smbus: Remove unneeded include

[Qemu-devel] [PATCH] smbus: Remove unneeded include

Posted by BALATON Zoltan 5 years, 3 months ago

The file no longer uses error_report after review so the header is not
needed either.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
Forgot to delete this when rewriting after review. This
can be squashed into 7713f5bed in dgibson/qemu/ppc-for-4.0

 hw/i2c/smbus_eeprom.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c
index bef24a1ca4..01b9439014 100644
--- a/hw/i2c/smbus_eeprom.c
+++ b/hw/i2c/smbus_eeprom.c
@@ -23,7 +23,6 @@
  */
 
 #include "qemu/osdep.h"
-#include "qemu/error-report.h"
 #include "qemu/units.h"
 #include "qapi/error.h"
 #include "hw/hw.h"
-- 
2.13.7

Re: [Qemu-devel] [PATCH] smbus: Remove unneeded include

Posted by Philippe Mathieu-Daudé 5 years, 3 months ago

On 1/12/19 2:32 AM, BALATON Zoltan wrote:
> The file no longer uses error_report after review so the header is not
> needed either.
> 
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
> Forgot to delete this when rewriting after review. This
> can be squashed into 7713f5bed in dgibson/qemu/ppc-for-4.0
> 
>  hw/i2c/smbus_eeprom.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c
> index bef24a1ca4..01b9439014 100644
> --- a/hw/i2c/smbus_eeprom.c
> +++ b/hw/i2c/smbus_eeprom.c
> @@ -23,7 +23,6 @@
>   */
>  
>  #include "qemu/osdep.h"
> -#include "qemu/error-report.h"
>  #include "qemu/units.h"
>  #include "qapi/error.h"
>  #include "hw/hw.h"
>

Re: [Qemu-devel] [Qemu-ppc] [PATCH] smbus: Remove unneeded include

Posted by Thomas Huth 5 years, 3 months ago

On 2019-01-12 02:32, BALATON Zoltan wrote:
> The file no longer uses error_report after review so the header is not
> needed either.
> 
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> Forgot to delete this when rewriting after review. This
> can be squashed into 7713f5bed in dgibson/qemu/ppc-for-4.0
> 
>  hw/i2c/smbus_eeprom.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c
> index bef24a1ca4..01b9439014 100644
> --- a/hw/i2c/smbus_eeprom.c
> +++ b/hw/i2c/smbus_eeprom.c
> @@ -23,7 +23,6 @@
>   */
>  
>  #include "qemu/osdep.h"
> -#include "qemu/error-report.h"
>  #include "qemu/units.h"
>  #include "qapi/error.h"
>  #include "hw/hw.h"
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>