qemu.py: Fix error message when qemu dies from signal

[Qemu-devel] [PATCH] qemu.py: Fix error message when qemu dies from signal

Posted by Eric Blake 6 years, 8 months ago

When qemu dies from a signal, the python code gets a negative
value for exitcode; but signal numbers are positive.  Copy the
pattern used in qemu-iotests/iotests.py for reporting a positive
value.

CC: qemu-trivial@nongnu.org
Signed-off-by: Eric Blake <eblake@redhat.com>
---
 scripts/qemu.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/qemu.py b/scripts/qemu.py
index 6e3b0e67719..0a5e02eb56e 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -351,7 +351,7 @@ class QEMUMachine(object):
                 command = ' '.join(self._qemu_full_args)
             else:
                 command = ''
-            LOG.warn(msg, exitcode, command)
+            LOG.warn(msg, -exitcode, command)

         self._launched = False

-- 
2.20.1

Re: [Qemu-devel] [PATCH] qemu.py: Fix error message when qemu dies from signal

Posted by Philippe Mathieu-Daudé 6 years, 8 months ago

Hi Eric,

On 1/11/19 9:13 PM, Eric Blake wrote:
> When qemu dies from a signal, the python code gets a negative
> value for exitcode; but signal numbers are positive.  Copy the
> pattern used in qemu-iotests/iotests.py for reporting a positive
> value.
> 
> CC: qemu-trivial@nongnu.org
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>  scripts/qemu.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/qemu.py b/scripts/qemu.py
> index 6e3b0e67719..0a5e02eb56e 100644
> --- a/scripts/qemu.py
> +++ b/scripts/qemu.py
> @@ -351,7 +351,7 @@ class QEMUMachine(object):
>                  command = ' '.join(self._qemu_full_args)
>              else:
>                  command = ''
> -            LOG.warn(msg, exitcode, command)
> +            LOG.warn(msg, -exitcode, command)

What about displaying signal name directly?

import signal

...

            msg = 'qemu received %s: %s'
            ...

            LOG.warn(msg, signal.Signals(-exitcode).name, command)

> 
>          self._launched = False
>

Re: [Qemu-devel] [PATCH] qemu.py: Fix error message when qemu dies from signal

Posted by Eric Blake 6 years, 8 months ago

On 1/14/19 5:04 AM, Philippe Mathieu-Daudé wrote:
> Hi Eric,
> 
> On 1/11/19 9:13 PM, Eric Blake wrote:
>> When qemu dies from a signal, the python code gets a negative
>> value for exitcode; but signal numbers are positive.  Copy the
>> pattern used in qemu-iotests/iotests.py for reporting a positive
>> value.
>>
>> CC: qemu-trivial@nongnu.org
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>> ---
>>  scripts/qemu.py | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/qemu.py b/scripts/qemu.py
>> index 6e3b0e67719..0a5e02eb56e 100644
>> --- a/scripts/qemu.py
>> +++ b/scripts/qemu.py
>> @@ -351,7 +351,7 @@ class QEMUMachine(object):
>>                  command = ' '.join(self._qemu_full_args)
>>              else:
>>                  command = ''
>> -            LOG.warn(msg, exitcode, command)
>> +            LOG.warn(msg, -exitcode, command)
> 
> What about displaying signal name directly?

If you want to do that, it should be a separate patch, and fix
iotests.py at the same time.


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH] qemu.py: Fix error message when qemu dies from signal

Posted by Philippe Mathieu-Daudé 6 years, 8 months ago

On 1/14/19 4:36 PM, Eric Blake wrote:
> On 1/14/19 5:04 AM, Philippe Mathieu-Daudé wrote:
>> Hi Eric,
>>
>> On 1/11/19 9:13 PM, Eric Blake wrote:
>>> When qemu dies from a signal, the python code gets a negative
>>> value for exitcode; but signal numbers are positive.  Copy the
>>> pattern used in qemu-iotests/iotests.py for reporting a positive
>>> value.
>>>
>>> CC: qemu-trivial@nongnu.org
>>> Signed-off-by: Eric Blake <eblake@redhat.com>
>>> ---
>>>  scripts/qemu.py | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/scripts/qemu.py b/scripts/qemu.py
>>> index 6e3b0e67719..0a5e02eb56e 100644
>>> --- a/scripts/qemu.py
>>> +++ b/scripts/qemu.py
>>> @@ -351,7 +351,7 @@ class QEMUMachine(object):
>>>                  command = ' '.join(self._qemu_full_args)
>>>              else:
>>>                  command = ''
>>> -            LOG.warn(msg, exitcode, command)
>>> +            LOG.warn(msg, -exitcode, command)
>>
>> What about displaying signal name directly?
> 
> If you want to do that, it should be a separate patch, and fix
> iotests.py at the same time.

Fair enough :)