[Qemu-devel] [PATCH v2 0/2] arm: Stub out NRF51 TWI magnetometer/accelerometer detection

Stefan Hajnoczi posted 2 patches 5 years, 3 months ago
Failed in applying to current master (apply log)
hw/i2c/Makefile.objs          |   1 +
include/hw/arm/nrf51.h        |   2 +
include/hw/arm/nrf51_soc.h    |   1 +
include/hw/i2c/microbit_i2c.h |  42 +++++++++++
hw/arm/microbit.c             |  15 ++++
hw/i2c/microbit_i2c.c         | 127 ++++++++++++++++++++++++++++++++++
tests/microbit-test.c         |  44 ++++++++++++
7 files changed, 232 insertions(+)
create mode 100644 include/hw/i2c/microbit_i2c.h
create mode 100644 hw/i2c/microbit_i2c.c
[Qemu-devel] [PATCH v2 0/2] arm: Stub out NRF51 TWI magnetometer/accelerometer detection
Posted by Stefan Hajnoczi 5 years, 3 months ago
v2:
 * Move stub code into a separate device [Peter]
 * Instantiate stub from microbit board instead of nRF51 SoC since this is
   microbit-specific.  Other boards using the nRF51 wouldn't necessarily want
   to see these TWI/I2C devices.
 * Add test case

This series stubs out the microbit's TWI/I2C devices so the microbit-dal
firmware boots successfully.  The accelerometer and magnetometer are probed at
startup.  If they are not found the firmware panics.

Stefan Hajnoczi (1):
  tests/microbit-test: add TWI stub device test

Steffen Görtz (1):
  arm: Stub out NRF51 TWI magnetometer/accelerometer detection

 hw/i2c/Makefile.objs          |   1 +
 include/hw/arm/nrf51.h        |   2 +
 include/hw/arm/nrf51_soc.h    |   1 +
 include/hw/i2c/microbit_i2c.h |  42 +++++++++++
 hw/arm/microbit.c             |  15 ++++
 hw/i2c/microbit_i2c.c         | 127 ++++++++++++++++++++++++++++++++++
 tests/microbit-test.c         |  44 ++++++++++++
 7 files changed, 232 insertions(+)
 create mode 100644 include/hw/i2c/microbit_i2c.h
 create mode 100644 hw/i2c/microbit_i2c.c

-- 
2.20.1


Re: [Qemu-devel] [PATCH v2 0/2] arm: Stub out NRF51 TWI magnetometer/accelerometer detection
Posted by Peter Maydell 5 years, 3 months ago
On Thu, 10 Jan 2019 at 09:40, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> v2:
>  * Move stub code into a separate device [Peter]
>  * Instantiate stub from microbit board instead of nRF51 SoC since this is
>    microbit-specific.  Other boards using the nRF51 wouldn't necessarily want
>    to see these TWI/I2C devices.
>  * Add test case
>
> This series stubs out the microbit's TWI/I2C devices so the microbit-dal
> firmware boots successfully.  The accelerometer and magnetometer are probed at
> startup.  If they are not found the firmware panics.
>
> Stefan Hajnoczi (1):
>   tests/microbit-test: add TWI stub device test
>
> Steffen Görtz (1):
>   arm: Stub out NRF51 TWI magnetometer/accelerometer detection
>
>  hw/i2c/Makefile.objs          |   1 +
>  include/hw/arm/nrf51.h        |   2 +
>  include/hw/arm/nrf51_soc.h    |   1 +
>  include/hw/i2c/microbit_i2c.h |  42 +++++++++++
>  hw/arm/microbit.c             |  15 ++++
>  hw/i2c/microbit_i2c.c         | 127 ++++++++++++++++++++++++++++++++++
>  tests/microbit-test.c         |  44 ++++++++++++
>  7 files changed, 232 insertions(+)
>  create mode 100644 include/hw/i2c/microbit_i2c.h
>  create mode 100644 hw/i2c/microbit_i2c.c

Applied to target-arm.next, thanks. Can you provide a
MAINTAINERS file update for the new files, please?
(You can send that separately or stick it in another
nrf51 series if you're sending one.)

thanks
-- PMM

Re: [Qemu-devel] [PATCH v2 0/2] arm: Stub out NRF51 TWI magnetometer/accelerometer detection
Posted by Stefan Hajnoczi 5 years, 3 months ago
On Mon, Jan 21, 2019 at 04:21:03PM +0000, Peter Maydell wrote:
> On Thu, 10 Jan 2019 at 09:40, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> >
> > v2:
> >  * Move stub code into a separate device [Peter]
> >  * Instantiate stub from microbit board instead of nRF51 SoC since this is
> >    microbit-specific.  Other boards using the nRF51 wouldn't necessarily want
> >    to see these TWI/I2C devices.
> >  * Add test case
> >
> > This series stubs out the microbit's TWI/I2C devices so the microbit-dal
> > firmware boots successfully.  The accelerometer and magnetometer are probed at
> > startup.  If they are not found the firmware panics.
> >
> > Stefan Hajnoczi (1):
> >   tests/microbit-test: add TWI stub device test
> >
> > Steffen Görtz (1):
> >   arm: Stub out NRF51 TWI magnetometer/accelerometer detection
> >
> >  hw/i2c/Makefile.objs          |   1 +
> >  include/hw/arm/nrf51.h        |   2 +
> >  include/hw/arm/nrf51_soc.h    |   1 +
> >  include/hw/i2c/microbit_i2c.h |  42 +++++++++++
> >  hw/arm/microbit.c             |  15 ++++
> >  hw/i2c/microbit_i2c.c         | 127 ++++++++++++++++++++++++++++++++++
> >  tests/microbit-test.c         |  44 ++++++++++++
> >  7 files changed, 232 insertions(+)
> >  create mode 100644 include/hw/i2c/microbit_i2c.h
> >  create mode 100644 hw/i2c/microbit_i2c.c
> 
> Applied to target-arm.next, thanks. Can you provide a
> MAINTAINERS file update for the new files, please?
> (You can send that separately or stick it in another
> nrf51 series if you're sending one.)

Sure, will do.

Stefan