Hi,

This is the current queue of fixes for our softfloat implementation. I
ended up taking Emilio's more complete dynamic probe approach for
broken FMA implementations (direct from git). There is also a fix for
the fp-bench. Finally a couple of patches to roll check-softfloat into
the main make system. It skips some f128 and extF80 float operations
which trigger faults but hopefully we can fix those up in a later
re-factor of the extended size floats.

The following patches need review
  patch 0003/softfloat enforce softfloat if the host s FMA is .patch
  patch 0004/tests Makefile add floating point tests.patch
  patch 0005/scripts archive source include softfloat tests.patch
  patch 0006/tests Makfile add check softfloat rule.patch

Alex Bennée (3):
  tests/Makefile: add floating point tests
  scripts/archive-source: include softfloat tests
  tests/Makfile: add check-softfloat rule

Emilio G. Cota (3):
  fp-bench: fix update_random_ops
  fp-bench: remove wrong exponent raise in fill_random
  softfloat: enforce softfloat if the host's FMA is broken

 fpu/softfloat.c           |  85 ++++++++++++++++++++++++
 include/qemu/cpuid.h      |   6 ++
 scripts/archive-source.sh |   2 +-
 tests/Makefile.include    | 132 +++++++++++++++++++++++++++++++++++++-
 tests/fp/fp-bench.c       |  15 +++--
 5 files changed, 230 insertions(+), 10 deletions(-)

-- 
2.17.1

Patchew URL: https://patchew.org/QEMU/20190108162154.22259-1-alex.bennee@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH  v1 0/6] current fpu/next queue
Message-id: 20190108162154.22259-1-alex.bennee@linaro.org

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
48a1465 tests/Makfile: add check-softfloat rule
283786b scripts/archive-source: include softfloat tests
4069cf6 tests/Makefile: add floating point tests
44b370e softfloat: enforce softfloat if the host's FMA is broken
a5a1840 fp-bench: remove wrong exponent raise in fill_random
f511a5c fp-bench: fix update_random_ops

=== OUTPUT BEGIN ===
Checking PATCH 1/6: fp-bench: fix update_random_ops...
Checking PATCH 2/6: fp-bench: remove wrong exponent raise in fill_random...
Checking PATCH 3/6: softfloat: enforce softfloat if the host's FMA is broken...
Checking PATCH 4/6: tests/Makefile: add floating point tests...
Checking PATCH 5/6: scripts/archive-source: include softfloat tests...
ERROR: line over 90 characters
#24: FILE: scripts/archive-source.sh:29:
+submodules="dtc ui/keycodemapdb tests/fp/berkeley-softfloat-3 tests/fp/berkeley-testfloat-3"

total: 1 errors, 0 warnings, 8 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/6: tests/Makfile: add check-softfloat rule...
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190108162154.22259-1-alex.bennee@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com