spice: Remove unused include

[Qemu-devel] [PATCH] spice: Remove unused include

Frediano Ziglio posted 1 patch 6 years, 10 months ago

Download mbox

Test checkpatch passed

Test asan passed

Test docker-mingw@fedora passed

Test docker-quick@centos7 passed

Test docker-clang@ubuntu passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190107184404.31993-1-fziglio@redhat.com

ui/spice-core.c | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] spice: Remove unused include

Posted by Frediano Ziglio 6 years, 10 months ago

The definitions in the header are not  used.
Also this fixes porting SPICE to Windows where the header is not
available.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
---
 ui/spice-core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ui/spice-core.c b/ui/spice-core.c
index 525e0929b9..fb87944a24 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -18,7 +18,6 @@
 #include "qemu/osdep.h"
 #include <spice.h>
 
-#include <netdb.h>
 #include "sysemu/sysemu.h"
 
 #include "ui/qemu-spice.h"
-- 
2.20.1

Re: [Qemu-devel] [PATCH] spice: Remove unused include

Posted by Philippe Mathieu-Daudé 6 years, 10 months ago

On 1/7/19 7:44 PM, Frediano Ziglio wrote:
> The definitions in the header are not  used.

Indeed, since e16f4c8770b.

> Also this fixes porting SPICE to Windows where the header is not
> available.
> 
> Signed-off-by: Frediano Ziglio <fziglio@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

(I might resend your patch in another series of mine)

> ---
>  ui/spice-core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/ui/spice-core.c b/ui/spice-core.c
> index 525e0929b9..fb87944a24 100644
> --- a/ui/spice-core.c
> +++ b/ui/spice-core.c
> @@ -18,7 +18,6 @@
>  #include "qemu/osdep.h"
>  #include <spice.h>
>  
> -#include <netdb.h>
>  #include "sysemu/sysemu.h"
>  
>  #include "ui/qemu-spice.h"
>

Re: [Qemu-devel] [PATCH] spice: Remove unused include

Posted by Gerd Hoffmann 6 years, 10 months ago

On Mon, Jan 07, 2019 at 06:44:04PM +0000, Frediano Ziglio wrote:
> The definitions in the header are not  used.
> Also this fixes porting SPICE to Windows where the header is not
> available.

Added to ui queue.

thanks,
  Gerd