1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PATCH] hw: pvrdma: fix memory leak in error path

Li Qiang posted 1 patch 6 years, 10 months ago
Test asan passed
Test checkpatch passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test docker-clang@ubuntu passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190103130338.49081-1-liq3ea@163.com
There is a newer version of this series
hw/rdma/vmw/pvrdma_qp_ops.c | 2 ++
1 file changed, 2 insertions(+)
[Qemu-devel] [PATCH] hw: pvrdma: fix memory leak in error path
Posted by Li Qiang 6 years, 10 months ago 
Spotted by Coverity: CID 1398595

Signed-off-by: Li Qiang <liq3ea@163.com>
---
 hw/rdma/vmw/pvrdma_qp_ops.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/rdma/vmw/pvrdma_qp_ops.c b/hw/rdma/vmw/pvrdma_qp_ops.c
index 300471a4c9..584be2043e 100644
--- a/hw/rdma/vmw/pvrdma_qp_ops.c
+++ b/hw/rdma/vmw/pvrdma_qp_ops.c
@@ -168,6 +168,7 @@ int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle)
         sgid = rdma_rm_get_gid(&dev->rdma_dev_res, wqe->hdr.wr.ud.av.gid_index);
         if (!sgid) {
             pr_dbg("Fail to get gid for idx %d\n", wqe->hdr.wr.ud.av.gid_index);
+            g_free(comp_ctx);
             return -EIO;
         }
         pr_dbg("sgid_id=%d, sgid=0x%llx\n", wqe->hdr.wr.ud.av.gid_index,
@@ -179,6 +180,7 @@ int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle)
         if (sgid_idx <= 0) {
             pr_dbg("Fail to get bk sgid_idx for sgid_idx %d\n",
                    wqe->hdr.wr.ud.av.gid_index);
+            g_free(comp_ctx);
             return -EIO;
         }
 
-- 
2.17.1
Re: [Qemu-devel] [PATCH] hw: pvrdma: fix memory leak in error path
Posted by Philippe Mathieu-Daudé 6 years, 10 months ago 
On 1/3/19 2:03 PM, Li Qiang wrote:
> Spotted by Coverity: CID 1398595
> 

Fixes: 2b05705dc8

> Signed-off-by: Li Qiang <liq3ea@163.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  hw/rdma/vmw/pvrdma_qp_ops.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/rdma/vmw/pvrdma_qp_ops.c b/hw/rdma/vmw/pvrdma_qp_ops.c
> index 300471a4c9..584be2043e 100644
> --- a/hw/rdma/vmw/pvrdma_qp_ops.c
> +++ b/hw/rdma/vmw/pvrdma_qp_ops.c
> @@ -168,6 +168,7 @@ int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle)
>          sgid = rdma_rm_get_gid(&dev->rdma_dev_res, wqe->hdr.wr.ud.av.gid_index);
>          if (!sgid) {
>              pr_dbg("Fail to get gid for idx %d\n", wqe->hdr.wr.ud.av.gid_index);
> +            g_free(comp_ctx);
>              return -EIO;
>          }
>          pr_dbg("sgid_id=%d, sgid=0x%llx\n", wqe->hdr.wr.ud.av.gid_index,
> @@ -179,6 +180,7 @@ int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle)
>          if (sgid_idx <= 0) {
>              pr_dbg("Fail to get bk sgid_idx for sgid_idx %d\n",
>                     wqe->hdr.wr.ud.av.gid_index);
> +            g_free(comp_ctx);
>              return -EIO;
>          }
>  
>
Re: [Qemu-devel] [PATCH] hw: pvrdma: fix memory leak in error path
Posted by Yuval Shaia 6 years, 10 months ago 
On Thu, Jan 03, 2019 at 02:47:37PM +0100, Philippe Mathieu-Daudé wrote:
> On 1/3/19 2:03 PM, Li Qiang wrote:
> > Spotted by Coverity: CID 1398595
> > 
> 
> Fixes: 2b05705dc8
> 
> > Signed-off-by: Li Qiang <liq3ea@163.com>
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> 
> > ---
> >  hw/rdma/vmw/pvrdma_qp_ops.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/hw/rdma/vmw/pvrdma_qp_ops.c b/hw/rdma/vmw/pvrdma_qp_ops.c
> > index 300471a4c9..584be2043e 100644
> > --- a/hw/rdma/vmw/pvrdma_qp_ops.c
> > +++ b/hw/rdma/vmw/pvrdma_qp_ops.c
> > @@ -168,6 +168,7 @@ int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle)
> >          sgid = rdma_rm_get_gid(&dev->rdma_dev_res, wqe->hdr.wr.ud.av.gid_index);
> >          if (!sgid) {
> >              pr_dbg("Fail to get gid for idx %d\n", wqe->hdr.wr.ud.av.gid_index);
> > +            g_free(comp_ctx);
> >              return -EIO;
> >          }
> >          pr_dbg("sgid_id=%d, sgid=0x%llx\n", wqe->hdr.wr.ud.av.gid_index,
> > @@ -179,6 +180,7 @@ int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle)
> >          if (sgid_idx <= 0) {
> >              pr_dbg("Fail to get bk sgid_idx for sgid_idx %d\n",
> >                     wqe->hdr.wr.ud.av.gid_index);
> > +            g_free(comp_ctx);
> >              return -EIO;
> >          }

Since comp_ctx is not used until the two checks are done we just can
relocate the allocation & initialization right after the two checks.

Yuval

> >  
> >
Re: [Qemu-devel] [PATCH] hw: pvrdma: fix memory leak in error path
Posted by 李强 6 years, 10 months ago 
At 2019-01-08 00:26:58, "Yuval Shaia" <yuval.shaia@oracle.com> wrote:
>On Thu, Jan 03, 2019 at 02:47:37PM +0100, Philippe Mathieu-Daudé wrote:
>> On 1/3/19 2:03 PM, Li Qiang wrote:
>> > Spotted by Coverity: CID 1398595
>> > 
>> 
>> Fixes: 2b05705dc8
>> 
>> > Signed-off-by: Li Qiang <liq3ea@163.com>
>> 
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> 
>> > ---
>> >  hw/rdma/vmw/pvrdma_qp_ops.c | 2 ++
>> >  1 file changed, 2 insertions(+)
>> > 
>> > diff --git a/hw/rdma/vmw/pvrdma_qp_ops.c b/hw/rdma/vmw/pvrdma_qp_ops.c
>> > index 300471a4c9..584be2043e 100644
>> > --- a/hw/rdma/vmw/pvrdma_qp_ops.c
>> > +++ b/hw/rdma/vmw/pvrdma_qp_ops.c
>> > @@ -168,6 +168,7 @@ int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle)
>> >          sgid = rdma_rm_get_gid(&dev->rdma_dev_res, wqe->hdr.wr.ud.av.gid_index);
>> >          if (!sgid) {
>> >              pr_dbg("Fail to get gid for idx %d\n", wqe->hdr.wr.ud.av.gid_index);
>> > +            g_free(comp_ctx);
>> >              return -EIO;
>> >          }
>> >          pr_dbg("sgid_id=%d, sgid=0x%llx\n", wqe->hdr.wr.ud.av.gid_index,
>> > @@ -179,6 +180,7 @@ int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle)
>> >          if (sgid_idx <= 0) {
>> >              pr_dbg("Fail to get bk sgid_idx for sgid_idx %d\n",
>> >                     wqe->hdr.wr.ud.av.gid_index);
>> > +            g_free(comp_ctx);
>> >              return -EIO;
>> >          }
>
>Since comp_ctx is not used until the two checks are done we just can
>relocate the allocation & initialization right after the two checks.

>


OK, will send a revised version later.


Thanks,
Li Qiang


>Yuval
>
>> >  
>> >
Re: [Qemu-devel] [PATCH] hw: pvrdma: fix memory leak in error path
Posted by Philippe Mathieu-Daudé 6 years, 10 months ago 
On 1/7/19 5:26 PM, Yuval Shaia wrote:
> On Thu, Jan 03, 2019 at 02:47:37PM +0100, Philippe Mathieu-Daudé wrote:
>> On 1/3/19 2:03 PM, Li Qiang wrote:
>>> Spotted by Coverity: CID 1398595
>>>
>>
>> Fixes: 2b05705dc8
>>
>>> Signed-off-by: Li Qiang <liq3ea@163.com>
>>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>
>>> ---
>>>  hw/rdma/vmw/pvrdma_qp_ops.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/hw/rdma/vmw/pvrdma_qp_ops.c b/hw/rdma/vmw/pvrdma_qp_ops.c
>>> index 300471a4c9..584be2043e 100644
>>> --- a/hw/rdma/vmw/pvrdma_qp_ops.c
>>> +++ b/hw/rdma/vmw/pvrdma_qp_ops.c
>>> @@ -168,6 +168,7 @@ int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle)
>>>          sgid = rdma_rm_get_gid(&dev->rdma_dev_res, wqe->hdr.wr.ud.av.gid_index);
>>>          if (!sgid) {
>>>              pr_dbg("Fail to get gid for idx %d\n", wqe->hdr.wr.ud.av.gid_index);
>>> +            g_free(comp_ctx);
>>>              return -EIO;
>>>          }
>>>          pr_dbg("sgid_id=%d, sgid=0x%llx\n", wqe->hdr.wr.ud.av.gid_index,
>>> @@ -179,6 +180,7 @@ int pvrdma_qp_send(PVRDMADev *dev, uint32_t qp_handle)
>>>          if (sgid_idx <= 0) {
>>>              pr_dbg("Fail to get bk sgid_idx for sgid_idx %d\n",
>>>                     wqe->hdr.wr.ud.av.gid_index);
>>> +            g_free(comp_ctx);
>>>              return -EIO;
>>>          }
> 
> Since comp_ctx is not used until the two checks are done we just can
> relocate the allocation & initialization right after the two checks.

Oops I missed this, thanks your suggestion is way cleaner!

Phil.

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.