[v3] dmg: fixing reading in dmg

[Qemu-devel] [PATCH v3 0/3] dmg: fixing reading in dmg

yuchenlin posted 3 patches 6 years, 10 months ago

Diff against v2
Download series mbox

Test checkpatch passed

Test docker-mingw@fedora passed

Test asan passed

Test docker-quick@centos7 passed

Test docker-clang@ubuntu passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20190103114700.9686-1-npes87184@gmail.com

block/dmg.c | 29 +++++++++++++++++++----------
1 file changed, 19 insertions(+), 10 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v3 0/3] dmg: fixing reading in dmg

Posted by yuchenlin 6 years, 10 months ago

There are two bugs in dmg reading.

First, it may hang in binary search. this problem is solved by patch 1.
Second, because of lacking zero chunk table, reading zero sector will
return EIO. this problem is solved by patch 2 and 3.

Thanks

v2 -> v3:
* fix potential overflow (Thanks Stefan)
* add Reviewed tag in patch 2 and 3

v1 -> v2:
* fix typos in patch 1
* add patch 2 and patch 3

yuchenlin (3):
  dmg: fix binary search
  dmg: use enumeration type instead of hard coding number
  dmg: don't skip zero chunk

 block/dmg.c | 29 +++++++++++++++++++----------
 1 file changed, 19 insertions(+), 10 deletions(-)

-- 
2.17.1

Re: [Qemu-devel] [PATCH v3 0/3] dmg: fixing reading in dmg

Posted by Stefan Hajnoczi 6 years, 10 months ago

On Thu, Jan 03, 2019 at 07:46:57PM +0800, yuchenlin wrote:
> There are two bugs in dmg reading.
> 
> First, it may hang in binary search. this problem is solved by patch 1.
> Second, because of lacking zero chunk table, reading zero sector will
> return EIO. this problem is solved by patch 2 and 3.
> 
> Thanks
> 
> v2 -> v3:
> * fix potential overflow (Thanks Stefan)
> * add Reviewed tag in patch 2 and 3
> 
> v1 -> v2:
> * fix typos in patch 1
> * add patch 2 and patch 3
> 
> yuchenlin (3):
>   dmg: fix binary search
>   dmg: use enumeration type instead of hard coding number
>   dmg: don't skip zero chunk
> 
>  block/dmg.c | 29 +++++++++++++++++++----------
>  1 file changed, 19 insertions(+), 10 deletions(-)
> 
> -- 
> 2.17.1
> 

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan