qom: Include qemu/fprintf-fn.h in cpu.h

[Qemu-devel] [PATCH] qom: Include qemu/fprintf-fn.h in cpu.h

Priit Laes posted 1 patch 6 years, 10 months ago

Download mbox

Test asan passed

Test checkpatch passed

Test docker-mingw@fedora passed

Test docker-quick@centos7 passed

Test docker-clang@ubuntu passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181226003722.31257-1-plaes@plaes.org

include/qom/cpu.h | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[Qemu-devel] [PATCH] qom: Include qemu/fprintf-fn.h in cpu.h

Posted by Priit Laes 6 years, 10 months ago

QOM cpu.h uses fprintf_function which requires Qemu's
qemu/fprintf-fn.h header. Include it.

Signed-off-by: Priit Laes <plaes@plaes.org>
---
 include/qom/cpu.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/qom/cpu.h b/include/qom/cpu.h
index 1396f53e5b..6d1ba53d72 100644
--- a/include/qom/cpu.h
+++ b/include/qom/cpu.h
@@ -26,6 +26,7 @@
 #include "exec/memattrs.h"
 #include "qapi/qapi-types-run-state.h"
 #include "qemu/bitmap.h"
+#include "qemu/fprintf-fn.h"
 #include "qemu/rcu_queue.h"
 #include "qemu/queue.h"
 #include "qemu/thread.h"
-- 
2.20.1

Re: [Qemu-devel] [PATCH] qom: Include qemu/fprintf-fn.h in cpu.h

Posted by Philippe Mathieu-Daudé 6 years, 10 months ago

On 12/26/18 1:37 AM, Priit Laes wrote:
> QOM cpu.h uses fprintf_function which requires Qemu's
> qemu/fprintf-fn.h header. Include it.
> 
> Signed-off-by: Priit Laes <plaes@plaes.org>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  include/qom/cpu.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/qom/cpu.h b/include/qom/cpu.h
> index 1396f53e5b..6d1ba53d72 100644
> --- a/include/qom/cpu.h
> +++ b/include/qom/cpu.h
> @@ -26,6 +26,7 @@
>  #include "exec/memattrs.h"
>  #include "qapi/qapi-types-run-state.h"
>  #include "qemu/bitmap.h"
> +#include "qemu/fprintf-fn.h"
>  #include "qemu/rcu_queue.h"
>  #include "qemu/queue.h"
>  #include "qemu/thread.h"
>

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qom: Include qemu/fprintf-fn.h in cpu.h

Posted by Laurent Vivier 6 years, 10 months ago

On 26/12/2018 01:37, Priit Laes wrote:
> QOM cpu.h uses fprintf_function which requires Qemu's
> qemu/fprintf-fn.h header. Include it.
> 
> Signed-off-by: Priit Laes <plaes@plaes.org>
> ---
>  include/qom/cpu.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/qom/cpu.h b/include/qom/cpu.h
> index 1396f53e5b..6d1ba53d72 100644
> --- a/include/qom/cpu.h
> +++ b/include/qom/cpu.h
> @@ -26,6 +26,7 @@
>  #include "exec/memattrs.h"
>  #include "qapi/qapi-types-run-state.h"
>  #include "qemu/bitmap.h"
> +#include "qemu/fprintf-fn.h"
>  #include "qemu/rcu_queue.h"
>  #include "qemu/queue.h"
>  #include "qemu/thread.h"
> 

Applied to my trivial-patches branch.

Thanks,
Laurent