[Qemu-devel] [RFC PATCH v2 0/7] ui: add generic keyboard state tracker, fix keymap

Gerd Hoffmann posted 7 patches 5 years, 4 months ago
Test checkpatch passed
Test asan passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 failed
Test docker-clang@ubuntu passed
Failed in applying to current master (apply log)
There is a newer version of this series
include/ui/gtk.h       |   2 +
include/ui/kbd-state.h |  32 +++++++++++++
include/ui/sdl2.h      |   2 +
ui/keymaps.h           |   3 +-
ui/vnc.h               |   5 +-
ui/curses.c            |   2 +-
ui/gtk.c               |  38 +++------------
ui/kbd-state.c         | 125 +++++++++++++++++++++++++++++++++++++++++++++++++
ui/keymaps.c           |  55 +++++++++++++---------
ui/sdl2-input.c        |  47 +++----------------
ui/sdl2.c              |  12 ++---
ui/vnc.c               | 119 ++++++++++++----------------------------------
ui/Makefile.objs       |   2 +-
13 files changed, 247 insertions(+), 197 deletions(-)
create mode 100644 include/ui/kbd-state.h
create mode 100644 ui/kbd-state.c
[Qemu-devel] [RFC PATCH v2 0/7] ui: add generic keyboard state tracker, fix keymap
Posted by Gerd Hoffmann 5 years, 4 months ago

Gerd Hoffmann (7):
  kbd-state: add keyboard state tracker
  kbd-state: use state tracker for sdl2
  sdl2: use only QKeyCode in sdl2_process_key()
  kbd-state: use state tracker for gtk
  kbd-state: use state tracker for vnc
  keymap: pass full keyboard state to keysym2scancode
  keymap: fix keyup mappings

 include/ui/gtk.h       |   2 +
 include/ui/kbd-state.h |  32 +++++++++++++
 include/ui/sdl2.h      |   2 +
 ui/keymaps.h           |   3 +-
 ui/vnc.h               |   5 +-
 ui/curses.c            |   2 +-
 ui/gtk.c               |  38 +++------------
 ui/kbd-state.c         | 125 +++++++++++++++++++++++++++++++++++++++++++++++++
 ui/keymaps.c           |  55 +++++++++++++---------
 ui/sdl2-input.c        |  47 +++----------------
 ui/sdl2.c              |  12 ++---
 ui/vnc.c               | 119 ++++++++++++----------------------------------
 ui/Makefile.objs       |   2 +-
 13 files changed, 247 insertions(+), 197 deletions(-)
 create mode 100644 include/ui/kbd-state.h
 create mode 100644 ui/kbd-state.c

-- 
2.9.3


Re: [Qemu-devel] [RFC PATCH v2 0/7] ui: add generic keyboard state tracker, fix keymap
Posted by no-reply@patchew.org 5 years, 4 months ago
Patchew URL: https://patchew.org/QEMU/20181219120904.17643-1-kraxel@redhat.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-quick@centos7 SHOW_ENV=1 J=8
=== TEST SCRIPT END ===

libpmem support   no
libudev           no

WARNING: Use of SDL 1.2 is deprecated and will be removed in
WARNING: future releases. Please switch to using SDL 2.0

NOTE: cross-compilers enabled:  'cc'
  GEN     x86_64-softmmu/config-devices.mak.tmp
---
  CC      chardev/char.o
  CC      chardev/char-fd.o
/tmp/qemu-test/src/ui/sdl.c: In function 'sdl_keyevent_to_keycode_generic':
/tmp/qemu-test/src/ui/sdl.c:218:28: error: incompatible type for argument 3 of 'keysym2scancode'
                            shift, altgr, ctrl) & SCANCODE_KEYMASK;
                            ^
In file included from /tmp/qemu-test/src/ui/sdl_keysym.h:2:0,
---
/tmp/qemu-test/src/ui/keymaps.h:58:5: note: expected 'struct KbdState *' but argument is of type '_Bool'
 int keysym2scancode(kbd_layout_t *k, int keysym,
     ^
/tmp/qemu-test/src/ui/sdl.c:218:28: error: too many arguments to function 'keysym2scancode'
                            shift, altgr, ctrl) & SCANCODE_KEYMASK;
                            ^
In file included from /tmp/qemu-test/src/ui/sdl_keysym.h:2:0,


The full log is available at
http://patchew.org/logs/20181219120904.17643-1-kraxel@redhat.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com