This is a counter-proposal to Vladimir's initial post for
reducing the noise in iotest 083.  The difference is that
I dropped error_get_hint, since I couldn't find any useful
hint to be traced during transmission phase in the first place,
and instead added a trace message for the one place where we
do set hints during handshaking phase.

Eric Blake (1):
  nbd/client: Trace all server option error messages

Vladimir Sementsov-Ogievskiy (2):
  nbd: publish _lookup functions
  block/nbd-client: use traces instead of noisy error_report_err

 include/block/nbd.h        |  5 +++++
 nbd/nbd-internal.h         |  5 -----
 block/nbd-client.c         | 23 +++++++++++++++++++----
 nbd/client.c               |  2 ++
 block/trace-events         |  4 ++++
 nbd/trace-events           |  1 +
 tests/qemu-iotests/083.out | 28 ----------------------------
 7 files changed, 31 insertions(+), 37 deletions(-)

-- 
2.17.2

19.12.2018 1:57, Eric Blake wrote:
> This is a counter-proposal to Vladimir's initial post for
> reducing the noise in iotest 083.  The difference is that
> I dropped error_get_hint, since I couldn't find any useful
> hint to be traced during transmission phase in the first place,
> and instead added a trace message for the one place where we
> do set hints during handshaking phase.

OK, agree with the idea.

> 
> Eric Blake (1):
>    nbd/client: Trace all server option error messages
> 
> Vladimir Sementsov-Ogievskiy (2):
>    nbd: publish _lookup functions
>    block/nbd-client: use traces instead of noisy error_report_err
> 
>   include/block/nbd.h        |  5 +++++
>   nbd/nbd-internal.h         |  5 -----
>   block/nbd-client.c         | 23 +++++++++++++++++++----
>   nbd/client.c               |  2 ++
>   block/trace-events         |  4 ++++
>   nbd/trace-events           |  1 +
>   tests/qemu-iotests/083.out | 28 ----------------------------
>   7 files changed, 31 insertions(+), 37 deletions(-)
> 


-- 
Best regards,
Vladimir

On 12/19/18 6:03 AM, Vladimir Sementsov-Ogievskiy wrote:
> 19.12.2018 1:57, Eric Blake wrote:
>> This is a counter-proposal to Vladimir's initial post for
>> reducing the noise in iotest 083.  The difference is that
>> I dropped error_get_hint, since I couldn't find any useful
>> hint to be traced during transmission phase in the first place,
>> and instead added a trace message for the one place where we
>> do set hints during handshaking phase.
> 
> OK, agree with the idea.

Thanks. I'll queue this one through my NBD tree and send a pull request 
soon (although depending on timing, Peter might not apply it until 
January...)

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org