[Qemu-devel] [PATCH 0/3] Fix & improve icon display on GTK and SDL frontends

Daniel P. Berrangé posted 3 patches 6 years, 10 months ago
Test checkpatch passed
Test asan failed
Test docker-mingw@fedora failed
Test docker-quick@centos7 passed
Test docker-clang@ubuntu failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181218142629.15943-1-berrange@redhat.com
There is a newer version of this series
Makefile                                      |  16 ++++++++++-
configure                                     |  27 ++++++++++++++++++
include/ui/sdl2.h                             |   3 ++
ui/gtk.c                                      |  18 ++++--------
.../icons/qemu.svg                            |   0
ui/icons/qemu_128x128.png                     | Bin 0 -> 7761 bytes
ui/icons/qemu_16x16.png                       | Bin 0 -> 751 bytes
ui/icons/qemu_24x24.png                       | Bin 0 -> 1167 bytes
ui/icons/qemu_256x256.png                     | Bin 0 -> 16216 bytes
.../qemu-icon.bmp => ui/icons/qemu_32x32.bmp  | Bin
ui/icons/qemu_32x32.png                       | Bin 0 -> 1656 bytes
ui/icons/qemu_48x48.png                       | Bin 0 -> 2604 bytes
ui/icons/qemu_512x512.png                     | Bin 0 -> 34609 bytes
ui/icons/qemu_64x64.png                       | Bin 0 -> 3588 bytes
ui/qemu.desktop                               |   8 ++++++
ui/sdl2.c                                     |  22 +++++++-------
16 files changed, 71 insertions(+), 23 deletions(-)
rename pc-bios/qemu_logo_no_text.svg => ui/icons/qemu.svg (100%)
create mode 100644 ui/icons/qemu_128x128.png
create mode 100644 ui/icons/qemu_16x16.png
create mode 100644 ui/icons/qemu_24x24.png
create mode 100644 ui/icons/qemu_256x256.png
rename pc-bios/qemu-icon.bmp => ui/icons/qemu_32x32.bmp (100%)
create mode 100644 ui/icons/qemu_32x32.png
create mode 100644 ui/icons/qemu_48x48.png
create mode 100644 ui/icons/qemu_512x512.png
create mode 100644 ui/icons/qemu_64x64.png
create mode 100644 ui/qemu.desktop
[Qemu-devel] [PATCH 0/3] Fix & improve icon display on GTK and SDL frontends
Posted by Daniel P. Berrangé 6 years, 10 months ago
This series improves the GTK and SDL frontends so that they display the
high quality QEMU logo.

Daniel P. Berrangé (3):
  ui: install logo icons to $prefix/share/icons
  ui: fix icon display for GTK frontend under GNOME Shell with Wayland
  sdl: add support for high resolution window icon

 Makefile                                      |  16 ++++++++++-
 configure                                     |  27 ++++++++++++++++++
 include/ui/sdl2.h                             |   3 ++
 ui/gtk.c                                      |  18 ++++--------
 .../icons/qemu.svg                            |   0
 ui/icons/qemu_128x128.png                     | Bin 0 -> 7761 bytes
 ui/icons/qemu_16x16.png                       | Bin 0 -> 751 bytes
 ui/icons/qemu_24x24.png                       | Bin 0 -> 1167 bytes
 ui/icons/qemu_256x256.png                     | Bin 0 -> 16216 bytes
 .../qemu-icon.bmp => ui/icons/qemu_32x32.bmp  | Bin
 ui/icons/qemu_32x32.png                       | Bin 0 -> 1656 bytes
 ui/icons/qemu_48x48.png                       | Bin 0 -> 2604 bytes
 ui/icons/qemu_512x512.png                     | Bin 0 -> 34609 bytes
 ui/icons/qemu_64x64.png                       | Bin 0 -> 3588 bytes
 ui/qemu.desktop                               |   8 ++++++
 ui/sdl2.c                                     |  22 +++++++-------
 16 files changed, 71 insertions(+), 23 deletions(-)
 rename pc-bios/qemu_logo_no_text.svg => ui/icons/qemu.svg (100%)
 create mode 100644 ui/icons/qemu_128x128.png
 create mode 100644 ui/icons/qemu_16x16.png
 create mode 100644 ui/icons/qemu_24x24.png
 create mode 100644 ui/icons/qemu_256x256.png
 rename pc-bios/qemu-icon.bmp => ui/icons/qemu_32x32.bmp (100%)
 create mode 100644 ui/icons/qemu_32x32.png
 create mode 100644 ui/icons/qemu_48x48.png
 create mode 100644 ui/icons/qemu_512x512.png
 create mode 100644 ui/icons/qemu_64x64.png
 create mode 100644 ui/qemu.desktop

-- 
2.19.2


Re: [Qemu-devel] [PATCH 0/3] Fix & improve icon display on GTK and SDL frontends
Posted by no-reply@patchew.org 6 years, 10 months ago
Patchew URL: https://patchew.org/QEMU/20181218142629.15943-1-berrange@redhat.com/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-mingw@fedora SHOW_ENV=1 J=8
=== TEST SCRIPT END ===

  CC      chardev/char-serial.o
  CC      chardev/char-socket.o
/tmp/qemu-test/src/ui/sdl2.c: In function 'sdl2_display_init':
/tmp/qemu-test/src/ui/sdl2.c:847:40: error: 'image' undeclared (first use in this function)
         uint32_t colorkey = SDL_MapRGB(image->format, 255, 255, 255);
                                        ^~~~~
/tmp/qemu-test/src/ui/sdl2.c:847:40: note: each undeclared identifier is reported only once for each function it appears in


The full log is available at
http://patchew.org/logs/20181218142629.15943-1-berrange@redhat.com/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com