[Qemu-devel] [PATCH v5 0/2] range/memory-device: fixes and cleanups

David Hildenbrand posted 2 patches 6 years, 10 months ago
Test checkpatch passed
Test asan passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test docker-clang@ubuntu passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181214131043.25071-1-david@redhat.com
hw/mem/memory-device.c | 51 +++++++++++++++++-----------------
include/qemu/range.h   | 62 ++++++++++++++++++++++++++++++++++++++++++
2 files changed, 88 insertions(+), 25 deletions(-)
[Qemu-devel] [PATCH v5 0/2] range/memory-device: fixes and cleanups
Posted by David Hildenbrand 6 years, 10 months ago
These are the two leftovers from
    [PATCH v3 0/7] qapi/range/memory-device: fixes and cleanups

The remaining patches extent the QEMU range code and rewrite
memory-device code to make use of it.

v34 -> v5:
- "memory-device: rewrite address assignment using ranges"
-- Squash to error pathes that resulted in the same error message

v3 -> v4:
- "memory-device: rewrite address assignment using ranges"
-- Use better error messages
-- Fix one theretical overflow

David Hildenbrand (2):
  range: add some more functions
  memory-device: rewrite address assignment using ranges

 hw/mem/memory-device.c | 51 +++++++++++++++++-----------------
 include/qemu/range.h   | 62 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 88 insertions(+), 25 deletions(-)

-- 
2.17.2


Re: [Qemu-devel] [PATCH v5 0/2] range/memory-device: fixes and cleanups
Posted by Michael S. Tsirkin 6 years, 10 months ago
On Fri, Dec 14, 2018 at 02:10:41PM +0100, David Hildenbrand wrote:
> These are the two leftovers from
>     [PATCH v3 0/7] qapi/range/memory-device: fixes and cleanups

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

Who's merging this Eduardo?

> The remaining patches extent the QEMU range code and rewrite
> memory-device code to make use of it.
> 
> v34 -> v5:
> - "memory-device: rewrite address assignment using ranges"
> -- Squash to error pathes that resulted in the same error message
> 
> v3 -> v4:
> - "memory-device: rewrite address assignment using ranges"
> -- Use better error messages
> -- Fix one theretical overflow
> 
> David Hildenbrand (2):
>   range: add some more functions
>   memory-device: rewrite address assignment using ranges
> 
>  hw/mem/memory-device.c | 51 +++++++++++++++++-----------------
>  include/qemu/range.h   | 62 ++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 88 insertions(+), 25 deletions(-)
> 
> -- 
> 2.17.2

Re: [Qemu-devel] [PATCH v5 0/2] range/memory-device: fixes and cleanups
Posted by Eduardo Habkost 6 years, 10 months ago
On Mon, Dec 17, 2018 at 10:28:58AM -0500, Michael S. Tsirkin wrote:
> On Fri, Dec 14, 2018 at 02:10:41PM +0100, David Hildenbrand wrote:
> > These are the two leftovers from
> >     [PATCH v3 0/7] qapi/range/memory-device: fixes and cleanups
> 
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> 
> Who's merging this Eduardo?

As I have merged memory-device cleanups before, I can merge it,
despite MAINTAINERS listing hw/mem/* as part of the ACPI/SMBIOS
section.  What do you prefer?

-- 
Eduardo

Re: [Qemu-devel] [PATCH v5 0/2] range/memory-device: fixes and cleanups
Posted by Michael S. Tsirkin 6 years, 10 months ago
On Mon, Dec 17, 2018 at 09:06:24PM -0200, Eduardo Habkost wrote:
> On Mon, Dec 17, 2018 at 10:28:58AM -0500, Michael S. Tsirkin wrote:
> > On Fri, Dec 14, 2018 at 02:10:41PM +0100, David Hildenbrand wrote:
> > > These are the two leftovers from
> > >     [PATCH v3 0/7] qapi/range/memory-device: fixes and cleanups
> > 
> > Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> > 
> > Who's merging this Eduardo?
> 
> As I have merged memory-device cleanups before, I can merge it,
> despite MAINTAINERS listing hw/mem/* as part of the ACPI/SMBIOS
> section.  What do you prefer?

Pls go ahead.

> -- 
> Eduardo