block/bochs.c | 22 ++--- block/file-posix.c | 2 +- block/file-win32.c | 8 +- block/linux-aio.c | 4 +- block/qcow2-cluster.c | 2 +- block/vpc.c | 2 +- bsd-user/elfload.c | 2 +- bsd-user/x86_64/target_syscall.h | 2 +- contrib/elf2dmp/main.c | 2 +- crypto/aes.c | 28 +++---- disas/alpha.c | 8 +- disas/arm.c | 2 +- disas/i386.c | 4 +- disas/m68k.c | 4 +- hw/alpha/typhoon.c | 12 +-- hw/arm/stellaris.c | 2 +- hw/arm/virt.c | 2 +- hw/char/sh_serial.c | 18 ++--- hw/char/virtio-serial-bus.c | 2 +- hw/char/xen_console.c | 58 ++++++------- hw/core/loader.c | 28 +++---- hw/display/tc6393xb.c | 6 +- hw/display/vga.c | 8 +- hw/display/virtio-gpu-3d.c | 6 +- hw/dma/pxa2xx_dma.c | 4 +- hw/dma/soc_dma.c | 2 +- hw/gpio/max7310.c | 2 +- hw/i386/xen/xen-hvm.c | 4 +- hw/ide/core.c | 94 +++++++++++----------- hw/input/lm832x.c | 2 +- hw/input/pckbd.c | 2 +- hw/input/tsc210x.c | 2 +- hw/intc/apic.c | 2 +- hw/mips/gt64xxx_pci.c | 6 +- hw/mips/mips_r4k.c | 4 +- hw/misc/max111x.c | 6 +- hw/misc/omap_l4.c | 4 +- hw/net/mipsnet.c | 16 ++-- hw/net/ne2000.c | 44 +++++----- hw/net/rocker/rocker.c | 2 +- hw/net/virtio-net.c | 4 +- hw/net/vmxnet3.c | 6 +- hw/pci/msix.c | 2 +- hw/pci/pci.c | 44 +++++----- hw/pci/pci_bridge.c | 2 +- hw/ppc/ppc405_uc.c | 2 +- hw/ppc/prep.c | 4 +- hw/scsi/lsi53c895a.c | 6 +- hw/sh4/r2d.c | 16 ++-- hw/usb/dev-bluetooth.c | 2 +- hw/usb/dev-hid.c | 6 +- hw/usb/dev-hub.c | 14 ++-- hw/usb/hcd-uhci.c | 4 +- hw/xen/xen_devconfig.c | 2 +- hw/xenpv/xen_domainbuild.c | 8 +- include/elf.h | 10 +-- include/hw/acpi/acpi.h | 14 ++-- include/hw/elf_ops.h | 2 +- include/hw/ide/internal.h | 2 +- include/hw/sh4/sh_intc.h | 20 ++--- include/hw/xen/io/ring.h | 4 +- include/qemu/acl.h | 14 ++-- include/qemu/iov.h | 2 +- include/scsi/constants.h | 2 +- include/sysemu/balloon.h | 2 +- linux-user/linuxload.c | 14 ++-- linux-user/main.c | 4 +- linux-user/mmap.c | 10 +-- linux-user/qemu.h | 4 +- linux-user/signal.c | 16 ++-- linux-user/strace.c | 4 +- linux-user/syscall.c | 2 +- linux-user/syscall_defs.h | 4 +- linux-user/uaccess.c | 2 +- linux-user/vm86.c | 2 +- linux-user/x86_64/target_syscall.h | 2 +- nbd/client.c | 2 +- net/checksum.c | 2 +- qtest.c | 4 +- slirp/ip_input.c | 4 +- slirp/tcp_input.c | 10 +-- slirp/tcp_output.c | 4 +- slirp/tcp_timer.c | 2 +- slirp/udp.c | 2 +- target/alpha/translate.c | 2 +- target/cris/helper.c | 2 +- target/cris/mmu.h | 10 +-- target/cris/translate_v10.inc.c | 2 +- target/i386/translate.c | 12 +-- target/mips/translate.c | 2 +- target/tilegx/translate.c | 2 +- tcg/i386/tcg-target.inc.c | 4 +- tests/tcg/alpha/test-cond.c | 4 +- tests/tcg/arm/hello-arm.c | 20 ++--- tests/tcg/cris/check_glibc_kernelversion.c | 8 +- tests/tcg/cris/check_mmap3.c | 2 +- tests/tcg/cris/check_openpf1.c | 2 +- tests/tcg/cris/check_settls1.c | 2 +- tests/tcg/i386/hello-i386.c | 14 ++-- tests/tcg/mips/hello-mips.c | 10 +-- tests/tcg/multiarch/sha1.c | 12 +-- tests/vhost-user-test.c | 4 +- ui/keymaps.h | 4 +- ui/qemu-pixman.c | 2 +- ui/vnc-enc-zywrle-template.c | 4 +- ui/vnc.c | 4 +- util/bitops.c | 4 +- util/osdep.c | 4 +- util/qemu-sockets.c | 4 +- 109 files changed, 429 insertions(+), 429 deletions(-)
Space-tab sequences at the beginning of the line are always a mistake, so patch 1 fixes them. I am not touching space-tab in the middle of the line, many of which are in #define lines. In addition, about a third of the files with TABs have only a few of them and it's worth converting them for consistency. Of the files touched by patch 2, hw/ide/core.c is the worst in absolute terms, with over 50 occurrences in a 3000 lines file; hw/char/xen_console.c has about a third TABs and two-thirds spaces but it is small so I included it. The files were selected by hand starting from a list of .c and .h files in the tree, sorted by number of occurrences. I left out files that for example were using TABs consistently for structs, on the grounds that those were probably copied from Linux. I also left out slirp from patch 2 because I did not want to complicate the ongoing surgery to extract it from QEMU. Thanks, Paolo Paolo Bonzini (2): remove space-tab sequences avoid TABs in files that only contain a few block/bochs.c | 22 ++--- block/file-posix.c | 2 +- block/file-win32.c | 8 +- block/linux-aio.c | 4 +- block/qcow2-cluster.c | 2 +- block/vpc.c | 2 +- bsd-user/elfload.c | 2 +- bsd-user/x86_64/target_syscall.h | 2 +- contrib/elf2dmp/main.c | 2 +- crypto/aes.c | 28 +++---- disas/alpha.c | 8 +- disas/arm.c | 2 +- disas/i386.c | 4 +- disas/m68k.c | 4 +- hw/alpha/typhoon.c | 12 +-- hw/arm/stellaris.c | 2 +- hw/arm/virt.c | 2 +- hw/char/sh_serial.c | 18 ++--- hw/char/virtio-serial-bus.c | 2 +- hw/char/xen_console.c | 58 ++++++------- hw/core/loader.c | 28 +++---- hw/display/tc6393xb.c | 6 +- hw/display/vga.c | 8 +- hw/display/virtio-gpu-3d.c | 6 +- hw/dma/pxa2xx_dma.c | 4 +- hw/dma/soc_dma.c | 2 +- hw/gpio/max7310.c | 2 +- hw/i386/xen/xen-hvm.c | 4 +- hw/ide/core.c | 94 +++++++++++----------- hw/input/lm832x.c | 2 +- hw/input/pckbd.c | 2 +- hw/input/tsc210x.c | 2 +- hw/intc/apic.c | 2 +- hw/mips/gt64xxx_pci.c | 6 +- hw/mips/mips_r4k.c | 4 +- hw/misc/max111x.c | 6 +- hw/misc/omap_l4.c | 4 +- hw/net/mipsnet.c | 16 ++-- hw/net/ne2000.c | 44 +++++----- hw/net/rocker/rocker.c | 2 +- hw/net/virtio-net.c | 4 +- hw/net/vmxnet3.c | 6 +- hw/pci/msix.c | 2 +- hw/pci/pci.c | 44 +++++----- hw/pci/pci_bridge.c | 2 +- hw/ppc/ppc405_uc.c | 2 +- hw/ppc/prep.c | 4 +- hw/scsi/lsi53c895a.c | 6 +- hw/sh4/r2d.c | 16 ++-- hw/usb/dev-bluetooth.c | 2 +- hw/usb/dev-hid.c | 6 +- hw/usb/dev-hub.c | 14 ++-- hw/usb/hcd-uhci.c | 4 +- hw/xen/xen_devconfig.c | 2 +- hw/xenpv/xen_domainbuild.c | 8 +- include/elf.h | 10 +-- include/hw/acpi/acpi.h | 14 ++-- include/hw/elf_ops.h | 2 +- include/hw/ide/internal.h | 2 +- include/hw/sh4/sh_intc.h | 20 ++--- include/hw/xen/io/ring.h | 4 +- include/qemu/acl.h | 14 ++-- include/qemu/iov.h | 2 +- include/scsi/constants.h | 2 +- include/sysemu/balloon.h | 2 +- linux-user/linuxload.c | 14 ++-- linux-user/main.c | 4 +- linux-user/mmap.c | 10 +-- linux-user/qemu.h | 4 +- linux-user/signal.c | 16 ++-- linux-user/strace.c | 4 +- linux-user/syscall.c | 2 +- linux-user/syscall_defs.h | 4 +- linux-user/uaccess.c | 2 +- linux-user/vm86.c | 2 +- linux-user/x86_64/target_syscall.h | 2 +- nbd/client.c | 2 +- net/checksum.c | 2 +- qtest.c | 4 +- slirp/ip_input.c | 4 +- slirp/tcp_input.c | 10 +-- slirp/tcp_output.c | 4 +- slirp/tcp_timer.c | 2 +- slirp/udp.c | 2 +- target/alpha/translate.c | 2 +- target/cris/helper.c | 2 +- target/cris/mmu.h | 10 +-- target/cris/translate_v10.inc.c | 2 +- target/i386/translate.c | 12 +-- target/mips/translate.c | 2 +- target/tilegx/translate.c | 2 +- tcg/i386/tcg-target.inc.c | 4 +- tests/tcg/alpha/test-cond.c | 4 +- tests/tcg/arm/hello-arm.c | 20 ++--- tests/tcg/cris/check_glibc_kernelversion.c | 8 +- tests/tcg/cris/check_mmap3.c | 2 +- tests/tcg/cris/check_openpf1.c | 2 +- tests/tcg/cris/check_settls1.c | 2 +- tests/tcg/i386/hello-i386.c | 14 ++-- tests/tcg/mips/hello-mips.c | 10 +-- tests/tcg/multiarch/sha1.c | 12 +-- tests/vhost-user-test.c | 4 +- ui/keymaps.h | 4 +- ui/qemu-pixman.c | 2 +- ui/vnc-enc-zywrle-template.c | 4 +- ui/vnc.c | 4 +- util/bitops.c | 4 +- util/osdep.c | 4 +- util/qemu-sockets.c | 4 +- 109 files changed, 429 insertions(+), 429 deletions(-) -- 2.19.2
On 12/13/2018 08:37 PM, Paolo Bonzini wrote: > Space-tab sequences at the beginning of the line are always a mistake, > so patch 1 fixes them. I am not touching space-tab in the middle of > the line, many of which are in #define lines. > > In addition, about a third of the files with TABs have only a few of > them and it's worth converting them for consistency. Of the files > touched by patch 2, hw/ide/core.c is the worst in absolute terms, with > over 50 occurrences in a 3000 lines file; hw/char/xen_console.c has > about a third TABs and two-thirds spaces but it is small so I included it. > > The files were selected by hand starting from a list of .c and .h > files in the tree, sorted by number of occurrences. I left out > files that for example were using TABs consistently for structs, > on the grounds that those were probably copied from Linux. I also > left out slirp from patch 2 because I did not want to complicate the > ongoing surgery to extract it from QEMU. > > Thanks, > > Paolo > > Paolo Bonzini (2): > remove space-tab sequences > avoid TABs in files that only contain a few > > block/bochs.c | 22 ++--- > block/file-posix.c | 2 +- > block/file-win32.c | 8 +- > block/linux-aio.c | 4 +- > block/qcow2-cluster.c | 2 +- > block/vpc.c | 2 +- > bsd-user/elfload.c | 2 +- > bsd-user/x86_64/target_syscall.h | 2 +- > contrib/elf2dmp/main.c | 2 +- > crypto/aes.c | 28 +++---- > disas/alpha.c | 8 +- > disas/arm.c | 2 +- > disas/i386.c | 4 +- > disas/m68k.c | 4 +- > hw/alpha/typhoon.c | 12 +-- > hw/arm/stellaris.c | 2 +- > hw/arm/virt.c | 2 +- > hw/char/sh_serial.c | 18 ++--- > hw/char/virtio-serial-bus.c | 2 +- > hw/char/xen_console.c | 58 ++++++------- > hw/core/loader.c | 28 +++---- > hw/display/tc6393xb.c | 6 +- > hw/display/vga.c | 8 +- > hw/display/virtio-gpu-3d.c | 6 +- > hw/dma/pxa2xx_dma.c | 4 +- > hw/dma/soc_dma.c | 2 +- > hw/gpio/max7310.c | 2 +- > hw/i386/xen/xen-hvm.c | 4 +- > hw/ide/core.c | 94 +++++++++++----------- > hw/input/lm832x.c | 2 +- > hw/input/pckbd.c | 2 +- > hw/input/tsc210x.c | 2 +- > hw/intc/apic.c | 2 +- > hw/mips/gt64xxx_pci.c | 6 +- > hw/mips/mips_r4k.c | 4 +- > hw/misc/max111x.c | 6 +- > hw/misc/omap_l4.c | 4 +- > hw/net/mipsnet.c | 16 ++-- > hw/net/ne2000.c | 44 +++++----- > hw/net/rocker/rocker.c | 2 +- > hw/net/virtio-net.c | 4 +- > hw/net/vmxnet3.c | 6 +- > hw/pci/msix.c | 2 +- > hw/pci/pci.c | 44 +++++----- > hw/pci/pci_bridge.c | 2 +- > hw/ppc/ppc405_uc.c | 2 +- > hw/ppc/prep.c | 4 +- > hw/scsi/lsi53c895a.c | 6 +- > hw/sh4/r2d.c | 16 ++-- > hw/usb/dev-bluetooth.c | 2 +- > hw/usb/dev-hid.c | 6 +- > hw/usb/dev-hub.c | 14 ++-- > hw/usb/hcd-uhci.c | 4 +- > hw/xen/xen_devconfig.c | 2 +- > hw/xenpv/xen_domainbuild.c | 8 +- > include/elf.h | 10 +-- > include/hw/acpi/acpi.h | 14 ++-- > include/hw/elf_ops.h | 2 +- > include/hw/ide/internal.h | 2 +- > include/hw/sh4/sh_intc.h | 20 ++--- > include/hw/xen/io/ring.h | 4 +- > include/qemu/acl.h | 14 ++-- > include/qemu/iov.h | 2 +- > include/scsi/constants.h | 2 +- > include/sysemu/balloon.h | 2 +- > linux-user/linuxload.c | 14 ++-- > linux-user/main.c | 4 +- > linux-user/mmap.c | 10 +-- > linux-user/qemu.h | 4 +- > linux-user/signal.c | 16 ++-- > linux-user/strace.c | 4 +- > linux-user/syscall.c | 2 +- > linux-user/syscall_defs.h | 4 +- > linux-user/uaccess.c | 2 +- > linux-user/vm86.c | 2 +- > linux-user/x86_64/target_syscall.h | 2 +- > nbd/client.c | 2 +- > net/checksum.c | 2 +- > qtest.c | 4 +- > slirp/ip_input.c | 4 +- > slirp/tcp_input.c | 10 +-- > slirp/tcp_output.c | 4 +- > slirp/tcp_timer.c | 2 +- > slirp/udp.c | 2 +- > target/alpha/translate.c | 2 +- > target/cris/helper.c | 2 +- > target/cris/mmu.h | 10 +-- > target/cris/translate_v10.inc.c | 2 +- > target/i386/translate.c | 12 +-- > target/mips/translate.c | 2 +- > target/tilegx/translate.c | 2 +- > tcg/i386/tcg-target.inc.c | 4 +- > tests/tcg/alpha/test-cond.c | 4 +- > tests/tcg/arm/hello-arm.c | 20 ++--- > tests/tcg/cris/check_glibc_kernelversion.c | 8 +- > tests/tcg/cris/check_mmap3.c | 2 +- > tests/tcg/cris/check_openpf1.c | 2 +- > tests/tcg/cris/check_settls1.c | 2 +- > tests/tcg/i386/hello-i386.c | 14 ++-- > tests/tcg/mips/hello-mips.c | 10 +-- > tests/tcg/multiarch/sha1.c | 12 +-- > tests/vhost-user-test.c | 4 +- > ui/keymaps.h | 4 +- > ui/qemu-pixman.c | 2 +- > ui/vnc-enc-zywrle-template.c | 4 +- > ui/vnc.c | 4 +- > util/bitops.c | 4 +- > util/osdep.c | 4 +- > util/qemu-sockets.c | 4 +- > 109 files changed, 429 insertions(+), 429 deletions(-) > Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Patchew URL: https://patchew.org/QEMU/20181213223737.11793-1-pbonzini@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20181213223737.11793-1-pbonzini@redhat.com
Type: series
Subject: [Qemu-devel] [PATCH 0/2] Fix TABs in many files
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
303caa2 avoid TABs in files that only contain a few
aab0b24 remove space-tab sequences
=== OUTPUT BEGIN ===
Checking PATCH 1/2: remove space-tab sequences...
ERROR: code indent should never use tabs
#21: FILE: bsd-user/x86_64/target_syscall.h:15:
+^Iabi_ulong r11;$
ERROR: code indent should never use tabs
#34: FILE: crypto/aes.c:1074:
+^Iint i = 0;$
ERROR: code indent should never use tabs
#43: FILE: crypto/aes.c:1163:
+^I^I}$
ERROR: code indent should never use tabs
#52: FILE: crypto/aes.c:1250:
+^I/* round 2: */$
ERROR: code indent should never use tabs
#61: FILE: crypto/aes.c:1260:
+^I/* round 4: */$
ERROR: code indent should never use tabs
#70: FILE: crypto/aes.c:1270:
+^I/* round 6: */$
ERROR: code indent should never use tabs
#79: FILE: crypto/aes.c:1280:
+^I/* round 8: */$
ERROR: code indent should never use tabs
#88: FILE: crypto/aes.c:1572:
+^Is0 =$
ERROR: code indent should never use tabs
#94: FILE: crypto/aes.c:1577:
+^I^Irk[0];$
ERROR: code indent should never use tabs
#97: FILE: crypto/aes.c:1579:
+^Is1 =$
ERROR: code indent should never use tabs
#103: FILE: crypto/aes.c:1584:
+^I^Irk[1];$
ERROR: code indent should never use tabs
#106: FILE: crypto/aes.c:1586:
+^Is2 =$
ERROR: code indent should never use tabs
#112: FILE: crypto/aes.c:1591:
+^I^Irk[2];$
ERROR: code indent should never use tabs
#115: FILE: crypto/aes.c:1593:
+^Is3 =$
ERROR: code indent should never use tabs
#121: FILE: crypto/aes.c:1598:
+^I^Irk[3];$
ERROR: code indent should never use tabs
#134: FILE: disas/alpha.c:675:
+^I^Iwhich bits in the actual opcode must match OPCODE.$
ERROR: code indent should never use tabs
#143: FILE: disas/alpha.c:702:
+^I^Ibut with defined results on previous implementations.$
ERROR: code indent should never use tabs
#147: FILE: disas/alpha.c:705:
+^I^Ipresumably undefined results on previous implementations$
ERROR: code indent should never use tabs
#156: FILE: disas/alpha.c:835:
+^I^I^I0xFFFFFFE0, BASE, { RC } },^I^I/* ev56 but */$
ERROR: code indent should never use tabs
#169: FILE: disas/arm.c:1080:
+^I^I^I^I(top bit of range being the sign bit)$
ERROR: code indent should never use tabs
#182: FILE: disas/i386.c:6078:
+^I}$
ERROR: code indent should never use tabs
#191: FILE: disas/i386.c:6115:
+^I}$
ERROR: code indent should never use tabs
#204: FILE: disas/m68k.c:353:
+^I^I^I^I^I^I(not 0,1,7.2-4)$
ERROR: space required after that ',' (ctx:VxV)
#204: FILE: disas/m68k.c:353:
+ (not 0,1,7.2-4)
^
ERROR: space required after that ',' (ctx:VxV)
#204: FILE: disas/m68k.c:353:
+ (not 0,1,7.2-4)
^
ERROR: spaces required around that '-' (ctx:VxV)
#204: FILE: disas/m68k.c:353:
+ (not 0,1,7.2-4)
^
ERROR: code indent should never use tabs
#213: FILE: disas/m68k.c:1650:
+^I case 0x18: name = "%psr"; break;$
ERROR: trailing statements should be on next line
#213: FILE: disas/m68k.c:1650:
+ case 0x18: name = "%psr"; break;
ERROR: code indent should never use tabs
#241: FILE: include/hw/elf_ops.h:346:
+^I*pentry = (uint64_t)(elf_sword)ehdr.e_entry;$
ERROR: code indent should never use tabs
#254: FILE: linux-user/linuxload.c:57:
+^Ibprm->e_uid = st.st_uid;$
ERROR: code indent should never use tabs
#267: FILE: linux-user/syscall.c:905:
+^Ireturn target_brk;$
ERROR: code indent should never use tabs
#280: FILE: linux-user/syscall_defs.h:1810:
+^Iabi_long^Ist_blocks;^I/* Number 512-byte blocks allocated. */$
ERROR: code indent should never use tabs
#289: FILE: linux-user/syscall_defs.h:1819:
+^Iabi_long^I__unused[3];$
ERROR: code indent should never use tabs
#302: FILE: linux-user/x86_64/target_syscall.h:15:
+^Iabi_ulong r11;$
ERROR: suspect code indent for conditional statements (24, 27)
#313: FILE: slirp/ip_input.c:195:
if (fp)
+ ip_freef(slirp, fp);
ERROR: code indent should never use tabs
#315: FILE: slirp/ip_input.c:196:
+^I^I^I ip_freef(slirp, fp);$
ERROR: code indent should never use tabs
#324: FILE: slirp/ip_input.c:540:
+^I^I^I if ((ia = (INA)ifa_ifwithdstaddr((SA)&ipaddr)) == 0)$
ERROR: spaces required around that '&' (ctx:VxV)
#324: FILE: slirp/ip_input.c:540:
+ if ((ia = (INA)ifa_ifwithdstaddr((SA)&ipaddr)) == 0)
^
ERROR: do not use assignment in if condition
#324: FILE: slirp/ip_input.c:540:
+ if ((ia = (INA)ifa_ifwithdstaddr((SA)&ipaddr)) == 0)
ERROR: braces {} are necessary for all arms of this statement
#324: FILE: slirp/ip_input.c:540:
+ if ((ia = (INA)ifa_ifwithdstaddr((SA)&ipaddr)) == 0)
[...]
ERROR: code indent should never use tabs
#337: FILE: slirp/tcp_input.c:77:
+^I^I sbappend((so), (m)); \$
ERROR: code indent should never use tabs
#346: FILE: slirp/tcp_input.c:1178:
+^I^I/*$
ERROR: code indent should never use tabs
#355: FILE: slirp/tcp_input.c:1328:
+^I^I/*$
ERROR: code indent should never use tabs
#364: FILE: slirp/tcp_input.c:1340:
+^I^I/*$
ERROR: code indent should never use tabs
#373: FILE: slirp/tcp_input.c:1348:
+^I^I/*$
ERROR: code indent should never use tabs
#386: FILE: slirp/tcp_output.c:278:
+^I}$
ERROR: code indent should never use tabs
#389: FILE: slirp/tcp_output.c:280:
+^Ihdrlen += optlen;$
ERROR: code indent should never use tabs
#402: FILE: slirp/tcp_timer.c:266:
+^I^I^Iif (tp->t_idle >= TCPTV_KEEP_IDLE + TCP_MAXIDLE)$
ERROR: braces {} are necessary for all arms of this statement
#402: FILE: slirp/tcp_timer.c:266:
+ if (tp->t_idle >= TCPTV_KEEP_IDLE + TCP_MAXIDLE)
[...]
ERROR: code indent should never use tabs
#415: FILE: slirp/udp.c:313:
+^I^I^Iso->so_emu = udptos[i].emu;$
WARNING: line over 80 characters
#430: FILE: tests/tcg/arm/hello-arm.c:81:
+ : "=r" (__res) \
ERROR: code indent should never use tabs
#430: FILE: tests/tcg/arm/hello-arm.c:81:
+^I: "=r" (__res)^I^I^I^I^I^I^I^I^I\$
WARNING: line over 80 characters
#431: FILE: tests/tcg/arm/hello-arm.c:82:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)) \
ERROR: code indent should never use tabs
#431: FILE: tests/tcg/arm/hello-arm.c:82:
+^I: "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4))^I\$
ERROR: space required after that ',' (ctx:VxV)
#431: FILE: tests/tcg/arm/hello-arm.c:82:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)) \
^
ERROR: space required after that ',' (ctx:VxV)
#431: FILE: tests/tcg/arm/hello-arm.c:82:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)) \
^
ERROR: space required after that ',' (ctx:VxV)
#431: FILE: tests/tcg/arm/hello-arm.c:82:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)) \
^
WARNING: line over 80 characters
#432: FILE: tests/tcg/arm/hello-arm.c:83:
+ : "r0","r1","r2","r3","lr"); \
ERROR: code indent should never use tabs
#432: FILE: tests/tcg/arm/hello-arm.c:83:
+^I: "r0","r1","r2","r3","lr");^I^I^I^I^I^I^I\$
ERROR: space required after that ',' (ctx:VxV)
#432: FILE: tests/tcg/arm/hello-arm.c:83:
+ : "r0","r1","r2","r3","lr"); \
^
ERROR: space required after that ',' (ctx:VxV)
#432: FILE: tests/tcg/arm/hello-arm.c:83:
+ : "r0","r1","r2","r3","lr"); \
^
ERROR: space required after that ',' (ctx:VxV)
#432: FILE: tests/tcg/arm/hello-arm.c:83:
+ : "r0","r1","r2","r3","lr"); \
^
ERROR: space required after that ',' (ctx:VxV)
#432: FILE: tests/tcg/arm/hello-arm.c:83:
+ : "r0","r1","r2","r3","lr"); \
^
WARNING: line over 80 characters
#442: FILE: tests/tcg/arm/hello-arm.c:99:
+ : "=r" (__res) \
ERROR: code indent should never use tabs
#442: FILE: tests/tcg/arm/hello-arm.c:99:
+^I: "=r" (__res)^I^I^I^I^I^I^I^I^I\$
WARNING: line over 80 characters
#443: FILE: tests/tcg/arm/hello-arm.c:100:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)), \
ERROR: code indent should never use tabs
#443: FILE: tests/tcg/arm/hello-arm.c:100:
+^I: "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)),^I\$
ERROR: space required after that ',' (ctx:VxV)
#443: FILE: tests/tcg/arm/hello-arm.c:100:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)), \
^
ERROR: space required after that ',' (ctx:VxV)
#443: FILE: tests/tcg/arm/hello-arm.c:100:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)), \
^
ERROR: space required after that ',' (ctx:VxV)
#443: FILE: tests/tcg/arm/hello-arm.c:100:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)), \
^
total: 65 errors, 5 warnings, 328 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/2: avoid TABs in files that only contain a few...
ERROR: braces {} are necessary for all arms of this statement
#535: FILE: hw/char/xen_console.c:89:
+ if (buffer->consumed > buffer->max_capacity - over)
[...]
ERROR: braces {} are necessary for all arms of this statement
#639: FILE: hw/core/loader.c:274:
+ if (size < 0)
[...]
ERROR: braces {} are necessary for all arms of this statement
#651: FILE: hw/core/loader.c:282:
+ if (size < 0)
[...]
ERROR: braces {} are necessary for all arms of this statement
#659: FILE: hw/core/loader.c:286:
+ if (ret < 0)
[...]
ERROR: space prohibited before that close parenthesis ')'
#715: FILE: hw/display/vga.c:91:
+ (((uint32_t)(__x) & (uint32_t)0xff000000UL) >> 24) ))
ERROR: braces {} are necessary for all arms of this statement
#754: FILE: hw/dma/pxa2xx_dma.c:286:
+ if (s->chan[channel].request)
[...]
ERROR: braces {} are necessary for all arms of this statement
#872: FILE: hw/ide/core.c:1191:
+ if (!s->nsector)
[...]
ERROR: braces {} are necessary for all arms of this statement
#1044: FILE: hw/intc/apic.c:444:
+ if (apic && apic->id == dest)
[...]
ERROR: code indent should never use tabs
#1110: FILE: hw/misc/max111x.c:46:
+ ((((v) >> (2 + (b0))) & 4) |^I\$
ERROR: code indent should never use tabs
#1111: FILE: hw/misc/max111x.c:47:
+ (((v) >> (3 + (b1))) & 2) |^I\$
ERROR: code indent should never use tabs
#1140: FILE: hw/net/mipsnet.c:115:
+ ret = be32_to_cpu(0x4d495053);^I^I/* MIPS */$
ERROR: code indent should never use tabs
#1144: FILE: hw/net/mipsnet.c:118:
+ ret = be32_to_cpu(0x4e455430);^I^I/* NET0 */$
ERROR: code indent should never use tabs
#1237: FILE: hw/net/ne2000.c:430:
+ ret = 0;^I^I/* 10baseT media */$
ERROR: code indent should never use tabs
#1240: FILE: hw/net/ne2000.c:433:
+ ret = 0x40;^I^I/* 10baseT active */$
ERROR: code indent should never use tabs
#1243: FILE: hw/net/ne2000.c:436:
+ ret = 0x40;^I^I/* Full duplex */$
ERROR: consider using qemu_strtoul in preference to strtoul
#1374: FILE: hw/pci/pci.c:631:
+ val = strtoul(p, &e, 16);
ERROR: braces {} are necessary for all arms of this statement
#1375: FILE: hw/pci/pci.c:632:
+ if (e == p)
[...]
ERROR: consider using qemu_strtoul in preference to strtoul
#1381: FILE: hw/pci/pci.c:638:
+ val = strtoul(p, &e, 16);
ERROR: braces {} are necessary for all arms of this statement
#1382: FILE: hw/pci/pci.c:639:
+ if (e == p)
[...]
ERROR: code indent should never use tabs
#1573: FILE: hw/usb/dev-hub.c:150:
+ 0x00,^I^I^I/* u8 bLength; patched in later */$
ERROR: code indent should never use tabs
#1574: FILE: hw/usb/dev-hub.c:151:
+ 0x29,^I^I^I/* u8 bDescriptorType; Hub-descriptor */$
ERROR: code indent should never use tabs
#1575: FILE: hw/usb/dev-hub.c:152:
+ 0x00,^I^I^I/* u8 bNbrPorts; (patched later) */$
ERROR: code indent should never use tabs
#1576: FILE: hw/usb/dev-hub.c:153:
+ 0x0a,^I^I^I/* u16 wHubCharacteristics; */$
ERROR: code indent should never use tabs
#1577: FILE: hw/usb/dev-hub.c:154:
+ 0x00,^I^I^I/* (per-port OC, no power switching) */$
ERROR: code indent should never use tabs
#1578: FILE: hw/usb/dev-hub.c:155:
+ 0x01,^I^I^I/* u8 bPwrOn2pwrGood; 2ms */$
ERROR: code indent should never use tabs
#1579: FILE: hw/usb/dev-hub.c:156:
+ 0x00^I^I^I/* u8 bHubContrCurrent; 0 mA */$
ERROR: space required after that ',' (ctx:VxV)
#1620: FILE: hw/xenpv/xen_domainbuild.c:85:
+ snprintf(path, sizeof(path), "cpu/%d/availability",i);
^
ERROR: code indent should never use tabs
#1767: FILE: include/hw/xen/io/ring.h:238:
+ /* Use volatile to force the copy into _req. */^I^I^I\$
ERROR: code indent should never use tabs
#1768: FILE: include/hw/xen/io/ring.h:239:
+ *(_req) = *(volatile typeof(_req))RING_GET_REQUEST(_r, _idx);^I\$
ERROR: return is not a function, parentheses are not required
#1850: FILE: linux-user/linuxload.c:41:
+ return(-errno);
ERROR: return is not a function, parentheses are not required
#1856: FILE: linux-user/linuxload.c:46:
+ return(-EACCES);
ERROR: return is not a function, parentheses are not required
#1860: FILE: linux-user/linuxload.c:49:
+ return(-EACCES);
ERROR: code indent should never use tabs
#1935: FILE: linux-user/qemu.h:53:
+ int^I^Ipersonality;$
ERROR: braces {} are necessary for all arms of this statement
#1968: FILE: linux-user/signal.c:740:
+ if (on_sig_stack(sp))
[...]
ERROR: spaces required around that '+' (ctx:VxV)
#2060: FILE: net/checksum.c:46:
+ sum = (sum & 0xFFFF)+(sum >> 16);
^
ERROR: trailing whitespace
#2108: FILE: target/cris/helper.c:243:
+ $
ERROR: code indent should never use tabs
#2278: FILE: tests/tcg/arm/hello-arm.c:14:
+ return (type) (res);^I^I^I^I^I^I\$
ERROR: code indent should never use tabs
#2287: FILE: tests/tcg/arm/hello-arm.c:36:
+ : "r0","lr");^I^I^I^I^I^I^I\$
ERROR: space required after that ',' (ctx:VxV)
#2287: FILE: tests/tcg/arm/hello-arm.c:36:
+ : "r0","lr"); \
^
ERROR: code indent should never use tabs
#2296: FILE: tests/tcg/arm/hello-arm.c:50:
+ : "r0","r1","lr");^I^I^I^I^I^I\$
ERROR: space required after that ',' (ctx:VxV)
#2296: FILE: tests/tcg/arm/hello-arm.c:50:
+ : "r0","r1","lr"); \
^
ERROR: space required after that ',' (ctx:VxV)
#2296: FILE: tests/tcg/arm/hello-arm.c:50:
+ : "r0","r1","lr"); \
^
WARNING: line over 80 characters
#2307: FILE: tests/tcg/arm/hello-arm.c:81:
+ : "=r" (__res) \
ERROR: code indent should never use tabs
#2307: FILE: tests/tcg/arm/hello-arm.c:81:
+ : "=r" (__res)^I^I^I^I^I^I^I^I^I\$
WARNING: line over 80 characters
#2308: FILE: tests/tcg/arm/hello-arm.c:82:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)) \
ERROR: code indent should never use tabs
#2308: FILE: tests/tcg/arm/hello-arm.c:82:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4))^I\$
ERROR: space required after that ',' (ctx:VxV)
#2308: FILE: tests/tcg/arm/hello-arm.c:82:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)) \
^
ERROR: space required after that ',' (ctx:VxV)
#2308: FILE: tests/tcg/arm/hello-arm.c:82:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)) \
^
ERROR: space required after that ',' (ctx:VxV)
#2308: FILE: tests/tcg/arm/hello-arm.c:82:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)) \
^
WARNING: line over 80 characters
#2309: FILE: tests/tcg/arm/hello-arm.c:83:
+ : "r0","r1","r2","r3","lr"); \
ERROR: code indent should never use tabs
#2309: FILE: tests/tcg/arm/hello-arm.c:83:
+ : "r0","r1","r2","r3","lr");^I^I^I^I^I^I^I\$
ERROR: space required after that ',' (ctx:VxV)
#2309: FILE: tests/tcg/arm/hello-arm.c:83:
+ : "r0","r1","r2","r3","lr"); \
^
ERROR: space required after that ',' (ctx:VxV)
#2309: FILE: tests/tcg/arm/hello-arm.c:83:
+ : "r0","r1","r2","r3","lr"); \
^
ERROR: space required after that ',' (ctx:VxV)
#2309: FILE: tests/tcg/arm/hello-arm.c:83:
+ : "r0","r1","r2","r3","lr"); \
^
ERROR: space required after that ',' (ctx:VxV)
#2309: FILE: tests/tcg/arm/hello-arm.c:83:
+ : "r0","r1","r2","r3","lr"); \
^
WARNING: line over 80 characters
#2321: FILE: tests/tcg/arm/hello-arm.c:99:
+ : "=r" (__res) \
ERROR: code indent should never use tabs
#2321: FILE: tests/tcg/arm/hello-arm.c:99:
+ : "=r" (__res)^I^I^I^I^I^I^I^I^I\$
WARNING: line over 80 characters
#2322: FILE: tests/tcg/arm/hello-arm.c:100:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)), \
ERROR: code indent should never use tabs
#2322: FILE: tests/tcg/arm/hello-arm.c:100:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)),^I\$
ERROR: space required after that ',' (ctx:VxV)
#2322: FILE: tests/tcg/arm/hello-arm.c:100:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)), \
^
ERROR: space required after that ',' (ctx:VxV)
#2322: FILE: tests/tcg/arm/hello-arm.c:100:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)), \
^
ERROR: space required after that ',' (ctx:VxV)
#2322: FILE: tests/tcg/arm/hello-arm.c:100:
+ : "r" ((long)(arg1)),"r" ((long)(arg2)),"r" ((long)(arg3)),"r" ((long)(arg4)), \
^
WARNING: line over 80 characters
#2323: FILE: tests/tcg/arm/hello-arm.c:101:
+ "r" ((long)(arg5)) \
ERROR: code indent should never use tabs
#2323: FILE: tests/tcg/arm/hello-arm.c:101:
+ "r" ((long)(arg5))^I^I^I^I^I^I^I^I\$
WARNING: line over 80 characters
#2324: FILE: tests/tcg/arm/hello-arm.c:102:
+ : "r0","r1","r2","r3","r4","lr"); \
ERROR: code indent should never use tabs
#2324: FILE: tests/tcg/arm/hello-arm.c:102:
+ : "r0","r1","r2","r3","r4","lr");^I^I^I^I^I^I\$
ERROR: space required after that ',' (ctx:VxV)
#2324: FILE: tests/tcg/arm/hello-arm.c:102:
+ : "r0","r1","r2","r3","r4","lr"); \
^
ERROR: space required after that ',' (ctx:VxV)
#2324: FILE: tests/tcg/arm/hello-arm.c:102:
+ : "r0","r1","r2","r3","r4","lr"); \
^
ERROR: space required after that ',' (ctx:VxV)
#2324: FILE: tests/tcg/arm/hello-arm.c:102:
+ : "r0","r1","r2","r3","r4","lr"); \
^
ERROR: space required after that ',' (ctx:VxV)
#2324: FILE: tests/tcg/arm/hello-arm.c:102:
+ : "r0","r1","r2","r3","r4","lr"); \
^
ERROR: space required after that ',' (ctx:VxV)
#2324: FILE: tests/tcg/arm/hello-arm.c:102:
+ : "r0","r1","r2","r3","r4","lr"); \
^
ERROR: braces {} are necessary for all arms of this statement
#2340: FILE: tests/tcg/cris/check_glibc_kernelversion.c:112:
+ if (version < __LINUX_KERNEL_VERSION)
[...]
ERROR: space prohibited between function name and open parenthesis '('
#2367: FILE: tests/tcg/cris/check_openpf1.c:22:
+ abort ();
ERROR: Use of volatile is usually wrong, please add a comment
#2380: FILE: tests/tcg/cris/check_settls1.c:38:
+ * (volatile int *) 0 = 0;
ERROR: space required after that ',' (ctx:VxV)
#2395: FILE: tests/tcg/i386/hello-i386.c:8:
+ : "=a" (__res) : "0" (__NR_exit),"c" ((long)(status)));
^
ERROR: line over 90 characters
#2411: FILE: tests/tcg/i386/hello-i386.c:19:
+ : "0" (__NR_write),"S" ((long)(fd)),"c" ((long)(buf)),"d" ((long)(len)));
ERROR: space required after that ',' (ctx:VxV)
#2411: FILE: tests/tcg/i386/hello-i386.c:19:
+ : "0" (__NR_write),"S" ((long)(fd)),"c" ((long)(buf)),"d" ((long)(len)));
^
ERROR: space required after that ',' (ctx:VxV)
#2411: FILE: tests/tcg/i386/hello-i386.c:19:
+ : "0" (__NR_write),"S" ((long)(fd)),"c" ((long)(buf)),"d" ((long)(len)));
^
ERROR: space required after that ',' (ctx:VxV)
#2411: FILE: tests/tcg/i386/hello-i386.c:19:
+ : "0" (__NR_write),"S" ((long)(fd)),"c" ((long)(buf)),"d" ((long)(len)));
^
ERROR: unnecessary whitespace before a quoted newline
#2420: FILE: tests/tcg/mips/hello-mips.c:24:
" syscall \n"
ERROR: braces {} are necessary for all arms of this statement
#2467: FILE: tests/tcg/multiarch/sha1.c:192:
+ for (j = 0; j < 4; t >>= 8, j++)
[...]
WARNING: line over 80 characters
#2491: FILE: tests/vhost-user-test.c:357:
+ g_assert_cmpint(msg.payload.u64 & (0x1ULL << VHOST_USER_F_PROTOCOL_FEATURES),
ERROR: "foo* bar" should be "foo *bar"
#2506: FILE: ui/keymaps.h:31:
+ const char* name;
ERROR: space required after that ',' (ctx:VxV)
#2601: FILE: util/qemu-sockets.c:273:
+ uaddr,INET6_ADDRSTRLEN,uport,32,
^
ERROR: space required after that ',' (ctx:VxV)
#2601: FILE: util/qemu-sockets.c:273:
+ uaddr,INET6_ADDRSTRLEN,uport,32,
^
ERROR: space required after that ',' (ctx:VxV)
#2601: FILE: util/qemu-sockets.c:273:
+ uaddr,INET6_ADDRSTRLEN,uport,32,
^
total: 78 errors, 8 warnings, 1911 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20181213223737.11793-1-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
© 2016 - 2024 Red Hat, Inc.