1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PATCH] block: Replace qdict_put() by qdict_put_obj() where appropriate

Markus Armbruster posted 1 patch 6 years, 10 months ago
Test checkpatch passed
Test asan passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test docker-clang@ubuntu passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181213175154.5242-1-armbru@redhat.com
block/blklogwrites.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
[Qemu-devel] [PATCH] block: Replace qdict_put() by qdict_put_obj() where appropriate
Posted by Markus Armbruster 6 years, 10 months ago 
Patch created mechanically by rerunning:

  $  spatch --sp-file scripts/coccinelle/qobject.cocci \
	    --macro-file scripts/cocci-macro-file.h \
	    --dir block --in-place

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 block/blklogwrites.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/block/blklogwrites.c b/block/blklogwrites.c
index ff98cd5533..d2e01bdb1d 100644
--- a/block/blklogwrites.c
+++ b/block/blklogwrites.c
@@ -295,10 +295,9 @@ static void blk_log_writes_refresh_filename(BlockDriverState *bs,
         qdict_put_str(opts, "driver", "blklogwrites");
 
         qobject_ref(bs->file->bs->full_open_options);
-        qdict_put_obj(opts, "file", QOBJECT(bs->file->bs->full_open_options));
+        qdict_put(opts, "file", bs->file->bs->full_open_options);
         qobject_ref(s->log_file->bs->full_open_options);
-        qdict_put_obj(opts, "log",
-                      QOBJECT(s->log_file->bs->full_open_options));
+        qdict_put(opts, "log", s->log_file->bs->full_open_options);
         qdict_put_int(opts, "log-sector-size", s->sectorsize);
 
         bs->full_open_options = opts;
-- 
2.17.2
Re: [Qemu-devel] [PATCH] block: Replace qdict_put() by qdict_put_obj() where appropriate
Posted by Eric Blake 6 years, 10 months ago 
On 12/13/18 11:51 AM, Markus Armbruster wrote:
> Patch created mechanically by rerunning:
> 
>    $  spatch --sp-file scripts/coccinelle/qobject.cocci \
> 	    --macro-file scripts/cocci-macro-file.h \
> 	    --dir block --in-place
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   block/blklogwrites.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org
Re: [Qemu-devel] [PATCH] block: Replace qdict_put() by qdict_put_obj() where appropriate
Posted by Kevin Wolf 6 years, 10 months ago 
Am 13.12.2018 um 18:51 hat Markus Armbruster geschrieben:
> Patch created mechanically by rerunning:
> 
>   $  spatch --sp-file scripts/coccinelle/qobject.cocci \
> 	    --macro-file scripts/cocci-macro-file.h \
> 	    --dir block --in-place
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Thanks, applied to the block branch.

Kevin
Re: [Qemu-devel] [Qemu-block] [PATCH] block: Replace qdict_put() by qdict_put_obj() where appropriate
Posted by Alberto Garcia 6 years, 10 months ago 
On Thu 13 Dec 2018 06:51:54 PM CET, Markus Armbruster wrote:
> Patch created mechanically by rerunning:
>
>   $  spatch --sp-file scripts/coccinelle/qobject.cocci \
> 	    --macro-file scripts/cocci-macro-file.h \
> 	    --dir block --in-place
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Alberto Garcia <berto@igalia.com>

Berto

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.