[v2] block: Convert from DPRINTF() macro to trace event

[Qemu-devel] [PATCH v2 0/4] block: Convert from DPRINTF() macro to trace event

Laurent Vivier posted 4 patches 6 years, 10 months ago

Diff against v1
Download series mbox

Test asan passed

Test checkpatch passed

Test docker-mingw@fedora passed

Test docker-quick@centos7 passed

Test docker-clang@ubuntu passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181213162727.17438-1-lvivier@redhat.com

block/curl.c       | 29 ++++++++--------------------
block/file-posix.c | 25 ++++++------------------
block/sheepdog.c   | 47 +++++++++++++++++-----------------------------
block/ssh.c        | 46 +++++++++++++++++----------------------------
block/trace-events | 47 ++++++++++++++++++++++++++++++++++++++++++++++
5 files changed, 95 insertions(+), 99 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v2 0/4] block: Convert from DPRINTF() macro to trace event

Posted by Laurent Vivier 6 years, 10 months ago

Convert all the remaining uses of DPRINTF() in the directory block.

Compiled for all target but only tested with "make check"

v2: replace "sd_" prefix by "sheepdog_"
    remove the dot at the end of the text strings
    use %zu with size_t
    change an uint64_t to int64_t to match % PRIi64

Laurent Vivier (4):
  block/ssh: Convert from DPRINTF() macro to trace events
  block/curl: Convert from DPRINTF() macro to trace events
  block/file-posix: Convert from DPRINTF() macro to trace events
  block/sheepdog: Convert from DPRINTF() macro to trace events

 block/curl.c       | 29 ++++++++--------------------
 block/file-posix.c | 25 ++++++------------------
 block/sheepdog.c   | 47 +++++++++++++++++-----------------------------
 block/ssh.c        | 46 +++++++++++++++++----------------------------
 block/trace-events | 47 ++++++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 95 insertions(+), 99 deletions(-)

-- 
2.19.2

Re: [Qemu-devel] [PATCH v2 0/4] block: Convert from DPRINTF() macro to trace event

Posted by Max Reitz 6 years, 9 months ago

On 13.12.18 17:27, Laurent Vivier wrote:
> Convert all the remaining uses of DPRINTF() in the directory block.
> 
> Compiled for all target but only tested with "make check"
> 
> v2: replace "sd_" prefix by "sheepdog_"
>     remove the dot at the end of the text strings
>     use %zu with size_t
>     change an uint64_t to int64_t to match % PRIi64
> 
> Laurent Vivier (4):
>   block/ssh: Convert from DPRINTF() macro to trace events
>   block/curl: Convert from DPRINTF() macro to trace events
>   block/file-posix: Convert from DPRINTF() macro to trace events
>   block/sheepdog: Convert from DPRINTF() macro to trace events

Applied to my block branch, with three fixes (Philippe asked me to do
one, so what are two more O:-)):
- Patch 1: Fixed ssh_{read,write}_return's @ret sign
- Patch 3: Moved the pointer asterisk in file_xfs_discard from type to name
- Patch 4: Fixed sheepdog_snapshot_create_inode's format string to use
PRIx32 instead of %x for uint32_ts

(https://git.xanclic.moe/XanClic/qemu/commits/branch/block)

Thanks!

Max

Re: [Qemu-devel] [PATCH v2 0/4] block: Convert from DPRINTF() macro to trace event

Posted by Philippe Mathieu-Daudé 6 years, 9 months ago

On 1/14/19 1:14 PM, Max Reitz wrote:
> On 13.12.18 17:27, Laurent Vivier wrote:
>> Convert all the remaining uses of DPRINTF() in the directory block.
>>
>> Compiled for all target but only tested with "make check"
>>
>> v2: replace "sd_" prefix by "sheepdog_"
>>     remove the dot at the end of the text strings
>>     use %zu with size_t
>>     change an uint64_t to int64_t to match % PRIi64
>>
>> Laurent Vivier (4):
>>   block/ssh: Convert from DPRINTF() macro to trace events
>>   block/curl: Convert from DPRINTF() macro to trace events
>>   block/file-posix: Convert from DPRINTF() macro to trace events
>>   block/sheepdog: Convert from DPRINTF() macro to trace events
> 
> Applied to my block branch, with three fixes (Philippe asked me to do
> one, so what are two more O:-)):
> - Patch 1: Fixed ssh_{read,write}_return's @ret sign
> - Patch 3: Moved the pointer asterisk in file_xfs_discard from type to name
> - Patch 4: Fixed sheepdog_snapshot_create_inode's format string to use
> PRIx32 instead of %x for uint32_ts

Thank you Max!

> 
> (https://git.xanclic.moe/XanClic/qemu/commits/branch/block)
> 
> Thanks!
> 
> Max
>