[Qemu-devel] [PATCH 0/4] Introduce the hw/firmware/ namespace

Philippe Mathieu-Daudé posted 4 patches 5 years, 4 months ago
Test checkpatch passed
Test docker-quick@centos7 passed
Test docker-clang@ubuntu passed
Test docker-mingw@fedora passed
Test asan passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181207165103.3992-1-philmd@redhat.com
There is a newer version of this series
MAINTAINERS                              |  2 +-
hw/arm/virt.c                            |  2 +-
hw/i386/pc.c                             |  2 +-
hw/i386/pc_piix.c                        |  2 +-
hw/i386/pc_q35.c                         |  2 +-
hw/smbios/smbios-stub.c                  |  2 +-
hw/smbios/smbios.c                       |  3 +--
hw/smbios/smbios_build.h                 |  4 ++++
hw/smbios/smbios_type_38-stub.c          |  2 +-
hw/smbios/smbios_type_38.c               |  3 +--
include/hw/{smbios => firmware}/smbios.h |  0
include/hw/smbios/ipmi.h                 | 15 ---------------
tests/acpi-utils.c                       |  1 -
tests/bios-tables-test.c                 |  2 +-
vl.c                                     |  2 +-
15 files changed, 15 insertions(+), 29 deletions(-)
rename include/hw/{smbios => firmware}/smbios.h (100%)
delete mode 100644 include/hw/smbios/ipmi.h
[Qemu-devel] [PATCH 0/4] Introduce the hw/firmware/ namespace
Posted by Philippe Mathieu-Daudé 5 years, 4 months ago
QEMU interacts with various firmwares. We already have some helpers
for some firmwares. Later we will add UEFI helpers.
This series introduce the hw/firmware namespace for this.

There is no need to move hw/smbios sources into a specific directory,
we only focus on the headers.

Philippe Mathieu-Daudé (4):
  tests: Remove unused include
  hw/smbios: Restrict access to "smbios_ipmi.h"
  hw/smbios: Remove "smbios_ipmi.h"
  hw/smbios: Move to the hw/firmware/ namespace

 MAINTAINERS                              |  2 +-
 hw/arm/virt.c                            |  2 +-
 hw/i386/pc.c                             |  2 +-
 hw/i386/pc_piix.c                        |  2 +-
 hw/i386/pc_q35.c                         |  2 +-
 hw/smbios/smbios-stub.c                  |  2 +-
 hw/smbios/smbios.c                       |  3 +--
 hw/smbios/smbios_build.h                 |  4 ++++
 hw/smbios/smbios_type_38-stub.c          |  2 +-
 hw/smbios/smbios_type_38.c               |  3 +--
 include/hw/{smbios => firmware}/smbios.h |  0
 include/hw/smbios/ipmi.h                 | 15 ---------------
 tests/acpi-utils.c                       |  1 -
 tests/bios-tables-test.c                 |  2 +-
 vl.c                                     |  2 +-
 15 files changed, 15 insertions(+), 29 deletions(-)
 rename include/hw/{smbios => firmware}/smbios.h (100%)
 delete mode 100644 include/hw/smbios/ipmi.h

-- 
2.17.2


Re: [Qemu-devel] [PATCH 0/4] Introduce the hw/firmware/ namespace
Posted by Michael S. Tsirkin 5 years, 4 months ago
On Fri, Dec 07, 2018 at 05:50:59PM +0100, Philippe Mathieu-Daudé wrote:
> QEMU interacts with various firmwares. We already have some helpers
> for some firmwares. Later we will add UEFI helpers.
> This series introduce the hw/firmware namespace for this.
> 
> There is no need to move hw/smbios sources into a specific directory,
> we only focus on the headers.

I like this

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

will queue after giving people a bit of time for review.

> Philippe Mathieu-Daudé (4):
>   tests: Remove unused include
>   hw/smbios: Restrict access to "smbios_ipmi.h"
>   hw/smbios: Remove "smbios_ipmi.h"
>   hw/smbios: Move to the hw/firmware/ namespace
> 
>  MAINTAINERS                              |  2 +-
>  hw/arm/virt.c                            |  2 +-
>  hw/i386/pc.c                             |  2 +-
>  hw/i386/pc_piix.c                        |  2 +-
>  hw/i386/pc_q35.c                         |  2 +-
>  hw/smbios/smbios-stub.c                  |  2 +-
>  hw/smbios/smbios.c                       |  3 +--
>  hw/smbios/smbios_build.h                 |  4 ++++
>  hw/smbios/smbios_type_38-stub.c          |  2 +-
>  hw/smbios/smbios_type_38.c               |  3 +--
>  include/hw/{smbios => firmware}/smbios.h |  0
>  include/hw/smbios/ipmi.h                 | 15 ---------------
>  tests/acpi-utils.c                       |  1 -
>  tests/bios-tables-test.c                 |  2 +-
>  vl.c                                     |  2 +-
>  15 files changed, 15 insertions(+), 29 deletions(-)
>  rename include/hw/{smbios => firmware}/smbios.h (100%)
>  delete mode 100644 include/hw/smbios/ipmi.h
> 
> -- 
> 2.17.2