I picked up the patch series from Fam and rebased it to current master
(which involved a major rework on the test case) and tried to address
Markus' review comments for v2. I did not do any further review of the
actual code, but it passes the tests, so I guess having it in tree is
better than continuing to let it bitrot.

v4:
- Use "legacyESX" in QAPI instead of "legacyesx" (requires an additional
  exception from the QAPI rules, but the string is directly written into
  the VMDK file, and "legacyESX" is the spelling in the spec). The
  QemuOpts based parser stays case sensitive in v4. [Markus]
- Documentation fixes [Markus]
- Added tests for adapter types
- Added patch 5 to forbid excess extents in blockdev-create [Markus]

Fam Zheng (3):
  vmdk: Refactor vmdk_create_extent
  vmdk: Implement .bdrv_co_create callback
  iotests: Filter cid numbers in VMDK extent info

Kevin Wolf (2):
  iotests: Add VMDK tests for blockdev-create
  vmdk: Reject excess extents in blockdev-create

 qapi/block-core.json             |  71 +++++
 qapi/qapi-schema.json            |  16 +-
 block/vmdk.c                     | 532 ++++++++++++++++++++++---------
 tests/qemu-iotests/237           | 237 ++++++++++++++
 tests/qemu-iotests/237.out       | 348 ++++++++++++++++++++
 tests/qemu-iotests/common.filter |   1 +
 tests/qemu-iotests/group         |   1 +
 tests/qemu-iotests/iotests.py    |   1 +
 8 files changed, 1049 insertions(+), 158 deletions(-)
 create mode 100755 tests/qemu-iotests/237
 create mode 100644 tests/qemu-iotests/237.out

-- 
2.19.2

Patchew URL: https://patchew.org/QEMU/20181207115343.6747-1-kwolf@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20181207115343.6747-1-kwolf@redhat.com
Subject: [Qemu-devel] [PATCH v4 0/5] vmdk: Implement blockdev-create
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
914b679 vmdk: Reject excess extents in blockdev-create
2721cff iotests: Add VMDK tests for blockdev-create
c098e37 iotests: Filter cid numbers in VMDK extent info
3e8f068 vmdk: Implement .bdrv_co_create callback
54b29ff vmdk: Refactor vmdk_create_extent

=== OUTPUT BEGIN ===
Checking PATCH 1/5: vmdk: Refactor vmdk_create_extent...
WARNING: line over 80 characters
#125: FILE: block/vmdk.c:2114:
+                               flat, compress, zeroed_grain, NULL, opts, errp)) {

total: 0 errors, 1 warnings, 104 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/5: vmdk: Implement .bdrv_co_create callback...
WARNING: line over 80 characters
#216: FILE: block/vmdk.c:2075:
+        bdrv_get_full_backing_filename_from_filename(blk_bs(blk)->filename, backing_file,

WARNING: line over 80 characters
#371: FILE: block/vmdk.c:2174:
+                                            bool flat, bool split, bool compress,

WARNING: line over 80 characters
#389: FILE: block/vmdk.c:2192:
+        rel_filename = g_strdup_printf("%s-flat%s", data->prefix, data->postfix);

WARNING: line over 80 characters
#406: FILE: block/vmdk.c:2209:
+static int coroutine_fn vmdk_co_create_opts(const char *filename, QemuOpts *opts,

total: 0 errors, 4 warnings, 658 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/5: iotests: Filter cid numbers in VMDK extent info...
Checking PATCH 4/5: iotests: Add VMDK tests for blockdev-create...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11: 
new file mode 100755

ERROR: trailing whitespace
#282: FILE: tests/qemu-iotests/237.out:28:
+            format: $

ERROR: trailing whitespace
#309: FILE: tests/qemu-iotests/237.out:55:
+            format: $

ERROR: trailing whitespace
#336: FILE: tests/qemu-iotests/237.out:82:
+            format: $

total: 3 errors, 1 warnings, 584 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/5: vmdk: Reject excess extents in blockdev-create...
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20181207115343.6747-1-kwolf@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com