[Qemu-devel] [PATCH v3 0/3] qapi: return ShutdownCause for events

Dominik Csapak posted 3 patches 23 weeks ago
Test checkpatch passed
Test docker-quick@centos7 passed
Test docker-clang@ubuntu passed
Test docker-mingw@fedora passed
Test asan passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181205110131.23049-1-d.csapak@proxmox.com
include/sysemu/sysemu.h    | 20 --------------------
qapi/run-state.json        | 44 ++++++++++++++++++++++++++++++++++++++++++--
qmp.c                      |  4 ++--
tests/qemu-iotests/060.out |  4 ++--
tests/qemu-iotests/071.out |  4 ++--
tests/qemu-iotests/081.out | 14 +++++++-------
tests/qemu-iotests/087.out | 12 ++++++------
tests/qemu-iotests/094.out |  2 +-
tests/qemu-iotests/109.out | 44 ++++++++++++++++++++++----------------------
tests/qemu-iotests/117.out |  2 +-
tests/qemu-iotests/119.out |  2 +-
tests/qemu-iotests/120.out |  2 +-
tests/qemu-iotests/127.out |  2 +-
tests/qemu-iotests/140.out |  2 +-
tests/qemu-iotests/143.out |  2 +-
tests/qemu-iotests/156.out |  2 +-
tests/qemu-iotests/176.out | 16 ++++++++--------
tests/qemu-iotests/183.out |  4 ++--
tests/qemu-iotests/184.out | 12 ++++++++----
tests/qemu-iotests/185.out | 10 +++++-----
tests/qemu-iotests/191.out |  6 ++++--
tests/qemu-iotests/195.out |  6 ++++--
tests/qemu-iotests/223.out |  2 +-
tests/qemu-iotests/227.out | 12 ++++++++----
vl.c                       |  4 ++--
25 files changed, 133 insertions(+), 101 deletions(-)

[Qemu-devel] [PATCH v3 0/3] qapi: return ShutdownCause for events

Posted by Dominik Csapak 23 weeks ago
This series improves the QMP SHUTDOWN and RESET events by adding
the ShutdownCause as additional parameter and splitting
the HOST_QMP reason into HOST_QMP_QUIT and HOST_QMP_SYSTEM_RESET
to be able to detect the difference between them when using '--no-reboot'

this is an alternative to my previous patches[1][2] which
added an exit-script/added a 'reset' argument to the events

 1: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg00697.html
 2: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg01271.html

changes from v2:
* better wording for the iotest changes
* typo fix (ouput -> output)
* added a '(since 4.0)' to the reason in the events

changes from v1:
* explain the reason for the patches in more detail in commit messages
* better punctuation and wording in commit messages
* switched patch 2 and 3
* fix iotests after both 2 and 3
* added documentation for 'reason' in the SHUTDOWN/RESET events
  (this was missing in v1)

Dominik Csapak (3):
  qapi: Turn ShutdownCause into QAPI enum
  qapi: Add reason to SHUTDOWN and RESET events
  qapi: Split host-qmp into quit and system-reset

 include/sysemu/sysemu.h    | 20 --------------------
 qapi/run-state.json        | 44 ++++++++++++++++++++++++++++++++++++++++++--
 qmp.c                      |  4 ++--
 tests/qemu-iotests/060.out |  4 ++--
 tests/qemu-iotests/071.out |  4 ++--
 tests/qemu-iotests/081.out | 14 +++++++-------
 tests/qemu-iotests/087.out | 12 ++++++------
 tests/qemu-iotests/094.out |  2 +-
 tests/qemu-iotests/109.out | 44 ++++++++++++++++++++++----------------------
 tests/qemu-iotests/117.out |  2 +-
 tests/qemu-iotests/119.out |  2 +-
 tests/qemu-iotests/120.out |  2 +-
 tests/qemu-iotests/127.out |  2 +-
 tests/qemu-iotests/140.out |  2 +-
 tests/qemu-iotests/143.out |  2 +-
 tests/qemu-iotests/156.out |  2 +-
 tests/qemu-iotests/176.out | 16 ++++++++--------
 tests/qemu-iotests/183.out |  4 ++--
 tests/qemu-iotests/184.out | 12 ++++++++----
 tests/qemu-iotests/185.out | 10 +++++-----
 tests/qemu-iotests/191.out |  6 ++++--
 tests/qemu-iotests/195.out |  6 ++++--
 tests/qemu-iotests/223.out |  2 +-
 tests/qemu-iotests/227.out | 12 ++++++++----
 vl.c                       |  4 ++--
 25 files changed, 133 insertions(+), 101 deletions(-)

-- 
2.11.0



Re: [Qemu-devel] [PATCH v3 0/3] qapi: return ShutdownCause for events

Posted by Markus Armbruster 23 weeks ago
Dominik Csapak <d.csapak@proxmox.com> writes:

> This series improves the QMP SHUTDOWN and RESET events by adding
> the ShutdownCause as additional parameter and splitting
> the HOST_QMP reason into HOST_QMP_QUIT and HOST_QMP_SYSTEM_RESET
> to be able to detect the difference between them when using '--no-reboot'
>
> this is an alternative to my previous patches[1][2] which
> added an exit-script/added a 'reset' argument to the events
>
>  1: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg00697.html
>  2: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg01271.html

Queued, thanks!

Re: [Qemu-devel] [PATCH v3 0/3] qapi: return ShutdownCause for events

Posted by Markus Armbruster 23 weeks ago
Dominik Csapak <d.csapak@proxmox.com> writes:

> This series improves the QMP SHUTDOWN and RESET events by adding
> the ShutdownCause as additional parameter and splitting
> the HOST_QMP reason into HOST_QMP_QUIT and HOST_QMP_SYSTEM_RESET
> to be able to detect the difference between them when using '--no-reboot'
>
> this is an alternative to my previous patches[1][2] which
> added an exit-script/added a 'reset' argument to the events
>
>  1: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg00697.html
>  2: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg01271.html

Next time, please add the Reviewed-bys you got for the previous version
to your commit messages, unless the commits changed enough to warrant
another round of review.

For the record, series again
Reviewed-by: Markus Armbruster <armbru@redhat.com>

Re: [Qemu-devel] [PATCH v3 0/3] qapi: return ShutdownCause for events

Posted by Dominik Csapak 23 weeks ago
On 12/5/18 1:21 PM, Markus Armbruster wrote:
> Dominik Csapak <d.csapak@proxmox.com> writes:
> 
>> This series improves the QMP SHUTDOWN and RESET events by adding
>> the ShutdownCause as additional parameter and splitting
>> the HOST_QMP reason into HOST_QMP_QUIT and HOST_QMP_SYSTEM_RESET
>> to be able to detect the difference between them when using '--no-reboot'
>>
>> this is an alternative to my previous patches[1][2] which
>> added an exit-script/added a 'reset' argument to the events
>>
>>   1: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg00697.html
>>   2: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg01271.html
> 
> Next time, please add the Reviewed-bys you got for the previous version
> to your commit messages, unless the commits changed enough to warrant
> another round of review.

Yes of course, sorry for that.

Thank you again for the review.

> 
> For the record, series again
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> 
>