[Qemu-devel] [PATCH 0/5] crypto threads

Vladimir Sementsov-Ogievskiy posted 5 patches 1 week ago
Test asan failed
Test checkpatch passed
Test docker-quick@centos7 failed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181204184657.78028-1-vsementsov@virtuozzo.com
crypto/blockpriv.h        |  42 ++++++--
include/crypto/block.h    |  16 ++-
block/crypto.c            |   1 +
block/qcow.c              |   2 +-
block/qcow2.c             |   4 +-
crypto/block-luks.c       |  60 +++++------
crypto/block-qcow.c       |  26 ++---
crypto/block.c            | 210 ++++++++++++++++++++++++++++----------
tests/test-crypto-block.c |   2 +
9 files changed, 257 insertions(+), 106 deletions(-)

[Qemu-devel] [PATCH 0/5] crypto threads

Posted by Vladimir Sementsov-Ogievskiy 1 week ago
Hi all.

These series are preliminary step before moving encryption code in
qcow2 to the threads. The first attempt of doing it is on list
([PATCH 00/11] qcow2: encryption threads : 
 https://lists.gnu.org/archive/html/qemu-block/2018-11/msg00729.html)
But it's approach with multiplying the whole QCryptoBlock per thread
was rejected. So, here is a solution to maintain multitasking inside
QCryptoBlock.

Patch 01 may be considered as 3.1-rc4 material, others are ofcourse
for 4.0.

Vladimir Sementsov-Ogievskiy (5):
  crypto/block-luks: fix memory leak in qcrypto_block_luks_create
  crypto/block: refactor qcrypto_block_*crypt_helper functions
  crypto/block: rename qcrypto_block_*crypt_helper
  crypto/block: introduce qcrypto_block_*crypt_helper functions
  crypto: support multiple threads accessing one QCryptoBlock

 crypto/blockpriv.h        |  42 ++++++--
 include/crypto/block.h    |  16 ++-
 block/crypto.c            |   1 +
 block/qcow.c              |   2 +-
 block/qcow2.c             |   4 +-
 crypto/block-luks.c       |  60 +++++------
 crypto/block-qcow.c       |  26 ++---
 crypto/block.c            | 210 ++++++++++++++++++++++++++++----------
 tests/test-crypto-block.c |   2 +
 9 files changed, 257 insertions(+), 106 deletions(-)

-- 
2.18.0


Re: [Qemu-devel] [PATCH 0/5] crypto threads

Posted by no-reply@patchew.org 1 week ago
Patchew URL: https://patchew.org/QEMU/20181204184657.78028-1-vsementsov@virtuozzo.com/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-quick@centos7 SHOW_ENV=1 J=8
=== TEST SCRIPT END ===

libpmem support   no
libudev           no

WARNING: Use of SDL 1.2 is deprecated and will be removed in
WARNING: future releases. Please switch to using SDL 2.0

NOTE: cross-compilers enabled:  'cc'
  GEN     x86_64-softmmu/config-devices.mak.tmp
---
  CC      tests/usb-hcd-uhci-test.o
  CC      tests/usb-hcd-xhci-test.o
/tmp/qemu-test/src/tests/test-crypto-block.c: In function 'test_block':
/tmp/qemu-test/src/tests/test-crypto-block.c:310:30: error: passing argument 6 of 'qcrypto_block_open' makes integer from pointer without a cast [-Werror]
                              NULL);
                              ^
In file included from /tmp/qemu-test/src/tests/test-crypto-block.c:24:0:
/tmp/qemu-test/src/include/crypto/block.h:107:15: note: expected 'int' but argument is of type 'void *'
 QCryptoBlock *qcrypto_block_open(QCryptoBlockOpenOptions *options,
               ^
/tmp/qemu-test/src/tests/test-crypto-block.c:310:30: error: too few arguments to function 'qcrypto_block_open'
                              NULL);
                              ^
In file included from /tmp/qemu-test/src/tests/test-crypto-block.c:24:0:
/tmp/qemu-test/src/include/crypto/block.h:107:15: note: declared here
 QCryptoBlock *qcrypto_block_open(QCryptoBlockOpenOptions *options,
               ^
/tmp/qemu-test/src/tests/test-crypto-block.c:318:30: error: passing argument 6 of 'qcrypto_block_open' makes integer from pointer without a cast [-Werror]
                              &error_abort);
                              ^
In file included from /tmp/qemu-test/src/tests/test-crypto-block.c:24:0:
/tmp/qemu-test/src/include/crypto/block.h:107:15: note: expected 'int' but argument is of type 'struct Error **'
 QCryptoBlock *qcrypto_block_open(QCryptoBlockOpenOptions *options,
               ^
/tmp/qemu-test/src/tests/test-crypto-block.c:318:30: error: too few arguments to function 'qcrypto_block_open'
                              &error_abort);
                              ^
In file included from /tmp/qemu-test/src/tests/test-crypto-block.c:24:0:
/tmp/qemu-test/src/include/crypto/block.h:107:15: note: declared here
 QCryptoBlock *qcrypto_block_open(QCryptoBlockOpenOptions *options,
               ^
/tmp/qemu-test/src/tests/test-crypto-block.c:332:30: error: passing argument 6 of 'qcrypto_block_open' makes integer from pointer without a cast [-Werror]
                              &error_abort);
                              ^
In file included from /tmp/qemu-test/src/tests/test-crypto-block.c:24:0:
/tmp/qemu-test/src/include/crypto/block.h:107:15: note: expected 'int' but argument is of type 'struct Error **'
 QCryptoBlock *qcrypto_block_open(QCryptoBlockOpenOptions *options,
               ^
/tmp/qemu-test/src/tests/test-crypto-block.c:332:30: error: too few arguments to function 'qcrypto_block_open'
                              &error_abort);
                              ^
In file included from /tmp/qemu-test/src/tests/test-crypto-block.c:24:0:


The full log is available at
http://patchew.org/logs/20181204184657.78028-1-vsementsov@virtuozzo.com/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com