[Qemu-devel] [PATCH v3 00/21] QOM'ify SysBusDeviceClass->init

Mao Zhongyi posted 21 patches 5 years, 4 months ago
Test asan passed
Test checkpatch passed
Test docker-quick@centos7 passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181130093852.20739-1-maozhongyi@cmss.chinamobile.com
hw/arm/musicpal.c            |  9 ++++-----
hw/block/onenand.c           | 16 +++++++---------
hw/char/grlib_apbuart.c      | 12 +++++-------
hw/core/empty_slot.c         |  9 ++++-----
hw/core/sysbus.c             | 15 +++++----------
hw/display/g364fb.c          |  9 +++------
hw/dma/puv3_dma.c            | 10 ++++------
hw/gpio/puv3_gpio.c          | 29 ++++++++++++++---------------
hw/input/milkymist-softusb.c | 16 +++++++---------
hw/input/pl050.c             | 11 +++++------
hw/intc/puv3_intc.c          | 11 ++++-------
hw/misc/milkymist-hpdmc.c    |  9 +++------
hw/misc/milkymist-pfpu.c     | 12 +++++-------
hw/misc/puv3_pm.c            | 10 ++++------
hw/nvram/ds1225y.c           | 12 +++++-------
hw/pci-bridge/dec.c          | 12 ++++++------
hw/timer/etraxfs_timer.c     | 14 +++++++-------
hw/timer/grlib_gptimer.c     | 11 +++++------
hw/timer/puv3_ost.c          | 13 ++++++-------
hw/usb/tusb6010.c            |  8 +++-----
hw/xen/xen_backend.c         |  7 -------
include/hw/sysbus.h          |  3 ---
22 files changed, 106 insertions(+), 152 deletions(-)
[Qemu-devel] [PATCH v3 00/21] QOM'ify SysBusDeviceClass->init
Posted by Mao Zhongyi 5 years, 4 months ago
v3 -> v2:

- rebase to the HEAD
- use SysBusDevice *sbd variable in patch15

v2 -> v1:

- SYS_BUS_DEVICE(dev) was used in a function several
  times, so use a variable 'sbd' to replace it, like:
  SysBusDevice *sbd = SYS_BUS_DEVICE(dev);
- remove the xen_sysdev_init() function
- drop the patch21 in v1
- fix the broken in sysbus_realize of patch22

Cc: alistair.francis@wdc.com
Cc: anthony.perard@citrix.com
Cc: armbru@redhat.com
Cc: borntraeger@de.ibm.com
Cc: chouteau@adacore.com
Cc: cohuck@redhat.com
Cc: david@gibson.dropbear.id.au
Cc: david@redhat.com
Cc: edgar.iglesias@gmail.com
Cc: ehabkost@redhat.com
Cc: f4bug@amsat.org
Cc: gxt@mprc.pku.edu.cn
Cc: jan.kiszka@web.de
Cc: kraxel@redhat.com
Cc: kwolf@redhat.com
Cc: marcandre.lureau@redhat.com
Cc: marcel.apfelbaum@gmail.com
Cc: michael@walle.cc
Cc: mreitz@redhat.com
Cc: mst@redhat.com
Cc: pbonzini@redhat.com
Cc: peter.maydell@linaro.org                                                                                                                                                                  
Cc: qemu-arm@nongnu.org
Cc: qemu-block@nongnu.org
Cc: qemu-ppc@nongnu.org
Cc: qemu-s390x@nongnu.org
Cc: richard.henderson@linaro.org
Cc: rth@twiddle.net
Cc: sstabellini@kernel.org
Cc: thuth@redhat.com
Cc: xen-devel@lists.xenproject.org

Mao Zhongyi (21):
  musicpal: Convert sysbus init function to realize function
  block/noenand: Convert sysbus init function to realize function
  char/grlib_apbuart: Convert sysbus init function to realize function
  core/empty_slot: Convert sysbus init function to realize function
  display/g364fb: Convert sysbus init function to realize function
  dma/puv3_dma: Convert sysbus init function to realize function
  gpio/puv3_gpio: Convert sysbus init function to realize function
  milkymist-softusb: Convert sysbus init function to realize function
  input/pl050: Convert sysbus init function to realize function
  intc/puv3_intc: Convert sysbus init function to realize function
  milkymist-hpdmc: Convert sysbus init function to realize function
  milkymist-pfpu: Convert sysbus init function to realize function
  puv3_pm.c: Convert sysbus init function to realize function
  nvram/ds1225y: Convert sysbus init function to realize function
  pci-bridge/dec: Convert sysbus init function to realize function
  timer/etraxfs_timer: Convert sysbus init function to realize function
  timer/grlib_gptimer: Convert sysbus init function to realize function
  timer/puv3_ost: Convert sysbus init function to realize function
  usb/tusb6010: Convert sysbus init function to realize function
  xen_backend: remove xen_sysdev_init() function
  core/sysbus: remove the SysBusDeviceClass::init path

 hw/arm/musicpal.c            |  9 ++++-----
 hw/block/onenand.c           | 16 +++++++---------
 hw/char/grlib_apbuart.c      | 12 +++++-------
 hw/core/empty_slot.c         |  9 ++++-----
 hw/core/sysbus.c             | 15 +++++----------
 hw/display/g364fb.c          |  9 +++------
 hw/dma/puv3_dma.c            | 10 ++++------
 hw/gpio/puv3_gpio.c          | 29 ++++++++++++++---------------
 hw/input/milkymist-softusb.c | 16 +++++++---------
 hw/input/pl050.c             | 11 +++++------
 hw/intc/puv3_intc.c          | 11 ++++-------
 hw/misc/milkymist-hpdmc.c    |  9 +++------
 hw/misc/milkymist-pfpu.c     | 12 +++++-------
 hw/misc/puv3_pm.c            | 10 ++++------
 hw/nvram/ds1225y.c           | 12 +++++-------
 hw/pci-bridge/dec.c          | 12 ++++++------
 hw/timer/etraxfs_timer.c     | 14 +++++++-------
 hw/timer/grlib_gptimer.c     | 11 +++++------
 hw/timer/puv3_ost.c          | 13 ++++++-------
 hw/usb/tusb6010.c            |  8 +++-----
 hw/xen/xen_backend.c         |  7 -------
 include/hw/sysbus.h          |  3 ---
 22 files changed, 106 insertions(+), 152 deletions(-)

-- 
2.17.1




Re: [Qemu-devel] [PATCH v3 00/21] QOM'ify SysBusDeviceClass->init
Posted by Peter Maydell 5 years, 4 months ago
On Fri, 30 Nov 2018 at 09:39, Mao Zhongyi
<maozhongyi@cmss.chinamobile.com> wrote:
>
> v3 -> v2:
>
> - rebase to the HEAD
> - use SysBusDevice *sbd variable in patch15

> Mao Zhongyi (21):
>   musicpal: Convert sysbus init function to realize function
>   block/noenand: Convert sysbus init function to realize function
>   char/grlib_apbuart: Convert sysbus init function to realize function
>   core/empty_slot: Convert sysbus init function to realize function
>   display/g364fb: Convert sysbus init function to realize function
>   dma/puv3_dma: Convert sysbus init function to realize function
>   gpio/puv3_gpio: Convert sysbus init function to realize function
>   milkymist-softusb: Convert sysbus init function to realize function
>   input/pl050: Convert sysbus init function to realize function
>   intc/puv3_intc: Convert sysbus init function to realize function
>   milkymist-hpdmc: Convert sysbus init function to realize function
>   milkymist-pfpu: Convert sysbus init function to realize function
>   puv3_pm.c: Convert sysbus init function to realize function
>   nvram/ds1225y: Convert sysbus init function to realize function
>   pci-bridge/dec: Convert sysbus init function to realize function
>   timer/etraxfs_timer: Convert sysbus init function to realize function
>   timer/grlib_gptimer: Convert sysbus init function to realize function
>   timer/puv3_ost: Convert sysbus init function to realize function
>   usb/tusb6010: Convert sysbus init function to realize function
>   xen_backend: remove xen_sysdev_init() function
>   core/sysbus: remove the SysBusDeviceClass::init path
>
>  hw/arm/musicpal.c            |  9 ++++-----
>  hw/block/onenand.c           | 16 +++++++---------
>  hw/char/grlib_apbuart.c      | 12 +++++-------
>  hw/core/empty_slot.c         |  9 ++++-----
>  hw/core/sysbus.c             | 15 +++++----------
>  hw/display/g364fb.c          |  9 +++------
>  hw/dma/puv3_dma.c            | 10 ++++------
>  hw/gpio/puv3_gpio.c          | 29 ++++++++++++++---------------
>  hw/input/milkymist-softusb.c | 16 +++++++---------
>  hw/input/pl050.c             | 11 +++++------
>  hw/intc/puv3_intc.c          | 11 ++++-------
>  hw/misc/milkymist-hpdmc.c    |  9 +++------
>  hw/misc/milkymist-pfpu.c     | 12 +++++-------
>  hw/misc/puv3_pm.c            | 10 ++++------
>  hw/nvram/ds1225y.c           | 12 +++++-------
>  hw/pci-bridge/dec.c          | 12 ++++++------
>  hw/timer/etraxfs_timer.c     | 14 +++++++-------
>  hw/timer/grlib_gptimer.c     | 11 +++++------
>  hw/timer/puv3_ost.c          | 13 ++++++-------
>  hw/usb/tusb6010.c            |  8 +++-----
>  hw/xen/xen_backend.c         |  7 -------
>  include/hw/sysbus.h          |  3 ---
>  22 files changed, 106 insertions(+), 152 deletions(-)

I think all these patches have now been reviewed. Does anybody
have a preference for which tree it goes through, given that it
touches lots of devices?

I can take this via target-arm, unless anybody would particularly
like to have some or all of it go some other route.

thanks
-- PMM