I'm working on a larger series for 4.0 that will add
'qemu-nbd --list' to show all possible information about a
server's exports, to make it easier to diagnose if the right
exports and bitmaps are present.  But in the process, I found
a few bugs that may be worth fixing in 3.1.  By itself, this
series does not warrant -rc4 (particularly since all of the
problems exist in the 3.0 release, so this is not a regression
fix), but if we have -rc4 for other reasons, these would make
incremental backup support a bit more reliable.

Eric Blake (3):
  nbd/server: Advertise all contexts in response to bare LIST
  nbd/client: Make x-dirty-bitmap more reliable
  nbd/client: Send NBD_CMD_DISC if open fails after connect

 block/nbd-client.c | 21 ++++++++++++++++++++-
 nbd/server.c       |  1 +
 2 files changed, 21 insertions(+), 1 deletion(-)

-- 
2.17.2

On 11/29/18 8:32 PM, Eric Blake wrote:
> I'm working on a larger series for 4.0 that will add
> 'qemu-nbd --list' to show all possible information about a
> server's exports, to make it easier to diagnose if the right
> exports and bitmaps are present.  But in the process, I found
> a few bugs that may be worth fixing in 3.1.  By itself, this
> series does not warrant -rc4 (particularly since all of the
> problems exist in the 3.0 release, so this is not a regression
> fix), but if we have -rc4 for other reasons, these would make
> incremental backup support a bit more reliable.

And CVEs might be the reason for an -rc4. I'm queuing this on my NBD 
tree, ready to send a Pull Request by early Monday if we indeed end up 
with an -rc4.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

On Fri, 30 Nov 2018 at 15:36, Eric Blake <eblake@redhat.com> wrote:
>
> On 11/29/18 8:32 PM, Eric Blake wrote:
> > I'm working on a larger series for 4.0 that will add
> > 'qemu-nbd --list' to show all possible information about a
> > server's exports, to make it easier to diagnose if the right
> > exports and bitmaps are present.  But in the process, I found
> > a few bugs that may be worth fixing in 3.1.  By itself, this
> > series does not warrant -rc4 (particularly since all of the
> > problems exist in the 3.0 release, so this is not a regression
> > fix), but if we have -rc4 for other reasons, these would make
> > incremental backup support a bit more reliable.
>
> And CVEs might be the reason for an -rc4. I'm queuing this on my NBD
> tree, ready to send a Pull Request by early Monday if we indeed end up
> with an -rc4.

...which we will, so would you like to send that pullreq ?

thanks
-- PMM