[Qemu-devel] [PATCH RFC v5 0/5] virtio-iommu: VFIO integration

Bharat Bhushan posted 5 patches 5 years, 4 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
hw/vfio/common.c                 |   2 -
hw/virtio/trace-events           |   5 +
hw/virtio/virtio-iommu.c         | 190 ++++++++++++++++++++++++++++++-
include/hw/virtio/virtio-iommu.h |   6 +
4 files changed, 198 insertions(+), 5 deletions(-)
[Qemu-devel] [PATCH RFC v5 0/5] virtio-iommu: VFIO integration
Posted by Bharat Bhushan 5 years, 4 months ago
This patch series integrates VFIO with virtio-iommu. This is
tested with assigning 2 pci devices to Virtual Machine.

This version is mainly about rebasing on v9 version on
virtio-iommu device framework from Eric Augur.

This patch series allows PCI pass-through using virtio-iommu.

This series is based on:
 - virtio-iommu kernel driver by Jean-Philippe Brucker
    [PATCH v5 0/7] Add virtio-iommu driver
    git://linux-arm.org/kvmtool-jpb.git virtio-iommu/v0.9

 - virtio-iommu device emulation by Eric Augur.
   [RFC,v9,00/17] VIRTIO-IOMMU device
   https://github.com/eauger/qemu/tree/v3.1.0-rc2-virtio-iommu-v0.9

v4->v5:
 - Rebase to v9 version from Eric
 - PCIe device hotplug fix
 - Added Patch 1/5 from Eric previous series (Eric somehow dropped in
   last version.
 - Patch "Translate the MSI doorbell in kvm_arch_fixup_msi_route"
   already integrated with vsmmu3

v3->v4:
 - Rebase to v4 version from Eric
 - Fixes from Eric with DPDK in VM
 - Logical division in multiple patches

v2->v3:
 - This series is based on "[RFC v3 0/8] VIRTIO-IOMMU device"
   Which is based on top of v2.10-rc0 that
 - Fixed issue with two PCI devices
 - Addressed review comments

v1->v2:
  - Added trace events
  - removed vSMMU3 link in patch description

Bharat Bhushan (4):
  virtio-iommu: Add iommu notifier for iommu-map/unmap
  virtio-iommu: Call iommu notifier on attach/detach
  virtio-iommu: add virtio-iommu replay
  virtio-iommu: handle IOMMU Notifier flag changes

Eric Auger (1):
  hw/vfio/common: Do not print error when viommu translates into an mmio
    region

 hw/vfio/common.c                 |   2 -
 hw/virtio/trace-events           |   5 +
 hw/virtio/virtio-iommu.c         | 190 ++++++++++++++++++++++++++++++-
 include/hw/virtio/virtio-iommu.h |   6 +
 4 files changed, 198 insertions(+), 5 deletions(-)

-- 
2.19.1


Re: [Qemu-devel] [PATCH RFC v5 0/5] virtio-iommu: VFIO integration
Posted by Auger Eric 4 years, 1 month ago
Hi Bharat,

On 11/27/18 7:52 AM, Bharat Bhushan wrote:
> This patch series integrates VFIO with virtio-iommu. This is
> tested with assigning 2 pci devices to Virtual Machine.
> 
> This version is mainly about rebasing on v9 version on
> virtio-iommu device framework from Eric Augur.
> 
> This patch series allows PCI pass-through using virtio-iommu.
> 
> This series is based on:
>  - virtio-iommu kernel driver by Jean-Philippe Brucker
>     [PATCH v5 0/7] Add virtio-iommu driver
>     git://linux-arm.org/kvmtool-jpb.git virtio-iommu/v0.9
> 
>  - virtio-iommu device emulation by Eric Augur.
>    [RFC,v9,00/17] VIRTIO-IOMMU device
>    https://github.com/eauger/qemu/tree/v3.1.0-rc2-virtio-iommu-v0.9

Now we have the driver and the base qemu device upstream we may resume
this activity to complete the VFIO integration. Do you intend the
respin? Otherwise let me know if you want me to help.

Thanks

Eric
> 
> v4->v5:
>  - Rebase to v9 version from Eric
>  - PCIe device hotplug fix
>  - Added Patch 1/5 from Eric previous series (Eric somehow dropped in
>    last version.
>  - Patch "Translate the MSI doorbell in kvm_arch_fixup_msi_route"
>    already integrated with vsmmu3
> 
> v3->v4:
>  - Rebase to v4 version from Eric
>  - Fixes from Eric with DPDK in VM
>  - Logical division in multiple patches
> 
> v2->v3:
>  - This series is based on "[RFC v3 0/8] VIRTIO-IOMMU device"
>    Which is based on top of v2.10-rc0 that
>  - Fixed issue with two PCI devices
>  - Addressed review comments
> 
> v1->v2:
>   - Added trace events
>   - removed vSMMU3 link in patch description
> 
> Bharat Bhushan (4):
>   virtio-iommu: Add iommu notifier for iommu-map/unmap
>   virtio-iommu: Call iommu notifier on attach/detach
>   virtio-iommu: add virtio-iommu replay
>   virtio-iommu: handle IOMMU Notifier flag changes
> 
> Eric Auger (1):
>   hw/vfio/common: Do not print error when viommu translates into an mmio
>     region
> 
>  hw/vfio/common.c                 |   2 -
>  hw/virtio/trace-events           |   5 +
>  hw/virtio/virtio-iommu.c         | 190 ++++++++++++++++++++++++++++++-
>  include/hw/virtio/virtio-iommu.h |   6 +
>  4 files changed, 198 insertions(+), 5 deletions(-)
> 


Re: [Qemu-devel] [PATCH RFC v5 0/5] virtio-iommu: VFIO integration
Posted by Bharat Bhushan 4 years, 1 month ago
Hi Eric,

On Fri, Feb 28, 2020 at 3:06 PM Auger Eric <eric.auger@redhat.com> wrote:

> Hi Bharat,
>
> On 11/27/18 7:52 AM, Bharat Bhushan wrote:
> > This patch series integrates VFIO with virtio-iommu. This is
> > tested with assigning 2 pci devices to Virtual Machine.
> >
> > This version is mainly about rebasing on v9 version on
> > virtio-iommu device framework from Eric Augur.
> >
> > This patch series allows PCI pass-through using virtio-iommu.
> >
> > This series is based on:
> >  - virtio-iommu kernel driver by Jean-Philippe Brucker
> >     [PATCH v5 0/7] Add virtio-iommu driver
> >     git://linux-arm.org/kvmtool-jpb.git virtio-iommu/v0.9
> >
> >  - virtio-iommu device emulation by Eric Augur.
> >    [RFC,v9,00/17] VIRTIO-IOMMU device
> >    https://github.com/eauger/qemu/tree/v3.1.0-rc2-virtio-iommu-v0.9
>
> Now we have the driver and the base qemu device upstream we may resume
> this activity to complete the VFIO integration. Do you intend the
> respin? Otherwise let me know if you want me to help.
>
>
Yes Eric, I am planning to respin the changes.

Can you please point to latest changes (qemu/Linux both).

Thanks
-Bharat

Thanks
>
> Eric
> >
> > v4->v5:
> >  - Rebase to v9 version from Eric
> >  - PCIe device hotplug fix
> >  - Added Patch 1/5 from Eric previous series (Eric somehow dropped in
> >    last version.
> >  - Patch "Translate the MSI doorbell in kvm_arch_fixup_msi_route"
> >    already integrated with vsmmu3
> >
> > v3->v4:
> >  - Rebase to v4 version from Eric
> >  - Fixes from Eric with DPDK in VM
> >  - Logical division in multiple patches
> >
> > v2->v3:
> >  - This series is based on "[RFC v3 0/8] VIRTIO-IOMMU device"
> >    Which is based on top of v2.10-rc0 that
> >  - Fixed issue with two PCI devices
> >  - Addressed review comments
> >
> > v1->v2:
> >   - Added trace events
> >   - removed vSMMU3 link in patch description
> >
> > Bharat Bhushan (4):
> >   virtio-iommu: Add iommu notifier for iommu-map/unmap
> >   virtio-iommu: Call iommu notifier on attach/detach
> >   virtio-iommu: add virtio-iommu replay
> >   virtio-iommu: handle IOMMU Notifier flag changes
> >
> > Eric Auger (1):
> >   hw/vfio/common: Do not print error when viommu translates into an mmio
> >     region
> >
> >  hw/vfio/common.c                 |   2 -
> >  hw/virtio/trace-events           |   5 +
> >  hw/virtio/virtio-iommu.c         | 190 ++++++++++++++++++++++++++++++-
> >  include/hw/virtio/virtio-iommu.h |   6 +
> >  4 files changed, 198 insertions(+), 5 deletions(-)
> >
>
>

-- 
-Bharat
Re: [Qemu-devel] [PATCH RFC v5 0/5] virtio-iommu: VFIO integration
Posted by Auger Eric 4 years, 1 month ago
Hi Bharat,

On 3/2/20 6:12 AM, Bharat Bhushan wrote:
> 
> Hi Eric, 
> 
> On Fri, Feb 28, 2020 at 3:06 PM Auger Eric <eric.auger@redhat.com
> <mailto:eric.auger@redhat.com>> wrote:
> 
>     Hi Bharat,
> 
>     On 11/27/18 7:52 AM, Bharat Bhushan wrote:
>     > This patch series integrates VFIO with virtio-iommu. This is
>     > tested with assigning 2 pci devices to Virtual Machine.
>     >
>     > This version is mainly about rebasing on v9 version on
>     > virtio-iommu device framework from Eric Augur.
>     >
>     > This patch series allows PCI pass-through using virtio-iommu.
>     >
>     > This series is based on:
>     >  - virtio-iommu kernel driver by Jean-Philippe Brucker
>     >     [PATCH v5 0/7] Add virtio-iommu driver
>     >     git://linux-arm.org/kvmtool-jpb.git
>     <http://linux-arm.org/kvmtool-jpb.git> virtio-iommu/v0.9
>     >
>     >  - virtio-iommu device emulation by Eric Augur.
>     >    [RFC,v9,00/17] VIRTIO-IOMMU device
>     >    https://github.com/eauger/qemu/tree/v3.1.0-rc2-virtio-iommu-v0.9
> 
>     Now we have the driver and the base qemu device upstream we may resume
>     this activity to complete the VFIO integration. Do you intend the
>     respin? Otherwise let me know if you want me to help.
> 
> 
> Yes Eric, I am planning to respin the changes.
> 
> Can you please point to latest changes (qemu/Linux both).
the driver and the base qemu device are upstream. This only boots in DT
mode at the moment with machvirt. Use -virtio-iommu-pci to instantiate
the device. About the qemu device, you will find latest changes in the
v16 history log: https://patchwork.kernel.org/cover/11382271/

Thanks

Eric

> 
> Thanks
> -Bharat
> 
>     Thanks
> 
>     Eric
>     >
>     > v4->v5:
>     >  - Rebase to v9 version from Eric
>     >  - PCIe device hotplug fix
>     >  - Added Patch 1/5 from Eric previous series (Eric somehow dropped in
>     >    last version.
>     >  - Patch "Translate the MSI doorbell in kvm_arch_fixup_msi_route"
>     >    already integrated with vsmmu3
>     >
>     > v3->v4:
>     >  - Rebase to v4 version from Eric
>     >  - Fixes from Eric with DPDK in VM
>     >  - Logical division in multiple patches
>     >
>     > v2->v3:
>     >  - This series is based on "[RFC v3 0/8] VIRTIO-IOMMU device"
>     >    Which is based on top of v2.10-rc0 that
>     >  - Fixed issue with two PCI devices
>     >  - Addressed review comments
>     >
>     > v1->v2:
>     >   - Added trace events
>     >   - removed vSMMU3 link in patch description
>     >
>     > Bharat Bhushan (4):
>     >   virtio-iommu: Add iommu notifier for iommu-map/unmap
>     >   virtio-iommu: Call iommu notifier on attach/detach
>     >   virtio-iommu: add virtio-iommu replay
>     >   virtio-iommu: handle IOMMU Notifier flag changes
>     >
>     > Eric Auger (1):
>     >   hw/vfio/common: Do not print error when viommu translates into
>     an mmio
>     >     region
>     >
>     >  hw/vfio/common.c                 |   2 -
>     >  hw/virtio/trace-events           |   5 +
>     >  hw/virtio/virtio-iommu.c         | 190
>     ++++++++++++++++++++++++++++++-
>     >  include/hw/virtio/virtio-iommu.h |   6 +
>     >  4 files changed, 198 insertions(+), 5 deletions(-)
>     >
> 
> 
> 
> -- 
> -Bharat