[v3] block: Fix crash on migration with explicit child nodes

[Qemu-devel] [PATCH for-3.1 v3 0/2] block: Fix crash on migration with explicit child nodes

Kevin Wolf posted 2 patches 5 years, 5 months ago

Diff against v1 v2
Download series mbox

Test asan passed

Test checkpatch passed

Test docker-quick@centos7 passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181126160513.26369-1-kwolf@redhat.com

block.c                    |  84 +++++++++++++++----------
tests/qemu-iotests/234     | 121 +++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/234.out |  30 +++++++++
tests/qemu-iotests/group   |   1 +
4 files changed, 205 insertions(+), 31 deletions(-)
create mode 100755 tests/qemu-iotests/234
create mode 100644 tests/qemu-iotests/234.out

Expand all Fold all

[Qemu-devel] [PATCH for-3.1 v3 0/2] block: Fix crash on migration with explicit child nodes

Posted by Kevin Wolf 5 years, 5 months ago

v3:
- Checking whether there are still active parents only really works with
  a single pass, so that's what we do now [Max]
- Test case polishing [Max]

v2:
- Cover children that were created after their parents [Max]

Kevin Wolf (2):
  block: Don't inactivate children before parents
  iotests: Test migration with -blockdev

 block.c                    |  84 +++++++++++++++----------
 tests/qemu-iotests/234     | 121 +++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/234.out |  30 +++++++++
 tests/qemu-iotests/group   |   1 +
 4 files changed, 205 insertions(+), 31 deletions(-)
 create mode 100755 tests/qemu-iotests/234
 create mode 100644 tests/qemu-iotests/234.out

-- 
2.19.1

Re: [Qemu-devel] [PATCH for-3.1 v3 0/2] block: Fix crash on migration with explicit child nodes

Posted by Max Reitz 5 years, 5 months ago

On 26.11.18 17:05, Kevin Wolf wrote:
> v3:
> - Checking whether there are still active parents only really works with
>   a single pass, so that's what we do now [Max]
> - Test case polishing [Max]
> 
> v2:
> - Cover children that were created after their parents [Max]
> 
> Kevin Wolf (2):
>   block: Don't inactivate children before parents
>   iotests: Test migration with -blockdev
> 
>  block.c                    |  84 +++++++++++++++----------
>  tests/qemu-iotests/234     | 121 +++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/234.out |  30 +++++++++
>  tests/qemu-iotests/group   |   1 +
>  4 files changed, 205 insertions(+), 31 deletions(-)
>  create mode 100755 tests/qemu-iotests/234
>  create mode 100644 tests/qemu-iotests/234.out

Reviewed-by: Max Reitz <mreitz@redhat.com>