[v1] MAINTAINERS: Add various missing entries

[Qemu-devel] [PATCH for-3.1 10/25] MAINTAINERS: Add missing entries for the sun4u machines

Posted by Philippe Mathieu-Daudé 7 years, 2 months ago

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index ba9cd9ac2b..d9cddb0cc8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1019,6 +1019,10 @@ Sun4u
 M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
 S: Maintained
 F: hw/sparc64/sun4u.c
+F: hw/sparc64/sun4u_iommu.c
+F: include/hw/sparc/sun4u_iommu.h
+F: hw/pci-host/sabre.c
+F: include/hw/pci-host/sabre.h
 F: pc-bios/openbios-sparc64
 
 Sun4v
-- 
2.17.2

Re: [Qemu-devel] [PATCH for-3.1 10/25] MAINTAINERS: Add missing entries for the sun4u machines

Posted by Mark Cave-Ayland 7 years, 2 months ago

On 25/11/2018 20:49, Philippe Mathieu-Daudé wrote:

> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ba9cd9ac2b..d9cddb0cc8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1019,6 +1019,10 @@ Sun4u
>  M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>  S: Maintained
>  F: hw/sparc64/sun4u.c
> +F: hw/sparc64/sun4u_iommu.c
> +F: include/hw/sparc/sun4u_iommu.h
> +F: hw/pci-host/sabre.c
> +F: include/hw/pci-host/sabre.h
>  F: pc-bios/openbios-sparc64

These are correct, however you also want to add the simba PCI bridges i.e.

F: hw/pci-bridge/simba.c
F: include/hw/pci-bridge/simba.h

So with that:

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.

Re: [Qemu-devel] [PATCH for-3.1 10/25] MAINTAINERS: Add missing entries for the sun4u machines

Posted by Philippe Mathieu-Daudé 7 years, 2 months ago

On 26/11/18 18:05, Mark Cave-Ayland wrote:
> On 25/11/2018 20:49, Philippe Mathieu-Daudé wrote:
> 
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>  MAINTAINERS | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index ba9cd9ac2b..d9cddb0cc8 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1019,6 +1019,10 @@ Sun4u
>>  M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>>  S: Maintained
>>  F: hw/sparc64/sun4u.c
>> +F: hw/sparc64/sun4u_iommu.c
>> +F: include/hw/sparc/sun4u_iommu.h
>> +F: hw/pci-host/sabre.c
>> +F: include/hw/pci-host/sabre.h
>>  F: pc-bios/openbios-sparc64
> 
> These are correct, however you also want to add the simba PCI bridges i.e.
> 
> F: hw/pci-bridge/simba.c
> F: include/hw/pci-bridge/simba.h

OK, will update.

> 
> So with that:
> 
> Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

Thanks!

Phil.