MAINTAINERS: Add an ARM SMMU section

[Qemu-devel] [PATCH for-3.1] MAINTAINERS: Add an ARM SMMU section

Posted by Eric Auger 5 years, 4 months ago

Add a new ARM SMMU section and set Eric Auger as the maintainer
for ARM SMMU emulation sources.

Signed-off-by: Eric Auger <eric.auger@redhat.com>
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
---
 MAINTAINERS | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 1032406c56..3cac9f0a0c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -151,6 +151,13 @@ F: disas/arm.c
 F: disas/arm-a64.cc
 F: disas/libvixl/
 
+ARM SMMU
+M: Eric Auger <eric.auger@redhat.com>
+L: qemu-arm@nongnu.org
+S: Maintained
+F: hw/arm/smmu*
+F: include/hw/arm/smmu*
+
 CRIS
 M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
 S: Maintained
-- 
2.17.2

Re: [Qemu-devel] [PATCH for-3.1] MAINTAINERS: Add an ARM SMMU section

Posted by Philippe Mathieu-Daudé 5 years, 4 months ago

Hi Eric,

On 22/11/18 19:01, Eric Auger wrote:
> Add a new ARM SMMU section and set Eric Auger as the maintainer
> for ARM SMMU emulation sources.
> 
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  MAINTAINERS | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1032406c56..3cac9f0a0c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -151,6 +151,13 @@ F: disas/arm.c
>  F: disas/arm-a64.cc
>  F: disas/libvixl/
>  
> +ARM SMMU
> +M: Eric Auger <eric.auger@redhat.com>
> +L: qemu-arm@nongnu.org
> +S: Maintained

Shouldn't you use 'Supported': "Someone is actually paid to look after
this."?

> +F: hw/arm/smmu*
> +F: include/hw/arm/smmu*
> +
>  CRIS
>  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
>  S: Maintained
>

Re: [Qemu-devel] [PATCH for-3.1] MAINTAINERS: Add an ARM SMMU section

Posted by Auger Eric 5 years, 4 months ago

Hi Philippe,

On 11/22/18 11:33 PM, Philippe Mathieu-Daudé wrote:
> Hi Eric,
> 
> On 22/11/18 19:01, Eric Auger wrote:
>> Add a new ARM SMMU section and set Eric Auger as the maintainer
>> for ARM SMMU emulation sources.
>>
>> Signed-off-by: Eric Auger <eric.auger@redhat.com>
>> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>>  MAINTAINERS | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 1032406c56..3cac9f0a0c 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -151,6 +151,13 @@ F: disas/arm.c
>>  F: disas/arm-a64.cc
>>  F: disas/libvixl/
>>  
>> +ARM SMMU
>> +M: Eric Auger <eric.auger@redhat.com>
>> +L: qemu-arm@nongnu.org
>> +S: Maintained
> 
> Shouldn't you use 'Supported': "Someone is actually paid to look after
> this."?
Not sure this is really important as long as get_maintainer.pl returns
the right contacts. Many ARM sections do not feature the "Supported"
tag. I will follow Peter's guidance though.

Thanks

Eric
> 
>> +F: hw/arm/smmu*
>> +F: include/hw/arm/smmu*
>> +
>>  CRIS
>>  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
>>  S: Maintained
>>

Re: [Qemu-devel] [PATCH for-3.1] MAINTAINERS: Add an ARM SMMU section

Posted by Peter Maydell 5 years, 4 months ago

On 23 November 2018 at 08:04, Auger Eric <eric.auger@redhat.com> wrote:
> On 11/22/18 11:33 PM, Philippe Mathieu-Daudé wrote:
>> On 22/11/18 19:01, Eric Auger wrote:
>>> +ARM SMMU
>>> +M: Eric Auger <eric.auger@redhat.com>
>>> +L: qemu-arm@nongnu.org
>>> +S: Maintained
>>
>> Shouldn't you use 'Supported': "Someone is actually paid to look after
>> this."?
> Not sure this is really important as long as get_maintainer.pl returns
> the right contacts. Many ARM sections do not feature the "Supported"
> tag. I will follow Peter's guidance though.

I don't really understand the purpose of the Supported vs
Maintained distinction. Mostly I list stuff as just
Maintained when I am dealing with it.

I think in particular that if a part of QEMU is just one
of a whole set of things that you are doing as part of
your job then Supported is a bit overstating things.

thanks
-- PMM

Re: [Qemu-devel] [PATCH for-3.1] MAINTAINERS: Add an ARM SMMU section

Posted by Peter Maydell 5 years, 4 months ago

On Thu, 22 Nov 2018 at 18:01, Eric Auger <eric.auger@redhat.com> wrote:
>
> Add a new ARM SMMU section and set Eric Auger as the maintainer
> for ARM SMMU emulation sources.
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  MAINTAINERS | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1032406c56..3cac9f0a0c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -151,6 +151,13 @@ F: disas/arm.c
>  F: disas/arm-a64.cc
>  F: disas/libvixl/
>
> +ARM SMMU
> +M: Eric Auger <eric.auger@redhat.com>
> +L: qemu-arm@nongnu.org
> +S: Maintained
> +F: hw/arm/smmu*
> +F: include/hw/arm/smmu*
> +
>  CRIS
>  M: Edgar E. Iglesias <edgar.iglesias@gmail.com>
>  S: Maintained

Applied to target-arm.next, thanks.

-- PMM