[Qemu-devel] [PULL 00/13] Block layer patches

Kevin Wolf posted 13 patches 5 years, 5 months ago
Test asan passed
Test checkpatch failed
Test docker-quick@centos7 passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181122165417.23894-1-kwolf@redhat.com
There is a newer version of this series
block.c                       |  4 +--
hw/block/nvme.c               | 12 +++-----
hw/scsi/scsi-disk.c           |  2 +-
qemu-img.c                    |  3 +-
tests/nvme-test.c             | 68 ++++++++++++++++++++++++++++++++++++-------
tests/Makefile.include        |  2 +-
tests/qemu-iotests/041        |  6 ++--
tests/qemu-iotests/118        | 20 +++++--------
tests/qemu-iotests/223        | 43 ++++++++++++++++++++++-----
tests/qemu-iotests/223.out    | 32 +++++++++++++++-----
tests/qemu-iotests/233        |  9 ++++--
tests/qemu-iotests/common.tls |  3 ++
tests/qemu-iotests/iotests.py |  2 +-
13 files changed, 148 insertions(+), 58 deletions(-)
[Qemu-devel] [PULL 00/13] Block layer patches
Posted by Kevin Wolf 5 years, 5 months ago
The following changes since commit 47c1cc30e440860aa695358f7c2dd0b9d7b53d16:

  Update version for v3.1.0-rc2 release (2018-11-20 18:10:26 +0000)

are available in the Git repository at:

  git://repo.or.cz/qemu/kevin.git tags/for-upstream

for you to fetch changes up to 924956b1efc50af7cc334b7a14f56aa213ca27ef:

  iotests: Enhance 223 to cover multiple bitmap granularities (2018-11-22 16:43:52 +0100)

----------------------------------------------------------------
Block layer patches:

- block: Fix update of BDRV_O_AUTO_RDONLY in update_flags_from_options()
- qemu-img: Fix memory leak and typo in error message
- nvme: Fixes for lockups and crashes
- scsi-disk: Fix crash if underlying host file or disk returns error
- Several qemu-iotests fixes and improvements

----------------------------------------------------------------
Alberto Garcia (1):
      block: Fix update of BDRV_O_AUTO_RDONLY in update_flags_from_options()

Daniel P. Berrangé (1):
      iotests: fix nbd test 233 to work correctly with raw images

Eric Blake (2):
      iotests: Skip 233 if certtool not installed
      iotests: Enhance 223 to cover multiple bitmap granularities

Igor Druzhinin (1):
      nvme: call blk_drain in NVMe reset code to avoid lockups

Kevin Wolf (3):
      iotests: Replace time.clock() with Timeout
      iotests: Replace assertEquals() with assertEqual()
      Revert "nvme: fix oob access issue(CVE-2018-16847)"

Logan Gunthorpe (1):
      nvme: fix bug with PCI IRQ pins on teardown

Max Reitz (2):
      qemu-img: Fix typo
      qemu-img: Fix leak

Paolo Bonzini (1):
      nvme: fix out-of-bounds access to the CMB

Richard W.M. Jones (1):
      scsi-disk: Fix crash if underlying host file or disk returns error

 block.c                       |  4 +--
 hw/block/nvme.c               | 12 +++-----
 hw/scsi/scsi-disk.c           |  2 +-
 qemu-img.c                    |  3 +-
 tests/nvme-test.c             | 68 ++++++++++++++++++++++++++++++++++++-------
 tests/Makefile.include        |  2 +-
 tests/qemu-iotests/041        |  6 ++--
 tests/qemu-iotests/118        | 20 +++++--------
 tests/qemu-iotests/223        | 43 ++++++++++++++++++++++-----
 tests/qemu-iotests/223.out    | 32 +++++++++++++++-----
 tests/qemu-iotests/233        |  9 ++++--
 tests/qemu-iotests/common.tls |  3 ++
 tests/qemu-iotests/iotests.py |  2 +-
 13 files changed, 148 insertions(+), 58 deletions(-)

Re: [Qemu-devel] [PULL 00/13] Block layer patches
Posted by Peter Maydell 5 years, 5 months ago
On 22 November 2018 at 16:54, Kevin Wolf <kwolf@redhat.com> wrote:
> The following changes since commit 47c1cc30e440860aa695358f7c2dd0b9d7b53d16:
>
>   Update version for v3.1.0-rc2 release (2018-11-20 18:10:26 +0000)
>
> are available in the Git repository at:
>
>   git://repo.or.cz/qemu/kevin.git tags/for-upstream
>
> for you to fetch changes up to 924956b1efc50af7cc334b7a14f56aa213ca27ef:
>
>   iotests: Enhance 223 to cover multiple bitmap granularities (2018-11-22 16:43:52 +0100)
>
> ----------------------------------------------------------------
> Block layer patches:
>
> - block: Fix update of BDRV_O_AUTO_RDONLY in update_flags_from_options()
> - qemu-img: Fix memory leak and typo in error message
> - nvme: Fixes for lockups and crashes
> - scsi-disk: Fix crash if underlying host file or disk returns error
> - Several qemu-iotests fixes and improvements
>
> ----------------------------------------------------------------

Hi; this seems to fail make check on s390x, sparc64, ppc64 (ie all
the bigendian hosts):

TEST: tests/nvme-test... (pid=12356)
  /i386/nvme/nop:                                                      OK
  /i386/nvme/cmb_test:                                                 **
ERROR:/home/linux1/qemu/tests/nvme-test.c:60:nvmetest_cmb_test:
assertion failed (qpci_io_re
adb(pdev, bar, 0) == 0x99): (0 == 153)
FAIL

thanks
-- PMM

Re: [Qemu-devel] [PULL 00/13] Block layer patches
Posted by no-reply@patchew.org 5 years, 5 months ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20181122165417.23894-1-kwolf@redhat.com
Type: series
Subject: [Qemu-devel] [PULL 00/13] Block layer patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
e0ba295 iotests: Enhance 223 to cover multiple bitmap granularities
8f69d38 nvme: fix bug with PCI IRQ pins on teardown
34506f4 Revert "nvme: fix oob access issue(CVE-2018-16847)"
f9e29f0 nvme: fix out-of-bounds access to the CMB
5b2b7aa nvme: call blk_drain in NVMe reset code to avoid lockups
40ede8d iotests: fix nbd test 233 to work correctly with raw images
81f0a87 block: Fix update of BDRV_O_AUTO_RDONLY in update_flags_from_options()
9d1d446 scsi-disk: Fix crash if underlying host file or disk returns error
114cf31 qemu-img: Fix leak
d1fac5e qemu-img: Fix typo
1e187df iotests: Skip 233 if certtool not installed
fdf543f iotests: Replace assertEquals() with assertEqual()
3b508f4 iotests: Replace time.clock() with Timeout

=== OUTPUT BEGIN ===
Checking PATCH 1/13: iotests: Replace time.clock() with Timeout...
Checking PATCH 2/13: iotests: Replace assertEquals() with assertEqual()...
Checking PATCH 3/13: iotests: Skip 233 if certtool not installed...
Checking PATCH 4/13: qemu-img: Fix typo...
Checking PATCH 5/13: qemu-img: Fix leak...
Checking PATCH 6/13: scsi-disk: Fix crash if underlying host file or disk returns error...
Checking PATCH 7/13: block: Fix update of BDRV_O_AUTO_RDONLY in update_flags_from_options()...
Checking PATCH 8/13: iotests: fix nbd test 233 to work correctly with raw images...
Checking PATCH 9/13: nvme: call blk_drain in NVMe reset code to avoid lockups...
Checking PATCH 10/13: nvme: fix out-of-bounds access to the CMB...
ERROR: space required after that ',' (ctx:VxV)
#107: FILE: tests/nvme-test.c:53:
+    pdev = qpci_device_find(qs->pcibus, QPCI_DEVFN(4,0));
                                                     ^

total: 1 errors, 0 warnings, 99 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 11/13: Revert "nvme: fix oob access issue(CVE-2018-16847)"...
Checking PATCH 12/13: nvme: fix bug with PCI IRQ pins on teardown...
Checking PATCH 13/13: iotests: Enhance 223 to cover multiple bitmap granularities...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com