Hi,

Here is a small series improving a bit Windows headers inclusion, and
setting the default required API version globally to Vista. It also
allows easier tweaking of available API version via CFLAGS.

Building QGA for older versions (XP) seems possible so far: the
dependency on libqemuutil.a implies building qemu-thread-win32.c,
which requires Vista API since commit 12f8def0 (v2.9). But qemu-thread
isn't being used in QGA, the resulting binary may still work on XP.
XP is no longer supported for the past 4.5y, it's time to drop support
for it.

Marc-André Lureau (4):
  build-sys: don't include windows.h, osdep.h does it
  build-sys: move windows defines in osdep.h header
  build-sys: build with Vista API by default
  RFC: qga: drop < Vista compatibility

 include/qemu/osdep.h      | 17 ++++++++++
 accel/tcg/translate-all.c |  4 ---
 qga/commands-win32.c      | 70 +--------------------------------------
 util/qemu-thread-win32.c  |  4 ---
 configure                 |  3 --
 roms/seabios              |  2 +-
 6 files changed, 19 insertions(+), 81 deletions(-)

-- 
2.20.0.rc1

On 22/11/18 12:00, Marc-André Lureau wrote:
> Hi,
> 
> Here is a small series improving a bit Windows headers inclusion, and
> setting the default required API version globally to Vista. It also
> allows easier tweaking of available API version via CFLAGS.
> 
> Building QGA for older versions (XP) seems possible so far: the
> dependency on libqemuutil.a implies building qemu-thread-win32.c,
> which requires Vista API since commit 12f8def0 (v2.9). But qemu-thread
> isn't being used in QGA, the resulting binary may still work on XP.
> XP is no longer supported for the past 4.5y, it's time to drop support
> for it.
> 
> Marc-André Lureau (4):
>   build-sys: don't include windows.h, osdep.h does it
>   build-sys: move windows defines in osdep.h header
>   build-sys: build with Vista API by default
>   RFC: qga: drop < Vista compatibility
> 
>  include/qemu/osdep.h      | 17 ++++++++++
>  accel/tcg/translate-all.c |  4 ---
>  qga/commands-win32.c      | 70 +--------------------------------------
>  util/qemu-thread-win32.c  |  4 ---
>  configure                 |  3 --
>  roms/seabios              |  2 +-
>  6 files changed, 19 insertions(+), 81 deletions(-)
> 

Queued, thanks.

Paolo

Am 29.11.2018 um 11:16 schrieb Paolo Bonzini:
> On 22/11/18 12:00, Marc-André Lureau wrote:
>>  include/qemu/osdep.h      | 17 ++++++++++
>>  accel/tcg/translate-all.c |  4 ---
>>  qga/commands-win32.c      | 70 +--------------------------------------
>>  util/qemu-thread-win32.c  |  4 ---
>>  configure                 |  3 --
>>  roms/seabios              |  2 +-
>>  6 files changed, 19 insertions(+), 81 deletions(-)
>>
> Queued, thanks.
>
> Paolo


Was the change for roms/seabios intentional?

Stefan

On Thu, Nov 29, 2018 at 2:45 PM Stefan Weil <sw@weilnetz.de> wrote:
>
> Am 29.11.2018 um 11:16 schrieb Paolo Bonzini:
> > On 22/11/18 12:00, Marc-André Lureau wrote:
> >>  include/qemu/osdep.h      | 17 ++++++++++
> >>  accel/tcg/translate-all.c |  4 ---
> >>  qga/commands-win32.c      | 70 +--------------------------------------
> >>  util/qemu-thread-win32.c  |  4 ---
> >>  configure                 |  3 --
> >>  roms/seabios              |  2 +-
> >>  6 files changed, 19 insertions(+), 81 deletions(-)
> >>
> > Queued, thanks.
> >
> > Paolo
>
>
> Was the change for roms/seabios intentional?

oh no! sorry Paolo

On 29/11/18 11:50, Marc-André Lureau wrote:
> On Thu, Nov 29, 2018 at 2:45 PM Stefan Weil <sw@weilnetz.de> wrote:
>>
>> Am 29.11.2018 um 11:16 schrieb Paolo Bonzini:
>>> On 22/11/18 12:00, Marc-André Lureau wrote:
>>>>  include/qemu/osdep.h      | 17 ++++++++++
>>>>  accel/tcg/translate-all.c |  4 ---
>>>>  qga/commands-win32.c      | 70 +--------------------------------------
>>>>  util/qemu-thread-win32.c  |  4 ---
>>>>  configure                 |  3 --
>>>>  roms/seabios              |  2 +-
>>>>  6 files changed, 19 insertions(+), 81 deletions(-)
>>>>
>>> Queued, thanks.
>>>
>>> Paolo
>>
>>
>> Was the change for roms/seabios intentional?
> 
> oh no! sorry Paolo

Removed, no problem.

Paolo