roms: seabios: Rename CROSS_COMPILE to CROSS_PREFIX

[Qemu-devel] [PATCH] roms: seabios: Rename CROSS_COMPILE to CROSS_PREFIX

Roman Bolshakov posted 1 patch 6 years, 11 months ago

Download mbox

Test asan passed

Test checkpatch passed

Test docker-quick@centos7 passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181121203720.75916-1-r.bolshakov@yadro.com

roms/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH] roms: seabios: Rename CROSS_COMPILE to CROSS_PREFIX

Posted by Roman Bolshakov 6 years, 11 months ago

SeaBIOS introduced CROSS_PREFIX in 2013 but it's not set in roms
Makefile.

With the change it's possible to cross-compile SeaBIOS on macOS,
if acpica/iasl is installed:
  cd roms
  export PATH=/path/to/cross/x86_64-unknown-linux-gnu/bin:$PATH
  make bios system=unknown-linux-gnu

Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
---
 roms/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/roms/Makefile b/roms/Makefile
index f4141e1d96..a6043eff37 100644
--- a/roms/Makefile
+++ b/roms/Makefile
@@ -83,12 +83,12 @@ build-seabios-config-%: config.%
 	cp $< seabios/builds/$*/.config
 	$(MAKE) -C seabios \
 		EXTRAVERSION=$(SEABIOS_EXTRAVERSION) \
-		CROSS_COMPILE=$(x86_64_cross_prefix) \
+		CROSS_PREFIX=$(x86_64_cross_prefix) \
 		KCONFIG_CONFIG=$(CURDIR)/seabios/builds/$*/.config \
 		OUT=$(CURDIR)/seabios/builds/$*/ oldnoconfig
 	$(MAKE) -C seabios \
 		EXTRAVERSION=$(SEABIOS_EXTRAVERSION) \
-		CROSS_COMPILE=$(x86_64_cross_prefix) \
+		CROSS_PREFIX=$(x86_64_cross_prefix) \
 		KCONFIG_CONFIG=$(CURDIR)/seabios/builds/$*/.config \
 		OUT=$(CURDIR)/seabios/builds/$*/ all
 
-- 
2.19.1

Re: [Qemu-devel] [PATCH] roms: seabios: Rename CROSS_COMPILE to CROSS_PREFIX

Posted by Gerd Hoffmann 6 years, 11 months ago

On Wed, Nov 21, 2018 at 11:37:21PM +0300, Roman Bolshakov wrote:
> SeaBIOS introduced CROSS_PREFIX in 2013 but it's not set in roms
> Makefile.

> -		CROSS_COMPILE=$(x86_64_cross_prefix) \
> +		CROSS_PREFIX=$(x86_64_cross_prefix) \

I'm wondering how that slipped though, IIRC I had actually tested
seabios crossbuilds ...

Queued up (for 4.0).

thanks,
  Gerd