[v3] minor qcow2 compression improvements

[Qemu-devel] [PATCH for 3.1 v3 0/3] minor qcow2 compression improvements

Eric Blake posted 3 patches 6 years, 10 months ago

Diff against v5 v6 v7
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181113230319.1008531-1-eblake@redhat.com

Test docker-clang@ubuntu passed

Test checkpatch passed

Test asan passed

Test docker-mingw@fedora passed

Test docker-quick@centos7 passed

docs/interop/qcow2.txt     | 30 +++++++++++-
block/qcow2.h              |  6 +++
block/qcow2-refcount.c     | 20 +++++---
tests/qemu-iotests/220     | 96 ++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/220.out | 54 +++++++++++++++++++++
tests/qemu-iotests/group   |  1 +
6 files changed, 198 insertions(+), 9 deletions(-)
create mode 100755 tests/qemu-iotests/220
create mode 100644 tests/qemu-iotests/220.out

Expand all Fold all

[Qemu-devel] [PATCH for 3.1 v3 0/3] minor qcow2 compression improvements

Posted by Eric Blake 6 years, 10 months ago

As the added iotests shows, we have a (corner case) data corruption
that is user triggerable, therefore, this is still appropriate for
inclusion in 3.1.

v6 was here:
https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg08497.html

since then:
- don't reduce constraints on reftable [Kevin]
- rebase to recent iotests changes
- drop patches that might conflict with Vladimir's work now on Kevin's
block-next branch

001/3:[0042] [FC] 'qcow2: Document some maximum size constraints'
002/3:[0003] [FC] 'qcow2: Don't allow overflow during cluster allocation'
003/3:[0003] [FC] 'iotests: Add new test 220 for max compressed cluster offset'

Eric Blake (3):
  qcow2: Document some maximum size constraints
  qcow2: Don't allow overflow during cluster allocation
  iotests: Add new test 220 for max compressed cluster offset

 docs/interop/qcow2.txt     | 30 +++++++++++-
 block/qcow2.h              |  6 +++
 block/qcow2-refcount.c     | 20 +++++---
 tests/qemu-iotests/220     | 96 ++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/220.out | 54 +++++++++++++++++++++
 tests/qemu-iotests/group   |  1 +
 6 files changed, 198 insertions(+), 9 deletions(-)
 create mode 100755 tests/qemu-iotests/220
 create mode 100644 tests/qemu-iotests/220.out

-- 
2.17.2

Re: [Qemu-devel] [PATCH for 3.1 v3 0/3] minor qcow2 compression improvements

Posted by Kevin Wolf 6 years, 10 months ago

Am 14.11.2018 um 00:03 hat Eric Blake geschrieben:
> As the added iotests shows, we have a (corner case) data corruption
> that is user triggerable, therefore, this is still appropriate for
> inclusion in 3.1.

Thanks, applied to the block branch.

Kevin

Re: [Qemu-devel] [PATCH for 3.1 v3 0/3] minor qcow2 compression improvements

Posted by Eric Blake 6 years, 10 months ago

On 11/14/18 8:35 AM, Kevin Wolf wrote:
> Am 14.11.2018 um 00:03 hat Eric Blake geschrieben:
>> As the added iotests shows, we have a (corner case) data corruption
>> that is user triggerable, therefore, this is still appropriate for
>> inclusion in 3.1.
> 
> Thanks, applied to the block branch.

Patch 2 and 3 are fine; but Berto raised questions about patch 1 so I 
posted a v9 of that patch, in case you want to replace it in your queue 
and/or defer it out of 3.1 and instead save it for 4.0.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH for 3.1 v3 0/3] minor qcow2 compression improvements

Posted by Eric Blake 6 years, 10 months ago

On 11/13/18 5:03 PM, Eric Blake wrote:
> As the added iotests shows, we have a (corner case) data corruption
> that is user triggerable, therefore, this is still appropriate for
> inclusion in 3.1.
> 
> v6 was here:
> https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg08497.html

Wow, I can't count. That was v7, and this email should be titled v8, not 
v3 ;)

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org