1. Patchew
  2. QEMU
  3. [Qemu-devel] [PATCH qemu RFC 0/7] spapr_pci, vfio: NVIDIA V100 + P9 passthrough
  4. View patch

[Qemu-devel] [PATCH qemu RFC 3/7] pci: Move NVIDIA vendor id to the rest of ids

Alexey Kardashevskiy posted 7 patches 7 years, 2 months ago
[Qemu-devel] [PATCH qemu RFC 3/7] pci: Move NVIDIA vendor id to the rest of ids
Posted by Alexey Kardashevskiy 7 years, 2 months ago 
sPAPR code will use it too so move it from VFIO to the common code.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
 include/hw/pci/pci_ids.h | 2 ++
 hw/vfio/pci-quirks.c     | 2 --
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/hw/pci/pci_ids.h b/include/hw/pci/pci_ids.h
index 63acc72..3ed7d10 100644
--- a/include/hw/pci/pci_ids.h
+++ b/include/hw/pci/pci_ids.h
@@ -271,4 +271,6 @@
 
 #define PCI_VENDOR_ID_SYNOPSYS           0x16C3
 
+#define PCI_VENDOR_ID_NVIDIA             0x10de
+
 #endif
diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c
index eae31c7..40a1200 100644
--- a/hw/vfio/pci-quirks.c
+++ b/hw/vfio/pci-quirks.c
@@ -526,8 +526,6 @@ static void vfio_probe_ati_bar2_quirk(VFIOPCIDevice *vdev, int nr)
  * note it for future reference.
  */
 
-#define PCI_VENDOR_ID_NVIDIA                    0x10de
-
 /*
  * Nvidia has several different methods to get to config space, the
  * nouveu project has several of these documented here:
-- 
2.17.1
Re: [Qemu-devel] [PATCH qemu RFC 3/7] pci: Move NVIDIA vendor id to the rest of ids
Posted by David Gibson 7 years, 2 months ago 
On Tue, Nov 13, 2018 at 07:31:00PM +1100, Alexey Kardashevskiy wrote:
> sPAPR code will use it too so move it from VFIO to the common code.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

This looks correct to me independent of the rest of the series.

> ---
>  include/hw/pci/pci_ids.h | 2 ++
>  hw/vfio/pci-quirks.c     | 2 --
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/hw/pci/pci_ids.h b/include/hw/pci/pci_ids.h
> index 63acc72..3ed7d10 100644
> --- a/include/hw/pci/pci_ids.h
> +++ b/include/hw/pci/pci_ids.h
> @@ -271,4 +271,6 @@
>  
>  #define PCI_VENDOR_ID_SYNOPSYS           0x16C3
>  
> +#define PCI_VENDOR_ID_NVIDIA             0x10de
> +
>  #endif
> diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c
> index eae31c7..40a1200 100644
> --- a/hw/vfio/pci-quirks.c
> +++ b/hw/vfio/pci-quirks.c
> @@ -526,8 +526,6 @@ static void vfio_probe_ati_bar2_quirk(VFIOPCIDevice *vdev, int nr)
>   * note it for future reference.
>   */
>  
> -#define PCI_VENDOR_ID_NVIDIA                    0x10de
> -
>  /*
>   * Nvidia has several different methods to get to config space, the
>   * nouveu project has several of these documented here:

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
Re: [Qemu-devel] [PATCH qemu RFC 3/7] pci: Move NVIDIA vendor id to the rest of ids
Posted by Alistair Francis 7 years, 2 months ago 
On Tue, Nov 13, 2018 at 12:42 AM Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
>
> sPAPR code will use it too so move it from VFIO to the common code.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  include/hw/pci/pci_ids.h | 2 ++
>  hw/vfio/pci-quirks.c     | 2 --
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/hw/pci/pci_ids.h b/include/hw/pci/pci_ids.h
> index 63acc72..3ed7d10 100644
> --- a/include/hw/pci/pci_ids.h
> +++ b/include/hw/pci/pci_ids.h
> @@ -271,4 +271,6 @@
>
>  #define PCI_VENDOR_ID_SYNOPSYS           0x16C3
>
> +#define PCI_VENDOR_ID_NVIDIA             0x10de
> +
>  #endif
> diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c
> index eae31c7..40a1200 100644
> --- a/hw/vfio/pci-quirks.c
> +++ b/hw/vfio/pci-quirks.c
> @@ -526,8 +526,6 @@ static void vfio_probe_ati_bar2_quirk(VFIOPCIDevice *vdev, int nr)
>   * note it for future reference.
>   */
>
> -#define PCI_VENDOR_ID_NVIDIA                    0x10de
> -
>  /*
>   * Nvidia has several different methods to get to config space, the
>   * nouveu project has several of these documented here:
> --
> 2.17.1
>
>
Re: [Qemu-devel] [PATCH qemu RFC 3/7] pci: Move NVIDIA vendor id to the rest of ids
Posted by Alexey Kardashevskiy 7 years, 1 month ago 

On 21/11/2018 05:27, Alistair Francis wrote:
> On Tue, Nov 13, 2018 at 12:42 AM Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
>>
>> sPAPR code will use it too so move it from VFIO to the common code.
>>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> 
> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>



Aaaaaand who is taking this? I am going to repost the patchset, posting
this one over and over again seems redundant. Thanks,



> 
> Alistair
> 
>> ---
>>  include/hw/pci/pci_ids.h | 2 ++
>>  hw/vfio/pci-quirks.c     | 2 --
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/hw/pci/pci_ids.h b/include/hw/pci/pci_ids.h
>> index 63acc72..3ed7d10 100644
>> --- a/include/hw/pci/pci_ids.h
>> +++ b/include/hw/pci/pci_ids.h
>> @@ -271,4 +271,6 @@
>>
>>  #define PCI_VENDOR_ID_SYNOPSYS           0x16C3
>>
>> +#define PCI_VENDOR_ID_NVIDIA             0x10de
>> +
>>  #endif
>> diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c
>> index eae31c7..40a1200 100644
>> --- a/hw/vfio/pci-quirks.c
>> +++ b/hw/vfio/pci-quirks.c
>> @@ -526,8 +526,6 @@ static void vfio_probe_ati_bar2_quirk(VFIOPCIDevice *vdev, int nr)
>>   * note it for future reference.
>>   */
>>
>> -#define PCI_VENDOR_ID_NVIDIA                    0x10de
>> -
>>  /*
>>   * Nvidia has several different methods to get to config space, the
>>   * nouveu project has several of these documented here:
>> --
>> 2.17.1
>>
>>

-- 
Alexey
Re: [Qemu-devel] [PATCH qemu RFC 3/7] pci: Move NVIDIA vendor id to the rest of ids
Posted by Alexey Kardashevskiy 7 years ago 
Ping, anyone?

On 14/12/2018 14:36, Alexey Kardashevskiy wrote:
> 
> 
> On 21/11/2018 05:27, Alistair Francis wrote:
>> On Tue, Nov 13, 2018 at 12:42 AM Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
>>>
>>> sPAPR code will use it too so move it from VFIO to the common code.
>>>
>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>>
>> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
> 
> 
> 
> Aaaaaand who is taking this? I am going to repost the patchset, posting
> this one over and over again seems redundant. Thanks,
> 
> 
> 
>>
>> Alistair
>>
>>> ---
>>>  include/hw/pci/pci_ids.h | 2 ++
>>>  hw/vfio/pci-quirks.c     | 2 --
>>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/include/hw/pci/pci_ids.h b/include/hw/pci/pci_ids.h
>>> index 63acc72..3ed7d10 100644
>>> --- a/include/hw/pci/pci_ids.h
>>> +++ b/include/hw/pci/pci_ids.h
>>> @@ -271,4 +271,6 @@
>>>
>>>  #define PCI_VENDOR_ID_SYNOPSYS           0x16C3
>>>
>>> +#define PCI_VENDOR_ID_NVIDIA             0x10de
>>> +
>>>  #endif
>>> diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c
>>> index eae31c7..40a1200 100644
>>> --- a/hw/vfio/pci-quirks.c
>>> +++ b/hw/vfio/pci-quirks.c
>>> @@ -526,8 +526,6 @@ static void vfio_probe_ati_bar2_quirk(VFIOPCIDevice *vdev, int nr)
>>>   * note it for future reference.
>>>   */
>>>
>>> -#define PCI_VENDOR_ID_NVIDIA                    0x10de
>>> -
>>>  /*
>>>   * Nvidia has several different methods to get to config space, the
>>>   * nouveu project has several of these documented here:
>>> --
>>> 2.17.1
>>>
>>>
> 

-- 
Alexey
Re: [Qemu-devel] [PATCH qemu RFC 3/7] pci: Move NVIDIA vendor id to the rest of ids
Posted by Alexey Kardashevskiy 6 years, 12 months ago 
Ping? 3 months today :)


On 16/01/2019 15:20, Alexey Kardashevskiy wrote:
> Ping, anyone?
> 
> On 14/12/2018 14:36, Alexey Kardashevskiy wrote:
>>
>>
>> On 21/11/2018 05:27, Alistair Francis wrote:
>>> On Tue, Nov 13, 2018 at 12:42 AM Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
>>>>
>>>> sPAPR code will use it too so move it from VFIO to the common code.
>>>>
>>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>>>
>>> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
>>
>>
>>
>> Aaaaaand who is taking this? I am going to repost the patchset, posting
>> this one over and over again seems redundant. Thanks,
>>
>>
>>
>>>
>>> Alistair
>>>
>>>> ---
>>>>  include/hw/pci/pci_ids.h | 2 ++
>>>>  hw/vfio/pci-quirks.c     | 2 --
>>>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/include/hw/pci/pci_ids.h b/include/hw/pci/pci_ids.h
>>>> index 63acc72..3ed7d10 100644
>>>> --- a/include/hw/pci/pci_ids.h
>>>> +++ b/include/hw/pci/pci_ids.h
>>>> @@ -271,4 +271,6 @@
>>>>
>>>>  #define PCI_VENDOR_ID_SYNOPSYS           0x16C3
>>>>
>>>> +#define PCI_VENDOR_ID_NVIDIA             0x10de
>>>> +
>>>>  #endif
>>>> diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c
>>>> index eae31c7..40a1200 100644
>>>> --- a/hw/vfio/pci-quirks.c
>>>> +++ b/hw/vfio/pci-quirks.c
>>>> @@ -526,8 +526,6 @@ static void vfio_probe_ati_bar2_quirk(VFIOPCIDevice *vdev, int nr)
>>>>   * note it for future reference.
>>>>   */
>>>>
>>>> -#define PCI_VENDOR_ID_NVIDIA                    0x10de
>>>> -
>>>>  /*
>>>>   * Nvidia has several different methods to get to config space, the
>>>>   * nouveu project has several of these documented here:
>>>> --
>>>> 2.17.1
>>>>
>>>>
>>
> 

-- 
Alexey
Re: [Qemu-devel] [PATCH qemu RFC 3/7] pci: Move NVIDIA vendor id to the rest of ids
Posted by Alex Williamson 6 years, 12 months ago 
On Thu, 14 Feb 2019 13:26:49 +1100
Alexey Kardashevskiy <aik@ozlabs.ru> wrote:

> Ping? 3 months today :)

How about a non-RFC?

> On 16/01/2019 15:20, Alexey Kardashevskiy wrote:
> > Ping, anyone?
> > 
> > On 14/12/2018 14:36, Alexey Kardashevskiy wrote:  
> >>
> >>
> >> On 21/11/2018 05:27, Alistair Francis wrote:  
> >>> On Tue, Nov 13, 2018 at 12:42 AM Alexey Kardashevskiy <aik@ozlabs.ru> wrote:  
> >>>>
> >>>> sPAPR code will use it too so move it from VFIO to the common code.
> >>>>
> >>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>  
> >>>
> >>> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>  
> >>
> >>
> >>
> >> Aaaaaand who is taking this? I am going to repost the patchset, posting
> >> this one over and over again seems redundant. Thanks,
> >>
> >>
> >>  
> >>>
> >>> Alistair
> >>>  
> >>>> ---
> >>>>  include/hw/pci/pci_ids.h | 2 ++
> >>>>  hw/vfio/pci-quirks.c     | 2 --
> >>>>  2 files changed, 2 insertions(+), 2 deletions(-)
> >>>>
> >>>> diff --git a/include/hw/pci/pci_ids.h b/include/hw/pci/pci_ids.h
> >>>> index 63acc72..3ed7d10 100644
> >>>> --- a/include/hw/pci/pci_ids.h
> >>>> +++ b/include/hw/pci/pci_ids.h
> >>>> @@ -271,4 +271,6 @@
> >>>>
> >>>>  #define PCI_VENDOR_ID_SYNOPSYS           0x16C3
> >>>>
> >>>> +#define PCI_VENDOR_ID_NVIDIA             0x10de
> >>>> +
> >>>>  #endif
> >>>> diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c
> >>>> index eae31c7..40a1200 100644
> >>>> --- a/hw/vfio/pci-quirks.c
> >>>> +++ b/hw/vfio/pci-quirks.c
> >>>> @@ -526,8 +526,6 @@ static void vfio_probe_ati_bar2_quirk(VFIOPCIDevice *vdev, int nr)
> >>>>   * note it for future reference.
> >>>>   */
> >>>>
> >>>> -#define PCI_VENDOR_ID_NVIDIA                    0x10de
> >>>> -
> >>>>  /*
> >>>>   * Nvidia has several different methods to get to config space, the
> >>>>   * nouveu project has several of these documented here:
> >>>> --
> >>>> 2.17.1
> >>>>
> >>>>  
> >>  
> >   
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.