[v2] Add support for RDMA MAD

[Qemu-devel] [PATCH v2 06/22] hw/pvrdma: Make function reset_device return void

Posted by Yuval Shaia 7 years, 3 months ago

This function cannot fail - fix it to return void

Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
---
 hw/rdma/vmw/pvrdma_main.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c
index 6c8c0154fa..fc2abd34af 100644
--- a/hw/rdma/vmw/pvrdma_main.c
+++ b/hw/rdma/vmw/pvrdma_main.c
@@ -369,13 +369,11 @@ static int unquiesce_device(PVRDMADev *dev)
     return 0;
 }
 
-static int reset_device(PVRDMADev *dev)
+static void reset_device(PVRDMADev *dev)
 {
     pvrdma_stop(dev);
 
     pr_dbg("Device reset complete\n");
-
-    return 0;
 }
 
 static uint64_t regs_read(void *opaque, hwaddr addr, unsigned size)
-- 
2.17.2

Re: [Qemu-devel] [PATCH v2 06/22] hw/pvrdma: Make function reset_device return void

Posted by Marcel Apfelbaum 7 years, 3 months ago


On 11/8/18 6:08 PM, Yuval Shaia wrote:
> This function cannot fail - fix it to return void
>
> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
> ---
>   hw/rdma/vmw/pvrdma_main.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c
> index 6c8c0154fa..fc2abd34af 100644
> --- a/hw/rdma/vmw/pvrdma_main.c
> +++ b/hw/rdma/vmw/pvrdma_main.c
> @@ -369,13 +369,11 @@ static int unquiesce_device(PVRDMADev *dev)
>       return 0;
>   }
>   
> -static int reset_device(PVRDMADev *dev)
> +static void reset_device(PVRDMADev *dev)
>   {
>       pvrdma_stop(dev);
>   
>       pr_dbg("Device reset complete\n");
> -
> -    return 0;
>
>   
>   static uint64_t regs_read(void *opaque, hwaddr addr, unsigned size)

Reviewed-by: Marcel Apfelbaum<marcel.apfelbaum@gmail.com>

Thanks,
Marcel