[Qemu-devel] [PATCH] pci_bridge: fix a typo in comment

Mao Zhongyi posted 1 patch 5 years, 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181108122102.9915-1-maozhongyi@cmss.chinamobile.com
Test docker-clang@ubuntu passed
Test checkpatch passed
Test asan passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
hw/pci/pci_bridge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[Qemu-devel] [PATCH] pci_bridge: fix a typo in comment
Posted by Mao Zhongyi 5 years, 5 months ago
Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
---
 hw/pci/pci_bridge.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c
index ee9dff2d3a..da8daa3ff2 100644
--- a/hw/pci/pci_bridge.c
+++ b/hw/pci/pci_bridge.c
@@ -310,7 +310,7 @@ void pci_bridge_reset(DeviceState *qdev)
 
     /*
      * the default values for base/limit registers aren't specified
-     * in the PCI-to-PCI-bridge spec. So we don't thouch them here.
+     * in the PCI-to-PCI-bridge spec. So we don't touch them here.
      * Each implementation can override it.
      * typical implementation does
      * zero base/limit registers or
-- 
2.17.1




Re: [Qemu-devel] [PATCH] pci_bridge: fix a typo in comment
Posted by Philippe Mathieu-Daudé 5 years, 5 months ago
Cc'ing qemu-trivial@

On 8/11/18 13:21, Mao Zhongyi wrote:
> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>   hw/pci/pci_bridge.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c
> index ee9dff2d3a..da8daa3ff2 100644
> --- a/hw/pci/pci_bridge.c
> +++ b/hw/pci/pci_bridge.c
> @@ -310,7 +310,7 @@ void pci_bridge_reset(DeviceState *qdev)
>   
>       /*
>        * the default values for base/limit registers aren't specified
> -     * in the PCI-to-PCI-bridge spec. So we don't thouch them here.
> +     * in the PCI-to-PCI-bridge spec. So we don't touch them here.
>        * Each implementation can override it.
>        * typical implementation does
>        * zero base/limit registers or
> 

Re: [Qemu-devel] [PATCH] pci_bridge: fix a typo in comment
Posted by maozy 4 years, 6 months ago
ping...

On 11/8/18 9:12 PM, Philippe Mathieu-Daudé wrote:
> Cc'ing qemu-trivial@
> 
> On 8/11/18 13:21, Mao Zhongyi wrote:
>> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> 
>> ---
>>   hw/pci/pci_bridge.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c
>> index ee9dff2d3a..da8daa3ff2 100644
>> --- a/hw/pci/pci_bridge.c
>> +++ b/hw/pci/pci_bridge.c
>> @@ -310,7 +310,7 @@ void pci_bridge_reset(DeviceState *qdev)
>>       /*
>>        * the default values for base/limit registers aren't specified
>> -     * in the PCI-to-PCI-bridge spec. So we don't thouch them here.
>> +     * in the PCI-to-PCI-bridge spec. So we don't touch them here.
>>        * Each implementation can override it.
>>        * typical implementation does
>>        * zero base/limit registers or
>>
> 



Re: [Qemu-devel] [PATCH] pci_bridge: fix a typo in comment
Posted by Philippe Mathieu-Daudé 4 years, 6 months ago
On 10/23/19 5:32 AM, maozy wrote:
> ping...

I'm not sure qemu-trivial@ received this one because the email address 
looked odd (now fixed).

> 
> On 11/8/18 9:12 PM, Philippe Mathieu-Daudé wrote:
>> Cc'ing qemu-trivial@
>>
>> On 8/11/18 13:21, Mao Zhongyi wrote:
>>> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
>>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>
>>> ---
>>>   hw/pci/pci_bridge.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c
>>> index ee9dff2d3a..da8daa3ff2 100644
>>> --- a/hw/pci/pci_bridge.c
>>> +++ b/hw/pci/pci_bridge.c
>>> @@ -310,7 +310,7 @@ void pci_bridge_reset(DeviceState *qdev)
>>>       /*
>>>        * the default values for base/limit registers aren't specified
>>> -     * in the PCI-to-PCI-bridge spec. So we don't thouch them here.
>>> +     * in the PCI-to-PCI-bridge spec. So we don't touch them here.
>>>        * Each implementation can override it.
>>>        * typical implementation does
>>>        * zero base/limit registers or
>>>
>>
> 
> 

Re: [Qemu-devel] [PATCH] pci_bridge: fix a typo in comment
Posted by Laurent Vivier 4 years, 6 months ago
Le 23/10/2019 à 12:47, Philippe Mathieu-Daudé a écrit :
> On 10/23/19 5:32 AM, maozy wrote:
>> ping...
> 
> I'm not sure qemu-trivial@ received this one because the email address
> looked odd (now fixed).
> 
>>
>> On 11/8/18 9:12 PM, Philippe Mathieu-Daudé wrote:
>>> Cc'ing qemu-trivial@
>>>
>>> On 8/11/18 13:21, Mao Zhongyi wrote:
>>>> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
>>>
>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>>
>>>> ---
>>>>   hw/pci/pci_bridge.c | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c
>>>> index ee9dff2d3a..da8daa3ff2 100644
>>>> --- a/hw/pci/pci_bridge.c
>>>> +++ b/hw/pci/pci_bridge.c
>>>> @@ -310,7 +310,7 @@ void pci_bridge_reset(DeviceState *qdev)
>>>>       /*
>>>>        * the default values for base/limit registers aren't specified
>>>> -     * in the PCI-to-PCI-bridge spec. So we don't thouch them here.
>>>> +     * in the PCI-to-PCI-bridge spec. So we don't touch them here.
>>>>        * Each implementation can override it.
>>>>        * typical implementation does
>>>>        * zero base/limit registers or
>>>>
>>>
>>
>>
> 

Applied to my trivial-patches branch.

Thanks,
Laurent