On Tue, Nov 06, 2018 at 11:17:03AM +0800, Dongli Zhang wrote:
>
>
> On 11/06/2018 02:15 AM, Michael S. Tsirkin wrote:
> > From: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
> >
> > Here should be submit_requests, there is no submit_merged_requests
> > function.
> >
> > Signed-off-by: Yaowei Bai <baiyaowei@cmss.chinamobile.com>
> > Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > hw/block/virtio-blk.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
> > index 225fe44b7a..83cf5c01f9 100644
> > --- a/hw/block/virtio-blk.c
> > +++ b/hw/block/virtio-blk.c
> > @@ -97,8 +97,8 @@ static void virtio_blk_rw_complete(void *opaque, int ret)
> >
> > if (req->qiov.nalloc != -1) {
> > /* If nalloc is != 1 req->qiov is a local copy of the original
>
> Should it be "If nalloc is != -1" in the comment? Seems the initial state is -1.
Makes sense. Patch?
> > - * external iovec. It was allocated in submit_merged_requests
> > - * to be able to merge requests. */
> > + * external iovec. It was allocated in submit_requests to be
> > + * able to merge requests. */
> > qemu_iovec_destroy(&req->qiov);
> > }
> >
> >
>
> Dongli Zhang