[Qemu-devel] [PATCH for 3.2 v2 2/7] hw/misc/bcm2835_property: Handle the 'domain state' property

Philippe Mathieu-Daudé posted 7 patches 7 years, 3 months ago
[Qemu-devel] [PATCH for 3.2 v2 2/7] hw/misc/bcm2835_property: Handle the 'domain state' property
Posted by Philippe Mathieu-Daudé 7 years, 3 months ago
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/misc/bcm2835_property.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/hw/misc/bcm2835_property.c b/hw/misc/bcm2835_property.c
index 145427ae0f..5d332324bd 100644
--- a/hw/misc/bcm2835_property.c
+++ b/hw/misc/bcm2835_property.c
@@ -121,6 +121,12 @@ static void bcm2835_property_mbox_push(BCM2835PropertyState *s, uint32_t value)
             resplen = 8;
             break;
 
+        case 0x00030030: /* domain state */
+            qemu_log_mask(LOG_UNIMP,
+                          "bcm2835_property: %x get domain state NYI\n", tag);
+            resplen = 8;
+            break;
+
         case 0x00038002: /* Set clock rate */
         case 0x00038004: /* Set max clock rate */
         case 0x00038007: /* Set min clock rate */
-- 
2.17.2


Re: [Qemu-devel] [PATCH for 3.2 v2 2/7] hw/misc/bcm2835_property: Handle the 'domain state' property
Posted by Peter Maydell 7 years, 3 months ago
On 2 November 2018 at 00:12, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/misc/bcm2835_property.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/hw/misc/bcm2835_property.c b/hw/misc/bcm2835_property.c
> index 145427ae0f..5d332324bd 100644
> --- a/hw/misc/bcm2835_property.c
> +++ b/hw/misc/bcm2835_property.c
> @@ -121,6 +121,12 @@ static void bcm2835_property_mbox_push(BCM2835PropertyState *s, uint32_t value)
>              resplen = 8;
>              break;
>
> +        case 0x00030030: /* domain state */
> +            qemu_log_mask(LOG_UNIMP,
> +                          "bcm2835_property: %x get domain state NYI\n", tag);
> +            resplen = 8;
> +            break;
> +

Our handling of "Set power state" has a slightly more sophisticated
"always say yes" implementation, but we have other properties which
we handle unimplemented like this, so if the kernel is happy with
this we don't need to do anything more sophisticated.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM