[Qemu-devel] [PATCH for 3.1 v2 1/7] MAINTAINERS: Add an entry for the Raspberry Pi machines

Philippe Mathieu-Daudé posted 7 patches 7 years, 3 months ago
[Qemu-devel] [PATCH for 3.1 v2 1/7] MAINTAINERS: Add an entry for the Raspberry Pi machines
Posted by Philippe Mathieu-Daudé 7 years, 3 months ago
So far the Raspi machines use the BCM2836 SoC which includes
a BCM2835 for the peripherals.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index f2360efe3e..c41ea5ed3f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -683,6 +683,12 @@ F: hw/arm/nrf51_soc.c
 F: hw/arm/microbit.c
 F: include/hw/arm/nrf51_soc.h
 
+Raspberry Pi
+L: qemu-arm@nongnu.org
+S: Odd Fixes
+F: hw/*/bcm283*
+F: include/hw/*/bcm283*
+
 CRIS Machines
 -------------
 Axis Dev88
-- 
2.17.2


Re: [Qemu-devel] [PATCH for 3.1 v2 1/7] MAINTAINERS: Add an entry for the Raspberry Pi machines
Posted by Peter Maydell 7 years, 3 months ago
On 2 November 2018 at 00:12, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> So far the Raspi machines use the BCM2836 SoC which includes
> a BCM2835 for the peripherals.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f2360efe3e..c41ea5ed3f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -683,6 +683,12 @@ F: hw/arm/nrf51_soc.c
>  F: hw/arm/microbit.c
>  F: include/hw/arm/nrf51_soc.h
>
> +Raspberry Pi
> +L: qemu-arm@nongnu.org
> +S: Odd Fixes
> +F: hw/*/bcm283*
> +F: include/hw/*/bcm283*
> +

We should also have F:hw/arm/raspi.c

Andrew, as the original submitter of the Raspberry Pi code
would you like to be listed as a maintainer for it?

thanks
-- PMM

Re: [Qemu-devel] [PATCH for 3.1 v2 1/7] MAINTAINERS: Add an entry for the Raspberry Pi machines
Posted by Andrew Baumann via Qemu-devel 7 years, 3 months ago
> From: Peter Maydell <peter.maydell@linaro.org>
> Sent: Monday, 5 November 2018 07:26
> 
> On 2 November 2018 at 00:12, Philippe Mathieu-Daudé <f4bug@amsat.org>
> wrote:
> > So far the Raspi machines use the BCM2836 SoC which includes a BCM2835
> > for the peripherals.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > ---
> >  MAINTAINERS | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS index f2360efe3e..c41ea5ed3f
> > 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -683,6 +683,12 @@ F: hw/arm/nrf51_soc.c
> >  F: hw/arm/microbit.c
> >  F: include/hw/arm/nrf51_soc.h
> >
> > +Raspberry Pi
> > +L: qemu-arm@nongnu.org
> > +S: Odd Fixes
> > +F: hw/*/bcm283*
> > +F: include/hw/*/bcm283*
> > +
> 
> We should also have F:hw/arm/raspi.c
> 
> Andrew, as the original submitter of the Raspberry Pi code would you like to
> be listed as a maintainer for it?

Thanks for asking; probably not -- I'm happy to review the odd patch if my input would be helpful, but I haven't worked on it for years, and I don't have spare cycles, so I'd just be a bottleneck.

Andrew
Re: [Qemu-devel] [PATCH for 3.1 v2 1/7] MAINTAINERS: Add an entry for the Raspberry Pi machines
Posted by Peter Maydell 7 years, 3 months ago
On 5 November 2018 at 17:06, Andrew Baumann
<Andrew.Baumann@microsoft.com> wrote:
> From: Peter Maydell <peter.maydell@linaro.org>
>> Andrew, as the original submitter of the Raspberry Pi code would you like to
>> be listed as a maintainer for it?
>
> Thanks for asking; probably not -- I'm happy to review the odd patch
> if my input would be helpful, but I haven't worked on it for years,
> and I don't have spare cycles, so I'd just be a bottleneck.

Sure, no problem. Would you like to be listed as a "reviewer"
(means people will CC you on patches, basically), or not at all?

We could maybe downgrade it to Orphan from Odd Fixes, unless
Philippe wants to volunteer as an "odd fixes" maintainer...

thanks
-- PMM

Re: [Qemu-devel] [PATCH for 3.1 v2 1/7] MAINTAINERS: Add an entry for the Raspberry Pi machines
Posted by Andrew Baumann via Qemu-devel 7 years, 3 months ago
> From: Peter Maydell <peter.maydell@linaro.org>
> Sent: Monday, 5 November 2018 09:58
> 
> On 5 November 2018 at 17:06, Andrew Baumann
> <Andrew.Baumann@microsoft.com> wrote:
> > From: Peter Maydell <peter.maydell@linaro.org>
> >> Andrew, as the original submitter of the Raspberry Pi code would you
> >> like to be listed as a maintainer for it?
> >
> > Thanks for asking; probably not -- I'm happy to review the odd patch
> > if my input would be helpful, but I haven't worked on it for years,
> > and I don't have spare cycles, so I'd just be a bottleneck.
> 
> Sure, no problem. Would you like to be listed as a "reviewer"
> (means people will CC you on patches, basically), or not at all?

Sure, reviewer is fine with me.

Andrew