osdep.h should be included first:

  CC      tests/vhost-user-bridge.o
In file included from /home/elmarco/src/qemu/tests/vhost-user-bridge.c:32:
/home/elmarco/src/qemu/include/qemu/atomic.h:480:1: error: unknown type name ‘int64_t’
 int64_t  atomic_read_i64(const int64_t *ptr);
 ^~~~~~~
/home/elmarco/src/qemu/include/qemu/atomic.h:480:32: error: unknown type name ‘int64_t’
 int64_t  atomic_read_i64(const int64_t *ptr);
                                ^~~~~~~
/home/elmarco/src/qemu/include/qemu/atomic.h:481:1: error: unknown type name ‘uint64_t’
 uint64_t atomic_read_u64(const uint64_t *ptr);
 ^~~~~~~~
/home/elmarco/src/qemu/include/qemu/atomic.h:481:32: error: unknown type name ‘uint64_t’
 uint64_t atomic_read_u64(const uint64_t *ptr);
                                ^~~~~~~~
/home/elmarco/src/qemu/include/qemu/atomic.h:482:21: error: unknown type name ‘int64_t’
 void atomic_set_i64(int64_t *ptr, int64_t val);
                     ^~~~~~~
/home/elmarco/src/qemu/include/qemu/atomic.h:482:35: error: unknown type name ‘int64_t’
 void atomic_set_i64(int64_t *ptr, int64_t val);
                                   ^~~~~~~
/home/elmarco/src/qemu/include/qemu/atomic.h:483:21: error: unknown type name ‘uint64_t’
 void atomic_set_u64(uint64_t *ptr, uint64_t val);
                     ^~~~~~~~
/home/elmarco/src/qemu/include/qemu/atomic.h:483:36: error: unknown type name ‘uint64_t’
 void atomic_set_u64(uint64_t *ptr, uint64_t val);
                                    ^~~~~~~~

(regression from 782da5b2921c4d18777d5d5bd9385b9f7beae360)

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 tests/vhost-user-bridge.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/vhost-user-bridge.c b/tests/vhost-user-bridge.c
index 0884294141..6e17370397 100644
--- a/tests/vhost-user-bridge.c
+++ b/tests/vhost-user-bridge.c
@@ -29,8 +29,9 @@
 
 #define _FILE_OFFSET_BITS 64
 
-#include "qemu/atomic.h"
 #include "qemu/osdep.h"
+
+#include "qemu/atomic.h"
 #include "qemu/iov.h"
 #include "standard-headers/linux/virtio_net.h"
 #include "contrib/libvhost-user/libvhost-user.h"
-- 
2.19.1.708.g4ede3d42df

On 10/31/2018 11:41 AM, Marc-André Lureau wrote:
> osdep.h should be included first:
> 
>   CC      tests/vhost-user-bridge.o
> In file included from /home/elmarco/src/qemu/tests/vhost-user-bridge.c:32:
> /home/elmarco/src/qemu/include/qemu/atomic.h:480:1: error: unknown type name ‘int64_t’
>  int64_t  atomic_read_i64(const int64_t *ptr);
>  ^~~~~~~
> /home/elmarco/src/qemu/include/qemu/atomic.h:480:32: error: unknown type name ‘int64_t’
>  int64_t  atomic_read_i64(const int64_t *ptr);
>                                 ^~~~~~~
> /home/elmarco/src/qemu/include/qemu/atomic.h:481:1: error: unknown type name ‘uint64_t’
>  uint64_t atomic_read_u64(const uint64_t *ptr);
>  ^~~~~~~~
> /home/elmarco/src/qemu/include/qemu/atomic.h:481:32: error: unknown type name ‘uint64_t’
>  uint64_t atomic_read_u64(const uint64_t *ptr);
>                                 ^~~~~~~~
> /home/elmarco/src/qemu/include/qemu/atomic.h:482:21: error: unknown type name ‘int64_t’
>  void atomic_set_i64(int64_t *ptr, int64_t val);
>                      ^~~~~~~
> /home/elmarco/src/qemu/include/qemu/atomic.h:482:35: error: unknown type name ‘int64_t’
>  void atomic_set_i64(int64_t *ptr, int64_t val);
>                                    ^~~~~~~
> /home/elmarco/src/qemu/include/qemu/atomic.h:483:21: error: unknown type name ‘uint64_t’
>  void atomic_set_u64(uint64_t *ptr, uint64_t val);
>                      ^~~~~~~~
> /home/elmarco/src/qemu/include/qemu/atomic.h:483:36: error: unknown type name ‘uint64_t’
>  void atomic_set_u64(uint64_t *ptr, uint64_t val);
>                                     ^~~~~~~~
> 
> (regression from 782da5b2921c4d18777d5d5bd9385b9f7beae360)
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  tests/vhost-user-bridge.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Funny, I was just looking into this right now :-)

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal

On Wed, Oct 31, 2018 at 14:41:36 +0400, Marc-André Lureau wrote:
> osdep.h should be included first:
> 
>   CC      tests/vhost-user-bridge.o
> In file included from /home/elmarco/src/qemu/tests/vhost-user-bridge.c:32:
> /home/elmarco/src/qemu/include/qemu/atomic.h:480:1: error: unknown type name ‘int64_t’
>  int64_t  atomic_read_i64(const int64_t *ptr);
(snip)
> (regression from 782da5b2921c4d18777d5d5bd9385b9f7beae360)
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

Reviewed-by: Emilio G. Cota <cota@braap.org>

Thanks,

		Emilio