[Qemu-devel] [PATCH 0/4] Introducing QemuSupportState

Gerd Hoffmann posted 4 patches 7 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181030111348.14713-1-kraxel@redhat.com
Test docker-clang@ubuntu passed
Test checkpatch passed
Test asan passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
There is a newer version of this series
include/hw/boards.h          |  5 ++---
include/hw/qdev-core.h       |  2 ++
include/qemu/support-state.h | 17 +++++++++++++++++
hw/core/qdev.c               |  8 +++++++-
hw/display/cirrus_vga.c      |  3 +++
hw/display/cirrus_vga_isa.c  |  3 +++
hw/i386/pc_piix.c            |  3 ++-
hw/ppc/prep.c                |  3 ++-
qdev-monitor.c               |  7 +++++++
util/support-state.c         | 23 +++++++++++++++++++++++
vl.c                         |  6 +++---
qapi/common.json             | 16 ++++++++++++++++
util/Makefile.objs           |  1 +
13 files changed, 88 insertions(+), 9 deletions(-)
create mode 100644 include/qemu/support-state.h
create mode 100644 util/support-state.c
[Qemu-devel] [PATCH 0/4] Introducing QemuSupportState
Posted by Gerd Hoffmann 7 years ago
Trying to fill the need to be more finegrained on support status ...

Any hints/patches how to hook that into introspection so we get
machine type / device support status to libvirt are welcome.

Gerd Hoffmann (4):
  add QemuSupportState
  add QemuSupportState to DeviceClass
  tag cirrus as obsolete
  switch machine types to QemuSupportState

 include/hw/boards.h          |  5 ++---
 include/hw/qdev-core.h       |  2 ++
 include/qemu/support-state.h | 17 +++++++++++++++++
 hw/core/qdev.c               |  8 +++++++-
 hw/display/cirrus_vga.c      |  3 +++
 hw/display/cirrus_vga_isa.c  |  3 +++
 hw/i386/pc_piix.c            |  3 ++-
 hw/ppc/prep.c                |  3 ++-
 qdev-monitor.c               |  7 +++++++
 util/support-state.c         | 23 +++++++++++++++++++++++
 vl.c                         |  6 +++---
 qapi/common.json             | 16 ++++++++++++++++
 util/Makefile.objs           |  1 +
 13 files changed, 88 insertions(+), 9 deletions(-)
 create mode 100644 include/qemu/support-state.h
 create mode 100644 util/support-state.c

-- 
2.9.3


Re: [Qemu-devel] [PATCH 0/4] Introducing QemuSupportState
Posted by Paolo Bonzini 7 years ago
On 30/10/2018 12:13, Gerd Hoffmann wrote:
> Trying to fill the need to be more finegrained on support status ...
> 
> Any hints/patches how to hook that into introspection so we get
> machine type / device support status to libvirt are welcome.

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

> Gerd Hoffmann (4):
>   add QemuSupportState
>   add QemuSupportState to DeviceClass
>   tag cirrus as obsolete
>   switch machine types to QemuSupportState
> 
>  include/hw/boards.h          |  5 ++---
>  include/hw/qdev-core.h       |  2 ++
>  include/qemu/support-state.h | 17 +++++++++++++++++
>  hw/core/qdev.c               |  8 +++++++-
>  hw/display/cirrus_vga.c      |  3 +++
>  hw/display/cirrus_vga_isa.c  |  3 +++
>  hw/i386/pc_piix.c            |  3 ++-
>  hw/ppc/prep.c                |  3 ++-
>  qdev-monitor.c               |  7 +++++++
>  util/support-state.c         | 23 +++++++++++++++++++++++
>  vl.c                         |  6 +++---
>  qapi/common.json             | 16 ++++++++++++++++
>  util/Makefile.objs           |  1 +
>  13 files changed, 88 insertions(+), 9 deletions(-)
>  create mode 100644 include/qemu/support-state.h
>  create mode 100644 util/support-state.c
> 


Re: [Qemu-devel] [PATCH 0/4] Introducing QemuSupportState
Posted by Eduardo Habkost 7 years ago
On Tue, Oct 30, 2018 at 12:13:44PM +0100, Gerd Hoffmann wrote:
> Trying to fill the need to be more finegrained on support status ...
> 
> Any hints/patches how to hook that into introspection so we get
> machine type / device support status to libvirt are welcome.

We have qom-list-types, but it returns info for all QOM types,
not just device types.

I see two possible approaches for this:

* Decide that every QOM type (devices, backend objects,
  machine-types) will have this flag, and just add it to
  qom-list-types.
* Add device-list-types or query-device-type commands,
  specific for TYPE_DEVICE.

I'm not sure which one is better.  The latter is more
conservative and safer, but will require duplicating the same
work for machine-types and backend objects later.

-- 
Eduardo