Pass other sense, such as UNIT_ATTENTION or BUSY, directly to the
guest.

Reported-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/scsi/scsi-generic.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c
index 8fc74ef0bd..b8fa0a0f7e 100644
--- a/hw/scsi/scsi-generic.c
+++ b/hw/scsi/scsi-generic.c
@@ -246,7 +246,6 @@ static void scsi_read_complete(void * opaque, int ret)
 {
     SCSIGenericReq *r = (SCSIGenericReq *)opaque;
     SCSIDevice *s = r->req.dev;
-    SCSISense sense;
     int len;
 
     assert(r->req.aiocb != NULL);
@@ -269,12 +268,15 @@ static void scsi_read_complete(void * opaque, int ret)
      * resulted in sense error but would need emulation.
      * In this case, emulate a valid VPD response.
      */
-    if (s->needs_vpd_bl_emulation) {
+    if (ret == 0 &&
+        (r->io_header.driver_status & SG_ERR_DRIVER_SENSE) &&
+        scsi_parse_sense_buf(r->req.sense, r->io_header.sb_len_wr).key == ILLEGAL_REQUEST &&
+        s->needs_vpd_bl_emulation) {
         int is_vpd_bl = r->req.cmd.buf[0] == INQUIRY &&
                          r->req.cmd.buf[1] & 0x01 &&
                          r->req.cmd.buf[2] == 0xb0;
 
-        if (is_vpd_bl && sg_io_sense_from_errno(-ret, &r->io_header, &sense)) {
+        if (is_vpd_bl) {
             len = scsi_generic_emulate_block_limits(r, s);
             /*
              * No need to let scsi_read_complete go on and handle an
-- 
2.17.1

On 29.10.18 18:34, Paolo Bonzini wrote:
> Pass other sense, such as UNIT_ATTENTION or BUSY, directly to the
> guest.
> 
> Reported-by: Max Reitz <mreitz@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  hw/scsi/scsi-generic.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

[...]

> @@ -269,12 +268,15 @@ static void scsi_read_complete(void * opaque, int ret)
>       * resulted in sense error but would need emulation.
>       * In this case, emulate a valid VPD response.
>       */
> -    if (s->needs_vpd_bl_emulation) {
> +    if (ret == 0 &&
> +        (r->io_header.driver_status & SG_ERR_DRIVER_SENSE) &&
> +        scsi_parse_sense_buf(r->req.sense, r->io_header.sb_len_wr).key == ILLEGAL_REQUEST &&

As noted by Patchew, this line needs to be split.  With that done:

Reviewed-by: Max Reitz <mreitz@redhat.com>


Thanks for the series!

Max