Series comparison

-[Qemu-devel] [PULL 0/6] target-arm queue
+[PULL 00/34] target-arm queue
-Last lot of patches for arm before softfreeze tomorrow...
+Some arm patches; my to-review queue is by no means empty, but
 this is a big enough set of patches to be getting on with...
-thanks
 -- PMM
-The following changes since commit ef3a6af5e789ff078d1fef880f9dfb6adf18e8f1:
+The following changes since commit cb9c6a8e5ad6a1f0ce164d352e3102df46986e22:
-  Merge remote-tracking branch 'remotes/kraxel/tags/vga-20181029-pull-request' into staging (2018-10-29 12:59:15 +0000)
+  .gitlab-ci.d/windows: Work-around timeout and OpenGL problems of the MSYS2 jobs (2023-01-04 18:58:33 +0000)
 are available in the Git repository at:
-  https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20181029
+  https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20230105
-for you to fetch changes up to 20cf5663734310a282e27b7389bc9f53ffe227e6:
+for you to fetch changes up to 93c9678de9dc7d2e68f9e8477da072bac30ef132:
-  tests/boot-serial-test: Add microbit board testcase (2018-10-29 15:19:48 +0000)
+  hw/net: Fix read of uninitialized memory in imx_fec. (2023-01-05 15:33:00 +0000)
 ----------------------------------------------------------------
 target-arm queue:
- * microbit: Add the UART to our nRF51 SoC model
+ * Implement AArch32 ARMv8-R support
- * Add a virtual Xilinx Versal board "xlnx-versal-virt"
+ * Add Cortex-R52 CPU
- * hw/arm/virt: Set VIRT_COMPAT_3_0 compat
+ * fix handling of HLT semihosting in system mode
  * hw/timer/ixm_epit: cleanup and fix bug in compare handling
  * target/arm: Coding style fixes
  * target/arm: Clean up includes
  * nseries: minor code cleanups
  * target/arm: align exposed ID registers with Linux
  * hw/arm/smmu-common: remove unnecessary inlines
  * i.MX7D: Handle GPT timers
  * i.MX7D: Connect IRQs to GPIO devices
  * i.MX6UL: Add a specific GPT timer instance
  * hw/net: Fix read of uninitialized memory in imx_fec
 ----------------------------------------------------------------
-Edgar E. Iglesias (2):
+Alex Bennée (1):
-      hw/arm: versal: Add a model of Xilinx Versal SoC
+      target/arm: fix handling of HLT semihosting in system mode
       hw/arm: versal: Add a virtual Xilinx Versal board
-Eric Auger (1):
+Axel Heider (8):
-      hw/arm/virt: Set VIRT_COMPAT_3_0 compat
+      hw/timer/imx_epit: improve comments
       hw/timer/imx_epit: cleanup CR defines
       hw/timer/imx_epit: define SR_OCIF
       hw/timer/imx_epit: update interrupt state on CR write access
       hw/timer/imx_epit: hard reset initializes CR with 0
       hw/timer/imx_epit: factor out register write handlers
       hw/timer/imx_epit: remove explicit fields cnt and freq
       hw/timer/imx_epit: fix compare timer handling
-Julia Suvorova (3):
+Claudio Fontana (1):
-      hw/char: Implement nRF51 SoC UART
+      target/arm: cleanup cpu includes
       hw/arm/nrf51_soc: Connect UART to nRF51 SoC
       tests/boot-serial-test: Add microbit board testcase
- hw/arm/Makefile.objs                |   1 +
+Fabiano Rosas (5):
- hw/char/Makefile.objs               |   1 +
+      target/arm: Fix checkpatch comment style warnings in helper.c
- include/hw/arm/nrf51_soc.h          |   3 +
+      target/arm: Fix checkpatch space errors in helper.c
- include/hw/arm/xlnx-versal.h        | 122 +++++++++
+      target/arm: Fix checkpatch brace errors in helper.c
- include/hw/char/nrf51_uart.h        |  78 ++++++
+      target/arm: Remove unused includes from m_helper.c
- hw/arm/microbit.c                   |   2 +
+      target/arm: Remove unused includes from helper.c
  hw/arm/nrf51_soc.c                  |  20 ++
  hw/arm/virt.c                       |   4 +
  hw/arm/xlnx-versal-virt.c           | 493 ++++++++++++++++++++++++++++++++++++
  hw/arm/xlnx-versal.c                | 323 +++++++++++++++++++++++
  hw/char/nrf51_uart.c                | 330 ++++++++++++++++++++++++
  tests/boot-serial-test.c            |  19 ++
  default-configs/aarch64-softmmu.mak |   1 +
  hw/char/trace-events                |   4 +
 files changed, 1401 insertions(+)
  create mode 100644 include/hw/arm/xlnx-versal.h
  create mode 100644 include/hw/char/nrf51_uart.h
  create mode 100644 hw/arm/xlnx-versal-virt.c
  create mode 100644 hw/arm/xlnx-versal.c
  create mode 100644 hw/char/nrf51_uart.c
+Jean-Christophe Dubois (4):
+      i.MX7D: Connect GPT timers to IRQ
+      i.MX7D: Compute clock frequency for the fixed frequency clocks.
+      i.MX6UL: Add a specific GPT timer instance for the i.MX6UL
+      i.MX7D: Connect IRQs to GPIO devices.
+Peter Maydell (1):
+      target/arm:Set lg_page_size to 0 if either S1 or S2 asks for it
+Philippe Mathieu-Daudé (5):
+      hw/input/tsc2xxx: Constify set_transform()'s MouseTransformInfo arg
+      hw/arm/nseries: Constify various read-only arrays
+      hw/arm/nseries: Silent -Wmissing-field-initializers warning
+      hw/arm/smmu-common: Reduce smmu_inv_notifiers_mr() scope
+      hw/arm/smmu-common: Avoid using inlined functions with external linkage
+Stephen Longfield (1):
+      hw/net: Fix read of uninitialized memory in imx_fec.
+Tobias Röhmel (7):
+      target/arm: Don't add all MIDR aliases for cores that implement PMSA
+      target/arm: Make RVBAR available for all ARMv8 CPUs
+      target/arm: Make stage_2_format for cache attributes optional
+      target/arm: Enable TTBCR_EAE for ARMv8-R AArch32
+      target/arm: Add PMSAv8r registers
+      target/arm: Add PMSAv8r functionality
+      target/arm: Add ARM Cortex-R52 CPU
+Zhuojia Shen (1):
+      target/arm: align exposed ID registers with Linux
+ include/hw/arm/fsl-imx7.h         |  20 +
+ include/hw/arm/smmu-common.h      |   3 -
+ include/hw/input/tsc2xxx.h        |   4 +-
+ include/hw/timer/imx_epit.h       |   8 +-
+ include/hw/timer/imx_gpt.h        |   1 +
+ target/arm/cpu.h                  |   6 +
+ target/arm/internals.h            |   4 +
+ hw/arm/fsl-imx6ul.c               |   2 +-
+ hw/arm/fsl-imx7.c                 |  41 +-
+ hw/arm/nseries.c                  |  28 +-
+ hw/arm/smmu-common.c              |  15 +-
+ hw/input/tsc2005.c                |   2 +-
+ hw/input/tsc210x.c                |   3 +-
+ hw/misc/imx6ul_ccm.c              |   6 -
+ hw/misc/imx7_ccm.c                |  49 ++-
+ hw/net/imx_fec.c                  |   8 +-
+ hw/timer/imx_epit.c               | 376 +++++++++-------
+ hw/timer/imx_gpt.c                |  25 ++
+ target/arm/cpu.c                  |  35 +-
+ target/arm/cpu64.c                |   6 -
+ target/arm/cpu_tcg.c              |  42 ++
+ target/arm/debug_helper.c         |   3 +
+ target/arm/helper.c               | 871 +++++++++++++++++++++++++++++---------
+ target/arm/m_helper.c             |  16 -
+ target/arm/machine.c              |  28 ++
+ target/arm/ptw.c                  | 152 +++++--
+ target/arm/tlb_helper.c           |   4 +
+ target/arm/translate.c            |   2 +-
+ tests/tcg/aarch64/sysregs.c       |  24 +-
+ tests/tcg/aarch64/Makefile.target |   7 +-
+files changed, 1330 insertions(+), 461 deletions(-)

-New patch
+[PULL 01/34] target/arm:Set lg_page_size to 0 if either S1 or S2 asks for it
+In get_phys_addr_twostage() we set the lg_page_size of the result to
+the maximum of the stage 1 and stage 2 page sizes.  This works for
+the case where we do want to create a TLB entry, because we know the
+common TLB code only creates entries of the TARGET_PAGE_SIZE and
+asking for a size larger than that only means that invalidations
+invalidate the whole larger area.  However, if lg_page_size is
+smaller than TARGET_PAGE_SIZE this effectively means "don't create a
+TLB entry"; in this case if either S1 or S2 said "this covers less
+than a page and can't go in a TLB" then the final result also should
+be marked that way.  Set the resulting page size to 0 if either
+stage asked for a less-than-a-page entry, and expand the comment
+to explain what's going on.
+This has no effect for VMSA because currently the VMSA lookup always
+returns results that cover at least TARGET_PAGE_SIZE; however when we
+add v8R support it will reuse this code path, and for v8R the S1 and
+S2 results can be smaller than TARGET_PAGE_SIZE.
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
+Message-id: 20221212142708.610090-1-peter.maydell@linaro.org
+---
+ target/arm/ptw.c | 16 +++++++++++++---
+file changed, 13 insertions(+), 3 deletions(-)
+diff --git a/target/arm/ptw.c b/target/arm/ptw.c
+index XXXXXXX..XXXXXXX 100644
+--- a/target/arm/ptw.c
++++ b/target/arm/ptw.c
+@@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_twostage(CPUARMState *env, S1Translate *ptw,
+     }
+     /*
+-     * Use the maximum of the S1 & S2 page size, so that invalidation
+-     * of pages > TARGET_PAGE_SIZE works correctly.
++     * If either S1 or S2 returned a result smaller than TARGET_PAGE_SIZE,
++     * this means "don't put this in the TLB"; in this case, return a
++     * result with lg_page_size == 0 to achieve that. Otherwise,
++     * use the maximum of the S1 & S2 page size, so that invalidation
++     * of pages > TARGET_PAGE_SIZE works correctly. (This works even though
++     * we know the combined result permissions etc only cover the minimum
++     * of the S1 and S2 page size, because we know that the common TLB code
++     * never actually creates TLB entries bigger than TARGET_PAGE_SIZE,
++     * and passing a larger page size value only affects invalidations.)
+      */
+-    if (result->f.lg_page_size < s1_lgpgsz) {
++    if (result->f.lg_page_size < TARGET_PAGE_BITS ||
++        s1_lgpgsz < TARGET_PAGE_BITS) {
++        result->f.lg_page_size = 0;
++    } else if (result->f.lg_page_size < s1_lgpgsz) {
+         result->f.lg_page_size = s1_lgpgsz;
+     }
+--
+.25.1

-New patch
+[PULL 02/34] target/arm: Don't add all MIDR aliases for cores that implement PMSA
+From: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>
+Cores with PMSA have the MPUIR register which has the
+same encoding as the MIDR alias with opc2=4. So we only
+add that alias if we are not realizing a core that
+implements PMSA.
+Signed-off-by: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>
+Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
+Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
+Message-id: 20221206102504.165775-2-tobias.roehmel@rwth-aachen.de
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+---
+ target/arm/helper.c | 13 +++++++++----
+file changed, 9 insertions(+), 4 deletions(-)
+diff --git a/target/arm/helper.c b/target/arm/helper.c
+index XXXXXXX..XXXXXXX 100644
+--- a/target/arm/helper.c
++++ b/target/arm/helper.c
+@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
+               .access = PL1_R, .type = ARM_CP_NO_RAW, .resetvalue = cpu->midr,
+               .fieldoffset = offsetof(CPUARMState, cp15.c0_cpuid),
+               .readfn = midr_read },
+-            /* crn = 0 op1 = 0 crm = 0 op2 = 4,7 : AArch32 aliases of MIDR */
+-            { .name = "MIDR", .type = ARM_CP_ALIAS | ARM_CP_CONST,
+-              .cp = 15, .crn = 0, .crm = 0, .opc1 = 0, .opc2 = 4,
+-              .access = PL1_R, .resetvalue = cpu->midr },
++            /* crn = 0 op1 = 0 crm = 0 op2 = 7 : AArch32 aliases of MIDR */
+             { .name = "MIDR", .type = ARM_CP_ALIAS | ARM_CP_CONST,
+               .cp = 15, .crn = 0, .crm = 0, .opc1 = 0, .opc2 = 7,
+               .access = PL1_R, .resetvalue = cpu->midr },
+@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
+               .accessfn = access_aa64_tid1,
+               .type = ARM_CP_CONST, .resetvalue = cpu->revidr },
+         };
++        ARMCPRegInfo id_v8_midr_alias_cp_reginfo = {
++            .name = "MIDR", .type = ARM_CP_ALIAS | ARM_CP_CONST,
++            .cp = 15, .crn = 0, .crm = 0, .opc1 = 0, .opc2 = 4,
++            .access = PL1_R, .resetvalue = cpu->midr
++        };
+         ARMCPRegInfo id_cp_reginfo[] = {
+             /* These are common to v8 and pre-v8 */
+             { .name = "CTR",
+@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
+         }
+         if (arm_feature(env, ARM_FEATURE_V8)) {
+             define_arm_cp_regs(cpu, id_v8_midr_cp_reginfo);
++            if (!arm_feature(env, ARM_FEATURE_PMSA)) {
++                define_one_arm_cp_reg(cpu, &id_v8_midr_alias_cp_reginfo);
++            }
+         } else {
+             define_arm_cp_regs(cpu, id_pre_v8_midr_cp_reginfo);
+         }
+--
+.25.1

-New patch
+[PULL 03/34] target/arm: Make RVBAR available for all ARMv8 CPUs
+From: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>
+RVBAR shadows RVBAR_ELx where x is the highest exception
+level if the highest EL is not EL3. This patch also allows
+ARMv8 CPUs to change the reset address with
+the rvbar property.
+Signed-off-by: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>
+Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
+Message-id: 20221206102504.165775-3-tobias.roehmel@rwth-aachen.de
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+---
+ target/arm/cpu.c    |  6 +++++-
+ target/arm/helper.c | 21 ++++++++++++++-------
+files changed, 19 insertions(+), 8 deletions(-)
+diff --git a/target/arm/cpu.c b/target/arm/cpu.c
+index XXXXXXX..XXXXXXX 100644
+--- a/target/arm/cpu.c
++++ b/target/arm/cpu.c
+@@ -XXX,XX +XXX,XX @@ static void arm_cpu_reset_hold(Object *obj)
+         env->cp15.cpacr_el1 = FIELD_DP64(env->cp15.cpacr_el1,
+                                          CPACR, CP11, 3);
+ #endif
++        if (arm_feature(env, ARM_FEATURE_V8)) {
++            env->cp15.rvbar = cpu->rvbar_prop;
++            env->regs[15] = cpu->rvbar_prop;
++        }
+     }
+ #if defined(CONFIG_USER_ONLY)
+@@ -XXX,XX +XXX,XX @@ void arm_cpu_post_init(Object *obj)
+         qdev_property_add_static(DEVICE(obj), &arm_cpu_reset_hivecs_property);
+     }
+-    if (arm_feature(&cpu->env, ARM_FEATURE_AARCH64)) {
++    if (arm_feature(&cpu->env, ARM_FEATURE_V8)) {
+         object_property_add_uint64_ptr(obj, "rvbar",
+                                        &cpu->rvbar_prop,
+                                        OBJ_PROP_FLAG_READWRITE);
+diff --git a/target/arm/helper.c b/target/arm/helper.c
+index XXXXXXX..XXXXXXX 100644
+--- a/target/arm/helper.c
++++ b/target/arm/helper.c
+@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
+         if (!arm_feature(env, ARM_FEATURE_EL3) &&
+             !arm_feature(env, ARM_FEATURE_EL2)) {
+             ARMCPRegInfo rvbar = {
+-                .name = "RVBAR_EL1", .state = ARM_CP_STATE_AA64,
++                .name = "RVBAR_EL1", .state = ARM_CP_STATE_BOTH,
+                 .opc0 = 3, .opc1 = 0, .crn = 12, .crm = 0, .opc2 = 1,
+                 .access = PL1_R,
+                 .fieldoffset = offsetof(CPUARMState, cp15.rvbar),
+@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
+         }
+         /* RVBAR_EL2 is only implemented if EL2 is the highest EL */
+         if (!arm_feature(env, ARM_FEATURE_EL3)) {
+-            ARMCPRegInfo rvbar = {
+-                .name = "RVBAR_EL2", .state = ARM_CP_STATE_AA64,
+-                .opc0 = 3, .opc1 = 4, .crn = 12, .crm = 0, .opc2 = 1,
+-                .access = PL2_R,
+-                .fieldoffset = offsetof(CPUARMState, cp15.rvbar),
++            ARMCPRegInfo rvbar[] = {
++                {
++                    .name = "RVBAR_EL2", .state = ARM_CP_STATE_AA64,
++                    .opc0 = 3, .opc1 = 4, .crn = 12, .crm = 0, .opc2 = 1,
++                    .access = PL2_R,
++                    .fieldoffset = offsetof(CPUARMState, cp15.rvbar),
++                },
++                {   .name = "RVBAR", .type = ARM_CP_ALIAS,
++                    .cp = 15, .opc1 = 0, .crn = 12, .crm = 0, .opc2 = 1,
++                    .access = PL2_R,
++                    .fieldoffset = offsetof(CPUARMState, cp15.rvbar),
++                },
+             };
+-            define_one_arm_cp_reg(cpu, &rvbar);
++            define_arm_cp_regs(cpu, rvbar);
+         }
+     }
+--
+.25.1

-New patch
+[PULL 04/34] target/arm: Make stage_2_format for cache attributes optional
+From: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>
+The v8R PMSAv8 has a two-stage MPU translation process, but, unlike
+VMSAv8, the stage 2 attributes are in the same format as the stage 1
+attributes (8-bit MAIR format). Rather than converting the MAIR
+format to the format used for VMSA stage 2 (bits [5:2] of a VMSA
+stage 2 descriptor) and then converting back to do the attribute
+combination, allow combined_attrs_nofwb() to accept s2 attributes
+that are already in the MAIR format.
+We move the assert() to combined_attrs_fwb(), because that function
+really does require a VMSA stage 2 attribute format. (We will never
+get there for v8R, because PMSAv8 does not implement FEAT_S2FWB.)
+Signed-off-by: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>
+Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
+Message-id: 20221206102504.165775-4-tobias.roehmel@rwth-aachen.de
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+---
+ target/arm/ptw.c | 10 ++++++++--
+file changed, 8 insertions(+), 2 deletions(-)
+diff --git a/target/arm/ptw.c b/target/arm/ptw.c
+index XXXXXXX..XXXXXXX 100644
+--- a/target/arm/ptw.c
++++ b/target/arm/ptw.c
+@@ -XXX,XX +XXX,XX @@ static uint8_t combined_attrs_nofwb(uint64_t hcr,
+ {
+     uint8_t s1lo, s2lo, s1hi, s2hi, s2_mair_attrs, ret_attrs;
+-    s2_mair_attrs = convert_stage2_attrs(hcr, s2.attrs);
++    if (s2.is_s2_format) {
++        s2_mair_attrs = convert_stage2_attrs(hcr, s2.attrs);
++    } else {
++        s2_mair_attrs = s2.attrs;
++    }
+     s1lo = extract32(s1.attrs, 0, 4);
+     s2lo = extract32(s2_mair_attrs, 0, 4);
+@@ -XXX,XX +XXX,XX @@ static uint8_t force_cacheattr_nibble_wb(uint8_t attr)
+  */
+ static uint8_t combined_attrs_fwb(ARMCacheAttrs s1, ARMCacheAttrs s2)
+ {
++    assert(s2.is_s2_format && !s1.is_s2_format);
++
+     switch (s2.attrs) {
+     case 7:
+         /* Use stage 1 attributes */
+@@ -XXX,XX +XXX,XX @@ static ARMCacheAttrs combine_cacheattrs(uint64_t hcr,
+     ARMCacheAttrs ret;
+     bool tagged = false;
+-    assert(s2.is_s2_format && !s1.is_s2_format);
++    assert(!s1.is_s2_format);
+     ret.is_s2_format = false;
+     if (s1.attrs == 0xf0) {
+--
+.25.1

-New patch
+[PULL 05/34] target/arm: Enable TTBCR_EAE for ARMv8-R AArch32
+From: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>
+ARMv8-R AArch32 CPUs behave as if TTBCR.EAE is always 1 even
+tough they don't have the TTBCR register.
+See ARM Architecture Reference Manual Supplement - ARMv8, for the ARMv8-R
+AArch32 architecture profile Version:A.c section C1.2.
+Signed-off-by: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>
+Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
+Message-id: 20221206102504.165775-5-tobias.roehmel@rwth-aachen.de
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+---
+ target/arm/internals.h    | 4 ++++
+ target/arm/debug_helper.c | 3 +++
+ target/arm/tlb_helper.c   | 4 ++++
+files changed, 11 insertions(+)
+diff --git a/target/arm/internals.h b/target/arm/internals.h
+index XXXXXXX..XXXXXXX 100644
+--- a/target/arm/internals.h
++++ b/target/arm/internals.h
+@@ -XXX,XX +XXX,XX @@ unsigned int arm_pamax(ARMCPU *cpu);
+ static inline bool extended_addresses_enabled(CPUARMState *env)
+ {
+     uint64_t tcr = env->cp15.tcr_el[arm_is_secure(env) ? 3 : 1];
++    if (arm_feature(env, ARM_FEATURE_PMSA) &&
++        arm_feature(env, ARM_FEATURE_V8)) {
++        return true;
++    }
+     return arm_el_is_aa64(env, 1) ||
+            (arm_feature(env, ARM_FEATURE_LPAE) && (tcr & TTBCR_EAE));
+ }
+diff --git a/target/arm/debug_helper.c b/target/arm/debug_helper.c
+index XXXXXXX..XXXXXXX 100644
+--- a/target/arm/debug_helper.c
++++ b/target/arm/debug_helper.c
+@@ -XXX,XX +XXX,XX @@ static uint32_t arm_debug_exception_fsr(CPUARMState *env)
+     if (target_el == 2 || arm_el_is_aa64(env, target_el)) {
+         using_lpae = true;
++    } else if (arm_feature(env, ARM_FEATURE_PMSA) &&
++               arm_feature(env, ARM_FEATURE_V8)) {
++        using_lpae = true;
+     } else {
+         if (arm_feature(env, ARM_FEATURE_LPAE) &&
+             (env->cp15.tcr_el[target_el] & TTBCR_EAE)) {
+diff --git a/target/arm/tlb_helper.c b/target/arm/tlb_helper.c
+index XXXXXXX..XXXXXXX 100644
+--- a/target/arm/tlb_helper.c
++++ b/target/arm/tlb_helper.c
+@@ -XXX,XX +XXX,XX @@ bool regime_using_lpae_format(CPUARMState *env, ARMMMUIdx mmu_idx)
+     if (el == 2 || arm_el_is_aa64(env, el)) {
+         return true;
+     }
++    if (arm_feature(env, ARM_FEATURE_PMSA) &&
++        arm_feature(env, ARM_FEATURE_V8)) {
++        return true;
++    }
+     if (arm_feature(env, ARM_FEATURE_LPAE)
+         && (regime_tcr(env, mmu_idx) & TTBCR_EAE)) {
+         return true;
+--
+.25.1

-[Qemu-devel] [PULL 3/6] hw/arm: versal: Add a virtual Xilinx Versal board
+[PULL 06/34] target/arm: Add PMSAv8r registers
-From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
+From: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>
-Add a virtual Xilinx Versal board.
+Signed-off-by: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>
+Message-id: 20221206102504.165775-6-tobias.roehmel@rwth-aachen.de
 This board is based on the Xilinx Versal SoC. The exact
 details of what peripherals are attached to this board
 will remain in control of QEMU. QEMU will generate an
 FDT on the fly for Linux and other software to auto-discover
 peripherals.
 Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
 [PMM: removed stray blank line at EOF]
 Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
 Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
 ---
- hw/arm/Makefile.objs      |   2 +-
+ target/arm/cpu.h     |   6 +
- hw/arm/xlnx-versal-virt.c | 493 ++++++++++++++++++++++++++++++++++++++
+ target/arm/cpu.c     |  28 +++-
-files changed, 494 insertions(+), 1 deletion(-)
+ target/arm/helper.c  | 302 +++++++++++++++++++++++++++++++++++++++++++
- create mode 100644 hw/arm/xlnx-versal-virt.c
+ target/arm/machine.c |  28 ++++
 files changed, 360 insertions(+), 4 deletions(-)
-diff --git a/hw/arm/Makefile.objs b/hw/arm/Makefile.objs
+diff --git a/target/arm/cpu.h b/target/arm/cpu.h
 index XXXXXXX..XXXXXXX 100644
---- a/hw/arm/Makefile.objs
+--- a/target/arm/cpu.h
-+++ b/hw/arm/Makefile.objs
++++ b/target/arm/cpu.h
-@@ -XXX,XX +XXX,XX @@ obj-$(CONFIG_ALLWINNER_A10) += allwinner-a10.o cubieboard.o
+@@ -XXX,XX +XXX,XX @@ typedef struct CPUArchState {
- obj-$(CONFIG_RASPI) += bcm2835_peripherals.o bcm2836.o raspi.o
+             };
- obj-$(CONFIG_STM32F205_SOC) += stm32f205_soc.o
+             uint64_t sctlr_el[4];
- obj-$(CONFIG_XLNX_ZYNQMP_ARM) += xlnx-zynqmp.o xlnx-zcu102.o
+         };
--obj-$(CONFIG_XLNX_VERSAL) += xlnx-versal.o
++        uint64_t vsctlr; /* Virtualization System control register. */
-+obj-$(CONFIG_XLNX_VERSAL) += xlnx-versal.o xlnx-versal-virt.o
+         uint64_t cpacr_el1; /* Architectural feature access control register */
- obj-$(CONFIG_FSL_IMX25) += fsl-imx25.o imx25_pdk.o
+         uint64_t cptr_el[4];  /* ARMv8 feature trap registers */
- obj-$(CONFIG_FSL_IMX31) += fsl-imx31.o kzm.o
+         uint32_t c1_xscaleauxcr; /* XScale auxiliary control register.  */
- obj-$(CONFIG_FSL_IMX6) += fsl-imx6.o sabrelite.o
+@@ -XXX,XX +XXX,XX @@ typedef struct CPUArchState {
-diff --git a/hw/arm/xlnx-versal-virt.c b/hw/arm/xlnx-versal-virt.c
+          */
-new file mode 100644
+         uint32_t *rbar[M_REG_NUM_BANKS];
-index XXXXXXX..XXXXXXX
+         uint32_t *rlar[M_REG_NUM_BANKS];
---- /dev/null
++        uint32_t *hprbar;
-+++ b/hw/arm/xlnx-versal-virt.c
++        uint32_t *hprlar;
-@@ -XXX,XX +XXX,XX @@
+         uint32_t mair0[M_REG_NUM_BANKS];
-+/*
+         uint32_t mair1[M_REG_NUM_BANKS];
-+ * Xilinx Versal Virtual board.
++        uint32_t hprselr;
-+ *
+     } pmsav8;
-+ * Copyright (c) 2018 Xilinx Inc.
-+ * Written by Edgar E. Iglesias
+     /* v8M SAU */
-+ *
+@@ -XXX,XX +XXX,XX @@ struct ArchCPU {
-+ * This program is free software; you can redistribute it and/or modify
+     bool has_mpu;
-+ * it under the terms of the GNU General Public License version 2 or
+     /* PMSAv7 MPU number of supported regions */
-+ * (at your option) any later version.
+     uint32_t pmsav7_dregion;
-+ */
++    /* PMSAv8 MPU number of supported hyp regions */
-+
++    uint32_t pmsav8r_hdregion;
-+#include "qemu/osdep.h"
+     /* v8M SAU number of supported regions */
-+#include "qemu/log.h"
+     uint32_t sau_sregion;
-+#include "qemu/error-report.h"
-+#include "qapi/error.h"
+diff --git a/target/arm/cpu.c b/target/arm/cpu.c
-+#include "sysemu/device_tree.h"
+index XXXXXXX..XXXXXXX 100644
-+#include "exec/address-spaces.h"
+--- a/target/arm/cpu.c
-+#include "hw/boards.h"
++++ b/target/arm/cpu.c
-+#include "hw/sysbus.h"
+@@ -XXX,XX +XXX,XX @@ static void arm_cpu_reset_hold(Object *obj)
-+#include "hw/arm/sysbus-fdt.h"
+                        sizeof(*env->pmsav7.dracr) * cpu->pmsav7_dregion);
-+#include "hw/arm/fdt.h"
+             }
-+#include "cpu.h"
+         }
-+#include "hw/arm/xlnx-versal.h"
++
-+
++        if (cpu->pmsav8r_hdregion > 0) {
-+#define TYPE_XLNX_VERSAL_VIRT_MACHINE MACHINE_TYPE_NAME("xlnx-versal-virt")
++            memset(env->pmsav8.hprbar, 0,
-+#define XLNX_VERSAL_VIRT_MACHINE(obj) \
++                   sizeof(*env->pmsav8.hprbar) * cpu->pmsav8r_hdregion);
-+    OBJECT_CHECK(VersalVirt, (obj), TYPE_XLNX_VERSAL_VIRT_MACHINE)
++            memset(env->pmsav8.hprlar, 0,
-+
++                   sizeof(*env->pmsav8.hprlar) * cpu->pmsav8r_hdregion);
-+typedef struct VersalVirt {
++        }
-+    MachineState parent_obj;
++
-+
+         env->pmsav7.rnr[M_REG_NS] = 0;
-+    Versal soc;
+         env->pmsav7.rnr[M_REG_S] = 0;
-+    MemoryRegion mr_ddr;
+         env->pmsav8.mair0[M_REG_NS] = 0;
-+
+@@ -XXX,XX +XXX,XX @@ static void arm_cpu_realizefn(DeviceState *dev, Error **errp)
-+    void *fdt;
+     /* MPU can be configured out of a PMSA CPU either by setting has-mpu
-+    int fdt_size;
+      * to false or by setting pmsav7-dregion to 0.
-+    struct {
+      */
-+        uint32_t gic;
+-    if (!cpu->has_mpu) {
-+        uint32_t ethernet_phy[2];
+-        cpu->pmsav7_dregion = 0;
-+        uint32_t clk_125Mhz;
+-    }
-+        uint32_t clk_25Mhz;
+-    if (cpu->pmsav7_dregion == 0) {
-+    } phandle;
++    if (!cpu->has_mpu || cpu->pmsav7_dregion == 0) {
-+    struct arm_boot_info binfo;
+         cpu->has_mpu = false;
-+
++        cpu->pmsav7_dregion = 0;
-+    struct {
++        cpu->pmsav8r_hdregion = 0;
-+        bool secure;
+     }
-+    } cfg;
-+} VersalVirt;
+     if (arm_feature(env, ARM_FEATURE_PMSA) &&
-+
+@@ -XXX,XX +XXX,XX @@ static void arm_cpu_realizefn(DeviceState *dev, Error **errp)
-+static void fdt_create(VersalVirt *s)
+                 env->pmsav7.dracr = g_new0(uint32_t, nr);
-+{
+             }
-+    MachineClass *mc = MACHINE_GET_CLASS(s);
+         }
-+    int i;
++
-+
++        if (cpu->pmsav8r_hdregion > 0xff) {
-+    s->fdt = create_device_tree(&s->fdt_size);
++            error_setg(errp, "PMSAv8 MPU EL2 #regions invalid %" PRIu32,
-+    if (!s->fdt) {
++                              cpu->pmsav8r_hdregion);
-+        error_report("create_device_tree() failed");
++            return;
-+        exit(1);
++        }
-+    }
++
-+
++        if (cpu->pmsav8r_hdregion) {
-+    /* Allocate all phandles.  */
++            env->pmsav8.hprbar = g_new0(uint32_t,
-+    s->phandle.gic = qemu_fdt_alloc_phandle(s->fdt);
++                                        cpu->pmsav8r_hdregion);
-+    for (i = 0; i < ARRAY_SIZE(s->phandle.ethernet_phy); i++) {
++            env->pmsav8.hprlar = g_new0(uint32_t,
-+        s->phandle.ethernet_phy[i] = qemu_fdt_alloc_phandle(s->fdt);
++                                        cpu->pmsav8r_hdregion);
-+    }
++        }
-+    s->phandle.clk_25Mhz = qemu_fdt_alloc_phandle(s->fdt);
+     }
-+    s->phandle.clk_125Mhz = qemu_fdt_alloc_phandle(s->fdt);
-+
+     if (arm_feature(env, ARM_FEATURE_M_SECURITY)) {
-+    /* Create /chosen node for load_dtb.  */
+diff --git a/target/arm/helper.c b/target/arm/helper.c
-+    qemu_fdt_add_subnode(s->fdt, "/chosen");
+index XXXXXXX..XXXXXXX 100644
-+
+--- a/target/arm/helper.c
-+    /* Header */
++++ b/target/arm/helper.c
-+    qemu_fdt_setprop_cell(s->fdt, "/", "interrupt-parent", s->phandle.gic);
+@@ -XXX,XX +XXX,XX @@ static void pmsav7_rgnr_write(CPUARMState *env, const ARMCPRegInfo *ri,
-+    qemu_fdt_setprop_cell(s->fdt, "/", "#size-cells", 0x2);
+     raw_write(env, ri, value);
-+    qemu_fdt_setprop_cell(s->fdt, "/", "#address-cells", 0x2);
+ }
-+    qemu_fdt_setprop_string(s->fdt, "/", "model", mc->desc);
-+    qemu_fdt_setprop_string(s->fdt, "/", "compatible", "xlnx-versal-virt");
++static void prbar_write(CPUARMState *env, const ARMCPRegInfo *ri,
-+}
++                          uint64_t value)
-+
++{
-+static void fdt_add_clk_node(VersalVirt *s, const char *name,
++    ARMCPU *cpu = env_archcpu(env);
-+                             unsigned int freq_hz, uint32_t phandle)
++
-+{
++    tlb_flush(CPU(cpu)); /* Mappings may have changed - purge! */
-+    qemu_fdt_add_subnode(s->fdt, name);
++    env->pmsav8.rbar[M_REG_NS][env->pmsav7.rnr[M_REG_NS]] = value;
-+    qemu_fdt_setprop_cell(s->fdt, name, "phandle", phandle);
++}
-+    qemu_fdt_setprop_cell(s->fdt, name, "clock-frequency", freq_hz);
++
-+    qemu_fdt_setprop_cell(s->fdt, name, "#clock-cells", 0x0);
++static uint64_t prbar_read(CPUARMState *env, const ARMCPRegInfo *ri)
-+    qemu_fdt_setprop_string(s->fdt, name, "compatible", "fixed-clock");
++{
-+    qemu_fdt_setprop(s->fdt, name, "u-boot,dm-pre-reloc", NULL, 0);
++    return env->pmsav8.rbar[M_REG_NS][env->pmsav7.rnr[M_REG_NS]];
 +}
 +
-+static void fdt_add_cpu_nodes(VersalVirt *s, uint32_t psci_conduit)
++static void prlar_write(CPUARMState *env, const ARMCPRegInfo *ri,
-+{
++                          uint64_t value)
-+    int i;
++{
-+
++    ARMCPU *cpu = env_archcpu(env);
-+    qemu_fdt_add_subnode(s->fdt, "/cpus");
++
-+    qemu_fdt_setprop_cell(s->fdt, "/cpus", "#size-cells", 0x0);
++    tlb_flush(CPU(cpu)); /* Mappings may have changed - purge! */
-+    qemu_fdt_setprop_cell(s->fdt, "/cpus", "#address-cells", 1);
++    env->pmsav8.rlar[M_REG_NS][env->pmsav7.rnr[M_REG_NS]] = value;
-+
++}
-+    for (i = XLNX_VERSAL_NR_ACPUS - 1; i >= 0; i--) {
++
-+        char *name = g_strdup_printf("/cpus/cpu@%d", i);
++static uint64_t prlar_read(CPUARMState *env, const ARMCPRegInfo *ri)
-+        ARMCPU *armcpu = ARM_CPU(qemu_get_cpu(i));
++{
-+
++    return env->pmsav8.rlar[M_REG_NS][env->pmsav7.rnr[M_REG_NS]];
-+        qemu_fdt_add_subnode(s->fdt, name);
++}
-+        qemu_fdt_setprop_cell(s->fdt, name, "reg", armcpu->mp_affinity);
++
-+        if (psci_conduit != QEMU_PSCI_CONDUIT_DISABLED) {
++static void prselr_write(CPUARMState *env, const ARMCPRegInfo *ri,
-+            qemu_fdt_setprop_string(s->fdt, name, "enable-method", "psci");
++                           uint64_t value)
-+        }
++{
-+        qemu_fdt_setprop_string(s->fdt, name, "device_type", "cpu");
++    ARMCPU *cpu = env_archcpu(env);
-+        qemu_fdt_setprop_string(s->fdt, name, "compatible",
++
-+                                armcpu->dtb_compatible);
++    /*
-+        g_free(name);
++     * Ignore writes that would select not implemented region.
-+    }
++     * This is architecturally UNPREDICTABLE.
-+}
++     */
-+
++    if (value >= cpu->pmsav7_dregion) {
 +static void fdt_add_gic_nodes(VersalVirt *s)
 +{
 +    char *nodename;
 +
 +    nodename = g_strdup_printf("/gic@%x", MM_GIC_APU_DIST_MAIN);
 +    qemu_fdt_add_subnode(s->fdt, nodename);
 +    qemu_fdt_setprop_cell(s->fdt, nodename, "phandle", s->phandle.gic);
 +    qemu_fdt_setprop_cells(s->fdt, nodename, "interrupts",
 +                           GIC_FDT_IRQ_TYPE_PPI, VERSAL_GIC_MAINT_IRQ,
 +                           GIC_FDT_IRQ_FLAGS_LEVEL_HI);
 +    qemu_fdt_setprop(s->fdt, nodename, "interrupt-controller", NULL, 0);
 +    qemu_fdt_setprop_sized_cells(s->fdt, nodename, "reg",
 +                                 2, MM_GIC_APU_DIST_MAIN,
 +                                 2, MM_GIC_APU_DIST_MAIN_SIZE,
 +                                 2, MM_GIC_APU_REDIST_0,
 +                                 2, MM_GIC_APU_REDIST_0_SIZE);
 +    qemu_fdt_setprop_cell(s->fdt, nodename, "#interrupt-cells", 3);
 +    qemu_fdt_setprop_string(s->fdt, nodename, "compatible", "arm,gic-v3");
 +}
 +
 +static void fdt_add_timer_nodes(VersalVirt *s)
 +{
 +    const char compat[] = "arm,armv8-timer";
 +    uint32_t irqflags = GIC_FDT_IRQ_FLAGS_LEVEL_HI;
 +
 +    qemu_fdt_add_subnode(s->fdt, "/timer");
 +    qemu_fdt_setprop_cells(s->fdt, "/timer", "interrupts",
 +            GIC_FDT_IRQ_TYPE_PPI, VERSAL_TIMER_S_EL1_IRQ, irqflags,
 +            GIC_FDT_IRQ_TYPE_PPI, VERSAL_TIMER_NS_EL1_IRQ, irqflags,
 +            GIC_FDT_IRQ_TYPE_PPI, VERSAL_TIMER_VIRT_IRQ, irqflags,
 +            GIC_FDT_IRQ_TYPE_PPI, VERSAL_TIMER_NS_EL2_IRQ, irqflags);
 +    qemu_fdt_setprop(s->fdt, "/timer", "compatible",
 +                     compat, sizeof(compat));
 +}
 +
 +static void fdt_add_uart_nodes(VersalVirt *s)
 +{
 +    uint64_t addrs[] = { MM_UART1, MM_UART0 };
 +    unsigned int irqs[] = { VERSAL_UART1_IRQ_0, VERSAL_UART0_IRQ_0 };
 +    const char compat[] = "arm,pl011\0arm,sbsa-uart";
 +    const char clocknames[] = "uartclk\0apb_pclk";
 +    int i;
 +
 +    for (i = 0; i < ARRAY_SIZE(addrs); i++) {
 +        char *name = g_strdup_printf("/uart@%" PRIx64, addrs[i]);
 +        qemu_fdt_add_subnode(s->fdt, name);
 +        qemu_fdt_setprop_cell(s->fdt, name, "current-speed", 115200);
 +        qemu_fdt_setprop_cells(s->fdt, name, "clocks",
 +                               s->phandle.clk_125Mhz, s->phandle.clk_125Mhz);
 +        qemu_fdt_setprop(s->fdt, name, "clock-names",
 +                         clocknames, sizeof(clocknames));
 +
 +        qemu_fdt_setprop_cells(s->fdt, name, "interrupts",
 +                               GIC_FDT_IRQ_TYPE_SPI, irqs[i],
 +                               GIC_FDT_IRQ_FLAGS_LEVEL_HI);
 +        qemu_fdt_setprop_sized_cells(s->fdt, name, "reg",
 +                                     2, addrs[i], 2, 0x1000);
 +        qemu_fdt_setprop(s->fdt, name, "compatible",
 +                         compat, sizeof(compat));
 +        qemu_fdt_setprop(s->fdt, name, "u-boot,dm-pre-reloc", NULL, 0);
 +
 +        if (addrs[i] == MM_UART0) {
 +            /* Select UART0.  */
 +            qemu_fdt_setprop_string(s->fdt, "/chosen", "stdout-path", name);
 +        }
 +        g_free(name);
 +    }
 +}
 +
 +static void fdt_add_fixed_link_nodes(VersalVirt *s, char *gemname,
 +                                     uint32_t phandle)
 +{
 +    char *name = g_strdup_printf("%s/fixed-link", gemname);
 +
 +    qemu_fdt_add_subnode(s->fdt, name);
 +    qemu_fdt_setprop_cell(s->fdt, name, "phandle", phandle);
 +    qemu_fdt_setprop_cells(s->fdt, name, "full-duplex");
 +    qemu_fdt_setprop_cell(s->fdt, name, "speed", 1000);
 +    g_free(name);
 +}
 +
 +static void fdt_add_gem_nodes(VersalVirt *s)
 +{
 +    uint64_t addrs[] = { MM_GEM1, MM_GEM0 };
 +    unsigned int irqs[] = { VERSAL_GEM1_IRQ_0, VERSAL_GEM0_IRQ_0 };
 +    const char clocknames[] = "pclk\0hclk\0tx_clk\0rx_clk";
 +    const char compat_gem[] = "cdns,zynqmp-gem\0cdns,gem";
 +    int i;
 +
 +    for (i = 0; i < ARRAY_SIZE(addrs); i++) {
 +        char *name = g_strdup_printf("/ethernet@%" PRIx64, addrs[i]);
 +        qemu_fdt_add_subnode(s->fdt, name);
 +
 +        fdt_add_fixed_link_nodes(s, name, s->phandle.ethernet_phy[i]);
 +        qemu_fdt_setprop_string(s->fdt, name, "phy-mode", "rgmii-id");
 +        qemu_fdt_setprop_cell(s->fdt, name, "phy-handle",
 +                              s->phandle.ethernet_phy[i]);
 +        qemu_fdt_setprop_cells(s->fdt, name, "clocks",
 +                               s->phandle.clk_25Mhz, s->phandle.clk_25Mhz,
 +                               s->phandle.clk_25Mhz, s->phandle.clk_25Mhz);
 +        qemu_fdt_setprop(s->fdt, name, "clock-names",
 +                         clocknames, sizeof(clocknames));
 +        qemu_fdt_setprop_cells(s->fdt, name, "interrupts",
 +                               GIC_FDT_IRQ_TYPE_SPI, irqs[i],
 +                               GIC_FDT_IRQ_FLAGS_LEVEL_HI,
 +                               GIC_FDT_IRQ_TYPE_SPI, irqs[i],
 +                               GIC_FDT_IRQ_FLAGS_LEVEL_HI);
 +        qemu_fdt_setprop_sized_cells(s->fdt, name, "reg",
 +                                     2, addrs[i], 2, 0x1000);
 +        qemu_fdt_setprop(s->fdt, name, "compatible",
 +                         compat_gem, sizeof(compat_gem));
 +        qemu_fdt_setprop_cell(s->fdt, name, "#address-cells", 1);
 +        qemu_fdt_setprop_cell(s->fdt, name, "#size-cells", 0);
 +        g_free(name);
 +    }
 +}
 +
 +static void fdt_nop_memory_nodes(void *fdt, Error **errp)
 +{
 +    Error *err = NULL;
 +    char **node_path;
 +    int n = 0;
 +
 +    node_path = qemu_fdt_node_unit_path(fdt, "memory", &err);
 +    if (err) {
 +        error_propagate(errp, err);
 +        return;
 +    }
-+    while (node_path[n]) {
++
-+        if (g_str_has_prefix(node_path[n], "/memory")) {
++    env->pmsav7.rnr[M_REG_NS] = value;
-+            qemu_fdt_nop_node(fdt, node_path[n]);
++}
-+        }
++
-+        n++;
++static void hprbar_write(CPUARMState *env, const ARMCPRegInfo *ri,
-+    }
++                          uint64_t value)
-+    g_strfreev(node_path);
++{
-+}
++    ARMCPU *cpu = env_archcpu(env);
 +
-+static void fdt_add_memory_nodes(VersalVirt *s, void *fdt, uint64_t ram_size)
++    tlb_flush(CPU(cpu)); /* Mappings may have changed - purge! */
-+{
++    env->pmsav8.hprbar[env->pmsav8.hprselr] = value;
-+    /* Describes the various split DDR access regions.  */
++}
-+    static const struct {
++
-+        uint64_t base;
++static uint64_t hprbar_read(CPUARMState *env, const ARMCPRegInfo *ri)
-+        uint64_t size;
++{
-+    } addr_ranges[] = {
++    return env->pmsav8.hprbar[env->pmsav8.hprselr];
-+        { MM_TOP_DDR, MM_TOP_DDR_SIZE },
++}
-+        { MM_TOP_DDR_2, MM_TOP_DDR_2_SIZE },
++
-+        { MM_TOP_DDR_3, MM_TOP_DDR_3_SIZE },
++static void hprlar_write(CPUARMState *env, const ARMCPRegInfo *ri,
-+        { MM_TOP_DDR_4, MM_TOP_DDR_4_SIZE }
++                          uint64_t value)
-+    };
++{
-+    uint64_t mem_reg_prop[8] = {0};
++    ARMCPU *cpu = env_archcpu(env);
-+    uint64_t size = ram_size;
++
-+    Error *err = NULL;
++    tlb_flush(CPU(cpu)); /* Mappings may have changed - purge! */
-+    char *name;
++    env->pmsav8.hprlar[env->pmsav8.hprselr] = value;
-+    int i;
++}
 +
-+    fdt_nop_memory_nodes(fdt, &err);
++static uint64_t hprlar_read(CPUARMState *env, const ARMCPRegInfo *ri)
-+    if (err) {
++{
-+        error_report_err(err);
++    return env->pmsav8.hprlar[env->pmsav8.hprselr];
 +}
 +
 +static void hprenr_write(CPUARMState *env, const ARMCPRegInfo *ri,
 +                          uint64_t value)
 +{
 +    uint32_t n;
 +    uint32_t bit;
 +    ARMCPU *cpu = env_archcpu(env);
 +
 +    /* Ignore writes to unimplemented regions */
 +    int rmax = MIN(cpu->pmsav8r_hdregion, 32);
 +    value &= MAKE_64BIT_MASK(0, rmax);
 +
 +    tlb_flush(CPU(cpu)); /* Mappings may have changed - purge! */
 +
 +    /* Register alias is only valid for first 32 indexes */
 +    for (n = 0; n < rmax; ++n) {
 +        bit = extract32(value, n, 1);
 +        env->pmsav8.hprlar[n] = deposit32(
 +                    env->pmsav8.hprlar[n], 0, 1, bit);
 +    }
 +}
 +
 +static uint64_t hprenr_read(CPUARMState *env, const ARMCPRegInfo *ri)
 +{
 +    uint32_t n;
 +    uint32_t result = 0x0;
 +    ARMCPU *cpu = env_archcpu(env);
 +
 +    /* Register alias is only valid for first 32 indexes */
 +    for (n = 0; n < MIN(cpu->pmsav8r_hdregion, 32); ++n) {
 +        if (env->pmsav8.hprlar[n] & 0x1) {
 +            result |= (0x1 << n);
 +        }
 +    }
 +    return result;
 +}
 +
 +static void hprselr_write(CPUARMState *env, const ARMCPRegInfo *ri,
 +                           uint64_t value)
 +{
 +    ARMCPU *cpu = env_archcpu(env);
 +
 +    /*
 +     * Ignore writes that would select not implemented region.
 +     * This is architecturally UNPREDICTABLE.
 +     */
 +    if (value >= cpu->pmsav8r_hdregion) {
 +        return;
 +    }
 +
-+    name = g_strdup_printf("/memory@%x", MM_TOP_DDR);
++    env->pmsav8.hprselr = value;
-+    for (i = 0; i < ARRAY_SIZE(addr_ranges) && size; i++) {
++}
-+        uint64_t mapsize;
++
-+
++static void pmsav8r_regn_write(CPUARMState *env, const ARMCPRegInfo *ri,
-+        mapsize = size < addr_ranges[i].size ? size : addr_ranges[i].size;
++                          uint64_t value)
-+
++{
-+        mem_reg_prop[i * 2] = addr_ranges[i].base;
++    ARMCPU *cpu = env_archcpu(env);
-+        mem_reg_prop[i * 2 + 1] = mapsize;
++    uint8_t index = (extract32(ri->opc0, 0, 1) << 4) |
-+        size -= mapsize;
++                    (extract32(ri->crm, 0, 3) << 1) | extract32(ri->opc2, 2, 1);
-+    }
++
-+    qemu_fdt_add_subnode(fdt, name);
++    tlb_flush(CPU(cpu)); /* Mappings may have changed - purge! */
-+    qemu_fdt_setprop_string(fdt, name, "device_type", "memory");
++
-+
++    if (ri->opc1 & 4) {
-+    switch (i) {
++        if (index >= cpu->pmsav8r_hdregion) {
-+    case 1:
++            return;
-+        qemu_fdt_setprop_sized_cells(fdt, name, "reg",
++        }
-+                                     2, mem_reg_prop[0],
++        if (ri->opc2 & 0x1) {
-+                                     2, mem_reg_prop[1]);
++            env->pmsav8.hprlar[index] = value;
-+        break;
++        } else {
-+    case 2:
++            env->pmsav8.hprbar[index] = value;
-+        qemu_fdt_setprop_sized_cells(fdt, name, "reg",
++        }
 +                                     2, mem_reg_prop[0],
 +                                     2, mem_reg_prop[1],
 +                                     2, mem_reg_prop[2],
 +                                     2, mem_reg_prop[3]);
 +        break;
 +    case 3:
 +        qemu_fdt_setprop_sized_cells(fdt, name, "reg",
 +                                     2, mem_reg_prop[0],
 +                                     2, mem_reg_prop[1],
 +                                     2, mem_reg_prop[2],
 +                                     2, mem_reg_prop[3],
 +                                     2, mem_reg_prop[4],
 +                                     2, mem_reg_prop[5]);
 +        break;
 +    case 4:
 +        qemu_fdt_setprop_sized_cells(fdt, name, "reg",
 +                                     2, mem_reg_prop[0],
 +                                     2, mem_reg_prop[1],
 +                                     2, mem_reg_prop[2],
 +                                     2, mem_reg_prop[3],
 +                                     2, mem_reg_prop[4],
 +                                     2, mem_reg_prop[5],
 +                                     2, mem_reg_prop[6],
 +                                     2, mem_reg_prop[7]);
 +        break;
 +    default:
 +        g_assert_not_reached();
 +    }
 +    g_free(name);
 +}
 +
 +static void versal_virt_modify_dtb(const struct arm_boot_info *binfo,
 +                                    void *fdt)
 +{
 +    VersalVirt *s = container_of(binfo, VersalVirt, binfo);
 +
 +    fdt_add_memory_nodes(s, fdt, binfo->ram_size);
 +}
 +
 +static void *versal_virt_get_dtb(const struct arm_boot_info *binfo,
 +                                  int *fdt_size)
 +{
 +    const VersalVirt *board = container_of(binfo, VersalVirt, binfo);
 +
 +    *fdt_size = board->fdt_size;
 +    return board->fdt;
 +}
 +
 +#define NUM_VIRTIO_TRANSPORT 32
 +static void create_virtio_regions(VersalVirt *s)
 +{
 +    int virtio_mmio_size = 0x200;
 +    int i;
 +
 +    for (i = 0; i < NUM_VIRTIO_TRANSPORT; i++) {
 +        char *name = g_strdup_printf("virtio%d", i);;
 +        hwaddr base = MM_TOP_RSVD + i * virtio_mmio_size;
 +        int irq = VERSAL_RSVD_HIGH_IRQ_FIRST + i;
 +        MemoryRegion *mr;
 +        DeviceState *dev;
 +        qemu_irq pic_irq;
 +
 +        pic_irq = qdev_get_gpio_in(DEVICE(&s->soc.fpd.apu.gic), irq);
 +        dev = qdev_create(NULL, "virtio-mmio");
 +        object_property_add_child(OBJECT(&s->soc), name, OBJECT(dev),
 +                                  &error_fatal);
 +        qdev_init_nofail(dev);
 +        sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, pic_irq);
 +        mr = sysbus_mmio_get_region(SYS_BUS_DEVICE(dev), 0);
 +        memory_region_add_subregion(&s->soc.mr_ps, base, mr);
 +        sysbus_create_simple("virtio-mmio", base, pic_irq);
 +    }
 +
 +    for (i = 0; i < NUM_VIRTIO_TRANSPORT; i++) {
 +        hwaddr base = MM_TOP_RSVD + i * virtio_mmio_size;
 +        int irq = VERSAL_RSVD_HIGH_IRQ_FIRST + i;
 +        char *name = g_strdup_printf("/virtio_mmio@%" PRIx64, base);
 +
 +        qemu_fdt_add_subnode(s->fdt, name);
 +        qemu_fdt_setprop(s->fdt, name, "dma-coherent", NULL, 0);
 +        qemu_fdt_setprop_cells(s->fdt, name, "interrupts",
 +                               GIC_FDT_IRQ_TYPE_SPI, irq,
 +                               GIC_FDT_IRQ_FLAGS_EDGE_LO_HI);
 +        qemu_fdt_setprop_sized_cells(s->fdt, name, "reg",
 +                                     2, base, 2, virtio_mmio_size);
 +        qemu_fdt_setprop_string(s->fdt, name, "compatible", "virtio,mmio");
 +        g_free(name);
 +    }
 +}
 +
 +static void versal_virt_init(MachineState *machine)
 +{
 +    VersalVirt *s = XLNX_VERSAL_VIRT_MACHINE(machine);
 +    int psci_conduit = QEMU_PSCI_CONDUIT_DISABLED;
 +
 +    /*
 +     * If the user provides an Operating System to be loaded, we expect them
 +     * to use the -kernel command line option.
 +     *
 +     * Users can load firmware or boot-loaders with the -device loader options.
 +     *
 +     * When loading an OS, we generate a dtb and let arm_load_kernel() select
 +     * where it gets loaded. This dtb will be passed to the kernel in x0.
 +     *
 +     * If there's no -kernel option, we generate a DTB and place it at 0x1000
 +     * for the bootloaders or firmware to pick up.
 +     *
 +     * If users want to provide their own DTB, they can use the -dtb option.
 +     * These dtb's will have their memory nodes modified to match QEMU's
 +     * selected ram_size option before they get passed to the kernel or fw.
 +     *
 +     * When loading an OS, we turn on QEMU's PSCI implementation with SMC
 +     * as the PSCI conduit. When there's no -kernel, we assume the user
 +     * provides EL3 firmware to handle PSCI.
 +     */
 +    if (machine->kernel_filename) {
 +        psci_conduit = QEMU_PSCI_CONDUIT_SMC;
 +    }
 +
 +    memory_region_allocate_system_memory(&s->mr_ddr, NULL, "ddr",
 +                                         machine->ram_size);
 +
 +    sysbus_init_child_obj(OBJECT(machine), "xlnx-ve", &s->soc,
 +                          sizeof(s->soc), TYPE_XLNX_VERSAL);
 +    object_property_set_link(OBJECT(&s->soc), OBJECT(&s->mr_ddr),
 +                             "ddr", &error_abort);
 +    object_property_set_int(OBJECT(&s->soc), psci_conduit,
 +                            "psci-conduit", &error_abort);
 +    object_property_set_bool(OBJECT(&s->soc), true, "realized", &error_fatal);
 +
 +    fdt_create(s);
 +    create_virtio_regions(s);
 +    fdt_add_gem_nodes(s);
 +    fdt_add_uart_nodes(s);
 +    fdt_add_gic_nodes(s);
 +    fdt_add_timer_nodes(s);
 +    fdt_add_cpu_nodes(s, psci_conduit);
 +    fdt_add_clk_node(s, "/clk125", 125000000, s->phandle.clk_125Mhz);
 +    fdt_add_clk_node(s, "/clk25", 25000000, s->phandle.clk_25Mhz);
 +
 +    /* Make the APU cpu address space visible to virtio and other
 +     * modules unaware of muliple address-spaces.  */
 +    memory_region_add_subregion_overlap(get_system_memory(),
 +                                        0, &s->soc.fpd.apu.mr, 0);
 +
 +    s->binfo.ram_size = machine->ram_size;
 +    s->binfo.kernel_filename = machine->kernel_filename;
 +    s->binfo.kernel_cmdline = machine->kernel_cmdline;
 +    s->binfo.initrd_filename = machine->initrd_filename;
 +    s->binfo.loader_start = 0x0;
 +    s->binfo.get_dtb = versal_virt_get_dtb;
 +    s->binfo.modify_dtb = versal_virt_modify_dtb;
 +    if (machine->kernel_filename) {
 +        arm_load_kernel(s->soc.fpd.apu.cpu[0], &s->binfo);
 +    } else {
-+        AddressSpace *as = arm_boot_address_space(s->soc.fpd.apu.cpu[0],
++        if (index >= cpu->pmsav7_dregion) {
-+                                                  &s->binfo);
++            return;
-+        /* Some boot-loaders (e.g u-boot) don't like blobs at address 0 (NULL).
++        }
-+         * Offset things by 4K.  */
++        if (ri->opc2 & 0x1) {
-+        s->binfo.loader_start = 0x1000;
++            env->pmsav8.rlar[M_REG_NS][index] = value;
-+        s->binfo.dtb_limit = 0x1000000;
++        } else {
-+        if (arm_load_dtb(s->binfo.loader_start,
++            env->pmsav8.rbar[M_REG_NS][index] = value;
-+                         &s->binfo, s->binfo.dtb_limit, as) < 0) {
++        }
-+            exit(EXIT_FAILURE);
++    }
-+        }
++}
-+    }
++
-+}
++static uint64_t pmsav8r_regn_read(CPUARMState *env, const ARMCPRegInfo *ri)
-+
++{
-+static void versal_virt_machine_instance_init(Object *obj)
++    ARMCPU *cpu = env_archcpu(env);
-+{
++    uint8_t index = (extract32(ri->opc0, 0, 1) << 4) |
-+}
++                    (extract32(ri->crm, 0, 3) << 1) | extract32(ri->opc2, 2, 1);
 +
-+static void versal_virt_machine_class_init(ObjectClass *oc, void *data)
++    if (ri->opc1 & 4) {
-+{
++        if (index >= cpu->pmsav8r_hdregion) {
-+    MachineClass *mc = MACHINE_CLASS(oc);
++            return 0x0;
-+
++        }
-+    mc->desc = "Xilinx Versal Virtual development board";
++        if (ri->opc2 & 0x1) {
-+    mc->init = versal_virt_init;
++            return env->pmsav8.hprlar[index];
-+    mc->max_cpus = XLNX_VERSAL_NR_ACPUS;
++        } else {
-+    mc->default_cpus = XLNX_VERSAL_NR_ACPUS;
++            return env->pmsav8.hprbar[index];
-+    mc->no_cdrom = true;
++        }
-+}
++    } else {
-+
++        if (index >= cpu->pmsav7_dregion) {
-+static const TypeInfo versal_virt_machine_init_typeinfo = {
++            return 0x0;
-+    .name       = TYPE_XLNX_VERSAL_VIRT_MACHINE,
++        }
-+    .parent     = TYPE_MACHINE,
++        if (ri->opc2 & 0x1) {
-+    .class_init = versal_virt_machine_class_init,
++            return env->pmsav8.rlar[M_REG_NS][index];
-+    .instance_init = versal_virt_machine_instance_init,
++        } else {
-+    .instance_size = sizeof(VersalVirt),
++            return env->pmsav8.rbar[M_REG_NS][index];
 +        }
 +    }
 +}
 +
 +static const ARMCPRegInfo pmsav8r_cp_reginfo[] = {
 +    { .name = "PRBAR",
 +      .cp = 15, .opc1 = 0, .crn = 6, .crm = 3, .opc2 = 0,
 +      .access = PL1_RW, .type = ARM_CP_NO_RAW,
 +      .accessfn = access_tvm_trvm,
 +      .readfn = prbar_read, .writefn = prbar_write },
 +    { .name = "PRLAR",
 +      .cp = 15, .opc1 = 0, .crn = 6, .crm = 3, .opc2 = 1,
 +      .access = PL1_RW, .type = ARM_CP_NO_RAW,
 +      .accessfn = access_tvm_trvm,
 +      .readfn = prlar_read, .writefn = prlar_write },
 +    { .name = "PRSELR", .resetvalue = 0,
 +      .cp = 15, .opc1 = 0, .crn = 6, .crm = 2, .opc2 = 1,
 +      .access = PL1_RW, .accessfn = access_tvm_trvm,
 +      .writefn = prselr_write,
 +      .fieldoffset = offsetof(CPUARMState, pmsav7.rnr[M_REG_NS]) },
 +    { .name = "HPRBAR", .resetvalue = 0,
 +      .cp = 15, .opc1 = 4, .crn = 6, .crm = 3, .opc2 = 0,
 +      .access = PL2_RW, .type = ARM_CP_NO_RAW,
 +      .readfn = hprbar_read, .writefn = hprbar_write },
 +    { .name = "HPRLAR",
 +      .cp = 15, .opc1 = 4, .crn = 6, .crm = 3, .opc2 = 1,
 +      .access = PL2_RW, .type = ARM_CP_NO_RAW,
 +      .readfn = hprlar_read, .writefn = hprlar_write },
 +    { .name = "HPRSELR", .resetvalue = 0,
 +      .cp = 15, .opc1 = 4, .crn = 6, .crm = 2, .opc2 = 1,
 +      .access = PL2_RW,
 +      .writefn = hprselr_write,
 +      .fieldoffset = offsetof(CPUARMState, pmsav8.hprselr) },
 +    { .name = "HPRENR",
 +      .cp = 15, .opc1 = 4, .crn = 6, .crm = 1, .opc2 = 1,
 +      .access = PL2_RW, .type = ARM_CP_NO_RAW,
 +      .readfn = hprenr_read, .writefn = hprenr_write },
 +};
 +
-+static void versal_virt_machine_init_register_types(void)
+ static const ARMCPRegInfo pmsav7_cp_reginfo[] = {
-+{
+     /* Reset for all these registers is handled in arm_cpu_reset(),
-+    type_register_static(&versal_virt_machine_init_typeinfo);
+      * because the PMSAv7 is also used by M-profile CPUs, which do
-+}
+@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
-+
+               .access = PL1_R, .type = ARM_CP_CONST,
-+type_init(versal_virt_machine_init_register_types)
+               .resetvalue = cpu->pmsav7_dregion << 8
          };
 +        /* HMPUIR is specific to PMSA V8 */
 +        ARMCPRegInfo id_hmpuir_reginfo = {
 +            .name = "HMPUIR",
 +            .cp = 15, .opc1 = 4, .crn = 0, .crm = 0, .opc2 = 4,
 +            .access = PL2_R, .type = ARM_CP_CONST,
 +            .resetvalue = cpu->pmsav8r_hdregion
 +        };
          static const ARMCPRegInfo crn0_wi_reginfo = {
              .name = "CRN0_WI", .cp = 15, .crn = 0, .crm = CP_ANY,
              .opc1 = CP_ANY, .opc2 = CP_ANY, .access = PL1_W,
@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
          define_arm_cp_regs(cpu, id_cp_reginfo);
          if (!arm_feature(env, ARM_FEATURE_PMSA)) {
              define_one_arm_cp_reg(cpu, &id_tlbtr_reginfo);
 +        } else if (arm_feature(env, ARM_FEATURE_PMSA) &&
 +                   arm_feature(env, ARM_FEATURE_V8)) {
 +            uint32_t i = 0;
 +            char *tmp_string;
 +
 +            define_one_arm_cp_reg(cpu, &id_mpuir_reginfo);
 +            define_one_arm_cp_reg(cpu, &id_hmpuir_reginfo);
 +            define_arm_cp_regs(cpu, pmsav8r_cp_reginfo);
 +
 +            /* Register alias is only valid for first 32 indexes */
 +            for (i = 0; i < MIN(cpu->pmsav7_dregion, 32); ++i) {
 +                uint8_t crm = 0b1000 | extract32(i, 1, 3);
 +                uint8_t opc1 = extract32(i, 4, 1);
 +                uint8_t opc2 = extract32(i, 0, 1) << 2;
 +
 +                tmp_string = g_strdup_printf("PRBAR%u", i);
 +                ARMCPRegInfo tmp_prbarn_reginfo = {
 +                    .name = tmp_string, .type = ARM_CP_ALIAS | ARM_CP_NO_RAW,
 +                    .cp = 15, .opc1 = opc1, .crn = 6, .crm = crm, .opc2 = opc2,
 +                    .access = PL1_RW, .resetvalue = 0,
 +                    .accessfn = access_tvm_trvm,
 +                    .writefn = pmsav8r_regn_write, .readfn = pmsav8r_regn_read
 +                };
 +                define_one_arm_cp_reg(cpu, &tmp_prbarn_reginfo);
 +                g_free(tmp_string);
 +
 +                opc2 = extract32(i, 0, 1) << 2 | 0x1;
 +                tmp_string = g_strdup_printf("PRLAR%u", i);
 +                ARMCPRegInfo tmp_prlarn_reginfo = {
 +                    .name = tmp_string, .type = ARM_CP_ALIAS | ARM_CP_NO_RAW,
 +                    .cp = 15, .opc1 = opc1, .crn = 6, .crm = crm, .opc2 = opc2,
 +                    .access = PL1_RW, .resetvalue = 0,
 +                    .accessfn = access_tvm_trvm,
 +                    .writefn = pmsav8r_regn_write, .readfn = pmsav8r_regn_read
 +                };
 +                define_one_arm_cp_reg(cpu, &tmp_prlarn_reginfo);
 +                g_free(tmp_string);
 +            }
 +
 +            /* Register alias is only valid for first 32 indexes */
 +            for (i = 0; i < MIN(cpu->pmsav8r_hdregion, 32); ++i) {
 +                uint8_t crm = 0b1000 | extract32(i, 1, 3);
 +                uint8_t opc1 = 0b100 | extract32(i, 4, 1);
 +                uint8_t opc2 = extract32(i, 0, 1) << 2;
 +
 +                tmp_string = g_strdup_printf("HPRBAR%u", i);
 +                ARMCPRegInfo tmp_hprbarn_reginfo = {
 +                    .name = tmp_string,
 +                    .type = ARM_CP_NO_RAW,
 +                    .cp = 15, .opc1 = opc1, .crn = 6, .crm = crm, .opc2 = opc2,
 +                    .access = PL2_RW, .resetvalue = 0,
 +                    .writefn = pmsav8r_regn_write, .readfn = pmsav8r_regn_read
 +                };
 +                define_one_arm_cp_reg(cpu, &tmp_hprbarn_reginfo);
 +                g_free(tmp_string);
 +
 +                opc2 = extract32(i, 0, 1) << 2 | 0x1;
 +                tmp_string = g_strdup_printf("HPRLAR%u", i);
 +                ARMCPRegInfo tmp_hprlarn_reginfo = {
 +                    .name = tmp_string,
 +                    .type = ARM_CP_NO_RAW,
 +                    .cp = 15, .opc1 = opc1, .crn = 6, .crm = crm, .opc2 = opc2,
 +                    .access = PL2_RW, .resetvalue = 0,
 +                    .writefn = pmsav8r_regn_write, .readfn = pmsav8r_regn_read
 +                };
 +                define_one_arm_cp_reg(cpu, &tmp_hprlarn_reginfo);
 +                g_free(tmp_string);
 +            }
          } else if (arm_feature(env, ARM_FEATURE_V7)) {
              define_one_arm_cp_reg(cpu, &id_mpuir_reginfo);
          }
@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
              sctlr.type |= ARM_CP_SUPPRESS_TB_END;
          }
          define_one_arm_cp_reg(cpu, &sctlr);
 +
 +        if (arm_feature(env, ARM_FEATURE_PMSA) &&
 +            arm_feature(env, ARM_FEATURE_V8)) {
 +            ARMCPRegInfo vsctlr = {
 +                .name = "VSCTLR", .state = ARM_CP_STATE_AA32,
 +                .cp = 15, .opc1 = 4, .crn = 2, .crm = 0, .opc2 = 0,
 +                .access = PL2_RW, .resetvalue = 0x0,
 +                .fieldoffset = offsetoflow32(CPUARMState, cp15.vsctlr),
 +            };
 +            define_one_arm_cp_reg(cpu, &vsctlr);
 +        }
      }
      if (cpu_isar_feature(aa64_lor, cpu)) {
 diff --git a/target/arm/machine.c b/target/arm/machine.c
 index XXXXXXX..XXXXXXX 100644
 --- a/target/arm/machine.c
 +++ b/target/arm/machine.c
@@ -XXX,XX +XXX,XX @@ static bool pmsav8_needed(void *opaque)
          arm_feature(env, ARM_FEATURE_V8);
  }
 +static bool pmsav8r_needed(void *opaque)
 +{
 +    ARMCPU *cpu = opaque;
 +    CPUARMState *env = &cpu->env;
 +
 +    return arm_feature(env, ARM_FEATURE_PMSA) &&
 +        arm_feature(env, ARM_FEATURE_V8) &&
 +        !arm_feature(env, ARM_FEATURE_M);
 +}
 +
 +static const VMStateDescription vmstate_pmsav8r = {
 +    .name = "cpu/pmsav8/pmsav8r",
 +    .version_id = 1,
 +    .minimum_version_id = 1,
 +    .needed = pmsav8r_needed,
 +    .fields = (VMStateField[]) {
 +        VMSTATE_VARRAY_UINT32(env.pmsav8.hprbar, ARMCPU,
 +                        pmsav8r_hdregion, 0, vmstate_info_uint32, uint32_t),
 +        VMSTATE_VARRAY_UINT32(env.pmsav8.hprlar, ARMCPU,
 +                        pmsav8r_hdregion, 0, vmstate_info_uint32, uint32_t),
 +        VMSTATE_END_OF_LIST()
 +    },
 +};
 +
  static const VMStateDescription vmstate_pmsav8 = {
      .name = "cpu/pmsav8",
      .version_id = 1,
@@ -XXX,XX +XXX,XX @@ static const VMStateDescription vmstate_pmsav8 = {
          VMSTATE_UINT32(env.pmsav8.mair0[M_REG_NS], ARMCPU),
          VMSTATE_UINT32(env.pmsav8.mair1[M_REG_NS], ARMCPU),
          VMSTATE_END_OF_LIST()
 +    },
 +    .subsections = (const VMStateDescription * []) {
 +        &vmstate_pmsav8r,
 +        NULL
      }
  };
 --
-.19.1
+.25.1

-[Qemu-devel] [PULL 2/6] hw/arm: versal: Add a model of Xilinx Versal SoC
+[PULL 07/34] target/arm: Add PMSAv8r functionality
-From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
+From: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>
-Add a model of Xilinx Versal SoC.
+Add PMSAv8r translation.
-Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
+Signed-off-by: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>
 Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
+Message-id: 20221206102504.165775-7-tobias.roehmel@rwth-aachen.de
 Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
 ---
- hw/arm/Makefile.objs                |   1 +
+ target/arm/ptw.c | 126 ++++++++++++++++++++++++++++++++++++++---------
- include/hw/arm/xlnx-versal.h        | 122 +++++++++++
+file changed, 104 insertions(+), 22 deletions(-)
- hw/arm/xlnx-versal.c                | 323 ++++++++++++++++++++++++++++
- default-configs/aarch64-softmmu.mak |   1 +
+diff --git a/target/arm/ptw.c b/target/arm/ptw.c
 files changed, 447 insertions(+)
  create mode 100644 include/hw/arm/xlnx-versal.h
  create mode 100644 hw/arm/xlnx-versal.c
 diff --git a/hw/arm/Makefile.objs b/hw/arm/Makefile.objs
 index XXXXXXX..XXXXXXX 100644
---- a/hw/arm/Makefile.objs
+--- a/target/arm/ptw.c
-+++ b/hw/arm/Makefile.objs
++++ b/target/arm/ptw.c
-@@ -XXX,XX +XXX,XX @@ obj-$(CONFIG_ALLWINNER_A10) += allwinner-a10.o cubieboard.o
+@@ -XXX,XX +XXX,XX @@ static bool pmsav7_use_background_region(ARMCPU *cpu, ARMMMUIdx mmu_idx,
- obj-$(CONFIG_RASPI) += bcm2835_peripherals.o bcm2836.o raspi.o
- obj-$(CONFIG_STM32F205_SOC) += stm32f205_soc.o
+     if (arm_feature(env, ARM_FEATURE_M)) {
- obj-$(CONFIG_XLNX_ZYNQMP_ARM) += xlnx-zynqmp.o xlnx-zcu102.o
+         return env->v7m.mpu_ctrl[is_secure] & R_V7M_MPU_CTRL_PRIVDEFENA_MASK;
-+obj-$(CONFIG_XLNX_VERSAL) += xlnx-versal.o
+-    } else {
- obj-$(CONFIG_FSL_IMX25) += fsl-imx25.o imx25_pdk.o
+-        return regime_sctlr(env, mmu_idx) & SCTLR_BR;
- obj-$(CONFIG_FSL_IMX31) += fsl-imx31.o kzm.o
+     }
- obj-$(CONFIG_FSL_IMX6) += fsl-imx6.o sabrelite.o
++
-diff --git a/include/hw/arm/xlnx-versal.h b/include/hw/arm/xlnx-versal.h
++    if (mmu_idx == ARMMMUIdx_Stage2) {
-new file mode 100644
++        return false;
-index XXXXXXX..XXXXXXX
++    }
---- /dev/null
++
-+++ b/include/hw/arm/xlnx-versal.h
++    return regime_sctlr(env, mmu_idx) & SCTLR_BR;
-@@ -XXX,XX +XXX,XX @@
+ }
-+/*
-+ * Model of the Xilinx Versal
+ static bool get_phys_addr_pmsav7(CPUARMState *env, uint32_t address,
-+ *
+@@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_pmsav7(CPUARMState *env, uint32_t address,
-+ * Copyright (c) 2018 Xilinx Inc.
+     return !(result->f.prot & (1 << access_type));
-+ * Written by Edgar E. Iglesias
+ }
-+ *
-+ * This program is free software; you can redistribute it and/or modify
++static uint32_t *regime_rbar(CPUARMState *env, ARMMMUIdx mmu_idx,
-+ * it under the terms of the GNU General Public License version 2 or
++                             uint32_t secure)
 + * (at your option) any later version.
 + */
 +
 +#ifndef XLNX_VERSAL_H
 +#define XLNX_VERSAL_H
 +
 +#include "hw/sysbus.h"
 +#include "hw/arm/arm.h"
 +#include "hw/intc/arm_gicv3.h"
 +
 +#define TYPE_XLNX_VERSAL "xlnx-versal"
 +#define XLNX_VERSAL(obj) OBJECT_CHECK(Versal, (obj), TYPE_XLNX_VERSAL)
 +
 +#define XLNX_VERSAL_NR_ACPUS   2
 +#define XLNX_VERSAL_NR_UARTS   2
 +#define XLNX_VERSAL_NR_GEMS    2
 +#define XLNX_VERSAL_NR_IRQS    256
 +
 +typedef struct Versal {
 +    /*< private >*/
 +    SysBusDevice parent_obj;
 +
 +    /*< public >*/
 +    struct {
 +        struct {
 +            MemoryRegion mr;
 +            ARMCPU *cpu[XLNX_VERSAL_NR_ACPUS];
 +            GICv3State gic;
 +        } apu;
 +    } fpd;
 +
 +    MemoryRegion mr_ps;
 +
 +    struct {
 +        /* 4 ranges to access DDR.  */
 +        MemoryRegion mr_ddr_ranges[4];
 +    } noc;
 +
 +    struct {
 +        MemoryRegion mr_ocm;
 +
 +        struct {
 +            SysBusDevice *uart[XLNX_VERSAL_NR_UARTS];
 +            SysBusDevice *gem[XLNX_VERSAL_NR_GEMS];
 +        } iou;
 +    } lpd;
 +
 +    struct {
 +        MemoryRegion *mr_ddr;
 +        uint32_t psci_conduit;
 +    } cfg;
 +} Versal;
 +
 +/* Memory-map and IRQ definitions. Copied a subset from
 + * auto-generated files.  */
 +
 +#define VERSAL_GIC_MAINT_IRQ        9
 +#define VERSAL_TIMER_VIRT_IRQ       11
 +#define VERSAL_TIMER_S_EL1_IRQ      13
 +#define VERSAL_TIMER_NS_EL1_IRQ     14
 +#define VERSAL_TIMER_NS_EL2_IRQ     10
 +
 +#define VERSAL_UART0_IRQ_0         18
 +#define VERSAL_UART1_IRQ_0         19
 +#define VERSAL_GEM0_IRQ_0          56
 +#define VERSAL_GEM0_WAKE_IRQ_0     57
 +#define VERSAL_GEM1_IRQ_0          58
 +#define VERSAL_GEM1_WAKE_IRQ_0     59
 +
 +/* Architecturally eserved IRQs suitable for virtualization.  */
 +#define VERSAL_RSVD_HIGH_IRQ_FIRST 160
 +#define VERSAL_RSVD_HIGH_IRQ_LAST  255
 +
 +#define MM_TOP_RSVD                 0xa0000000U
 +#define MM_TOP_RSVD_SIZE            0x4000000
 +#define MM_GIC_APU_DIST_MAIN        0xf9000000U
 +#define MM_GIC_APU_DIST_MAIN_SIZE   0x10000
 +#define MM_GIC_APU_REDIST_0         0xf9080000U
 +#define MM_GIC_APU_REDIST_0_SIZE    0x80000
 +
 +#define MM_UART0                    0xff000000U
 +#define MM_UART0_SIZE               0x10000
 +#define MM_UART1                    0xff010000U
 +#define MM_UART1_SIZE               0x10000
 +
 +#define MM_GEM0                     0xff0c0000U
 +#define MM_GEM0_SIZE                0x10000
 +#define MM_GEM1                     0xff0d0000U
 +#define MM_GEM1_SIZE                0x10000
 +
 +#define MM_OCM                      0xfffc0000U
 +#define MM_OCM_SIZE                 0x40000
 +
 +#define MM_TOP_DDR                  0x0
 +#define MM_TOP_DDR_SIZE             0x80000000U
 +#define MM_TOP_DDR_2                0x800000000ULL
 +#define MM_TOP_DDR_2_SIZE           0x800000000ULL
 +#define MM_TOP_DDR_3                0xc000000000ULL
 +#define MM_TOP_DDR_3_SIZE           0x4000000000ULL
 +#define MM_TOP_DDR_4                0x10000000000ULL
 +#define MM_TOP_DDR_4_SIZE           0xb780000000ULL
 +
 +#define MM_PSM_START                0xffc80000U
 +#define MM_PSM_END                  0xffcf0000U
 +
 +#define MM_CRL                      0xff5e0000U
 +#define MM_CRL_SIZE                 0x300000
 +#define MM_IOU_SCNTR                0xff130000U
 +#define MM_IOU_SCNTR_SIZE           0x10000
 +#define MM_IOU_SCNTRS               0xff140000U
 +#define MM_IOU_SCNTRS_SIZE          0x10000
 +#define MM_FPD_CRF                  0xfd1a0000U
 +#define MM_FPD_CRF_SIZE             0x140000
 +#endif
 diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c
 new file mode 100644
 index XXXXXXX..XXXXXXX
 --- /dev/null
 +++ b/hw/arm/xlnx-versal.c
@@ -XXX,XX +XXX,XX @@
 +/*
 + * Xilinx Versal SoC model.
 + *
 + * Copyright (c) 2018 Xilinx Inc.
 + * Written by Edgar E. Iglesias
 + *
 + * This program is free software; you can redistribute it and/or modify
 + * it under the terms of the GNU General Public License version 2 or
 + * (at your option) any later version.
 + */
 +
 +#include "qemu/osdep.h"
 +#include "qapi/error.h"
 +#include "qemu-common.h"
 +#include "qemu/log.h"
 +#include "hw/sysbus.h"
 +#include "net/net.h"
 +#include "sysemu/sysemu.h"
 +#include "sysemu/kvm.h"
 +#include "hw/arm/arm.h"
 +#include "kvm_arm.h"
 +#include "hw/misc/unimp.h"
 +#include "hw/intc/arm_gicv3_common.h"
 +#include "hw/arm/xlnx-versal.h"
 +
 +#define XLNX_VERSAL_ACPU_TYPE ARM_CPU_TYPE_NAME("cortex-a72")
 +#define GEM_REVISION        0x40070106
 +
 +static void versal_create_apu_cpus(Versal *s)
 +{
-+    int i;
++    if (regime_el(env, mmu_idx) == 2) {
-+
++        return env->pmsav8.hprbar;
-+    for (i = 0; i < ARRAY_SIZE(s->fpd.apu.cpu); i++) {
++    } else {
-+        Object *obj;
++        return env->pmsav8.rbar[secure];
 +        char *name;
 +
 +        obj = object_new(XLNX_VERSAL_ACPU_TYPE);
 +        if (!obj) {
 +            /* Secondary CPUs start in PSCI powered-down state */
 +            error_report("Unable to create apu.cpu[%d] of type %s",
 +                         i, XLNX_VERSAL_ACPU_TYPE);
 +            exit(EXIT_FAILURE);
 +        }
 +
 +        name = g_strdup_printf("apu-cpu[%d]", i);
 +        object_property_add_child(OBJECT(s), name, obj, &error_fatal);
 +        g_free(name);
 +
 +        object_property_set_int(obj, s->cfg.psci_conduit,
 +                                "psci-conduit", &error_abort);
 +        if (i) {
 +            object_property_set_bool(obj, true,
 +                                     "start-powered-off", &error_abort);
 +        }
 +
 +        object_property_set_int(obj, ARRAY_SIZE(s->fpd.apu.cpu),
 +                                "core-count", &error_abort);
 +        object_property_set_link(obj, OBJECT(&s->fpd.apu.mr), "memory",
 +                                 &error_abort);
 +        object_property_set_bool(obj, true, "realized", &error_fatal);
 +        s->fpd.apu.cpu[i] = ARM_CPU(obj);
 +    }
 +}
 +
-+static void versal_create_apu_gic(Versal *s, qemu_irq *pic)
++static uint32_t *regime_rlar(CPUARMState *env, ARMMMUIdx mmu_idx,
 +                             uint32_t secure)
 +{
-+    static const uint64_t addrs[] = {
++    if (regime_el(env, mmu_idx) == 2) {
-+        MM_GIC_APU_DIST_MAIN,
++        return env->pmsav8.hprlar;
-+        MM_GIC_APU_REDIST_0
++    } else {
-+    };
++        return env->pmsav8.rlar[secure];
 +    SysBusDevice *gicbusdev;
 +    DeviceState *gicdev;
 +    int nr_apu_cpus = ARRAY_SIZE(s->fpd.apu.cpu);
 +    int i;
 +
 +    sysbus_init_child_obj(OBJECT(s), "apu-gic",
 +                          &s->fpd.apu.gic, sizeof(s->fpd.apu.gic),
 +                          gicv3_class_name());
 +    gicbusdev = SYS_BUS_DEVICE(&s->fpd.apu.gic);
 +    gicdev = DEVICE(&s->fpd.apu.gic);
 +    qdev_prop_set_uint32(gicdev, "revision", 3);
 +    qdev_prop_set_uint32(gicdev, "num-cpu", 2);
 +    qdev_prop_set_uint32(gicdev, "num-irq", XLNX_VERSAL_NR_IRQS + 32);
 +    qdev_prop_set_uint32(gicdev, "len-redist-region-count", 1);
 +    qdev_prop_set_uint32(gicdev, "redist-region-count[0]", 2);
 +    qdev_prop_set_bit(gicdev, "has-security-extensions", true);
 +
 +    object_property_set_bool(OBJECT(&s->fpd.apu.gic), true, "realized",
 +                                    &error_fatal);
 +
 +    for (i = 0; i < ARRAY_SIZE(addrs); i++) {
 +        MemoryRegion *mr;
 +
 +        mr = sysbus_mmio_get_region(gicbusdev, i);
 +        memory_region_add_subregion(&s->fpd.apu.mr, addrs[i], mr);
 +    }
 +
 +    for (i = 0; i < nr_apu_cpus; i++) {
 +        DeviceState *cpudev = DEVICE(s->fpd.apu.cpu[i]);
 +        int ppibase = XLNX_VERSAL_NR_IRQS + i * GIC_INTERNAL + GIC_NR_SGIS;
 +        qemu_irq maint_irq;
 +        int ti;
 +        /* Mapping from the output timer irq lines from the CPU to the
 +         * GIC PPI inputs.
 +         */
 +        const int timer_irq[] = {
 +            [GTIMER_PHYS] = VERSAL_TIMER_NS_EL1_IRQ,
 +            [GTIMER_VIRT] = VERSAL_TIMER_VIRT_IRQ,
 +            [GTIMER_HYP]  = VERSAL_TIMER_NS_EL2_IRQ,
 +            [GTIMER_SEC]  = VERSAL_TIMER_S_EL1_IRQ,
 +        };
 +
 +        for (ti = 0; ti < ARRAY_SIZE(timer_irq); ti++) {
 +            qdev_connect_gpio_out(cpudev, ti,
 +                                  qdev_get_gpio_in(gicdev,
 +                                                   ppibase + timer_irq[ti]));
 +        }
 +        maint_irq = qdev_get_gpio_in(gicdev,
 +                                        ppibase + VERSAL_GIC_MAINT_IRQ);
 +        qdev_connect_gpio_out_named(cpudev, "gicv3-maintenance-interrupt",
 +                                    0, maint_irq);
 +        sysbus_connect_irq(gicbusdev, i, qdev_get_gpio_in(cpudev, ARM_CPU_IRQ));
 +        sysbus_connect_irq(gicbusdev, i + nr_apu_cpus,
 +                           qdev_get_gpio_in(cpudev, ARM_CPU_FIQ));
 +        sysbus_connect_irq(gicbusdev, i + 2 * nr_apu_cpus,
 +                           qdev_get_gpio_in(cpudev, ARM_CPU_VIRQ));
 +        sysbus_connect_irq(gicbusdev, i + 3 * nr_apu_cpus,
 +                           qdev_get_gpio_in(cpudev, ARM_CPU_VFIQ));
 +    }
 +
 +    for (i = 0; i < XLNX_VERSAL_NR_IRQS; i++) {
 +        pic[i] = qdev_get_gpio_in(gicdev, i);
 +    }
 +}
 +
-+static void versal_create_uarts(Versal *s, qemu_irq *pic)
+ bool pmsav8_mpu_lookup(CPUARMState *env, uint32_t address,
-+{
+                        MMUAccessType access_type, ARMMMUIdx mmu_idx,
-+    int i;
+                        bool secure, GetPhysAddrResult *result,
-+
+@@ -XXX,XX +XXX,XX @@ bool pmsav8_mpu_lookup(CPUARMState *env, uint32_t address,
-+    for (i = 0; i < ARRAY_SIZE(s->lpd.iou.uart); i++) {
+     bool hit = false;
-+        static const int irqs[] = { VERSAL_UART0_IRQ_0, VERSAL_UART1_IRQ_0};
+     uint32_t addr_page_base = address & TARGET_PAGE_MASK;
-+        static const uint64_t addrs[] = { MM_UART0, MM_UART1 };
+     uint32_t addr_page_limit = addr_page_base + (TARGET_PAGE_SIZE - 1);
-+        char *name = g_strdup_printf("uart%d", i);
++    int region_counter;
-+        DeviceState *dev;
++
-+        MemoryRegion *mr;
++    if (regime_el(env, mmu_idx) == 2) {
-+
++        region_counter = cpu->pmsav8r_hdregion;
-+        dev = qdev_create(NULL, "pl011");
++    } else {
-+        s->lpd.iou.uart[i] = SYS_BUS_DEVICE(dev);
++        region_counter = cpu->pmsav7_dregion;
-+        qdev_prop_set_chr(dev, "chardev", serial_hd(i));
++    }
-+        object_property_add_child(OBJECT(s), name, OBJECT(dev), &error_fatal);
-+        qdev_init_nofail(dev);
+     result->f.lg_page_size = TARGET_PAGE_BITS;
-+
+     result->f.phys_addr = address;
-+        mr = sysbus_mmio_get_region(s->lpd.iou.uart[i], 0);
+@@ -XXX,XX +XXX,XX @@ bool pmsav8_mpu_lookup(CPUARMState *env, uint32_t address,
-+        memory_region_add_subregion(&s->mr_ps, addrs[i], mr);
+         *mregion = -1;
-+
+     }
-+        sysbus_connect_irq(s->lpd.iou.uart[i], 0, pic[irqs[i]]);
-+        g_free(name);
++    if (mmu_idx == ARMMMUIdx_Stage2) {
-+    }
++        fi->stage2 = true;
-+}
++    }
 +
-+static void versal_create_gems(Versal *s, qemu_irq *pic)
+     /*
-+{
+      * Unlike the ARM ARM pseudocode, we don't need to check whether this
-+    int i;
+      * was an exception vector read from the vector table (which is always
-+
+@@ -XXX,XX +XXX,XX @@ bool pmsav8_mpu_lookup(CPUARMState *env, uint32_t address,
-+    for (i = 0; i < ARRAY_SIZE(s->lpd.iou.gem); i++) {
+             hit = true;
-+        static const int irqs[] = { VERSAL_GEM0_IRQ_0, VERSAL_GEM1_IRQ_0};
+         }
-+        static const uint64_t addrs[] = { MM_GEM0, MM_GEM1 };
-+        char *name = g_strdup_printf("gem%d", i);
+-        for (n = (int)cpu->pmsav7_dregion - 1; n >= 0; n--) {
-+        NICInfo *nd = &nd_table[i];
++        uint32_t bitmask;
-+        DeviceState *dev;
++        if (arm_feature(env, ARM_FEATURE_M)) {
-+        MemoryRegion *mr;
++            bitmask = 0x1f;
-+
++        } else {
-+        dev = qdev_create(NULL, "cadence_gem");
++            bitmask = 0x3f;
-+        s->lpd.iou.gem[i] = SYS_BUS_DEVICE(dev);
++            fi->level = 0;
-+        object_property_add_child(OBJECT(s), name, OBJECT(dev), &error_fatal);
++        }
-+        if (nd->used) {
++
-+            qemu_check_nic_model(nd, "cadence_gem");
++        for (n = region_counter - 1; n >= 0; n--) {
-+            qdev_set_nic_properties(dev, nd);
+             /* region search */
-+        }
+             /*
-+        object_property_set_int(OBJECT(s->lpd.iou.gem[i]),
+-             * Note that the base address is bits [31:5] from the register
-+                                2, "num-priority-queues",
+-             * with bits [4:0] all zeroes, but the limit address is bits
-+                                &error_abort);
+-             * [31:5] from the register with bits [4:0] all ones.
-+        object_property_set_link(OBJECT(s->lpd.iou.gem[i]),
++             * Note that the base address is bits [31:x] from the register
-+                                 OBJECT(&s->mr_ps), "dma",
++             * with bits [x-1:0] all zeroes, but the limit address is bits
-+                                 &error_abort);
++             * [31:x] from the register with bits [x:0] all ones. Where x is
-+        qdev_init_nofail(dev);
++             * 5 for Cortex-M and 6 for Cortex-R
-+
+              */
-+        mr = sysbus_mmio_get_region(s->lpd.iou.gem[i], 0);
+-            uint32_t base = env->pmsav8.rbar[secure][n] & ~0x1f;
-+        memory_region_add_subregion(&s->mr_ps, addrs[i], mr);
+-            uint32_t limit = env->pmsav8.rlar[secure][n] | 0x1f;
-+
++            uint32_t base = regime_rbar(env, mmu_idx, secure)[n] & ~bitmask;
-+        sysbus_connect_irq(s->lpd.iou.gem[i], 0, pic[irqs[i]]);
++            uint32_t limit = regime_rlar(env, mmu_idx, secure)[n] | bitmask;
-+        g_free(name);
-+    }
+-            if (!(env->pmsav8.rlar[secure][n] & 0x1)) {
-+}
++            if (!(regime_rlar(env, mmu_idx, secure)[n] & 0x1)) {
-+
+                 /* Region disabled */
-+/* This takes the board allocated linear DDR memory and creates aliases
+                 continue;
-+ * for each split DDR range/aperture on the Versal address map.
+             }
-+ */
+@@ -XXX,XX +XXX,XX @@ bool pmsav8_mpu_lookup(CPUARMState *env, uint32_t address,
-+static void versal_map_ddr(Versal *s)
+                  * PMSAv7 where highest-numbered-region wins)
-+{
+                  */
-+    uint64_t size = memory_region_size(s->cfg.mr_ddr);
+                 fi->type = ARMFault_Permission;
-+    /* Describes the various split DDR access regions.  */
+-                fi->level = 1;
-+    static const struct {
++                if (arm_feature(env, ARM_FEATURE_M)) {
-+        uint64_t base;
++                    fi->level = 1;
-+        uint64_t size;
++                }
-+    } addr_ranges[] = {
+                 return true;
-+        { MM_TOP_DDR, MM_TOP_DDR_SIZE },
+             }
-+        { MM_TOP_DDR_2, MM_TOP_DDR_2_SIZE },
-+        { MM_TOP_DDR_3, MM_TOP_DDR_3_SIZE },
+@@ -XXX,XX +XXX,XX @@ bool pmsav8_mpu_lookup(CPUARMState *env, uint32_t address,
-+        { MM_TOP_DDR_4, MM_TOP_DDR_4_SIZE }
+     }
-+    };
-+    uint64_t offset = 0;
+     if (!hit) {
-+    int i;
+-        /* background fault */
-+
+-        fi->type = ARMFault_Background;
-+    assert(ARRAY_SIZE(addr_ranges) == ARRAY_SIZE(s->noc.mr_ddr_ranges));
++        if (arm_feature(env, ARM_FEATURE_M)) {
-+    for (i = 0; i < ARRAY_SIZE(addr_ranges) && size; i++) {
++            fi->type = ARMFault_Background;
-+        char *name;
++        } else {
-+        uint64_t mapsize;
++            fi->type = ARMFault_Permission;
-+
++        }
-+        mapsize = size < addr_ranges[i].size ? size : addr_ranges[i].size;
+         return true;
-+        name = g_strdup_printf("noc-ddr-range%d", i);
+     }
-+        /* Create the MR alias.  */
-+        memory_region_init_alias(&s->noc.mr_ddr_ranges[i], OBJECT(s),
+@@ -XXX,XX +XXX,XX @@ bool pmsav8_mpu_lookup(CPUARMState *env, uint32_t address,
-+                                 name, s->cfg.mr_ddr,
+         /* hit using the background region */
-+                                 offset, mapsize);
+         get_phys_addr_pmsav7_default(env, mmu_idx, address, &result->f.prot);
-+
+     } else {
-+        /* Map it onto the NoC MR.  */
+-        uint32_t ap = extract32(env->pmsav8.rbar[secure][matchregion], 1, 2);
-+        memory_region_add_subregion(&s->mr_ps, addr_ranges[i].base,
+-        uint32_t xn = extract32(env->pmsav8.rbar[secure][matchregion], 0, 1);
-+                                    &s->noc.mr_ddr_ranges[i]);
++        uint32_t matched_rbar = regime_rbar(env, mmu_idx, secure)[matchregion];
-+        offset += mapsize;
++        uint32_t matched_rlar = regime_rlar(env, mmu_idx, secure)[matchregion];
-+        size -= mapsize;
++        uint32_t ap = extract32(matched_rbar, 1, 2);
-+        g_free(name);
++        uint32_t xn = extract32(matched_rbar, 0, 1);
-+    }
+         bool pxn = false;
-+}
-+
+         if (arm_feature(env, ARM_FEATURE_V8_1M)) {
-+static void versal_unimp_area(Versal *s, const char *name,
+-            pxn = extract32(env->pmsav8.rlar[secure][matchregion], 4, 1);
-+                                MemoryRegion *mr,
++            pxn = extract32(matched_rlar, 4, 1);
-+                                hwaddr base, hwaddr size)
+         }
-+{
-+    DeviceState *dev = qdev_create(NULL, TYPE_UNIMPLEMENTED_DEVICE);
+         if (m_is_system_region(env, address)) {
-+    MemoryRegion *mr_dev;
+@@ -XXX,XX +XXX,XX @@ bool pmsav8_mpu_lookup(CPUARMState *env, uint32_t address,
-+
+             xn = 1;
-+    qdev_prop_set_string(dev, "name", name);
+         }
-+    qdev_prop_set_uint64(dev, "size", size);
-+    object_property_add_child(OBJECT(s), name, OBJECT(dev), &error_fatal);
+-        result->f.prot = simple_ap_to_rw_prot(env, mmu_idx, ap);
-+    qdev_init_nofail(dev);
++        if (regime_el(env, mmu_idx) == 2) {
-+
++            result->f.prot = simple_ap_to_rw_prot_is_user(ap,
-+    mr_dev = sysbus_mmio_get_region(SYS_BUS_DEVICE(dev), 0);
++                                            mmu_idx != ARMMMUIdx_E2);
-+    memory_region_add_subregion(mr, base, mr_dev);
++        } else {
-+}
++            result->f.prot = simple_ap_to_rw_prot(env, mmu_idx, ap);
-+
++        }
-+static void versal_unimp(Versal *s)
++
-+{
++        if (!arm_feature(env, ARM_FEATURE_M)) {
-+    versal_unimp_area(s, "psm", &s->mr_ps,
++            uint8_t attrindx = extract32(matched_rlar, 1, 3);
-+                        MM_PSM_START, MM_PSM_END - MM_PSM_START);
++            uint64_t mair = env->cp15.mair_el[regime_el(env, mmu_idx)];
-+    versal_unimp_area(s, "crl", &s->mr_ps,
++            uint8_t sh = extract32(matched_rlar, 3, 2);
-+                        MM_CRL, MM_CRL_SIZE);
++
-+    versal_unimp_area(s, "crf", &s->mr_ps,
++            if (regime_sctlr(env, mmu_idx) & SCTLR_WXN &&
-+                        MM_FPD_CRF, MM_FPD_CRF_SIZE);
++                result->f.prot & PAGE_WRITE && mmu_idx != ARMMMUIdx_Stage2) {
-+    versal_unimp_area(s, "iou-scntr", &s->mr_ps,
++                xn = 0x1;
-+                        MM_IOU_SCNTR, MM_IOU_SCNTR_SIZE);
++            }
-+    versal_unimp_area(s, "iou-scntr-seucre", &s->mr_ps,
++
-+                        MM_IOU_SCNTRS, MM_IOU_SCNTRS_SIZE);
++            if ((regime_el(env, mmu_idx) == 1) &&
-+}
++                regime_sctlr(env, mmu_idx) & SCTLR_UWXN && ap == 0x1) {
-+
++                pxn = 0x1;
-+static void versal_realize(DeviceState *dev, Error **errp)
++            }
-+{
++
-+    Versal *s = XLNX_VERSAL(dev);
++            result->cacheattrs.is_s2_format = false;
-+    qemu_irq pic[XLNX_VERSAL_NR_IRQS];
++            result->cacheattrs.attrs = extract64(mair, attrindx * 8, 8);
-+
++            result->cacheattrs.shareability = sh;
-+    versal_create_apu_cpus(s);
++        }
-+    versal_create_apu_gic(s, pic);
++
-+    versal_create_uarts(s, pic);
+         if (result->f.prot && !xn && !(pxn && !is_user)) {
-+    versal_create_gems(s, pic);
+             result->f.prot |= PAGE_EXEC;
-+    versal_map_ddr(s);
+         }
-+    versal_unimp(s);
+-        /*
-+
+-         * We don't need to look the attribute up in the MAIR0/MAIR1
-+    /* Create the On Chip Memory (OCM).  */
+-         * registers because that only tells us about cacheability.
-+    memory_region_init_ram(&s->lpd.mr_ocm, OBJECT(s), "ocm",
+-         */
-+                           MM_OCM_SIZE, &error_fatal);
++
-+
+         if (mregion) {
-+    memory_region_add_subregion_overlap(&s->mr_ps, MM_OCM, &s->lpd.mr_ocm, 0);
+             *mregion = matchregion;
-+    memory_region_add_subregion_overlap(&s->fpd.apu.mr, 0, &s->mr_ps, 0);
+         }
-+}
+     }
-+
-+static void versal_init(Object *obj)
+     fi->type = ARMFault_Permission;
-+{
+-    fi->level = 1;
-+    Versal *s = XLNX_VERSAL(obj);
++    if (arm_feature(env, ARM_FEATURE_M)) {
-+
++        fi->level = 1;
-+    memory_region_init(&s->fpd.apu.mr, obj, "mr-apu", UINT64_MAX);
++    }
-+    memory_region_init(&s->mr_ps, obj, "mr-ps-switch", UINT64_MAX);
+     return !(result->f.prot & (1 << access_type));
-+}
+ }
-+
-+static Property versal_properties[] = {
+@@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_twostage(CPUARMState *env, S1Translate *ptw,
-+    DEFINE_PROP_LINK("ddr", Versal, cfg.mr_ddr, TYPE_MEMORY_REGION,
+     cacheattrs1 = result->cacheattrs;
-+                     MemoryRegion *),
+     memset(result, 0, sizeof(*result));
-+    DEFINE_PROP_UINT32("psci-conduit", Versal, cfg.psci_conduit, 0),
-+    DEFINE_PROP_END_OF_LIST()
+-    ret = get_phys_addr_lpae(env, ptw, ipa, access_type, is_el0, result, fi);
-+};
++    if (arm_feature(env, ARM_FEATURE_PMSA)) {
-+
++        ret = get_phys_addr_pmsav8(env, ipa, access_type,
-+static void versal_class_init(ObjectClass *klass, void *data)
++                                   ptw->in_mmu_idx, is_secure, result, fi);
-+{
++    } else {
-+    DeviceClass *dc = DEVICE_CLASS(klass);
++        ret = get_phys_addr_lpae(env, ptw, ipa, access_type,
-+
++                                 is_el0, result, fi);
-+    dc->realize = versal_realize;
++    }
-+    dc->props = versal_properties;
+     fi->s2addr = ipa;
-+    /* No VMSD since we haven't got any top-level SoC state to save.  */
-+}
+     /* Combine the S1 and S2 perms.  */
 +
 +static const TypeInfo versal_info = {
 +    .name = TYPE_XLNX_VERSAL,
 +    .parent = TYPE_SYS_BUS_DEVICE,
 +    .instance_size = sizeof(Versal),
 +    .instance_init = versal_init,
 +    .class_init = versal_class_init,
 +};
 +
 +static void versal_register_types(void)
 +{
 +    type_register_static(&versal_info);
 +}
 +
 +type_init(versal_register_types);
 diff --git a/default-configs/aarch64-softmmu.mak b/default-configs/aarch64-softmmu.mak
 index XXXXXXX..XXXXXXX 100644
 --- a/default-configs/aarch64-softmmu.mak
 +++ b/default-configs/aarch64-softmmu.mak
@@ -XXX,XX +XXX,XX @@ CONFIG_DDC=y
  CONFIG_DPCD=y
  CONFIG_XLNX_ZYNQMP=y
  CONFIG_XLNX_ZYNQMP_ARM=y
 +CONFIG_XLNX_VERSAL=y
  CONFIG_ARM_SMMUV3=y
 --
-.19.1
+.25.1

-New patch
+[PULL 08/34] target/arm: Add ARM Cortex-R52 CPU
+From: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>
+All constants are taken from the ARM Cortex-R52 Processor TRM Revision: r1p3
+Signed-off-by: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>
+Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
+Message-id: 20221206102504.165775-8-tobias.roehmel@rwth-aachen.de
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+---
+ target/arm/cpu_tcg.c | 42 ++++++++++++++++++++++++++++++++++++++++++
+file changed, 42 insertions(+)
+diff --git a/target/arm/cpu_tcg.c b/target/arm/cpu_tcg.c
+index XXXXXXX..XXXXXXX 100644
+--- a/target/arm/cpu_tcg.c
++++ b/target/arm/cpu_tcg.c
+@@ -XXX,XX +XXX,XX @@ static void cortex_r5_initfn(Object *obj)
+     define_arm_cp_regs(cpu, cortexr5_cp_reginfo);
+ }
++static void cortex_r52_initfn(Object *obj)
++{
++    ARMCPU *cpu = ARM_CPU(obj);
++
++    set_feature(&cpu->env, ARM_FEATURE_V8);
++    set_feature(&cpu->env, ARM_FEATURE_EL2);
++    set_feature(&cpu->env, ARM_FEATURE_PMSA);
++    set_feature(&cpu->env, ARM_FEATURE_NEON);
++    set_feature(&cpu->env, ARM_FEATURE_GENERIC_TIMER);
++    cpu->midr = 0x411fd133; /* r1p3 */
++    cpu->revidr = 0x00000000;
++    cpu->reset_fpsid = 0x41034023;
++    cpu->isar.mvfr0 = 0x10110222;
++    cpu->isar.mvfr1 = 0x12111111;
++    cpu->isar.mvfr2 = 0x00000043;
++    cpu->ctr = 0x8144c004;
++    cpu->reset_sctlr = 0x30c50838;
++    cpu->isar.id_pfr0 = 0x00000131;
++    cpu->isar.id_pfr1 = 0x10111001;
++    cpu->isar.id_dfr0 = 0x03010006;
++    cpu->id_afr0 = 0x00000000;
++    cpu->isar.id_mmfr0 = 0x00211040;
++    cpu->isar.id_mmfr1 = 0x40000000;
++    cpu->isar.id_mmfr2 = 0x01200000;
++    cpu->isar.id_mmfr3 = 0xf0102211;
++    cpu->isar.id_mmfr4 = 0x00000010;
++    cpu->isar.id_isar0 = 0x02101110;
++    cpu->isar.id_isar1 = 0x13112111;
++    cpu->isar.id_isar2 = 0x21232142;
++    cpu->isar.id_isar3 = 0x01112131;
++    cpu->isar.id_isar4 = 0x00010142;
++    cpu->isar.id_isar5 = 0x00010001;
++    cpu->isar.dbgdidr = 0x77168000;
++    cpu->clidr = (1 << 27) | (1 << 24) | 0x3;
++    cpu->ccsidr[0] = 0x700fe01a; /* 32KB L1 dcache */
++    cpu->ccsidr[1] = 0x201fe00a; /* 32KB L1 icache */
++
++    cpu->pmsav7_dregion = 16;
++    cpu->pmsav8r_hdregion = 16;
++}
++
+ static void cortex_r5f_initfn(Object *obj)
+ {
+     ARMCPU *cpu = ARM_CPU(obj);
+@@ -XXX,XX +XXX,XX @@ static const ARMCPUInfo arm_tcg_cpus[] = {
+                              .class_init = arm_v7m_class_init },
+     { .name = "cortex-r5",   .initfn = cortex_r5_initfn },
+     { .name = "cortex-r5f",  .initfn = cortex_r5f_initfn },
++    { .name = "cortex-r52",  .initfn = cortex_r52_initfn },
+     { .name = "ti925t",      .initfn = ti925t_initfn },
+     { .name = "sa1100",      .initfn = sa1100_initfn },
+     { .name = "sa1110",      .initfn = sa1110_initfn },
+--
+.25.1

-New patch
+[PULL 09/34] target/arm: fix handling of HLT semihosting in system mode
+From: Alex Bennée <alex.bennee@linaro.org>
+The check semihosting_enabled() wants to know if the guest is
+currently in user mode. Unlike the other cases the test was inverted
+causing us to block semihosting calls in non-EL0 modes.
+Cc: qemu-stable@nongnu.org
+Fixes: 19b26317e9 (target/arm: Honour -semihosting-config userspace=on)
+Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
+Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+---
+ target/arm/translate.c | 2 +-
+file changed, 1 insertion(+), 1 deletion(-)
+diff --git a/target/arm/translate.c b/target/arm/translate.c
+index XXXXXXX..XXXXXXX 100644
+--- a/target/arm/translate.c
++++ b/target/arm/translate.c
+@@ -XXX,XX +XXX,XX @@ static inline void gen_hlt(DisasContext *s, int imm)
+      * semihosting, to provide some semblance of security
+      * (and for consistency with our 32-bit semihosting).
+      */
+-    if (semihosting_enabled(s->current_el != 0) &&
++    if (semihosting_enabled(s->current_el == 0) &&
+         (imm == (s->thumb ? 0x3c : 0xf000))) {
+         gen_exception_internal_insn(s, EXCP_SEMIHOST);
+         return;
+--
+.25.1

-New patch
+[PULL 10/34] hw/timer/imx_epit: improve comments
+From: Axel Heider <axel.heider@hensoldt.net>
+Fix typos, add background information
+Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
+Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+---
+ hw/timer/imx_epit.c | 20 ++++++++++++++++----
+file changed, 16 insertions(+), 4 deletions(-)
+diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c
+index XXXXXXX..XXXXXXX 100644
+--- a/hw/timer/imx_epit.c
++++ b/hw/timer/imx_epit.c
+@@ -XXX,XX +XXX,XX @@ static void imx_epit_set_freq(IMXEPITState *s)
+     }
+ }
++/*
++ * This is called both on hardware (device) reset and software reset.
++ */
+ static void imx_epit_reset(DeviceState *dev)
+ {
+     IMXEPITState *s = IMX_EPIT(dev);
+-    /*
+-     * Soft reset doesn't touch some bits; hard reset clears them
+-     */
++    /* Soft reset doesn't touch some bits; hard reset clears them */
+     s->cr &= (CR_EN|CR_ENMOD|CR_STOPEN|CR_DOZEN|CR_WAITEN|CR_DBGEN);
+     s->sr = 0;
+     s->lr = EPIT_TIMER_MAX;
+@@ -XXX,XX +XXX,XX @@ static void imx_epit_write(void *opaque, hwaddr offset, uint64_t value,
+         ptimer_transaction_begin(s->timer_cmp);
+         ptimer_transaction_begin(s->timer_reload);
++        /* Update the frequency. Has been done already in case of a reset. */
+         if (!(s->cr & CR_SWR)) {
+             imx_epit_set_freq(s);
+         }
+@@ -XXX,XX +XXX,XX @@ static void imx_epit_write(void *opaque, hwaddr offset, uint64_t value,
+         break;
+     case 1: /* SR - ACK*/
+-        /* writing 1 to OCIF clear the OCIF bit */
++        /* writing 1 to OCIF clears the OCIF bit */
+         if (value & 0x01) {
+             s->sr = 0;
+             imx_epit_update_int(s);
+@@ -XXX,XX +XXX,XX @@ static void imx_epit_realize(DeviceState *dev, Error **errp)
+x00001000);
+     sysbus_init_mmio(sbd, &s->iomem);
++    /*
++     * The reload timer keeps running when the peripheral is enabled. It is a
++     * kind of wall clock that does not generate any interrupts. The callback
++     * needs to be provided, but it does nothing as the ptimer already supports
++     * all necessary reloading functionality.
++     */
+     s->timer_reload = ptimer_init(imx_epit_reload, s, PTIMER_POLICY_LEGACY);
++    /*
++     * The compare timer is running only when the peripheral configuration is
++     * in a state that will generate compare interrupts.
++     */
+     s->timer_cmp = ptimer_init(imx_epit_cmp, s, PTIMER_POLICY_LEGACY);
+ }
+--
+.25.1

-New patch
+[PULL 11/34] hw/timer/imx_epit: cleanup CR defines
+From: Axel Heider <axel.heider@hensoldt.net>
+remove unused defines, add needed defines
+Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
+Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+---
+ include/hw/timer/imx_epit.h | 4 ++--
+ hw/timer/imx_epit.c         | 4 ++--
+files changed, 4 insertions(+), 4 deletions(-)
+diff --git a/include/hw/timer/imx_epit.h b/include/hw/timer/imx_epit.h
+index XXXXXXX..XXXXXXX 100644
+--- a/include/hw/timer/imx_epit.h
++++ b/include/hw/timer/imx_epit.h
+@@ -XXX,XX +XXX,XX @@
+ #define CR_OCIEN    (1 << 2)
+ #define CR_RLD      (1 << 3)
+ #define CR_PRESCALE_SHIFT (4)
+-#define CR_PRESCALE_MASK  (0xfff)
++#define CR_PRESCALE_BITS  (12)
+ #define CR_SWR      (1 << 16)
+ #define CR_IOVW     (1 << 17)
+ #define CR_DBGEN    (1 << 18)
+@@ -XXX,XX +XXX,XX @@
+ #define CR_DOZEN    (1 << 20)
+ #define CR_STOPEN   (1 << 21)
+ #define CR_CLKSRC_SHIFT (24)
+-#define CR_CLKSRC_MASK  (0x3 << CR_CLKSRC_SHIFT)
++#define CR_CLKSRC_BITS  (2)
+ #define EPIT_TIMER_MAX  0XFFFFFFFFUL
+diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c
+index XXXXXXX..XXXXXXX 100644
+--- a/hw/timer/imx_epit.c
++++ b/hw/timer/imx_epit.c
+@@ -XXX,XX +XXX,XX @@ static void imx_epit_set_freq(IMXEPITState *s)
+     uint32_t clksrc;
+     uint32_t prescaler;
+-    clksrc = extract32(s->cr, CR_CLKSRC_SHIFT, 2);
+-    prescaler = 1 + extract32(s->cr, CR_PRESCALE_SHIFT, 12);
++    clksrc = extract32(s->cr, CR_CLKSRC_SHIFT, CR_CLKSRC_BITS);
++    prescaler = 1 + extract32(s->cr, CR_PRESCALE_SHIFT, CR_PRESCALE_BITS);
+     s->freq = imx_ccm_get_clock_frequency(s->ccm,
+                                 imx_epit_clocks[clksrc]) / prescaler;
+--
+.25.1

-New patch
+[PULL 12/34] hw/timer/imx_epit: define SR_OCIF
+From: Axel Heider <axel.heider@hensoldt.net>
+Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+---
+ include/hw/timer/imx_epit.h |  2 ++
+ hw/timer/imx_epit.c         | 12 ++++++------
+files changed, 8 insertions(+), 6 deletions(-)
+diff --git a/include/hw/timer/imx_epit.h b/include/hw/timer/imx_epit.h
+index XXXXXXX..XXXXXXX 100644
+--- a/include/hw/timer/imx_epit.h
++++ b/include/hw/timer/imx_epit.h
+@@ -XXX,XX +XXX,XX @@
+ #define CR_CLKSRC_SHIFT (24)
+ #define CR_CLKSRC_BITS  (2)
++#define SR_OCIF     (1 << 0)
++
+ #define EPIT_TIMER_MAX  0XFFFFFFFFUL
+ #define TYPE_IMX_EPIT "imx.epit"
+diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c
+index XXXXXXX..XXXXXXX 100644
+--- a/hw/timer/imx_epit.c
++++ b/hw/timer/imx_epit.c
+@@ -XXX,XX +XXX,XX @@ static const IMXClk imx_epit_clocks[] =  {
+  */
+ static void imx_epit_update_int(IMXEPITState *s)
+ {
+-    if (s->sr && (s->cr & CR_OCIEN) && (s->cr & CR_EN)) {
++    if ((s->sr & SR_OCIF) && (s->cr & CR_OCIEN) && (s->cr & CR_EN)) {
+         qemu_irq_raise(s->irq);
+     } else {
+         qemu_irq_lower(s->irq);
+@@ -XXX,XX +XXX,XX @@ static void imx_epit_write(void *opaque, hwaddr offset, uint64_t value,
+         break;
+     case 1: /* SR - ACK*/
+-        /* writing 1 to OCIF clears the OCIF bit */
+-        if (value & 0x01) {
+-            s->sr = 0;
++        /* writing 1 to SR.OCIF clears this bit and turns the interrupt off */
++        if (value & SR_OCIF) {
++            s->sr = 0; /* SR.OCIF is the only bit in this register anyway */
+             imx_epit_update_int(s);
+         }
+         break;
+@@ -XXX,XX +XXX,XX @@ static void imx_epit_cmp(void *opaque)
+     IMXEPITState *s = IMX_EPIT(opaque);
+     DPRINTF("sr was %d\n", s->sr);
+-
+-    s->sr = 1;
++    /* Set interrupt status bit SR.OCIF and update the interrupt state */
++    s->sr |= SR_OCIF;
+     imx_epit_update_int(s);
+ }
+--
+.25.1

-New patch
+[PULL 13/34] hw/timer/imx_epit: update interrupt state on CR write access
+From: Axel Heider <axel.heider@hensoldt.net>
+The interrupt state can change due to:
+- reset clears both SR.OCIF and CR.OCIE
+- write to CR.EN or CR.OCIE
+Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
+Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+---
+ hw/timer/imx_epit.c | 16 ++++++++++++----
+file changed, 12 insertions(+), 4 deletions(-)
+diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c
+index XXXXXXX..XXXXXXX 100644
+--- a/hw/timer/imx_epit.c
++++ b/hw/timer/imx_epit.c
+@@ -XXX,XX +XXX,XX @@ static void imx_epit_write(void *opaque, hwaddr offset, uint64_t value,
+         if (s->cr & CR_SWR) {
+             /* handle the reset */
+             imx_epit_reset(DEVICE(s));
+-            /*
+-             * TODO: could we 'break' here? following operations appear
+-             * to duplicate the work imx_epit_reset() already did.
+-             */
+         }
++        /*
++         * The interrupt state can change due to:
++         * - reset clears both SR.OCIF and CR.OCIE
++         * - write to CR.EN or CR.OCIE
++         */
++        imx_epit_update_int(s);
++
++        /*
++         * TODO: could we 'break' here for reset? following operations appear
++         * to duplicate the work imx_epit_reset() already did.
++         */
++
+         ptimer_transaction_begin(s->timer_cmp);
+         ptimer_transaction_begin(s->timer_reload);
+--
+.25.1

-New patch
+[PULL 14/34] hw/timer/imx_epit: hard reset initializes CR with 0
+From: Axel Heider <axel.heider@hensoldt.net>
+Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
+Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+---
+ hw/timer/imx_epit.c | 20 ++++++++++++++------
+file changed, 14 insertions(+), 6 deletions(-)
+diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c
+index XXXXXXX..XXXXXXX 100644
+--- a/hw/timer/imx_epit.c
++++ b/hw/timer/imx_epit.c
+@@ -XXX,XX +XXX,XX @@ static void imx_epit_set_freq(IMXEPITState *s)
+ /*
+  * This is called both on hardware (device) reset and software reset.
+  */
+-static void imx_epit_reset(DeviceState *dev)
++static void imx_epit_reset(IMXEPITState *s, bool is_hard_reset)
+ {
+-    IMXEPITState *s = IMX_EPIT(dev);
+-
+     /* Soft reset doesn't touch some bits; hard reset clears them */
+-    s->cr &= (CR_EN|CR_ENMOD|CR_STOPEN|CR_DOZEN|CR_WAITEN|CR_DBGEN);
++    if (is_hard_reset) {
++        s->cr = 0;
++    } else {
++        s->cr &= (CR_EN|CR_ENMOD|CR_STOPEN|CR_DOZEN|CR_WAITEN|CR_DBGEN);
++    }
+     s->sr = 0;
+     s->lr = EPIT_TIMER_MAX;
+     s->cmp = 0;
+@@ -XXX,XX +XXX,XX @@ static void imx_epit_write(void *opaque, hwaddr offset, uint64_t value,
+         s->cr = value & 0x03ffffff;
+         if (s->cr & CR_SWR) {
+             /* handle the reset */
+-            imx_epit_reset(DEVICE(s));
++            imx_epit_reset(s, false);
+         }
+         /*
+@@ -XXX,XX +XXX,XX @@ static void imx_epit_realize(DeviceState *dev, Error **errp)
+     s->timer_cmp = ptimer_init(imx_epit_cmp, s, PTIMER_POLICY_LEGACY);
+ }
++static void imx_epit_dev_reset(DeviceState *dev)
++{
++    IMXEPITState *s = IMX_EPIT(dev);
++    imx_epit_reset(s, true);
++}
++
+ static void imx_epit_class_init(ObjectClass *klass, void *data)
+ {
+     DeviceClass *dc  = DEVICE_CLASS(klass);
+     dc->realize = imx_epit_realize;
+-    dc->reset = imx_epit_reset;
++    dc->reset = imx_epit_dev_reset;
+     dc->vmsd = &vmstate_imx_timer_epit;
+     dc->desc = "i.MX periodic timer";
+ }
+--
+.25.1

-New patch
+[PULL 15/34] hw/timer/imx_epit: factor out register write handlers
+From: Axel Heider <axel.heider@hensoldt.net>
+Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
+Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+---
+ hw/timer/imx_epit.c | 215 ++++++++++++++++++++++++--------------------
+file changed, 117 insertions(+), 98 deletions(-)
+diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c
+index XXXXXXX..XXXXXXX 100644
+--- a/hw/timer/imx_epit.c
++++ b/hw/timer/imx_epit.c
+@@ -XXX,XX +XXX,XX @@ static void imx_epit_reload_compare_timer(IMXEPITState *s)
+     }
+ }
++static void imx_epit_write_cr(IMXEPITState *s, uint32_t value)
++{
++    uint32_t oldcr = s->cr;
++
++    s->cr = value & 0x03ffffff;
++
++    if (s->cr & CR_SWR) {
++        /* handle the reset */
++        imx_epit_reset(s, false);
++    }
++
++    /*
++     * The interrupt state can change due to:
++     * - reset clears both SR.OCIF and CR.OCIE
++     * - write to CR.EN or CR.OCIE
++     */
++    imx_epit_update_int(s);
++
++    /*
++     * TODO: could we 'break' here for reset? following operations appear
++     * to duplicate the work imx_epit_reset() already did.
++     */
++
++    ptimer_transaction_begin(s->timer_cmp);
++    ptimer_transaction_begin(s->timer_reload);
++
++    /* Update the frequency. Has been done already in case of a reset. */
++    if (!(s->cr & CR_SWR)) {
++        imx_epit_set_freq(s);
++    }
++
++    if (s->freq && (s->cr & CR_EN) && !(oldcr & CR_EN)) {
++        if (s->cr & CR_ENMOD) {
++            if (s->cr & CR_RLD) {
++                ptimer_set_limit(s->timer_reload, s->lr, 1);
++                ptimer_set_limit(s->timer_cmp, s->lr, 1);
++            } else {
++                ptimer_set_limit(s->timer_reload, EPIT_TIMER_MAX, 1);
++                ptimer_set_limit(s->timer_cmp, EPIT_TIMER_MAX, 1);
++            }
++        }
++
++        imx_epit_reload_compare_timer(s);
++        ptimer_run(s->timer_reload, 0);
++        if (s->cr & CR_OCIEN) {
++            ptimer_run(s->timer_cmp, 0);
++        } else {
++            ptimer_stop(s->timer_cmp);
++        }
++    } else if (!(s->cr & CR_EN)) {
++        /* stop both timers */
++        ptimer_stop(s->timer_reload);
++        ptimer_stop(s->timer_cmp);
++    } else  if (s->cr & CR_OCIEN) {
++        if (!(oldcr & CR_OCIEN)) {
++            imx_epit_reload_compare_timer(s);
++            ptimer_run(s->timer_cmp, 0);
++        }
++    } else {
++        ptimer_stop(s->timer_cmp);
++    }
++
++    ptimer_transaction_commit(s->timer_cmp);
++    ptimer_transaction_commit(s->timer_reload);
++}
++
++static void imx_epit_write_sr(IMXEPITState *s, uint32_t value)
++{
++    /* writing 1 to SR.OCIF clears this bit and turns the interrupt off */
++    if (value & SR_OCIF) {
++        s->sr = 0; /* SR.OCIF is the only bit in this register anyway */
++        imx_epit_update_int(s);
++    }
++}
++
++static void imx_epit_write_lr(IMXEPITState *s, uint32_t value)
++{
++    s->lr = value;
++
++    ptimer_transaction_begin(s->timer_cmp);
++    ptimer_transaction_begin(s->timer_reload);
++    if (s->cr & CR_RLD) {
++        /* Also set the limit if the LRD bit is set */
++        /* If IOVW bit is set then set the timer value */
++        ptimer_set_limit(s->timer_reload, s->lr, s->cr & CR_IOVW);
++        ptimer_set_limit(s->timer_cmp, s->lr, 0);
++    } else if (s->cr & CR_IOVW) {
++        /* If IOVW bit is set then set the timer value */
++        ptimer_set_count(s->timer_reload, s->lr);
++    }
++    /*
++     * Commit the change to s->timer_reload, so it can propagate. Otherwise
++     * the timer interrupt may not fire properly. The commit must happen
++     * before calling imx_epit_reload_compare_timer(), which reads
++     * s->timer_reload internally again.
++     */
++    ptimer_transaction_commit(s->timer_reload);
++    imx_epit_reload_compare_timer(s);
++    ptimer_transaction_commit(s->timer_cmp);
++}
++
++static void imx_epit_write_cmp(IMXEPITState *s, uint32_t value)
++{
++    s->cmp = value;
++
++    ptimer_transaction_begin(s->timer_cmp);
++    imx_epit_reload_compare_timer(s);
++    ptimer_transaction_commit(s->timer_cmp);
++}
++
+ static void imx_epit_write(void *opaque, hwaddr offset, uint64_t value,
+                            unsigned size)
+ {
+     IMXEPITState *s = IMX_EPIT(opaque);
+-    uint64_t oldcr;
+     DPRINTF("(%s, value = 0x%08x)\n", imx_epit_reg_name(offset >> 2),
+             (uint32_t)value);
+     switch (offset >> 2) {
+     case 0: /* CR */
+-
+-        oldcr = s->cr;
+-        s->cr = value & 0x03ffffff;
+-        if (s->cr & CR_SWR) {
+-            /* handle the reset */
+-            imx_epit_reset(s, false);
+-        }
+-
+-        /*
+-         * The interrupt state can change due to:
+-         * - reset clears both SR.OCIF and CR.OCIE
+-         * - write to CR.EN or CR.OCIE
+-         */
+-        imx_epit_update_int(s);
+-
+-        /*
+-         * TODO: could we 'break' here for reset? following operations appear
+-         * to duplicate the work imx_epit_reset() already did.
+-         */
+-
+-        ptimer_transaction_begin(s->timer_cmp);
+-        ptimer_transaction_begin(s->timer_reload);
+-
+-        /* Update the frequency. Has been done already in case of a reset. */
+-        if (!(s->cr & CR_SWR)) {
+-            imx_epit_set_freq(s);
+-        }
+-
+-        if (s->freq && (s->cr & CR_EN) && !(oldcr & CR_EN)) {
+-            if (s->cr & CR_ENMOD) {
+-                if (s->cr & CR_RLD) {
+-                    ptimer_set_limit(s->timer_reload, s->lr, 1);
+-                    ptimer_set_limit(s->timer_cmp, s->lr, 1);
+-                } else {
+-                    ptimer_set_limit(s->timer_reload, EPIT_TIMER_MAX, 1);
+-                    ptimer_set_limit(s->timer_cmp, EPIT_TIMER_MAX, 1);
+-                }
+-            }
+-
+-            imx_epit_reload_compare_timer(s);
+-            ptimer_run(s->timer_reload, 0);
+-            if (s->cr & CR_OCIEN) {
+-                ptimer_run(s->timer_cmp, 0);
+-            } else {
+-                ptimer_stop(s->timer_cmp);
+-            }
+-        } else if (!(s->cr & CR_EN)) {
+-            /* stop both timers */
+-            ptimer_stop(s->timer_reload);
+-            ptimer_stop(s->timer_cmp);
+-        } else  if (s->cr & CR_OCIEN) {
+-            if (!(oldcr & CR_OCIEN)) {
+-                imx_epit_reload_compare_timer(s);
+-                ptimer_run(s->timer_cmp, 0);
+-            }
+-        } else {
+-            ptimer_stop(s->timer_cmp);
+-        }
+-
+-        ptimer_transaction_commit(s->timer_cmp);
+-        ptimer_transaction_commit(s->timer_reload);
++        imx_epit_write_cr(s, (uint32_t)value);
+         break;
+-    case 1: /* SR - ACK*/
+-        /* writing 1 to SR.OCIF clears this bit and turns the interrupt off */
+-        if (value & SR_OCIF) {
+-            s->sr = 0; /* SR.OCIF is the only bit in this register anyway */
+-            imx_epit_update_int(s);
+-        }
++    case 1: /* SR */
++        imx_epit_write_sr(s, (uint32_t)value);
+         break;
+-    case 2: /* LR - set ticks */
+-        s->lr = value;
+-
+-        ptimer_transaction_begin(s->timer_cmp);
+-        ptimer_transaction_begin(s->timer_reload);
+-        if (s->cr & CR_RLD) {
+-            /* Also set the limit if the LRD bit is set */
+-            /* If IOVW bit is set then set the timer value */
+-            ptimer_set_limit(s->timer_reload, s->lr, s->cr & CR_IOVW);
+-            ptimer_set_limit(s->timer_cmp, s->lr, 0);
+-        } else if (s->cr & CR_IOVW) {
+-            /* If IOVW bit is set then set the timer value */
+-            ptimer_set_count(s->timer_reload, s->lr);
+-        }
+-        /*
+-         * Commit the change to s->timer_reload, so it can propagate. Otherwise
+-         * the timer interrupt may not fire properly. The commit must happen
+-         * before calling imx_epit_reload_compare_timer(), which reads
+-         * s->timer_reload internally again.
+-         */
+-        ptimer_transaction_commit(s->timer_reload);
+-        imx_epit_reload_compare_timer(s);
+-        ptimer_transaction_commit(s->timer_cmp);
++    case 2: /* LR */
++        imx_epit_write_lr(s, (uint32_t)value);
+         break;
+     case 3: /* CMP */
+-        s->cmp = value;
+-
+-        ptimer_transaction_begin(s->timer_cmp);
+-        imx_epit_reload_compare_timer(s);
+-        ptimer_transaction_commit(s->timer_cmp);
+-
++        imx_epit_write_cmp(s, (uint32_t)value);
+         break;
+     default:
+         qemu_log_mask(LOG_GUEST_ERROR, "[%s]%s: Bad register at offset 0x%"
+                       HWADDR_PRIx "\n", TYPE_IMX_EPIT, __func__, offset);
+-
+         break;
+     }
+ }
++
+ static void imx_epit_cmp(void *opaque)
+ {
+     IMXEPITState *s = IMX_EPIT(opaque);
+--
+.25.1

-New patch
+[PULL 16/34] hw/timer/imx_epit: remove explicit fields cnt and freq
+From: Axel Heider <axel.heider@hensoldt.net>
+The CNT register is a read-only register. There is no need to
+store it's value, it can be calculated on demand.
+The calculated frequency is needed temporarily only.
+Note that this is a migration compatibility break for all boards
+types that use the EPIT peripheral.
+Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
+Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+---
+ include/hw/timer/imx_epit.h |  2 -
+ hw/timer/imx_epit.c         | 73 ++++++++++++++-----------------------
+files changed, 28 insertions(+), 47 deletions(-)
+diff --git a/include/hw/timer/imx_epit.h b/include/hw/timer/imx_epit.h
+index XXXXXXX..XXXXXXX 100644
+--- a/include/hw/timer/imx_epit.h
++++ b/include/hw/timer/imx_epit.h
+@@ -XXX,XX +XXX,XX @@ struct IMXEPITState {
+     uint32_t sr;
+     uint32_t lr;
+     uint32_t cmp;
+-    uint32_t cnt;
+-    uint32_t freq;
+     qemu_irq irq;
+ };
+diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c
+index XXXXXXX..XXXXXXX 100644
+--- a/hw/timer/imx_epit.c
++++ b/hw/timer/imx_epit.c
+@@ -XXX,XX +XXX,XX @@ static void imx_epit_update_int(IMXEPITState *s)
+     }
+ }
+-/*
+- * Must be called from within a ptimer_transaction_begin/commit block
+- * for both s->timer_cmp and s->timer_reload.
+- */
+-static void imx_epit_set_freq(IMXEPITState *s)
++static uint32_t imx_epit_get_freq(IMXEPITState *s)
+ {
+-    uint32_t clksrc;
+-    uint32_t prescaler;
+-
+-    clksrc = extract32(s->cr, CR_CLKSRC_SHIFT, CR_CLKSRC_BITS);
+-    prescaler = 1 + extract32(s->cr, CR_PRESCALE_SHIFT, CR_PRESCALE_BITS);
+-
+-    s->freq = imx_ccm_get_clock_frequency(s->ccm,
+-                                imx_epit_clocks[clksrc]) / prescaler;
+-
+-    DPRINTF("Setting ptimer frequency to %u\n", s->freq);
+-
+-    if (s->freq) {
+-        ptimer_set_freq(s->timer_reload, s->freq);
+-        ptimer_set_freq(s->timer_cmp, s->freq);
+-    }
++    uint32_t clksrc = extract32(s->cr, CR_CLKSRC_SHIFT, CR_CLKSRC_BITS);
++    uint32_t prescaler = 1 + extract32(s->cr, CR_PRESCALE_SHIFT, CR_PRESCALE_BITS);
++    uint32_t f_in = imx_ccm_get_clock_frequency(s->ccm, imx_epit_clocks[clksrc]);
++    uint32_t freq = f_in / prescaler;
++    DPRINTF("ptimer frequency is %u\n", freq);
++    return freq;
+ }
+ /*
+@@ -XXX,XX +XXX,XX @@ static void imx_epit_reset(IMXEPITState *s, bool is_hard_reset)
+     s->sr = 0;
+     s->lr = EPIT_TIMER_MAX;
+     s->cmp = 0;
+-    s->cnt = 0;
+     ptimer_transaction_begin(s->timer_cmp);
+     ptimer_transaction_begin(s->timer_reload);
+-    /* stop both timers */
++
++    /*
++     * The reset switches off the input clock, so even if the CR.EN is still
++     * set, the timers are no longer running.
++     */
++    assert(imx_epit_get_freq(s) == 0);
+     ptimer_stop(s->timer_cmp);
+     ptimer_stop(s->timer_reload);
+-    /* compute new frequency */
+-    imx_epit_set_freq(s);
+     /* init both timers to EPIT_TIMER_MAX */
+     ptimer_set_limit(s->timer_cmp, EPIT_TIMER_MAX, 1);
+     ptimer_set_limit(s->timer_reload, EPIT_TIMER_MAX, 1);
+-    if (s->freq && (s->cr & CR_EN)) {
+-        /* if the timer is still enabled, restart it */
+-        ptimer_run(s->timer_reload, 0);
+-    }
+     ptimer_transaction_commit(s->timer_cmp);
+     ptimer_transaction_commit(s->timer_reload);
+ }
+-static uint32_t imx_epit_update_count(IMXEPITState *s)
+-{
+-    s->cnt = ptimer_get_count(s->timer_reload);
+-
+-    return s->cnt;
+-}
+-
+ static uint64_t imx_epit_read(void *opaque, hwaddr offset, unsigned size)
+ {
+     IMXEPITState *s = IMX_EPIT(opaque);
+@@ -XXX,XX +XXX,XX @@ static uint64_t imx_epit_read(void *opaque, hwaddr offset, unsigned size)
+         break;
+     case 4: /* CNT */
+-        imx_epit_update_count(s);
+-        reg_value = s->cnt;
++        reg_value = ptimer_get_count(s->timer_reload);
+         break;
+     default:
+@@ -XXX,XX +XXX,XX @@ static void imx_epit_reload_compare_timer(IMXEPITState *s)
+ {
+     if ((s->cr & (CR_EN | CR_OCIEN)) == (CR_EN | CR_OCIEN))  {
+         /* if the compare feature is on and timers are running */
+-        uint32_t tmp = imx_epit_update_count(s);
++        uint32_t tmp = ptimer_get_count(s->timer_reload);
+         uint64_t next;
+         if (tmp > s->cmp) {
+             /* It'll fire in this round of the timer */
+@@ -XXX,XX +XXX,XX @@ static void imx_epit_reload_compare_timer(IMXEPITState *s)
+ static void imx_epit_write_cr(IMXEPITState *s, uint32_t value)
+ {
++    uint32_t freq = 0;
+     uint32_t oldcr = s->cr;
+     s->cr = value & 0x03ffffff;
+@@ -XXX,XX +XXX,XX @@ static void imx_epit_write_cr(IMXEPITState *s, uint32_t value)
+     ptimer_transaction_begin(s->timer_cmp);
+     ptimer_transaction_begin(s->timer_reload);
+-    /* Update the frequency. Has been done already in case of a reset. */
++    /*
++     * Update the frequency. In case of a reset the input clock was
++     * switched off, so this can be skipped.
++     */
+     if (!(s->cr & CR_SWR)) {
+-        imx_epit_set_freq(s);
++        freq = imx_epit_get_freq(s);
++        if (freq) {
++            ptimer_set_freq(s->timer_reload, freq);
++            ptimer_set_freq(s->timer_cmp, freq);
++        }
+     }
+-    if (s->freq && (s->cr & CR_EN) && !(oldcr & CR_EN)) {
++    if (freq && (s->cr & CR_EN) && !(oldcr & CR_EN)) {
+         if (s->cr & CR_ENMOD) {
+             if (s->cr & CR_RLD) {
+                 ptimer_set_limit(s->timer_reload, s->lr, 1);
+@@ -XXX,XX +XXX,XX @@ static const MemoryRegionOps imx_epit_ops = {
+ static const VMStateDescription vmstate_imx_timer_epit = {
+     .name = TYPE_IMX_EPIT,
+-    .version_id = 2,
+-    .minimum_version_id = 2,
++    .version_id = 3,
++    .minimum_version_id = 3,
+     .fields = (VMStateField[]) {
+         VMSTATE_UINT32(cr, IMXEPITState),
+         VMSTATE_UINT32(sr, IMXEPITState),
+         VMSTATE_UINT32(lr, IMXEPITState),
+         VMSTATE_UINT32(cmp, IMXEPITState),
+-        VMSTATE_UINT32(cnt, IMXEPITState),
+-        VMSTATE_UINT32(freq, IMXEPITState),
+         VMSTATE_PTIMER(timer_reload, IMXEPITState),
+         VMSTATE_PTIMER(timer_cmp, IMXEPITState),
+         VMSTATE_END_OF_LIST()
+--
+.25.1

-New patch
+[PULL 17/34] hw/timer/imx_epit: fix compare timer handling
+From: Axel Heider <axel.heider@hensoldt.net>
+- fix #1263 for CR writes
+- rework compare time handling
+  - The compare timer has to run even if CR.OCIEN is not set,
+    as SR.OCIF must be updated.
+  - The compare timer fires exactly once when the
+    compare value is less than the current value, but the
+    reload values is less than the compare value.
+  - The compare timer will never fire if the reload value is
+    less than the compare value. Disable it in this case.
+Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
+[PMM: fixed minor style nits]
+Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+---
+ hw/timer/imx_epit.c | 192 ++++++++++++++++++++++++++------------------
+file changed, 116 insertions(+), 76 deletions(-)
+diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c
+index XXXXXXX..XXXXXXX 100644
+--- a/hw/timer/imx_epit.c
++++ b/hw/timer/imx_epit.c
+@@ -XXX,XX +XXX,XX @@
+  * Originally written by Hans Jiang
+  * Updated by Peter Chubb
+  * Updated by Jean-Christophe Dubois <jcd@tribudubois.net>
++ * Updated by Axel Heider
+  *
+  * This code is licensed under GPL version 2 or later.  See
+  * the COPYING file in the top-level directory.
+@@ -XXX,XX +XXX,XX @@ static uint64_t imx_epit_read(void *opaque, hwaddr offset, unsigned size)
+     return reg_value;
+ }
+-/* Must be called from ptimer_transaction_begin/commit block for s->timer_cmp */
+-static void imx_epit_reload_compare_timer(IMXEPITState *s)
++/*
++ * Must be called from a ptimer_transaction_begin/commit block for
++ * s->timer_cmp, but outside of a transaction block of s->timer_reload,
++ * so the proper counter value is read.
++ */
++static void imx_epit_update_compare_timer(IMXEPITState *s)
+ {
+-    if ((s->cr & (CR_EN | CR_OCIEN)) == (CR_EN | CR_OCIEN))  {
+-        /* if the compare feature is on and timers are running */
+-        uint32_t tmp = ptimer_get_count(s->timer_reload);
+-        uint64_t next;
+-        if (tmp > s->cmp) {
+-            /* It'll fire in this round of the timer */
+-            next = tmp - s->cmp;
+-        } else { /* catch it next time around */
+-            next = tmp - s->cmp + ((s->cr & CR_RLD) ? EPIT_TIMER_MAX : s->lr);
++    uint64_t counter = 0;
++    bool is_oneshot = false;
++    /*
++     * The compare timer only has to run if the timer peripheral is active
++     * and there is an input clock, Otherwise it can be switched off.
++     */
++    bool is_active = (s->cr & CR_EN) && imx_epit_get_freq(s);
++    if (is_active) {
++        /*
++         * Calculate next timeout for compare timer. Reading the reload
++         * counter returns proper results only if pending transactions
++         * on it are committed here. Otherwise stale values are be read.
++         */
++        counter = ptimer_get_count(s->timer_reload);
++        uint64_t limit = ptimer_get_limit(s->timer_cmp);
++        /*
++         * The compare timer is a periodic timer if the limit is at least
++         * the compare value. Otherwise it may fire at most once in the
++         * current round.
++         */
++        bool is_oneshot = (limit >= s->cmp);
++        if (counter >= s->cmp) {
++            /* The compare timer fires in the current round. */
++            counter -= s->cmp;
++        } else if (!is_oneshot) {
++            /*
++             * The compare timer fires after a reload, as it is below the
++             * compare value already in this round. Note that the counter
++             * value calculated below can be above the 32-bit limit, which
++             * is legal here because the compare timer is an internal
++             * helper ptimer only.
++             */
++            counter += limit - s->cmp;
++        } else {
++            /*
++             * The compare timer won't fire in this round, and the limit is
++             * set to a value below the compare value. This practically means
++             * it will never fire, so it can be switched off.
++             */
++            is_active = false;
+         }
+-        ptimer_set_count(s->timer_cmp, next);
+     }
++
++    /*
++     * Set the compare timer and let it run, or stop it. This is agnostic
++     * of CR.OCIEN bit, as this bit affects interrupt generation only. The
++     * compare timer needs to run even if no interrupts are to be generated,
++     * because the SR.OCIF bit must be updated also.
++     * Note that the timer might already be stopped or be running with
++     * counter values. However, finding out when an update is needed and
++     * when not is not trivial. It's much easier applying the setting again,
++     * as this does not harm either and the overhead is negligible.
++     */
++    if (is_active) {
++        ptimer_set_count(s->timer_cmp, counter);
++        ptimer_run(s->timer_cmp, is_oneshot ? 1 : 0);
++    } else {
++        ptimer_stop(s->timer_cmp);
++    }
++
+ }
+ static void imx_epit_write_cr(IMXEPITState *s, uint32_t value)
+ {
+-    uint32_t freq = 0;
+     uint32_t oldcr = s->cr;
+     s->cr = value & 0x03ffffff;
+     if (s->cr & CR_SWR) {
+-        /* handle the reset */
++        /*
++         * Reset clears CR.SWR again. It does not touch CR.EN, but the timers
++         * are still stopped because the input clock is disabled.
++         */
+         imx_epit_reset(s, false);
++    } else {
++        uint32_t freq;
++        uint32_t toggled_cr_bits = oldcr ^ s->cr;
++        /* re-initialize the limits if CR.RLD has changed */
++        bool set_limit = toggled_cr_bits & CR_RLD;
++        /* set the counter if the timer got just enabled and CR.ENMOD is set */
++        bool is_switched_on = (toggled_cr_bits & s->cr) & CR_EN;
++        bool set_counter = is_switched_on && (s->cr & CR_ENMOD);
++
++        ptimer_transaction_begin(s->timer_cmp);
++        ptimer_transaction_begin(s->timer_reload);
++        freq = imx_epit_get_freq(s);
++        if (freq) {
++            ptimer_set_freq(s->timer_reload, freq);
++            ptimer_set_freq(s->timer_cmp, freq);
++        }
++
++        if (set_limit || set_counter) {
++            uint64_t limit = (s->cr & CR_RLD) ? s->lr : EPIT_TIMER_MAX;
++            ptimer_set_limit(s->timer_reload, limit, set_counter ? 1 : 0);
++            if (set_limit) {
++                ptimer_set_limit(s->timer_cmp, limit, 0);
++            }
++        }
++        /*
++         * If there is an input clock and the peripheral is enabled, then
++         * ensure the wall clock timer is ticking. Otherwise stop the timers.
++         * The compare timer will be updated later.
++         */
++        if (freq && (s->cr & CR_EN)) {
++            ptimer_run(s->timer_reload, 0);
++        } else {
++            ptimer_stop(s->timer_reload);
++        }
++        /* Commit changes to reload timer, so they can propagate. */
++        ptimer_transaction_commit(s->timer_reload);
++        /* Update compare timer based on the committed reload timer value. */
++        imx_epit_update_compare_timer(s);
++        ptimer_transaction_commit(s->timer_cmp);
+     }
+     /*
+@@ -XXX,XX +XXX,XX @@ static void imx_epit_write_cr(IMXEPITState *s, uint32_t value)
+      * - write to CR.EN or CR.OCIE
+      */
+     imx_epit_update_int(s);
+-
+-    /*
+-     * TODO: could we 'break' here for reset? following operations appear
+-     * to duplicate the work imx_epit_reset() already did.
+-     */
+-
+-    ptimer_transaction_begin(s->timer_cmp);
+-    ptimer_transaction_begin(s->timer_reload);
+-
+-    /*
+-     * Update the frequency. In case of a reset the input clock was
+-     * switched off, so this can be skipped.
+-     */
+-    if (!(s->cr & CR_SWR)) {
+-        freq = imx_epit_get_freq(s);
+-        if (freq) {
+-            ptimer_set_freq(s->timer_reload, freq);
+-            ptimer_set_freq(s->timer_cmp, freq);
+-        }
+-    }
+-
+-    if (freq && (s->cr & CR_EN) && !(oldcr & CR_EN)) {
+-        if (s->cr & CR_ENMOD) {
+-            if (s->cr & CR_RLD) {
+-                ptimer_set_limit(s->timer_reload, s->lr, 1);
+-                ptimer_set_limit(s->timer_cmp, s->lr, 1);
+-            } else {
+-                ptimer_set_limit(s->timer_reload, EPIT_TIMER_MAX, 1);
+-                ptimer_set_limit(s->timer_cmp, EPIT_TIMER_MAX, 1);
+-            }
+-        }
+-
+-        imx_epit_reload_compare_timer(s);
+-        ptimer_run(s->timer_reload, 0);
+-        if (s->cr & CR_OCIEN) {
+-            ptimer_run(s->timer_cmp, 0);
+-        } else {
+-            ptimer_stop(s->timer_cmp);
+-        }
+-    } else if (!(s->cr & CR_EN)) {
+-        /* stop both timers */
+-        ptimer_stop(s->timer_reload);
+-        ptimer_stop(s->timer_cmp);
+-    } else  if (s->cr & CR_OCIEN) {
+-        if (!(oldcr & CR_OCIEN)) {
+-            imx_epit_reload_compare_timer(s);
+-            ptimer_run(s->timer_cmp, 0);
+-        }
+-    } else {
+-        ptimer_stop(s->timer_cmp);
+-    }
+-
+-    ptimer_transaction_commit(s->timer_cmp);
+-    ptimer_transaction_commit(s->timer_reload);
+ }
+ static void imx_epit_write_sr(IMXEPITState *s, uint32_t value)
+@@ -XXX,XX +XXX,XX @@ static void imx_epit_write_lr(IMXEPITState *s, uint32_t value)
+         /* If IOVW bit is set then set the timer value */
+         ptimer_set_count(s->timer_reload, s->lr);
+     }
+-    /*
+-     * Commit the change to s->timer_reload, so it can propagate. Otherwise
+-     * the timer interrupt may not fire properly. The commit must happen
+-     * before calling imx_epit_reload_compare_timer(), which reads
+-     * s->timer_reload internally again.
+-     */
++    /* Commit the changes to s->timer_reload, so they can propagate. */
+     ptimer_transaction_commit(s->timer_reload);
+-    imx_epit_reload_compare_timer(s);
++    /* Update the compare timer based on the committed reload timer value. */
++    imx_epit_update_compare_timer(s);
+     ptimer_transaction_commit(s->timer_cmp);
+ }
+@@ -XXX,XX +XXX,XX @@ static void imx_epit_write_cmp(IMXEPITState *s, uint32_t value)
+ {
+     s->cmp = value;
++    /* Update the compare timer based on the committed reload timer value. */
+     ptimer_transaction_begin(s->timer_cmp);
+-    imx_epit_reload_compare_timer(s);
++    imx_epit_update_compare_timer(s);
+     ptimer_transaction_commit(s->timer_cmp);
+ }
+@@ -XXX,XX +XXX,XX @@ static void imx_epit_cmp(void *opaque)
+ {
+     IMXEPITState *s = IMX_EPIT(opaque);
++    /* The cmp ptimer can't be running when the peripheral is disabled */
++    assert(s->cr & CR_EN);
++
+     DPRINTF("sr was %d\n", s->sr);
+     /* Set interrupt status bit SR.OCIF and update the interrupt state */
+     s->sr |= SR_OCIF;
+--
+.25.1

-New patch
+[PULL 18/34] target/arm: Fix checkpatch comment style warnings in helper.c
+From: Fabiano Rosas <farosas@suse.de>
+Fix these:
+WARNING: Block comments use a leading /* on a separate line
+WARNING: Block comments use * on subsequent lines
+WARNING: Block comments use a trailing */ on a separate line
+Signed-off-by: Fabiano Rosas <farosas@suse.de>
+Reviewed-by: Claudio Fontana <cfontana@suse.de>
+Reviewed-by: Cornelia Huck <cohuck@redhat.com>
+Message-id: 20221213190537.511-2-farosas@suse.de
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+---
+ target/arm/helper.c | 323 +++++++++++++++++++++++++++++---------------
+file changed, 215 insertions(+), 108 deletions(-)
+diff --git a/target/arm/helper.c b/target/arm/helper.c
+index XXXXXXX..XXXXXXX 100644
+--- a/target/arm/helper.c
++++ b/target/arm/helper.c
+@@ -XXX,XX +XXX,XX @@ uint64_t read_raw_cp_reg(CPUARMState *env, const ARMCPRegInfo *ri)
+ static void write_raw_cp_reg(CPUARMState *env, const ARMCPRegInfo *ri,
+                              uint64_t v)
+ {
+-    /* Raw write of a coprocessor register (as needed for migration, etc).
++    /*
++     * Raw write of a coprocessor register (as needed for migration, etc).
+      * Note that constant registers are treated as write-ignored; the
+      * caller should check for success by whether a readback gives the
+      * value written.
+@@ -XXX,XX +XXX,XX @@ static void write_raw_cp_reg(CPUARMState *env, const ARMCPRegInfo *ri,
+ static bool raw_accessors_invalid(const ARMCPRegInfo *ri)
+ {
+-   /* Return true if the regdef would cause an assertion if you called
++   /*
++    * Return true if the regdef would cause an assertion if you called
+     * read_raw_cp_reg() or write_raw_cp_reg() on it (ie if it is a
+     * program bug for it not to have the NO_RAW flag).
+     * NB that returning false here doesn't necessarily mean that calling
+@@ -XXX,XX +XXX,XX @@ bool write_list_to_cpustate(ARMCPU *cpu)
+         if (ri->type & ARM_CP_NO_RAW) {
+             continue;
+         }
+-        /* Write value and confirm it reads back as written
++        /*
++         * Write value and confirm it reads back as written
+          * (to catch read-only registers and partially read-only
+          * registers where the incoming migration value doesn't match)
+          */
+@@ -XXX,XX +XXX,XX @@ static gint cpreg_key_compare(gconstpointer a, gconstpointer b)
+ void init_cpreg_list(ARMCPU *cpu)
+ {
+-    /* Initialise the cpreg_tuples[] array based on the cp_regs hash.
++    /*
++     * Initialise the cpreg_tuples[] array based on the cp_regs hash.
+      * Note that we require cpreg_tuples[] to be sorted by key ID.
+      */
+     GList *keys;
+@@ -XXX,XX +XXX,XX @@ static CPAccessResult access_el3_aa32ns(CPUARMState *env,
+     return CP_ACCESS_OK;
+ }
+-/* Some secure-only AArch32 registers trap to EL3 if used from
++/*
++ * Some secure-only AArch32 registers trap to EL3 if used from
+  * Secure EL1 (but are just ordinary UNDEF in other non-EL3 contexts).
+  * Note that an access from Secure EL1 can only happen if EL3 is AArch64.
+  * We assume that the .access field is set to PL1_RW.
+@@ -XXX,XX +XXX,XX @@ static CPAccessResult access_trap_aa32s_el1(CPUARMState *env,
+     return CP_ACCESS_TRAP_UNCATEGORIZED;
+ }
+-/* Check for traps to performance monitor registers, which are controlled
++/*
++ * Check for traps to performance monitor registers, which are controlled
+  * by MDCR_EL2.TPM for EL2 and MDCR_EL3.TPM for EL3.
+  */
+ static CPAccessResult access_tpm(CPUARMState *env, const ARMCPRegInfo *ri,
+@@ -XXX,XX +XXX,XX @@ static void fcse_write(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t value)
+     ARMCPU *cpu = env_archcpu(env);
+     if (raw_read(env, ri) != value) {
+-        /* Unlike real hardware the qemu TLB uses virtual addresses,
++        /*
++         * Unlike real hardware the qemu TLB uses virtual addresses,
+          * not modified virtual addresses, so this causes a TLB flush.
+          */
+         tlb_flush(CPU(cpu));
+@@ -XXX,XX +XXX,XX @@ static void contextidr_write(CPUARMState *env, const ARMCPRegInfo *ri,
+     if (raw_read(env, ri) != value && !arm_feature(env, ARM_FEATURE_PMSA)
+         && !extended_addresses_enabled(env)) {
+-        /* For VMSA (when not using the LPAE long descriptor page table
++        /*
++         * For VMSA (when not using the LPAE long descriptor page table
+          * format) this register includes the ASID, so do a TLB flush.
+          * For PMSA it is purely a process ID and no action is needed.
+          */
+@@ -XXX,XX +XXX,XX @@ static void tlbiipas2is_hyp_write(CPUARMState *env, const ARMCPRegInfo *ri,
+ }
+ static const ARMCPRegInfo cp_reginfo[] = {
+-    /* Define the secure and non-secure FCSE identifier CP registers
++    /*
++     * Define the secure and non-secure FCSE identifier CP registers
+      * separately because there is no secure bank in V8 (no _EL3).  This allows
+      * the secure register to be properly reset and migrated. There is also no
+      * v8 EL1 version of the register so the non-secure instance stands alone.
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo cp_reginfo[] = {
+       .access = PL1_RW, .secure = ARM_CP_SECSTATE_S,
+       .fieldoffset = offsetof(CPUARMState, cp15.fcseidr_s),
+       .resetvalue = 0, .writefn = fcse_write, .raw_writefn = raw_write, },
+-    /* Define the secure and non-secure context identifier CP registers
++    /*
++     * Define the secure and non-secure context identifier CP registers
+      * separately because there is no secure bank in V8 (no _EL3).  This allows
+      * the secure register to be properly reset and migrated.  In the
+      * non-secure case, the 32-bit register will have reset and migration
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo cp_reginfo[] = {
+ };
+ static const ARMCPRegInfo not_v8_cp_reginfo[] = {
+-    /* NB: Some of these registers exist in v8 but with more precise
++    /*
++     * NB: Some of these registers exist in v8 but with more precise
+      * definitions that don't use CP_ANY wildcards (mostly in v8_cp_reginfo[]).
+      */
+     /* MMU Domain access control / MPU write buffer control */
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo not_v8_cp_reginfo[] = {
+       .writefn = dacr_write, .raw_writefn = raw_write,
+       .bank_fieldoffsets = { offsetoflow32(CPUARMState, cp15.dacr_s),
+                              offsetoflow32(CPUARMState, cp15.dacr_ns) } },
+-    /* ARMv7 allocates a range of implementation defined TLB LOCKDOWN regs.
++    /*
++     * ARMv7 allocates a range of implementation defined TLB LOCKDOWN regs.
+      * For v6 and v5, these mappings are overly broad.
+      */
+     { .name = "TLB_LOCKDOWN", .cp = 15, .crn = 10, .crm = 0,
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo not_v8_cp_reginfo[] = {
+ };
+ static const ARMCPRegInfo not_v6_cp_reginfo[] = {
+-    /* Not all pre-v6 cores implemented this WFI, so this is slightly
++    /*
++     * Not all pre-v6 cores implemented this WFI, so this is slightly
+      * over-broad.
+      */
+     { .name = "WFI_v5", .cp = 15, .crn = 7, .crm = 8, .opc1 = 0, .opc2 = 2,
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo not_v6_cp_reginfo[] = {
+ };
+ static const ARMCPRegInfo not_v7_cp_reginfo[] = {
+-    /* Standard v6 WFI (also used in some pre-v6 cores); not in v7 (which
++    /*
++     * Standard v6 WFI (also used in some pre-v6 cores); not in v7 (which
+      * is UNPREDICTABLE; we choose to NOP as most implementations do).
+      */
+     { .name = "WFI_v6", .cp = 15, .crn = 7, .crm = 0, .opc1 = 0, .opc2 = 4,
+       .access = PL1_W, .type = ARM_CP_WFI },
+-    /* L1 cache lockdown. Not architectural in v6 and earlier but in practice
++    /*
++     * L1 cache lockdown. Not architectural in v6 and earlier but in practice
+      * implemented in 926, 946, 1026, 1136, 1176 and 11MPCore. StrongARM and
+      * OMAPCP will override this space.
+      */
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo not_v7_cp_reginfo[] = {
+     { .name = "DUMMY", .cp = 15, .crn = 0, .crm = 0, .opc1 = 1, .opc2 = CP_ANY,
+       .access = PL1_R, .type = ARM_CP_CONST | ARM_CP_NO_RAW,
+       .resetvalue = 0 },
+-    /* We don't implement pre-v7 debug but most CPUs had at least a DBGDIDR;
++    /*
++     * We don't implement pre-v7 debug but most CPUs had at least a DBGDIDR;
+      * implementing it as RAZ means the "debug architecture version" bits
+      * will read as a reserved value, which should cause Linux to not try
+      * to use the debug hardware.
+      */
+     { .name = "DBGDIDR", .cp = 14, .crn = 0, .crm = 0, .opc1 = 0, .opc2 = 0,
+       .access = PL0_R, .type = ARM_CP_CONST, .resetvalue = 0 },
+-    /* MMU TLB control. Note that the wildcarding means we cover not just
++    /*
++     * MMU TLB control. Note that the wildcarding means we cover not just
+      * the unified TLB ops but also the dside/iside/inner-shareable variants.
+      */
+     { .name = "TLBIALL", .cp = 15, .crn = 8, .crm = CP_ANY,
+@@ -XXX,XX +XXX,XX @@ static void cpacr_write(CPUARMState *env, const ARMCPRegInfo *ri,
+     /* In ARMv8 most bits of CPACR_EL1 are RES0. */
+     if (!arm_feature(env, ARM_FEATURE_V8)) {
+-        /* ARMv7 defines bits for unimplemented coprocessors as RAZ/WI.
++        /*
++         * ARMv7 defines bits for unimplemented coprocessors as RAZ/WI.
+          * ASEDIS [31] and D32DIS [30] are both UNK/SBZP without VFP.
+          * TRCDIS [28] is RAZ/WI since we do not implement a trace macrocell.
+          */
+@@ -XXX,XX +XXX,XX @@ static void cpacr_write(CPUARMState *env, const ARMCPRegInfo *ri,
+                 value |= R_CPACR_ASEDIS_MASK;
+             }
+-            /* VFPv3 and upwards with NEON implement 32 double precision
++            /*
++             * VFPv3 and upwards with NEON implement 32 double precision
+              * registers (D0-D31).
+              */
+             if (!cpu_isar_feature(aa32_simd_r32, env_archcpu(env))) {
+@@ -XXX,XX +XXX,XX @@ static uint64_t cpacr_read(CPUARMState *env, const ARMCPRegInfo *ri)
+ static void cpacr_reset(CPUARMState *env, const ARMCPRegInfo *ri)
+ {
+-    /* Call cpacr_write() so that we reset with the correct RAO bits set
++    /*
++     * Call cpacr_write() so that we reset with the correct RAO bits set
+      * for our CPU features.
+      */
+     cpacr_write(env, ri, 0);
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo v6_cp_reginfo[] = {
+     { .name = "MVA_prefetch",
+       .cp = 15, .crn = 7, .crm = 13, .opc1 = 0, .opc2 = 1,
+       .access = PL1_W, .type = ARM_CP_NOP },
+-    /* We need to break the TB after ISB to execute self-modifying code
++    /*
++     * We need to break the TB after ISB to execute self-modifying code
+      * correctly and also to take any pending interrupts immediately.
+      * So use arm_cp_write_ignore() function instead of ARM_CP_NOP flag.
+      */
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo v6_cp_reginfo[] = {
+       .bank_fieldoffsets = { offsetof(CPUARMState, cp15.ifar_s),
+                              offsetof(CPUARMState, cp15.ifar_ns) },
+       .resetvalue = 0, },
+-    /* Watchpoint Fault Address Register : should actually only be present
++    /*
++     * Watchpoint Fault Address Register : should actually only be present
+      * for 1136, 1176, 11MPCore.
+      */
+     { .name = "WFAR", .cp = 15, .crn = 6, .crm = 0, .opc1 = 0, .opc2 = 1,
+@@ -XXX,XX +XXX,XX @@ static bool event_supported(uint16_t number)
+ static CPAccessResult pmreg_access(CPUARMState *env, const ARMCPRegInfo *ri,
+                                    bool isread)
+ {
+-    /* Performance monitor registers user accessibility is controlled
++    /*
++     * Performance monitor registers user accessibility is controlled
+      * by PMUSERENR. MDCR_EL2.TPM and MDCR_EL3.TPM allow configurable
+      * trapping to EL2 or EL3 for other accesses.
+      */
+@@ -XXX,XX +XXX,XX @@ static CPAccessResult pmreg_access_ccntr(CPUARMState *env,
+     (MDCR_HPME | MDCR_HPMD | MDCR_HPMN | MDCR_HCCD | MDCR_HLP)
+ #define MDCR_EL3_PMU_ENABLE_BITS (MDCR_SPME | MDCR_SCCD)
+-/* Returns true if the counter (pass 31 for PMCCNTR) should count events using
++/*
++ * Returns true if the counter (pass 31 for PMCCNTR) should count events using
+  * the current EL, security state, and register configuration.
+  */
+ static bool pmu_counter_enabled(CPUARMState *env, uint8_t counter)
+@@ -XXX,XX +XXX,XX @@ static uint64_t pmccntr_read(CPUARMState *env, const ARMCPRegInfo *ri)
+ static void pmselr_write(CPUARMState *env, const ARMCPRegInfo *ri,
+                          uint64_t value)
+ {
+-    /* The value of PMSELR.SEL affects the behavior of PMXEVTYPER and
++    /*
++     * The value of PMSELR.SEL affects the behavior of PMXEVTYPER and
+      * PMXEVCNTR. We allow [0..31] to be written to PMSELR here; in the
+      * meanwhile, we check PMSELR.SEL when PMXEVTYPER and PMXEVCNTR are
+      * accessed.
+@@ -XXX,XX +XXX,XX @@ static void pmevtyper_write(CPUARMState *env, const ARMCPRegInfo *ri,
+         env->cp15.c14_pmevtyper[counter] = value & PMXEVTYPER_MASK;
+         pmevcntr_op_finish(env, counter);
+     }
+-    /* Attempts to access PMXEVTYPER are CONSTRAINED UNPREDICTABLE when
++    /*
++     * Attempts to access PMXEVTYPER are CONSTRAINED UNPREDICTABLE when
+      * PMSELR value is equal to or greater than the number of implemented
+      * counters, but not equal to 0x1f. We opt to behave as a RAZ/WI.
+      */
+@@ -XXX,XX +XXX,XX @@ static uint64_t pmevcntr_read(CPUARMState *env, const ARMCPRegInfo *ri,
+         }
+         return ret;
+     } else {
+-      /* We opt to behave as a RAZ/WI when attempts to access PM[X]EVCNTR
+-       * are CONSTRAINED UNPREDICTABLE. */
++      /*
++       * We opt to behave as a RAZ/WI when attempts to access PM[X]EVCNTR
++       * are CONSTRAINED UNPREDICTABLE.
++       */
+         return 0;
+     }
+ }
+@@ -XXX,XX +XXX,XX @@ static void pmintenclr_write(CPUARMState *env, const ARMCPRegInfo *ri,
+ static void vbar_write(CPUARMState *env, const ARMCPRegInfo *ri,
+                        uint64_t value)
+ {
+-    /* Note that even though the AArch64 view of this register has bits
++    /*
++     * Note that even though the AArch64 view of this register has bits
+      * [10:0] all RES0 we can only mask the bottom 5, to comply with the
+      * architectural requirements for bits which are RES0 only in some
+      * contexts. (ARMv8 would permit us to do no masking at all, but ARMv7
+@@ -XXX,XX +XXX,XX @@ static void scr_write(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t value)
+     if (!arm_feature(env, ARM_FEATURE_EL2)) {
+         valid_mask &= ~SCR_HCE;
+-        /* On ARMv7, SMD (or SCD as it is called in v7) is only
++        /*
++         * On ARMv7, SMD (or SCD as it is called in v7) is only
+          * supported if EL2 exists. The bit is UNK/SBZP when
+          * EL2 is unavailable. In QEMU ARMv7, we force it to always zero
+          * when EL2 is unavailable.
+@@ -XXX,XX +XXX,XX @@ static uint64_t ccsidr_read(CPUARMState *env, const ARMCPRegInfo *ri)
+ {
+     ARMCPU *cpu = env_archcpu(env);
+-    /* Acquire the CSSELR index from the bank corresponding to the CCSIDR
++    /*
++     * Acquire the CSSELR index from the bank corresponding to the CCSIDR
+      * bank
+      */
+     uint32_t index = A32_BANKED_REG_GET(env, csselr,
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo v7_cp_reginfo[] = {
+     /* the old v6 WFI, UNPREDICTABLE in v7 but we choose to NOP */
+     { .name = "NOP", .cp = 15, .crn = 7, .crm = 0, .opc1 = 0, .opc2 = 4,
+       .access = PL1_W, .type = ARM_CP_NOP },
+-    /* Performance monitors are implementation defined in v7,
++    /*
++     * Performance monitors are implementation defined in v7,
+      * but with an ARM recommended set of registers, which we
+      * follow.
+      *
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo v7_cp_reginfo[] = {
+       .writefn = csselr_write, .resetvalue = 0,
+       .bank_fieldoffsets = { offsetof(CPUARMState, cp15.csselr_s),
+                              offsetof(CPUARMState, cp15.csselr_ns) } },
+-    /* Auxiliary ID register: this actually has an IMPDEF value but for now
++    /*
++     * Auxiliary ID register: this actually has an IMPDEF value but for now
+      * just RAZ for all cores:
+      */
+     { .name = "AIDR", .state = ARM_CP_STATE_BOTH,
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo v7_cp_reginfo[] = {
+       .access = PL1_R, .type = ARM_CP_CONST,
+       .accessfn = access_aa64_tid1,
+       .resetvalue = 0 },
+-    /* Auxiliary fault status registers: these also are IMPDEF, and we
++    /*
++     * Auxiliary fault status registers: these also are IMPDEF, and we
+      * choose to RAZ/WI for all cores.
+      */
+     { .name = "AFSR0_EL1", .state = ARM_CP_STATE_BOTH,
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo v7_cp_reginfo[] = {
+       .opc0 = 3, .opc1 = 0, .crn = 5, .crm = 1, .opc2 = 1,
+       .access = PL1_RW, .accessfn = access_tvm_trvm,
+       .type = ARM_CP_CONST, .resetvalue = 0 },
+-    /* MAIR can just read-as-written because we don't implement caches
++    /*
++     * MAIR can just read-as-written because we don't implement caches
+      * and so don't need to care about memory attributes.
+      */
+     { .name = "MAIR_EL1", .state = ARM_CP_STATE_AA64,
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo v7_cp_reginfo[] = {
+       .opc0 = 3, .opc1 = 6, .crn = 10, .crm = 2, .opc2 = 0,
+       .access = PL3_RW, .fieldoffset = offsetof(CPUARMState, cp15.mair_el[3]),
+       .resetvalue = 0 },
+-    /* For non-long-descriptor page tables these are PRRR and NMRR;
++    /*
++     * For non-long-descriptor page tables these are PRRR and NMRR;
+      * regardless they still act as reads-as-written for QEMU.
+      */
+-     /* MAIR0/1 are defined separately from their 64-bit counterpart which
++     /*
++      * MAIR0/1 are defined separately from their 64-bit counterpart which
+       * allows them to assign the correct fieldoffset based on the endianness
+       * handled in the field definitions.
+       */
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo v6k_cp_reginfo[] = {
+ static CPAccessResult gt_cntfrq_access(CPUARMState *env, const ARMCPRegInfo *ri,
+                                        bool isread)
+ {
+-    /* CNTFRQ: not visible from PL0 if both PL0PCTEN and PL0VCTEN are zero.
++    /*
++     * CNTFRQ: not visible from PL0 if both PL0PCTEN and PL0VCTEN are zero.
+      * Writable only at the highest implemented exception level.
+      */
+     int el = arm_current_el(env);
+@@ -XXX,XX +XXX,XX @@ static CPAccessResult gt_stimer_access(CPUARMState *env,
+                                        const ARMCPRegInfo *ri,
+                                        bool isread)
+ {
+-    /* The AArch64 register view of the secure physical timer is
++    /*
++     * The AArch64 register view of the secure physical timer is
+      * always accessible from EL3, and configurably accessible from
+      * Secure EL1.
+      */
+@@ -XXX,XX +XXX,XX @@ static void gt_recalc_timer(ARMCPU *cpu, int timeridx)
+     ARMGenericTimer *gt = &cpu->env.cp15.c14_timer[timeridx];
+     if (gt->ctl & 1) {
+-        /* Timer enabled: calculate and set current ISTATUS, irq, and
++        /*
++         * Timer enabled: calculate and set current ISTATUS, irq, and
+          * reset timer to when ISTATUS next has to change
+          */
+         uint64_t offset = timeridx == GTIMER_VIRT ?
+@@ -XXX,XX +XXX,XX @@ static void gt_recalc_timer(ARMCPU *cpu, int timeridx)
+             /* Next transition is when we hit cval */
+             nexttick = gt->cval + offset;
+         }
+-        /* Note that the desired next expiry time might be beyond the
++        /*
++         * Note that the desired next expiry time might be beyond the
+          * signed-64-bit range of a QEMUTimer -- in this case we just
+          * set the timer for as far in the future as possible. When the
+          * timer expires we will reset the timer for any remaining period.
+@@ -XXX,XX +XXX,XX @@ static void gt_ctl_write(CPUARMState *env, const ARMCPRegInfo *ri,
+         /* Enable toggled */
+         gt_recalc_timer(cpu, timeridx);
+     } else if ((oldval ^ value) & 2) {
+-        /* IMASK toggled: don't need to recalculate,
++        /*
++         * IMASK toggled: don't need to recalculate,
+          * just set the interrupt line based on ISTATUS
+          */
+         int irqstate = (oldval & 4) && !(value & 2);
+@@ -XXX,XX +XXX,XX @@ static void arm_gt_cntfrq_reset(CPUARMState *env, const ARMCPRegInfo *opaque)
+ }
+ static const ARMCPRegInfo generic_timer_cp_reginfo[] = {
+-    /* Note that CNTFRQ is purely reads-as-written for the benefit
++    /*
++     * Note that CNTFRQ is purely reads-as-written for the benefit
+      * of software; writing it doesn't actually change the timer frequency.
+      * Our reset value matches the fixed frequency we implement the timer at.
+      */
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo generic_timer_cp_reginfo[] = {
+       .readfn = gt_virt_redir_cval_read, .raw_readfn = raw_read,
+       .writefn = gt_virt_redir_cval_write, .raw_writefn = raw_write,
+     },
+-    /* Secure timer -- this is actually restricted to only EL3
++    /*
++     * Secure timer -- this is actually restricted to only EL3
+      * and configurably Secure-EL1 via the accessfn.
+      */
+     { .name = "CNTPS_TVAL_EL1", .state = ARM_CP_STATE_AA64,
+@@ -XXX,XX +XXX,XX @@ static CPAccessResult e2h_access(CPUARMState *env, const ARMCPRegInfo *ri,
+ #else
+-/* In user-mode most of the generic timer registers are inaccessible
++/*
++ * In user-mode most of the generic timer registers are inaccessible
+  * however modern kernels (4.12+) allow access to cntvct_el0
+  */
+@@ -XXX,XX +XXX,XX @@ static uint64_t gt_virt_cnt_read(CPUARMState *env, const ARMCPRegInfo *ri)
+ {
+     ARMCPU *cpu = env_archcpu(env);
+-    /* Currently we have no support for QEMUTimer in linux-user so we
++    /*
++     * Currently we have no support for QEMUTimer in linux-user so we
+      * can't call gt_get_countervalue(env), instead we directly
+      * call the lower level functions.
+      */
+@@ -XXX,XX +XXX,XX @@ static CPAccessResult ats_access(CPUARMState *env, const ARMCPRegInfo *ri,
+                                  bool isread)
+ {
+     if (ri->opc2 & 4) {
+-        /* The ATS12NSO* operations must trap to EL3 or EL2 if executed in
++        /*
++         * The ATS12NSO* operations must trap to EL3 or EL2 if executed in
+          * Secure EL1 (which can only happen if EL3 is AArch64).
+          * They are simply UNDEF if executed from NS EL1.
+          * They function normally from EL2 or EL3.
+@@ -XXX,XX +XXX,XX @@ static uint64_t do_ats_write(CPUARMState *env, uint64_t value,
+             }
+         }
+     } else {
+-        /* fsr is a DFSR/IFSR value for the short descriptor
++        /*
++         * fsr is a DFSR/IFSR value for the short descriptor
+          * translation table format (with WnR always clear).
+          * Convert it to a 32-bit PAR.
+          */
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo pmsav8r_cp_reginfo[] = {
+ };
+ static const ARMCPRegInfo pmsav7_cp_reginfo[] = {
+-    /* Reset for all these registers is handled in arm_cpu_reset(),
++    /*
++     * Reset for all these registers is handled in arm_cpu_reset(),
+      * because the PMSAv7 is also used by M-profile CPUs, which do
+      * not register cpregs but still need the state to be reset.
+      */
+@@ -XXX,XX +XXX,XX @@ static void vmsa_ttbcr_write(CPUARMState *env, const ARMCPRegInfo *ri,
+     }
+     if (arm_feature(env, ARM_FEATURE_LPAE)) {
+-        /* With LPAE the TTBCR could result in a change of ASID
++        /*
++         * With LPAE the TTBCR could result in a change of ASID
+          * via the TTBCR.A1 bit, so do a TLB flush.
+          */
+         tlb_flush(CPU(cpu));
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo vmsa_cp_reginfo[] = {
+                              offsetoflow32(CPUARMState, cp15.tcr_el[1])} },
+ };
+-/* Note that unlike TTBCR, writing to TTBCR2 does not require flushing
++/*
++ * Note that unlike TTBCR, writing to TTBCR2 does not require flushing
+  * qemu tlbs nor adjusting cached masks.
+  */
+ static const ARMCPRegInfo ttbcr2_reginfo = {
+@@ -XXX,XX +XXX,XX @@ static void omap_wfi_write(CPUARMState *env, const ARMCPRegInfo *ri,
+ static void omap_cachemaint_write(CPUARMState *env, const ARMCPRegInfo *ri,
+                                   uint64_t value)
+ {
+-    /* On OMAP there are registers indicating the max/min index of dcache lines
++    /*
++     * On OMAP there are registers indicating the max/min index of dcache lines
+      * containing a dirty line; cache flush operations have to reset these.
+      */
+     env->cp15.c15_i_max = 0x000;
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo omap_cp_reginfo[] = {
+       .crm = 8, .opc1 = 0, .opc2 = 0, .access = PL1_RW,
+       .type = ARM_CP_NO_RAW,
+       .readfn = arm_cp_read_zero, .writefn = omap_wfi_write, },
+-    /* TODO: Peripheral port remap register:
++    /*
++     * TODO: Peripheral port remap register:
+      * On OMAP2 mcr p15, 0, rn, c15, c2, 4 sets up the interrupt controller
+      * base address at $rn & ~0xfff and map size of 0x200 << ($rn & 0xfff),
+      * when MMU is off.
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo xscale_cp_reginfo[] = {
+       .cp = 15, .crn = 1, .crm = 0, .opc1 = 0, .opc2 = 1, .access = PL1_RW,
+       .fieldoffset = offsetof(CPUARMState, cp15.c1_xscaleauxcr),
+       .resetvalue = 0, },
+-    /* XScale specific cache-lockdown: since we have no cache we NOP these
++    /*
++     * XScale specific cache-lockdown: since we have no cache we NOP these
+      * and hope the guest does not really rely on cache behaviour.
+      */
+     { .name = "XSCALE_LOCK_ICACHE_LINE",
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo xscale_cp_reginfo[] = {
+ };
+ static const ARMCPRegInfo dummy_c15_cp_reginfo[] = {
+-    /* RAZ/WI the whole crn=15 space, when we don't have a more specific
++    /*
++     * RAZ/WI the whole crn=15 space, when we don't have a more specific
+      * implementation of this implementation-defined space.
+      * Ideally this should eventually disappear in favour of actually
+      * implementing the correct behaviour for all cores.
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo cache_block_ops_cp_reginfo[] = {
+ };
+ static const ARMCPRegInfo cache_test_clean_cp_reginfo[] = {
+-    /* The cache test-and-clean instructions always return (1 << 30)
++    /*
++     * The cache test-and-clean instructions always return (1 << 30)
+      * to indicate that there are no dirty cache lines.
+      */
+     { .name = "TC_DCACHE", .cp = 15, .crn = 7, .crm = 10, .opc1 = 0, .opc2 = 3,
+@@ -XXX,XX +XXX,XX @@ static uint64_t mpidr_read_val(CPUARMState *env)
+     if (arm_feature(env, ARM_FEATURE_V7MP)) {
+         mpidr |= (1U << 31);
+-        /* Cores which are uniprocessor (non-coherent)
++        /*
++         * Cores which are uniprocessor (non-coherent)
+          * but still implement the MP extensions set
+          * bit 30. (For instance, Cortex-R5).
+          */
+@@ -XXX,XX +XXX,XX @@ static CPAccessResult access_tocu(CPUARMState *env, const ARMCPRegInfo *ri,
+     return do_cacheop_pou_access(env, HCR_TOCU | HCR_TPU);
+ }
+-/* See: D4.7.2 TLB maintenance requirements and the TLB maintenance instructions
++/*
++ * See: D4.7.2 TLB maintenance requirements and the TLB maintenance instructions
+  * Page D4-1736 (DDI0487A.b)
+  */
+@@ -XXX,XX +XXX,XX @@ static void tlbi_aa64_alle3is_write(CPUARMState *env, const ARMCPRegInfo *ri,
+ static void tlbi_aa64_vae2_write(CPUARMState *env, const ARMCPRegInfo *ri,
+                                  uint64_t value)
+ {
+-    /* Invalidate by VA, EL2
++    /*
++     * Invalidate by VA, EL2
+      * Currently handles both VAE2 and VALE2, since we don't support
+      * flush-last-level-only.
+      */
+@@ -XXX,XX +XXX,XX @@ static void tlbi_aa64_vae2_write(CPUARMState *env, const ARMCPRegInfo *ri,
+ static void tlbi_aa64_vae3_write(CPUARMState *env, const ARMCPRegInfo *ri,
+                                  uint64_t value)
+ {
+-    /* Invalidate by VA, EL3
++    /*
++     * Invalidate by VA, EL3
+      * Currently handles both VAE3 and VALE3, since we don't support
+      * flush-last-level-only.
+      */
+@@ -XXX,XX +XXX,XX @@ static void tlbi_aa64_vae1is_write(CPUARMState *env, const ARMCPRegInfo *ri,
+ static void tlbi_aa64_vae1_write(CPUARMState *env, const ARMCPRegInfo *ri,
+                                  uint64_t value)
+ {
+-    /* Invalidate by VA, EL1&0 (AArch64 version).
++    /*
++     * Invalidate by VA, EL1&0 (AArch64 version).
+      * Currently handles all of VAE1, VAAE1, VAALE1 and VALE1,
+      * since we don't support flush-for-specific-ASID-only or
+      * flush-last-level-only.
+@@ -XXX,XX +XXX,XX @@ static CPAccessResult sp_el0_access(CPUARMState *env, const ARMCPRegInfo *ri,
+                                     bool isread)
+ {
+     if (!(env->pstate & PSTATE_SP)) {
+-        /* Access to SP_EL0 is undefined if it's being used as
++        /*
++         * Access to SP_EL0 is undefined if it's being used as
+          * the stack pointer.
+          */
+         return CP_ACCESS_TRAP_UNCATEGORIZED;
+@@ -XXX,XX +XXX,XX @@ static void sctlr_write(CPUARMState *env, const ARMCPRegInfo *ri,
+     }
+     if (raw_read(env, ri) == value) {
+-        /* Skip the TLB flush if nothing actually changed; Linux likes
++        /*
++         * Skip the TLB flush if nothing actually changed; Linux likes
+          * to do a lot of pointless SCTLR writes.
+          */
+         return;
+@@ -XXX,XX +XXX,XX @@ static void mdcr_el2_write(CPUARMState *env, const ARMCPRegInfo *ri,
+ }
+ static const ARMCPRegInfo v8_cp_reginfo[] = {
+-    /* Minimal set of EL0-visible registers. This will need to be expanded
++    /*
++     * Minimal set of EL0-visible registers. This will need to be expanded
+      * significantly for system emulation of AArch64 CPUs.
+      */
+     { .name = "NZCV", .state = ARM_CP_STATE_AA64,
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo v8_cp_reginfo[] = {
+       .opc0 = 3, .opc1 = 0, .crn = 4, .crm = 0, .opc2 = 0,
+       .access = PL1_RW,
+       .fieldoffset = offsetof(CPUARMState, banked_spsr[BANK_SVC]) },
+-    /* We rely on the access checks not allowing the guest to write to the
++    /*
++     * We rely on the access checks not allowing the guest to write to the
+      * state field when SPSel indicates that it's being used as the stack
+      * pointer.
+      */
+@@ -XXX,XX +XXX,XX @@ static void do_hcr_write(CPUARMState *env, uint64_t value, uint64_t valid_mask)
+     if (arm_feature(env, ARM_FEATURE_EL3)) {
+         valid_mask &= ~HCR_HCD;
+     } else if (cpu->psci_conduit != QEMU_PSCI_CONDUIT_SMC) {
+-        /* Architecturally HCR.TSC is RES0 if EL3 is not implemented.
++        /*
++         * Architecturally HCR.TSC is RES0 if EL3 is not implemented.
+          * However, if we're using the SMC PSCI conduit then QEMU is
+          * effectively acting like EL3 firmware and so the guest at
+          * EL2 should retain the ability to prevent EL1 from being
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo el2_cp_reginfo[] = {
+       .access = PL2_W, .type = ARM_CP_NO_RAW | ARM_CP_EL3_NO_EL2_UNDEF,
+       .writefn = tlbi_aa64_vae2is_write },
+ #ifndef CONFIG_USER_ONLY
+-    /* Unlike the other EL2-related AT operations, these must
++    /*
++     * Unlike the other EL2-related AT operations, these must
+      * UNDEF from EL3 if EL2 is not implemented, which is why we
+      * define them here rather than with the rest of the AT ops.
+      */
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo el2_cp_reginfo[] = {
+       .access = PL2_W, .accessfn = at_s1e2_access,
+       .type = ARM_CP_NO_RAW | ARM_CP_RAISES_EXC | ARM_CP_EL3_NO_EL2_UNDEF,
+       .writefn = ats_write64 },
+-    /* The AArch32 ATS1H* operations are CONSTRAINED UNPREDICTABLE
++    /*
++     * The AArch32 ATS1H* operations are CONSTRAINED UNPREDICTABLE
+      * if EL2 is not implemented; we choose to UNDEF. Behaviour at EL3
+      * with SCR.NS == 0 outside Monitor mode is UNPREDICTABLE; we choose
+      * to behave as if SCR.NS was 1.
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo el2_cp_reginfo[] = {
+       .writefn = ats1h_write, .type = ARM_CP_NO_RAW | ARM_CP_RAISES_EXC },
+     { .name = "CNTHCTL_EL2", .state = ARM_CP_STATE_BOTH,
+       .opc0 = 3, .opc1 = 4, .crn = 14, .crm = 1, .opc2 = 0,
+-      /* ARMv7 requires bit 0 and 1 to reset to 1. ARMv8 defines the
++      /*
++       * ARMv7 requires bit 0 and 1 to reset to 1. ARMv8 defines the
+        * reset values as IMPDEF. We choose to reset to 3 to comply with
+        * both ARMv7 and ARMv8.
+        */
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo el2_sec_cp_reginfo[] = {
+ static CPAccessResult nsacr_access(CPUARMState *env, const ARMCPRegInfo *ri,
+                                    bool isread)
+ {
+-    /* The NSACR is RW at EL3, and RO for NS EL1 and NS EL2.
++    /*
++     * The NSACR is RW at EL3, and RO for NS EL1 and NS EL2.
+      * At Secure EL1 it traps to EL3 or EL2.
+      */
+     if (arm_current_el(env) == 3) {
+@@ -XXX,XX +XXX,XX @@ static void define_pmu_regs(ARMCPU *cpu)
+     }
+ }
+-/* We don't know until after realize whether there's a GICv3
++/*
++ * We don't know until after realize whether there's a GICv3
+  * attached, and that is what registers the gicv3 sysregs.
+  * So we have to fill in the GIC fields in ID_PFR/ID_PFR1_EL1/ID_AA64PFR0_EL1
+  * at runtime.
+@@ -XXX,XX +XXX,XX @@ static uint64_t id_aa64pfr0_read(CPUARMState *env, const ARMCPRegInfo *ri)
+ }
+ #endif
+-/* Shared logic between LORID and the rest of the LOR* registers.
++/*
++ * Shared logic between LORID and the rest of the LOR* registers.
+  * Secure state exclusion has already been dealt with.
+  */
+ static CPAccessResult access_lor_ns(CPUARMState *env,
+@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
+     define_arm_cp_regs(cpu, cp_reginfo);
+     if (!arm_feature(env, ARM_FEATURE_V8)) {
+-        /* Must go early as it is full of wildcards that may be
++        /*
++         * Must go early as it is full of wildcards that may be
+          * overridden by later definitions.
+          */
+         define_arm_cp_regs(cpu, not_v8_cp_reginfo);
+@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
+               .access = PL1_R, .type = ARM_CP_CONST,
+               .accessfn = access_aa32_tid3,
+               .resetvalue = cpu->isar.id_pfr0 },
+-            /* ID_PFR1 is not a plain ARM_CP_CONST because we don't know
++            /*
++             * ID_PFR1 is not a plain ARM_CP_CONST because we don't know
+              * the value of the GIC field until after we define these regs.
+              */
+             { .name = "ID_PFR1", .state = ARM_CP_STATE_BOTH,
+@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
+         define_arm_cp_regs(cpu, el3_regs);
+     }
+-    /* The behaviour of NSACR is sufficiently various that we don't
++    /*
++     * The behaviour of NSACR is sufficiently various that we don't
+      * try to describe it in a single reginfo:
+      *  if EL3 is 64 bit, then trap to EL3 from S EL1,
+      *     reads as constant 0xc00 from NS EL1 and NS EL2
+@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
+     if (cpu_isar_feature(aa32_jazelle, cpu)) {
+         define_arm_cp_regs(cpu, jazelle_regs);
+     }
+-    /* Slightly awkwardly, the OMAP and StrongARM cores need all of
++    /*
++     * Slightly awkwardly, the OMAP and StrongARM cores need all of
+      * cp15 crn=0 to be writes-ignored, whereas for other cores they should
+      * be read-only (ie write causes UNDEF exception).
+      */
+     {
+         ARMCPRegInfo id_pre_v8_midr_cp_reginfo[] = {
+-            /* Pre-v8 MIDR space.
++            /*
++             * Pre-v8 MIDR space.
+              * Note that the MIDR isn't a simple constant register because
+              * of the TI925 behaviour where writes to another register can
+              * cause the MIDR value to change.
+@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
+         if (arm_feature(env, ARM_FEATURE_OMAPCP) ||
+             arm_feature(env, ARM_FEATURE_STRONGARM)) {
+             size_t i;
+-            /* Register the blanket "writes ignored" value first to cover the
++            /*
++             * Register the blanket "writes ignored" value first to cover the
+              * whole space. Then update the specific ID registers to allow write
+              * access, so that they ignore writes rather than causing them to
+              * UNDEF.
+@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
+             .raw_writefn = raw_write,
+         };
+         if (arm_feature(env, ARM_FEATURE_XSCALE)) {
+-            /* Normally we would always end the TB on an SCTLR write, but Linux
++            /*
++             * Normally we would always end the TB on an SCTLR write, but Linux
+              * arch/arm/mach-pxa/sleep.S expects two instructions following
+              * an MMU enable to execute from cache.  Imitate this behaviour.
+              */
+@@ -XXX,XX +XXX,XX @@ static void add_cpreg_to_hashtable(ARMCPU *cpu, const ARMCPRegInfo *r,
+ void define_one_arm_cp_reg_with_opaque(ARMCPU *cpu,
+                                        const ARMCPRegInfo *r, void *opaque)
+ {
+-    /* Define implementations of coprocessor registers.
++    /*
++     * Define implementations of coprocessor registers.
+      * We store these in a hashtable because typically
+      * there are less than 150 registers in a space which
+      * is 16*16*16*8*8 = 262144 in size.
+@@ -XXX,XX +XXX,XX @@ void define_one_arm_cp_reg_with_opaque(ARMCPU *cpu,
+     default:
+         g_assert_not_reached();
+     }
+-    /* The AArch64 pseudocode CheckSystemAccess() specifies that op1
++    /*
++     * The AArch64 pseudocode CheckSystemAccess() specifies that op1
+      * encodes a minimum access level for the register. We roll this
+      * runtime check into our general permission check code, so check
+      * here that the reginfo's specified permissions are strict enough
+@@ -XXX,XX +XXX,XX @@ void define_one_arm_cp_reg_with_opaque(ARMCPU *cpu,
+         assert((r->access & ~mask) == 0);
+     }
+-    /* Check that the register definition has enough info to handle
++    /*
++     * Check that the register definition has enough info to handle
+      * reads and writes if they are permitted.
+      */
+     if (!(r->type & (ARM_CP_SPECIAL_MASK | ARM_CP_CONST))) {
+@@ -XXX,XX +XXX,XX @@ void define_one_arm_cp_reg_with_opaque(ARMCPU *cpu,
+                         continue;
+                     }
+                     if (state == ARM_CP_STATE_AA32) {
+-                        /* Under AArch32 CP registers can be common
++                        /*
++                         * Under AArch32 CP registers can be common
+                          * (same for secure and non-secure world) or banked.
+                          */
+                         char *name;
+@@ -XXX,XX +XXX,XX @@ void define_one_arm_cp_reg_with_opaque(ARMCPU *cpu,
+                             g_assert_not_reached();
+                         }
+                     } else {
+-                        /* AArch64 registers get mapped to non-secure instance
+-                         * of AArch32 */
++                        /*
++                         * AArch64 registers get mapped to non-secure instance
++                         * of AArch32
++                         */
+                         add_cpreg_to_hashtable(cpu, r, opaque, state,
+                                                ARM_CP_SECSTATE_NS,
+                                                crm, opc1, opc2, r->name);
+@@ -XXX,XX +XXX,XX @@ void arm_cp_reset_ignore(CPUARMState *env, const ARMCPRegInfo *opaque)
+ static int bad_mode_switch(CPUARMState *env, int mode, CPSRWriteType write_type)
+ {
+-    /* Return true if it is not valid for us to switch to
++    /*
++     * Return true if it is not valid for us to switch to
+      * this CPU mode (ie all the UNPREDICTABLE cases in
+      * the ARM ARM CPSRWriteByInstr pseudocode).
+      */
+@@ -XXX,XX +XXX,XX @@ static int bad_mode_switch(CPUARMState *env, int mode, CPSRWriteType write_type)
+     case ARM_CPU_MODE_UND:
+     case ARM_CPU_MODE_IRQ:
+     case ARM_CPU_MODE_FIQ:
+-        /* Note that we don't implement the IMPDEF NSACR.RFR which in v7
++        /*
++         * Note that we don't implement the IMPDEF NSACR.RFR which in v7
+          * allows FIQ mode to be Secure-only. (In v8 this doesn't exist.)
+          */
+-        /* If HCR.TGE is set then changes from Monitor to NS PL1 via MSR
++        /*
++         * If HCR.TGE is set then changes from Monitor to NS PL1 via MSR
+          * and CPS are treated as illegal mode changes.
+          */
+         if (write_type == CPSRWriteByInstr &&
+@@ -XXX,XX +XXX,XX @@ void cpsr_write(CPUARMState *env, uint32_t val, uint32_t mask,
+         env->GE = (val >> 16) & 0xf;
+     }
+-    /* In a V7 implementation that includes the security extensions but does
++    /*
++     * In a V7 implementation that includes the security extensions but does
+      * not include Virtualization Extensions the SCR.FW and SCR.AW bits control
+      * whether non-secure software is allowed to change the CPSR_F and CPSR_A
+      * bits respectively.
+@@ -XXX,XX +XXX,XX @@ void cpsr_write(CPUARMState *env, uint32_t val, uint32_t mask,
+         changed_daif = (env->daif ^ val) & mask;
+         if (changed_daif & CPSR_A) {
+-            /* Check to see if we are allowed to change the masking of async
++            /*
++             * Check to see if we are allowed to change the masking of async
+              * abort exceptions from a non-secure state.
+              */
+             if (!(env->cp15.scr_el3 & SCR_AW)) {
+@@ -XXX,XX +XXX,XX @@ void cpsr_write(CPUARMState *env, uint32_t val, uint32_t mask,
+         }
+         if (changed_daif & CPSR_F) {
+-            /* Check to see if we are allowed to change the masking of FIQ
++            /*
++             * Check to see if we are allowed to change the masking of FIQ
+              * exceptions from a non-secure state.
+              */
+             if (!(env->cp15.scr_el3 & SCR_FW)) {
+@@ -XXX,XX +XXX,XX @@ void cpsr_write(CPUARMState *env, uint32_t val, uint32_t mask,
+                 mask &= ~CPSR_F;
+             }
+-            /* Check whether non-maskable FIQ (NMFI) support is enabled.
++            /*
++             * Check whether non-maskable FIQ (NMFI) support is enabled.
+              * If this bit is set software is not allowed to mask
+              * FIQs, but is allowed to set CPSR_F to 0.
+              */
+@@ -XXX,XX +XXX,XX @@ void cpsr_write(CPUARMState *env, uint32_t val, uint32_t mask,
+     if (write_type != CPSRWriteRaw &&
+         ((env->uncached_cpsr ^ val) & mask & CPSR_M)) {
+         if ((env->uncached_cpsr & CPSR_M) == ARM_CPU_MODE_USR) {
+-            /* Note that we can only get here in USR mode if this is a
++            /*
++             * Note that we can only get here in USR mode if this is a
+              * gdb stub write; for this case we follow the architectural
+              * behaviour for guest writes in USR mode of ignoring an attempt
+              * to switch mode. (Those are caught by translate.c for writes
+@@ -XXX,XX +XXX,XX @@ void cpsr_write(CPUARMState *env, uint32_t val, uint32_t mask,
+              */
+             mask &= ~CPSR_M;
+         } else if (bad_mode_switch(env, val & CPSR_M, write_type)) {
+-            /* Attempt to switch to an invalid mode: this is UNPREDICTABLE in
++            /*
++             * Attempt to switch to an invalid mode: this is UNPREDICTABLE in
+              * v7, and has defined behaviour in v8:
+              *  + leave CPSR.M untouched
+              *  + allow changes to the other CPSR fields
+@@ -XXX,XX +XXX,XX @@ static void switch_mode(CPUARMState *env, int mode)
+     env->regs[14] = env->banked_r14[r14_bank_number(mode)];
+ }
+-/* Physical Interrupt Target EL Lookup Table
++/*
++ * Physical Interrupt Target EL Lookup Table
+  *
+  * [ From ARM ARM section G1.13.4 (Table G1-15) ]
+  *
+@@ -XXX,XX +XXX,XX @@ uint32_t arm_phys_excp_target_el(CPUState *cs, uint32_t excp_idx,
+     if (arm_feature(env, ARM_FEATURE_EL3)) {
+         rw = ((env->cp15.scr_el3 & SCR_RW) == SCR_RW);
+     } else {
+-        /* Either EL2 is the highest EL (and so the EL2 register width
++        /*
++         * Either EL2 is the highest EL (and so the EL2 register width
+          * is given by is64); or there is no EL2 or EL3, in which case
+          * the value of 'rw' does not affect the table lookup anyway.
+          */
+@@ -XXX,XX +XXX,XX @@ void aarch64_sync_64_to_32(CPUARMState *env)
+         env->banked_r13[bank_number(ARM_CPU_MODE_UND)] = env->xregs[23];
+     }
+-    /* Registers x24-x30 are mapped to r8-r14 in FIQ mode.  If we are in FIQ
++    /*
++     * Registers x24-x30 are mapped to r8-r14 in FIQ mode.  If we are in FIQ
+      * mode, then we can copy to r8-r14.  Otherwise, we copy to the
+      * FIQ bank for r8-r14.
+      */
+@@ -XXX,XX +XXX,XX @@ static void arm_cpu_do_interrupt_aarch32(CPUState *cs)
+         /* High vectors. When enabled, base address cannot be remapped. */
+         addr += 0xffff0000;
+     } else {
+-        /* ARM v7 architectures provide a vector base address register to remap
++        /*
++         * ARM v7 architectures provide a vector base address register to remap
+          * the interrupt vector table.
+          * This register is only followed in non-monitor mode, and is banked.
+          * Note: only bits 31:5 are valid.
+@@ -XXX,XX +XXX,XX @@ static void arm_cpu_do_interrupt_aarch64(CPUState *cs)
+     aarch64_sve_change_el(env, cur_el, new_el, is_a64(env));
+     if (cur_el < new_el) {
+-        /* Entry vector offset depends on whether the implemented EL
++        /*
++         * Entry vector offset depends on whether the implemented EL
+          * immediately lower than the target level is using AArch32 or AArch64
+          */
+         bool is_aa64;
+@@ -XXX,XX +XXX,XX @@ static void handle_semihosting(CPUState *cs)
+ }
+ #endif
+-/* Handle a CPU exception for A and R profile CPUs.
++/*
++ * Handle a CPU exception for A and R profile CPUs.
+  * Do any appropriate logging, handle PSCI calls, and then hand off
+  * to the AArch64-entry or AArch32-entry function depending on the
+  * target exception level's register width.
+@@ -XXX,XX +XXX,XX @@ void arm_cpu_do_interrupt(CPUState *cs)
+     }
+ #endif
+-    /* Hooks may change global state so BQL should be held, also the
++    /*
++     * Hooks may change global state so BQL should be held, also the
+      * BQL needs to be held for any modification of
+      * cs->interrupt_request.
+      */
+@@ -XXX,XX +XXX,XX @@ ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va,
+     };
+ }
+-/* Note that signed overflow is undefined in C.  The following routines are
+-   careful to use unsigned types where modulo arithmetic is required.
+-   Failure to do so _will_ break on newer gcc.  */
++/*
++ * Note that signed overflow is undefined in C.  The following routines are
++ * careful to use unsigned types where modulo arithmetic is required.
++ * Failure to do so _will_ break on newer gcc.
++ */
+ /* Signed saturating arithmetic.  */
+@@ -XXX,XX +XXX,XX @@ uint32_t HELPER(sel_flags)(uint32_t flags, uint32_t a, uint32_t b)
+     return (a & mask) | (b & ~mask);
+ }
+-/* CRC helpers.
++/*
++ * CRC helpers.
+  * The upper bytes of val (above the number specified by 'bytes') must have
+  * been zeroed out by the caller.
+  */
+@@ -XXX,XX +XXX,XX @@ uint32_t HELPER(crc32c)(uint32_t acc, uint32_t val, uint32_t bytes)
+     return crc32c(acc, buf, bytes) ^ 0xffffffff;
+ }
+-/* Return the exception level to which FP-disabled exceptions should
++/*
++ * Return the exception level to which FP-disabled exceptions should
+  * be taken, or 0 if FP is enabled.
+  */
+ int fp_exception_el(CPUARMState *env, int cur_el)
+@@ -XXX,XX +XXX,XX @@ int fp_exception_el(CPUARMState *env, int cur_el)
+ #ifndef CONFIG_USER_ONLY
+     uint64_t hcr_el2;
+-    /* CPACR and the CPTR registers don't exist before v6, so FP is
++    /*
++     * CPACR and the CPTR registers don't exist before v6, so FP is
+      * always accessible
+      */
+     if (!arm_feature(env, ARM_FEATURE_V6)) {
+@@ -XXX,XX +XXX,XX @@ int fp_exception_el(CPUARMState *env, int cur_el)
+     hcr_el2 = arm_hcr_el2_eff(env);
+-    /* The CPACR controls traps to EL1, or PL1 if we're 32 bit:
++    /*
++     * The CPACR controls traps to EL1, or PL1 if we're 32 bit:
+      * 0, 2 : trap EL0 and EL1/PL1 accesses
+      * 1    : trap only EL0 accesses
+      * 3    : trap no accesses
+--
+.25.1

-New patch
+[PULL 19/34] target/arm: Fix checkpatch space errors in helper.c
+From: Fabiano Rosas <farosas@suse.de>
+Fix the following:
+ERROR: spaces required around that '|' (ctx:VxV)
+ERROR: space required before the open parenthesis '('
+ERROR: spaces required around that '+' (ctx:VxB)
+ERROR: space prohibited between function name and open parenthesis '('
+(the last two still have some occurrences in macros which I left
+behind because it might impact readability)
+Signed-off-by: Fabiano Rosas <farosas@suse.de>
+Reviewed-by: Claudio Fontana <cfontana@suse.de>
+Reviewed-by: Cornelia Huck <cohuck@redhat.com>
+Message-id: 20221213190537.511-3-farosas@suse.de
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+---
+ target/arm/helper.c | 42 +++++++++++++++++++++---------------------
+file changed, 21 insertions(+), 21 deletions(-)
+diff --git a/target/arm/helper.c b/target/arm/helper.c
+index XXXXXXX..XXXXXXX 100644
+--- a/target/arm/helper.c
++++ b/target/arm/helper.c
+@@ -XXX,XX +XXX,XX @@ static void add_cpreg_to_list(gpointer key, gpointer opaque)
+     uint32_t regidx = (uintptr_t)key;
+     const ARMCPRegInfo *ri = get_arm_cp_reginfo(cpu->cp_regs, regidx);
+-    if (!(ri->type & (ARM_CP_NO_RAW|ARM_CP_ALIAS))) {
++    if (!(ri->type & (ARM_CP_NO_RAW | ARM_CP_ALIAS))) {
+         cpu->cpreg_indexes[cpu->cpreg_array_len] = cpreg_to_kvm_id(regidx);
+         /* The value array need not be initialized at this point */
+         cpu->cpreg_array_len++;
+@@ -XXX,XX +XXX,XX @@ static void count_cpreg(gpointer key, gpointer opaque)
+     ri = g_hash_table_lookup(cpu->cp_regs, key);
+-    if (!(ri->type & (ARM_CP_NO_RAW|ARM_CP_ALIAS))) {
++    if (!(ri->type & (ARM_CP_NO_RAW | ARM_CP_ALIAS))) {
+         cpu->cpreg_array_len++;
+     }
+ }
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo v6k_cp_reginfo[] = {
+       .resetfn = arm_cp_reset_ignore },
+     { .name = "TPIDRRO_EL0", .state = ARM_CP_STATE_AA64,
+       .opc0 = 3, .opc1 = 3, .opc2 = 3, .crn = 13, .crm = 0,
+-      .access = PL0_R|PL1_W,
++      .access = PL0_R | PL1_W,
+       .fieldoffset = offsetof(CPUARMState, cp15.tpidrro_el[0]),
+       .resetvalue = 0},
+     { .name = "TPIDRURO", .cp = 15, .crn = 13, .crm = 0, .opc1 = 0, .opc2 = 3,
+-      .access = PL0_R|PL1_W,
++      .access = PL0_R | PL1_W,
+       .bank_fieldoffsets = { offsetoflow32(CPUARMState, cp15.tpidruro_s),
+                              offsetoflow32(CPUARMState, cp15.tpidruro_ns) },
+       .resetfn = arm_cp_reset_ignore },
+@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo cache_block_ops_cp_reginfo[] = {
+       .resetvalue = 0 },
+     /* The cache ops themselves: these all NOP for QEMU */
+     { .name = "IICR", .cp = 15, .crm = 5, .opc1 = 0,
+-      .access = PL1_W, .type = ARM_CP_NOP|ARM_CP_64BIT },
++      .access = PL1_W, .type = ARM_CP_NOP | ARM_CP_64BIT },
+     { .name = "IDCR", .cp = 15, .crm = 6, .opc1 = 0,
+-      .access = PL1_W, .type = ARM_CP_NOP|ARM_CP_64BIT },
++      .access = PL1_W, .type = ARM_CP_NOP | ARM_CP_64BIT },
+     { .name = "CDCR", .cp = 15, .crm = 12, .opc1 = 0,
+-      .access = PL0_W, .type = ARM_CP_NOP|ARM_CP_64BIT },
++      .access = PL0_W, .type = ARM_CP_NOP | ARM_CP_64BIT },
+     { .name = "PIR", .cp = 15, .crm = 12, .opc1 = 1,
+-      .access = PL0_W, .type = ARM_CP_NOP|ARM_CP_64BIT },
++      .access = PL0_W, .type = ARM_CP_NOP | ARM_CP_64BIT },
+     { .name = "PDR", .cp = 15, .crm = 12, .opc1 = 2,
+-      .access = PL0_W, .type = ARM_CP_NOP|ARM_CP_64BIT },
++      .access = PL0_W, .type = ARM_CP_NOP | ARM_CP_64BIT },
+     { .name = "CIDCR", .cp = 15, .crm = 14, .opc1 = 0,
+-      .access = PL1_W, .type = ARM_CP_NOP|ARM_CP_64BIT },
++      .access = PL1_W, .type = ARM_CP_NOP | ARM_CP_64BIT },
+ };
+ static const ARMCPRegInfo cache_test_clean_cp_reginfo[] = {
+@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
+             ARMCPRegInfo cbar = {
+                 .name = "CBAR",
+                 .cp = 15, .crn = 15, .crm = 0, .opc1 = 4, .opc2 = 0,
+-                .access = PL1_R|PL3_W, .resetvalue = cpu->reset_cbar,
++                .access = PL1_R | PL3_W, .resetvalue = cpu->reset_cbar,
+                 .fieldoffset = offsetof(CPUARMState,
+                                         cp15.c15_config_base_address)
+             };
+@@ -XXX,XX +XXX,XX @@ static void switch_mode(CPUARMState *env, int mode)
+         return;
+     if (old_mode == ARM_CPU_MODE_FIQ) {
+-        memcpy (env->fiq_regs, env->regs + 8, 5 * sizeof(uint32_t));
+-        memcpy (env->regs + 8, env->usr_regs, 5 * sizeof(uint32_t));
++        memcpy(env->fiq_regs, env->regs + 8, 5 * sizeof(uint32_t));
++        memcpy(env->regs + 8, env->usr_regs, 5 * sizeof(uint32_t));
+     } else if (mode == ARM_CPU_MODE_FIQ) {
+-        memcpy (env->usr_regs, env->regs + 8, 5 * sizeof(uint32_t));
+-        memcpy (env->regs + 8, env->fiq_regs, 5 * sizeof(uint32_t));
++        memcpy(env->usr_regs, env->regs + 8, 5 * sizeof(uint32_t));
++        memcpy(env->regs + 8, env->fiq_regs, 5 * sizeof(uint32_t));
+     }
+     i = bank_number(old_mode);
+@@ -XXX,XX +XXX,XX @@ static inline uint8_t sub8_usat(uint8_t a, uint8_t b)
+     RESULT(sum, n, 16); \
+     if (sum >= 0) \
+         ge |= 3 << (n * 2); \
+-    } while(0)
++    } while (0)
+ #define SARITH8(a, b, n, op) do { \
+     int32_t sum; \
+@@ -XXX,XX +XXX,XX @@ static inline uint8_t sub8_usat(uint8_t a, uint8_t b)
+     RESULT(sum, n, 8); \
+     if (sum >= 0) \
+         ge |= 1 << n; \
+-    } while(0)
++    } while (0)
+ #define ADD16(a, b, n) SARITH16(a, b, n, +)
+@@ -XXX,XX +XXX,XX @@ static inline uint8_t sub8_usat(uint8_t a, uint8_t b)
+     RESULT(sum, n, 16); \
+     if ((sum >> 16) == 1) \
+         ge |= 3 << (n * 2); \
+-    } while(0)
++    } while (0)
+ #define ADD8(a, b, n) do { \
+     uint32_t sum; \
+@@ -XXX,XX +XXX,XX @@ static inline uint8_t sub8_usat(uint8_t a, uint8_t b)
+     RESULT(sum, n, 8); \
+     if ((sum >> 8) == 1) \
+         ge |= 1 << n; \
+-    } while(0)
++    } while (0)
+ #define SUB16(a, b, n) do { \
+     uint32_t sum; \
+@@ -XXX,XX +XXX,XX @@ static inline uint8_t sub8_usat(uint8_t a, uint8_t b)
+     RESULT(sum, n, 16); \
+     if ((sum >> 16) == 0) \
+         ge |= 3 << (n * 2); \
+-    } while(0)
++    } while (0)
+ #define SUB8(a, b, n) do { \
+     uint32_t sum; \
+@@ -XXX,XX +XXX,XX @@ static inline uint8_t sub8_usat(uint8_t a, uint8_t b)
+     RESULT(sum, n, 8); \
+     if ((sum >> 8) == 0) \
+         ge |= 1 << n; \
+-    } while(0)
++    } while (0)
+ #define PFX u
+ #define ARITH_GE
+--
+.25.1

-New patch
+[PULL 20/34] target/arm: Fix checkpatch brace errors in helper.c
+From: Fabiano Rosas <farosas@suse.de>
+Fix this:
+ERROR: braces {} are necessary for all arms of this statement
+Signed-off-by: Fabiano Rosas <farosas@suse.de>
+Reviewed-by: Claudio Fontana <cfontana@suse.de>
+Reviewed-by: Cornelia Huck <cohuck@redhat.com>
+Message-id: 20221213190537.511-4-farosas@suse.de
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+---
+ target/arm/helper.c | 67 ++++++++++++++++++++++++++++-----------------
+file changed, 42 insertions(+), 25 deletions(-)
+diff --git a/target/arm/helper.c b/target/arm/helper.c
+index XXXXXXX..XXXXXXX 100644
+--- a/target/arm/helper.c
++++ b/target/arm/helper.c
+@@ -XXX,XX +XXX,XX @@ void cpsr_write(CPUARMState *env, uint32_t val, uint32_t mask,
+         env->CF = (val >> 29) & 1;
+         env->VF = (val << 3) & 0x80000000;
+     }
+-    if (mask & CPSR_Q)
++    if (mask & CPSR_Q) {
+         env->QF = ((val & CPSR_Q) != 0);
+-    if (mask & CPSR_T)
++    }
++    if (mask & CPSR_T) {
+         env->thumb = ((val & CPSR_T) != 0);
++    }
+     if (mask & CPSR_IT_0_1) {
+         env->condexec_bits &= ~3;
+         env->condexec_bits |= (val >> 25) & 3;
+@@ -XXX,XX +XXX,XX @@ static void switch_mode(CPUARMState *env, int mode)
+     int i;
+     old_mode = env->uncached_cpsr & CPSR_M;
+-    if (mode == old_mode)
++    if (mode == old_mode) {
+         return;
++    }
+     if (old_mode == ARM_CPU_MODE_FIQ) {
+         memcpy(env->fiq_regs, env->regs + 8, 5 * sizeof(uint32_t));
+@@ -XXX,XX +XXX,XX @@ static void arm_cpu_do_interrupt_aarch32(CPUState *cs)
+         new_mode = ARM_CPU_MODE_UND;
+         addr = 0x04;
+         mask = CPSR_I;
+-        if (env->thumb)
++        if (env->thumb) {
+             offset = 2;
+-        else
++        } else {
+             offset = 4;
++        }
+         break;
+     case EXCP_SWI:
+         new_mode = ARM_CPU_MODE_SVC;
+@@ -XXX,XX +XXX,XX @@ static inline uint16_t add16_sat(uint16_t a, uint16_t b)
+     res = a + b;
+     if (((res ^ a) & 0x8000) && !((a ^ b) & 0x8000)) {
+-        if (a & 0x8000)
++        if (a & 0x8000) {
+             res = 0x8000;
+-        else
++        } else {
+             res = 0x7fff;
++        }
+     }
+     return res;
+ }
+@@ -XXX,XX +XXX,XX @@ static inline uint8_t add8_sat(uint8_t a, uint8_t b)
+     res = a + b;
+     if (((res ^ a) & 0x80) && !((a ^ b) & 0x80)) {
+-        if (a & 0x80)
++        if (a & 0x80) {
+             res = 0x80;
+-        else
++        } else {
+             res = 0x7f;
++        }
+     }
+     return res;
+ }
+@@ -XXX,XX +XXX,XX @@ static inline uint16_t sub16_sat(uint16_t a, uint16_t b)
+     res = a - b;
+     if (((res ^ a) & 0x8000) && ((a ^ b) & 0x8000)) {
+-        if (a & 0x8000)
++        if (a & 0x8000) {
+             res = 0x8000;
+-        else
++        } else {
+             res = 0x7fff;
++        }
+     }
+     return res;
+ }
+@@ -XXX,XX +XXX,XX @@ static inline uint8_t sub8_sat(uint8_t a, uint8_t b)
+     res = a - b;
+     if (((res ^ a) & 0x80) && ((a ^ b) & 0x80)) {
+-        if (a & 0x80)
++        if (a & 0x80) {
+             res = 0x80;
+-        else
++        } else {
+             res = 0x7f;
++        }
+     }
+     return res;
+ }
+@@ -XXX,XX +XXX,XX @@ static inline uint16_t add16_usat(uint16_t a, uint16_t b)
+ {
+     uint16_t res;
+     res = a + b;
+-    if (res < a)
++    if (res < a) {
+         res = 0xffff;
++    }
+     return res;
+ }
+ static inline uint16_t sub16_usat(uint16_t a, uint16_t b)
+ {
+-    if (a > b)
++    if (a > b) {
+         return a - b;
+-    else
++    } else {
+         return 0;
++    }
+ }
+ static inline uint8_t add8_usat(uint8_t a, uint8_t b)
+ {
+     uint8_t res;
+     res = a + b;
+-    if (res < a)
++    if (res < a) {
+         res = 0xff;
++    }
+     return res;
+ }
+ static inline uint8_t sub8_usat(uint8_t a, uint8_t b)
+ {
+-    if (a > b)
++    if (a > b) {
+         return a - b;
+-    else
++    } else {
+         return 0;
++    }
+ }
+ #define ADD16(a, b, n) RESULT(add16_usat(a, b), n, 16);
+@@ -XXX,XX +XXX,XX @@ static inline uint8_t sub8_usat(uint8_t a, uint8_t b)
+ static inline uint8_t do_usad(uint8_t a, uint8_t b)
+ {
+-    if (a > b)
++    if (a > b) {
+         return a - b;
+-    else
++    } else {
+         return b - a;
++    }
+ }
+ /* Unsigned sum of absolute byte differences.  */
+@@ -XXX,XX +XXX,XX @@ uint32_t HELPER(sel_flags)(uint32_t flags, uint32_t a, uint32_t b)
+     uint32_t mask;
+     mask = 0;
+-    if (flags & 1)
++    if (flags & 1) {
+         mask |= 0xff;
+-    if (flags & 2)
++    }
++    if (flags & 2) {
+         mask |= 0xff00;
+-    if (flags & 4)
++    }
++    if (flags & 4) {
+         mask |= 0xff0000;
+-    if (flags & 8)
++    }
++    if (flags & 8) {
+         mask |= 0xff000000;
++    }
+     return (a & mask) | (b & ~mask);
+ }
+--
+.25.1

-New patch
+[PULL 21/34] target/arm: Remove unused includes from m_helper.c
+From: Fabiano Rosas <farosas@suse.de>
+Signed-off-by: Fabiano Rosas <farosas@suse.de>
+Reviewed-by: Claudio Fontana <cfontana@suse.de>
+Reviewed-by: Cornelia Huck <cohuck@redhat.com>
+Message-id: 20221213190537.511-5-farosas@suse.de
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+---
+ target/arm/m_helper.c | 16 ----------------
+file changed, 16 deletions(-)
+diff --git a/target/arm/m_helper.c b/target/arm/m_helper.c
+index XXXXXXX..XXXXXXX 100644
+--- a/target/arm/m_helper.c
++++ b/target/arm/m_helper.c
+@@ -XXX,XX +XXX,XX @@
+  */
+ #include "qemu/osdep.h"
+-#include "qemu/units.h"
+-#include "target/arm/idau.h"
+-#include "trace.h"
+ #include "cpu.h"
+ #include "internals.h"
+-#include "exec/gdbstub.h"
+ #include "exec/helper-proto.h"
+-#include "qemu/host-utils.h"
+ #include "qemu/main-loop.h"
+ #include "qemu/bitops.h"
+-#include "qemu/crc32c.h"
+-#include "qemu/qemu-print.h"
+ #include "qemu/log.h"
+ #include "exec/exec-all.h"
+-#include <zlib.h> /* For crc32 */
+-#include "semihosting/semihost.h"
+-#include "sysemu/cpus.h"
+-#include "sysemu/kvm.h"
+-#include "qemu/range.h"
+-#include "qapi/qapi-commands-machine-target.h"
+-#include "qapi/error.h"
+-#include "qemu/guest-random.h"
+ #ifdef CONFIG_TCG
+-#include "arm_ldst.h"
+ #include "exec/cpu_ldst.h"
+ #include "semihosting/common-semi.h"
+ #endif
+--
+.25.1

-New patch
+[PULL 22/34] target/arm: Remove unused includes from helper.c
+From: Fabiano Rosas <farosas@suse.de>
+Signed-off-by: Fabiano Rosas <farosas@suse.de>
+Reviewed-by: Claudio Fontana <cfontana@suse.de>
+Reviewed-by: Cornelia Huck <cohuck@redhat.com>
+Message-id: 20221213190537.511-6-farosas@suse.de
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+---
+ target/arm/helper.c | 7 -------
+file changed, 7 deletions(-)
+diff --git a/target/arm/helper.c b/target/arm/helper.c
+index XXXXXXX..XXXXXXX 100644
+--- a/target/arm/helper.c
++++ b/target/arm/helper.c
+@@ -XXX,XX +XXX,XX @@
+  */
+ #include "qemu/osdep.h"
+-#include "qemu/units.h"
+ #include "qemu/log.h"
+ #include "trace.h"
+ #include "cpu.h"
+ #include "internals.h"
+ #include "exec/helper-proto.h"
+-#include "qemu/host-utils.h"
+ #include "qemu/main-loop.h"
+ #include "qemu/timer.h"
+ #include "qemu/bitops.h"
+@@ -XXX,XX +XXX,XX @@
+ #include "exec/exec-all.h"
+ #include <zlib.h> /* For crc32 */
+ #include "hw/irq.h"
+-#include "semihosting/semihost.h"
+-#include "sysemu/cpus.h"
+ #include "sysemu/cpu-timers.h"
+ #include "sysemu/kvm.h"
+-#include "qemu/range.h"
+ #include "qapi/qapi-commands-machine-target.h"
+ #include "qapi/error.h"
+ #include "qemu/guest-random.h"
+ #ifdef CONFIG_TCG
+-#include "arm_ldst.h"
+-#include "exec/cpu_ldst.h"
+ #include "semihosting/common-semi.h"
+ #endif
+ #include "cpregs.h"
+--
+.25.1

-New patch
+[PULL 23/34] target/arm: cleanup cpu includes
+From: Claudio Fontana <cfontana@suse.de>
+Remove some unused headers.
+Signed-off-by: Claudio Fontana <cfontana@suse.de>
+Acked-by: Richard Henderson <richard.henderson@linaro.org>
+Reviewed-by: Claudio Fontana <cfontana@suse.de>
+Reviewed-by: Cornelia Huck <cohuck@redhat.com>
+Signed-off-by: Fabiano Rosas <farosas@suse.de>
+Message-id: 20221213190537.511-7-farosas@suse.de
+[added back some includes that are still needed at this point]
+Signed-off-by: Fabiano Rosas <farosas@suse.de>
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+---
+ target/arm/cpu.c   | 1 -
+ target/arm/cpu64.c | 6 ------
+files changed, 7 deletions(-)
+diff --git a/target/arm/cpu.c b/target/arm/cpu.c
+index XXXXXXX..XXXXXXX 100644
+--- a/target/arm/cpu.c
++++ b/target/arm/cpu.c
+@@ -XXX,XX +XXX,XX @@
+ #include "target/arm/idau.h"
+ #include "qemu/module.h"
+ #include "qapi/error.h"
+-#include "qapi/visitor.h"
+ #include "cpu.h"
+ #ifdef CONFIG_TCG
+ #include "hw/core/tcg-cpu-ops.h"
+diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c
+index XXXXXXX..XXXXXXX 100644
+--- a/target/arm/cpu64.c
++++ b/target/arm/cpu64.c
+@@ -XXX,XX +XXX,XX @@
+ #include "qemu/osdep.h"
+ #include "qapi/error.h"
+ #include "cpu.h"
+-#ifdef CONFIG_TCG
+-#include "hw/core/tcg-cpu-ops.h"
+-#endif /* CONFIG_TCG */
+ #include "qemu/module.h"
+-#if !defined(CONFIG_USER_ONLY)
+-#include "hw/loader.h"
+-#endif
+ #include "sysemu/kvm.h"
+ #include "sysemu/hvf.h"
+ #include "kvm_arm.h"
+--
+.25.1

-New patch
+[PULL 24/34] hw/input/tsc2xxx: Constify set_transform()'s MouseTransformInfo arg
+From: Philippe Mathieu-Daudé <philmd@linaro.org>
+The pointed MouseTransformInfo structure is accessed read-only.
+Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
+Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
+Message-id: 20221220142520.24094-2-philmd@linaro.org
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+---
+ include/hw/input/tsc2xxx.h | 4 ++--
+ hw/input/tsc2005.c         | 2 +-
+ hw/input/tsc210x.c         | 3 +--
+files changed, 4 insertions(+), 5 deletions(-)
+diff --git a/include/hw/input/tsc2xxx.h b/include/hw/input/tsc2xxx.h
+index XXXXXXX..XXXXXXX 100644
+--- a/include/hw/input/tsc2xxx.h
++++ b/include/hw/input/tsc2xxx.h
+@@ -XXX,XX +XXX,XX @@ uWireSlave *tsc2102_init(qemu_irq pint);
+ uWireSlave *tsc2301_init(qemu_irq penirq, qemu_irq kbirq, qemu_irq dav);
+ I2SCodec *tsc210x_codec(uWireSlave *chip);
+ uint32_t tsc210x_txrx(void *opaque, uint32_t value, int len);
+-void tsc210x_set_transform(uWireSlave *chip, MouseTransformInfo *info);
++void tsc210x_set_transform(uWireSlave *chip, const MouseTransformInfo *info);
+ void tsc210x_key_event(uWireSlave *chip, int key, int down);
+ /* tsc2005.c */
+ void *tsc2005_init(qemu_irq pintdav);
+ uint32_t tsc2005_txrx(void *opaque, uint32_t value, int len);
+-void tsc2005_set_transform(void *opaque, MouseTransformInfo *info);
++void tsc2005_set_transform(void *opaque, const MouseTransformInfo *info);
+ #endif
+diff --git a/hw/input/tsc2005.c b/hw/input/tsc2005.c
+index XXXXXXX..XXXXXXX 100644
+--- a/hw/input/tsc2005.c
++++ b/hw/input/tsc2005.c
+@@ -XXX,XX +XXX,XX @@ void *tsc2005_init(qemu_irq pintdav)
+  * from the touchscreen.  Assuming 12-bit precision was used during
+  * tslib calibration.
+  */
+-void tsc2005_set_transform(void *opaque, MouseTransformInfo *info)
++void tsc2005_set_transform(void *opaque, const MouseTransformInfo *info)
+ {
+     TSC2005State *s = (TSC2005State *) opaque;
+diff --git a/hw/input/tsc210x.c b/hw/input/tsc210x.c
+index XXXXXXX..XXXXXXX 100644
+--- a/hw/input/tsc210x.c
++++ b/hw/input/tsc210x.c
+@@ -XXX,XX +XXX,XX @@ I2SCodec *tsc210x_codec(uWireSlave *chip)
+  * from the touchscreen.  Assuming 12-bit precision was used during
+  * tslib calibration.
+  */
+-void tsc210x_set_transform(uWireSlave *chip,
+-                MouseTransformInfo *info)
++void tsc210x_set_transform(uWireSlave *chip, const MouseTransformInfo *info)
+ {
+     TSC210xState *s = (TSC210xState *) chip->opaque;
+ #if 0
+--
+.25.1

-[Qemu-devel] [PULL 6/6] tests/boot-serial-test: Add microbit board testcase
+[PULL 25/34] hw/arm/nseries: Constify various read-only arrays
-From: Julia Suvorova via Qemu-devel <qemu-devel@nongnu.org>
+From: Philippe Mathieu-Daudé <philmd@linaro.org>
-New mini-kernel test for nRF51 SoC UART.
+Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
+Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
-Signed-off-by: Julia Suvorova <jusual@mail.ru>
+Message-id: 20221220142520.24094-3-philmd@linaro.org
 Acked-by: Thomas Huth <thuth@redhat.com>
 Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
 Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
 ---
- tests/boot-serial-test.c | 19 +++++++++++++++++++
+ hw/arm/nseries.c | 18 +++++++++---------
-file changed, 19 insertions(+)
+file changed, 9 insertions(+), 9 deletions(-)
-diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c
+diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c
 index XXXXXXX..XXXXXXX 100644
---- a/tests/boot-serial-test.c
+--- a/hw/arm/nseries.c
-+++ b/tests/boot-serial-test.c
++++ b/hw/arm/nseries.c
-@@ -XXX,XX +XXX,XX @@ static const uint8_t kernel_aarch64[] = {
+@@ -XXX,XX +XXX,XX @@ static void n8x0_i2c_setup(struct n800_s *s)
-xfd, 0xff, 0xff, 0x17,                 /* b       -12 (loop) */
+ }
  /* Touchscreen and keypad controller */
 -static MouseTransformInfo n800_pointercal = {
 +static const MouseTransformInfo n800_pointercal = {
      .x = 800,
      .y = 480,
      .a = { 14560, -68, -3455208, -39, -9621, 35152972, 65536 },
  };
-+static const uint8_t kernel_nrf51[] = {
+-static MouseTransformInfo n810_pointercal = {
-+    0x00, 0x00, 0x00, 0x00,                 /* Stack top address */
++static const MouseTransformInfo n810_pointercal = {
-+    0x09, 0x00, 0x00, 0x00,                 /* Reset handler address */
+     .x = 800,
-+    0x04, 0x4a,                             /* ldr  r2, [pc, #16] Get ENABLE */
+     .y = 480,
-+    0x04, 0x21,                             /* movs r1, #4 */
+     .a = { 15041, 148, -4731056, 171, -10238, 35933380, 65536 },
-+    0x11, 0x60,                             /* str  r1, [r2] */
+@@ -XXX,XX +XXX,XX @@ static void n810_key_event(void *opaque, int keycode)
-+    0x04, 0x4a,                             /* ldr  r2, [pc, #16] Get STARTTX */
-+    0x01, 0x21,                             /* movs r1, #1 */
+ #define M    0
-+    0x11, 0x60,                             /* str  r1, [r2] */
-+    0x03, 0x4a,                             /* ldr  r2, [pc, #12] Get TXD */
+-static int n810_keys[0x80] = {
-+    0x54, 0x21,                             /* movs r1, 'T' */
++static const int n810_keys[0x80] = {
-+    0x11, 0x60,                             /* str  r1, [r2] */
+     [0x01] = 16,    /* Q */
-+    0xfe, 0xe7,                             /* b    . */
+     [0x02] = 37,    /* K */
-+    0x00, 0x25, 0x00, 0x40,                 /* 0x40002500 = UART ENABLE */
+     [0x03] = 24,    /* O */
-+    0x08, 0x20, 0x00, 0x40,                 /* 0x40002008 = UART STARTTX */
+@@ -XXX,XX +XXX,XX @@ static void n8x0_usb_setup(struct n800_s *s)
-+    0x1c, 0x25, 0x00, 0x40                  /* 0x4000251c = UART TXD */
+ /* Setup done before the main bootloader starts by some early setup code
-+};
+  * - used when we want to run the main bootloader in emulation.  This
-+
+  * isn't documented.  */
- typedef struct testdef {
+-static uint32_t n800_pinout[104] = {
-     const char *arch;       /* Target architecture */
++static const uint32_t n800_pinout[104] = {
-     const char *machine;    /* Name of the machine */
+x080f00d8, 0x00d40808, 0x03080808, 0x080800d0,
-@@ -XXX,XX +XXX,XX @@ static testdef_t tests[] = {
+x00dc0808, 0x0b0f0f00, 0x080800b4, 0x00c00808,
-     { "hppa", "hppa", "", "SeaBIOS wants SYSTEM HALT" },
+x08080808, 0x180800c4, 0x00b80000, 0x08080808,
-     { "aarch64", "virt", "-cpu cortex-a57", "TT", sizeof(kernel_aarch64),
+@@ -XXX,XX +XXX,XX @@ static void n8x0_boot_init(void *opaque)
-       kernel_aarch64 },
+ #define OMAP_TAG_CBUS        0x4e03
-+    { "arm", "microbit", "", "T", sizeof(kernel_nrf51), kernel_nrf51 },
+ #define OMAP_TAG_EM_ASIC_BB5    0x4e04
 -static struct omap_gpiosw_info_s {
 +static const struct omap_gpiosw_info_s {
      const char *name;
      int line;
      int type;
@@ -XXX,XX +XXX,XX @@ static struct omap_gpiosw_info_s {
      { NULL }
  };
+-static struct omap_partition_info_s {
++static const struct omap_partition_info_s {
+     uint32_t offset;
+     uint32_t size;
+     int mask;
+@@ -XXX,XX +XXX,XX @@ static struct omap_partition_info_s {
+     { 0, 0, 0, NULL }
+ };
+-static uint8_t n8x0_bd_addr[6] = { N8X0_BD_ADDR };
++static const uint8_t n8x0_bd_addr[6] = { N8X0_BD_ADDR };
+ static int n8x0_atag_setup(void *p, int model)
+ {
+     uint8_t *b;
+     uint16_t *w;
+     uint32_t *l;
+-    struct omap_gpiosw_info_s *gpiosw;
+-    struct omap_partition_info_s *partition;
++    const struct omap_gpiosw_info_s *gpiosw;
++    const struct omap_partition_info_s *partition;
+     const char *tag;
+     w = p;
 --
-.19.1
+.25.1

-New patch
+[PULL 26/34] hw/arm/nseries: Silent -Wmissing-field-initializers warning
+From: Philippe Mathieu-Daudé <philmd@linaro.org>
+Silent when compiling with -Wextra:
+  ../hw/arm/nseries.c:1081:12: warning: missing field 'line' initializer [-Wmissing-field-initializers]
+      { NULL }
+             ^
+Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
+Message-id: 20221220142520.24094-4-philmd@linaro.org
+Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+---
+ hw/arm/nseries.c | 10 ++++------
+file changed, 4 insertions(+), 6 deletions(-)
+diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c
+index XXXXXXX..XXXXXXX 100644
+--- a/hw/arm/nseries.c
++++ b/hw/arm/nseries.c
+@@ -XXX,XX +XXX,XX @@ static const struct omap_gpiosw_info_s {
+         "headphone", N8X0_HEADPHONE_GPIO,
+         OMAP_GPIOSW_TYPE_CONNECTION | OMAP_GPIOSW_INVERTED,
+     },
+-    { NULL }
++    { /* end of list */ }
+ }, n810_gpiosw_info[] = {
+     {
+         "gps_reset", N810_GPS_RESET_GPIO,
+@@ -XXX,XX +XXX,XX @@ static const struct omap_gpiosw_info_s {
+         "slide", N810_SLIDE_GPIO,
+         OMAP_GPIOSW_TYPE_COVER | OMAP_GPIOSW_INVERTED,
+     },
+-    { NULL }
++    { /* end of list */ }
+ };
+ static const struct omap_partition_info_s {
+@@ -XXX,XX +XXX,XX @@ static const struct omap_partition_info_s {
+     { 0x00080000, 0x00200000, 0x0, "kernel" },
+     { 0x00280000, 0x00200000, 0x3, "initfs" },
+     { 0x00480000, 0x0fb80000, 0x3, "rootfs" },
+-
+-    { 0, 0, 0, NULL }
++    { /* end of list */ }
+ }, n810_part_info[] = {
+     { 0x00000000, 0x00020000, 0x3, "bootloader" },
+     { 0x00020000, 0x00060000, 0x0, "config" },
+     { 0x00080000, 0x00220000, 0x0, "kernel" },
+     { 0x002a0000, 0x00400000, 0x0, "initfs" },
+     { 0x006a0000, 0x0f960000, 0x0, "rootfs" },
+-
+-    { 0, 0, 0, NULL }
++    { /* end of list */ }
+ };
+ static const uint8_t n8x0_bd_addr[6] = { N8X0_BD_ADDR };
+--
+.25.1

-New patch
+[PULL 27/34] target/arm: align exposed ID registers with Linux
+From: Zhuojia Shen <chaosdefinition@hotmail.com>
 In CPUID registers exposed to userspace, some registers were missing
 and some fields were not exposed.  This patch aligns exposed ID
 registers and their fields with what the upstream kernel currently
 exposes.
 Specifically, the following new ID registers/fields are exposed to
 userspace:
 ID_AA64PFR1_EL1.BT:       bits 3-0
 ID_AA64PFR1_EL1.MTE:      bits 11-8
 ID_AA64PFR1_EL1.SME:      bits 27-24
 ID_AA64ZFR0_EL1.SVEver:   bits 3-0
 ID_AA64ZFR0_EL1.AES:      bits 7-4
 ID_AA64ZFR0_EL1.BitPerm:  bits 19-16
 ID_AA64ZFR0_EL1.BF16:     bits 23-20
 ID_AA64ZFR0_EL1.SHA3:     bits 35-32
 ID_AA64ZFR0_EL1.SM4:      bits 43-40
 ID_AA64ZFR0_EL1.I8MM:     bits 47-44
 ID_AA64ZFR0_EL1.F32MM:    bits 55-52
 ID_AA64ZFR0_EL1.F64MM:    bits 59-56
 ID_AA64SMFR0_EL1.F32F32:  bit 32
 ID_AA64SMFR0_EL1.B16F32:  bit 34
 ID_AA64SMFR0_EL1.F16F32:  bit 35
 ID_AA64SMFR0_EL1.I8I32:   bits 39-36
 ID_AA64SMFR0_EL1.F64F64:  bit 48
 ID_AA64SMFR0_EL1.I16I64:  bits 55-52
 ID_AA64SMFR0_EL1.FA64:    bit 63
 ID_AA64MMFR0_EL1.ECV:     bits 63-60
 ID_AA64MMFR1_EL1.AFP:     bits 47-44
 ID_AA64MMFR2_EL1.AT:      bits 35-32
 ID_AA64ISAR0_EL1.RNDR:    bits 63-60
 ID_AA64ISAR1_EL1.FRINTTS: bits 35-32
 ID_AA64ISAR1_EL1.BF16:    bits 47-44
 ID_AA64ISAR1_EL1.DGH:     bits 51-48
 ID_AA64ISAR1_EL1.I8MM:    bits 55-52
 ID_AA64ISAR2_EL1.WFxT:    bits 3-0
 ID_AA64ISAR2_EL1.RPRES:   bits 7-4
 ID_AA64ISAR2_EL1.GPA3:    bits 11-8
 ID_AA64ISAR2_EL1.APA3:    bits 15-12
 The code is also refactored to use symbolic names for ID register fields
 for better readability and maintainability.
 The test case in tests/tcg/aarch64/sysregs.c is also updated to match
 the intended behavior.
 Signed-off-by: Zhuojia Shen <chaosdefinition@hotmail.com>
 Message-id: DS7PR12MB6309FB585E10772928F14271ACE79@DS7PR12MB6309.namprd12.prod.outlook.com
 Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
 [PMM: use Sn_n_Cn_Cn_n syntax to work with older assemblers
 that don't recognize id_aa64isar2_el1 and id_aa64mmfr2_el1]
 Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
 ---
  target/arm/helper.c               | 96 +++++++++++++++++++++++++------
  tests/tcg/aarch64/sysregs.c       | 24 ++++++--
  tests/tcg/aarch64/Makefile.target |  7 ++-
 files changed, 103 insertions(+), 24 deletions(-)
 diff --git a/target/arm/helper.c b/target/arm/helper.c
 index XXXXXXX..XXXXXXX 100644
 --- a/target/arm/helper.c
 +++ b/target/arm/helper.c
@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
  #ifdef CONFIG_USER_ONLY
          static const ARMCPRegUserSpaceInfo v8_user_idregs[] = {
              { .name = "ID_AA64PFR0_EL1",
 -              .exported_bits = 0x000f000f00ff0000,
 -              .fixed_bits    = 0x0000000000000011 },
 +              .exported_bits = R_ID_AA64PFR0_FP_MASK |
 +                               R_ID_AA64PFR0_ADVSIMD_MASK |
 +                               R_ID_AA64PFR0_SVE_MASK |
 +                               R_ID_AA64PFR0_DIT_MASK,
 +              .fixed_bits = (0x1u << R_ID_AA64PFR0_EL0_SHIFT) |
 +                            (0x1u << R_ID_AA64PFR0_EL1_SHIFT) },
              { .name = "ID_AA64PFR1_EL1",
 -              .exported_bits = 0x00000000000000f0 },
 +              .exported_bits = R_ID_AA64PFR1_BT_MASK |
 +                               R_ID_AA64PFR1_SSBS_MASK |
 +                               R_ID_AA64PFR1_MTE_MASK |
 +                               R_ID_AA64PFR1_SME_MASK },
              { .name = "ID_AA64PFR*_EL1_RESERVED",
 -              .is_glob = true                     },
 -            { .name = "ID_AA64ZFR0_EL1"           },
 +              .is_glob = true },
 +            { .name = "ID_AA64ZFR0_EL1",
 +              .exported_bits = R_ID_AA64ZFR0_SVEVER_MASK |
 +                               R_ID_AA64ZFR0_AES_MASK |
 +                               R_ID_AA64ZFR0_BITPERM_MASK |
 +                               R_ID_AA64ZFR0_BFLOAT16_MASK |
 +                               R_ID_AA64ZFR0_SHA3_MASK |
 +                               R_ID_AA64ZFR0_SM4_MASK |
 +                               R_ID_AA64ZFR0_I8MM_MASK |
 +                               R_ID_AA64ZFR0_F32MM_MASK |
 +                               R_ID_AA64ZFR0_F64MM_MASK },
 +            { .name = "ID_AA64SMFR0_EL1",
 +              .exported_bits = R_ID_AA64SMFR0_F32F32_MASK |
 +                               R_ID_AA64SMFR0_B16F32_MASK |
 +                               R_ID_AA64SMFR0_F16F32_MASK |
 +                               R_ID_AA64SMFR0_I8I32_MASK |
 +                               R_ID_AA64SMFR0_F64F64_MASK |
 +                               R_ID_AA64SMFR0_I16I64_MASK |
 +                               R_ID_AA64SMFR0_FA64_MASK },
              { .name = "ID_AA64MMFR0_EL1",
 -              .fixed_bits    = 0x00000000ff000000 },
 -            { .name = "ID_AA64MMFR1_EL1"          },
 +              .exported_bits = R_ID_AA64MMFR0_ECV_MASK,
 +              .fixed_bits = (0xfu << R_ID_AA64MMFR0_TGRAN64_SHIFT) |
 +                            (0xfu << R_ID_AA64MMFR0_TGRAN4_SHIFT) },
 +            { .name = "ID_AA64MMFR1_EL1",
 +              .exported_bits = R_ID_AA64MMFR1_AFP_MASK },
 +            { .name = "ID_AA64MMFR2_EL1",
 +              .exported_bits = R_ID_AA64MMFR2_AT_MASK },
              { .name = "ID_AA64MMFR*_EL1_RESERVED",
 -              .is_glob = true                     },
 +              .is_glob = true },
              { .name = "ID_AA64DFR0_EL1",
 -              .fixed_bits    = 0x0000000000000006 },
 -            { .name = "ID_AA64DFR1_EL1"           },
 +              .fixed_bits = (0x6u << R_ID_AA64DFR0_DEBUGVER_SHIFT) },
 +            { .name = "ID_AA64DFR1_EL1" },
              { .name = "ID_AA64DFR*_EL1_RESERVED",
 -              .is_glob = true                     },
 +              .is_glob = true },
              { .name = "ID_AA64AFR*",
 -              .is_glob = true                     },
 +              .is_glob = true },
              { .name = "ID_AA64ISAR0_EL1",
 -              .exported_bits = 0x00fffffff0fffff0 },
 +              .exported_bits = R_ID_AA64ISAR0_AES_MASK |
 +                               R_ID_AA64ISAR0_SHA1_MASK |
 +                               R_ID_AA64ISAR0_SHA2_MASK |
 +                               R_ID_AA64ISAR0_CRC32_MASK |
 +                               R_ID_AA64ISAR0_ATOMIC_MASK |
 +                               R_ID_AA64ISAR0_RDM_MASK |
 +                               R_ID_AA64ISAR0_SHA3_MASK |
 +                               R_ID_AA64ISAR0_SM3_MASK |
 +                               R_ID_AA64ISAR0_SM4_MASK |
 +                               R_ID_AA64ISAR0_DP_MASK |
 +                               R_ID_AA64ISAR0_FHM_MASK |
 +                               R_ID_AA64ISAR0_TS_MASK |
 +                               R_ID_AA64ISAR0_RNDR_MASK },
              { .name = "ID_AA64ISAR1_EL1",
 -              .exported_bits = 0x000000f0ffffffff },
 +              .exported_bits = R_ID_AA64ISAR1_DPB_MASK |
 +                               R_ID_AA64ISAR1_APA_MASK |
 +                               R_ID_AA64ISAR1_API_MASK |
 +                               R_ID_AA64ISAR1_JSCVT_MASK |
 +                               R_ID_AA64ISAR1_FCMA_MASK |
 +                               R_ID_AA64ISAR1_LRCPC_MASK |
 +                               R_ID_AA64ISAR1_GPA_MASK |
 +                               R_ID_AA64ISAR1_GPI_MASK |
 +                               R_ID_AA64ISAR1_FRINTTS_MASK |
 +                               R_ID_AA64ISAR1_SB_MASK |
 +                               R_ID_AA64ISAR1_BF16_MASK |
 +                               R_ID_AA64ISAR1_DGH_MASK |
 +                               R_ID_AA64ISAR1_I8MM_MASK },
 +            { .name = "ID_AA64ISAR2_EL1",
 +              .exported_bits = R_ID_AA64ISAR2_WFXT_MASK |
 +                               R_ID_AA64ISAR2_RPRES_MASK |
 +                               R_ID_AA64ISAR2_GPA3_MASK |
 +                               R_ID_AA64ISAR2_APA3_MASK },
              { .name = "ID_AA64ISAR*_EL1_RESERVED",
 -              .is_glob = true                     },
 +              .is_glob = true },
          };
          modify_arm_cp_regs(v8_idregs, v8_user_idregs);
  #endif
@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
  #ifdef CONFIG_USER_ONLY
          static const ARMCPRegUserSpaceInfo id_v8_user_midr_cp_reginfo[] = {
              { .name = "MIDR_EL1",
 -              .exported_bits = 0x00000000ffffffff },
 -            { .name = "REVIDR_EL1"                },
 +              .exported_bits = R_MIDR_EL1_REVISION_MASK |
 +                               R_MIDR_EL1_PARTNUM_MASK |
 +                               R_MIDR_EL1_ARCHITECTURE_MASK |
 +                               R_MIDR_EL1_VARIANT_MASK |
 +                               R_MIDR_EL1_IMPLEMENTER_MASK },
 +            { .name = "REVIDR_EL1" },
          };
          modify_arm_cp_regs(id_v8_midr_cp_reginfo, id_v8_user_midr_cp_reginfo);
  #endif
 diff --git a/tests/tcg/aarch64/sysregs.c b/tests/tcg/aarch64/sysregs.c
 index XXXXXXX..XXXXXXX 100644
 --- a/tests/tcg/aarch64/sysregs.c
 +++ b/tests/tcg/aarch64/sysregs.c
@@ -XXX,XX +XXX,XX @@
  #define HWCAP_CPUID (1 << 11)
  #endif
 +/*
 + * Older assemblers don't recognize newer system register names,
 + * but we can still access them by the Sn_n_Cn_Cn_n syntax.
 + */
 +#define SYS_ID_AA64ISAR2_EL1 S3_0_C0_C6_2
 +#define SYS_ID_AA64MMFR2_EL1 S3_0_C0_C7_2
 +
  int failed_bit_count;
  /* Read and print system register `id' value */
@@ -XXX,XX +XXX,XX @@ int main(void)
       * minimum valid fields - for the purposes of this check allowed
       * to have non-zero values.
       */
 -    get_cpu_reg_check_mask(id_aa64isar0_el1, _m(00ff,ffff,f0ff,fff0));
 -    get_cpu_reg_check_mask(id_aa64isar1_el1, _m(0000,00f0,ffff,ffff));
 +    get_cpu_reg_check_mask(id_aa64isar0_el1, _m(f0ff,ffff,f0ff,fff0));
 +    get_cpu_reg_check_mask(id_aa64isar1_el1, _m(00ff,f0ff,ffff,ffff));
 +    get_cpu_reg_check_mask(SYS_ID_AA64ISAR2_EL1, _m(0000,0000,0000,ffff));
      /* TGran4 & TGran64 as pegged to -1 */
 -    get_cpu_reg_check_mask(id_aa64mmfr0_el1, _m(0000,0000,ff00,0000));
 -    get_cpu_reg_check_zero(id_aa64mmfr1_el1);
 +    get_cpu_reg_check_mask(id_aa64mmfr0_el1, _m(f000,0000,ff00,0000));
 +    get_cpu_reg_check_mask(id_aa64mmfr1_el1, _m(0000,f000,0000,0000));
 +    get_cpu_reg_check_mask(SYS_ID_AA64MMFR2_EL1, _m(0000,000f,0000,0000));
      /* EL1/EL0 reported as AA64 only */
      get_cpu_reg_check_mask(id_aa64pfr0_el1,  _m(000f,000f,00ff,0011));
 -    get_cpu_reg_check_mask(id_aa64pfr1_el1,  _m(0000,0000,0000,00f0));
 +    get_cpu_reg_check_mask(id_aa64pfr1_el1,  _m(0000,0000,0f00,0fff));
      /* all hidden, DebugVer fixed to 0x6 (ARMv8 debug architecture) */
      get_cpu_reg_check_mask(id_aa64dfr0_el1,  _m(0000,0000,0000,0006));
      get_cpu_reg_check_zero(id_aa64dfr1_el1);
 -    get_cpu_reg_check_zero(id_aa64zfr0_el1);
 +    get_cpu_reg_check_mask(id_aa64zfr0_el1,  _m(0ff0,ff0f,00ff,00ff));
 +#ifdef HAS_ARMV9_SME
 +    get_cpu_reg_check_mask(id_aa64smfr0_el1, _m(80f1,00fd,0000,0000));
 +#endif
      get_cpu_reg_check_zero(id_aa64afr0_el1);
      get_cpu_reg_check_zero(id_aa64afr1_el1);
 diff --git a/tests/tcg/aarch64/Makefile.target b/tests/tcg/aarch64/Makefile.target
 index XXXXXXX..XXXXXXX 100644
 --- a/tests/tcg/aarch64/Makefile.target
 +++ b/tests/tcg/aarch64/Makefile.target
@@ -XXX,XX +XXX,XX @@ config-cc.mak: Makefile
          $(call cc-option,-march=armv8.1-a+sve2,         CROSS_CC_HAS_SVE2); \
          $(call cc-option,-march=armv8.3-a,              CROSS_CC_HAS_ARMV8_3); \
          $(call cc-option,-mbranch-protection=standard,  CROSS_CC_HAS_ARMV8_BTI); \
 -        $(call cc-option,-march=armv8.5-a+memtag,       CROSS_CC_HAS_ARMV8_MTE)) 3> config-cc.mak
 +        $(call cc-option,-march=armv8.5-a+memtag,       CROSS_CC_HAS_ARMV8_MTE); \
 +        $(call cc-option,-march=armv9-a+sme,            CROSS_CC_HAS_ARMV9_SME)) 3> config-cc.mak
  -include config-cc.mak
  # Pauth Tests
@@ -XXX,XX +XXX,XX @@ endif
  ifneq ($(CROSS_CC_HAS_SVE),)
  # System Registers Tests
  AARCH64_TESTS += sysregs
 +ifneq ($(CROSS_CC_HAS_ARMV9_SME),)
 +sysregs: CFLAGS+=-march=armv9-a+sme -DHAS_ARMV9_SME
 +else
  sysregs: CFLAGS+=-march=armv8.1-a+sve
 +endif
  # SVE ioctl test
  AARCH64_TESTS += sve-ioctls
 --
 .25.1

-[Qemu-devel] [PULL 1/6] hw/arm/virt: Set VIRT_COMPAT_3_0 compat
+[PULL 28/34] hw/arm/smmu-common: Reduce smmu_inv_notifiers_mr() scope
-From: Eric Auger <eric.auger@redhat.com>
+From: Philippe Mathieu-Daudé <philmd@linaro.org>
-We are missing the VIRT_COMPAT_3_0 definition and setting.
+This function is not used anywhere outside this file,
-Let's add them.
+so we can make the function "static void".
-Signed-off-by: Eric Auger <eric.auger@redhat.com>
+Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
-Reviewed-by: Andrew Jones <drjones@redhat.com>
+Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
-Message-id: 20181024085602.16611-1-eric.auger@redhat.com
+Reviewed-by: Eric Auger <eric.auger@redhat.com>
 Message-id: 20221216214924.4711-2-philmd@linaro.org
 Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
 ---
- hw/arm/virt.c | 4 ++++
+ include/hw/arm/smmu-common.h | 3 ---
-file changed, 4 insertions(+)
+ hw/arm/smmu-common.c         | 2 +-
 files changed, 1 insertion(+), 4 deletions(-)
-diff --git a/hw/arm/virt.c b/hw/arm/virt.c
+diff --git a/include/hw/arm/smmu-common.h b/include/hw/arm/smmu-common.h
 index XXXXXXX..XXXXXXX 100644
---- a/hw/arm/virt.c
+--- a/include/hw/arm/smmu-common.h
-+++ b/hw/arm/virt.c
++++ b/include/hw/arm/smmu-common.h
-@@ -XXX,XX +XXX,XX @@ static void virt_machine_3_1_options(MachineClass *mc)
+@@ -XXX,XX +XXX,XX @@ void smmu_iotlb_inv_iova(SMMUState *s, int asid, dma_addr_t iova,
  /* Unmap the range of all the notifiers registered to any IOMMU mr */
  void smmu_inv_notifiers_all(SMMUState *s);
 -/* Unmap the range of all the notifiers registered to @mr */
 -void smmu_inv_notifiers_mr(IOMMUMemoryRegion *mr);
 -
  #endif /* HW_ARM_SMMU_COMMON_H */
 diff --git a/hw/arm/smmu-common.c b/hw/arm/smmu-common.c
 index XXXXXXX..XXXXXXX 100644
 --- a/hw/arm/smmu-common.c
 +++ b/hw/arm/smmu-common.c
@@ -XXX,XX +XXX,XX @@ static void smmu_unmap_notifier_range(IOMMUNotifier *n)
  }
- DEFINE_VIRT_MACHINE_AS_LATEST(3, 1)
+ /* Unmap all notifiers attached to @mr */
-+#define VIRT_COMPAT_3_0 \
+-inline void smmu_inv_notifiers_mr(IOMMUMemoryRegion *mr)
-+    HW_COMPAT_3_0
++static void smmu_inv_notifiers_mr(IOMMUMemoryRegion *mr)
 +
  static void virt_3_0_instance_init(Object *obj)
  {
-     virt_3_1_instance_init(obj);
+     IOMMUNotifier *n;
@@ -XXX,XX +XXX,XX @@ static void virt_3_0_instance_init(Object *obj)
  static void virt_machine_3_0_options(MachineClass *mc)
  {
      virt_machine_3_1_options(mc);
 +    SET_MACHINE_COMPAT(mc, VIRT_COMPAT_3_0);
  }
  DEFINE_VIRT_MACHINE(3, 0)
 --
-.19.1
+.25.1

-[Qemu-devel] [PULL 5/6] hw/arm/nrf51_soc: Connect UART to nRF51 SoC
+[PULL 29/34] hw/arm/smmu-common: Avoid using inlined functions with external linkage
-From: Julia Suvorova via Qemu-devel <qemu-devel@nongnu.org>
+From: Philippe Mathieu-Daudé <philmd@linaro.org>
-Wire up nRF51 UART in the corresponding SoC.
+When using Clang ("Apple clang version 14.0.0 (clang-1400.0.29.202)")
 and building with -Wall we get:
-Signed-off-by: Julia Suvorova <jusual@mail.ru>
+  hw/arm/smmu-common.c:173:33: warning: static function 'smmu_hash_remove_by_asid_iova' is used in an inline function with external linkage [-Wstatic-in-inline]
-Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
+  hw/arm/smmu-common.h:170:1: note: use 'static' to give inline function 'smmu_iotlb_inv_iova' internal linkage
-Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
+    void smmu_iotlb_inv_iova(SMMUState *s, int asid, dma_addr_t iova,
     ^
     static
 None of our code base require / use inlined functions with external
 linkage. Some places use internal inlining in the hot path. These
 two functions are certainly not in any hot path and don't justify
 any inlining, so these are likely oversights rather than intentional.
 Reported-by: Stefan Weil <sw@weilnetz.de>
 Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
+Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
+Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
+Reviewed-by: Eric Auger <eric.auger@redhat.com>
+Message-id: 20221216214924.4711-3-philmd@linaro.org
 Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
 ---
- include/hw/arm/nrf51_soc.h |  3 +++
+ hw/arm/smmu-common.c | 13 ++++++-------
- hw/arm/microbit.c          |  2 ++
+file changed, 6 insertions(+), 7 deletions(-)
  hw/arm/nrf51_soc.c         | 20 ++++++++++++++++++++
 files changed, 25 insertions(+)
-diff --git a/include/hw/arm/nrf51_soc.h b/include/hw/arm/nrf51_soc.h
+diff --git a/hw/arm/smmu-common.c b/hw/arm/smmu-common.c
 index XXXXXXX..XXXXXXX 100644
---- a/include/hw/arm/nrf51_soc.h
+--- a/hw/arm/smmu-common.c
-+++ b/include/hw/arm/nrf51_soc.h
++++ b/hw/arm/smmu-common.c
-@@ -XXX,XX +XXX,XX @@
+@@ -XXX,XX +XXX,XX @@ void smmu_iotlb_insert(SMMUState *bs, SMMUTransCfg *cfg, SMMUTLBEntry *new)
+     g_hash_table_insert(bs->iotlb, key, new);
- #include "hw/sysbus.h"
+ }
- #include "hw/arm/armv7m.h"
-+#include "hw/char/nrf51_uart.h"
+-inline void smmu_iotlb_inv_all(SMMUState *s)
++void smmu_iotlb_inv_all(SMMUState *s)
  #define TYPE_NRF51_SOC "nrf51-soc"
  #define NRF51_SOC(obj) \
@@ -XXX,XX +XXX,XX @@ typedef struct NRF51State {
      /*< public >*/
      ARMv7MState cpu;
 +    NRF51UARTState uart;
 +
      MemoryRegion iomem;
      MemoryRegion sram;
      MemoryRegion flash;
 diff --git a/hw/arm/microbit.c b/hw/arm/microbit.c
 index XXXXXXX..XXXXXXX 100644
 --- a/hw/arm/microbit.c
 +++ b/hw/arm/microbit.c
@@ -XXX,XX +XXX,XX @@
  #include "qapi/error.h"
  #include "hw/boards.h"
  #include "hw/arm/arm.h"
 +#include "sysemu/sysemu.h"
  #include "exec/address-spaces.h"
  #include "hw/arm/nrf51_soc.h"
@@ -XXX,XX +XXX,XX @@ static void microbit_init(MachineState *machine)
      sysbus_init_child_obj(OBJECT(machine), "nrf51", soc, sizeof(s->nrf51),
                            TYPE_NRF51_SOC);
 +    qdev_prop_set_chr(DEVICE(&s->nrf51), "serial0", serial_hd(0));
      object_property_set_link(soc, OBJECT(system_memory), "memory",
                               &error_fatal);
      object_property_set_bool(soc, true, "realized", &error_fatal);
 diff --git a/hw/arm/nrf51_soc.c b/hw/arm/nrf51_soc.c
 index XXXXXXX..XXXXXXX 100644
 --- a/hw/arm/nrf51_soc.c
 +++ b/hw/arm/nrf51_soc.c
@@ -XXX,XX +XXX,XX @@
  #define NRF51822_FLASH_SIZE     (256 * 1024)
  #define NRF51822_SRAM_SIZE      (16 * 1024)
 +#define BASE_TO_IRQ(base) ((base >> 12) & 0x1F)
 +
  static void nrf51_soc_realize(DeviceState *dev_soc, Error **errp)
  {
-     NRF51State *s = NRF51_SOC(dev_soc);
+     trace_smmu_iotlb_inv_all();
-+    MemoryRegion *mr;
+     g_hash_table_remove_all(s->iotlb);
-     Error *err = NULL;
+@@ -XXX,XX +XXX,XX @@ static gboolean smmu_hash_remove_by_asid_iova(gpointer key, gpointer value,
+            ((entry->iova & ~info->mask) == info->iova);
      if (!s->board_memory) {
@@ -XXX,XX +XXX,XX @@ static void nrf51_soc_realize(DeviceState *dev_soc, Error **errp)
      }
      memory_region_add_subregion(&s->container, SRAM_BASE, &s->sram);
 +    /* UART */
 +    object_property_set_bool(OBJECT(&s->uart), true, "realized", &err);
 +    if (err) {
 +        error_propagate(errp, err);
 +        return;
 +    }
 +    mr = sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->uart), 0);
 +    memory_region_add_subregion_overlap(&s->container, UART_BASE, mr, 0);
 +    sysbus_connect_irq(SYS_BUS_DEVICE(&s->uart), 0,
 +                       qdev_get_gpio_in(DEVICE(&s->cpu),
 +                       BASE_TO_IRQ(UART_BASE)));
 +
      create_unimplemented_device("nrf51_soc.io", IOMEM_BASE, IOMEM_SIZE);
      create_unimplemented_device("nrf51_soc.ficr", FICR_BASE, FICR_SIZE);
      create_unimplemented_device("nrf51_soc.private",
@@ -XXX,XX +XXX,XX @@ static void nrf51_soc_init(Object *obj)
      qdev_prop_set_string(DEVICE(&s->cpu), "cpu-type",
                           ARM_CPU_TYPE_NAME("cortex-m0"));
      qdev_prop_set_uint32(DEVICE(&s->cpu), "num-irq", 32);
 +
 +    sysbus_init_child_obj(obj, "uart", &s->uart, sizeof(s->uart),
 +                           TYPE_NRF51_UART);
 +    object_property_add_alias(obj, "serial0", OBJECT(&s->uart), "chardev",
 +                              &error_abort);
  }
- static Property nrf51_soc_properties[] = {
+-inline void
 -smmu_iotlb_inv_iova(SMMUState *s, int asid, dma_addr_t iova,
 -                    uint8_t tg, uint64_t num_pages, uint8_t ttl)
 +void smmu_iotlb_inv_iova(SMMUState *s, int asid, dma_addr_t iova,
 +                         uint8_t tg, uint64_t num_pages, uint8_t ttl)
  {
      /* if tg is not set we use 4KB range invalidation */
      uint8_t granule = tg ? tg * 2 + 10 : 12;
@@ -XXX,XX +XXX,XX @@ smmu_iotlb_inv_iova(SMMUState *s, int asid, dma_addr_t iova,
                                  &info);
  }
 -inline void smmu_iotlb_inv_asid(SMMUState *s, uint16_t asid)
 +void smmu_iotlb_inv_asid(SMMUState *s, uint16_t asid)
  {
      trace_smmu_iotlb_inv_asid(asid);
      g_hash_table_foreach_remove(s->iotlb, smmu_hash_remove_by_asid, &asid);
@@ -XXX,XX +XXX,XX @@ error:
   *
   * return 0 on success
   */
 -inline int smmu_ptw(SMMUTransCfg *cfg, dma_addr_t iova, IOMMUAccessFlags perm,
 -                    SMMUTLBEntry *tlbe, SMMUPTWEventInfo *info)
 +int smmu_ptw(SMMUTransCfg *cfg, dma_addr_t iova, IOMMUAccessFlags perm,
 +             SMMUTLBEntry *tlbe, SMMUPTWEventInfo *info)
  {
      if (!cfg->aa64) {
          /*
 --
-.19.1
+.25.1

-New patch
+[PULL 30/34] i.MX7D: Connect GPT timers to IRQ
+From: Jean-Christophe Dubois <jcd@tribudubois.net>
+So far the GPT timers were unable to raise IRQs to the processor.
+Signed-off-by: Jean-Christophe Dubois <jcd@tribudubois.net>
+Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+---
+ include/hw/arm/fsl-imx7.h |  5 +++++
+ hw/arm/fsl-imx7.c         | 10 ++++++++++
+files changed, 15 insertions(+)
+diff --git a/include/hw/arm/fsl-imx7.h b/include/hw/arm/fsl-imx7.h
+index XXXXXXX..XXXXXXX 100644
+--- a/include/hw/arm/fsl-imx7.h
++++ b/include/hw/arm/fsl-imx7.h
+@@ -XXX,XX +XXX,XX @@ enum FslIMX7IRQs {
+     FSL_IMX7_USB2_IRQ     = 42,
+     FSL_IMX7_USB3_IRQ     = 40,
++    FSL_IMX7_GPT1_IRQ     = 55,
++    FSL_IMX7_GPT2_IRQ     = 54,
++    FSL_IMX7_GPT3_IRQ     = 53,
++    FSL_IMX7_GPT4_IRQ     = 52,
++
+     FSL_IMX7_WDOG1_IRQ    = 78,
+     FSL_IMX7_WDOG2_IRQ    = 79,
+     FSL_IMX7_WDOG3_IRQ    = 10,
+diff --git a/hw/arm/fsl-imx7.c b/hw/arm/fsl-imx7.c
+index XXXXXXX..XXXXXXX 100644
+--- a/hw/arm/fsl-imx7.c
++++ b/hw/arm/fsl-imx7.c
+@@ -XXX,XX +XXX,XX @@ static void fsl_imx7_realize(DeviceState *dev, Error **errp)
+             FSL_IMX7_GPT4_ADDR,
+         };
++        static const int FSL_IMX7_GPTn_IRQ[FSL_IMX7_NUM_GPTS] = {
++            FSL_IMX7_GPT1_IRQ,
++            FSL_IMX7_GPT2_IRQ,
++            FSL_IMX7_GPT3_IRQ,
++            FSL_IMX7_GPT4_IRQ,
++        };
++
+         s->gpt[i].ccm = IMX_CCM(&s->ccm);
+         sysbus_realize(SYS_BUS_DEVICE(&s->gpt[i]), &error_abort);
+         sysbus_mmio_map(SYS_BUS_DEVICE(&s->gpt[i]), 0, FSL_IMX7_GPTn_ADDR[i]);
++        sysbus_connect_irq(SYS_BUS_DEVICE(&s->gpt[i]), 0,
++                           qdev_get_gpio_in(DEVICE(&s->a7mpcore),
++                                            FSL_IMX7_GPTn_IRQ[i]));
+     }
+     for (i = 0; i < FSL_IMX7_NUM_GPIOS; i++) {
+--
+.25.1

-[Qemu-devel] [PULL 4/6] hw/char: Implement nRF51 SoC UART
+[PULL 31/34] i.MX7D: Compute clock frequency for the fixed frequency clocks.
-From: Julia Suvorova via Qemu-devel <qemu-devel@nongnu.org>
+From: Jean-Christophe Dubois <jcd@tribudubois.net>
-Not implemented: CTS/NCTS, PSEL*.
+CCM derived clocks will have to be added later.
-Signed-off-by: Julia Suvorova <jusual@mail.ru>
+Signed-off-by: Jean-Christophe Dubois <jcd@tribudubois.net>
-Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
+Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
 Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
 ---
- hw/char/Makefile.objs        |   1 +
+ hw/misc/imx7_ccm.c | 49 +++++++++++++++++++++++++++++++++++++---------
- include/hw/char/nrf51_uart.h |  78 +++++++++
+file changed, 40 insertions(+), 9 deletions(-)
  hw/char/nrf51_uart.c         | 330 +++++++++++++++++++++++++++++++++++
  hw/char/trace-events         |   4 +
 files changed, 413 insertions(+)
  create mode 100644 include/hw/char/nrf51_uart.h
  create mode 100644 hw/char/nrf51_uart.c
-diff --git a/hw/char/Makefile.objs b/hw/char/Makefile.objs
+diff --git a/hw/misc/imx7_ccm.c b/hw/misc/imx7_ccm.c
 index XXXXXXX..XXXXXXX 100644
---- a/hw/char/Makefile.objs
+--- a/hw/misc/imx7_ccm.c
-+++ b/hw/char/Makefile.objs
++++ b/hw/misc/imx7_ccm.c
 @@ -XXX,XX +XXX,XX @@
- common-obj-$(CONFIG_IPACK) += ipoctal232.o
+ #include "hw/misc/imx7_ccm.h"
- common-obj-$(CONFIG_ESCC) += escc.o
+ #include "migration/vmstate.h"
-+common-obj-$(CONFIG_NRF51_SOC) += nrf51_uart.o
  common-obj-$(CONFIG_PARALLEL) += parallel.o
  common-obj-$(CONFIG_PARALLEL) += parallel-isa.o
  common-obj-$(CONFIG_PL011) += pl011.o
 diff --git a/include/hw/char/nrf51_uart.h b/include/hw/char/nrf51_uart.h
 new file mode 100644
 index XXXXXXX..XXXXXXX
 --- /dev/null
 +++ b/include/hw/char/nrf51_uart.h
@@ -XXX,XX +XXX,XX @@
 +/*
 + * nRF51 SoC UART emulation
 + *
 + * Copyright (c) 2018 Julia Suvorova <jusual@mail.ru>
 + *
 + * This program is free software; you can redistribute it and/or modify
 + * it under the terms of the GNU General Public License version 2 or
 + * (at your option) any later version.
 + */
 +
 +#ifndef NRF51_UART_H
 +#define NRF51_UART_H
 +
 +#include "hw/sysbus.h"
 +#include "chardev/char-fe.h"
 +#include "hw/registerfields.h"
 +
 +#define UART_FIFO_LENGTH 6
 +#define UART_BASE 0x40002000
 +#define UART_SIZE 0x1000
 +
 +#define TYPE_NRF51_UART "nrf51_soc.uart"
 +#define NRF51_UART(obj) OBJECT_CHECK(NRF51UARTState, (obj), TYPE_NRF51_UART)
 +
 +REG32(UART_STARTRX, 0x000)
 +REG32(UART_STOPRX, 0x004)
 +REG32(UART_STARTTX, 0x008)
 +REG32(UART_STOPTX, 0x00C)
 +REG32(UART_SUSPEND, 0x01C)
 +
 +REG32(UART_CTS, 0x100)
 +REG32(UART_NCTS, 0x104)
 +REG32(UART_RXDRDY, 0x108)
 +REG32(UART_TXDRDY, 0x11C)
 +REG32(UART_ERROR, 0x124)
 +REG32(UART_RXTO, 0x144)
 +
 +REG32(UART_INTEN, 0x300)
 +    FIELD(UART_INTEN, CTS, 0, 1)
 +    FIELD(UART_INTEN, NCTS, 1, 1)
 +    FIELD(UART_INTEN, RXDRDY, 2, 1)
 +    FIELD(UART_INTEN, TXDRDY, 7, 1)
 +    FIELD(UART_INTEN, ERROR, 9, 1)
 +    FIELD(UART_INTEN, RXTO, 17, 1)
 +REG32(UART_INTENSET, 0x304)
 +REG32(UART_INTENCLR, 0x308)
 +REG32(UART_ERRORSRC, 0x480)
 +REG32(UART_ENABLE, 0x500)
 +REG32(UART_PSELRTS, 0x508)
 +REG32(UART_PSELTXD, 0x50C)
 +REG32(UART_PSELCTS, 0x510)
 +REG32(UART_PSELRXD, 0x514)
 +REG32(UART_RXD, 0x518)
 +REG32(UART_TXD, 0x51C)
 +REG32(UART_BAUDRATE, 0x524)
 +REG32(UART_CONFIG, 0x56C)
 +
 +typedef struct NRF51UARTState {
 +    SysBusDevice parent_obj;
 +
 +    MemoryRegion iomem;
 +    CharBackend chr;
 +    qemu_irq irq;
 +    guint watch_tag;
 +
 +    uint8_t rx_fifo[UART_FIFO_LENGTH];
 +    unsigned int rx_fifo_pos;
 +    unsigned int rx_fifo_len;
 +
 +    uint32_t reg[0x56C];
 +
 +    bool rx_started;
 +    bool tx_started;
 +    bool pending_tx_byte;
 +    bool enabled;
 +} NRF51UARTState;
 +
 +#endif
 diff --git a/hw/char/nrf51_uart.c b/hw/char/nrf51_uart.c
 new file mode 100644
 index XXXXXXX..XXXXXXX
 --- /dev/null
 +++ b/hw/char/nrf51_uart.c
@@ -XXX,XX +XXX,XX @@
 +/*
 + * nRF51 SoC UART emulation
 + *
 + * See nRF51 Series Reference Manual, "29 Universal Asynchronous
 + * Receiver/Transmitter" for hardware specifications:
 + * http://infocenter.nordicsemi.com/pdf/nRF51_RM_v3.0.pdf
 + *
 + * Copyright (c) 2018 Julia Suvorova <jusual@mail.ru>
 + *
 + * This program is free software; you can redistribute it and/or modify
 + * it under the terms of the GNU General Public License version 2 or
 + * (at your option) any later version.
 + */
 +
 +#include "qemu/osdep.h"
 +#include "qemu/log.h"
 +#include "hw/char/nrf51_uart.h"
 +#include "trace.h"
 +
-+static void nrf51_uart_update_irq(NRF51UARTState *s)
++#define CKIH_FREQ 24000000 /* 24MHz crystal input */
 +{
 +    bool irq = false;
 +
-+    irq |= (s->reg[R_UART_RXDRDY] &&
+ static void imx7_analog_reset(DeviceState *dev)
-+            (s->reg[R_UART_INTEN] & R_UART_INTEN_RXDRDY_MASK));
+ {
-+    irq |= (s->reg[R_UART_TXDRDY] &&
+     IMX7AnalogState *s = IMX7_ANALOG(dev);
-+            (s->reg[R_UART_INTEN] & R_UART_INTEN_TXDRDY_MASK));
+@@ -XXX,XX +XXX,XX @@ static const VMStateDescription vmstate_imx7_ccm = {
-+    irq |= (s->reg[R_UART_ERROR]  &&
+ static uint32_t imx7_ccm_get_clock_frequency(IMXCCMState *dev, IMXClk clock)
-+            (s->reg[R_UART_INTEN] & R_UART_INTEN_ERROR_MASK));
+ {
-+    irq |= (s->reg[R_UART_RXTO]   &&
+     /*
-+            (s->reg[R_UART_INTEN] & R_UART_INTEN_RXTO_MASK));
+-     * This function is "consumed" by GPT emulation code, however on
 -     * i.MX7 each GPT block can have their own clock root. This means
 -     * that this functions needs somehow to know requester's identity
 -     * and the way to pass it: be it via additional IMXClk constants
 -     * or by adding another argument to this method needs to be
 -     * figured out
 +     * This function is "consumed" by GPT emulation code. Some clocks
 +     * have fixed frequencies and we can provide requested frequency
 +     * easily. However for CCM provided clocks (like IPG) each GPT
 +     * timer can have its own clock root.
 +     * This means we need additionnal information when calling this
 +     * function to know the requester's identity.
       */
 -    qemu_log_mask(LOG_GUEST_ERROR, "[%s]%s: Not implemented\n",
 -                  TYPE_IMX7_CCM, __func__);
 -    return 0;
 +    uint32_t freq = 0;
 +
-+    qemu_set_irq(s->irq, irq);
++    switch (clock) {
-+}
++    case CLK_NONE:
 +
 +static uint64_t uart_read(void *opaque, hwaddr addr, unsigned int size)
 +{
 +    NRF51UARTState *s = NRF51_UART(opaque);
 +    uint64_t r;
 +
 +    if (!s->enabled) {
 +        return 0;
 +    }
 +
 +    switch (addr) {
 +    case A_UART_RXD:
 +        r = s->rx_fifo[s->rx_fifo_pos];
 +        if (s->rx_started && s->rx_fifo_len) {
 +            s->rx_fifo_pos = (s->rx_fifo_pos + 1) % UART_FIFO_LENGTH;
 +            s->rx_fifo_len--;
 +            if (s->rx_fifo_len) {
 +                s->reg[R_UART_RXDRDY] = 1;
 +                nrf51_uart_update_irq(s);
 +            }
 +            qemu_chr_fe_accept_input(&s->chr);
 +        }
 +        break;
-+    case A_UART_INTENSET:
++    case CLK_32k:
-+    case A_UART_INTENCLR:
++        freq = CKIL_FREQ;
-+    case A_UART_INTEN:
++        break;
-+        r = s->reg[R_UART_INTEN];
++    case CLK_HIGH:
 +        freq = CKIH_FREQ;
 +        break;
 +    case CLK_IPG:
 +    case CLK_IPG_HIGH:
 +        /*
 +         * For now we don't have a way to figure out the device this
 +         * function is called for. Until then the IPG derived clocks
 +         * are left unimplemented.
 +         */
 +        qemu_log_mask(LOG_GUEST_ERROR, "[%s]%s: Clock %d Not implemented\n",
 +                      TYPE_IMX7_CCM, __func__, clock);
 +        break;
 +    default:
-+        r = s->reg[addr / 4];
++        qemu_log_mask(LOG_GUEST_ERROR, "[%s]%s: unsupported clock %d\n",
 +                      TYPE_IMX7_CCM, __func__, clock);
 +        break;
 +    }
 +
-+    trace_nrf51_uart_read(addr, r, size);
++    trace_ccm_clock_freq(clock, freq);
 +
-+    return r;
++    return freq;
-+}
+ }
-+
-+static gboolean uart_transmit(GIOChannel *chan, GIOCondition cond, void *opaque)
+ static void imx7_ccm_class_init(ObjectClass *klass, void *data)
 +{
 +    NRF51UARTState *s = NRF51_UART(opaque);
 +    int r;
 +    uint8_t c = s->reg[R_UART_TXD];
 +
 +    s->watch_tag = 0;
 +
 +    r = qemu_chr_fe_write(&s->chr, &c, 1);
 +    if (r <= 0) {
 +        s->watch_tag = qemu_chr_fe_add_watch(&s->chr, G_IO_OUT | G_IO_HUP,
 +                                             uart_transmit, s);
 +        if (!s->watch_tag) {
 +            /* The hardware has no transmit error reporting,
 +             * so silently drop the byte
 +             */
 +            goto buffer_drained;
 +        }
 +        return FALSE;
 +    }
 +
 +buffer_drained:
 +    s->reg[R_UART_TXDRDY] = 1;
 +    s->pending_tx_byte = false;
 +    return FALSE;
 +}
 +
 +static void uart_cancel_transmit(NRF51UARTState *s)
 +{
 +    if (s->watch_tag) {
 +        g_source_remove(s->watch_tag);
 +        s->watch_tag = 0;
 +    }
 +}
 +
 +static void uart_write(void *opaque, hwaddr addr,
 +                       uint64_t value, unsigned int size)
 +{
 +    NRF51UARTState *s = NRF51_UART(opaque);
 +
 +    trace_nrf51_uart_write(addr, value, size);
 +
 +    if (!s->enabled && (addr != A_UART_ENABLE)) {
 +        return;
 +    }
 +
 +    switch (addr) {
 +    case A_UART_TXD:
 +        if (!s->pending_tx_byte && s->tx_started) {
 +            s->reg[R_UART_TXD] = value;
 +            s->pending_tx_byte = true;
 +            uart_transmit(NULL, G_IO_OUT, s);
 +        }
 +        break;
 +    case A_UART_INTEN:
 +        s->reg[R_UART_INTEN] = value;
 +        break;
 +    case A_UART_INTENSET:
 +        s->reg[R_UART_INTEN] |= value;
 +        break;
 +    case A_UART_INTENCLR:
 +        s->reg[R_UART_INTEN] &= ~value;
 +        break;
 +    case A_UART_TXDRDY ... A_UART_RXTO:
 +        s->reg[addr / 4] = value;
 +        break;
 +    case A_UART_ERRORSRC:
 +        s->reg[addr / 4] &= ~value;
 +        break;
 +    case A_UART_RXD:
 +        break;
 +    case A_UART_RXDRDY:
 +        if (value == 0) {
 +            s->reg[R_UART_RXDRDY] = 0;
 +        }
 +        break;
 +    case A_UART_STARTTX:
 +        if (value == 1) {
 +            s->tx_started = true;
 +        }
 +        break;
 +    case A_UART_STARTRX:
 +        if (value == 1) {
 +            s->rx_started = true;
 +        }
 +        break;
 +    case A_UART_ENABLE:
 +        if (value) {
 +            if (value == 4) {
 +                s->enabled = true;
 +            }
 +            break;
 +        }
 +        s->enabled = false;
 +        value = 1;
 +        /* fall through */
 +    case A_UART_SUSPEND:
 +    case A_UART_STOPTX:
 +        if (value == 1) {
 +            s->tx_started = false;
 +        }
 +        /* fall through */
 +    case A_UART_STOPRX:
 +        if (addr != A_UART_STOPTX && value == 1) {
 +            s->rx_started = false;
 +            s->reg[R_UART_RXTO] = 1;
 +        }
 +        break;
 +    default:
 +        s->reg[addr / 4] = value;
 +        break;
 +    }
 +    nrf51_uart_update_irq(s);
 +}
 +
 +static const MemoryRegionOps uart_ops = {
 +    .read =  uart_read,
 +    .write = uart_write,
 +    .endianness = DEVICE_LITTLE_ENDIAN,
 +};
 +
 +static void nrf51_uart_reset(DeviceState *dev)
 +{
 +    NRF51UARTState *s = NRF51_UART(dev);
 +
 +    s->pending_tx_byte = 0;
 +
 +    uart_cancel_transmit(s);
 +
 +    memset(s->reg, 0, sizeof(s->reg));
 +
 +    s->reg[R_UART_PSELRTS] = 0xFFFFFFFF;
 +    s->reg[R_UART_PSELTXD] = 0xFFFFFFFF;
 +    s->reg[R_UART_PSELCTS] = 0xFFFFFFFF;
 +    s->reg[R_UART_PSELRXD] = 0xFFFFFFFF;
 +    s->reg[R_UART_BAUDRATE] = 0x4000000;
 +
 +    s->rx_fifo_len = 0;
 +    s->rx_fifo_pos = 0;
 +    s->rx_started = false;
 +    s->tx_started = false;
 +    s->enabled = false;
 +}
 +
 +static void uart_receive(void *opaque, const uint8_t *buf, int size)
 +{
 +
 +    NRF51UARTState *s = NRF51_UART(opaque);
 +    int i;
 +
 +    if (size == 0 || s->rx_fifo_len >= UART_FIFO_LENGTH) {
 +        return;
 +    }
 +
 +    for (i = 0; i < size; i++) {
 +        uint32_t pos = (s->rx_fifo_pos + s->rx_fifo_len) % UART_FIFO_LENGTH;
 +        s->rx_fifo[pos] = buf[i];
 +        s->rx_fifo_len++;
 +    }
 +
 +    s->reg[R_UART_RXDRDY] = 1;
 +    nrf51_uart_update_irq(s);
 +}
 +
 +static int uart_can_receive(void *opaque)
 +{
 +    NRF51UARTState *s = NRF51_UART(opaque);
 +
 +    return s->rx_started ? (UART_FIFO_LENGTH - s->rx_fifo_len) : 0;
 +}
 +
 +static void uart_event(void *opaque, int event)
 +{
 +    NRF51UARTState *s = NRF51_UART(opaque);
 +
 +    if (event == CHR_EVENT_BREAK) {
 +        s->reg[R_UART_ERRORSRC] |= 3;
 +        s->reg[R_UART_ERROR] = 1;
 +        nrf51_uart_update_irq(s);
 +    }
 +}
 +
 +static void nrf51_uart_realize(DeviceState *dev, Error **errp)
 +{
 +    NRF51UARTState *s = NRF51_UART(dev);
 +
 +    qemu_chr_fe_set_handlers(&s->chr, uart_can_receive, uart_receive,
 +                             uart_event, NULL, s, NULL, true);
 +}
 +
 +static void nrf51_uart_init(Object *obj)
 +{
 +    NRF51UARTState *s = NRF51_UART(obj);
 +    SysBusDevice *sbd = SYS_BUS_DEVICE(obj);
 +
 +    memory_region_init_io(&s->iomem, obj, &uart_ops, s,
 +                          "nrf51_soc.uart", UART_SIZE);
 +    sysbus_init_mmio(sbd, &s->iomem);
 +    sysbus_init_irq(sbd, &s->irq);
 +}
 +
 +static int nrf51_uart_post_load(void *opaque, int version_id)
 +{
 +    NRF51UARTState *s = NRF51_UART(opaque);
 +
 +    if (s->pending_tx_byte) {
 +        s->watch_tag = qemu_chr_fe_add_watch(&s->chr, G_IO_OUT | G_IO_HUP,
 +                                             uart_transmit, s);
 +    }
 +
 +    return 0;
 +}
 +
 +static const VMStateDescription nrf51_uart_vmstate = {
 +    .name = "nrf51_soc.uart",
 +    .post_load = nrf51_uart_post_load,
 +    .fields = (VMStateField[]) {
 +        VMSTATE_UINT32_ARRAY(reg, NRF51UARTState, 0x56C),
 +        VMSTATE_UINT8_ARRAY(rx_fifo, NRF51UARTState, UART_FIFO_LENGTH),
 +        VMSTATE_UINT32(rx_fifo_pos, NRF51UARTState),
 +        VMSTATE_UINT32(rx_fifo_len, NRF51UARTState),
 +        VMSTATE_BOOL(rx_started, NRF51UARTState),
 +        VMSTATE_BOOL(tx_started, NRF51UARTState),
 +        VMSTATE_BOOL(pending_tx_byte, NRF51UARTState),
 +        VMSTATE_BOOL(enabled, NRF51UARTState),
 +        VMSTATE_END_OF_LIST()
 +    }
 +};
 +
 +static Property nrf51_uart_properties[] = {
 +    DEFINE_PROP_CHR("chardev", NRF51UARTState, chr),
 +    DEFINE_PROP_END_OF_LIST(),
 +};
 +
 +static void nrf51_uart_class_init(ObjectClass *klass, void *data)
 +{
 +    DeviceClass *dc = DEVICE_CLASS(klass);
 +
 +    dc->reset = nrf51_uart_reset;
 +    dc->realize = nrf51_uart_realize;
 +    dc->props = nrf51_uart_properties;
 +    dc->vmsd = &nrf51_uart_vmstate;
 +}
 +
 +static const TypeInfo nrf51_uart_info = {
 +    .name = TYPE_NRF51_UART,
 +    .parent = TYPE_SYS_BUS_DEVICE,
 +    .instance_size = sizeof(NRF51UARTState),
 +    .instance_init = nrf51_uart_init,
 +    .class_init = nrf51_uart_class_init
 +};
 +
 +static void nrf51_uart_register_types(void)
 +{
 +    type_register_static(&nrf51_uart_info);
 +}
 +
 +type_init(nrf51_uart_register_types)
 diff --git a/hw/char/trace-events b/hw/char/trace-events
 index XXXXXXX..XXXXXXX 100644
 --- a/hw/char/trace-events
 +++ b/hw/char/trace-events
@@ -XXX,XX +XXX,XX @@ cmsdk_apb_uart_receive(uint8_t c) "CMSDK APB UART: got character 0x%x from backe
  cmsdk_apb_uart_tx_pending(void) "CMSDK APB UART: character send to backend pending"
  cmsdk_apb_uart_tx(uint8_t c) "CMSDK APB UART: character 0x%x sent to backend"
  cmsdk_apb_uart_set_params(int speed) "CMSDK APB UART: params set to %d 8N1"
 +
 +# hw/char/nrf51_uart.c
 +nrf51_uart_read(uint64_t addr, uint64_t r, unsigned int size) "addr 0x%" PRIx64 " value 0x%" PRIx64 " size %u"
 +nrf51_uart_write(uint64_t addr, uint64_t value, unsigned int size) "addr 0x%" PRIx64 " value 0x%" PRIx64 " size %u"
 --
-.19.1
+.25.1

-New patch
+[PULL 32/34] i.MX6UL: Add a specific GPT timer instance for the i.MX6UL
+From: Jean-Christophe Dubois <jcd@tribudubois.net>
+The i.MX6UL doesn't support CLK_HIGH ou CLK_HIGH_DIV clock source.
+Signed-off-by: Jean-Christophe Dubois <jcd@tribudubois.net>
+Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+---
+ include/hw/timer/imx_gpt.h |  1 +
+ hw/arm/fsl-imx6ul.c        |  2 +-
+ hw/misc/imx6ul_ccm.c       |  6 ------
+ hw/timer/imx_gpt.c         | 25 +++++++++++++++++++++++++
+files changed, 27 insertions(+), 7 deletions(-)
+diff --git a/include/hw/timer/imx_gpt.h b/include/hw/timer/imx_gpt.h
+index XXXXXXX..XXXXXXX 100644
+--- a/include/hw/timer/imx_gpt.h
++++ b/include/hw/timer/imx_gpt.h
+@@ -XXX,XX +XXX,XX @@
+ #define TYPE_IMX25_GPT "imx25.gpt"
+ #define TYPE_IMX31_GPT "imx31.gpt"
+ #define TYPE_IMX6_GPT "imx6.gpt"
++#define TYPE_IMX6UL_GPT "imx6ul.gpt"
+ #define TYPE_IMX7_GPT "imx7.gpt"
+ #define TYPE_IMX_GPT TYPE_IMX25_GPT
+diff --git a/hw/arm/fsl-imx6ul.c b/hw/arm/fsl-imx6ul.c
+index XXXXXXX..XXXXXXX 100644
+--- a/hw/arm/fsl-imx6ul.c
++++ b/hw/arm/fsl-imx6ul.c
+@@ -XXX,XX +XXX,XX @@ static void fsl_imx6ul_init(Object *obj)
+      */
+     for (i = 0; i < FSL_IMX6UL_NUM_GPTS; i++) {
+         snprintf(name, NAME_SIZE, "gpt%d", i);
+-        object_initialize_child(obj, name, &s->gpt[i], TYPE_IMX7_GPT);
++        object_initialize_child(obj, name, &s->gpt[i], TYPE_IMX6UL_GPT);
+     }
+     /*
+diff --git a/hw/misc/imx6ul_ccm.c b/hw/misc/imx6ul_ccm.c
+index XXXXXXX..XXXXXXX 100644
+--- a/hw/misc/imx6ul_ccm.c
++++ b/hw/misc/imx6ul_ccm.c
+@@ -XXX,XX +XXX,XX @@ static uint32_t imx6ul_ccm_get_clock_frequency(IMXCCMState *dev, IMXClk clock)
+     case CLK_32k:
+         freq = CKIL_FREQ;
+         break;
+-    case CLK_HIGH:
+-        freq = CKIH_FREQ;
+-        break;
+-    case CLK_HIGH_DIV:
+-        freq = CKIH_FREQ / 8;
+-        break;
+     default:
+         qemu_log_mask(LOG_GUEST_ERROR, "[%s]%s: unsupported clock %d\n",
+                       TYPE_IMX6UL_CCM, __func__, clock);
+diff --git a/hw/timer/imx_gpt.c b/hw/timer/imx_gpt.c
+index XXXXXXX..XXXXXXX 100644
+--- a/hw/timer/imx_gpt.c
++++ b/hw/timer/imx_gpt.c
+@@ -XXX,XX +XXX,XX @@ static const IMXClk imx6_gpt_clocks[] = {
+     CLK_HIGH,      /* 111 reference clock */
+ };
++static const IMXClk imx6ul_gpt_clocks[] = {
++    CLK_NONE,      /* 000 No clock source */
++    CLK_IPG,       /* 001 ipg_clk, 532MHz*/
++    CLK_IPG_HIGH,  /* 010 ipg_clk_highfreq */
++    CLK_EXT,       /* 011 External clock */
++    CLK_32k,       /* 100 ipg_clk_32k */
++    CLK_NONE,      /* 101 not defined */
++    CLK_NONE,      /* 110 not defined */
++    CLK_NONE,      /* 111 not defined */
++};
++
+ static const IMXClk imx7_gpt_clocks[] = {
+     CLK_NONE,      /* 000 No clock source */
+     CLK_IPG,       /* 001 ipg_clk, 532MHz*/
+@@ -XXX,XX +XXX,XX @@ static void imx6_gpt_init(Object *obj)
+     s->clocks = imx6_gpt_clocks;
+ }
++static void imx6ul_gpt_init(Object *obj)
++{
++    IMXGPTState *s = IMX_GPT(obj);
++
++    s->clocks = imx6ul_gpt_clocks;
++}
++
+ static void imx7_gpt_init(Object *obj)
+ {
+     IMXGPTState *s = IMX_GPT(obj);
+@@ -XXX,XX +XXX,XX @@ static const TypeInfo imx6_gpt_info = {
+     .instance_init = imx6_gpt_init,
+ };
++static const TypeInfo imx6ul_gpt_info = {
++    .name = TYPE_IMX6UL_GPT,
++    .parent = TYPE_IMX25_GPT,
++    .instance_init = imx6ul_gpt_init,
++};
++
+ static const TypeInfo imx7_gpt_info = {
+     .name = TYPE_IMX7_GPT,
+     .parent = TYPE_IMX25_GPT,
+@@ -XXX,XX +XXX,XX @@ static void imx_gpt_register_types(void)
+     type_register_static(&imx25_gpt_info);
+     type_register_static(&imx31_gpt_info);
+     type_register_static(&imx6_gpt_info);
++    type_register_static(&imx6ul_gpt_info);
+     type_register_static(&imx7_gpt_info);
+ }
+--
+.25.1

-New patch
+[PULL 33/34] i.MX7D: Connect IRQs to GPIO devices.
+From: Jean-Christophe Dubois <jcd@tribudubois.net>
+IRQs were not associated to the various GPIO devices inside i.MX7D.
+This patch brings the i.MX7D on par with i.MX6.
+Signed-off-by: Jean-Christophe Dubois <jcd@tribudubois.net>
+Message-id: 20221226101418.415170-1-jcd@tribudubois.net
+Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+---
+ include/hw/arm/fsl-imx7.h | 15 +++++++++++++++
+ hw/arm/fsl-imx7.c         | 31 ++++++++++++++++++++++++++++++-
+files changed, 45 insertions(+), 1 deletion(-)
+diff --git a/include/hw/arm/fsl-imx7.h b/include/hw/arm/fsl-imx7.h
+index XXXXXXX..XXXXXXX 100644
+--- a/include/hw/arm/fsl-imx7.h
++++ b/include/hw/arm/fsl-imx7.h
+@@ -XXX,XX +XXX,XX @@ enum FslIMX7IRQs {
+     FSL_IMX7_GPT3_IRQ     = 53,
+     FSL_IMX7_GPT4_IRQ     = 52,
++    FSL_IMX7_GPIO1_LOW_IRQ  = 64,
++    FSL_IMX7_GPIO1_HIGH_IRQ = 65,
++    FSL_IMX7_GPIO2_LOW_IRQ  = 66,
++    FSL_IMX7_GPIO2_HIGH_IRQ = 67,
++    FSL_IMX7_GPIO3_LOW_IRQ  = 68,
++    FSL_IMX7_GPIO3_HIGH_IRQ = 69,
++    FSL_IMX7_GPIO4_LOW_IRQ  = 70,
++    FSL_IMX7_GPIO4_HIGH_IRQ = 71,
++    FSL_IMX7_GPIO5_LOW_IRQ  = 72,
++    FSL_IMX7_GPIO5_HIGH_IRQ = 73,
++    FSL_IMX7_GPIO6_LOW_IRQ  = 74,
++    FSL_IMX7_GPIO6_HIGH_IRQ = 75,
++    FSL_IMX7_GPIO7_LOW_IRQ  = 76,
++    FSL_IMX7_GPIO7_HIGH_IRQ = 77,
++
+     FSL_IMX7_WDOG1_IRQ    = 78,
+     FSL_IMX7_WDOG2_IRQ    = 79,
+     FSL_IMX7_WDOG3_IRQ    = 10,
+diff --git a/hw/arm/fsl-imx7.c b/hw/arm/fsl-imx7.c
+index XXXXXXX..XXXXXXX 100644
+--- a/hw/arm/fsl-imx7.c
++++ b/hw/arm/fsl-imx7.c
+@@ -XXX,XX +XXX,XX @@ static void fsl_imx7_realize(DeviceState *dev, Error **errp)
+             FSL_IMX7_GPIO7_ADDR,
+         };
++        static const int FSL_IMX7_GPIOn_LOW_IRQ[FSL_IMX7_NUM_GPIOS] = {
++            FSL_IMX7_GPIO1_LOW_IRQ,
++            FSL_IMX7_GPIO2_LOW_IRQ,
++            FSL_IMX7_GPIO3_LOW_IRQ,
++            FSL_IMX7_GPIO4_LOW_IRQ,
++            FSL_IMX7_GPIO5_LOW_IRQ,
++            FSL_IMX7_GPIO6_LOW_IRQ,
++            FSL_IMX7_GPIO7_LOW_IRQ,
++        };
++
++        static const int FSL_IMX7_GPIOn_HIGH_IRQ[FSL_IMX7_NUM_GPIOS] = {
++            FSL_IMX7_GPIO1_HIGH_IRQ,
++            FSL_IMX7_GPIO2_HIGH_IRQ,
++            FSL_IMX7_GPIO3_HIGH_IRQ,
++            FSL_IMX7_GPIO4_HIGH_IRQ,
++            FSL_IMX7_GPIO5_HIGH_IRQ,
++            FSL_IMX7_GPIO6_HIGH_IRQ,
++            FSL_IMX7_GPIO7_HIGH_IRQ,
++        };
++
+         sysbus_realize(SYS_BUS_DEVICE(&s->gpio[i]), &error_abort);
+-        sysbus_mmio_map(SYS_BUS_DEVICE(&s->gpio[i]), 0, FSL_IMX7_GPIOn_ADDR[i]);
++        sysbus_mmio_map(SYS_BUS_DEVICE(&s->gpio[i]), 0,
++                        FSL_IMX7_GPIOn_ADDR[i]);
++
++        sysbus_connect_irq(SYS_BUS_DEVICE(&s->gpio[i]), 0,
++                           qdev_get_gpio_in(DEVICE(&s->a7mpcore),
++                                            FSL_IMX7_GPIOn_LOW_IRQ[i]));
++
++        sysbus_connect_irq(SYS_BUS_DEVICE(&s->gpio[i]), 1,
++                           qdev_get_gpio_in(DEVICE(&s->a7mpcore),
++                                            FSL_IMX7_GPIOn_HIGH_IRQ[i]));
+     }
+     /*
+--
+.25.1

-New patch
+[PULL 34/34] hw/net: Fix read of uninitialized memory in imx_fec.
+From: Stephen Longfield <slongfield@google.com>
+Size is used at lines 1088/1188 for the loop, which reads the last 4
+bytes from the crc_ptr so it does need to get increased, however it
+shouldn't be increased before the buffer is passed to CRC computation,
+or the crc32 function will access uninitialized memory.
+This was pointed out to me by clg@kaod.org during the code review of
+a similar patch to hw/net/ftgmac100.c
+Change-Id: Ib0464303b191af1e28abeb2f5105eb25aadb5e9b
+Signed-off-by: Stephen Longfield <slongfield@google.com>
+Reviewed-by: Patrick Venture <venture@google.com>
+Message-id: 20221221183202.3788132-1-slongfield@google.com
+Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
+Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
+---
+ hw/net/imx_fec.c | 8 ++++----
+file changed, 4 insertions(+), 4 deletions(-)
+diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c
+index XXXXXXX..XXXXXXX 100644
+--- a/hw/net/imx_fec.c
++++ b/hw/net/imx_fec.c
+@@ -XXX,XX +XXX,XX @@ static ssize_t imx_fec_receive(NetClientState *nc, const uint8_t *buf,
+         return 0;
+     }
+-    /* 4 bytes for the CRC.  */
+-    size += 4;
+     crc = cpu_to_be32(crc32(~0, buf, size));
++    /* Increase size by 4, loop below reads the last 4 bytes from crc_ptr. */
++    size += 4;
+     crc_ptr = (uint8_t *) &crc;
+     /* Huge frames are truncated.  */
+@@ -XXX,XX +XXX,XX @@ static ssize_t imx_enet_receive(NetClientState *nc, const uint8_t *buf,
+         return 0;
+     }
+-    /* 4 bytes for the CRC.  */
+-    size += 4;
+     crc = cpu_to_be32(crc32(~0, buf, size));
++    /* Increase size by 4, loop below reads the last 4 bytes from crc_ptr. */
++    size += 4;
+     crc_ptr = (uint8_t *) &crc;
+     if (shift16) {
+--
+.25.1

Last lot of patches for arm before softfreeze tomorrow...

thanks
-- PMM

The following changes since commit ef3a6af5e789ff078d1fef880f9dfb6adf18e8f1:

Merge remote-tracking branch 'remotes/kraxel/tags/vga-20181029-pull-request' into staging (2018-10-29 12:59:15 +0000)

are available in the Git repository at:

https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20181029

for you to fetch changes up to 20cf5663734310a282e27b7389bc9f53ffe227e6:

tests/boot-serial-test: Add microbit board testcase (2018-10-29 15:19:48 +0000)

----------------------------------------------------------------
target-arm queue:
 * microbit: Add the UART to our nRF51 SoC model
 * Add a virtual Xilinx Versal board "xlnx-versal-virt"
 * hw/arm/virt: Set VIRT_COMPAT_3_0 compat

----------------------------------------------------------------
Edgar E. Iglesias (2):
      hw/arm: versal: Add a model of Xilinx Versal SoC
      hw/arm: versal: Add a virtual Xilinx Versal board

Eric Auger (1):
      hw/arm/virt: Set VIRT_COMPAT_3_0 compat

Julia Suvorova (3):
      hw/char: Implement nRF51 SoC UART
      hw/arm/nrf51_soc: Connect UART to nRF51 SoC
      tests/boot-serial-test: Add microbit board testcase

hw/arm/Makefile.objs                |   1 +
 hw/char/Makefile.objs               |   1 +
 include/hw/arm/nrf51_soc.h          |   3 +
 include/hw/arm/xlnx-versal.h        | 122 +++++++++
 include/hw/char/nrf51_uart.h        |  78 ++++++
 hw/arm/microbit.c                   |   2 +
 hw/arm/nrf51_soc.c                  |  20 ++
 hw/arm/virt.c                       |   4 +
 hw/arm/xlnx-versal-virt.c           | 493 ++++++++++++++++++++++++++++++++++++
 hw/arm/xlnx-versal.c                | 323 +++++++++++++++++++++++
 hw/char/nrf51_uart.c                | 330 ++++++++++++++++++++++++
 tests/boot-serial-test.c            |  19 ++
 default-configs/aarch64-softmmu.mak |   1 +
 hw/char/trace-events                |   4 +
 14 files changed, 1401 insertions(+)
 create mode 100644 include/hw/arm/xlnx-versal.h
 create mode 100644 include/hw/char/nrf51_uart.h
 create mode 100644 hw/arm/xlnx-versal-virt.c
 create mode 100644 hw/arm/xlnx-versal.c
 create mode 100644 hw/char/nrf51_uart.c

From: Eric Auger <eric.auger@redhat.com>

We are missing the VIRT_COMPAT_3_0 definition and setting.
Let's add them.

Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Andrew Jones <drjones@redhat.com>
Message-id: 20181024085602.16611-1-eric.auger@redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/arm/virt.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -XXX,XX +XXX,XX @@ static void virt_machine_3_1_options(MachineClass *mc)
 }
 DEFINE_VIRT_MACHINE_AS_LATEST(3, 1)
 
+#define VIRT_COMPAT_3_0 \
+    HW_COMPAT_3_0
+
 static void virt_3_0_instance_init(Object *obj)
 {
     virt_3_1_instance_init(obj);
@@ -XXX,XX +XXX,XX @@ static void virt_3_0_instance_init(Object *obj)
 static void virt_machine_3_0_options(MachineClass *mc)
 {
     virt_machine_3_1_options(mc);
+    SET_MACHINE_COMPAT(mc, VIRT_COMPAT_3_0);
 }
 DEFINE_VIRT_MACHINE(3, 0)
 
-- 
2.19.1

From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>

Add a model of Xilinx Versal SoC.

Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/arm/Makefile.objs                |   1 +
 include/hw/arm/xlnx-versal.h        | 122 +++++++++++
 hw/arm/xlnx-versal.c                | 323 ++++++++++++++++++++++++++++
 default-configs/aarch64-softmmu.mak |   1 +
 4 files changed, 447 insertions(+)
 create mode 100644 include/hw/arm/xlnx-versal.h
 create mode 100644 hw/arm/xlnx-versal.c

diff --git a/hw/arm/Makefile.objs b/hw/arm/Makefile.objs
index XXXXXXX..XXXXXXX 100644
--- a/hw/arm/Makefile.objs
+++ b/hw/arm/Makefile.objs
@@ -XXX,XX +XXX,XX @@ obj-$(CONFIG_ALLWINNER_A10) += allwinner-a10.o cubieboard.o
 obj-$(CONFIG_RASPI) += bcm2835_peripherals.o bcm2836.o raspi.o
 obj-$(CONFIG_STM32F205_SOC) += stm32f205_soc.o
 obj-$(CONFIG_XLNX_ZYNQMP_ARM) += xlnx-zynqmp.o xlnx-zcu102.o
+obj-$(CONFIG_XLNX_VERSAL) += xlnx-versal.o
 obj-$(CONFIG_FSL_IMX25) += fsl-imx25.o imx25_pdk.o
 obj-$(CONFIG_FSL_IMX31) += fsl-imx31.o kzm.o
 obj-$(CONFIG_FSL_IMX6) += fsl-imx6.o sabrelite.o
diff --git a/include/hw/arm/xlnx-versal.h b/include/hw/arm/xlnx-versal.h
new file mode 100644
index XXXXXXX..XXXXXXX
--- /dev/null
+++ b/include/hw/arm/xlnx-versal.h
@@ -XXX,XX +XXX,XX @@
+/*
+ * Model of the Xilinx Versal
+ *
+ * Copyright (c) 2018 Xilinx Inc.
+ * Written by Edgar E. Iglesias
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 or
+ * (at your option) any later version.
+ */
+
+#ifndef XLNX_VERSAL_H
+#define XLNX_VERSAL_H
+
+#include "hw/sysbus.h"
+#include "hw/arm/arm.h"
+#include "hw/intc/arm_gicv3.h"
+
+#define TYPE_XLNX_VERSAL "xlnx-versal"
+#define XLNX_VERSAL(obj) OBJECT_CHECK(Versal, (obj), TYPE_XLNX_VERSAL)
+
+#define XLNX_VERSAL_NR_ACPUS   2
+#define XLNX_VERSAL_NR_UARTS   2
+#define XLNX_VERSAL_NR_GEMS    2
+#define XLNX_VERSAL_NR_IRQS    256
+
+typedef struct Versal {
+    /*< private >*/
+    SysBusDevice parent_obj;
+
+    /*< public >*/
+    struct {
+        struct {
+            MemoryRegion mr;
+            ARMCPU *cpu[XLNX_VERSAL_NR_ACPUS];
+            GICv3State gic;
+        } apu;
+    } fpd;
+
+    MemoryRegion mr_ps;
+
+    struct {
+        /* 4 ranges to access DDR.  */
+        MemoryRegion mr_ddr_ranges[4];
+    } noc;
+
+    struct {
+        MemoryRegion mr_ocm;
+
+        struct {
+            SysBusDevice *uart[XLNX_VERSAL_NR_UARTS];
+            SysBusDevice *gem[XLNX_VERSAL_NR_GEMS];
+        } iou;
+    } lpd;
+
+    struct {
+        MemoryRegion *mr_ddr;
+        uint32_t psci_conduit;
+    } cfg;
+} Versal;
+
+/* Memory-map and IRQ definitions. Copied a subset from
+ * auto-generated files.  */
+
+#define VERSAL_GIC_MAINT_IRQ        9
+#define VERSAL_TIMER_VIRT_IRQ       11
+#define VERSAL_TIMER_S_EL1_IRQ      13
+#define VERSAL_TIMER_NS_EL1_IRQ     14
+#define VERSAL_TIMER_NS_EL2_IRQ     10
+
+#define VERSAL_UART0_IRQ_0         18
+#define VERSAL_UART1_IRQ_0         19
+#define VERSAL_GEM0_IRQ_0          56
+#define VERSAL_GEM0_WAKE_IRQ_0     57
+#define VERSAL_GEM1_IRQ_0          58
+#define VERSAL_GEM1_WAKE_IRQ_0     59
+
+/* Architecturally eserved IRQs suitable for virtualization.  */
+#define VERSAL_RSVD_HIGH_IRQ_FIRST 160
+#define VERSAL_RSVD_HIGH_IRQ_LAST  255
+
+#define MM_TOP_RSVD                 0xa0000000U
+#define MM_TOP_RSVD_SIZE            0x4000000
+#define MM_GIC_APU_DIST_MAIN        0xf9000000U
+#define MM_GIC_APU_DIST_MAIN_SIZE   0x10000
+#define MM_GIC_APU_REDIST_0         0xf9080000U
+#define MM_GIC_APU_REDIST_0_SIZE    0x80000
+
+#define MM_UART0                    0xff000000U
+#define MM_UART0_SIZE               0x10000
+#define MM_UART1                    0xff010000U
+#define MM_UART1_SIZE               0x10000
+
+#define MM_GEM0                     0xff0c0000U
+#define MM_GEM0_SIZE                0x10000
+#define MM_GEM1                     0xff0d0000U
+#define MM_GEM1_SIZE                0x10000
+
+#define MM_OCM                      0xfffc0000U
+#define MM_OCM_SIZE                 0x40000
+
+#define MM_TOP_DDR                  0x0
+#define MM_TOP_DDR_SIZE             0x80000000U
+#define MM_TOP_DDR_2                0x800000000ULL
+#define MM_TOP_DDR_2_SIZE           0x800000000ULL
+#define MM_TOP_DDR_3                0xc000000000ULL
+#define MM_TOP_DDR_3_SIZE           0x4000000000ULL
+#define MM_TOP_DDR_4                0x10000000000ULL
+#define MM_TOP_DDR_4_SIZE           0xb780000000ULL
+
+#define MM_PSM_START                0xffc80000U
+#define MM_PSM_END                  0xffcf0000U
+
+#define MM_CRL                      0xff5e0000U
+#define MM_CRL_SIZE                 0x300000
+#define MM_IOU_SCNTR                0xff130000U
+#define MM_IOU_SCNTR_SIZE           0x10000
+#define MM_IOU_SCNTRS               0xff140000U
+#define MM_IOU_SCNTRS_SIZE          0x10000
+#define MM_FPD_CRF                  0xfd1a0000U
+#define MM_FPD_CRF_SIZE             0x140000
+#endif
diff --git a/hw/arm/xlnx-versal.c b/hw/arm/xlnx-versal.c
new file mode 100644
index XXXXXXX..XXXXXXX
--- /dev/null
+++ b/hw/arm/xlnx-versal.c
@@ -XXX,XX +XXX,XX @@
+/*
+ * Xilinx Versal SoC model.
+ *
+ * Copyright (c) 2018 Xilinx Inc.
+ * Written by Edgar E. Iglesias
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 or
+ * (at your option) any later version.
+ */
+
+#include "qemu/osdep.h"
+#include "qapi/error.h"
+#include "qemu-common.h"
+#include "qemu/log.h"
+#include "hw/sysbus.h"
+#include "net/net.h"
+#include "sysemu/sysemu.h"
+#include "sysemu/kvm.h"
+#include "hw/arm/arm.h"
+#include "kvm_arm.h"
+#include "hw/misc/unimp.h"
+#include "hw/intc/arm_gicv3_common.h"
+#include "hw/arm/xlnx-versal.h"
+
+#define XLNX_VERSAL_ACPU_TYPE ARM_CPU_TYPE_NAME("cortex-a72")
+#define GEM_REVISION        0x40070106
+
+static void versal_create_apu_cpus(Versal *s)
+{
+    int i;
+
+    for (i = 0; i < ARRAY_SIZE(s->fpd.apu.cpu); i++) {
+        Object *obj;
+        char *name;
+
+        obj = object_new(XLNX_VERSAL_ACPU_TYPE);
+        if (!obj) {
+            /* Secondary CPUs start in PSCI powered-down state */
+            error_report("Unable to create apu.cpu[%d] of type %s",
+                         i, XLNX_VERSAL_ACPU_TYPE);
+            exit(EXIT_FAILURE);
+        }
+
+        name = g_strdup_printf("apu-cpu[%d]", i);
+        object_property_add_child(OBJECT(s), name, obj, &error_fatal);
+        g_free(name);
+
+        object_property_set_int(obj, s->cfg.psci_conduit,
+                                "psci-conduit", &error_abort);
+        if (i) {
+            object_property_set_bool(obj, true,
+                                     "start-powered-off", &error_abort);
+        }
+
+        object_property_set_int(obj, ARRAY_SIZE(s->fpd.apu.cpu),
+                                "core-count", &error_abort);
+        object_property_set_link(obj, OBJECT(&s->fpd.apu.mr), "memory",
+                                 &error_abort);
+        object_property_set_bool(obj, true, "realized", &error_fatal);
+        s->fpd.apu.cpu[i] = ARM_CPU(obj);
+    }
+}
+
+static void versal_create_apu_gic(Versal *s, qemu_irq *pic)
+{
+    static const uint64_t addrs[] = {
+        MM_GIC_APU_DIST_MAIN,
+        MM_GIC_APU_REDIST_0
+    };
+    SysBusDevice *gicbusdev;
+    DeviceState *gicdev;
+    int nr_apu_cpus = ARRAY_SIZE(s->fpd.apu.cpu);
+    int i;
+
+    sysbus_init_child_obj(OBJECT(s), "apu-gic",
+                          &s->fpd.apu.gic, sizeof(s->fpd.apu.gic),
+                          gicv3_class_name());
+    gicbusdev = SYS_BUS_DEVICE(&s->fpd.apu.gic);
+    gicdev = DEVICE(&s->fpd.apu.gic);
+    qdev_prop_set_uint32(gicdev, "revision", 3);
+    qdev_prop_set_uint32(gicdev, "num-cpu", 2);
+    qdev_prop_set_uint32(gicdev, "num-irq", XLNX_VERSAL_NR_IRQS + 32);
+    qdev_prop_set_uint32(gicdev, "len-redist-region-count", 1);
+    qdev_prop_set_uint32(gicdev, "redist-region-count[0]", 2);
+    qdev_prop_set_bit(gicdev, "has-security-extensions", true);
+
+    object_property_set_bool(OBJECT(&s->fpd.apu.gic), true, "realized",
+                                    &error_fatal);
+
+    for (i = 0; i < ARRAY_SIZE(addrs); i++) {
+        MemoryRegion *mr;
+
+        mr = sysbus_mmio_get_region(gicbusdev, i);
+        memory_region_add_subregion(&s->fpd.apu.mr, addrs[i], mr);
+    }
+
+    for (i = 0; i < nr_apu_cpus; i++) {
+        DeviceState *cpudev = DEVICE(s->fpd.apu.cpu[i]);
+        int ppibase = XLNX_VERSAL_NR_IRQS + i * GIC_INTERNAL + GIC_NR_SGIS;
+        qemu_irq maint_irq;
+        int ti;
+        /* Mapping from the output timer irq lines from the CPU to the
+         * GIC PPI inputs.
+         */
+        const int timer_irq[] = {
+            [GTIMER_PHYS] = VERSAL_TIMER_NS_EL1_IRQ,
+            [GTIMER_VIRT] = VERSAL_TIMER_VIRT_IRQ,
+            [GTIMER_HYP]  = VERSAL_TIMER_NS_EL2_IRQ,
+            [GTIMER_SEC]  = VERSAL_TIMER_S_EL1_IRQ,
+        };
+
+        for (ti = 0; ti < ARRAY_SIZE(timer_irq); ti++) {
+            qdev_connect_gpio_out(cpudev, ti,
+                                  qdev_get_gpio_in(gicdev,
+                                                   ppibase + timer_irq[ti]));
+        }
+        maint_irq = qdev_get_gpio_in(gicdev,
+                                        ppibase + VERSAL_GIC_MAINT_IRQ);
+        qdev_connect_gpio_out_named(cpudev, "gicv3-maintenance-interrupt",
+                                    0, maint_irq);
+        sysbus_connect_irq(gicbusdev, i, qdev_get_gpio_in(cpudev, ARM_CPU_IRQ));
+        sysbus_connect_irq(gicbusdev, i + nr_apu_cpus,
+                           qdev_get_gpio_in(cpudev, ARM_CPU_FIQ));
+        sysbus_connect_irq(gicbusdev, i + 2 * nr_apu_cpus,
+                           qdev_get_gpio_in(cpudev, ARM_CPU_VIRQ));
+        sysbus_connect_irq(gicbusdev, i + 3 * nr_apu_cpus,
+                           qdev_get_gpio_in(cpudev, ARM_CPU_VFIQ));
+    }
+
+    for (i = 0; i < XLNX_VERSAL_NR_IRQS; i++) {
+        pic[i] = qdev_get_gpio_in(gicdev, i);
+    }
+}
+
+static void versal_create_uarts(Versal *s, qemu_irq *pic)
+{
+    int i;
+
+    for (i = 0; i < ARRAY_SIZE(s->lpd.iou.uart); i++) {
+        static const int irqs[] = { VERSAL_UART0_IRQ_0, VERSAL_UART1_IRQ_0};
+        static const uint64_t addrs[] = { MM_UART0, MM_UART1 };
+        char *name = g_strdup_printf("uart%d", i);
+        DeviceState *dev;
+        MemoryRegion *mr;
+
+        dev = qdev_create(NULL, "pl011");
+        s->lpd.iou.uart[i] = SYS_BUS_DEVICE(dev);
+        qdev_prop_set_chr(dev, "chardev", serial_hd(i));
+        object_property_add_child(OBJECT(s), name, OBJECT(dev), &error_fatal);
+        qdev_init_nofail(dev);
+
+        mr = sysbus_mmio_get_region(s->lpd.iou.uart[i], 0);
+        memory_region_add_subregion(&s->mr_ps, addrs[i], mr);
+
+        sysbus_connect_irq(s->lpd.iou.uart[i], 0, pic[irqs[i]]);
+        g_free(name);
+    }
+}
+
+static void versal_create_gems(Versal *s, qemu_irq *pic)
+{
+    int i;
+
+    for (i = 0; i < ARRAY_SIZE(s->lpd.iou.gem); i++) {
+        static const int irqs[] = { VERSAL_GEM0_IRQ_0, VERSAL_GEM1_IRQ_0};
+        static const uint64_t addrs[] = { MM_GEM0, MM_GEM1 };
+        char *name = g_strdup_printf("gem%d", i);
+        NICInfo *nd = &nd_table[i];
+        DeviceState *dev;
+        MemoryRegion *mr;
+
+        dev = qdev_create(NULL, "cadence_gem");
+        s->lpd.iou.gem[i] = SYS_BUS_DEVICE(dev);
+        object_property_add_child(OBJECT(s), name, OBJECT(dev), &error_fatal);
+        if (nd->used) {
+            qemu_check_nic_model(nd, "cadence_gem");
+            qdev_set_nic_properties(dev, nd);
+        }
+        object_property_set_int(OBJECT(s->lpd.iou.gem[i]),
+                                2, "num-priority-queues",
+                                &error_abort);
+        object_property_set_link(OBJECT(s->lpd.iou.gem[i]),
+                                 OBJECT(&s->mr_ps), "dma",
+                                 &error_abort);
+        qdev_init_nofail(dev);
+
+        mr = sysbus_mmio_get_region(s->lpd.iou.gem[i], 0);
+        memory_region_add_subregion(&s->mr_ps, addrs[i], mr);
+
+        sysbus_connect_irq(s->lpd.iou.gem[i], 0, pic[irqs[i]]);
+        g_free(name);
+    }
+}
+
+/* This takes the board allocated linear DDR memory and creates aliases
+ * for each split DDR range/aperture on the Versal address map.
+ */
+static void versal_map_ddr(Versal *s)
+{
+    uint64_t size = memory_region_size(s->cfg.mr_ddr);
+    /* Describes the various split DDR access regions.  */
+    static const struct {
+        uint64_t base;
+        uint64_t size;
+    } addr_ranges[] = {
+        { MM_TOP_DDR, MM_TOP_DDR_SIZE },
+        { MM_TOP_DDR_2, MM_TOP_DDR_2_SIZE },
+        { MM_TOP_DDR_3, MM_TOP_DDR_3_SIZE },
+        { MM_TOP_DDR_4, MM_TOP_DDR_4_SIZE }
+    };
+    uint64_t offset = 0;
+    int i;
+
+    assert(ARRAY_SIZE(addr_ranges) == ARRAY_SIZE(s->noc.mr_ddr_ranges));
+    for (i = 0; i < ARRAY_SIZE(addr_ranges) && size; i++) {
+        char *name;
+        uint64_t mapsize;
+
+        mapsize = size < addr_ranges[i].size ? size : addr_ranges[i].size;
+        name = g_strdup_printf("noc-ddr-range%d", i);
+        /* Create the MR alias.  */
+        memory_region_init_alias(&s->noc.mr_ddr_ranges[i], OBJECT(s),
+                                 name, s->cfg.mr_ddr,
+                                 offset, mapsize);
+
+        /* Map it onto the NoC MR.  */
+        memory_region_add_subregion(&s->mr_ps, addr_ranges[i].base,
+                                    &s->noc.mr_ddr_ranges[i]);
+        offset += mapsize;
+        size -= mapsize;
+        g_free(name);
+    }
+}
+
+static void versal_unimp_area(Versal *s, const char *name,
+                                MemoryRegion *mr,
+                                hwaddr base, hwaddr size)
+{
+    DeviceState *dev = qdev_create(NULL, TYPE_UNIMPLEMENTED_DEVICE);
+    MemoryRegion *mr_dev;
+
+    qdev_prop_set_string(dev, "name", name);
+    qdev_prop_set_uint64(dev, "size", size);
+    object_property_add_child(OBJECT(s), name, OBJECT(dev), &error_fatal);
+    qdev_init_nofail(dev);
+
+    mr_dev = sysbus_mmio_get_region(SYS_BUS_DEVICE(dev), 0);
+    memory_region_add_subregion(mr, base, mr_dev);
+}
+
+static void versal_unimp(Versal *s)
+{
+    versal_unimp_area(s, "psm", &s->mr_ps,
+                        MM_PSM_START, MM_PSM_END - MM_PSM_START);
+    versal_unimp_area(s, "crl", &s->mr_ps,
+                        MM_CRL, MM_CRL_SIZE);
+    versal_unimp_area(s, "crf", &s->mr_ps,
+                        MM_FPD_CRF, MM_FPD_CRF_SIZE);
+    versal_unimp_area(s, "iou-scntr", &s->mr_ps,
+                        MM_IOU_SCNTR, MM_IOU_SCNTR_SIZE);
+    versal_unimp_area(s, "iou-scntr-seucre", &s->mr_ps,
+                        MM_IOU_SCNTRS, MM_IOU_SCNTRS_SIZE);
+}
+
+static void versal_realize(DeviceState *dev, Error **errp)
+{
+    Versal *s = XLNX_VERSAL(dev);
+    qemu_irq pic[XLNX_VERSAL_NR_IRQS];
+
+    versal_create_apu_cpus(s);
+    versal_create_apu_gic(s, pic);
+    versal_create_uarts(s, pic);
+    versal_create_gems(s, pic);
+    versal_map_ddr(s);
+    versal_unimp(s);
+
+    /* Create the On Chip Memory (OCM).  */
+    memory_region_init_ram(&s->lpd.mr_ocm, OBJECT(s), "ocm",
+                           MM_OCM_SIZE, &error_fatal);
+
+    memory_region_add_subregion_overlap(&s->mr_ps, MM_OCM, &s->lpd.mr_ocm, 0);
+    memory_region_add_subregion_overlap(&s->fpd.apu.mr, 0, &s->mr_ps, 0);
+}
+
+static void versal_init(Object *obj)
+{
+    Versal *s = XLNX_VERSAL(obj);
+
+    memory_region_init(&s->fpd.apu.mr, obj, "mr-apu", UINT64_MAX);
+    memory_region_init(&s->mr_ps, obj, "mr-ps-switch", UINT64_MAX);
+}
+
+static Property versal_properties[] = {
+    DEFINE_PROP_LINK("ddr", Versal, cfg.mr_ddr, TYPE_MEMORY_REGION,
+                     MemoryRegion *),
+    DEFINE_PROP_UINT32("psci-conduit", Versal, cfg.psci_conduit, 0),
+    DEFINE_PROP_END_OF_LIST()
+};
+
+static void versal_class_init(ObjectClass *klass, void *data)
+{
+    DeviceClass *dc = DEVICE_CLASS(klass);
+
+    dc->realize = versal_realize;
+    dc->props = versal_properties;
+    /* No VMSD since we haven't got any top-level SoC state to save.  */
+}
+
+static const TypeInfo versal_info = {
+    .name = TYPE_XLNX_VERSAL,
+    .parent = TYPE_SYS_BUS_DEVICE,
+    .instance_size = sizeof(Versal),
+    .instance_init = versal_init,
+    .class_init = versal_class_init,
+};
+
+static void versal_register_types(void)
+{
+    type_register_static(&versal_info);
+}
+
+type_init(versal_register_types);
diff --git a/default-configs/aarch64-softmmu.mak b/default-configs/aarch64-softmmu.mak
index XXXXXXX..XXXXXXX 100644
--- a/default-configs/aarch64-softmmu.mak
+++ b/default-configs/aarch64-softmmu.mak
@@ -XXX,XX +XXX,XX @@ CONFIG_DDC=y
 CONFIG_DPCD=y
 CONFIG_XLNX_ZYNQMP=y
 CONFIG_XLNX_ZYNQMP_ARM=y
+CONFIG_XLNX_VERSAL=y
 CONFIG_ARM_SMMUV3=y
-- 
2.19.1

From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>

Add a virtual Xilinx Versal board.

This board is based on the Xilinx Versal SoC. The exact
details of what peripherals are attached to this board
will remain in control of QEMU. QEMU will generate an
FDT on the fly for Linux and other software to auto-discover
peripherals.

Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
[PMM: removed stray blank line at EOF]
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/arm/Makefile.objs      |   2 +-
 hw/arm/xlnx-versal-virt.c | 493 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 494 insertions(+), 1 deletion(-)
 create mode 100644 hw/arm/xlnx-versal-virt.c

diff --git a/hw/arm/Makefile.objs b/hw/arm/Makefile.objs
index XXXXXXX..XXXXXXX 100644
--- a/hw/arm/Makefile.objs
+++ b/hw/arm/Makefile.objs
@@ -XXX,XX +XXX,XX @@ obj-$(CONFIG_ALLWINNER_A10) += allwinner-a10.o cubieboard.o
 obj-$(CONFIG_RASPI) += bcm2835_peripherals.o bcm2836.o raspi.o
 obj-$(CONFIG_STM32F205_SOC) += stm32f205_soc.o
 obj-$(CONFIG_XLNX_ZYNQMP_ARM) += xlnx-zynqmp.o xlnx-zcu102.o
-obj-$(CONFIG_XLNX_VERSAL) += xlnx-versal.o
+obj-$(CONFIG_XLNX_VERSAL) += xlnx-versal.o xlnx-versal-virt.o
 obj-$(CONFIG_FSL_IMX25) += fsl-imx25.o imx25_pdk.o
 obj-$(CONFIG_FSL_IMX31) += fsl-imx31.o kzm.o
 obj-$(CONFIG_FSL_IMX6) += fsl-imx6.o sabrelite.o
diff --git a/hw/arm/xlnx-versal-virt.c b/hw/arm/xlnx-versal-virt.c
new file mode 100644
index XXXXXXX..XXXXXXX
--- /dev/null
+++ b/hw/arm/xlnx-versal-virt.c
@@ -XXX,XX +XXX,XX @@
+/*
+ * Xilinx Versal Virtual board.
+ *
+ * Copyright (c) 2018 Xilinx Inc.
+ * Written by Edgar E. Iglesias
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 or
+ * (at your option) any later version.
+ */
+
+#include "qemu/osdep.h"
+#include "qemu/log.h"
+#include "qemu/error-report.h"
+#include "qapi/error.h"
+#include "sysemu/device_tree.h"
+#include "exec/address-spaces.h"
+#include "hw/boards.h"
+#include "hw/sysbus.h"
+#include "hw/arm/sysbus-fdt.h"
+#include "hw/arm/fdt.h"
+#include "cpu.h"
+#include "hw/arm/xlnx-versal.h"
+
+#define TYPE_XLNX_VERSAL_VIRT_MACHINE MACHINE_TYPE_NAME("xlnx-versal-virt")
+#define XLNX_VERSAL_VIRT_MACHINE(obj) \
+    OBJECT_CHECK(VersalVirt, (obj), TYPE_XLNX_VERSAL_VIRT_MACHINE)
+
+typedef struct VersalVirt {
+    MachineState parent_obj;
+
+    Versal soc;
+    MemoryRegion mr_ddr;
+
+    void *fdt;
+    int fdt_size;
+    struct {
+        uint32_t gic;
+        uint32_t ethernet_phy[2];
+        uint32_t clk_125Mhz;
+        uint32_t clk_25Mhz;
+    } phandle;
+    struct arm_boot_info binfo;
+
+    struct {
+        bool secure;
+    } cfg;
+} VersalVirt;
+
+static void fdt_create(VersalVirt *s)
+{
+    MachineClass *mc = MACHINE_GET_CLASS(s);
+    int i;
+
+    s->fdt = create_device_tree(&s->fdt_size);
+    if (!s->fdt) {
+        error_report("create_device_tree() failed");
+        exit(1);
+    }
+
+    /* Allocate all phandles.  */
+    s->phandle.gic = qemu_fdt_alloc_phandle(s->fdt);
+    for (i = 0; i < ARRAY_SIZE(s->phandle.ethernet_phy); i++) {
+        s->phandle.ethernet_phy[i] = qemu_fdt_alloc_phandle(s->fdt);
+    }
+    s->phandle.clk_25Mhz = qemu_fdt_alloc_phandle(s->fdt);
+    s->phandle.clk_125Mhz = qemu_fdt_alloc_phandle(s->fdt);
+
+    /* Create /chosen node for load_dtb.  */
+    qemu_fdt_add_subnode(s->fdt, "/chosen");
+
+    /* Header */
+    qemu_fdt_setprop_cell(s->fdt, "/", "interrupt-parent", s->phandle.gic);
+    qemu_fdt_setprop_cell(s->fdt, "/", "#size-cells", 0x2);
+    qemu_fdt_setprop_cell(s->fdt, "/", "#address-cells", 0x2);
+    qemu_fdt_setprop_string(s->fdt, "/", "model", mc->desc);
+    qemu_fdt_setprop_string(s->fdt, "/", "compatible", "xlnx-versal-virt");
+}
+
+static void fdt_add_clk_node(VersalVirt *s, const char *name,
+                             unsigned int freq_hz, uint32_t phandle)
+{
+    qemu_fdt_add_subnode(s->fdt, name);
+    qemu_fdt_setprop_cell(s->fdt, name, "phandle", phandle);
+    qemu_fdt_setprop_cell(s->fdt, name, "clock-frequency", freq_hz);
+    qemu_fdt_setprop_cell(s->fdt, name, "#clock-cells", 0x0);
+    qemu_fdt_setprop_string(s->fdt, name, "compatible", "fixed-clock");
+    qemu_fdt_setprop(s->fdt, name, "u-boot,dm-pre-reloc", NULL, 0);
+}
+
+static void fdt_add_cpu_nodes(VersalVirt *s, uint32_t psci_conduit)
+{
+    int i;
+
+    qemu_fdt_add_subnode(s->fdt, "/cpus");
+    qemu_fdt_setprop_cell(s->fdt, "/cpus", "#size-cells", 0x0);
+    qemu_fdt_setprop_cell(s->fdt, "/cpus", "#address-cells", 1);
+
+    for (i = XLNX_VERSAL_NR_ACPUS - 1; i >= 0; i--) {
+        char *name = g_strdup_printf("/cpus/cpu@%d", i);
+        ARMCPU *armcpu = ARM_CPU(qemu_get_cpu(i));
+
+        qemu_fdt_add_subnode(s->fdt, name);
+        qemu_fdt_setprop_cell(s->fdt, name, "reg", armcpu->mp_affinity);
+        if (psci_conduit != QEMU_PSCI_CONDUIT_DISABLED) {
+            qemu_fdt_setprop_string(s->fdt, name, "enable-method", "psci");
+        }
+        qemu_fdt_setprop_string(s->fdt, name, "device_type", "cpu");
+        qemu_fdt_setprop_string(s->fdt, name, "compatible",
+                                armcpu->dtb_compatible);
+        g_free(name);
+    }
+}
+
+static void fdt_add_gic_nodes(VersalVirt *s)
+{
+    char *nodename;
+
+    nodename = g_strdup_printf("/gic@%x", MM_GIC_APU_DIST_MAIN);
+    qemu_fdt_add_subnode(s->fdt, nodename);
+    qemu_fdt_setprop_cell(s->fdt, nodename, "phandle", s->phandle.gic);
+    qemu_fdt_setprop_cells(s->fdt, nodename, "interrupts",
+                           GIC_FDT_IRQ_TYPE_PPI, VERSAL_GIC_MAINT_IRQ,
+                           GIC_FDT_IRQ_FLAGS_LEVEL_HI);
+    qemu_fdt_setprop(s->fdt, nodename, "interrupt-controller", NULL, 0);
+    qemu_fdt_setprop_sized_cells(s->fdt, nodename, "reg",
+                                 2, MM_GIC_APU_DIST_MAIN,
+                                 2, MM_GIC_APU_DIST_MAIN_SIZE,
+                                 2, MM_GIC_APU_REDIST_0,
+                                 2, MM_GIC_APU_REDIST_0_SIZE);
+    qemu_fdt_setprop_cell(s->fdt, nodename, "#interrupt-cells", 3);
+    qemu_fdt_setprop_string(s->fdt, nodename, "compatible", "arm,gic-v3");
+}
+
+static void fdt_add_timer_nodes(VersalVirt *s)
+{
+    const char compat[] = "arm,armv8-timer";
+    uint32_t irqflags = GIC_FDT_IRQ_FLAGS_LEVEL_HI;
+
+    qemu_fdt_add_subnode(s->fdt, "/timer");
+    qemu_fdt_setprop_cells(s->fdt, "/timer", "interrupts",
+            GIC_FDT_IRQ_TYPE_PPI, VERSAL_TIMER_S_EL1_IRQ, irqflags,
+            GIC_FDT_IRQ_TYPE_PPI, VERSAL_TIMER_NS_EL1_IRQ, irqflags,
+            GIC_FDT_IRQ_TYPE_PPI, VERSAL_TIMER_VIRT_IRQ, irqflags,
+            GIC_FDT_IRQ_TYPE_PPI, VERSAL_TIMER_NS_EL2_IRQ, irqflags);
+    qemu_fdt_setprop(s->fdt, "/timer", "compatible",
+                     compat, sizeof(compat));
+}
+
+static void fdt_add_uart_nodes(VersalVirt *s)
+{
+    uint64_t addrs[] = { MM_UART1, MM_UART0 };
+    unsigned int irqs[] = { VERSAL_UART1_IRQ_0, VERSAL_UART0_IRQ_0 };
+    const char compat[] = "arm,pl011\0arm,sbsa-uart";
+    const char clocknames[] = "uartclk\0apb_pclk";
+    int i;
+
+    for (i = 0; i < ARRAY_SIZE(addrs); i++) {
+        char *name = g_strdup_printf("/uart@%" PRIx64, addrs[i]);
+        qemu_fdt_add_subnode(s->fdt, name);
+        qemu_fdt_setprop_cell(s->fdt, name, "current-speed", 115200);
+        qemu_fdt_setprop_cells(s->fdt, name, "clocks",
+                               s->phandle.clk_125Mhz, s->phandle.clk_125Mhz);
+        qemu_fdt_setprop(s->fdt, name, "clock-names",
+                         clocknames, sizeof(clocknames));
+
+        qemu_fdt_setprop_cells(s->fdt, name, "interrupts",
+                               GIC_FDT_IRQ_TYPE_SPI, irqs[i],
+                               GIC_FDT_IRQ_FLAGS_LEVEL_HI);
+        qemu_fdt_setprop_sized_cells(s->fdt, name, "reg",
+                                     2, addrs[i], 2, 0x1000);
+        qemu_fdt_setprop(s->fdt, name, "compatible",
+                         compat, sizeof(compat));
+        qemu_fdt_setprop(s->fdt, name, "u-boot,dm-pre-reloc", NULL, 0);
+
+        if (addrs[i] == MM_UART0) {
+            /* Select UART0.  */
+            qemu_fdt_setprop_string(s->fdt, "/chosen", "stdout-path", name);
+        }
+        g_free(name);
+    }
+}
+
+static void fdt_add_fixed_link_nodes(VersalVirt *s, char *gemname,
+                                     uint32_t phandle)
+{
+    char *name = g_strdup_printf("%s/fixed-link", gemname);
+
+    qemu_fdt_add_subnode(s->fdt, name);
+    qemu_fdt_setprop_cell(s->fdt, name, "phandle", phandle);
+    qemu_fdt_setprop_cells(s->fdt, name, "full-duplex");
+    qemu_fdt_setprop_cell(s->fdt, name, "speed", 1000);
+    g_free(name);
+}
+
+static void fdt_add_gem_nodes(VersalVirt *s)
+{
+    uint64_t addrs[] = { MM_GEM1, MM_GEM0 };
+    unsigned int irqs[] = { VERSAL_GEM1_IRQ_0, VERSAL_GEM0_IRQ_0 };
+    const char clocknames[] = "pclk\0hclk\0tx_clk\0rx_clk";
+    const char compat_gem[] = "cdns,zynqmp-gem\0cdns,gem";
+    int i;
+
+    for (i = 0; i < ARRAY_SIZE(addrs); i++) {
+        char *name = g_strdup_printf("/ethernet@%" PRIx64, addrs[i]);
+        qemu_fdt_add_subnode(s->fdt, name);
+
+        fdt_add_fixed_link_nodes(s, name, s->phandle.ethernet_phy[i]);
+        qemu_fdt_setprop_string(s->fdt, name, "phy-mode", "rgmii-id");
+        qemu_fdt_setprop_cell(s->fdt, name, "phy-handle",
+                              s->phandle.ethernet_phy[i]);
+        qemu_fdt_setprop_cells(s->fdt, name, "clocks",
+                               s->phandle.clk_25Mhz, s->phandle.clk_25Mhz,
+                               s->phandle.clk_25Mhz, s->phandle.clk_25Mhz);
+        qemu_fdt_setprop(s->fdt, name, "clock-names",
+                         clocknames, sizeof(clocknames));
+        qemu_fdt_setprop_cells(s->fdt, name, "interrupts",
+                               GIC_FDT_IRQ_TYPE_SPI, irqs[i],
+                               GIC_FDT_IRQ_FLAGS_LEVEL_HI,
+                               GIC_FDT_IRQ_TYPE_SPI, irqs[i],
+                               GIC_FDT_IRQ_FLAGS_LEVEL_HI);
+        qemu_fdt_setprop_sized_cells(s->fdt, name, "reg",
+                                     2, addrs[i], 2, 0x1000);
+        qemu_fdt_setprop(s->fdt, name, "compatible",
+                         compat_gem, sizeof(compat_gem));
+        qemu_fdt_setprop_cell(s->fdt, name, "#address-cells", 1);
+        qemu_fdt_setprop_cell(s->fdt, name, "#size-cells", 0);
+        g_free(name);
+    }
+}
+
+static void fdt_nop_memory_nodes(void *fdt, Error **errp)
+{
+    Error *err = NULL;
+    char **node_path;
+    int n = 0;
+
+    node_path = qemu_fdt_node_unit_path(fdt, "memory", &err);
+    if (err) {
+        error_propagate(errp, err);
+        return;
+    }
+    while (node_path[n]) {
+        if (g_str_has_prefix(node_path[n], "/memory")) {
+            qemu_fdt_nop_node(fdt, node_path[n]);
+        }
+        n++;
+    }
+    g_strfreev(node_path);
+}
+
+static void fdt_add_memory_nodes(VersalVirt *s, void *fdt, uint64_t ram_size)
+{
+    /* Describes the various split DDR access regions.  */
+    static const struct {
+        uint64_t base;
+        uint64_t size;
+    } addr_ranges[] = {
+        { MM_TOP_DDR, MM_TOP_DDR_SIZE },
+        { MM_TOP_DDR_2, MM_TOP_DDR_2_SIZE },
+        { MM_TOP_DDR_3, MM_TOP_DDR_3_SIZE },
+        { MM_TOP_DDR_4, MM_TOP_DDR_4_SIZE }
+    };
+    uint64_t mem_reg_prop[8] = {0};
+    uint64_t size = ram_size;
+    Error *err = NULL;
+    char *name;
+    int i;
+
+    fdt_nop_memory_nodes(fdt, &err);
+    if (err) {
+        error_report_err(err);
+        return;
+    }
+
+    name = g_strdup_printf("/memory@%x", MM_TOP_DDR);
+    for (i = 0; i < ARRAY_SIZE(addr_ranges) && size; i++) {
+        uint64_t mapsize;
+
+        mapsize = size < addr_ranges[i].size ? size : addr_ranges[i].size;
+
+        mem_reg_prop[i * 2] = addr_ranges[i].base;
+        mem_reg_prop[i * 2 + 1] = mapsize;
+        size -= mapsize;
+    }
+    qemu_fdt_add_subnode(fdt, name);
+    qemu_fdt_setprop_string(fdt, name, "device_type", "memory");
+
+    switch (i) {
+    case 1:
+        qemu_fdt_setprop_sized_cells(fdt, name, "reg",
+                                     2, mem_reg_prop[0],
+                                     2, mem_reg_prop[1]);
+        break;
+    case 2:
+        qemu_fdt_setprop_sized_cells(fdt, name, "reg",
+                                     2, mem_reg_prop[0],
+                                     2, mem_reg_prop[1],
+                                     2, mem_reg_prop[2],
+                                     2, mem_reg_prop[3]);
+        break;
+    case 3:
+        qemu_fdt_setprop_sized_cells(fdt, name, "reg",
+                                     2, mem_reg_prop[0],
+                                     2, mem_reg_prop[1],
+                                     2, mem_reg_prop[2],
+                                     2, mem_reg_prop[3],
+                                     2, mem_reg_prop[4],
+                                     2, mem_reg_prop[5]);
+        break;
+    case 4:
+        qemu_fdt_setprop_sized_cells(fdt, name, "reg",
+                                     2, mem_reg_prop[0],
+                                     2, mem_reg_prop[1],
+                                     2, mem_reg_prop[2],
+                                     2, mem_reg_prop[3],
+                                     2, mem_reg_prop[4],
+                                     2, mem_reg_prop[5],
+                                     2, mem_reg_prop[6],
+                                     2, mem_reg_prop[7]);
+        break;
+    default:
+        g_assert_not_reached();
+    }
+    g_free(name);
+}
+
+static void versal_virt_modify_dtb(const struct arm_boot_info *binfo,
+                                    void *fdt)
+{
+    VersalVirt *s = container_of(binfo, VersalVirt, binfo);
+
+    fdt_add_memory_nodes(s, fdt, binfo->ram_size);
+}
+
+static void *versal_virt_get_dtb(const struct arm_boot_info *binfo,
+                                  int *fdt_size)
+{
+    const VersalVirt *board = container_of(binfo, VersalVirt, binfo);
+
+    *fdt_size = board->fdt_size;
+    return board->fdt;
+}
+
+#define NUM_VIRTIO_TRANSPORT 32
+static void create_virtio_regions(VersalVirt *s)
+{
+    int virtio_mmio_size = 0x200;
+    int i;
+
+    for (i = 0; i < NUM_VIRTIO_TRANSPORT; i++) {
+        char *name = g_strdup_printf("virtio%d", i);;
+        hwaddr base = MM_TOP_RSVD + i * virtio_mmio_size;
+        int irq = VERSAL_RSVD_HIGH_IRQ_FIRST + i;
+        MemoryRegion *mr;
+        DeviceState *dev;
+        qemu_irq pic_irq;
+
+        pic_irq = qdev_get_gpio_in(DEVICE(&s->soc.fpd.apu.gic), irq);
+        dev = qdev_create(NULL, "virtio-mmio");
+        object_property_add_child(OBJECT(&s->soc), name, OBJECT(dev),
+                                  &error_fatal);
+        qdev_init_nofail(dev);
+        sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, pic_irq);
+        mr = sysbus_mmio_get_region(SYS_BUS_DEVICE(dev), 0);
+        memory_region_add_subregion(&s->soc.mr_ps, base, mr);
+        sysbus_create_simple("virtio-mmio", base, pic_irq);
+    }
+
+    for (i = 0; i < NUM_VIRTIO_TRANSPORT; i++) {
+        hwaddr base = MM_TOP_RSVD + i * virtio_mmio_size;
+        int irq = VERSAL_RSVD_HIGH_IRQ_FIRST + i;
+        char *name = g_strdup_printf("/virtio_mmio@%" PRIx64, base);
+
+        qemu_fdt_add_subnode(s->fdt, name);
+        qemu_fdt_setprop(s->fdt, name, "dma-coherent", NULL, 0);
+        qemu_fdt_setprop_cells(s->fdt, name, "interrupts",
+                               GIC_FDT_IRQ_TYPE_SPI, irq,
+                               GIC_FDT_IRQ_FLAGS_EDGE_LO_HI);
+        qemu_fdt_setprop_sized_cells(s->fdt, name, "reg",
+                                     2, base, 2, virtio_mmio_size);
+        qemu_fdt_setprop_string(s->fdt, name, "compatible", "virtio,mmio");
+        g_free(name);
+    }
+}
+
+static void versal_virt_init(MachineState *machine)
+{
+    VersalVirt *s = XLNX_VERSAL_VIRT_MACHINE(machine);
+    int psci_conduit = QEMU_PSCI_CONDUIT_DISABLED;
+
+    /*
+     * If the user provides an Operating System to be loaded, we expect them
+     * to use the -kernel command line option.
+     *
+     * Users can load firmware or boot-loaders with the -device loader options.
+     *
+     * When loading an OS, we generate a dtb and let arm_load_kernel() select
+     * where it gets loaded. This dtb will be passed to the kernel in x0.
+     *
+     * If there's no -kernel option, we generate a DTB and place it at 0x1000
+     * for the bootloaders or firmware to pick up.
+     *
+     * If users want to provide their own DTB, they can use the -dtb option.
+     * These dtb's will have their memory nodes modified to match QEMU's
+     * selected ram_size option before they get passed to the kernel or fw.
+     *
+     * When loading an OS, we turn on QEMU's PSCI implementation with SMC
+     * as the PSCI conduit. When there's no -kernel, we assume the user
+     * provides EL3 firmware to handle PSCI.
+     */
+    if (machine->kernel_filename) {
+        psci_conduit = QEMU_PSCI_CONDUIT_SMC;
+    }
+
+    memory_region_allocate_system_memory(&s->mr_ddr, NULL, "ddr",
+                                         machine->ram_size);
+
+    sysbus_init_child_obj(OBJECT(machine), "xlnx-ve", &s->soc,
+                          sizeof(s->soc), TYPE_XLNX_VERSAL);
+    object_property_set_link(OBJECT(&s->soc), OBJECT(&s->mr_ddr),
+                             "ddr", &error_abort);
+    object_property_set_int(OBJECT(&s->soc), psci_conduit,
+                            "psci-conduit", &error_abort);
+    object_property_set_bool(OBJECT(&s->soc), true, "realized", &error_fatal);
+
+    fdt_create(s);
+    create_virtio_regions(s);
+    fdt_add_gem_nodes(s);
+    fdt_add_uart_nodes(s);
+    fdt_add_gic_nodes(s);
+    fdt_add_timer_nodes(s);
+    fdt_add_cpu_nodes(s, psci_conduit);
+    fdt_add_clk_node(s, "/clk125", 125000000, s->phandle.clk_125Mhz);
+    fdt_add_clk_node(s, "/clk25", 25000000, s->phandle.clk_25Mhz);
+
+    /* Make the APU cpu address space visible to virtio and other
+     * modules unaware of muliple address-spaces.  */
+    memory_region_add_subregion_overlap(get_system_memory(),
+                                        0, &s->soc.fpd.apu.mr, 0);
+
+    s->binfo.ram_size = machine->ram_size;
+    s->binfo.kernel_filename = machine->kernel_filename;
+    s->binfo.kernel_cmdline = machine->kernel_cmdline;
+    s->binfo.initrd_filename = machine->initrd_filename;
+    s->binfo.loader_start = 0x0;
+    s->binfo.get_dtb = versal_virt_get_dtb;
+    s->binfo.modify_dtb = versal_virt_modify_dtb;
+    if (machine->kernel_filename) {
+        arm_load_kernel(s->soc.fpd.apu.cpu[0], &s->binfo);
+    } else {
+        AddressSpace *as = arm_boot_address_space(s->soc.fpd.apu.cpu[0],
+                                                  &s->binfo);
+        /* Some boot-loaders (e.g u-boot) don't like blobs at address 0 (NULL).
+         * Offset things by 4K.  */
+        s->binfo.loader_start = 0x1000;
+        s->binfo.dtb_limit = 0x1000000;
+        if (arm_load_dtb(s->binfo.loader_start,
+                         &s->binfo, s->binfo.dtb_limit, as) < 0) {
+            exit(EXIT_FAILURE);
+        }
+    }
+}
+
+static void versal_virt_machine_instance_init(Object *obj)
+{
+}
+
+static void versal_virt_machine_class_init(ObjectClass *oc, void *data)
+{
+    MachineClass *mc = MACHINE_CLASS(oc);
+
+    mc->desc = "Xilinx Versal Virtual development board";
+    mc->init = versal_virt_init;
+    mc->max_cpus = XLNX_VERSAL_NR_ACPUS;
+    mc->default_cpus = XLNX_VERSAL_NR_ACPUS;
+    mc->no_cdrom = true;
+}
+
+static const TypeInfo versal_virt_machine_init_typeinfo = {
+    .name       = TYPE_XLNX_VERSAL_VIRT_MACHINE,
+    .parent     = TYPE_MACHINE,
+    .class_init = versal_virt_machine_class_init,
+    .instance_init = versal_virt_machine_instance_init,
+    .instance_size = sizeof(VersalVirt),
+};
+
+static void versal_virt_machine_init_register_types(void)
+{
+    type_register_static(&versal_virt_machine_init_typeinfo);
+}
+
+type_init(versal_virt_machine_init_register_types)
-- 
2.19.1

From: Julia Suvorova via Qemu-devel <qemu-devel@nongnu.org>

Not implemented: CTS/NCTS, PSEL*.

Signed-off-by: Julia Suvorova <jusual@mail.ru>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/char/Makefile.objs        |   1 +
 include/hw/char/nrf51_uart.h |  78 +++++++++
 hw/char/nrf51_uart.c         | 330 +++++++++++++++++++++++++++++++++++
 hw/char/trace-events         |   4 +
 4 files changed, 413 insertions(+)
 create mode 100644 include/hw/char/nrf51_uart.h
 create mode 100644 hw/char/nrf51_uart.c

diff --git a/hw/char/Makefile.objs b/hw/char/Makefile.objs
index XXXXXXX..XXXXXXX 100644
--- a/hw/char/Makefile.objs
+++ b/hw/char/Makefile.objs
@@ -XXX,XX +XXX,XX @@
 common-obj-$(CONFIG_IPACK) += ipoctal232.o
 common-obj-$(CONFIG_ESCC) += escc.o
+common-obj-$(CONFIG_NRF51_SOC) += nrf51_uart.o
 common-obj-$(CONFIG_PARALLEL) += parallel.o
 common-obj-$(CONFIG_PARALLEL) += parallel-isa.o
 common-obj-$(CONFIG_PL011) += pl011.o
diff --git a/include/hw/char/nrf51_uart.h b/include/hw/char/nrf51_uart.h
new file mode 100644
index XXXXXXX..XXXXXXX
--- /dev/null
+++ b/include/hw/char/nrf51_uart.h
@@ -XXX,XX +XXX,XX @@
+/*
+ * nRF51 SoC UART emulation
+ *
+ * Copyright (c) 2018 Julia Suvorova <jusual@mail.ru>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 or
+ * (at your option) any later version.
+ */
+
+#ifndef NRF51_UART_H
+#define NRF51_UART_H
+
+#include "hw/sysbus.h"
+#include "chardev/char-fe.h"
+#include "hw/registerfields.h"
+
+#define UART_FIFO_LENGTH 6
+#define UART_BASE 0x40002000
+#define UART_SIZE 0x1000
+
+#define TYPE_NRF51_UART "nrf51_soc.uart"
+#define NRF51_UART(obj) OBJECT_CHECK(NRF51UARTState, (obj), TYPE_NRF51_UART)
+
+REG32(UART_STARTRX, 0x000)
+REG32(UART_STOPRX, 0x004)
+REG32(UART_STARTTX, 0x008)
+REG32(UART_STOPTX, 0x00C)
+REG32(UART_SUSPEND, 0x01C)
+
+REG32(UART_CTS, 0x100)
+REG32(UART_NCTS, 0x104)
+REG32(UART_RXDRDY, 0x108)
+REG32(UART_TXDRDY, 0x11C)
+REG32(UART_ERROR, 0x124)
+REG32(UART_RXTO, 0x144)
+
+REG32(UART_INTEN, 0x300)
+    FIELD(UART_INTEN, CTS, 0, 1)
+    FIELD(UART_INTEN, NCTS, 1, 1)
+    FIELD(UART_INTEN, RXDRDY, 2, 1)
+    FIELD(UART_INTEN, TXDRDY, 7, 1)
+    FIELD(UART_INTEN, ERROR, 9, 1)
+    FIELD(UART_INTEN, RXTO, 17, 1)
+REG32(UART_INTENSET, 0x304)
+REG32(UART_INTENCLR, 0x308)
+REG32(UART_ERRORSRC, 0x480)
+REG32(UART_ENABLE, 0x500)
+REG32(UART_PSELRTS, 0x508)
+REG32(UART_PSELTXD, 0x50C)
+REG32(UART_PSELCTS, 0x510)
+REG32(UART_PSELRXD, 0x514)
+REG32(UART_RXD, 0x518)
+REG32(UART_TXD, 0x51C)
+REG32(UART_BAUDRATE, 0x524)
+REG32(UART_CONFIG, 0x56C)
+
+typedef struct NRF51UARTState {
+    SysBusDevice parent_obj;
+
+    MemoryRegion iomem;
+    CharBackend chr;
+    qemu_irq irq;
+    guint watch_tag;
+
+    uint8_t rx_fifo[UART_FIFO_LENGTH];
+    unsigned int rx_fifo_pos;
+    unsigned int rx_fifo_len;
+
+    uint32_t reg[0x56C];
+
+    bool rx_started;
+    bool tx_started;
+    bool pending_tx_byte;
+    bool enabled;
+} NRF51UARTState;
+
+#endif
diff --git a/hw/char/nrf51_uart.c b/hw/char/nrf51_uart.c
new file mode 100644
index XXXXXXX..XXXXXXX
--- /dev/null
+++ b/hw/char/nrf51_uart.c
@@ -XXX,XX +XXX,XX @@
+/*
+ * nRF51 SoC UART emulation
+ *
+ * See nRF51 Series Reference Manual, "29 Universal Asynchronous
+ * Receiver/Transmitter" for hardware specifications:
+ * http://infocenter.nordicsemi.com/pdf/nRF51_RM_v3.0.pdf
+ *
+ * Copyright (c) 2018 Julia Suvorova <jusual@mail.ru>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 or
+ * (at your option) any later version.
+ */
+
+#include "qemu/osdep.h"
+#include "qemu/log.h"
+#include "hw/char/nrf51_uart.h"
+#include "trace.h"
+
+static void nrf51_uart_update_irq(NRF51UARTState *s)
+{
+    bool irq = false;
+
+    irq |= (s->reg[R_UART_RXDRDY] &&
+            (s->reg[R_UART_INTEN] & R_UART_INTEN_RXDRDY_MASK));
+    irq |= (s->reg[R_UART_TXDRDY] &&
+            (s->reg[R_UART_INTEN] & R_UART_INTEN_TXDRDY_MASK));
+    irq |= (s->reg[R_UART_ERROR]  &&
+            (s->reg[R_UART_INTEN] & R_UART_INTEN_ERROR_MASK));
+    irq |= (s->reg[R_UART_RXTO]   &&
+            (s->reg[R_UART_INTEN] & R_UART_INTEN_RXTO_MASK));
+
+    qemu_set_irq(s->irq, irq);
+}
+
+static uint64_t uart_read(void *opaque, hwaddr addr, unsigned int size)
+{
+    NRF51UARTState *s = NRF51_UART(opaque);
+    uint64_t r;
+
+    if (!s->enabled) {
+        return 0;
+    }
+
+    switch (addr) {
+    case A_UART_RXD:
+        r = s->rx_fifo[s->rx_fifo_pos];
+        if (s->rx_started && s->rx_fifo_len) {
+            s->rx_fifo_pos = (s->rx_fifo_pos + 1) % UART_FIFO_LENGTH;
+            s->rx_fifo_len--;
+            if (s->rx_fifo_len) {
+                s->reg[R_UART_RXDRDY] = 1;
+                nrf51_uart_update_irq(s);
+            }
+            qemu_chr_fe_accept_input(&s->chr);
+        }
+        break;
+    case A_UART_INTENSET:
+    case A_UART_INTENCLR:
+    case A_UART_INTEN:
+        r = s->reg[R_UART_INTEN];
+        break;
+    default:
+        r = s->reg[addr / 4];
+        break;
+    }
+
+    trace_nrf51_uart_read(addr, r, size);
+
+    return r;
+}
+
+static gboolean uart_transmit(GIOChannel *chan, GIOCondition cond, void *opaque)
+{
+    NRF51UARTState *s = NRF51_UART(opaque);
+    int r;
+    uint8_t c = s->reg[R_UART_TXD];
+
+    s->watch_tag = 0;
+
+    r = qemu_chr_fe_write(&s->chr, &c, 1);
+    if (r <= 0) {
+        s->watch_tag = qemu_chr_fe_add_watch(&s->chr, G_IO_OUT | G_IO_HUP,
+                                             uart_transmit, s);
+        if (!s->watch_tag) {
+            /* The hardware has no transmit error reporting,
+             * so silently drop the byte
+             */
+            goto buffer_drained;
+        }
+        return FALSE;
+    }
+
+buffer_drained:
+    s->reg[R_UART_TXDRDY] = 1;
+    s->pending_tx_byte = false;
+    return FALSE;
+}
+
+static void uart_cancel_transmit(NRF51UARTState *s)
+{
+    if (s->watch_tag) {
+        g_source_remove(s->watch_tag);
+        s->watch_tag = 0;
+    }
+}
+
+static void uart_write(void *opaque, hwaddr addr,
+                       uint64_t value, unsigned int size)
+{
+    NRF51UARTState *s = NRF51_UART(opaque);
+
+    trace_nrf51_uart_write(addr, value, size);
+
+    if (!s->enabled && (addr != A_UART_ENABLE)) {
+        return;
+    }
+
+    switch (addr) {
+    case A_UART_TXD:
+        if (!s->pending_tx_byte && s->tx_started) {
+            s->reg[R_UART_TXD] = value;
+            s->pending_tx_byte = true;
+            uart_transmit(NULL, G_IO_OUT, s);
+        }
+        break;
+    case A_UART_INTEN:
+        s->reg[R_UART_INTEN] = value;
+        break;
+    case A_UART_INTENSET:
+        s->reg[R_UART_INTEN] |= value;
+        break;
+    case A_UART_INTENCLR:
+        s->reg[R_UART_INTEN] &= ~value;
+        break;
+    case A_UART_TXDRDY ... A_UART_RXTO:
+        s->reg[addr / 4] = value;
+        break;
+    case A_UART_ERRORSRC:
+        s->reg[addr / 4] &= ~value;
+        break;
+    case A_UART_RXD:
+        break;
+    case A_UART_RXDRDY:
+        if (value == 0) {
+            s->reg[R_UART_RXDRDY] = 0;
+        }
+        break;
+    case A_UART_STARTTX:
+        if (value == 1) {
+            s->tx_started = true;
+        }
+        break;
+    case A_UART_STARTRX:
+        if (value == 1) {
+            s->rx_started = true;
+        }
+        break;
+    case A_UART_ENABLE:
+        if (value) {
+            if (value == 4) {
+                s->enabled = true;
+            }
+            break;
+        }
+        s->enabled = false;
+        value = 1;
+        /* fall through */
+    case A_UART_SUSPEND:
+    case A_UART_STOPTX:
+        if (value == 1) {
+            s->tx_started = false;
+        }
+        /* fall through */
+    case A_UART_STOPRX:
+        if (addr != A_UART_STOPTX && value == 1) {
+            s->rx_started = false;
+            s->reg[R_UART_RXTO] = 1;
+        }
+        break;
+    default:
+        s->reg[addr / 4] = value;
+        break;
+    }
+    nrf51_uart_update_irq(s);
+}
+
+static const MemoryRegionOps uart_ops = {
+    .read =  uart_read,
+    .write = uart_write,
+    .endianness = DEVICE_LITTLE_ENDIAN,
+};
+
+static void nrf51_uart_reset(DeviceState *dev)
+{
+    NRF51UARTState *s = NRF51_UART(dev);
+
+    s->pending_tx_byte = 0;
+
+    uart_cancel_transmit(s);
+
+    memset(s->reg, 0, sizeof(s->reg));
+
+    s->reg[R_UART_PSELRTS] = 0xFFFFFFFF;
+    s->reg[R_UART_PSELTXD] = 0xFFFFFFFF;
+    s->reg[R_UART_PSELCTS] = 0xFFFFFFFF;
+    s->reg[R_UART_PSELRXD] = 0xFFFFFFFF;
+    s->reg[R_UART_BAUDRATE] = 0x4000000;
+
+    s->rx_fifo_len = 0;
+    s->rx_fifo_pos = 0;
+    s->rx_started = false;
+    s->tx_started = false;
+    s->enabled = false;
+}
+
+static void uart_receive(void *opaque, const uint8_t *buf, int size)
+{
+
+    NRF51UARTState *s = NRF51_UART(opaque);
+    int i;
+
+    if (size == 0 || s->rx_fifo_len >= UART_FIFO_LENGTH) {
+        return;
+    }
+
+    for (i = 0; i < size; i++) {
+        uint32_t pos = (s->rx_fifo_pos + s->rx_fifo_len) % UART_FIFO_LENGTH;
+        s->rx_fifo[pos] = buf[i];
+        s->rx_fifo_len++;
+    }
+
+    s->reg[R_UART_RXDRDY] = 1;
+    nrf51_uart_update_irq(s);
+}
+
+static int uart_can_receive(void *opaque)
+{
+    NRF51UARTState *s = NRF51_UART(opaque);
+
+    return s->rx_started ? (UART_FIFO_LENGTH - s->rx_fifo_len) : 0;
+}
+
+static void uart_event(void *opaque, int event)
+{
+    NRF51UARTState *s = NRF51_UART(opaque);
+
+    if (event == CHR_EVENT_BREAK) {
+        s->reg[R_UART_ERRORSRC] |= 3;
+        s->reg[R_UART_ERROR] = 1;
+        nrf51_uart_update_irq(s);
+    }
+}
+
+static void nrf51_uart_realize(DeviceState *dev, Error **errp)
+{
+    NRF51UARTState *s = NRF51_UART(dev);
+
+    qemu_chr_fe_set_handlers(&s->chr, uart_can_receive, uart_receive,
+                             uart_event, NULL, s, NULL, true);
+}
+
+static void nrf51_uart_init(Object *obj)
+{
+    NRF51UARTState *s = NRF51_UART(obj);
+    SysBusDevice *sbd = SYS_BUS_DEVICE(obj);
+
+    memory_region_init_io(&s->iomem, obj, &uart_ops, s,
+                          "nrf51_soc.uart", UART_SIZE);
+    sysbus_init_mmio(sbd, &s->iomem);
+    sysbus_init_irq(sbd, &s->irq);
+}
+
+static int nrf51_uart_post_load(void *opaque, int version_id)
+{
+    NRF51UARTState *s = NRF51_UART(opaque);
+
+    if (s->pending_tx_byte) {
+        s->watch_tag = qemu_chr_fe_add_watch(&s->chr, G_IO_OUT | G_IO_HUP,
+                                             uart_transmit, s);
+    }
+
+    return 0;
+}
+
+static const VMStateDescription nrf51_uart_vmstate = {
+    .name = "nrf51_soc.uart",
+    .post_load = nrf51_uart_post_load,
+    .fields = (VMStateField[]) {
+        VMSTATE_UINT32_ARRAY(reg, NRF51UARTState, 0x56C),
+        VMSTATE_UINT8_ARRAY(rx_fifo, NRF51UARTState, UART_FIFO_LENGTH),
+        VMSTATE_UINT32(rx_fifo_pos, NRF51UARTState),
+        VMSTATE_UINT32(rx_fifo_len, NRF51UARTState),
+        VMSTATE_BOOL(rx_started, NRF51UARTState),
+        VMSTATE_BOOL(tx_started, NRF51UARTState),
+        VMSTATE_BOOL(pending_tx_byte, NRF51UARTState),
+        VMSTATE_BOOL(enabled, NRF51UARTState),
+        VMSTATE_END_OF_LIST()
+    }
+};
+
+static Property nrf51_uart_properties[] = {
+    DEFINE_PROP_CHR("chardev", NRF51UARTState, chr),
+    DEFINE_PROP_END_OF_LIST(),
+};
+
+static void nrf51_uart_class_init(ObjectClass *klass, void *data)
+{
+    DeviceClass *dc = DEVICE_CLASS(klass);
+
+    dc->reset = nrf51_uart_reset;
+    dc->realize = nrf51_uart_realize;
+    dc->props = nrf51_uart_properties;
+    dc->vmsd = &nrf51_uart_vmstate;
+}
+
+static const TypeInfo nrf51_uart_info = {
+    .name = TYPE_NRF51_UART,
+    .parent = TYPE_SYS_BUS_DEVICE,
+    .instance_size = sizeof(NRF51UARTState),
+    .instance_init = nrf51_uart_init,
+    .class_init = nrf51_uart_class_init
+};
+
+static void nrf51_uart_register_types(void)
+{
+    type_register_static(&nrf51_uart_info);
+}
+
+type_init(nrf51_uart_register_types)
diff --git a/hw/char/trace-events b/hw/char/trace-events
index XXXXXXX..XXXXXXX 100644
--- a/hw/char/trace-events
+++ b/hw/char/trace-events
@@ -XXX,XX +XXX,XX @@ cmsdk_apb_uart_receive(uint8_t c) "CMSDK APB UART: got character 0x%x from backe
 cmsdk_apb_uart_tx_pending(void) "CMSDK APB UART: character send to backend pending"
 cmsdk_apb_uart_tx(uint8_t c) "CMSDK APB UART: character 0x%x sent to backend"
 cmsdk_apb_uart_set_params(int speed) "CMSDK APB UART: params set to %d 8N1"
+
+# hw/char/nrf51_uart.c
+nrf51_uart_read(uint64_t addr, uint64_t r, unsigned int size) "addr 0x%" PRIx64 " value 0x%" PRIx64 " size %u"
+nrf51_uart_write(uint64_t addr, uint64_t value, unsigned int size) "addr 0x%" PRIx64 " value 0x%" PRIx64 " size %u"
-- 
2.19.1

From: Julia Suvorova via Qemu-devel <qemu-devel@nongnu.org>

Wire up nRF51 UART in the corresponding SoC.

Signed-off-by: Julia Suvorova <jusual@mail.ru>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 include/hw/arm/nrf51_soc.h |  3 +++
 hw/arm/microbit.c          |  2 ++
 hw/arm/nrf51_soc.c         | 20 ++++++++++++++++++++
 3 files changed, 25 insertions(+)

diff --git a/include/hw/arm/nrf51_soc.h b/include/hw/arm/nrf51_soc.h
index XXXXXXX..XXXXXXX 100644
--- a/include/hw/arm/nrf51_soc.h
+++ b/include/hw/arm/nrf51_soc.h
@@ -XXX,XX +XXX,XX @@
 
 #include "hw/sysbus.h"
 #include "hw/arm/armv7m.h"
+#include "hw/char/nrf51_uart.h"
 
 #define TYPE_NRF51_SOC "nrf51-soc"
 #define NRF51_SOC(obj) \
@@ -XXX,XX +XXX,XX @@ typedef struct NRF51State {
     /*< public >*/
     ARMv7MState cpu;
 
+    NRF51UARTState uart;
+
     MemoryRegion iomem;
     MemoryRegion sram;
     MemoryRegion flash;
diff --git a/hw/arm/microbit.c b/hw/arm/microbit.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/arm/microbit.c
+++ b/hw/arm/microbit.c
@@ -XXX,XX +XXX,XX @@
 #include "qapi/error.h"
 #include "hw/boards.h"
 #include "hw/arm/arm.h"
+#include "sysemu/sysemu.h"
 #include "exec/address-spaces.h"
 
 #include "hw/arm/nrf51_soc.h"
@@ -XXX,XX +XXX,XX @@ static void microbit_init(MachineState *machine)
 
     sysbus_init_child_obj(OBJECT(machine), "nrf51", soc, sizeof(s->nrf51),
                           TYPE_NRF51_SOC);
+    qdev_prop_set_chr(DEVICE(&s->nrf51), "serial0", serial_hd(0));
     object_property_set_link(soc, OBJECT(system_memory), "memory",
                              &error_fatal);
     object_property_set_bool(soc, true, "realized", &error_fatal);
diff --git a/hw/arm/nrf51_soc.c b/hw/arm/nrf51_soc.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/arm/nrf51_soc.c
+++ b/hw/arm/nrf51_soc.c
@@ -XXX,XX +XXX,XX @@
 #define NRF51822_FLASH_SIZE     (256 * 1024)
 #define NRF51822_SRAM_SIZE      (16 * 1024)
 
+#define BASE_TO_IRQ(base) ((base >> 12) & 0x1F)
+
 static void nrf51_soc_realize(DeviceState *dev_soc, Error **errp)
 {
     NRF51State *s = NRF51_SOC(dev_soc);
+    MemoryRegion *mr;
     Error *err = NULL;
 
     if (!s->board_memory) {
@@ -XXX,XX +XXX,XX @@ static void nrf51_soc_realize(DeviceState *dev_soc, Error **errp)
     }
     memory_region_add_subregion(&s->container, SRAM_BASE, &s->sram);
 
+    /* UART */
+    object_property_set_bool(OBJECT(&s->uart), true, "realized", &err);
+    if (err) {
+        error_propagate(errp, err);
+        return;
+    }
+    mr = sysbus_mmio_get_region(SYS_BUS_DEVICE(&s->uart), 0);
+    memory_region_add_subregion_overlap(&s->container, UART_BASE, mr, 0);
+    sysbus_connect_irq(SYS_BUS_DEVICE(&s->uart), 0,
+                       qdev_get_gpio_in(DEVICE(&s->cpu),
+                       BASE_TO_IRQ(UART_BASE)));
+
     create_unimplemented_device("nrf51_soc.io", IOMEM_BASE, IOMEM_SIZE);
     create_unimplemented_device("nrf51_soc.ficr", FICR_BASE, FICR_SIZE);
     create_unimplemented_device("nrf51_soc.private",
@@ -XXX,XX +XXX,XX @@ static void nrf51_soc_init(Object *obj)
     qdev_prop_set_string(DEVICE(&s->cpu), "cpu-type",
                          ARM_CPU_TYPE_NAME("cortex-m0"));
     qdev_prop_set_uint32(DEVICE(&s->cpu), "num-irq", 32);
+
+    sysbus_init_child_obj(obj, "uart", &s->uart, sizeof(s->uart),
+                           TYPE_NRF51_UART);
+    object_property_add_alias(obj, "serial0", OBJECT(&s->uart), "chardev",
+                              &error_abort);
 }
 
 static Property nrf51_soc_properties[] = {
-- 
2.19.1

From: Julia Suvorova via Qemu-devel <qemu-devel@nongnu.org>

New mini-kernel test for nRF51 SoC UART.

Signed-off-by: Julia Suvorova <jusual@mail.ru>
Acked-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 tests/boot-serial-test.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/tests/boot-serial-test.c b/tests/boot-serial-test.c
index XXXXXXX..XXXXXXX 100644
--- a/tests/boot-serial-test.c
+++ b/tests/boot-serial-test.c
@@ -XXX,XX +XXX,XX @@ static const uint8_t kernel_aarch64[] = {
     0xfd, 0xff, 0xff, 0x17,                 /* b       -12 (loop) */
 };
 
+static const uint8_t kernel_nrf51[] = {
+    0x00, 0x00, 0x00, 0x00,                 /* Stack top address */
+    0x09, 0x00, 0x00, 0x00,                 /* Reset handler address */
+    0x04, 0x4a,                             /* ldr  r2, [pc, #16] Get ENABLE */
+    0x04, 0x21,                             /* movs r1, #4 */
+    0x11, 0x60,                             /* str  r1, [r2] */
+    0x04, 0x4a,                             /* ldr  r2, [pc, #16] Get STARTTX */
+    0x01, 0x21,                             /* movs r1, #1 */
+    0x11, 0x60,                             /* str  r1, [r2] */
+    0x03, 0x4a,                             /* ldr  r2, [pc, #12] Get TXD */
+    0x54, 0x21,                             /* movs r1, 'T' */
+    0x11, 0x60,                             /* str  r1, [r2] */
+    0xfe, 0xe7,                             /* b    . */
+    0x00, 0x25, 0x00, 0x40,                 /* 0x40002500 = UART ENABLE */
+    0x08, 0x20, 0x00, 0x40,                 /* 0x40002008 = UART STARTTX */
+    0x1c, 0x25, 0x00, 0x40                  /* 0x4000251c = UART TXD */
+};
+
 typedef struct testdef {
     const char *arch;       /* Target architecture */
     const char *machine;    /* Name of the machine */
@@ -XXX,XX +XXX,XX @@ static testdef_t tests[] = {
     { "hppa", "hppa", "", "SeaBIOS wants SYSTEM HALT" },
     { "aarch64", "virt", "-cpu cortex-a57", "TT", sizeof(kernel_aarch64),
       kernel_aarch64 },
+    { "arm", "microbit", "", "T", sizeof(kernel_nrf51), kernel_nrf51 },
 
     { NULL }
 };
-- 
2.19.1

Some arm patches; my to-review queue is by no means empty, but
this is a big enough set of patches to be getting on with...

-- PMM

The following changes since commit cb9c6a8e5ad6a1f0ce164d352e3102df46986e22:

.gitlab-ci.d/windows: Work-around timeout and OpenGL problems of the MSYS2 jobs (2023-01-04 18:58:33 +0000)

are available in the Git repository at:

https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20230105

for you to fetch changes up to 93c9678de9dc7d2e68f9e8477da072bac30ef132:

hw/net: Fix read of uninitialized memory in imx_fec. (2023-01-05 15:33:00 +0000)

----------------------------------------------------------------
target-arm queue:
 * Implement AArch32 ARMv8-R support
 * Add Cortex-R52 CPU
 * fix handling of HLT semihosting in system mode
 * hw/timer/ixm_epit: cleanup and fix bug in compare handling
 * target/arm: Coding style fixes
 * target/arm: Clean up includes
 * nseries: minor code cleanups
 * target/arm: align exposed ID registers with Linux
 * hw/arm/smmu-common: remove unnecessary inlines
 * i.MX7D: Handle GPT timers
 * i.MX7D: Connect IRQs to GPIO devices
 * i.MX6UL: Add a specific GPT timer instance
 * hw/net: Fix read of uninitialized memory in imx_fec

----------------------------------------------------------------
Alex Bennée (1):
      target/arm: fix handling of HLT semihosting in system mode

Axel Heider (8):
      hw/timer/imx_epit: improve comments
      hw/timer/imx_epit: cleanup CR defines
      hw/timer/imx_epit: define SR_OCIF
      hw/timer/imx_epit: update interrupt state on CR write access
      hw/timer/imx_epit: hard reset initializes CR with 0
      hw/timer/imx_epit: factor out register write handlers
      hw/timer/imx_epit: remove explicit fields cnt and freq
      hw/timer/imx_epit: fix compare timer handling

Claudio Fontana (1):
      target/arm: cleanup cpu includes

Fabiano Rosas (5):
      target/arm: Fix checkpatch comment style warnings in helper.c
      target/arm: Fix checkpatch space errors in helper.c
      target/arm: Fix checkpatch brace errors in helper.c
      target/arm: Remove unused includes from m_helper.c
      target/arm: Remove unused includes from helper.c

Jean-Christophe Dubois (4):
      i.MX7D: Connect GPT timers to IRQ
      i.MX7D: Compute clock frequency for the fixed frequency clocks.
      i.MX6UL: Add a specific GPT timer instance for the i.MX6UL
      i.MX7D: Connect IRQs to GPIO devices.

Peter Maydell (1):
      target/arm:Set lg_page_size to 0 if either S1 or S2 asks for it

Philippe Mathieu-Daudé (5):
      hw/input/tsc2xxx: Constify set_transform()'s MouseTransformInfo arg
      hw/arm/nseries: Constify various read-only arrays
      hw/arm/nseries: Silent -Wmissing-field-initializers warning
      hw/arm/smmu-common: Reduce smmu_inv_notifiers_mr() scope
      hw/arm/smmu-common: Avoid using inlined functions with external linkage

Stephen Longfield (1):
      hw/net: Fix read of uninitialized memory in imx_fec.

Tobias Röhmel (7):
      target/arm: Don't add all MIDR aliases for cores that implement PMSA
      target/arm: Make RVBAR available for all ARMv8 CPUs
      target/arm: Make stage_2_format for cache attributes optional
      target/arm: Enable TTBCR_EAE for ARMv8-R AArch32
      target/arm: Add PMSAv8r registers
      target/arm: Add PMSAv8r functionality
      target/arm: Add ARM Cortex-R52 CPU

Zhuojia Shen (1):
      target/arm: align exposed ID registers with Linux

In get_phys_addr_twostage() we set the lg_page_size of the result to
the maximum of the stage 1 and stage 2 page sizes.  This works for
the case where we do want to create a TLB entry, because we know the
common TLB code only creates entries of the TARGET_PAGE_SIZE and
asking for a size larger than that only means that invalidations
invalidate the whole larger area.  However, if lg_page_size is
smaller than TARGET_PAGE_SIZE this effectively means "don't create a
TLB entry"; in this case if either S1 or S2 said "this covers less
than a page and can't go in a TLB" then the final result also should
be marked that way.  Set the resulting page size to 0 if either
stage asked for a less-than-a-page entry, and expand the comment
to explain what's going on.

This has no effect for VMSA because currently the VMSA lookup always
returns results that cover at least TARGET_PAGE_SIZE; however when we
add v8R support it will reuse this code path, and for v8R the S1 and
S2 results can be smaller than TARGET_PAGE_SIZE.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20221212142708.610090-1-peter.maydell@linaro.org
---
 target/arm/ptw.c | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/target/arm/ptw.c b/target/arm/ptw.c
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/ptw.c
+++ b/target/arm/ptw.c
@@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_twostage(CPUARMState *env, S1Translate *ptw,
     }
 
     /*
-     * Use the maximum of the S1 & S2 page size, so that invalidation
-     * of pages > TARGET_PAGE_SIZE works correctly.
+     * If either S1 or S2 returned a result smaller than TARGET_PAGE_SIZE,
+     * this means "don't put this in the TLB"; in this case, return a
+     * result with lg_page_size == 0 to achieve that. Otherwise,
+     * use the maximum of the S1 & S2 page size, so that invalidation
+     * of pages > TARGET_PAGE_SIZE works correctly. (This works even though
+     * we know the combined result permissions etc only cover the minimum
+     * of the S1 and S2 page size, because we know that the common TLB code
+     * never actually creates TLB entries bigger than TARGET_PAGE_SIZE,
+     * and passing a larger page size value only affects invalidations.)
      */
-    if (result->f.lg_page_size < s1_lgpgsz) {
+    if (result->f.lg_page_size < TARGET_PAGE_BITS ||
+        s1_lgpgsz < TARGET_PAGE_BITS) {
+        result->f.lg_page_size = 0;
+    } else if (result->f.lg_page_size < s1_lgpgsz) {
         result->f.lg_page_size = s1_lgpgsz;
     }
 
-- 
2.25.1

From: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>

Cores with PMSA have the MPUIR register which has the
same encoding as the MIDR alias with opc2=4. So we only
add that alias if we are not realizing a core that
implements PMSA.

Signed-off-by: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20221206102504.165775-2-tobias.roehmel@rwth-aachen.de
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/arm/helper.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/target/arm/helper.c b/target/arm/helper.c
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
               .access = PL1_R, .type = ARM_CP_NO_RAW, .resetvalue = cpu->midr,
               .fieldoffset = offsetof(CPUARMState, cp15.c0_cpuid),
               .readfn = midr_read },
-            /* crn = 0 op1 = 0 crm = 0 op2 = 4,7 : AArch32 aliases of MIDR */
-            { .name = "MIDR", .type = ARM_CP_ALIAS | ARM_CP_CONST,
-              .cp = 15, .crn = 0, .crm = 0, .opc1 = 0, .opc2 = 4,
-              .access = PL1_R, .resetvalue = cpu->midr },
+            /* crn = 0 op1 = 0 crm = 0 op2 = 7 : AArch32 aliases of MIDR */
             { .name = "MIDR", .type = ARM_CP_ALIAS | ARM_CP_CONST,
               .cp = 15, .crn = 0, .crm = 0, .opc1 = 0, .opc2 = 7,
               .access = PL1_R, .resetvalue = cpu->midr },
@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
               .accessfn = access_aa64_tid1,
               .type = ARM_CP_CONST, .resetvalue = cpu->revidr },
         };
+        ARMCPRegInfo id_v8_midr_alias_cp_reginfo = {
+            .name = "MIDR", .type = ARM_CP_ALIAS | ARM_CP_CONST,
+            .cp = 15, .crn = 0, .crm = 0, .opc1 = 0, .opc2 = 4,
+            .access = PL1_R, .resetvalue = cpu->midr
+        };
         ARMCPRegInfo id_cp_reginfo[] = {
             /* These are common to v8 and pre-v8 */
             { .name = "CTR",
@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
         }
         if (arm_feature(env, ARM_FEATURE_V8)) {
             define_arm_cp_regs(cpu, id_v8_midr_cp_reginfo);
+            if (!arm_feature(env, ARM_FEATURE_PMSA)) {
+                define_one_arm_cp_reg(cpu, &id_v8_midr_alias_cp_reginfo);
+            }
         } else {
             define_arm_cp_regs(cpu, id_pre_v8_midr_cp_reginfo);
         }
-- 
2.25.1

From: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>

RVBAR shadows RVBAR_ELx where x is the highest exception
level if the highest EL is not EL3. This patch also allows
ARMv8 CPUs to change the reset address with
the rvbar property.

Signed-off-by: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20221206102504.165775-3-tobias.roehmel@rwth-aachen.de
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/arm/cpu.c    |  6 +++++-
 target/arm/helper.c | 21 ++++++++++++++-------
 2 files changed, 19 insertions(+), 8 deletions(-)

diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -XXX,XX +XXX,XX @@ static void arm_cpu_reset_hold(Object *obj)
         env->cp15.cpacr_el1 = FIELD_DP64(env->cp15.cpacr_el1,
                                          CPACR, CP11, 3);
 #endif
+        if (arm_feature(env, ARM_FEATURE_V8)) {
+            env->cp15.rvbar = cpu->rvbar_prop;
+            env->regs[15] = cpu->rvbar_prop;
+        }
     }
 
 #if defined(CONFIG_USER_ONLY)
@@ -XXX,XX +XXX,XX @@ void arm_cpu_post_init(Object *obj)
         qdev_property_add_static(DEVICE(obj), &arm_cpu_reset_hivecs_property);
     }
 
-    if (arm_feature(&cpu->env, ARM_FEATURE_AARCH64)) {
+    if (arm_feature(&cpu->env, ARM_FEATURE_V8)) {
         object_property_add_uint64_ptr(obj, "rvbar",
                                        &cpu->rvbar_prop,
                                        OBJ_PROP_FLAG_READWRITE);
diff --git a/target/arm/helper.c b/target/arm/helper.c
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
         if (!arm_feature(env, ARM_FEATURE_EL3) &&
             !arm_feature(env, ARM_FEATURE_EL2)) {
             ARMCPRegInfo rvbar = {
-                .name = "RVBAR_EL1", .state = ARM_CP_STATE_AA64,
+                .name = "RVBAR_EL1", .state = ARM_CP_STATE_BOTH,
                 .opc0 = 3, .opc1 = 0, .crn = 12, .crm = 0, .opc2 = 1,
                 .access = PL1_R,
                 .fieldoffset = offsetof(CPUARMState, cp15.rvbar),
@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
         }
         /* RVBAR_EL2 is only implemented if EL2 is the highest EL */
         if (!arm_feature(env, ARM_FEATURE_EL3)) {
-            ARMCPRegInfo rvbar = {
-                .name = "RVBAR_EL2", .state = ARM_CP_STATE_AA64,
-                .opc0 = 3, .opc1 = 4, .crn = 12, .crm = 0, .opc2 = 1,
-                .access = PL2_R,
-                .fieldoffset = offsetof(CPUARMState, cp15.rvbar),
+            ARMCPRegInfo rvbar[] = {
+                {
+                    .name = "RVBAR_EL2", .state = ARM_CP_STATE_AA64,
+                    .opc0 = 3, .opc1 = 4, .crn = 12, .crm = 0, .opc2 = 1,
+                    .access = PL2_R,
+                    .fieldoffset = offsetof(CPUARMState, cp15.rvbar),
+                },
+                {   .name = "RVBAR", .type = ARM_CP_ALIAS,
+                    .cp = 15, .opc1 = 0, .crn = 12, .crm = 0, .opc2 = 1,
+                    .access = PL2_R,
+                    .fieldoffset = offsetof(CPUARMState, cp15.rvbar),
+                },
             };
-            define_one_arm_cp_reg(cpu, &rvbar);
+            define_arm_cp_regs(cpu, rvbar);
         }
     }
 
-- 
2.25.1

From: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>

The v8R PMSAv8 has a two-stage MPU translation process, but, unlike
VMSAv8, the stage 2 attributes are in the same format as the stage 1
attributes (8-bit MAIR format). Rather than converting the MAIR
format to the format used for VMSA stage 2 (bits [5:2] of a VMSA
stage 2 descriptor) and then converting back to do the attribute
combination, allow combined_attrs_nofwb() to accept s2 attributes
that are already in the MAIR format.

We move the assert() to combined_attrs_fwb(), because that function
really does require a VMSA stage 2 attribute format. (We will never
get there for v8R, because PMSAv8 does not implement FEAT_S2FWB.)

Signed-off-by: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20221206102504.165775-4-tobias.roehmel@rwth-aachen.de
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/arm/ptw.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/target/arm/ptw.c b/target/arm/ptw.c
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/ptw.c
+++ b/target/arm/ptw.c
@@ -XXX,XX +XXX,XX @@ static uint8_t combined_attrs_nofwb(uint64_t hcr,
 {
     uint8_t s1lo, s2lo, s1hi, s2hi, s2_mair_attrs, ret_attrs;
 
-    s2_mair_attrs = convert_stage2_attrs(hcr, s2.attrs);
+    if (s2.is_s2_format) {
+        s2_mair_attrs = convert_stage2_attrs(hcr, s2.attrs);
+    } else {
+        s2_mair_attrs = s2.attrs;
+    }
 
     s1lo = extract32(s1.attrs, 0, 4);
     s2lo = extract32(s2_mair_attrs, 0, 4);
@@ -XXX,XX +XXX,XX @@ static uint8_t force_cacheattr_nibble_wb(uint8_t attr)
  */
 static uint8_t combined_attrs_fwb(ARMCacheAttrs s1, ARMCacheAttrs s2)
 {
+    assert(s2.is_s2_format && !s1.is_s2_format);
+
     switch (s2.attrs) {
     case 7:
         /* Use stage 1 attributes */
@@ -XXX,XX +XXX,XX @@ static ARMCacheAttrs combine_cacheattrs(uint64_t hcr,
     ARMCacheAttrs ret;
     bool tagged = false;
 
-    assert(s2.is_s2_format && !s1.is_s2_format);
+    assert(!s1.is_s2_format);
     ret.is_s2_format = false;
 
     if (s1.attrs == 0xf0) {
-- 
2.25.1

From: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>

ARMv8-R AArch32 CPUs behave as if TTBCR.EAE is always 1 even
tough they don't have the TTBCR register.
See ARM Architecture Reference Manual Supplement - ARMv8, for the ARMv8-R
AArch32 architecture profile Version:A.c section C1.2.

Signed-off-by: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20221206102504.165775-5-tobias.roehmel@rwth-aachen.de
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/arm/internals.h    | 4 ++++
 target/arm/debug_helper.c | 3 +++
 target/arm/tlb_helper.c   | 4 ++++
 3 files changed, 11 insertions(+)

diff --git a/target/arm/internals.h b/target/arm/internals.h
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/internals.h
+++ b/target/arm/internals.h
@@ -XXX,XX +XXX,XX @@ unsigned int arm_pamax(ARMCPU *cpu);
 static inline bool extended_addresses_enabled(CPUARMState *env)
 {
     uint64_t tcr = env->cp15.tcr_el[arm_is_secure(env) ? 3 : 1];
+    if (arm_feature(env, ARM_FEATURE_PMSA) &&
+        arm_feature(env, ARM_FEATURE_V8)) {
+        return true;
+    }
     return arm_el_is_aa64(env, 1) ||
            (arm_feature(env, ARM_FEATURE_LPAE) && (tcr & TTBCR_EAE));
 }
diff --git a/target/arm/debug_helper.c b/target/arm/debug_helper.c
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/debug_helper.c
+++ b/target/arm/debug_helper.c
@@ -XXX,XX +XXX,XX @@ static uint32_t arm_debug_exception_fsr(CPUARMState *env)
 
     if (target_el == 2 || arm_el_is_aa64(env, target_el)) {
         using_lpae = true;
+    } else if (arm_feature(env, ARM_FEATURE_PMSA) &&
+               arm_feature(env, ARM_FEATURE_V8)) {
+        using_lpae = true;
     } else {
         if (arm_feature(env, ARM_FEATURE_LPAE) &&
             (env->cp15.tcr_el[target_el] & TTBCR_EAE)) {
diff --git a/target/arm/tlb_helper.c b/target/arm/tlb_helper.c
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/tlb_helper.c
+++ b/target/arm/tlb_helper.c
@@ -XXX,XX +XXX,XX @@ bool regime_using_lpae_format(CPUARMState *env, ARMMMUIdx mmu_idx)
     if (el == 2 || arm_el_is_aa64(env, el)) {
         return true;
     }
+    if (arm_feature(env, ARM_FEATURE_PMSA) &&
+        arm_feature(env, ARM_FEATURE_V8)) {
+        return true;
+    }
     if (arm_feature(env, ARM_FEATURE_LPAE)
         && (regime_tcr(env, mmu_idx) & TTBCR_EAE)) {
         return true;
-- 
2.25.1

From: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>

Signed-off-by: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>
Message-id: 20221206102504.165775-6-tobias.roehmel@rwth-aachen.de
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/arm/cpu.h     |   6 +
 target/arm/cpu.c     |  28 +++-
 target/arm/helper.c  | 302 +++++++++++++++++++++++++++++++++++++++++++
 target/arm/machine.c |  28 ++++
 4 files changed, 360 insertions(+), 4 deletions(-)

diff --git a/target/arm/cpu.h b/target/arm/cpu.h
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/cpu.h
+++ b/target/arm/cpu.h
@@ -XXX,XX +XXX,XX @@ typedef struct CPUArchState {
             };
             uint64_t sctlr_el[4];
         };
+        uint64_t vsctlr; /* Virtualization System control register. */
         uint64_t cpacr_el1; /* Architectural feature access control register */
         uint64_t cptr_el[4];  /* ARMv8 feature trap registers */
         uint32_t c1_xscaleauxcr; /* XScale auxiliary control register.  */
@@ -XXX,XX +XXX,XX @@ typedef struct CPUArchState {
          */
         uint32_t *rbar[M_REG_NUM_BANKS];
         uint32_t *rlar[M_REG_NUM_BANKS];
+        uint32_t *hprbar;
+        uint32_t *hprlar;
         uint32_t mair0[M_REG_NUM_BANKS];
         uint32_t mair1[M_REG_NUM_BANKS];
+        uint32_t hprselr;
     } pmsav8;
 
     /* v8M SAU */
@@ -XXX,XX +XXX,XX @@ struct ArchCPU {
     bool has_mpu;
     /* PMSAv7 MPU number of supported regions */
     uint32_t pmsav7_dregion;
+    /* PMSAv8 MPU number of supported hyp regions */
+    uint32_t pmsav8r_hdregion;
     /* v8M SAU number of supported regions */
     uint32_t sau_sregion;
 
diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -XXX,XX +XXX,XX @@ static void arm_cpu_reset_hold(Object *obj)
                        sizeof(*env->pmsav7.dracr) * cpu->pmsav7_dregion);
             }
         }
+
+        if (cpu->pmsav8r_hdregion > 0) {
+            memset(env->pmsav8.hprbar, 0,
+                   sizeof(*env->pmsav8.hprbar) * cpu->pmsav8r_hdregion);
+            memset(env->pmsav8.hprlar, 0,
+                   sizeof(*env->pmsav8.hprlar) * cpu->pmsav8r_hdregion);
+        }
+
         env->pmsav7.rnr[M_REG_NS] = 0;
         env->pmsav7.rnr[M_REG_S] = 0;
         env->pmsav8.mair0[M_REG_NS] = 0;
@@ -XXX,XX +XXX,XX @@ static void arm_cpu_realizefn(DeviceState *dev, Error **errp)
     /* MPU can be configured out of a PMSA CPU either by setting has-mpu
      * to false or by setting pmsav7-dregion to 0.
      */
-    if (!cpu->has_mpu) {
-        cpu->pmsav7_dregion = 0;
-    }
-    if (cpu->pmsav7_dregion == 0) {
+    if (!cpu->has_mpu || cpu->pmsav7_dregion == 0) {
         cpu->has_mpu = false;
+        cpu->pmsav7_dregion = 0;
+        cpu->pmsav8r_hdregion = 0;
     }
 
     if (arm_feature(env, ARM_FEATURE_PMSA) &&
@@ -XXX,XX +XXX,XX @@ static void arm_cpu_realizefn(DeviceState *dev, Error **errp)
                 env->pmsav7.dracr = g_new0(uint32_t, nr);
             }
         }
+
+        if (cpu->pmsav8r_hdregion > 0xff) {
+            error_setg(errp, "PMSAv8 MPU EL2 #regions invalid %" PRIu32,
+                              cpu->pmsav8r_hdregion);
+            return;
+        }
+
+        if (cpu->pmsav8r_hdregion) {
+            env->pmsav8.hprbar = g_new0(uint32_t,
+                                        cpu->pmsav8r_hdregion);
+            env->pmsav8.hprlar = g_new0(uint32_t,
+                                        cpu->pmsav8r_hdregion);
+        }
     }
 
     if (arm_feature(env, ARM_FEATURE_M_SECURITY)) {
diff --git a/target/arm/helper.c b/target/arm/helper.c
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -XXX,XX +XXX,XX @@ static void pmsav7_rgnr_write(CPUARMState *env, const ARMCPRegInfo *ri,
     raw_write(env, ri, value);
 }
 
+static void prbar_write(CPUARMState *env, const ARMCPRegInfo *ri,
+                          uint64_t value)
+{
+    ARMCPU *cpu = env_archcpu(env);
+
+    tlb_flush(CPU(cpu)); /* Mappings may have changed - purge! */
+    env->pmsav8.rbar[M_REG_NS][env->pmsav7.rnr[M_REG_NS]] = value;
+}
+
+static uint64_t prbar_read(CPUARMState *env, const ARMCPRegInfo *ri)
+{
+    return env->pmsav8.rbar[M_REG_NS][env->pmsav7.rnr[M_REG_NS]];
+}
+
+static void prlar_write(CPUARMState *env, const ARMCPRegInfo *ri,
+                          uint64_t value)
+{
+    ARMCPU *cpu = env_archcpu(env);
+
+    tlb_flush(CPU(cpu)); /* Mappings may have changed - purge! */
+    env->pmsav8.rlar[M_REG_NS][env->pmsav7.rnr[M_REG_NS]] = value;
+}
+
+static uint64_t prlar_read(CPUARMState *env, const ARMCPRegInfo *ri)
+{
+    return env->pmsav8.rlar[M_REG_NS][env->pmsav7.rnr[M_REG_NS]];
+}
+
+static void prselr_write(CPUARMState *env, const ARMCPRegInfo *ri,
+                           uint64_t value)
+{
+    ARMCPU *cpu = env_archcpu(env);
+
+    /*
+     * Ignore writes that would select not implemented region.
+     * This is architecturally UNPREDICTABLE.
+     */
+    if (value >= cpu->pmsav7_dregion) {
+        return;
+    }
+
+    env->pmsav7.rnr[M_REG_NS] = value;
+}
+
+static void hprbar_write(CPUARMState *env, const ARMCPRegInfo *ri,
+                          uint64_t value)
+{
+    ARMCPU *cpu = env_archcpu(env);
+
+    tlb_flush(CPU(cpu)); /* Mappings may have changed - purge! */
+    env->pmsav8.hprbar[env->pmsav8.hprselr] = value;
+}
+
+static uint64_t hprbar_read(CPUARMState *env, const ARMCPRegInfo *ri)
+{
+    return env->pmsav8.hprbar[env->pmsav8.hprselr];
+}
+
+static void hprlar_write(CPUARMState *env, const ARMCPRegInfo *ri,
+                          uint64_t value)
+{
+    ARMCPU *cpu = env_archcpu(env);
+
+    tlb_flush(CPU(cpu)); /* Mappings may have changed - purge! */
+    env->pmsav8.hprlar[env->pmsav8.hprselr] = value;
+}
+
+static uint64_t hprlar_read(CPUARMState *env, const ARMCPRegInfo *ri)
+{
+    return env->pmsav8.hprlar[env->pmsav8.hprselr];
+}
+
+static void hprenr_write(CPUARMState *env, const ARMCPRegInfo *ri,
+                          uint64_t value)
+{
+    uint32_t n;
+    uint32_t bit;
+    ARMCPU *cpu = env_archcpu(env);
+
+    /* Ignore writes to unimplemented regions */
+    int rmax = MIN(cpu->pmsav8r_hdregion, 32);
+    value &= MAKE_64BIT_MASK(0, rmax);
+
+    tlb_flush(CPU(cpu)); /* Mappings may have changed - purge! */
+
+    /* Register alias is only valid for first 32 indexes */
+    for (n = 0; n < rmax; ++n) {
+        bit = extract32(value, n, 1);
+        env->pmsav8.hprlar[n] = deposit32(
+                    env->pmsav8.hprlar[n], 0, 1, bit);
+    }
+}
+
+static uint64_t hprenr_read(CPUARMState *env, const ARMCPRegInfo *ri)
+{
+    uint32_t n;
+    uint32_t result = 0x0;
+    ARMCPU *cpu = env_archcpu(env);
+
+    /* Register alias is only valid for first 32 indexes */
+    for (n = 0; n < MIN(cpu->pmsav8r_hdregion, 32); ++n) {
+        if (env->pmsav8.hprlar[n] & 0x1) {
+            result |= (0x1 << n);
+        }
+    }
+    return result;
+}
+
+static void hprselr_write(CPUARMState *env, const ARMCPRegInfo *ri,
+                           uint64_t value)
+{
+    ARMCPU *cpu = env_archcpu(env);
+
+    /*
+     * Ignore writes that would select not implemented region.
+     * This is architecturally UNPREDICTABLE.
+     */
+    if (value >= cpu->pmsav8r_hdregion) {
+        return;
+    }
+
+    env->pmsav8.hprselr = value;
+}
+
+static void pmsav8r_regn_write(CPUARMState *env, const ARMCPRegInfo *ri,
+                          uint64_t value)
+{
+    ARMCPU *cpu = env_archcpu(env);
+    uint8_t index = (extract32(ri->opc0, 0, 1) << 4) |
+                    (extract32(ri->crm, 0, 3) << 1) | extract32(ri->opc2, 2, 1);
+
+    tlb_flush(CPU(cpu)); /* Mappings may have changed - purge! */
+
+    if (ri->opc1 & 4) {
+        if (index >= cpu->pmsav8r_hdregion) {
+            return;
+        }
+        if (ri->opc2 & 0x1) {
+            env->pmsav8.hprlar[index] = value;
+        } else {
+            env->pmsav8.hprbar[index] = value;
+        }
+    } else {
+        if (index >= cpu->pmsav7_dregion) {
+            return;
+        }
+        if (ri->opc2 & 0x1) {
+            env->pmsav8.rlar[M_REG_NS][index] = value;
+        } else {
+            env->pmsav8.rbar[M_REG_NS][index] = value;
+        }
+    }
+}
+
+static uint64_t pmsav8r_regn_read(CPUARMState *env, const ARMCPRegInfo *ri)
+{
+    ARMCPU *cpu = env_archcpu(env);
+    uint8_t index = (extract32(ri->opc0, 0, 1) << 4) |
+                    (extract32(ri->crm, 0, 3) << 1) | extract32(ri->opc2, 2, 1);
+
+    if (ri->opc1 & 4) {
+        if (index >= cpu->pmsav8r_hdregion) {
+            return 0x0;
+        }
+        if (ri->opc2 & 0x1) {
+            return env->pmsav8.hprlar[index];
+        } else {
+            return env->pmsav8.hprbar[index];
+        }
+    } else {
+        if (index >= cpu->pmsav7_dregion) {
+            return 0x0;
+        }
+        if (ri->opc2 & 0x1) {
+            return env->pmsav8.rlar[M_REG_NS][index];
+        } else {
+            return env->pmsav8.rbar[M_REG_NS][index];
+        }
+    }
+}
+
+static const ARMCPRegInfo pmsav8r_cp_reginfo[] = {
+    { .name = "PRBAR",
+      .cp = 15, .opc1 = 0, .crn = 6, .crm = 3, .opc2 = 0,
+      .access = PL1_RW, .type = ARM_CP_NO_RAW,
+      .accessfn = access_tvm_trvm,
+      .readfn = prbar_read, .writefn = prbar_write },
+    { .name = "PRLAR",
+      .cp = 15, .opc1 = 0, .crn = 6, .crm = 3, .opc2 = 1,
+      .access = PL1_RW, .type = ARM_CP_NO_RAW,
+      .accessfn = access_tvm_trvm,
+      .readfn = prlar_read, .writefn = prlar_write },
+    { .name = "PRSELR", .resetvalue = 0,
+      .cp = 15, .opc1 = 0, .crn = 6, .crm = 2, .opc2 = 1,
+      .access = PL1_RW, .accessfn = access_tvm_trvm,
+      .writefn = prselr_write,
+      .fieldoffset = offsetof(CPUARMState, pmsav7.rnr[M_REG_NS]) },
+    { .name = "HPRBAR", .resetvalue = 0,
+      .cp = 15, .opc1 = 4, .crn = 6, .crm = 3, .opc2 = 0,
+      .access = PL2_RW, .type = ARM_CP_NO_RAW,
+      .readfn = hprbar_read, .writefn = hprbar_write },
+    { .name = "HPRLAR",
+      .cp = 15, .opc1 = 4, .crn = 6, .crm = 3, .opc2 = 1,
+      .access = PL2_RW, .type = ARM_CP_NO_RAW,
+      .readfn = hprlar_read, .writefn = hprlar_write },
+    { .name = "HPRSELR", .resetvalue = 0,
+      .cp = 15, .opc1 = 4, .crn = 6, .crm = 2, .opc2 = 1,
+      .access = PL2_RW,
+      .writefn = hprselr_write,
+      .fieldoffset = offsetof(CPUARMState, pmsav8.hprselr) },
+    { .name = "HPRENR",
+      .cp = 15, .opc1 = 4, .crn = 6, .crm = 1, .opc2 = 1,
+      .access = PL2_RW, .type = ARM_CP_NO_RAW,
+      .readfn = hprenr_read, .writefn = hprenr_write },
+};
+
 static const ARMCPRegInfo pmsav7_cp_reginfo[] = {
     /* Reset for all these registers is handled in arm_cpu_reset(),
      * because the PMSAv7 is also used by M-profile CPUs, which do
@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
               .access = PL1_R, .type = ARM_CP_CONST,
               .resetvalue = cpu->pmsav7_dregion << 8
         };
+        /* HMPUIR is specific to PMSA V8 */
+        ARMCPRegInfo id_hmpuir_reginfo = {
+            .name = "HMPUIR",
+            .cp = 15, .opc1 = 4, .crn = 0, .crm = 0, .opc2 = 4,
+            .access = PL2_R, .type = ARM_CP_CONST,
+            .resetvalue = cpu->pmsav8r_hdregion
+        };
         static const ARMCPRegInfo crn0_wi_reginfo = {
             .name = "CRN0_WI", .cp = 15, .crn = 0, .crm = CP_ANY,
             .opc1 = CP_ANY, .opc2 = CP_ANY, .access = PL1_W,
@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
         define_arm_cp_regs(cpu, id_cp_reginfo);
         if (!arm_feature(env, ARM_FEATURE_PMSA)) {
             define_one_arm_cp_reg(cpu, &id_tlbtr_reginfo);
+        } else if (arm_feature(env, ARM_FEATURE_PMSA) &&
+                   arm_feature(env, ARM_FEATURE_V8)) {
+            uint32_t i = 0;
+            char *tmp_string;
+
+            define_one_arm_cp_reg(cpu, &id_mpuir_reginfo);
+            define_one_arm_cp_reg(cpu, &id_hmpuir_reginfo);
+            define_arm_cp_regs(cpu, pmsav8r_cp_reginfo);
+
+            /* Register alias is only valid for first 32 indexes */
+            for (i = 0; i < MIN(cpu->pmsav7_dregion, 32); ++i) {
+                uint8_t crm = 0b1000 | extract32(i, 1, 3);
+                uint8_t opc1 = extract32(i, 4, 1);
+                uint8_t opc2 = extract32(i, 0, 1) << 2;
+
+                tmp_string = g_strdup_printf("PRBAR%u", i);
+                ARMCPRegInfo tmp_prbarn_reginfo = {
+                    .name = tmp_string, .type = ARM_CP_ALIAS | ARM_CP_NO_RAW,
+                    .cp = 15, .opc1 = opc1, .crn = 6, .crm = crm, .opc2 = opc2,
+                    .access = PL1_RW, .resetvalue = 0,
+                    .accessfn = access_tvm_trvm,
+                    .writefn = pmsav8r_regn_write, .readfn = pmsav8r_regn_read
+                };
+                define_one_arm_cp_reg(cpu, &tmp_prbarn_reginfo);
+                g_free(tmp_string);
+
+                opc2 = extract32(i, 0, 1) << 2 | 0x1;
+                tmp_string = g_strdup_printf("PRLAR%u", i);
+                ARMCPRegInfo tmp_prlarn_reginfo = {
+                    .name = tmp_string, .type = ARM_CP_ALIAS | ARM_CP_NO_RAW,
+                    .cp = 15, .opc1 = opc1, .crn = 6, .crm = crm, .opc2 = opc2,
+                    .access = PL1_RW, .resetvalue = 0,
+                    .accessfn = access_tvm_trvm,
+                    .writefn = pmsav8r_regn_write, .readfn = pmsav8r_regn_read
+                };
+                define_one_arm_cp_reg(cpu, &tmp_prlarn_reginfo);
+                g_free(tmp_string);
+            }
+
+            /* Register alias is only valid for first 32 indexes */
+            for (i = 0; i < MIN(cpu->pmsav8r_hdregion, 32); ++i) {
+                uint8_t crm = 0b1000 | extract32(i, 1, 3);
+                uint8_t opc1 = 0b100 | extract32(i, 4, 1);
+                uint8_t opc2 = extract32(i, 0, 1) << 2;
+
+                tmp_string = g_strdup_printf("HPRBAR%u", i);
+                ARMCPRegInfo tmp_hprbarn_reginfo = {
+                    .name = tmp_string,
+                    .type = ARM_CP_NO_RAW,
+                    .cp = 15, .opc1 = opc1, .crn = 6, .crm = crm, .opc2 = opc2,
+                    .access = PL2_RW, .resetvalue = 0,
+                    .writefn = pmsav8r_regn_write, .readfn = pmsav8r_regn_read
+                };
+                define_one_arm_cp_reg(cpu, &tmp_hprbarn_reginfo);
+                g_free(tmp_string);
+
+                opc2 = extract32(i, 0, 1) << 2 | 0x1;
+                tmp_string = g_strdup_printf("HPRLAR%u", i);
+                ARMCPRegInfo tmp_hprlarn_reginfo = {
+                    .name = tmp_string,
+                    .type = ARM_CP_NO_RAW,
+                    .cp = 15, .opc1 = opc1, .crn = 6, .crm = crm, .opc2 = opc2,
+                    .access = PL2_RW, .resetvalue = 0,
+                    .writefn = pmsav8r_regn_write, .readfn = pmsav8r_regn_read
+                };
+                define_one_arm_cp_reg(cpu, &tmp_hprlarn_reginfo);
+                g_free(tmp_string);
+            }
         } else if (arm_feature(env, ARM_FEATURE_V7)) {
             define_one_arm_cp_reg(cpu, &id_mpuir_reginfo);
         }
@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
             sctlr.type |= ARM_CP_SUPPRESS_TB_END;
         }
         define_one_arm_cp_reg(cpu, &sctlr);
+
+        if (arm_feature(env, ARM_FEATURE_PMSA) &&
+            arm_feature(env, ARM_FEATURE_V8)) {
+            ARMCPRegInfo vsctlr = {
+                .name = "VSCTLR", .state = ARM_CP_STATE_AA32,
+                .cp = 15, .opc1 = 4, .crn = 2, .crm = 0, .opc2 = 0,
+                .access = PL2_RW, .resetvalue = 0x0,
+                .fieldoffset = offsetoflow32(CPUARMState, cp15.vsctlr),
+            };
+            define_one_arm_cp_reg(cpu, &vsctlr);
+        }
     }
 
     if (cpu_isar_feature(aa64_lor, cpu)) {
diff --git a/target/arm/machine.c b/target/arm/machine.c
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/machine.c
+++ b/target/arm/machine.c
@@ -XXX,XX +XXX,XX @@ static bool pmsav8_needed(void *opaque)
         arm_feature(env, ARM_FEATURE_V8);
 }
 
+static bool pmsav8r_needed(void *opaque)
+{
+    ARMCPU *cpu = opaque;
+    CPUARMState *env = &cpu->env;
+
+    return arm_feature(env, ARM_FEATURE_PMSA) &&
+        arm_feature(env, ARM_FEATURE_V8) &&
+        !arm_feature(env, ARM_FEATURE_M);
+}
+
+static const VMStateDescription vmstate_pmsav8r = {
+    .name = "cpu/pmsav8/pmsav8r",
+    .version_id = 1,
+    .minimum_version_id = 1,
+    .needed = pmsav8r_needed,
+    .fields = (VMStateField[]) {
+        VMSTATE_VARRAY_UINT32(env.pmsav8.hprbar, ARMCPU,
+                        pmsav8r_hdregion, 0, vmstate_info_uint32, uint32_t),
+        VMSTATE_VARRAY_UINT32(env.pmsav8.hprlar, ARMCPU,
+                        pmsav8r_hdregion, 0, vmstate_info_uint32, uint32_t),
+        VMSTATE_END_OF_LIST()
+    },
+};
+
 static const VMStateDescription vmstate_pmsav8 = {
     .name = "cpu/pmsav8",
     .version_id = 1,
@@ -XXX,XX +XXX,XX @@ static const VMStateDescription vmstate_pmsav8 = {
         VMSTATE_UINT32(env.pmsav8.mair0[M_REG_NS], ARMCPU),
         VMSTATE_UINT32(env.pmsav8.mair1[M_REG_NS], ARMCPU),
         VMSTATE_END_OF_LIST()
+    },
+    .subsections = (const VMStateDescription * []) {
+        &vmstate_pmsav8r,
+        NULL
     }
 };
 
-- 
2.25.1

From: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>

Add PMSAv8r translation.

Signed-off-by: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20221206102504.165775-7-tobias.roehmel@rwth-aachen.de
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/arm/ptw.c | 126 ++++++++++++++++++++++++++++++++++++++---------
 1 file changed, 104 insertions(+), 22 deletions(-)

diff --git a/target/arm/ptw.c b/target/arm/ptw.c
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/ptw.c
+++ b/target/arm/ptw.c
@@ -XXX,XX +XXX,XX @@ static bool pmsav7_use_background_region(ARMCPU *cpu, ARMMMUIdx mmu_idx,
 
     if (arm_feature(env, ARM_FEATURE_M)) {
         return env->v7m.mpu_ctrl[is_secure] & R_V7M_MPU_CTRL_PRIVDEFENA_MASK;
-    } else {
-        return regime_sctlr(env, mmu_idx) & SCTLR_BR;
     }
+
+    if (mmu_idx == ARMMMUIdx_Stage2) {
+        return false;
+    }
+
+    return regime_sctlr(env, mmu_idx) & SCTLR_BR;
 }
 
 static bool get_phys_addr_pmsav7(CPUARMState *env, uint32_t address,
@@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_pmsav7(CPUARMState *env, uint32_t address,
     return !(result->f.prot & (1 << access_type));
 }
 
+static uint32_t *regime_rbar(CPUARMState *env, ARMMMUIdx mmu_idx,
+                             uint32_t secure)
+{
+    if (regime_el(env, mmu_idx) == 2) {
+        return env->pmsav8.hprbar;
+    } else {
+        return env->pmsav8.rbar[secure];
+    }
+}
+
+static uint32_t *regime_rlar(CPUARMState *env, ARMMMUIdx mmu_idx,
+                             uint32_t secure)
+{
+    if (regime_el(env, mmu_idx) == 2) {
+        return env->pmsav8.hprlar;
+    } else {
+        return env->pmsav8.rlar[secure];
+    }
+}
+
 bool pmsav8_mpu_lookup(CPUARMState *env, uint32_t address,
                        MMUAccessType access_type, ARMMMUIdx mmu_idx,
                        bool secure, GetPhysAddrResult *result,
@@ -XXX,XX +XXX,XX @@ bool pmsav8_mpu_lookup(CPUARMState *env, uint32_t address,
     bool hit = false;
     uint32_t addr_page_base = address & TARGET_PAGE_MASK;
     uint32_t addr_page_limit = addr_page_base + (TARGET_PAGE_SIZE - 1);
+    int region_counter;
+
+    if (regime_el(env, mmu_idx) == 2) {
+        region_counter = cpu->pmsav8r_hdregion;
+    } else {
+        region_counter = cpu->pmsav7_dregion;
+    }
 
     result->f.lg_page_size = TARGET_PAGE_BITS;
     result->f.phys_addr = address;
@@ -XXX,XX +XXX,XX @@ bool pmsav8_mpu_lookup(CPUARMState *env, uint32_t address,
         *mregion = -1;
     }
 
+    if (mmu_idx == ARMMMUIdx_Stage2) {
+        fi->stage2 = true;
+    }
+
     /*
      * Unlike the ARM ARM pseudocode, we don't need to check whether this
      * was an exception vector read from the vector table (which is always
@@ -XXX,XX +XXX,XX @@ bool pmsav8_mpu_lookup(CPUARMState *env, uint32_t address,
             hit = true;
         }
 
-        for (n = (int)cpu->pmsav7_dregion - 1; n >= 0; n--) {
+        uint32_t bitmask;
+        if (arm_feature(env, ARM_FEATURE_M)) {
+            bitmask = 0x1f;
+        } else {
+            bitmask = 0x3f;
+            fi->level = 0;
+        }
+
+        for (n = region_counter - 1; n >= 0; n--) {
             /* region search */
             /*
-             * Note that the base address is bits [31:5] from the register
-             * with bits [4:0] all zeroes, but the limit address is bits
-             * [31:5] from the register with bits [4:0] all ones.
+             * Note that the base address is bits [31:x] from the register
+             * with bits [x-1:0] all zeroes, but the limit address is bits
+             * [31:x] from the register with bits [x:0] all ones. Where x is
+             * 5 for Cortex-M and 6 for Cortex-R
              */
-            uint32_t base = env->pmsav8.rbar[secure][n] & ~0x1f;
-            uint32_t limit = env->pmsav8.rlar[secure][n] | 0x1f;
+            uint32_t base = regime_rbar(env, mmu_idx, secure)[n] & ~bitmask;
+            uint32_t limit = regime_rlar(env, mmu_idx, secure)[n] | bitmask;
 
-            if (!(env->pmsav8.rlar[secure][n] & 0x1)) {
+            if (!(regime_rlar(env, mmu_idx, secure)[n] & 0x1)) {
                 /* Region disabled */
                 continue;
             }
@@ -XXX,XX +XXX,XX @@ bool pmsav8_mpu_lookup(CPUARMState *env, uint32_t address,
                  * PMSAv7 where highest-numbered-region wins)
                  */
                 fi->type = ARMFault_Permission;
-                fi->level = 1;
+                if (arm_feature(env, ARM_FEATURE_M)) {
+                    fi->level = 1;
+                }
                 return true;
             }
 
@@ -XXX,XX +XXX,XX @@ bool pmsav8_mpu_lookup(CPUARMState *env, uint32_t address,
     }
 
     if (!hit) {
-        /* background fault */
-        fi->type = ARMFault_Background;
+        if (arm_feature(env, ARM_FEATURE_M)) {
+            fi->type = ARMFault_Background;
+        } else {
+            fi->type = ARMFault_Permission;
+        }
         return true;
     }
 
@@ -XXX,XX +XXX,XX @@ bool pmsav8_mpu_lookup(CPUARMState *env, uint32_t address,
         /* hit using the background region */
         get_phys_addr_pmsav7_default(env, mmu_idx, address, &result->f.prot);
     } else {
-        uint32_t ap = extract32(env->pmsav8.rbar[secure][matchregion], 1, 2);
-        uint32_t xn = extract32(env->pmsav8.rbar[secure][matchregion], 0, 1);
+        uint32_t matched_rbar = regime_rbar(env, mmu_idx, secure)[matchregion];
+        uint32_t matched_rlar = regime_rlar(env, mmu_idx, secure)[matchregion];
+        uint32_t ap = extract32(matched_rbar, 1, 2);
+        uint32_t xn = extract32(matched_rbar, 0, 1);
         bool pxn = false;
 
         if (arm_feature(env, ARM_FEATURE_V8_1M)) {
-            pxn = extract32(env->pmsav8.rlar[secure][matchregion], 4, 1);
+            pxn = extract32(matched_rlar, 4, 1);
         }
 
         if (m_is_system_region(env, address)) {
@@ -XXX,XX +XXX,XX @@ bool pmsav8_mpu_lookup(CPUARMState *env, uint32_t address,
             xn = 1;
         }
 
-        result->f.prot = simple_ap_to_rw_prot(env, mmu_idx, ap);
+        if (regime_el(env, mmu_idx) == 2) {
+            result->f.prot = simple_ap_to_rw_prot_is_user(ap,
+                                            mmu_idx != ARMMMUIdx_E2);
+        } else {
+            result->f.prot = simple_ap_to_rw_prot(env, mmu_idx, ap);
+        }
+
+        if (!arm_feature(env, ARM_FEATURE_M)) {
+            uint8_t attrindx = extract32(matched_rlar, 1, 3);
+            uint64_t mair = env->cp15.mair_el[regime_el(env, mmu_idx)];
+            uint8_t sh = extract32(matched_rlar, 3, 2);
+
+            if (regime_sctlr(env, mmu_idx) & SCTLR_WXN &&
+                result->f.prot & PAGE_WRITE && mmu_idx != ARMMMUIdx_Stage2) {
+                xn = 0x1;
+            }
+
+            if ((regime_el(env, mmu_idx) == 1) &&
+                regime_sctlr(env, mmu_idx) & SCTLR_UWXN && ap == 0x1) {
+                pxn = 0x1;
+            }
+
+            result->cacheattrs.is_s2_format = false;
+            result->cacheattrs.attrs = extract64(mair, attrindx * 8, 8);
+            result->cacheattrs.shareability = sh;
+        }
+
         if (result->f.prot && !xn && !(pxn && !is_user)) {
             result->f.prot |= PAGE_EXEC;
         }
-        /*
-         * We don't need to look the attribute up in the MAIR0/MAIR1
-         * registers because that only tells us about cacheability.
-         */
+
         if (mregion) {
             *mregion = matchregion;
         }
     }
 
     fi->type = ARMFault_Permission;
-    fi->level = 1;
+    if (arm_feature(env, ARM_FEATURE_M)) {
+        fi->level = 1;
+    }
     return !(result->f.prot & (1 << access_type));
 }
 
@@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_twostage(CPUARMState *env, S1Translate *ptw,
     cacheattrs1 = result->cacheattrs;
     memset(result, 0, sizeof(*result));
 
-    ret = get_phys_addr_lpae(env, ptw, ipa, access_type, is_el0, result, fi);
+    if (arm_feature(env, ARM_FEATURE_PMSA)) {
+        ret = get_phys_addr_pmsav8(env, ipa, access_type,
+                                   ptw->in_mmu_idx, is_secure, result, fi);
+    } else {
+        ret = get_phys_addr_lpae(env, ptw, ipa, access_type,
+                                 is_el0, result, fi);
+    }
     fi->s2addr = ipa;
 
     /* Combine the S1 and S2 perms.  */
-- 
2.25.1

From: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>

All constants are taken from the ARM Cortex-R52 Processor TRM Revision: r1p3

Signed-off-by: Tobias Röhmel <tobias.roehmel@rwth-aachen.de>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 20221206102504.165775-8-tobias.roehmel@rwth-aachen.de
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/arm/cpu_tcg.c | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/target/arm/cpu_tcg.c b/target/arm/cpu_tcg.c
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/cpu_tcg.c
+++ b/target/arm/cpu_tcg.c
@@ -XXX,XX +XXX,XX @@ static void cortex_r5_initfn(Object *obj)
     define_arm_cp_regs(cpu, cortexr5_cp_reginfo);
 }
 
+static void cortex_r52_initfn(Object *obj)
+{
+    ARMCPU *cpu = ARM_CPU(obj);
+
+    set_feature(&cpu->env, ARM_FEATURE_V8);
+    set_feature(&cpu->env, ARM_FEATURE_EL2);
+    set_feature(&cpu->env, ARM_FEATURE_PMSA);
+    set_feature(&cpu->env, ARM_FEATURE_NEON);
+    set_feature(&cpu->env, ARM_FEATURE_GENERIC_TIMER);
+    cpu->midr = 0x411fd133; /* r1p3 */
+    cpu->revidr = 0x00000000;
+    cpu->reset_fpsid = 0x41034023;
+    cpu->isar.mvfr0 = 0x10110222;
+    cpu->isar.mvfr1 = 0x12111111;
+    cpu->isar.mvfr2 = 0x00000043;
+    cpu->ctr = 0x8144c004;
+    cpu->reset_sctlr = 0x30c50838;
+    cpu->isar.id_pfr0 = 0x00000131;
+    cpu->isar.id_pfr1 = 0x10111001;
+    cpu->isar.id_dfr0 = 0x03010006;
+    cpu->id_afr0 = 0x00000000;
+    cpu->isar.id_mmfr0 = 0x00211040;
+    cpu->isar.id_mmfr1 = 0x40000000;
+    cpu->isar.id_mmfr2 = 0x01200000;
+    cpu->isar.id_mmfr3 = 0xf0102211;
+    cpu->isar.id_mmfr4 = 0x00000010;
+    cpu->isar.id_isar0 = 0x02101110;
+    cpu->isar.id_isar1 = 0x13112111;
+    cpu->isar.id_isar2 = 0x21232142;
+    cpu->isar.id_isar3 = 0x01112131;
+    cpu->isar.id_isar4 = 0x00010142;
+    cpu->isar.id_isar5 = 0x00010001;
+    cpu->isar.dbgdidr = 0x77168000;
+    cpu->clidr = (1 << 27) | (1 << 24) | 0x3;
+    cpu->ccsidr[0] = 0x700fe01a; /* 32KB L1 dcache */
+    cpu->ccsidr[1] = 0x201fe00a; /* 32KB L1 icache */
+
+    cpu->pmsav7_dregion = 16;
+    cpu->pmsav8r_hdregion = 16;
+}
+
 static void cortex_r5f_initfn(Object *obj)
 {
     ARMCPU *cpu = ARM_CPU(obj);
@@ -XXX,XX +XXX,XX @@ static const ARMCPUInfo arm_tcg_cpus[] = {
                              .class_init = arm_v7m_class_init },
     { .name = "cortex-r5",   .initfn = cortex_r5_initfn },
     { .name = "cortex-r5f",  .initfn = cortex_r5f_initfn },
+    { .name = "cortex-r52",  .initfn = cortex_r52_initfn },
     { .name = "ti925t",      .initfn = ti925t_initfn },
     { .name = "sa1100",      .initfn = sa1100_initfn },
     { .name = "sa1110",      .initfn = sa1110_initfn },
-- 
2.25.1

From: Alex Bennée <alex.bennee@linaro.org>

The check semihosting_enabled() wants to know if the guest is
currently in user mode. Unlike the other cases the test was inverted
causing us to block semihosting calls in non-EL0 modes.

Cc: qemu-stable@nongnu.org
Fixes: 19b26317e9 (target/arm: Honour -semihosting-config userspace=on)
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/arm/translate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/arm/translate.c b/target/arm/translate.c
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/translate.c
+++ b/target/arm/translate.c
@@ -XXX,XX +XXX,XX @@ static inline void gen_hlt(DisasContext *s, int imm)
      * semihosting, to provide some semblance of security
      * (and for consistency with our 32-bit semihosting).
      */
-    if (semihosting_enabled(s->current_el != 0) &&
+    if (semihosting_enabled(s->current_el == 0) &&
         (imm == (s->thumb ? 0x3c : 0xf000))) {
         gen_exception_internal_insn(s, EXCP_SEMIHOST);
         return;
-- 
2.25.1

From: Axel Heider <axel.heider@hensoldt.net>

Fix typos, add background information

Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/timer/imx_epit.c | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/timer/imx_epit.c
+++ b/hw/timer/imx_epit.c
@@ -XXX,XX +XXX,XX @@ static void imx_epit_set_freq(IMXEPITState *s)
     }
 }
 
+/*
+ * This is called both on hardware (device) reset and software reset.
+ */
 static void imx_epit_reset(DeviceState *dev)
 {
     IMXEPITState *s = IMX_EPIT(dev);
 
-    /*
-     * Soft reset doesn't touch some bits; hard reset clears them
-     */
+    /* Soft reset doesn't touch some bits; hard reset clears them */
     s->cr &= (CR_EN|CR_ENMOD|CR_STOPEN|CR_DOZEN|CR_WAITEN|CR_DBGEN);
     s->sr = 0;
     s->lr = EPIT_TIMER_MAX;
@@ -XXX,XX +XXX,XX @@ static void imx_epit_write(void *opaque, hwaddr offset, uint64_t value,
         ptimer_transaction_begin(s->timer_cmp);
         ptimer_transaction_begin(s->timer_reload);
 
+        /* Update the frequency. Has been done already in case of a reset. */
         if (!(s->cr & CR_SWR)) {
             imx_epit_set_freq(s);
         }
@@ -XXX,XX +XXX,XX @@ static void imx_epit_write(void *opaque, hwaddr offset, uint64_t value,
         break;
 
     case 1: /* SR - ACK*/
-        /* writing 1 to OCIF clear the OCIF bit */
+        /* writing 1 to OCIF clears the OCIF bit */
         if (value & 0x01) {
             s->sr = 0;
             imx_epit_update_int(s);
@@ -XXX,XX +XXX,XX @@ static void imx_epit_realize(DeviceState *dev, Error **errp)
                           0x00001000);
     sysbus_init_mmio(sbd, &s->iomem);
 
+    /*
+     * The reload timer keeps running when the peripheral is enabled. It is a
+     * kind of wall clock that does not generate any interrupts. The callback
+     * needs to be provided, but it does nothing as the ptimer already supports
+     * all necessary reloading functionality.
+     */
     s->timer_reload = ptimer_init(imx_epit_reload, s, PTIMER_POLICY_LEGACY);
 
+    /*
+     * The compare timer is running only when the peripheral configuration is
+     * in a state that will generate compare interrupts.
+     */
     s->timer_cmp = ptimer_init(imx_epit_cmp, s, PTIMER_POLICY_LEGACY);
 }
 
-- 
2.25.1

From: Axel Heider <axel.heider@hensoldt.net>

remove unused defines, add needed defines

Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 include/hw/timer/imx_epit.h | 4 ++--
 hw/timer/imx_epit.c         | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/hw/timer/imx_epit.h b/include/hw/timer/imx_epit.h
index XXXXXXX..XXXXXXX 100644
--- a/include/hw/timer/imx_epit.h
+++ b/include/hw/timer/imx_epit.h
@@ -XXX,XX +XXX,XX @@
 #define CR_OCIEN    (1 << 2)
 #define CR_RLD      (1 << 3)
 #define CR_PRESCALE_SHIFT (4)
-#define CR_PRESCALE_MASK  (0xfff)
+#define CR_PRESCALE_BITS  (12)
 #define CR_SWR      (1 << 16)
 #define CR_IOVW     (1 << 17)
 #define CR_DBGEN    (1 << 18)
@@ -XXX,XX +XXX,XX @@
 #define CR_DOZEN    (1 << 20)
 #define CR_STOPEN   (1 << 21)
 #define CR_CLKSRC_SHIFT (24)
-#define CR_CLKSRC_MASK  (0x3 << CR_CLKSRC_SHIFT)
+#define CR_CLKSRC_BITS  (2)
 
 #define EPIT_TIMER_MAX  0XFFFFFFFFUL
 
diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/timer/imx_epit.c
+++ b/hw/timer/imx_epit.c
@@ -XXX,XX +XXX,XX @@ static void imx_epit_set_freq(IMXEPITState *s)
     uint32_t clksrc;
     uint32_t prescaler;
 
-    clksrc = extract32(s->cr, CR_CLKSRC_SHIFT, 2);
-    prescaler = 1 + extract32(s->cr, CR_PRESCALE_SHIFT, 12);
+    clksrc = extract32(s->cr, CR_CLKSRC_SHIFT, CR_CLKSRC_BITS);
+    prescaler = 1 + extract32(s->cr, CR_PRESCALE_SHIFT, CR_PRESCALE_BITS);
 
     s->freq = imx_ccm_get_clock_frequency(s->ccm,
                                 imx_epit_clocks[clksrc]) / prescaler;
-- 
2.25.1

From: Axel Heider <axel.heider@hensoldt.net>

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 include/hw/timer/imx_epit.h |  2 ++
 hw/timer/imx_epit.c         | 12 ++++++------
 2 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/include/hw/timer/imx_epit.h b/include/hw/timer/imx_epit.h
index XXXXXXX..XXXXXXX 100644
--- a/include/hw/timer/imx_epit.h
+++ b/include/hw/timer/imx_epit.h
@@ -XXX,XX +XXX,XX @@
 #define CR_CLKSRC_SHIFT (24)
 #define CR_CLKSRC_BITS  (2)
 
+#define SR_OCIF     (1 << 0)
+
 #define EPIT_TIMER_MAX  0XFFFFFFFFUL
 
 #define TYPE_IMX_EPIT "imx.epit"
diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/timer/imx_epit.c
+++ b/hw/timer/imx_epit.c
@@ -XXX,XX +XXX,XX @@ static const IMXClk imx_epit_clocks[] =  {
  */
 static void imx_epit_update_int(IMXEPITState *s)
 {
-    if (s->sr && (s->cr & CR_OCIEN) && (s->cr & CR_EN)) {
+    if ((s->sr & SR_OCIF) && (s->cr & CR_OCIEN) && (s->cr & CR_EN)) {
         qemu_irq_raise(s->irq);
     } else {
         qemu_irq_lower(s->irq);
@@ -XXX,XX +XXX,XX @@ static void imx_epit_write(void *opaque, hwaddr offset, uint64_t value,
         break;
 
     case 1: /* SR - ACK*/
-        /* writing 1 to OCIF clears the OCIF bit */
-        if (value & 0x01) {
-            s->sr = 0;
+        /* writing 1 to SR.OCIF clears this bit and turns the interrupt off */
+        if (value & SR_OCIF) {
+            s->sr = 0; /* SR.OCIF is the only bit in this register anyway */
             imx_epit_update_int(s);
         }
         break;
@@ -XXX,XX +XXX,XX @@ static void imx_epit_cmp(void *opaque)
     IMXEPITState *s = IMX_EPIT(opaque);
 
     DPRINTF("sr was %d\n", s->sr);
-
-    s->sr = 1;
+    /* Set interrupt status bit SR.OCIF and update the interrupt state */
+    s->sr |= SR_OCIF;
     imx_epit_update_int(s);
 }
 
-- 
2.25.1

From: Axel Heider <axel.heider@hensoldt.net>

The interrupt state can change due to:
- reset clears both SR.OCIF and CR.OCIE
- write to CR.EN or CR.OCIE

Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/timer/imx_epit.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/timer/imx_epit.c
+++ b/hw/timer/imx_epit.c
@@ -XXX,XX +XXX,XX @@ static void imx_epit_write(void *opaque, hwaddr offset, uint64_t value,
         if (s->cr & CR_SWR) {
             /* handle the reset */
             imx_epit_reset(DEVICE(s));
-            /*
-             * TODO: could we 'break' here? following operations appear
-             * to duplicate the work imx_epit_reset() already did.
-             */
         }
 
+        /*
+         * The interrupt state can change due to:
+         * - reset clears both SR.OCIF and CR.OCIE
+         * - write to CR.EN or CR.OCIE
+         */
+        imx_epit_update_int(s);
+
+        /*
+         * TODO: could we 'break' here for reset? following operations appear
+         * to duplicate the work imx_epit_reset() already did.
+         */
+
         ptimer_transaction_begin(s->timer_cmp);
         ptimer_transaction_begin(s->timer_reload);
 
-- 
2.25.1

From: Axel Heider <axel.heider@hensoldt.net>

Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/timer/imx_epit.c | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/timer/imx_epit.c
+++ b/hw/timer/imx_epit.c
@@ -XXX,XX +XXX,XX @@ static void imx_epit_set_freq(IMXEPITState *s)
 /*
  * This is called both on hardware (device) reset and software reset.
  */
-static void imx_epit_reset(DeviceState *dev)
+static void imx_epit_reset(IMXEPITState *s, bool is_hard_reset)
 {
-    IMXEPITState *s = IMX_EPIT(dev);
-
     /* Soft reset doesn't touch some bits; hard reset clears them */
-    s->cr &= (CR_EN|CR_ENMOD|CR_STOPEN|CR_DOZEN|CR_WAITEN|CR_DBGEN);
+    if (is_hard_reset) {
+        s->cr = 0;
+    } else {
+        s->cr &= (CR_EN|CR_ENMOD|CR_STOPEN|CR_DOZEN|CR_WAITEN|CR_DBGEN);
+    }
     s->sr = 0;
     s->lr = EPIT_TIMER_MAX;
     s->cmp = 0;
@@ -XXX,XX +XXX,XX @@ static void imx_epit_write(void *opaque, hwaddr offset, uint64_t value,
         s->cr = value & 0x03ffffff;
         if (s->cr & CR_SWR) {
             /* handle the reset */
-            imx_epit_reset(DEVICE(s));
+            imx_epit_reset(s, false);
         }
 
         /*
@@ -XXX,XX +XXX,XX @@ static void imx_epit_realize(DeviceState *dev, Error **errp)
     s->timer_cmp = ptimer_init(imx_epit_cmp, s, PTIMER_POLICY_LEGACY);
 }
 
+static void imx_epit_dev_reset(DeviceState *dev)
+{
+    IMXEPITState *s = IMX_EPIT(dev);
+    imx_epit_reset(s, true);
+}
+
 static void imx_epit_class_init(ObjectClass *klass, void *data)
 {
     DeviceClass *dc  = DEVICE_CLASS(klass);
 
     dc->realize = imx_epit_realize;
-    dc->reset = imx_epit_reset;
+    dc->reset = imx_epit_dev_reset;
     dc->vmsd = &vmstate_imx_timer_epit;
     dc->desc = "i.MX periodic timer";
 }
-- 
2.25.1

From: Axel Heider <axel.heider@hensoldt.net>

Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/timer/imx_epit.c | 215 ++++++++++++++++++++++++--------------------
 1 file changed, 117 insertions(+), 98 deletions(-)

diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/timer/imx_epit.c
+++ b/hw/timer/imx_epit.c
@@ -XXX,XX +XXX,XX @@ static void imx_epit_reload_compare_timer(IMXEPITState *s)
     }
 }
 
+static void imx_epit_write_cr(IMXEPITState *s, uint32_t value)
+{
+    uint32_t oldcr = s->cr;
+
+    s->cr = value & 0x03ffffff;
+
+    if (s->cr & CR_SWR) {
+        /* handle the reset */
+        imx_epit_reset(s, false);
+    }
+
+    /*
+     * The interrupt state can change due to:
+     * - reset clears both SR.OCIF and CR.OCIE
+     * - write to CR.EN or CR.OCIE
+     */
+    imx_epit_update_int(s);
+
+    /*
+     * TODO: could we 'break' here for reset? following operations appear
+     * to duplicate the work imx_epit_reset() already did.
+     */
+
+    ptimer_transaction_begin(s->timer_cmp);
+    ptimer_transaction_begin(s->timer_reload);
+
+    /* Update the frequency. Has been done already in case of a reset. */
+    if (!(s->cr & CR_SWR)) {
+        imx_epit_set_freq(s);
+    }
+
+    if (s->freq && (s->cr & CR_EN) && !(oldcr & CR_EN)) {
+        if (s->cr & CR_ENMOD) {
+            if (s->cr & CR_RLD) {
+                ptimer_set_limit(s->timer_reload, s->lr, 1);
+                ptimer_set_limit(s->timer_cmp, s->lr, 1);
+            } else {
+                ptimer_set_limit(s->timer_reload, EPIT_TIMER_MAX, 1);
+                ptimer_set_limit(s->timer_cmp, EPIT_TIMER_MAX, 1);
+            }
+        }
+
+        imx_epit_reload_compare_timer(s);
+        ptimer_run(s->timer_reload, 0);
+        if (s->cr & CR_OCIEN) {
+            ptimer_run(s->timer_cmp, 0);
+        } else {
+            ptimer_stop(s->timer_cmp);
+        }
+    } else if (!(s->cr & CR_EN)) {
+        /* stop both timers */
+        ptimer_stop(s->timer_reload);
+        ptimer_stop(s->timer_cmp);
+    } else  if (s->cr & CR_OCIEN) {
+        if (!(oldcr & CR_OCIEN)) {
+            imx_epit_reload_compare_timer(s);
+            ptimer_run(s->timer_cmp, 0);
+        }
+    } else {
+        ptimer_stop(s->timer_cmp);
+    }
+
+    ptimer_transaction_commit(s->timer_cmp);
+    ptimer_transaction_commit(s->timer_reload);
+}
+
+static void imx_epit_write_sr(IMXEPITState *s, uint32_t value)
+{
+    /* writing 1 to SR.OCIF clears this bit and turns the interrupt off */
+    if (value & SR_OCIF) {
+        s->sr = 0; /* SR.OCIF is the only bit in this register anyway */
+        imx_epit_update_int(s);
+    }
+}
+
+static void imx_epit_write_lr(IMXEPITState *s, uint32_t value)
+{
+    s->lr = value;
+
+    ptimer_transaction_begin(s->timer_cmp);
+    ptimer_transaction_begin(s->timer_reload);
+    if (s->cr & CR_RLD) {
+        /* Also set the limit if the LRD bit is set */
+        /* If IOVW bit is set then set the timer value */
+        ptimer_set_limit(s->timer_reload, s->lr, s->cr & CR_IOVW);
+        ptimer_set_limit(s->timer_cmp, s->lr, 0);
+    } else if (s->cr & CR_IOVW) {
+        /* If IOVW bit is set then set the timer value */
+        ptimer_set_count(s->timer_reload, s->lr);
+    }
+    /*
+     * Commit the change to s->timer_reload, so it can propagate. Otherwise
+     * the timer interrupt may not fire properly. The commit must happen
+     * before calling imx_epit_reload_compare_timer(), which reads
+     * s->timer_reload internally again.
+     */
+    ptimer_transaction_commit(s->timer_reload);
+    imx_epit_reload_compare_timer(s);
+    ptimer_transaction_commit(s->timer_cmp);
+}
+
+static void imx_epit_write_cmp(IMXEPITState *s, uint32_t value)
+{
+    s->cmp = value;
+
+    ptimer_transaction_begin(s->timer_cmp);
+    imx_epit_reload_compare_timer(s);
+    ptimer_transaction_commit(s->timer_cmp);
+}
+
 static void imx_epit_write(void *opaque, hwaddr offset, uint64_t value,
                            unsigned size)
 {
     IMXEPITState *s = IMX_EPIT(opaque);
-    uint64_t oldcr;
 
     DPRINTF("(%s, value = 0x%08x)\n", imx_epit_reg_name(offset >> 2),
             (uint32_t)value);
 
     switch (offset >> 2) {
     case 0: /* CR */
-
-        oldcr = s->cr;
-        s->cr = value & 0x03ffffff;
-        if (s->cr & CR_SWR) {
-            /* handle the reset */
-            imx_epit_reset(s, false);
-        }
-
-        /*
-         * The interrupt state can change due to:
-         * - reset clears both SR.OCIF and CR.OCIE
-         * - write to CR.EN or CR.OCIE
-         */
-        imx_epit_update_int(s);
-
-        /*
-         * TODO: could we 'break' here for reset? following operations appear
-         * to duplicate the work imx_epit_reset() already did.
-         */
-
-        ptimer_transaction_begin(s->timer_cmp);
-        ptimer_transaction_begin(s->timer_reload);
-
-        /* Update the frequency. Has been done already in case of a reset. */
-        if (!(s->cr & CR_SWR)) {
-            imx_epit_set_freq(s);
-        }
-
-        if (s->freq && (s->cr & CR_EN) && !(oldcr & CR_EN)) {
-            if (s->cr & CR_ENMOD) {
-                if (s->cr & CR_RLD) {
-                    ptimer_set_limit(s->timer_reload, s->lr, 1);
-                    ptimer_set_limit(s->timer_cmp, s->lr, 1);
-                } else {
-                    ptimer_set_limit(s->timer_reload, EPIT_TIMER_MAX, 1);
-                    ptimer_set_limit(s->timer_cmp, EPIT_TIMER_MAX, 1);
-                }
-            }
-
-            imx_epit_reload_compare_timer(s);
-            ptimer_run(s->timer_reload, 0);
-            if (s->cr & CR_OCIEN) {
-                ptimer_run(s->timer_cmp, 0);
-            } else {
-                ptimer_stop(s->timer_cmp);
-            }
-        } else if (!(s->cr & CR_EN)) {
-            /* stop both timers */
-            ptimer_stop(s->timer_reload);
-            ptimer_stop(s->timer_cmp);
-        } else  if (s->cr & CR_OCIEN) {
-            if (!(oldcr & CR_OCIEN)) {
-                imx_epit_reload_compare_timer(s);
-                ptimer_run(s->timer_cmp, 0);
-            }
-        } else {
-            ptimer_stop(s->timer_cmp);
-        }
-
-        ptimer_transaction_commit(s->timer_cmp);
-        ptimer_transaction_commit(s->timer_reload);
+        imx_epit_write_cr(s, (uint32_t)value);
         break;
 
-    case 1: /* SR - ACK*/
-        /* writing 1 to SR.OCIF clears this bit and turns the interrupt off */
-        if (value & SR_OCIF) {
-            s->sr = 0; /* SR.OCIF is the only bit in this register anyway */
-            imx_epit_update_int(s);
-        }
+    case 1: /* SR */
+        imx_epit_write_sr(s, (uint32_t)value);
         break;
 
-    case 2: /* LR - set ticks */
-        s->lr = value;
-
-        ptimer_transaction_begin(s->timer_cmp);
-        ptimer_transaction_begin(s->timer_reload);
-        if (s->cr & CR_RLD) {
-            /* Also set the limit if the LRD bit is set */
-            /* If IOVW bit is set then set the timer value */
-            ptimer_set_limit(s->timer_reload, s->lr, s->cr & CR_IOVW);
-            ptimer_set_limit(s->timer_cmp, s->lr, 0);
-        } else if (s->cr & CR_IOVW) {
-            /* If IOVW bit is set then set the timer value */
-            ptimer_set_count(s->timer_reload, s->lr);
-        }
-        /*
-         * Commit the change to s->timer_reload, so it can propagate. Otherwise
-         * the timer interrupt may not fire properly. The commit must happen
-         * before calling imx_epit_reload_compare_timer(), which reads
-         * s->timer_reload internally again.
-         */
-        ptimer_transaction_commit(s->timer_reload);
-        imx_epit_reload_compare_timer(s);
-        ptimer_transaction_commit(s->timer_cmp);
+    case 2: /* LR */
+        imx_epit_write_lr(s, (uint32_t)value);
         break;
 
     case 3: /* CMP */
-        s->cmp = value;
-
-        ptimer_transaction_begin(s->timer_cmp);
-        imx_epit_reload_compare_timer(s);
-        ptimer_transaction_commit(s->timer_cmp);
-
+        imx_epit_write_cmp(s, (uint32_t)value);
         break;
 
     default:
         qemu_log_mask(LOG_GUEST_ERROR, "[%s]%s: Bad register at offset 0x%"
                       HWADDR_PRIx "\n", TYPE_IMX_EPIT, __func__, offset);
-
         break;
     }
 }
+
 static void imx_epit_cmp(void *opaque)
 {
     IMXEPITState *s = IMX_EPIT(opaque);
-- 
2.25.1

From: Axel Heider <axel.heider@hensoldt.net>

The CNT register is a read-only register. There is no need to
store it's value, it can be calculated on demand.
The calculated frequency is needed temporarily only.

Note that this is a migration compatibility break for all boards
types that use the EPIT peripheral.

Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 include/hw/timer/imx_epit.h |  2 -
 hw/timer/imx_epit.c         | 73 ++++++++++++++-----------------------
 2 files changed, 28 insertions(+), 47 deletions(-)

diff --git a/include/hw/timer/imx_epit.h b/include/hw/timer/imx_epit.h
index XXXXXXX..XXXXXXX 100644
--- a/include/hw/timer/imx_epit.h
+++ b/include/hw/timer/imx_epit.h
@@ -XXX,XX +XXX,XX @@ struct IMXEPITState {
     uint32_t sr;
     uint32_t lr;
     uint32_t cmp;
-    uint32_t cnt;
 
-    uint32_t freq;
     qemu_irq irq;
 };
 
diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/timer/imx_epit.c
+++ b/hw/timer/imx_epit.c
@@ -XXX,XX +XXX,XX @@ static void imx_epit_update_int(IMXEPITState *s)
     }
 }
 
-/*
- * Must be called from within a ptimer_transaction_begin/commit block
- * for both s->timer_cmp and s->timer_reload.
- */
-static void imx_epit_set_freq(IMXEPITState *s)
+static uint32_t imx_epit_get_freq(IMXEPITState *s)
 {
-    uint32_t clksrc;
-    uint32_t prescaler;
-
-    clksrc = extract32(s->cr, CR_CLKSRC_SHIFT, CR_CLKSRC_BITS);
-    prescaler = 1 + extract32(s->cr, CR_PRESCALE_SHIFT, CR_PRESCALE_BITS);
-
-    s->freq = imx_ccm_get_clock_frequency(s->ccm,
-                                imx_epit_clocks[clksrc]) / prescaler;
-
-    DPRINTF("Setting ptimer frequency to %u\n", s->freq);
-
-    if (s->freq) {
-        ptimer_set_freq(s->timer_reload, s->freq);
-        ptimer_set_freq(s->timer_cmp, s->freq);
-    }
+    uint32_t clksrc = extract32(s->cr, CR_CLKSRC_SHIFT, CR_CLKSRC_BITS);
+    uint32_t prescaler = 1 + extract32(s->cr, CR_PRESCALE_SHIFT, CR_PRESCALE_BITS);
+    uint32_t f_in = imx_ccm_get_clock_frequency(s->ccm, imx_epit_clocks[clksrc]);
+    uint32_t freq = f_in / prescaler;
+    DPRINTF("ptimer frequency is %u\n", freq);
+    return freq;
 }
 
 /*
@@ -XXX,XX +XXX,XX @@ static void imx_epit_reset(IMXEPITState *s, bool is_hard_reset)
     s->sr = 0;
     s->lr = EPIT_TIMER_MAX;
     s->cmp = 0;
-    s->cnt = 0;
     ptimer_transaction_begin(s->timer_cmp);
     ptimer_transaction_begin(s->timer_reload);
-    /* stop both timers */
+
+    /*
+     * The reset switches off the input clock, so even if the CR.EN is still
+     * set, the timers are no longer running.
+     */
+    assert(imx_epit_get_freq(s) == 0);
     ptimer_stop(s->timer_cmp);
     ptimer_stop(s->timer_reload);
-    /* compute new frequency */
-    imx_epit_set_freq(s);
     /* init both timers to EPIT_TIMER_MAX */
     ptimer_set_limit(s->timer_cmp, EPIT_TIMER_MAX, 1);
     ptimer_set_limit(s->timer_reload, EPIT_TIMER_MAX, 1);
-    if (s->freq && (s->cr & CR_EN)) {
-        /* if the timer is still enabled, restart it */
-        ptimer_run(s->timer_reload, 0);
-    }
     ptimer_transaction_commit(s->timer_cmp);
     ptimer_transaction_commit(s->timer_reload);
 }
 
-static uint32_t imx_epit_update_count(IMXEPITState *s)
-{
-    s->cnt = ptimer_get_count(s->timer_reload);
-
-    return s->cnt;
-}
-
 static uint64_t imx_epit_read(void *opaque, hwaddr offset, unsigned size)
 {
     IMXEPITState *s = IMX_EPIT(opaque);
@@ -XXX,XX +XXX,XX @@ static uint64_t imx_epit_read(void *opaque, hwaddr offset, unsigned size)
         break;
 
     case 4: /* CNT */
-        imx_epit_update_count(s);
-        reg_value = s->cnt;
+        reg_value = ptimer_get_count(s->timer_reload);
         break;
 
     default:
@@ -XXX,XX +XXX,XX @@ static void imx_epit_reload_compare_timer(IMXEPITState *s)
 {
     if ((s->cr & (CR_EN | CR_OCIEN)) == (CR_EN | CR_OCIEN))  {
         /* if the compare feature is on and timers are running */
-        uint32_t tmp = imx_epit_update_count(s);
+        uint32_t tmp = ptimer_get_count(s->timer_reload);
         uint64_t next;
         if (tmp > s->cmp) {
             /* It'll fire in this round of the timer */
@@ -XXX,XX +XXX,XX @@ static void imx_epit_reload_compare_timer(IMXEPITState *s)
 
 static void imx_epit_write_cr(IMXEPITState *s, uint32_t value)
 {
+    uint32_t freq = 0;
     uint32_t oldcr = s->cr;
 
     s->cr = value & 0x03ffffff;
@@ -XXX,XX +XXX,XX @@ static void imx_epit_write_cr(IMXEPITState *s, uint32_t value)
     ptimer_transaction_begin(s->timer_cmp);
     ptimer_transaction_begin(s->timer_reload);
 
-    /* Update the frequency. Has been done already in case of a reset. */
+    /*
+     * Update the frequency. In case of a reset the input clock was
+     * switched off, so this can be skipped.
+     */
     if (!(s->cr & CR_SWR)) {
-        imx_epit_set_freq(s);
+        freq = imx_epit_get_freq(s);
+        if (freq) {
+            ptimer_set_freq(s->timer_reload, freq);
+            ptimer_set_freq(s->timer_cmp, freq);
+        }
     }
 
-    if (s->freq && (s->cr & CR_EN) && !(oldcr & CR_EN)) {
+    if (freq && (s->cr & CR_EN) && !(oldcr & CR_EN)) {
         if (s->cr & CR_ENMOD) {
             if (s->cr & CR_RLD) {
                 ptimer_set_limit(s->timer_reload, s->lr, 1);
@@ -XXX,XX +XXX,XX @@ static const MemoryRegionOps imx_epit_ops = {
 
 static const VMStateDescription vmstate_imx_timer_epit = {
     .name = TYPE_IMX_EPIT,
-    .version_id = 2,
-    .minimum_version_id = 2,
+    .version_id = 3,
+    .minimum_version_id = 3,
     .fields = (VMStateField[]) {
         VMSTATE_UINT32(cr, IMXEPITState),
         VMSTATE_UINT32(sr, IMXEPITState),
         VMSTATE_UINT32(lr, IMXEPITState),
         VMSTATE_UINT32(cmp, IMXEPITState),
-        VMSTATE_UINT32(cnt, IMXEPITState),
-        VMSTATE_UINT32(freq, IMXEPITState),
         VMSTATE_PTIMER(timer_reload, IMXEPITState),
         VMSTATE_PTIMER(timer_cmp, IMXEPITState),
         VMSTATE_END_OF_LIST()
-- 
2.25.1

From: Axel Heider <axel.heider@hensoldt.net>

- fix #1263 for CR writes
- rework compare time handling
  - The compare timer has to run even if CR.OCIEN is not set,
    as SR.OCIF must be updated.
  - The compare timer fires exactly once when the
    compare value is less than the current value, but the
    reload values is less than the compare value.
  - The compare timer will never fire if the reload value is
    less than the compare value. Disable it in this case.

Signed-off-by: Axel Heider <axel.heider@hensoldt.net>
[PMM: fixed minor style nits]
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/timer/imx_epit.c | 192 ++++++++++++++++++++++++++------------------
 1 file changed, 116 insertions(+), 76 deletions(-)

diff --git a/hw/timer/imx_epit.c b/hw/timer/imx_epit.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/timer/imx_epit.c
+++ b/hw/timer/imx_epit.c
@@ -XXX,XX +XXX,XX @@
  * Originally written by Hans Jiang
  * Updated by Peter Chubb
  * Updated by Jean-Christophe Dubois <jcd@tribudubois.net>
+ * Updated by Axel Heider
  *
  * This code is licensed under GPL version 2 or later.  See
  * the COPYING file in the top-level directory.
@@ -XXX,XX +XXX,XX @@ static uint64_t imx_epit_read(void *opaque, hwaddr offset, unsigned size)
     return reg_value;
 }
 
-/* Must be called from ptimer_transaction_begin/commit block for s->timer_cmp */
-static void imx_epit_reload_compare_timer(IMXEPITState *s)
+/*
+ * Must be called from a ptimer_transaction_begin/commit block for
+ * s->timer_cmp, but outside of a transaction block of s->timer_reload,
+ * so the proper counter value is read.
+ */
+static void imx_epit_update_compare_timer(IMXEPITState *s)
 {
-    if ((s->cr & (CR_EN | CR_OCIEN)) == (CR_EN | CR_OCIEN))  {
-        /* if the compare feature is on and timers are running */
-        uint32_t tmp = ptimer_get_count(s->timer_reload);
-        uint64_t next;
-        if (tmp > s->cmp) {
-            /* It'll fire in this round of the timer */
-            next = tmp - s->cmp;
-        } else { /* catch it next time around */
-            next = tmp - s->cmp + ((s->cr & CR_RLD) ? EPIT_TIMER_MAX : s->lr);
+    uint64_t counter = 0;
+    bool is_oneshot = false;
+    /*
+     * The compare timer only has to run if the timer peripheral is active
+     * and there is an input clock, Otherwise it can be switched off.
+     */
+    bool is_active = (s->cr & CR_EN) && imx_epit_get_freq(s);
+    if (is_active) {
+        /*
+         * Calculate next timeout for compare timer. Reading the reload
+         * counter returns proper results only if pending transactions
+         * on it are committed here. Otherwise stale values are be read.
+         */
+        counter = ptimer_get_count(s->timer_reload);
+        uint64_t limit = ptimer_get_limit(s->timer_cmp);
+        /*
+         * The compare timer is a periodic timer if the limit is at least
+         * the compare value. Otherwise it may fire at most once in the
+         * current round.
+         */
+        bool is_oneshot = (limit >= s->cmp);
+        if (counter >= s->cmp) {
+            /* The compare timer fires in the current round. */
+            counter -= s->cmp;
+        } else if (!is_oneshot) {
+            /*
+             * The compare timer fires after a reload, as it is below the
+             * compare value already in this round. Note that the counter
+             * value calculated below can be above the 32-bit limit, which
+             * is legal here because the compare timer is an internal
+             * helper ptimer only.
+             */
+            counter += limit - s->cmp;
+        } else {
+            /*
+             * The compare timer won't fire in this round, and the limit is
+             * set to a value below the compare value. This practically means
+             * it will never fire, so it can be switched off.
+             */
+            is_active = false;
         }
-        ptimer_set_count(s->timer_cmp, next);
     }
+
+    /*
+     * Set the compare timer and let it run, or stop it. This is agnostic
+     * of CR.OCIEN bit, as this bit affects interrupt generation only. The
+     * compare timer needs to run even if no interrupts are to be generated,
+     * because the SR.OCIF bit must be updated also.
+     * Note that the timer might already be stopped or be running with
+     * counter values. However, finding out when an update is needed and
+     * when not is not trivial. It's much easier applying the setting again,
+     * as this does not harm either and the overhead is negligible.
+     */
+    if (is_active) {
+        ptimer_set_count(s->timer_cmp, counter);
+        ptimer_run(s->timer_cmp, is_oneshot ? 1 : 0);
+    } else {
+        ptimer_stop(s->timer_cmp);
+    }
+
 }
 
 static void imx_epit_write_cr(IMXEPITState *s, uint32_t value)
 {
-    uint32_t freq = 0;
     uint32_t oldcr = s->cr;
 
     s->cr = value & 0x03ffffff;
 
     if (s->cr & CR_SWR) {
-        /* handle the reset */
+        /*
+         * Reset clears CR.SWR again. It does not touch CR.EN, but the timers
+         * are still stopped because the input clock is disabled.
+         */
         imx_epit_reset(s, false);
+    } else {
+        uint32_t freq;
+        uint32_t toggled_cr_bits = oldcr ^ s->cr;
+        /* re-initialize the limits if CR.RLD has changed */
+        bool set_limit = toggled_cr_bits & CR_RLD;
+        /* set the counter if the timer got just enabled and CR.ENMOD is set */
+        bool is_switched_on = (toggled_cr_bits & s->cr) & CR_EN;
+        bool set_counter = is_switched_on && (s->cr & CR_ENMOD);
+
+        ptimer_transaction_begin(s->timer_cmp);
+        ptimer_transaction_begin(s->timer_reload);
+        freq = imx_epit_get_freq(s);
+        if (freq) {
+            ptimer_set_freq(s->timer_reload, freq);
+            ptimer_set_freq(s->timer_cmp, freq);
+        }
+
+        if (set_limit || set_counter) {
+            uint64_t limit = (s->cr & CR_RLD) ? s->lr : EPIT_TIMER_MAX;
+            ptimer_set_limit(s->timer_reload, limit, set_counter ? 1 : 0);
+            if (set_limit) {
+                ptimer_set_limit(s->timer_cmp, limit, 0);
+            }
+        }
+        /*
+         * If there is an input clock and the peripheral is enabled, then
+         * ensure the wall clock timer is ticking. Otherwise stop the timers.
+         * The compare timer will be updated later.
+         */
+        if (freq && (s->cr & CR_EN)) {
+            ptimer_run(s->timer_reload, 0);
+        } else {
+            ptimer_stop(s->timer_reload);
+        }
+        /* Commit changes to reload timer, so they can propagate. */
+        ptimer_transaction_commit(s->timer_reload);
+        /* Update compare timer based on the committed reload timer value. */
+        imx_epit_update_compare_timer(s);
+        ptimer_transaction_commit(s->timer_cmp);
     }
 
     /*
@@ -XXX,XX +XXX,XX @@ static void imx_epit_write_cr(IMXEPITState *s, uint32_t value)
      * - write to CR.EN or CR.OCIE
      */
     imx_epit_update_int(s);
-
-    /*
-     * TODO: could we 'break' here for reset? following operations appear
-     * to duplicate the work imx_epit_reset() already did.
-     */
-
-    ptimer_transaction_begin(s->timer_cmp);
-    ptimer_transaction_begin(s->timer_reload);
-
-    /*
-     * Update the frequency. In case of a reset the input clock was
-     * switched off, so this can be skipped.
-     */
-    if (!(s->cr & CR_SWR)) {
-        freq = imx_epit_get_freq(s);
-        if (freq) {
-            ptimer_set_freq(s->timer_reload, freq);
-            ptimer_set_freq(s->timer_cmp, freq);
-        }
-    }
-
-    if (freq && (s->cr & CR_EN) && !(oldcr & CR_EN)) {
-        if (s->cr & CR_ENMOD) {
-            if (s->cr & CR_RLD) {
-                ptimer_set_limit(s->timer_reload, s->lr, 1);
-                ptimer_set_limit(s->timer_cmp, s->lr, 1);
-            } else {
-                ptimer_set_limit(s->timer_reload, EPIT_TIMER_MAX, 1);
-                ptimer_set_limit(s->timer_cmp, EPIT_TIMER_MAX, 1);
-            }
-        }
-
-        imx_epit_reload_compare_timer(s);
-        ptimer_run(s->timer_reload, 0);
-        if (s->cr & CR_OCIEN) {
-            ptimer_run(s->timer_cmp, 0);
-        } else {
-            ptimer_stop(s->timer_cmp);
-        }
-    } else if (!(s->cr & CR_EN)) {
-        /* stop both timers */
-        ptimer_stop(s->timer_reload);
-        ptimer_stop(s->timer_cmp);
-    } else  if (s->cr & CR_OCIEN) {
-        if (!(oldcr & CR_OCIEN)) {
-            imx_epit_reload_compare_timer(s);
-            ptimer_run(s->timer_cmp, 0);
-        }
-    } else {
-        ptimer_stop(s->timer_cmp);
-    }
-
-    ptimer_transaction_commit(s->timer_cmp);
-    ptimer_transaction_commit(s->timer_reload);
 }
 
 static void imx_epit_write_sr(IMXEPITState *s, uint32_t value)
@@ -XXX,XX +XXX,XX @@ static void imx_epit_write_lr(IMXEPITState *s, uint32_t value)
         /* If IOVW bit is set then set the timer value */
         ptimer_set_count(s->timer_reload, s->lr);
     }
-    /*
-     * Commit the change to s->timer_reload, so it can propagate. Otherwise
-     * the timer interrupt may not fire properly. The commit must happen
-     * before calling imx_epit_reload_compare_timer(), which reads
-     * s->timer_reload internally again.
-     */
+    /* Commit the changes to s->timer_reload, so they can propagate. */
     ptimer_transaction_commit(s->timer_reload);
-    imx_epit_reload_compare_timer(s);
+    /* Update the compare timer based on the committed reload timer value. */
+    imx_epit_update_compare_timer(s);
     ptimer_transaction_commit(s->timer_cmp);
 }
 
@@ -XXX,XX +XXX,XX @@ static void imx_epit_write_cmp(IMXEPITState *s, uint32_t value)
 {
     s->cmp = value;
 
+    /* Update the compare timer based on the committed reload timer value. */
     ptimer_transaction_begin(s->timer_cmp);
-    imx_epit_reload_compare_timer(s);
+    imx_epit_update_compare_timer(s);
     ptimer_transaction_commit(s->timer_cmp);
 }
 
@@ -XXX,XX +XXX,XX @@ static void imx_epit_cmp(void *opaque)
 {
     IMXEPITState *s = IMX_EPIT(opaque);
 
+    /* The cmp ptimer can't be running when the peripheral is disabled */
+    assert(s->cr & CR_EN);
+
     DPRINTF("sr was %d\n", s->sr);
     /* Set interrupt status bit SR.OCIF and update the interrupt state */
     s->sr |= SR_OCIF;
-- 
2.25.1

From: Fabiano Rosas <farosas@suse.de>

Fix these:

WARNING: Block comments use a leading /* on a separate line
WARNING: Block comments use * on subsequent lines
WARNING: Block comments use a trailing */ on a separate line

Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Claudio Fontana <cfontana@suse.de>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Message-id: 20221213190537.511-2-farosas@suse.de
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/arm/helper.c | 323 +++++++++++++++++++++++++++++---------------
 1 file changed, 215 insertions(+), 108 deletions(-)

diff --git a/target/arm/helper.c b/target/arm/helper.c
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -XXX,XX +XXX,XX @@ uint64_t read_raw_cp_reg(CPUARMState *env, const ARMCPRegInfo *ri)
 static void write_raw_cp_reg(CPUARMState *env, const ARMCPRegInfo *ri,
                              uint64_t v)
 {
-    /* Raw write of a coprocessor register (as needed for migration, etc).
+    /*
+     * Raw write of a coprocessor register (as needed for migration, etc).
      * Note that constant registers are treated as write-ignored; the
      * caller should check for success by whether a readback gives the
      * value written.
@@ -XXX,XX +XXX,XX @@ static void write_raw_cp_reg(CPUARMState *env, const ARMCPRegInfo *ri,
 
 static bool raw_accessors_invalid(const ARMCPRegInfo *ri)
 {
-   /* Return true if the regdef would cause an assertion if you called
+   /*
+    * Return true if the regdef would cause an assertion if you called
     * read_raw_cp_reg() or write_raw_cp_reg() on it (ie if it is a
     * program bug for it not to have the NO_RAW flag).
     * NB that returning false here doesn't necessarily mean that calling
@@ -XXX,XX +XXX,XX @@ bool write_list_to_cpustate(ARMCPU *cpu)
         if (ri->type & ARM_CP_NO_RAW) {
             continue;
         }
-        /* Write value and confirm it reads back as written
+        /*
+         * Write value and confirm it reads back as written
          * (to catch read-only registers and partially read-only
          * registers where the incoming migration value doesn't match)
          */
@@ -XXX,XX +XXX,XX @@ static gint cpreg_key_compare(gconstpointer a, gconstpointer b)
 
 void init_cpreg_list(ARMCPU *cpu)
 {
-    /* Initialise the cpreg_tuples[] array based on the cp_regs hash.
+    /*
+     * Initialise the cpreg_tuples[] array based on the cp_regs hash.
      * Note that we require cpreg_tuples[] to be sorted by key ID.
      */
     GList *keys;
@@ -XXX,XX +XXX,XX @@ static CPAccessResult access_el3_aa32ns(CPUARMState *env,
     return CP_ACCESS_OK;
 }
 
-/* Some secure-only AArch32 registers trap to EL3 if used from
+/*
+ * Some secure-only AArch32 registers trap to EL3 if used from
  * Secure EL1 (but are just ordinary UNDEF in other non-EL3 contexts).
  * Note that an access from Secure EL1 can only happen if EL3 is AArch64.
  * We assume that the .access field is set to PL1_RW.
@@ -XXX,XX +XXX,XX @@ static CPAccessResult access_trap_aa32s_el1(CPUARMState *env,
     return CP_ACCESS_TRAP_UNCATEGORIZED;
 }
 
-/* Check for traps to performance monitor registers, which are controlled
+/*
+ * Check for traps to performance monitor registers, which are controlled
  * by MDCR_EL2.TPM for EL2 and MDCR_EL3.TPM for EL3.
  */
 static CPAccessResult access_tpm(CPUARMState *env, const ARMCPRegInfo *ri,
@@ -XXX,XX +XXX,XX @@ static void fcse_write(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t value)
     ARMCPU *cpu = env_archcpu(env);
 
     if (raw_read(env, ri) != value) {
-        /* Unlike real hardware the qemu TLB uses virtual addresses,
+        /*
+         * Unlike real hardware the qemu TLB uses virtual addresses,
          * not modified virtual addresses, so this causes a TLB flush.
          */
         tlb_flush(CPU(cpu));
@@ -XXX,XX +XXX,XX @@ static void contextidr_write(CPUARMState *env, const ARMCPRegInfo *ri,
 
     if (raw_read(env, ri) != value && !arm_feature(env, ARM_FEATURE_PMSA)
         && !extended_addresses_enabled(env)) {
-        /* For VMSA (when not using the LPAE long descriptor page table
+        /*
+         * For VMSA (when not using the LPAE long descriptor page table
          * format) this register includes the ASID, so do a TLB flush.
          * For PMSA it is purely a process ID and no action is needed.
          */
@@ -XXX,XX +XXX,XX @@ static void tlbiipas2is_hyp_write(CPUARMState *env, const ARMCPRegInfo *ri,
 }
 
 static const ARMCPRegInfo cp_reginfo[] = {
-    /* Define the secure and non-secure FCSE identifier CP registers
+    /*
+     * Define the secure and non-secure FCSE identifier CP registers
      * separately because there is no secure bank in V8 (no _EL3).  This allows
      * the secure register to be properly reset and migrated. There is also no
      * v8 EL1 version of the register so the non-secure instance stands alone.
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo cp_reginfo[] = {
       .access = PL1_RW, .secure = ARM_CP_SECSTATE_S,
       .fieldoffset = offsetof(CPUARMState, cp15.fcseidr_s),
       .resetvalue = 0, .writefn = fcse_write, .raw_writefn = raw_write, },
-    /* Define the secure and non-secure context identifier CP registers
+    /*
+     * Define the secure and non-secure context identifier CP registers
      * separately because there is no secure bank in V8 (no _EL3).  This allows
      * the secure register to be properly reset and migrated.  In the
      * non-secure case, the 32-bit register will have reset and migration
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo cp_reginfo[] = {
 };
 
 static const ARMCPRegInfo not_v8_cp_reginfo[] = {
-    /* NB: Some of these registers exist in v8 but with more precise
+    /*
+     * NB: Some of these registers exist in v8 but with more precise
      * definitions that don't use CP_ANY wildcards (mostly in v8_cp_reginfo[]).
      */
     /* MMU Domain access control / MPU write buffer control */
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo not_v8_cp_reginfo[] = {
       .writefn = dacr_write, .raw_writefn = raw_write,
       .bank_fieldoffsets = { offsetoflow32(CPUARMState, cp15.dacr_s),
                              offsetoflow32(CPUARMState, cp15.dacr_ns) } },
-    /* ARMv7 allocates a range of implementation defined TLB LOCKDOWN regs.
+    /*
+     * ARMv7 allocates a range of implementation defined TLB LOCKDOWN regs.
      * For v6 and v5, these mappings are overly broad.
      */
     { .name = "TLB_LOCKDOWN", .cp = 15, .crn = 10, .crm = 0,
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo not_v8_cp_reginfo[] = {
 };
 
 static const ARMCPRegInfo not_v6_cp_reginfo[] = {
-    /* Not all pre-v6 cores implemented this WFI, so this is slightly
+    /*
+     * Not all pre-v6 cores implemented this WFI, so this is slightly
      * over-broad.
      */
     { .name = "WFI_v5", .cp = 15, .crn = 7, .crm = 8, .opc1 = 0, .opc2 = 2,
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo not_v6_cp_reginfo[] = {
 };
 
 static const ARMCPRegInfo not_v7_cp_reginfo[] = {
-    /* Standard v6 WFI (also used in some pre-v6 cores); not in v7 (which
+    /*
+     * Standard v6 WFI (also used in some pre-v6 cores); not in v7 (which
      * is UNPREDICTABLE; we choose to NOP as most implementations do).
      */
     { .name = "WFI_v6", .cp = 15, .crn = 7, .crm = 0, .opc1 = 0, .opc2 = 4,
       .access = PL1_W, .type = ARM_CP_WFI },
-    /* L1 cache lockdown. Not architectural in v6 and earlier but in practice
+    /*
+     * L1 cache lockdown. Not architectural in v6 and earlier but in practice
      * implemented in 926, 946, 1026, 1136, 1176 and 11MPCore. StrongARM and
      * OMAPCP will override this space.
      */
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo not_v7_cp_reginfo[] = {
     { .name = "DUMMY", .cp = 15, .crn = 0, .crm = 0, .opc1 = 1, .opc2 = CP_ANY,
       .access = PL1_R, .type = ARM_CP_CONST | ARM_CP_NO_RAW,
       .resetvalue = 0 },
-    /* We don't implement pre-v7 debug but most CPUs had at least a DBGDIDR;
+    /*
+     * We don't implement pre-v7 debug but most CPUs had at least a DBGDIDR;
      * implementing it as RAZ means the "debug architecture version" bits
      * will read as a reserved value, which should cause Linux to not try
      * to use the debug hardware.
      */
     { .name = "DBGDIDR", .cp = 14, .crn = 0, .crm = 0, .opc1 = 0, .opc2 = 0,
       .access = PL0_R, .type = ARM_CP_CONST, .resetvalue = 0 },
-    /* MMU TLB control. Note that the wildcarding means we cover not just
+    /*
+     * MMU TLB control. Note that the wildcarding means we cover not just
      * the unified TLB ops but also the dside/iside/inner-shareable variants.
      */
     { .name = "TLBIALL", .cp = 15, .crn = 8, .crm = CP_ANY,
@@ -XXX,XX +XXX,XX @@ static void cpacr_write(CPUARMState *env, const ARMCPRegInfo *ri,
 
     /* In ARMv8 most bits of CPACR_EL1 are RES0. */
     if (!arm_feature(env, ARM_FEATURE_V8)) {
-        /* ARMv7 defines bits for unimplemented coprocessors as RAZ/WI.
+        /*
+         * ARMv7 defines bits for unimplemented coprocessors as RAZ/WI.
          * ASEDIS [31] and D32DIS [30] are both UNK/SBZP without VFP.
          * TRCDIS [28] is RAZ/WI since we do not implement a trace macrocell.
          */
@@ -XXX,XX +XXX,XX @@ static void cpacr_write(CPUARMState *env, const ARMCPRegInfo *ri,
                 value |= R_CPACR_ASEDIS_MASK;
             }
 
-            /* VFPv3 and upwards with NEON implement 32 double precision
+            /*
+             * VFPv3 and upwards with NEON implement 32 double precision
              * registers (D0-D31).
              */
             if (!cpu_isar_feature(aa32_simd_r32, env_archcpu(env))) {
@@ -XXX,XX +XXX,XX @@ static uint64_t cpacr_read(CPUARMState *env, const ARMCPRegInfo *ri)
 
 static void cpacr_reset(CPUARMState *env, const ARMCPRegInfo *ri)
 {
-    /* Call cpacr_write() so that we reset with the correct RAO bits set
+    /*
+     * Call cpacr_write() so that we reset with the correct RAO bits set
      * for our CPU features.
      */
     cpacr_write(env, ri, 0);
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo v6_cp_reginfo[] = {
     { .name = "MVA_prefetch",
       .cp = 15, .crn = 7, .crm = 13, .opc1 = 0, .opc2 = 1,
       .access = PL1_W, .type = ARM_CP_NOP },
-    /* We need to break the TB after ISB to execute self-modifying code
+    /*
+     * We need to break the TB after ISB to execute self-modifying code
      * correctly and also to take any pending interrupts immediately.
      * So use arm_cp_write_ignore() function instead of ARM_CP_NOP flag.
      */
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo v6_cp_reginfo[] = {
       .bank_fieldoffsets = { offsetof(CPUARMState, cp15.ifar_s),
                              offsetof(CPUARMState, cp15.ifar_ns) },
       .resetvalue = 0, },
-    /* Watchpoint Fault Address Register : should actually only be present
+    /*
+     * Watchpoint Fault Address Register : should actually only be present
      * for 1136, 1176, 11MPCore.
      */
     { .name = "WFAR", .cp = 15, .crn = 6, .crm = 0, .opc1 = 0, .opc2 = 1,
@@ -XXX,XX +XXX,XX @@ static bool event_supported(uint16_t number)
 static CPAccessResult pmreg_access(CPUARMState *env, const ARMCPRegInfo *ri,
                                    bool isread)
 {
-    /* Performance monitor registers user accessibility is controlled
+    /*
+     * Performance monitor registers user accessibility is controlled
      * by PMUSERENR. MDCR_EL2.TPM and MDCR_EL3.TPM allow configurable
      * trapping to EL2 or EL3 for other accesses.
      */
@@ -XXX,XX +XXX,XX @@ static CPAccessResult pmreg_access_ccntr(CPUARMState *env,
     (MDCR_HPME | MDCR_HPMD | MDCR_HPMN | MDCR_HCCD | MDCR_HLP)
 #define MDCR_EL3_PMU_ENABLE_BITS (MDCR_SPME | MDCR_SCCD)
 
-/* Returns true if the counter (pass 31 for PMCCNTR) should count events using
+/*
+ * Returns true if the counter (pass 31 for PMCCNTR) should count events using
  * the current EL, security state, and register configuration.
  */
 static bool pmu_counter_enabled(CPUARMState *env, uint8_t counter)
@@ -XXX,XX +XXX,XX @@ static uint64_t pmccntr_read(CPUARMState *env, const ARMCPRegInfo *ri)
 static void pmselr_write(CPUARMState *env, const ARMCPRegInfo *ri,
                          uint64_t value)
 {
-    /* The value of PMSELR.SEL affects the behavior of PMXEVTYPER and
+    /*
+     * The value of PMSELR.SEL affects the behavior of PMXEVTYPER and
      * PMXEVCNTR. We allow [0..31] to be written to PMSELR here; in the
      * meanwhile, we check PMSELR.SEL when PMXEVTYPER and PMXEVCNTR are
      * accessed.
@@ -XXX,XX +XXX,XX @@ static void pmevtyper_write(CPUARMState *env, const ARMCPRegInfo *ri,
         env->cp15.c14_pmevtyper[counter] = value & PMXEVTYPER_MASK;
         pmevcntr_op_finish(env, counter);
     }
-    /* Attempts to access PMXEVTYPER are CONSTRAINED UNPREDICTABLE when
+    /*
+     * Attempts to access PMXEVTYPER are CONSTRAINED UNPREDICTABLE when
      * PMSELR value is equal to or greater than the number of implemented
      * counters, but not equal to 0x1f. We opt to behave as a RAZ/WI.
      */
@@ -XXX,XX +XXX,XX @@ static uint64_t pmevcntr_read(CPUARMState *env, const ARMCPRegInfo *ri,
         }
         return ret;
     } else {
-      /* We opt to behave as a RAZ/WI when attempts to access PM[X]EVCNTR
-       * are CONSTRAINED UNPREDICTABLE. */
+      /*
+       * We opt to behave as a RAZ/WI when attempts to access PM[X]EVCNTR
+       * are CONSTRAINED UNPREDICTABLE.
+       */
         return 0;
     }
 }
@@ -XXX,XX +XXX,XX @@ static void pmintenclr_write(CPUARMState *env, const ARMCPRegInfo *ri,
 static void vbar_write(CPUARMState *env, const ARMCPRegInfo *ri,
                        uint64_t value)
 {
-    /* Note that even though the AArch64 view of this register has bits
+    /*
+     * Note that even though the AArch64 view of this register has bits
      * [10:0] all RES0 we can only mask the bottom 5, to comply with the
      * architectural requirements for bits which are RES0 only in some
      * contexts. (ARMv8 would permit us to do no masking at all, but ARMv7
@@ -XXX,XX +XXX,XX @@ static void scr_write(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t value)
     if (!arm_feature(env, ARM_FEATURE_EL2)) {
         valid_mask &= ~SCR_HCE;
 
-        /* On ARMv7, SMD (or SCD as it is called in v7) is only
+        /*
+         * On ARMv7, SMD (or SCD as it is called in v7) is only
          * supported if EL2 exists. The bit is UNK/SBZP when
          * EL2 is unavailable. In QEMU ARMv7, we force it to always zero
          * when EL2 is unavailable.
@@ -XXX,XX +XXX,XX @@ static uint64_t ccsidr_read(CPUARMState *env, const ARMCPRegInfo *ri)
 {
     ARMCPU *cpu = env_archcpu(env);
 
-    /* Acquire the CSSELR index from the bank corresponding to the CCSIDR
+    /*
+     * Acquire the CSSELR index from the bank corresponding to the CCSIDR
      * bank
      */
     uint32_t index = A32_BANKED_REG_GET(env, csselr,
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo v7_cp_reginfo[] = {
     /* the old v6 WFI, UNPREDICTABLE in v7 but we choose to NOP */
     { .name = "NOP", .cp = 15, .crn = 7, .crm = 0, .opc1 = 0, .opc2 = 4,
       .access = PL1_W, .type = ARM_CP_NOP },
-    /* Performance monitors are implementation defined in v7,
+    /*
+     * Performance monitors are implementation defined in v7,
      * but with an ARM recommended set of registers, which we
      * follow.
      *
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo v7_cp_reginfo[] = {
       .writefn = csselr_write, .resetvalue = 0,
       .bank_fieldoffsets = { offsetof(CPUARMState, cp15.csselr_s),
                              offsetof(CPUARMState, cp15.csselr_ns) } },
-    /* Auxiliary ID register: this actually has an IMPDEF value but for now
+    /*
+     * Auxiliary ID register: this actually has an IMPDEF value but for now
      * just RAZ for all cores:
      */
     { .name = "AIDR", .state = ARM_CP_STATE_BOTH,
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo v7_cp_reginfo[] = {
       .access = PL1_R, .type = ARM_CP_CONST,
       .accessfn = access_aa64_tid1,
       .resetvalue = 0 },
-    /* Auxiliary fault status registers: these also are IMPDEF, and we
+    /*
+     * Auxiliary fault status registers: these also are IMPDEF, and we
      * choose to RAZ/WI for all cores.
      */
     { .name = "AFSR0_EL1", .state = ARM_CP_STATE_BOTH,
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo v7_cp_reginfo[] = {
       .opc0 = 3, .opc1 = 0, .crn = 5, .crm = 1, .opc2 = 1,
       .access = PL1_RW, .accessfn = access_tvm_trvm,
       .type = ARM_CP_CONST, .resetvalue = 0 },
-    /* MAIR can just read-as-written because we don't implement caches
+    /*
+     * MAIR can just read-as-written because we don't implement caches
      * and so don't need to care about memory attributes.
      */
     { .name = "MAIR_EL1", .state = ARM_CP_STATE_AA64,
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo v7_cp_reginfo[] = {
       .opc0 = 3, .opc1 = 6, .crn = 10, .crm = 2, .opc2 = 0,
       .access = PL3_RW, .fieldoffset = offsetof(CPUARMState, cp15.mair_el[3]),
       .resetvalue = 0 },
-    /* For non-long-descriptor page tables these are PRRR and NMRR;
+    /*
+     * For non-long-descriptor page tables these are PRRR and NMRR;
      * regardless they still act as reads-as-written for QEMU.
      */
-     /* MAIR0/1 are defined separately from their 64-bit counterpart which
+     /*
+      * MAIR0/1 are defined separately from their 64-bit counterpart which
       * allows them to assign the correct fieldoffset based on the endianness
       * handled in the field definitions.
       */
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo v6k_cp_reginfo[] = {
 static CPAccessResult gt_cntfrq_access(CPUARMState *env, const ARMCPRegInfo *ri,
                                        bool isread)
 {
-    /* CNTFRQ: not visible from PL0 if both PL0PCTEN and PL0VCTEN are zero.
+    /*
+     * CNTFRQ: not visible from PL0 if both PL0PCTEN and PL0VCTEN are zero.
      * Writable only at the highest implemented exception level.
      */
     int el = arm_current_el(env);
@@ -XXX,XX +XXX,XX @@ static CPAccessResult gt_stimer_access(CPUARMState *env,
                                        const ARMCPRegInfo *ri,
                                        bool isread)
 {
-    /* The AArch64 register view of the secure physical timer is
+    /*
+     * The AArch64 register view of the secure physical timer is
      * always accessible from EL3, and configurably accessible from
      * Secure EL1.
      */
@@ -XXX,XX +XXX,XX @@ static void gt_recalc_timer(ARMCPU *cpu, int timeridx)
     ARMGenericTimer *gt = &cpu->env.cp15.c14_timer[timeridx];
 
     if (gt->ctl & 1) {
-        /* Timer enabled: calculate and set current ISTATUS, irq, and
+        /*
+         * Timer enabled: calculate and set current ISTATUS, irq, and
          * reset timer to when ISTATUS next has to change
          */
         uint64_t offset = timeridx == GTIMER_VIRT ?
@@ -XXX,XX +XXX,XX @@ static void gt_recalc_timer(ARMCPU *cpu, int timeridx)
             /* Next transition is when we hit cval */
             nexttick = gt->cval + offset;
         }
-        /* Note that the desired next expiry time might be beyond the
+        /*
+         * Note that the desired next expiry time might be beyond the
          * signed-64-bit range of a QEMUTimer -- in this case we just
          * set the timer for as far in the future as possible. When the
          * timer expires we will reset the timer for any remaining period.
@@ -XXX,XX +XXX,XX @@ static void gt_ctl_write(CPUARMState *env, const ARMCPRegInfo *ri,
         /* Enable toggled */
         gt_recalc_timer(cpu, timeridx);
     } else if ((oldval ^ value) & 2) {
-        /* IMASK toggled: don't need to recalculate,
+        /*
+         * IMASK toggled: don't need to recalculate,
          * just set the interrupt line based on ISTATUS
          */
         int irqstate = (oldval & 4) && !(value & 2);
@@ -XXX,XX +XXX,XX @@ static void arm_gt_cntfrq_reset(CPUARMState *env, const ARMCPRegInfo *opaque)
 }
 
 static const ARMCPRegInfo generic_timer_cp_reginfo[] = {
-    /* Note that CNTFRQ is purely reads-as-written for the benefit
+    /*
+     * Note that CNTFRQ is purely reads-as-written for the benefit
      * of software; writing it doesn't actually change the timer frequency.
      * Our reset value matches the fixed frequency we implement the timer at.
      */
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo generic_timer_cp_reginfo[] = {
       .readfn = gt_virt_redir_cval_read, .raw_readfn = raw_read,
       .writefn = gt_virt_redir_cval_write, .raw_writefn = raw_write,
     },
-    /* Secure timer -- this is actually restricted to only EL3
+    /*
+     * Secure timer -- this is actually restricted to only EL3
      * and configurably Secure-EL1 via the accessfn.
      */
     { .name = "CNTPS_TVAL_EL1", .state = ARM_CP_STATE_AA64,
@@ -XXX,XX +XXX,XX @@ static CPAccessResult e2h_access(CPUARMState *env, const ARMCPRegInfo *ri,
 
 #else
 
-/* In user-mode most of the generic timer registers are inaccessible
+/*
+ * In user-mode most of the generic timer registers are inaccessible
  * however modern kernels (4.12+) allow access to cntvct_el0
  */
 
@@ -XXX,XX +XXX,XX @@ static uint64_t gt_virt_cnt_read(CPUARMState *env, const ARMCPRegInfo *ri)
 {
     ARMCPU *cpu = env_archcpu(env);
 
-    /* Currently we have no support for QEMUTimer in linux-user so we
+    /*
+     * Currently we have no support for QEMUTimer in linux-user so we
      * can't call gt_get_countervalue(env), instead we directly
      * call the lower level functions.
      */
@@ -XXX,XX +XXX,XX @@ static CPAccessResult ats_access(CPUARMState *env, const ARMCPRegInfo *ri,
                                  bool isread)
 {
     if (ri->opc2 & 4) {
-        /* The ATS12NSO* operations must trap to EL3 or EL2 if executed in
+        /*
+         * The ATS12NSO* operations must trap to EL3 or EL2 if executed in
          * Secure EL1 (which can only happen if EL3 is AArch64).
          * They are simply UNDEF if executed from NS EL1.
          * They function normally from EL2 or EL3.
@@ -XXX,XX +XXX,XX @@ static uint64_t do_ats_write(CPUARMState *env, uint64_t value,
             }
         }
     } else {
-        /* fsr is a DFSR/IFSR value for the short descriptor
+        /*
+         * fsr is a DFSR/IFSR value for the short descriptor
          * translation table format (with WnR always clear).
          * Convert it to a 32-bit PAR.
          */
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo pmsav8r_cp_reginfo[] = {
 };
 
 static const ARMCPRegInfo pmsav7_cp_reginfo[] = {
-    /* Reset for all these registers is handled in arm_cpu_reset(),
+    /*
+     * Reset for all these registers is handled in arm_cpu_reset(),
      * because the PMSAv7 is also used by M-profile CPUs, which do
      * not register cpregs but still need the state to be reset.
      */
@@ -XXX,XX +XXX,XX @@ static void vmsa_ttbcr_write(CPUARMState *env, const ARMCPRegInfo *ri,
     }
 
     if (arm_feature(env, ARM_FEATURE_LPAE)) {
-        /* With LPAE the TTBCR could result in a change of ASID
+        /*
+         * With LPAE the TTBCR could result in a change of ASID
          * via the TTBCR.A1 bit, so do a TLB flush.
          */
         tlb_flush(CPU(cpu));
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo vmsa_cp_reginfo[] = {
                              offsetoflow32(CPUARMState, cp15.tcr_el[1])} },
 };
 
-/* Note that unlike TTBCR, writing to TTBCR2 does not require flushing
+/*
+ * Note that unlike TTBCR, writing to TTBCR2 does not require flushing
  * qemu tlbs nor adjusting cached masks.
  */
 static const ARMCPRegInfo ttbcr2_reginfo = {
@@ -XXX,XX +XXX,XX @@ static void omap_wfi_write(CPUARMState *env, const ARMCPRegInfo *ri,
 static void omap_cachemaint_write(CPUARMState *env, const ARMCPRegInfo *ri,
                                   uint64_t value)
 {
-    /* On OMAP there are registers indicating the max/min index of dcache lines
+    /*
+     * On OMAP there are registers indicating the max/min index of dcache lines
      * containing a dirty line; cache flush operations have to reset these.
      */
     env->cp15.c15_i_max = 0x000;
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo omap_cp_reginfo[] = {
       .crm = 8, .opc1 = 0, .opc2 = 0, .access = PL1_RW,
       .type = ARM_CP_NO_RAW,
       .readfn = arm_cp_read_zero, .writefn = omap_wfi_write, },
-    /* TODO: Peripheral port remap register:
+    /*
+     * TODO: Peripheral port remap register:
      * On OMAP2 mcr p15, 0, rn, c15, c2, 4 sets up the interrupt controller
      * base address at $rn & ~0xfff and map size of 0x200 << ($rn & 0xfff),
      * when MMU is off.
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo xscale_cp_reginfo[] = {
       .cp = 15, .crn = 1, .crm = 0, .opc1 = 0, .opc2 = 1, .access = PL1_RW,
       .fieldoffset = offsetof(CPUARMState, cp15.c1_xscaleauxcr),
       .resetvalue = 0, },
-    /* XScale specific cache-lockdown: since we have no cache we NOP these
+    /*
+     * XScale specific cache-lockdown: since we have no cache we NOP these
      * and hope the guest does not really rely on cache behaviour.
      */
     { .name = "XSCALE_LOCK_ICACHE_LINE",
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo xscale_cp_reginfo[] = {
 };
 
 static const ARMCPRegInfo dummy_c15_cp_reginfo[] = {
-    /* RAZ/WI the whole crn=15 space, when we don't have a more specific
+    /*
+     * RAZ/WI the whole crn=15 space, when we don't have a more specific
      * implementation of this implementation-defined space.
      * Ideally this should eventually disappear in favour of actually
      * implementing the correct behaviour for all cores.
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo cache_block_ops_cp_reginfo[] = {
 };
 
 static const ARMCPRegInfo cache_test_clean_cp_reginfo[] = {
-    /* The cache test-and-clean instructions always return (1 << 30)
+    /*
+     * The cache test-and-clean instructions always return (1 << 30)
      * to indicate that there are no dirty cache lines.
      */
     { .name = "TC_DCACHE", .cp = 15, .crn = 7, .crm = 10, .opc1 = 0, .opc2 = 3,
@@ -XXX,XX +XXX,XX @@ static uint64_t mpidr_read_val(CPUARMState *env)
 
     if (arm_feature(env, ARM_FEATURE_V7MP)) {
         mpidr |= (1U << 31);
-        /* Cores which are uniprocessor (non-coherent)
+        /*
+         * Cores which are uniprocessor (non-coherent)
          * but still implement the MP extensions set
          * bit 30. (For instance, Cortex-R5).
          */
@@ -XXX,XX +XXX,XX @@ static CPAccessResult access_tocu(CPUARMState *env, const ARMCPRegInfo *ri,
     return do_cacheop_pou_access(env, HCR_TOCU | HCR_TPU);
 }
 
-/* See: D4.7.2 TLB maintenance requirements and the TLB maintenance instructions
+/*
+ * See: D4.7.2 TLB maintenance requirements and the TLB maintenance instructions
  * Page D4-1736 (DDI0487A.b)
  */
 
@@ -XXX,XX +XXX,XX @@ static void tlbi_aa64_alle3is_write(CPUARMState *env, const ARMCPRegInfo *ri,
 static void tlbi_aa64_vae2_write(CPUARMState *env, const ARMCPRegInfo *ri,
                                  uint64_t value)
 {
-    /* Invalidate by VA, EL2
+    /*
+     * Invalidate by VA, EL2
      * Currently handles both VAE2 and VALE2, since we don't support
      * flush-last-level-only.
      */
@@ -XXX,XX +XXX,XX @@ static void tlbi_aa64_vae2_write(CPUARMState *env, const ARMCPRegInfo *ri,
 static void tlbi_aa64_vae3_write(CPUARMState *env, const ARMCPRegInfo *ri,
                                  uint64_t value)
 {
-    /* Invalidate by VA, EL3
+    /*
+     * Invalidate by VA, EL3
      * Currently handles both VAE3 and VALE3, since we don't support
      * flush-last-level-only.
      */
@@ -XXX,XX +XXX,XX @@ static void tlbi_aa64_vae1is_write(CPUARMState *env, const ARMCPRegInfo *ri,
 static void tlbi_aa64_vae1_write(CPUARMState *env, const ARMCPRegInfo *ri,
                                  uint64_t value)
 {
-    /* Invalidate by VA, EL1&0 (AArch64 version).
+    /*
+     * Invalidate by VA, EL1&0 (AArch64 version).
      * Currently handles all of VAE1, VAAE1, VAALE1 and VALE1,
      * since we don't support flush-for-specific-ASID-only or
      * flush-last-level-only.
@@ -XXX,XX +XXX,XX @@ static CPAccessResult sp_el0_access(CPUARMState *env, const ARMCPRegInfo *ri,
                                     bool isread)
 {
     if (!(env->pstate & PSTATE_SP)) {
-        /* Access to SP_EL0 is undefined if it's being used as
+        /*
+         * Access to SP_EL0 is undefined if it's being used as
          * the stack pointer.
          */
         return CP_ACCESS_TRAP_UNCATEGORIZED;
@@ -XXX,XX +XXX,XX @@ static void sctlr_write(CPUARMState *env, const ARMCPRegInfo *ri,
     }
 
     if (raw_read(env, ri) == value) {
-        /* Skip the TLB flush if nothing actually changed; Linux likes
+        /*
+         * Skip the TLB flush if nothing actually changed; Linux likes
          * to do a lot of pointless SCTLR writes.
          */
         return;
@@ -XXX,XX +XXX,XX @@ static void mdcr_el2_write(CPUARMState *env, const ARMCPRegInfo *ri,
 }
 
 static const ARMCPRegInfo v8_cp_reginfo[] = {
-    /* Minimal set of EL0-visible registers. This will need to be expanded
+    /*
+     * Minimal set of EL0-visible registers. This will need to be expanded
      * significantly for system emulation of AArch64 CPUs.
      */
     { .name = "NZCV", .state = ARM_CP_STATE_AA64,
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo v8_cp_reginfo[] = {
       .opc0 = 3, .opc1 = 0, .crn = 4, .crm = 0, .opc2 = 0,
       .access = PL1_RW,
       .fieldoffset = offsetof(CPUARMState, banked_spsr[BANK_SVC]) },
-    /* We rely on the access checks not allowing the guest to write to the
+    /*
+     * We rely on the access checks not allowing the guest to write to the
      * state field when SPSel indicates that it's being used as the stack
      * pointer.
      */
@@ -XXX,XX +XXX,XX @@ static void do_hcr_write(CPUARMState *env, uint64_t value, uint64_t valid_mask)
     if (arm_feature(env, ARM_FEATURE_EL3)) {
         valid_mask &= ~HCR_HCD;
     } else if (cpu->psci_conduit != QEMU_PSCI_CONDUIT_SMC) {
-        /* Architecturally HCR.TSC is RES0 if EL3 is not implemented.
+        /*
+         * Architecturally HCR.TSC is RES0 if EL3 is not implemented.
          * However, if we're using the SMC PSCI conduit then QEMU is
          * effectively acting like EL3 firmware and so the guest at
          * EL2 should retain the ability to prevent EL1 from being
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo el2_cp_reginfo[] = {
       .access = PL2_W, .type = ARM_CP_NO_RAW | ARM_CP_EL3_NO_EL2_UNDEF,
       .writefn = tlbi_aa64_vae2is_write },
 #ifndef CONFIG_USER_ONLY
-    /* Unlike the other EL2-related AT operations, these must
+    /*
+     * Unlike the other EL2-related AT operations, these must
      * UNDEF from EL3 if EL2 is not implemented, which is why we
      * define them here rather than with the rest of the AT ops.
      */
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo el2_cp_reginfo[] = {
       .access = PL2_W, .accessfn = at_s1e2_access,
       .type = ARM_CP_NO_RAW | ARM_CP_RAISES_EXC | ARM_CP_EL3_NO_EL2_UNDEF,
       .writefn = ats_write64 },
-    /* The AArch32 ATS1H* operations are CONSTRAINED UNPREDICTABLE
+    /*
+     * The AArch32 ATS1H* operations are CONSTRAINED UNPREDICTABLE
      * if EL2 is not implemented; we choose to UNDEF. Behaviour at EL3
      * with SCR.NS == 0 outside Monitor mode is UNPREDICTABLE; we choose
      * to behave as if SCR.NS was 1.
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo el2_cp_reginfo[] = {
       .writefn = ats1h_write, .type = ARM_CP_NO_RAW | ARM_CP_RAISES_EXC },
     { .name = "CNTHCTL_EL2", .state = ARM_CP_STATE_BOTH,
       .opc0 = 3, .opc1 = 4, .crn = 14, .crm = 1, .opc2 = 0,
-      /* ARMv7 requires bit 0 and 1 to reset to 1. ARMv8 defines the
+      /*
+       * ARMv7 requires bit 0 and 1 to reset to 1. ARMv8 defines the
        * reset values as IMPDEF. We choose to reset to 3 to comply with
        * both ARMv7 and ARMv8.
        */
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo el2_sec_cp_reginfo[] = {
 static CPAccessResult nsacr_access(CPUARMState *env, const ARMCPRegInfo *ri,
                                    bool isread)
 {
-    /* The NSACR is RW at EL3, and RO for NS EL1 and NS EL2.
+    /*
+     * The NSACR is RW at EL3, and RO for NS EL1 and NS EL2.
      * At Secure EL1 it traps to EL3 or EL2.
      */
     if (arm_current_el(env) == 3) {
@@ -XXX,XX +XXX,XX @@ static void define_pmu_regs(ARMCPU *cpu)
     }
 }
 
-/* We don't know until after realize whether there's a GICv3
+/*
+ * We don't know until after realize whether there's a GICv3
  * attached, and that is what registers the gicv3 sysregs.
  * So we have to fill in the GIC fields in ID_PFR/ID_PFR1_EL1/ID_AA64PFR0_EL1
  * at runtime.
@@ -XXX,XX +XXX,XX @@ static uint64_t id_aa64pfr0_read(CPUARMState *env, const ARMCPRegInfo *ri)
 }
 #endif
 
-/* Shared logic between LORID and the rest of the LOR* registers.
+/*
+ * Shared logic between LORID and the rest of the LOR* registers.
  * Secure state exclusion has already been dealt with.
  */
 static CPAccessResult access_lor_ns(CPUARMState *env,
@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
 
     define_arm_cp_regs(cpu, cp_reginfo);
     if (!arm_feature(env, ARM_FEATURE_V8)) {
-        /* Must go early as it is full of wildcards that may be
+        /*
+         * Must go early as it is full of wildcards that may be
          * overridden by later definitions.
          */
         define_arm_cp_regs(cpu, not_v8_cp_reginfo);
@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
               .access = PL1_R, .type = ARM_CP_CONST,
               .accessfn = access_aa32_tid3,
               .resetvalue = cpu->isar.id_pfr0 },
-            /* ID_PFR1 is not a plain ARM_CP_CONST because we don't know
+            /*
+             * ID_PFR1 is not a plain ARM_CP_CONST because we don't know
              * the value of the GIC field until after we define these regs.
              */
             { .name = "ID_PFR1", .state = ARM_CP_STATE_BOTH,
@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
 
         define_arm_cp_regs(cpu, el3_regs);
     }
-    /* The behaviour of NSACR is sufficiently various that we don't
+    /*
+     * The behaviour of NSACR is sufficiently various that we don't
      * try to describe it in a single reginfo:
      *  if EL3 is 64 bit, then trap to EL3 from S EL1,
      *     reads as constant 0xc00 from NS EL1 and NS EL2
@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
     if (cpu_isar_feature(aa32_jazelle, cpu)) {
         define_arm_cp_regs(cpu, jazelle_regs);
     }
-    /* Slightly awkwardly, the OMAP and StrongARM cores need all of
+    /*
+     * Slightly awkwardly, the OMAP and StrongARM cores need all of
      * cp15 crn=0 to be writes-ignored, whereas for other cores they should
      * be read-only (ie write causes UNDEF exception).
      */
     {
         ARMCPRegInfo id_pre_v8_midr_cp_reginfo[] = {
-            /* Pre-v8 MIDR space.
+            /*
+             * Pre-v8 MIDR space.
              * Note that the MIDR isn't a simple constant register because
              * of the TI925 behaviour where writes to another register can
              * cause the MIDR value to change.
@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
         if (arm_feature(env, ARM_FEATURE_OMAPCP) ||
             arm_feature(env, ARM_FEATURE_STRONGARM)) {
             size_t i;
-            /* Register the blanket "writes ignored" value first to cover the
+            /*
+             * Register the blanket "writes ignored" value first to cover the
              * whole space. Then update the specific ID registers to allow write
              * access, so that they ignore writes rather than causing them to
              * UNDEF.
@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
             .raw_writefn = raw_write,
         };
         if (arm_feature(env, ARM_FEATURE_XSCALE)) {
-            /* Normally we would always end the TB on an SCTLR write, but Linux
+            /*
+             * Normally we would always end the TB on an SCTLR write, but Linux
              * arch/arm/mach-pxa/sleep.S expects two instructions following
              * an MMU enable to execute from cache.  Imitate this behaviour.
              */
@@ -XXX,XX +XXX,XX @@ static void add_cpreg_to_hashtable(ARMCPU *cpu, const ARMCPRegInfo *r,
 void define_one_arm_cp_reg_with_opaque(ARMCPU *cpu,
                                        const ARMCPRegInfo *r, void *opaque)
 {
-    /* Define implementations of coprocessor registers.
+    /*
+     * Define implementations of coprocessor registers.
      * We store these in a hashtable because typically
      * there are less than 150 registers in a space which
      * is 16*16*16*8*8 = 262144 in size.
@@ -XXX,XX +XXX,XX @@ void define_one_arm_cp_reg_with_opaque(ARMCPU *cpu,
     default:
         g_assert_not_reached();
     }
-    /* The AArch64 pseudocode CheckSystemAccess() specifies that op1
+    /*
+     * The AArch64 pseudocode CheckSystemAccess() specifies that op1
      * encodes a minimum access level for the register. We roll this
      * runtime check into our general permission check code, so check
      * here that the reginfo's specified permissions are strict enough
@@ -XXX,XX +XXX,XX @@ void define_one_arm_cp_reg_with_opaque(ARMCPU *cpu,
         assert((r->access & ~mask) == 0);
     }
 
-    /* Check that the register definition has enough info to handle
+    /*
+     * Check that the register definition has enough info to handle
      * reads and writes if they are permitted.
      */
     if (!(r->type & (ARM_CP_SPECIAL_MASK | ARM_CP_CONST))) {
@@ -XXX,XX +XXX,XX @@ void define_one_arm_cp_reg_with_opaque(ARMCPU *cpu,
                         continue;
                     }
                     if (state == ARM_CP_STATE_AA32) {
-                        /* Under AArch32 CP registers can be common
+                        /*
+                         * Under AArch32 CP registers can be common
                          * (same for secure and non-secure world) or banked.
                          */
                         char *name;
@@ -XXX,XX +XXX,XX @@ void define_one_arm_cp_reg_with_opaque(ARMCPU *cpu,
                             g_assert_not_reached();
                         }
                     } else {
-                        /* AArch64 registers get mapped to non-secure instance
-                         * of AArch32 */
+                        /*
+                         * AArch64 registers get mapped to non-secure instance
+                         * of AArch32
+                         */
                         add_cpreg_to_hashtable(cpu, r, opaque, state,
                                                ARM_CP_SECSTATE_NS,
                                                crm, opc1, opc2, r->name);
@@ -XXX,XX +XXX,XX @@ void arm_cp_reset_ignore(CPUARMState *env, const ARMCPRegInfo *opaque)
 
 static int bad_mode_switch(CPUARMState *env, int mode, CPSRWriteType write_type)
 {
-    /* Return true if it is not valid for us to switch to
+    /*
+     * Return true if it is not valid for us to switch to
      * this CPU mode (ie all the UNPREDICTABLE cases in
      * the ARM ARM CPSRWriteByInstr pseudocode).
      */
@@ -XXX,XX +XXX,XX @@ static int bad_mode_switch(CPUARMState *env, int mode, CPSRWriteType write_type)
     case ARM_CPU_MODE_UND:
     case ARM_CPU_MODE_IRQ:
     case ARM_CPU_MODE_FIQ:
-        /* Note that we don't implement the IMPDEF NSACR.RFR which in v7
+        /*
+         * Note that we don't implement the IMPDEF NSACR.RFR which in v7
          * allows FIQ mode to be Secure-only. (In v8 this doesn't exist.)
          */
-        /* If HCR.TGE is set then changes from Monitor to NS PL1 via MSR
+        /*
+         * If HCR.TGE is set then changes from Monitor to NS PL1 via MSR
          * and CPS are treated as illegal mode changes.
          */
         if (write_type == CPSRWriteByInstr &&
@@ -XXX,XX +XXX,XX @@ void cpsr_write(CPUARMState *env, uint32_t val, uint32_t mask,
         env->GE = (val >> 16) & 0xf;
     }
 
-    /* In a V7 implementation that includes the security extensions but does
+    /*
+     * In a V7 implementation that includes the security extensions but does
      * not include Virtualization Extensions the SCR.FW and SCR.AW bits control
      * whether non-secure software is allowed to change the CPSR_F and CPSR_A
      * bits respectively.
@@ -XXX,XX +XXX,XX @@ void cpsr_write(CPUARMState *env, uint32_t val, uint32_t mask,
         changed_daif = (env->daif ^ val) & mask;
 
         if (changed_daif & CPSR_A) {
-            /* Check to see if we are allowed to change the masking of async
+            /*
+             * Check to see if we are allowed to change the masking of async
              * abort exceptions from a non-secure state.
              */
             if (!(env->cp15.scr_el3 & SCR_AW)) {
@@ -XXX,XX +XXX,XX @@ void cpsr_write(CPUARMState *env, uint32_t val, uint32_t mask,
         }
 
         if (changed_daif & CPSR_F) {
-            /* Check to see if we are allowed to change the masking of FIQ
+            /*
+             * Check to see if we are allowed to change the masking of FIQ
              * exceptions from a non-secure state.
              */
             if (!(env->cp15.scr_el3 & SCR_FW)) {
@@ -XXX,XX +XXX,XX @@ void cpsr_write(CPUARMState *env, uint32_t val, uint32_t mask,
                 mask &= ~CPSR_F;
             }
 
-            /* Check whether non-maskable FIQ (NMFI) support is enabled.
+            /*
+             * Check whether non-maskable FIQ (NMFI) support is enabled.
              * If this bit is set software is not allowed to mask
              * FIQs, but is allowed to set CPSR_F to 0.
              */
@@ -XXX,XX +XXX,XX @@ void cpsr_write(CPUARMState *env, uint32_t val, uint32_t mask,
     if (write_type != CPSRWriteRaw &&
         ((env->uncached_cpsr ^ val) & mask & CPSR_M)) {
         if ((env->uncached_cpsr & CPSR_M) == ARM_CPU_MODE_USR) {
-            /* Note that we can only get here in USR mode if this is a
+            /*
+             * Note that we can only get here in USR mode if this is a
              * gdb stub write; for this case we follow the architectural
              * behaviour for guest writes in USR mode of ignoring an attempt
              * to switch mode. (Those are caught by translate.c for writes
@@ -XXX,XX +XXX,XX @@ void cpsr_write(CPUARMState *env, uint32_t val, uint32_t mask,
              */
             mask &= ~CPSR_M;
         } else if (bad_mode_switch(env, val & CPSR_M, write_type)) {
-            /* Attempt to switch to an invalid mode: this is UNPREDICTABLE in
+            /*
+             * Attempt to switch to an invalid mode: this is UNPREDICTABLE in
              * v7, and has defined behaviour in v8:
              *  + leave CPSR.M untouched
              *  + allow changes to the other CPSR fields
@@ -XXX,XX +XXX,XX @@ static void switch_mode(CPUARMState *env, int mode)
     env->regs[14] = env->banked_r14[r14_bank_number(mode)];
 }
 
-/* Physical Interrupt Target EL Lookup Table
+/*
+ * Physical Interrupt Target EL Lookup Table
  *
  * [ From ARM ARM section G1.13.4 (Table G1-15) ]
  *
@@ -XXX,XX +XXX,XX @@ uint32_t arm_phys_excp_target_el(CPUState *cs, uint32_t excp_idx,
     if (arm_feature(env, ARM_FEATURE_EL3)) {
         rw = ((env->cp15.scr_el3 & SCR_RW) == SCR_RW);
     } else {
-        /* Either EL2 is the highest EL (and so the EL2 register width
+        /*
+         * Either EL2 is the highest EL (and so the EL2 register width
          * is given by is64); or there is no EL2 or EL3, in which case
          * the value of 'rw' does not affect the table lookup anyway.
          */
@@ -XXX,XX +XXX,XX @@ void aarch64_sync_64_to_32(CPUARMState *env)
         env->banked_r13[bank_number(ARM_CPU_MODE_UND)] = env->xregs[23];
     }
 
-    /* Registers x24-x30 are mapped to r8-r14 in FIQ mode.  If we are in FIQ
+    /*
+     * Registers x24-x30 are mapped to r8-r14 in FIQ mode.  If we are in FIQ
      * mode, then we can copy to r8-r14.  Otherwise, we copy to the
      * FIQ bank for r8-r14.
      */
@@ -XXX,XX +XXX,XX @@ static void arm_cpu_do_interrupt_aarch32(CPUState *cs)
         /* High vectors. When enabled, base address cannot be remapped. */
         addr += 0xffff0000;
     } else {
-        /* ARM v7 architectures provide a vector base address register to remap
+        /*
+         * ARM v7 architectures provide a vector base address register to remap
          * the interrupt vector table.
          * This register is only followed in non-monitor mode, and is banked.
          * Note: only bits 31:5 are valid.
@@ -XXX,XX +XXX,XX @@ static void arm_cpu_do_interrupt_aarch64(CPUState *cs)
     aarch64_sve_change_el(env, cur_el, new_el, is_a64(env));
 
     if (cur_el < new_el) {
-        /* Entry vector offset depends on whether the implemented EL
+        /*
+         * Entry vector offset depends on whether the implemented EL
          * immediately lower than the target level is using AArch32 or AArch64
          */
         bool is_aa64;
@@ -XXX,XX +XXX,XX @@ static void handle_semihosting(CPUState *cs)
 }
 #endif
 
-/* Handle a CPU exception for A and R profile CPUs.
+/*
+ * Handle a CPU exception for A and R profile CPUs.
  * Do any appropriate logging, handle PSCI calls, and then hand off
  * to the AArch64-entry or AArch32-entry function depending on the
  * target exception level's register width.
@@ -XXX,XX +XXX,XX @@ void arm_cpu_do_interrupt(CPUState *cs)
     }
 #endif
 
-    /* Hooks may change global state so BQL should be held, also the
+    /*
+     * Hooks may change global state so BQL should be held, also the
      * BQL needs to be held for any modification of
      * cs->interrupt_request.
      */
@@ -XXX,XX +XXX,XX @@ ARMVAParameters aa64_va_parameters(CPUARMState *env, uint64_t va,
     };
 }
 
-/* Note that signed overflow is undefined in C.  The following routines are
-   careful to use unsigned types where modulo arithmetic is required.
-   Failure to do so _will_ break on newer gcc.  */
+/*
+ * Note that signed overflow is undefined in C.  The following routines are
+ * careful to use unsigned types where modulo arithmetic is required.
+ * Failure to do so _will_ break on newer gcc.
+ */
 
 /* Signed saturating arithmetic.  */
 
@@ -XXX,XX +XXX,XX @@ uint32_t HELPER(sel_flags)(uint32_t flags, uint32_t a, uint32_t b)
     return (a & mask) | (b & ~mask);
 }
 
-/* CRC helpers.
+/*
+ * CRC helpers.
  * The upper bytes of val (above the number specified by 'bytes') must have
  * been zeroed out by the caller.
  */
@@ -XXX,XX +XXX,XX @@ uint32_t HELPER(crc32c)(uint32_t acc, uint32_t val, uint32_t bytes)
     return crc32c(acc, buf, bytes) ^ 0xffffffff;
 }
 
-/* Return the exception level to which FP-disabled exceptions should
+/*
+ * Return the exception level to which FP-disabled exceptions should
  * be taken, or 0 if FP is enabled.
  */
 int fp_exception_el(CPUARMState *env, int cur_el)
@@ -XXX,XX +XXX,XX @@ int fp_exception_el(CPUARMState *env, int cur_el)
 #ifndef CONFIG_USER_ONLY
     uint64_t hcr_el2;
 
-    /* CPACR and the CPTR registers don't exist before v6, so FP is
+    /*
+     * CPACR and the CPTR registers don't exist before v6, so FP is
      * always accessible
      */
     if (!arm_feature(env, ARM_FEATURE_V6)) {
@@ -XXX,XX +XXX,XX @@ int fp_exception_el(CPUARMState *env, int cur_el)
 
     hcr_el2 = arm_hcr_el2_eff(env);
 
-    /* The CPACR controls traps to EL1, or PL1 if we're 32 bit:
+    /*
+     * The CPACR controls traps to EL1, or PL1 if we're 32 bit:
      * 0, 2 : trap EL0 and EL1/PL1 accesses
      * 1    : trap only EL0 accesses
      * 3    : trap no accesses
-- 
2.25.1

From: Fabiano Rosas <farosas@suse.de>

Fix the following:

ERROR: spaces required around that '|' (ctx:VxV)
ERROR: space required before the open parenthesis '('
ERROR: spaces required around that '+' (ctx:VxB)
ERROR: space prohibited between function name and open parenthesis '('

(the last two still have some occurrences in macros which I left
behind because it might impact readability)

Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Claudio Fontana <cfontana@suse.de>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Message-id: 20221213190537.511-3-farosas@suse.de
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/arm/helper.c | 42 +++++++++++++++++++++---------------------
 1 file changed, 21 insertions(+), 21 deletions(-)

diff --git a/target/arm/helper.c b/target/arm/helper.c
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -XXX,XX +XXX,XX @@ static void add_cpreg_to_list(gpointer key, gpointer opaque)
     uint32_t regidx = (uintptr_t)key;
     const ARMCPRegInfo *ri = get_arm_cp_reginfo(cpu->cp_regs, regidx);
 
-    if (!(ri->type & (ARM_CP_NO_RAW|ARM_CP_ALIAS))) {
+    if (!(ri->type & (ARM_CP_NO_RAW | ARM_CP_ALIAS))) {
         cpu->cpreg_indexes[cpu->cpreg_array_len] = cpreg_to_kvm_id(regidx);
         /* The value array need not be initialized at this point */
         cpu->cpreg_array_len++;
@@ -XXX,XX +XXX,XX @@ static void count_cpreg(gpointer key, gpointer opaque)
 
     ri = g_hash_table_lookup(cpu->cp_regs, key);
 
-    if (!(ri->type & (ARM_CP_NO_RAW|ARM_CP_ALIAS))) {
+    if (!(ri->type & (ARM_CP_NO_RAW | ARM_CP_ALIAS))) {
         cpu->cpreg_array_len++;
     }
 }
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo v6k_cp_reginfo[] = {
       .resetfn = arm_cp_reset_ignore },
     { .name = "TPIDRRO_EL0", .state = ARM_CP_STATE_AA64,
       .opc0 = 3, .opc1 = 3, .opc2 = 3, .crn = 13, .crm = 0,
-      .access = PL0_R|PL1_W,
+      .access = PL0_R | PL1_W,
       .fieldoffset = offsetof(CPUARMState, cp15.tpidrro_el[0]),
       .resetvalue = 0},
     { .name = "TPIDRURO", .cp = 15, .crn = 13, .crm = 0, .opc1 = 0, .opc2 = 3,
-      .access = PL0_R|PL1_W,
+      .access = PL0_R | PL1_W,
       .bank_fieldoffsets = { offsetoflow32(CPUARMState, cp15.tpidruro_s),
                              offsetoflow32(CPUARMState, cp15.tpidruro_ns) },
       .resetfn = arm_cp_reset_ignore },
@@ -XXX,XX +XXX,XX @@ static const ARMCPRegInfo cache_block_ops_cp_reginfo[] = {
       .resetvalue = 0 },
     /* The cache ops themselves: these all NOP for QEMU */
     { .name = "IICR", .cp = 15, .crm = 5, .opc1 = 0,
-      .access = PL1_W, .type = ARM_CP_NOP|ARM_CP_64BIT },
+      .access = PL1_W, .type = ARM_CP_NOP | ARM_CP_64BIT },
     { .name = "IDCR", .cp = 15, .crm = 6, .opc1 = 0,
-      .access = PL1_W, .type = ARM_CP_NOP|ARM_CP_64BIT },
+      .access = PL1_W, .type = ARM_CP_NOP | ARM_CP_64BIT },
     { .name = "CDCR", .cp = 15, .crm = 12, .opc1 = 0,
-      .access = PL0_W, .type = ARM_CP_NOP|ARM_CP_64BIT },
+      .access = PL0_W, .type = ARM_CP_NOP | ARM_CP_64BIT },
     { .name = "PIR", .cp = 15, .crm = 12, .opc1 = 1,
-      .access = PL0_W, .type = ARM_CP_NOP|ARM_CP_64BIT },
+      .access = PL0_W, .type = ARM_CP_NOP | ARM_CP_64BIT },
     { .name = "PDR", .cp = 15, .crm = 12, .opc1 = 2,
-      .access = PL0_W, .type = ARM_CP_NOP|ARM_CP_64BIT },
+      .access = PL0_W, .type = ARM_CP_NOP | ARM_CP_64BIT },
     { .name = "CIDCR", .cp = 15, .crm = 14, .opc1 = 0,
-      .access = PL1_W, .type = ARM_CP_NOP|ARM_CP_64BIT },
+      .access = PL1_W, .type = ARM_CP_NOP | ARM_CP_64BIT },
 };
 
 static const ARMCPRegInfo cache_test_clean_cp_reginfo[] = {
@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
             ARMCPRegInfo cbar = {
                 .name = "CBAR",
                 .cp = 15, .crn = 15, .crm = 0, .opc1 = 4, .opc2 = 0,
-                .access = PL1_R|PL3_W, .resetvalue = cpu->reset_cbar,
+                .access = PL1_R | PL3_W, .resetvalue = cpu->reset_cbar,
                 .fieldoffset = offsetof(CPUARMState,
                                         cp15.c15_config_base_address)
             };
@@ -XXX,XX +XXX,XX @@ static void switch_mode(CPUARMState *env, int mode)
         return;
 
     if (old_mode == ARM_CPU_MODE_FIQ) {
-        memcpy (env->fiq_regs, env->regs + 8, 5 * sizeof(uint32_t));
-        memcpy (env->regs + 8, env->usr_regs, 5 * sizeof(uint32_t));
+        memcpy(env->fiq_regs, env->regs + 8, 5 * sizeof(uint32_t));
+        memcpy(env->regs + 8, env->usr_regs, 5 * sizeof(uint32_t));
     } else if (mode == ARM_CPU_MODE_FIQ) {
-        memcpy (env->usr_regs, env->regs + 8, 5 * sizeof(uint32_t));
-        memcpy (env->regs + 8, env->fiq_regs, 5 * sizeof(uint32_t));
+        memcpy(env->usr_regs, env->regs + 8, 5 * sizeof(uint32_t));
+        memcpy(env->regs + 8, env->fiq_regs, 5 * sizeof(uint32_t));
     }
 
     i = bank_number(old_mode);
@@ -XXX,XX +XXX,XX @@ static inline uint8_t sub8_usat(uint8_t a, uint8_t b)
     RESULT(sum, n, 16); \
     if (sum >= 0) \
         ge |= 3 << (n * 2); \
-    } while(0)
+    } while (0)
 
 #define SARITH8(a, b, n, op) do { \
     int32_t sum; \
@@ -XXX,XX +XXX,XX @@ static inline uint8_t sub8_usat(uint8_t a, uint8_t b)
     RESULT(sum, n, 8); \
     if (sum >= 0) \
         ge |= 1 << n; \
-    } while(0)
+    } while (0)
 
 
 #define ADD16(a, b, n) SARITH16(a, b, n, +)
@@ -XXX,XX +XXX,XX @@ static inline uint8_t sub8_usat(uint8_t a, uint8_t b)
     RESULT(sum, n, 16); \
     if ((sum >> 16) == 1) \
         ge |= 3 << (n * 2); \
-    } while(0)
+    } while (0)
 
 #define ADD8(a, b, n) do { \
     uint32_t sum; \
@@ -XXX,XX +XXX,XX @@ static inline uint8_t sub8_usat(uint8_t a, uint8_t b)
     RESULT(sum, n, 8); \
     if ((sum >> 8) == 1) \
         ge |= 1 << n; \
-    } while(0)
+    } while (0)
 
 #define SUB16(a, b, n) do { \
     uint32_t sum; \
@@ -XXX,XX +XXX,XX @@ static inline uint8_t sub8_usat(uint8_t a, uint8_t b)
     RESULT(sum, n, 16); \
     if ((sum >> 16) == 0) \
         ge |= 3 << (n * 2); \
-    } while(0)
+    } while (0)
 
 #define SUB8(a, b, n) do { \
     uint32_t sum; \
@@ -XXX,XX +XXX,XX @@ static inline uint8_t sub8_usat(uint8_t a, uint8_t b)
     RESULT(sum, n, 8); \
     if ((sum >> 8) == 0) \
         ge |= 1 << n; \
-    } while(0)
+    } while (0)
 
 #define PFX u
 #define ARITH_GE
-- 
2.25.1

From: Fabiano Rosas <farosas@suse.de>

Fix this:
ERROR: braces {} are necessary for all arms of this statement

Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Claudio Fontana <cfontana@suse.de>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Message-id: 20221213190537.511-4-farosas@suse.de
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/arm/helper.c | 67 ++++++++++++++++++++++++++++-----------------
 1 file changed, 42 insertions(+), 25 deletions(-)

diff --git a/target/arm/helper.c b/target/arm/helper.c
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -XXX,XX +XXX,XX @@ void cpsr_write(CPUARMState *env, uint32_t val, uint32_t mask,
         env->CF = (val >> 29) & 1;
         env->VF = (val << 3) & 0x80000000;
     }
-    if (mask & CPSR_Q)
+    if (mask & CPSR_Q) {
         env->QF = ((val & CPSR_Q) != 0);
-    if (mask & CPSR_T)
+    }
+    if (mask & CPSR_T) {
         env->thumb = ((val & CPSR_T) != 0);
+    }
     if (mask & CPSR_IT_0_1) {
         env->condexec_bits &= ~3;
         env->condexec_bits |= (val >> 25) & 3;
@@ -XXX,XX +XXX,XX @@ static void switch_mode(CPUARMState *env, int mode)
     int i;
 
     old_mode = env->uncached_cpsr & CPSR_M;
-    if (mode == old_mode)
+    if (mode == old_mode) {
         return;
+    }
 
     if (old_mode == ARM_CPU_MODE_FIQ) {
         memcpy(env->fiq_regs, env->regs + 8, 5 * sizeof(uint32_t));
@@ -XXX,XX +XXX,XX @@ static void arm_cpu_do_interrupt_aarch32(CPUState *cs)
         new_mode = ARM_CPU_MODE_UND;
         addr = 0x04;
         mask = CPSR_I;
-        if (env->thumb)
+        if (env->thumb) {
             offset = 2;
-        else
+        } else {
             offset = 4;
+        }
         break;
     case EXCP_SWI:
         new_mode = ARM_CPU_MODE_SVC;
@@ -XXX,XX +XXX,XX @@ static inline uint16_t add16_sat(uint16_t a, uint16_t b)
 
     res = a + b;
     if (((res ^ a) & 0x8000) && !((a ^ b) & 0x8000)) {
-        if (a & 0x8000)
+        if (a & 0x8000) {
             res = 0x8000;
-        else
+        } else {
             res = 0x7fff;
+        }
     }
     return res;
 }
@@ -XXX,XX +XXX,XX @@ static inline uint8_t add8_sat(uint8_t a, uint8_t b)
 
     res = a + b;
     if (((res ^ a) & 0x80) && !((a ^ b) & 0x80)) {
-        if (a & 0x80)
+        if (a & 0x80) {
             res = 0x80;
-        else
+        } else {
             res = 0x7f;
+        }
     }
     return res;
 }
@@ -XXX,XX +XXX,XX @@ static inline uint16_t sub16_sat(uint16_t a, uint16_t b)
 
     res = a - b;
     if (((res ^ a) & 0x8000) && ((a ^ b) & 0x8000)) {
-        if (a & 0x8000)
+        if (a & 0x8000) {
             res = 0x8000;
-        else
+        } else {
             res = 0x7fff;
+        }
     }
     return res;
 }
@@ -XXX,XX +XXX,XX @@ static inline uint8_t sub8_sat(uint8_t a, uint8_t b)
 
     res = a - b;
     if (((res ^ a) & 0x80) && ((a ^ b) & 0x80)) {
-        if (a & 0x80)
+        if (a & 0x80) {
             res = 0x80;
-        else
+        } else {
             res = 0x7f;
+        }
     }
     return res;
 }
@@ -XXX,XX +XXX,XX @@ static inline uint16_t add16_usat(uint16_t a, uint16_t b)
 {
     uint16_t res;
     res = a + b;
-    if (res < a)
+    if (res < a) {
         res = 0xffff;
+    }
     return res;
 }
 
 static inline uint16_t sub16_usat(uint16_t a, uint16_t b)
 {
-    if (a > b)
+    if (a > b) {
         return a - b;
-    else
+    } else {
         return 0;
+    }
 }
 
 static inline uint8_t add8_usat(uint8_t a, uint8_t b)
 {
     uint8_t res;
     res = a + b;
-    if (res < a)
+    if (res < a) {
         res = 0xff;
+    }
     return res;
 }
 
 static inline uint8_t sub8_usat(uint8_t a, uint8_t b)
 {
-    if (a > b)
+    if (a > b) {
         return a - b;
-    else
+    } else {
         return 0;
+    }
 }
 
 #define ADD16(a, b, n) RESULT(add16_usat(a, b), n, 16);
@@ -XXX,XX +XXX,XX @@ static inline uint8_t sub8_usat(uint8_t a, uint8_t b)
 
 static inline uint8_t do_usad(uint8_t a, uint8_t b)
 {
-    if (a > b)
+    if (a > b) {
         return a - b;
-    else
+    } else {
         return b - a;
+    }
 }
 
 /* Unsigned sum of absolute byte differences.  */
@@ -XXX,XX +XXX,XX @@ uint32_t HELPER(sel_flags)(uint32_t flags, uint32_t a, uint32_t b)
     uint32_t mask;
 
     mask = 0;
-    if (flags & 1)
+    if (flags & 1) {
         mask |= 0xff;
-    if (flags & 2)
+    }
+    if (flags & 2) {
         mask |= 0xff00;
-    if (flags & 4)
+    }
+    if (flags & 4) {
         mask |= 0xff0000;
-    if (flags & 8)
+    }
+    if (flags & 8) {
         mask |= 0xff000000;
+    }
     return (a & mask) | (b & ~mask);
 }
 
-- 
2.25.1

From: Fabiano Rosas <farosas@suse.de>

Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Claudio Fontana <cfontana@suse.de>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Message-id: 20221213190537.511-5-farosas@suse.de
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/arm/m_helper.c | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/target/arm/m_helper.c b/target/arm/m_helper.c
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/m_helper.c
+++ b/target/arm/m_helper.c
@@ -XXX,XX +XXX,XX @@
  */
 
 #include "qemu/osdep.h"
-#include "qemu/units.h"
-#include "target/arm/idau.h"
-#include "trace.h"
 #include "cpu.h"
 #include "internals.h"
-#include "exec/gdbstub.h"
 #include "exec/helper-proto.h"
-#include "qemu/host-utils.h"
 #include "qemu/main-loop.h"
 #include "qemu/bitops.h"
-#include "qemu/crc32c.h"
-#include "qemu/qemu-print.h"
 #include "qemu/log.h"
 #include "exec/exec-all.h"
-#include <zlib.h> /* For crc32 */
-#include "semihosting/semihost.h"
-#include "sysemu/cpus.h"
-#include "sysemu/kvm.h"
-#include "qemu/range.h"
-#include "qapi/qapi-commands-machine-target.h"
-#include "qapi/error.h"
-#include "qemu/guest-random.h"
 #ifdef CONFIG_TCG
-#include "arm_ldst.h"
 #include "exec/cpu_ldst.h"
 #include "semihosting/common-semi.h"
 #endif
-- 
2.25.1

From: Fabiano Rosas <farosas@suse.de>

Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Claudio Fontana <cfontana@suse.de>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Message-id: 20221213190537.511-6-farosas@suse.de
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/arm/helper.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/target/arm/helper.c b/target/arm/helper.c
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -XXX,XX +XXX,XX @@
  */
 
 #include "qemu/osdep.h"
-#include "qemu/units.h"
 #include "qemu/log.h"
 #include "trace.h"
 #include "cpu.h"
 #include "internals.h"
 #include "exec/helper-proto.h"
-#include "qemu/host-utils.h"
 #include "qemu/main-loop.h"
 #include "qemu/timer.h"
 #include "qemu/bitops.h"
@@ -XXX,XX +XXX,XX @@
 #include "exec/exec-all.h"
 #include <zlib.h> /* For crc32 */
 #include "hw/irq.h"
-#include "semihosting/semihost.h"
-#include "sysemu/cpus.h"
 #include "sysemu/cpu-timers.h"
 #include "sysemu/kvm.h"
-#include "qemu/range.h"
 #include "qapi/qapi-commands-machine-target.h"
 #include "qapi/error.h"
 #include "qemu/guest-random.h"
 #ifdef CONFIG_TCG
-#include "arm_ldst.h"
-#include "exec/cpu_ldst.h"
 #include "semihosting/common-semi.h"
 #endif
 #include "cpregs.h"
-- 
2.25.1

From: Claudio Fontana <cfontana@suse.de>

Remove some unused headers.

Signed-off-by: Claudio Fontana <cfontana@suse.de>
Acked-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Claudio Fontana <cfontana@suse.de>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Message-id: 20221213190537.511-7-farosas@suse.de
[added back some includes that are still needed at this point]
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/arm/cpu.c   | 1 -
 target/arm/cpu64.c | 6 ------
 2 files changed, 7 deletions(-)

diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -XXX,XX +XXX,XX @@
 #include "target/arm/idau.h"
 #include "qemu/module.h"
 #include "qapi/error.h"
-#include "qapi/visitor.h"
 #include "cpu.h"
 #ifdef CONFIG_TCG
 #include "hw/core/tcg-cpu-ops.h"
diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/cpu64.c
+++ b/target/arm/cpu64.c
@@ -XXX,XX +XXX,XX @@
 #include "qemu/osdep.h"
 #include "qapi/error.h"
 #include "cpu.h"
-#ifdef CONFIG_TCG
-#include "hw/core/tcg-cpu-ops.h"
-#endif /* CONFIG_TCG */
 #include "qemu/module.h"
-#if !defined(CONFIG_USER_ONLY)
-#include "hw/loader.h"
-#endif
 #include "sysemu/kvm.h"
 #include "sysemu/hvf.h"
 #include "kvm_arm.h"
-- 
2.25.1

From: Philippe Mathieu-Daudé <philmd@linaro.org>

The pointed MouseTransformInfo structure is accessed read-only.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20221220142520.24094-2-philmd@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 include/hw/input/tsc2xxx.h | 4 ++--
 hw/input/tsc2005.c         | 2 +-
 hw/input/tsc210x.c         | 3 +--
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/include/hw/input/tsc2xxx.h b/include/hw/input/tsc2xxx.h
index XXXXXXX..XXXXXXX 100644
--- a/include/hw/input/tsc2xxx.h
+++ b/include/hw/input/tsc2xxx.h
@@ -XXX,XX +XXX,XX @@ uWireSlave *tsc2102_init(qemu_irq pint);
 uWireSlave *tsc2301_init(qemu_irq penirq, qemu_irq kbirq, qemu_irq dav);
 I2SCodec *tsc210x_codec(uWireSlave *chip);
 uint32_t tsc210x_txrx(void *opaque, uint32_t value, int len);
-void tsc210x_set_transform(uWireSlave *chip, MouseTransformInfo *info);
+void tsc210x_set_transform(uWireSlave *chip, const MouseTransformInfo *info);
 void tsc210x_key_event(uWireSlave *chip, int key, int down);
 
 /* tsc2005.c */
 void *tsc2005_init(qemu_irq pintdav);
 uint32_t tsc2005_txrx(void *opaque, uint32_t value, int len);
-void tsc2005_set_transform(void *opaque, MouseTransformInfo *info);
+void tsc2005_set_transform(void *opaque, const MouseTransformInfo *info);
 
 #endif
diff --git a/hw/input/tsc2005.c b/hw/input/tsc2005.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/input/tsc2005.c
+++ b/hw/input/tsc2005.c
@@ -XXX,XX +XXX,XX @@ void *tsc2005_init(qemu_irq pintdav)
  * from the touchscreen.  Assuming 12-bit precision was used during
  * tslib calibration.
  */
-void tsc2005_set_transform(void *opaque, MouseTransformInfo *info)
+void tsc2005_set_transform(void *opaque, const MouseTransformInfo *info)
 {
     TSC2005State *s = (TSC2005State *) opaque;
 
diff --git a/hw/input/tsc210x.c b/hw/input/tsc210x.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/input/tsc210x.c
+++ b/hw/input/tsc210x.c
@@ -XXX,XX +XXX,XX @@ I2SCodec *tsc210x_codec(uWireSlave *chip)
  * from the touchscreen.  Assuming 12-bit precision was used during
  * tslib calibration.
  */
-void tsc210x_set_transform(uWireSlave *chip,
-                MouseTransformInfo *info)
+void tsc210x_set_transform(uWireSlave *chip, const MouseTransformInfo *info)
 {
     TSC210xState *s = (TSC210xState *) chip->opaque;
 #if 0
-- 
2.25.1

From: Philippe Mathieu-Daudé <philmd@linaro.org>

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20221220142520.24094-3-philmd@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/arm/nseries.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/arm/nseries.c
+++ b/hw/arm/nseries.c
@@ -XXX,XX +XXX,XX @@ static void n8x0_i2c_setup(struct n800_s *s)
 }
 
 /* Touchscreen and keypad controller */
-static MouseTransformInfo n800_pointercal = {
+static const MouseTransformInfo n800_pointercal = {
     .x = 800,
     .y = 480,
     .a = { 14560, -68, -3455208, -39, -9621, 35152972, 65536 },
 };
 
-static MouseTransformInfo n810_pointercal = {
+static const MouseTransformInfo n810_pointercal = {
     .x = 800,
     .y = 480,
     .a = { 15041, 148, -4731056, 171, -10238, 35933380, 65536 },
@@ -XXX,XX +XXX,XX @@ static void n810_key_event(void *opaque, int keycode)
 
 #define M	0
 
-static int n810_keys[0x80] = {
+static const int n810_keys[0x80] = {
     [0x01] = 16,	/* Q */
     [0x02] = 37,	/* K */
     [0x03] = 24,	/* O */
@@ -XXX,XX +XXX,XX @@ static void n8x0_usb_setup(struct n800_s *s)
 /* Setup done before the main bootloader starts by some early setup code
  * - used when we want to run the main bootloader in emulation.  This
  * isn't documented.  */
-static uint32_t n800_pinout[104] = {
+static const uint32_t n800_pinout[104] = {
     0x080f00d8, 0x00d40808, 0x03080808, 0x080800d0,
     0x00dc0808, 0x0b0f0f00, 0x080800b4, 0x00c00808,
     0x08080808, 0x180800c4, 0x00b80000, 0x08080808,
@@ -XXX,XX +XXX,XX @@ static void n8x0_boot_init(void *opaque)
 #define OMAP_TAG_CBUS		0x4e03
 #define OMAP_TAG_EM_ASIC_BB5	0x4e04
 
-static struct omap_gpiosw_info_s {
+static const struct omap_gpiosw_info_s {
     const char *name;
     int line;
     int type;
@@ -XXX,XX +XXX,XX @@ static struct omap_gpiosw_info_s {
     { NULL }
 };
 
-static struct omap_partition_info_s {
+static const struct omap_partition_info_s {
     uint32_t offset;
     uint32_t size;
     int mask;
@@ -XXX,XX +XXX,XX @@ static struct omap_partition_info_s {
     { 0, 0, 0, NULL }
 };
 
-static uint8_t n8x0_bd_addr[6] = { N8X0_BD_ADDR };
+static const uint8_t n8x0_bd_addr[6] = { N8X0_BD_ADDR };
 
 static int n8x0_atag_setup(void *p, int model)
 {
     uint8_t *b;
     uint16_t *w;
     uint32_t *l;
-    struct omap_gpiosw_info_s *gpiosw;
-    struct omap_partition_info_s *partition;
+    const struct omap_gpiosw_info_s *gpiosw;
+    const struct omap_partition_info_s *partition;
     const char *tag;
 
     w = p;
-- 
2.25.1

From: Philippe Mathieu-Daudé <philmd@linaro.org>

Silent when compiling with -Wextra:

../hw/arm/nseries.c:1081:12: warning: missing field 'line' initializer [-Wmissing-field-initializers]
      { NULL }
             ^

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-id: 20221220142520.24094-4-philmd@linaro.org
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/arm/nseries.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/arm/nseries.c
+++ b/hw/arm/nseries.c
@@ -XXX,XX +XXX,XX @@ static const struct omap_gpiosw_info_s {
         "headphone", N8X0_HEADPHONE_GPIO,
         OMAP_GPIOSW_TYPE_CONNECTION | OMAP_GPIOSW_INVERTED,
     },
-    { NULL }
+    { /* end of list */ }
 }, n810_gpiosw_info[] = {
     {
         "gps_reset", N810_GPS_RESET_GPIO,
@@ -XXX,XX +XXX,XX @@ static const struct omap_gpiosw_info_s {
         "slide", N810_SLIDE_GPIO,
         OMAP_GPIOSW_TYPE_COVER | OMAP_GPIOSW_INVERTED,
     },
-    { NULL }
+    { /* end of list */ }
 };
 
 static const struct omap_partition_info_s {
@@ -XXX,XX +XXX,XX @@ static const struct omap_partition_info_s {
     { 0x00080000, 0x00200000, 0x0, "kernel" },
     { 0x00280000, 0x00200000, 0x3, "initfs" },
     { 0x00480000, 0x0fb80000, 0x3, "rootfs" },
-
-    { 0, 0, 0, NULL }
+    { /* end of list */ }
 }, n810_part_info[] = {
     { 0x00000000, 0x00020000, 0x3, "bootloader" },
     { 0x00020000, 0x00060000, 0x0, "config" },
     { 0x00080000, 0x00220000, 0x0, "kernel" },
     { 0x002a0000, 0x00400000, 0x0, "initfs" },
     { 0x006a0000, 0x0f960000, 0x0, "rootfs" },
-
-    { 0, 0, 0, NULL }
+    { /* end of list */ }
 };
 
 static const uint8_t n8x0_bd_addr[6] = { N8X0_BD_ADDR };
-- 
2.25.1

From: Zhuojia Shen <chaosdefinition@hotmail.com>

In CPUID registers exposed to userspace, some registers were missing
and some fields were not exposed.  This patch aligns exposed ID
registers and their fields with what the upstream kernel currently
exposes.

Specifically, the following new ID registers/fields are exposed to
userspace:

ID_AA64PFR1_EL1.BT:       bits 3-0
ID_AA64PFR1_EL1.MTE:      bits 11-8
ID_AA64PFR1_EL1.SME:      bits 27-24

ID_AA64ZFR0_EL1.SVEver:   bits 3-0
ID_AA64ZFR0_EL1.AES:      bits 7-4
ID_AA64ZFR0_EL1.BitPerm:  bits 19-16
ID_AA64ZFR0_EL1.BF16:     bits 23-20
ID_AA64ZFR0_EL1.SHA3:     bits 35-32
ID_AA64ZFR0_EL1.SM4:      bits 43-40
ID_AA64ZFR0_EL1.I8MM:     bits 47-44
ID_AA64ZFR0_EL1.F32MM:    bits 55-52
ID_AA64ZFR0_EL1.F64MM:    bits 59-56

ID_AA64SMFR0_EL1.F32F32:  bit 32
ID_AA64SMFR0_EL1.B16F32:  bit 34
ID_AA64SMFR0_EL1.F16F32:  bit 35
ID_AA64SMFR0_EL1.I8I32:   bits 39-36
ID_AA64SMFR0_EL1.F64F64:  bit 48
ID_AA64SMFR0_EL1.I16I64:  bits 55-52
ID_AA64SMFR0_EL1.FA64:    bit 63

ID_AA64MMFR0_EL1.ECV:     bits 63-60

ID_AA64MMFR1_EL1.AFP:     bits 47-44

ID_AA64MMFR2_EL1.AT:      bits 35-32

ID_AA64ISAR0_EL1.RNDR:    bits 63-60

ID_AA64ISAR1_EL1.FRINTTS: bits 35-32
ID_AA64ISAR1_EL1.BF16:    bits 47-44
ID_AA64ISAR1_EL1.DGH:     bits 51-48
ID_AA64ISAR1_EL1.I8MM:    bits 55-52

ID_AA64ISAR2_EL1.WFxT:    bits 3-0
ID_AA64ISAR2_EL1.RPRES:   bits 7-4
ID_AA64ISAR2_EL1.GPA3:    bits 11-8
ID_AA64ISAR2_EL1.APA3:    bits 15-12

The code is also refactored to use symbolic names for ID register fields
for better readability and maintainability.

The test case in tests/tcg/aarch64/sysregs.c is also updated to match
the intended behavior.

Signed-off-by: Zhuojia Shen <chaosdefinition@hotmail.com>
Message-id: DS7PR12MB6309FB585E10772928F14271ACE79@DS7PR12MB6309.namprd12.prod.outlook.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
[PMM: use Sn_n_Cn_Cn_n syntax to work with older assemblers
that don't recognize id_aa64isar2_el1 and id_aa64mmfr2_el1]
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target/arm/helper.c               | 96 +++++++++++++++++++++++++------
 tests/tcg/aarch64/sysregs.c       | 24 ++++++--
 tests/tcg/aarch64/Makefile.target |  7 ++-
 3 files changed, 103 insertions(+), 24 deletions(-)

diff --git a/target/arm/helper.c b/target/arm/helper.c
index XXXXXXX..XXXXXXX 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
 #ifdef CONFIG_USER_ONLY
         static const ARMCPRegUserSpaceInfo v8_user_idregs[] = {
             { .name = "ID_AA64PFR0_EL1",
-              .exported_bits = 0x000f000f00ff0000,
-              .fixed_bits    = 0x0000000000000011 },
+              .exported_bits = R_ID_AA64PFR0_FP_MASK |
+                               R_ID_AA64PFR0_ADVSIMD_MASK |
+                               R_ID_AA64PFR0_SVE_MASK |
+                               R_ID_AA64PFR0_DIT_MASK,
+              .fixed_bits = (0x1u << R_ID_AA64PFR0_EL0_SHIFT) |
+                            (0x1u << R_ID_AA64PFR0_EL1_SHIFT) },
             { .name = "ID_AA64PFR1_EL1",
-              .exported_bits = 0x00000000000000f0 },
+              .exported_bits = R_ID_AA64PFR1_BT_MASK |
+                               R_ID_AA64PFR1_SSBS_MASK |
+                               R_ID_AA64PFR1_MTE_MASK |
+                               R_ID_AA64PFR1_SME_MASK },
             { .name = "ID_AA64PFR*_EL1_RESERVED",
-              .is_glob = true                     },
-            { .name = "ID_AA64ZFR0_EL1"           },
+              .is_glob = true },
+            { .name = "ID_AA64ZFR0_EL1",
+              .exported_bits = R_ID_AA64ZFR0_SVEVER_MASK |
+                               R_ID_AA64ZFR0_AES_MASK |
+                               R_ID_AA64ZFR0_BITPERM_MASK |
+                               R_ID_AA64ZFR0_BFLOAT16_MASK |
+                               R_ID_AA64ZFR0_SHA3_MASK |
+                               R_ID_AA64ZFR0_SM4_MASK |
+                               R_ID_AA64ZFR0_I8MM_MASK |
+                               R_ID_AA64ZFR0_F32MM_MASK |
+                               R_ID_AA64ZFR0_F64MM_MASK },
+            { .name = "ID_AA64SMFR0_EL1",
+              .exported_bits = R_ID_AA64SMFR0_F32F32_MASK |
+                               R_ID_AA64SMFR0_B16F32_MASK |
+                               R_ID_AA64SMFR0_F16F32_MASK |
+                               R_ID_AA64SMFR0_I8I32_MASK |
+                               R_ID_AA64SMFR0_F64F64_MASK |
+                               R_ID_AA64SMFR0_I16I64_MASK |
+                               R_ID_AA64SMFR0_FA64_MASK },
             { .name = "ID_AA64MMFR0_EL1",
-              .fixed_bits    = 0x00000000ff000000 },
-            { .name = "ID_AA64MMFR1_EL1"          },
+              .exported_bits = R_ID_AA64MMFR0_ECV_MASK,
+              .fixed_bits = (0xfu << R_ID_AA64MMFR0_TGRAN64_SHIFT) |
+                            (0xfu << R_ID_AA64MMFR0_TGRAN4_SHIFT) },
+            { .name = "ID_AA64MMFR1_EL1",
+              .exported_bits = R_ID_AA64MMFR1_AFP_MASK },
+            { .name = "ID_AA64MMFR2_EL1",
+              .exported_bits = R_ID_AA64MMFR2_AT_MASK },
             { .name = "ID_AA64MMFR*_EL1_RESERVED",
-              .is_glob = true                     },
+              .is_glob = true },
             { .name = "ID_AA64DFR0_EL1",
-              .fixed_bits    = 0x0000000000000006 },
-            { .name = "ID_AA64DFR1_EL1"           },
+              .fixed_bits = (0x6u << R_ID_AA64DFR0_DEBUGVER_SHIFT) },
+            { .name = "ID_AA64DFR1_EL1" },
             { .name = "ID_AA64DFR*_EL1_RESERVED",
-              .is_glob = true                     },
+              .is_glob = true },
             { .name = "ID_AA64AFR*",
-              .is_glob = true                     },
+              .is_glob = true },
             { .name = "ID_AA64ISAR0_EL1",
-              .exported_bits = 0x00fffffff0fffff0 },
+              .exported_bits = R_ID_AA64ISAR0_AES_MASK |
+                               R_ID_AA64ISAR0_SHA1_MASK |
+                               R_ID_AA64ISAR0_SHA2_MASK |
+                               R_ID_AA64ISAR0_CRC32_MASK |
+                               R_ID_AA64ISAR0_ATOMIC_MASK |
+                               R_ID_AA64ISAR0_RDM_MASK |
+                               R_ID_AA64ISAR0_SHA3_MASK |
+                               R_ID_AA64ISAR0_SM3_MASK |
+                               R_ID_AA64ISAR0_SM4_MASK |
+                               R_ID_AA64ISAR0_DP_MASK |
+                               R_ID_AA64ISAR0_FHM_MASK |
+                               R_ID_AA64ISAR0_TS_MASK |
+                               R_ID_AA64ISAR0_RNDR_MASK },
             { .name = "ID_AA64ISAR1_EL1",
-              .exported_bits = 0x000000f0ffffffff },
+              .exported_bits = R_ID_AA64ISAR1_DPB_MASK |
+                               R_ID_AA64ISAR1_APA_MASK |
+                               R_ID_AA64ISAR1_API_MASK |
+                               R_ID_AA64ISAR1_JSCVT_MASK |
+                               R_ID_AA64ISAR1_FCMA_MASK |
+                               R_ID_AA64ISAR1_LRCPC_MASK |
+                               R_ID_AA64ISAR1_GPA_MASK |
+                               R_ID_AA64ISAR1_GPI_MASK |
+                               R_ID_AA64ISAR1_FRINTTS_MASK |
+                               R_ID_AA64ISAR1_SB_MASK |
+                               R_ID_AA64ISAR1_BF16_MASK |
+                               R_ID_AA64ISAR1_DGH_MASK |
+                               R_ID_AA64ISAR1_I8MM_MASK },
+            { .name = "ID_AA64ISAR2_EL1",
+              .exported_bits = R_ID_AA64ISAR2_WFXT_MASK |
+                               R_ID_AA64ISAR2_RPRES_MASK |
+                               R_ID_AA64ISAR2_GPA3_MASK |
+                               R_ID_AA64ISAR2_APA3_MASK },
             { .name = "ID_AA64ISAR*_EL1_RESERVED",
-              .is_glob = true                     },
+              .is_glob = true },
         };
         modify_arm_cp_regs(v8_idregs, v8_user_idregs);
 #endif
@@ -XXX,XX +XXX,XX @@ void register_cp_regs_for_features(ARMCPU *cpu)
 #ifdef CONFIG_USER_ONLY
         static const ARMCPRegUserSpaceInfo id_v8_user_midr_cp_reginfo[] = {
             { .name = "MIDR_EL1",
-              .exported_bits = 0x00000000ffffffff },
-            { .name = "REVIDR_EL1"                },
+              .exported_bits = R_MIDR_EL1_REVISION_MASK |
+                               R_MIDR_EL1_PARTNUM_MASK |
+                               R_MIDR_EL1_ARCHITECTURE_MASK |
+                               R_MIDR_EL1_VARIANT_MASK |
+                               R_MIDR_EL1_IMPLEMENTER_MASK },
+            { .name = "REVIDR_EL1" },
         };
         modify_arm_cp_regs(id_v8_midr_cp_reginfo, id_v8_user_midr_cp_reginfo);
 #endif
diff --git a/tests/tcg/aarch64/sysregs.c b/tests/tcg/aarch64/sysregs.c
index XXXXXXX..XXXXXXX 100644
--- a/tests/tcg/aarch64/sysregs.c
+++ b/tests/tcg/aarch64/sysregs.c
@@ -XXX,XX +XXX,XX @@
 #define HWCAP_CPUID (1 << 11)
 #endif
 
+/*
+ * Older assemblers don't recognize newer system register names,
+ * but we can still access them by the Sn_n_Cn_Cn_n syntax.
+ */
+#define SYS_ID_AA64ISAR2_EL1 S3_0_C0_C6_2
+#define SYS_ID_AA64MMFR2_EL1 S3_0_C0_C7_2
+
 int failed_bit_count;
 
 /* Read and print system register `id' value */
@@ -XXX,XX +XXX,XX @@ int main(void)
      * minimum valid fields - for the purposes of this check allowed
      * to have non-zero values.
      */
-    get_cpu_reg_check_mask(id_aa64isar0_el1, _m(00ff,ffff,f0ff,fff0));
-    get_cpu_reg_check_mask(id_aa64isar1_el1, _m(0000,00f0,ffff,ffff));
+    get_cpu_reg_check_mask(id_aa64isar0_el1, _m(f0ff,ffff,f0ff,fff0));
+    get_cpu_reg_check_mask(id_aa64isar1_el1, _m(00ff,f0ff,ffff,ffff));
+    get_cpu_reg_check_mask(SYS_ID_AA64ISAR2_EL1, _m(0000,0000,0000,ffff));
     /* TGran4 & TGran64 as pegged to -1 */
-    get_cpu_reg_check_mask(id_aa64mmfr0_el1, _m(0000,0000,ff00,0000));
-    get_cpu_reg_check_zero(id_aa64mmfr1_el1);
+    get_cpu_reg_check_mask(id_aa64mmfr0_el1, _m(f000,0000,ff00,0000));
+    get_cpu_reg_check_mask(id_aa64mmfr1_el1, _m(0000,f000,0000,0000));
+    get_cpu_reg_check_mask(SYS_ID_AA64MMFR2_EL1, _m(0000,000f,0000,0000));
     /* EL1/EL0 reported as AA64 only */
     get_cpu_reg_check_mask(id_aa64pfr0_el1,  _m(000f,000f,00ff,0011));
-    get_cpu_reg_check_mask(id_aa64pfr1_el1,  _m(0000,0000,0000,00f0));
+    get_cpu_reg_check_mask(id_aa64pfr1_el1,  _m(0000,0000,0f00,0fff));
     /* all hidden, DebugVer fixed to 0x6 (ARMv8 debug architecture) */
     get_cpu_reg_check_mask(id_aa64dfr0_el1,  _m(0000,0000,0000,0006));
     get_cpu_reg_check_zero(id_aa64dfr1_el1);
-    get_cpu_reg_check_zero(id_aa64zfr0_el1);
+    get_cpu_reg_check_mask(id_aa64zfr0_el1,  _m(0ff0,ff0f,00ff,00ff));
+#ifdef HAS_ARMV9_SME
+    get_cpu_reg_check_mask(id_aa64smfr0_el1, _m(80f1,00fd,0000,0000));
+#endif
 
     get_cpu_reg_check_zero(id_aa64afr0_el1);
     get_cpu_reg_check_zero(id_aa64afr1_el1);
diff --git a/tests/tcg/aarch64/Makefile.target b/tests/tcg/aarch64/Makefile.target
index XXXXXXX..XXXXXXX 100644
--- a/tests/tcg/aarch64/Makefile.target
+++ b/tests/tcg/aarch64/Makefile.target
@@ -XXX,XX +XXX,XX @@ config-cc.mak: Makefile
 	    $(call cc-option,-march=armv8.1-a+sve2,         CROSS_CC_HAS_SVE2); \
 	    $(call cc-option,-march=armv8.3-a,              CROSS_CC_HAS_ARMV8_3); \
 	    $(call cc-option,-mbranch-protection=standard,  CROSS_CC_HAS_ARMV8_BTI); \
-	    $(call cc-option,-march=armv8.5-a+memtag,       CROSS_CC_HAS_ARMV8_MTE)) 3> config-cc.mak
+	    $(call cc-option,-march=armv8.5-a+memtag,       CROSS_CC_HAS_ARMV8_MTE); \
+	    $(call cc-option,-march=armv9-a+sme,            CROSS_CC_HAS_ARMV9_SME)) 3> config-cc.mak
 -include config-cc.mak
 
 # Pauth Tests
@@ -XXX,XX +XXX,XX @@ endif
 ifneq ($(CROSS_CC_HAS_SVE),)
 # System Registers Tests
 AARCH64_TESTS += sysregs
+ifneq ($(CROSS_CC_HAS_ARMV9_SME),)
+sysregs: CFLAGS+=-march=armv9-a+sme -DHAS_ARMV9_SME
+else
 sysregs: CFLAGS+=-march=armv8.1-a+sve
+endif
 
 # SVE ioctl test
 AARCH64_TESTS += sve-ioctls
-- 
2.25.1

From: Philippe Mathieu-Daudé <philmd@linaro.org>

This function is not used anywhere outside this file,
so we can make the function "static void".

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Message-id: 20221216214924.4711-2-philmd@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 include/hw/arm/smmu-common.h | 3 ---
 hw/arm/smmu-common.c         | 2 +-
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/include/hw/arm/smmu-common.h b/include/hw/arm/smmu-common.h
index XXXXXXX..XXXXXXX 100644
--- a/include/hw/arm/smmu-common.h
+++ b/include/hw/arm/smmu-common.h
@@ -XXX,XX +XXX,XX @@ void smmu_iotlb_inv_iova(SMMUState *s, int asid, dma_addr_t iova,
 /* Unmap the range of all the notifiers registered to any IOMMU mr */
 void smmu_inv_notifiers_all(SMMUState *s);
 
-/* Unmap the range of all the notifiers registered to @mr */
-void smmu_inv_notifiers_mr(IOMMUMemoryRegion *mr);
-
 #endif /* HW_ARM_SMMU_COMMON_H */
diff --git a/hw/arm/smmu-common.c b/hw/arm/smmu-common.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/arm/smmu-common.c
+++ b/hw/arm/smmu-common.c
@@ -XXX,XX +XXX,XX @@ static void smmu_unmap_notifier_range(IOMMUNotifier *n)
 }
 
 /* Unmap all notifiers attached to @mr */
-inline void smmu_inv_notifiers_mr(IOMMUMemoryRegion *mr)
+static void smmu_inv_notifiers_mr(IOMMUMemoryRegion *mr)
 {
     IOMMUNotifier *n;
 
-- 
2.25.1

From: Philippe Mathieu-Daudé <philmd@linaro.org>

When using Clang ("Apple clang version 14.0.0 (clang-1400.0.29.202)")
and building with -Wall we get:

hw/arm/smmu-common.c:173:33: warning: static function 'smmu_hash_remove_by_asid_iova' is used in an inline function with external linkage [-Wstatic-in-inline]
  hw/arm/smmu-common.h:170:1: note: use 'static' to give inline function 'smmu_iotlb_inv_iova' internal linkage
    void smmu_iotlb_inv_iova(SMMUState *s, int asid, dma_addr_t iova,
    ^
    static

None of our code base require / use inlined functions with external
linkage. Some places use internal inlining in the hot path. These
two functions are certainly not in any hot path and don't justify
any inlining, so these are likely oversights rather than intentional.

Reported-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Message-id: 20221216214924.4711-3-philmd@linaro.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/arm/smmu-common.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/hw/arm/smmu-common.c b/hw/arm/smmu-common.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/arm/smmu-common.c
+++ b/hw/arm/smmu-common.c
@@ -XXX,XX +XXX,XX @@ void smmu_iotlb_insert(SMMUState *bs, SMMUTransCfg *cfg, SMMUTLBEntry *new)
     g_hash_table_insert(bs->iotlb, key, new);
 }
 
-inline void smmu_iotlb_inv_all(SMMUState *s)
+void smmu_iotlb_inv_all(SMMUState *s)
 {
     trace_smmu_iotlb_inv_all();
     g_hash_table_remove_all(s->iotlb);
@@ -XXX,XX +XXX,XX @@ static gboolean smmu_hash_remove_by_asid_iova(gpointer key, gpointer value,
            ((entry->iova & ~info->mask) == info->iova);
 }
 
-inline void
-smmu_iotlb_inv_iova(SMMUState *s, int asid, dma_addr_t iova,
-                    uint8_t tg, uint64_t num_pages, uint8_t ttl)
+void smmu_iotlb_inv_iova(SMMUState *s, int asid, dma_addr_t iova,
+                         uint8_t tg, uint64_t num_pages, uint8_t ttl)
 {
     /* if tg is not set we use 4KB range invalidation */
     uint8_t granule = tg ? tg * 2 + 10 : 12;
@@ -XXX,XX +XXX,XX @@ smmu_iotlb_inv_iova(SMMUState *s, int asid, dma_addr_t iova,
                                 &info);
 }
 
-inline void smmu_iotlb_inv_asid(SMMUState *s, uint16_t asid)
+void smmu_iotlb_inv_asid(SMMUState *s, uint16_t asid)
 {
     trace_smmu_iotlb_inv_asid(asid);
     g_hash_table_foreach_remove(s->iotlb, smmu_hash_remove_by_asid, &asid);
@@ -XXX,XX +XXX,XX @@ error:
  *
  * return 0 on success
  */
-inline int smmu_ptw(SMMUTransCfg *cfg, dma_addr_t iova, IOMMUAccessFlags perm,
-                    SMMUTLBEntry *tlbe, SMMUPTWEventInfo *info)
+int smmu_ptw(SMMUTransCfg *cfg, dma_addr_t iova, IOMMUAccessFlags perm,
+             SMMUTLBEntry *tlbe, SMMUPTWEventInfo *info)
 {
     if (!cfg->aa64) {
         /*
-- 
2.25.1

From: Jean-Christophe Dubois <jcd@tribudubois.net>

So far the GPT timers were unable to raise IRQs to the processor.

Signed-off-by: Jean-Christophe Dubois <jcd@tribudubois.net>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 include/hw/arm/fsl-imx7.h |  5 +++++
 hw/arm/fsl-imx7.c         | 10 ++++++++++
 2 files changed, 15 insertions(+)

From: Jean-Christophe Dubois <jcd@tribudubois.net>

CCM derived clocks will have to be added later.

Signed-off-by: Jean-Christophe Dubois <jcd@tribudubois.net>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/misc/imx7_ccm.c | 49 +++++++++++++++++++++++++++++++++++++---------
 1 file changed, 40 insertions(+), 9 deletions(-)

diff --git a/hw/misc/imx7_ccm.c b/hw/misc/imx7_ccm.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/misc/imx7_ccm.c
+++ b/hw/misc/imx7_ccm.c
@@ -XXX,XX +XXX,XX @@
 #include "hw/misc/imx7_ccm.h"
 #include "migration/vmstate.h"
 
+#include "trace.h"
+
+#define CKIH_FREQ 24000000 /* 24MHz crystal input */
+
 static void imx7_analog_reset(DeviceState *dev)
 {
     IMX7AnalogState *s = IMX7_ANALOG(dev);
@@ -XXX,XX +XXX,XX @@ static const VMStateDescription vmstate_imx7_ccm = {
 static uint32_t imx7_ccm_get_clock_frequency(IMXCCMState *dev, IMXClk clock)
 {
     /*
-     * This function is "consumed" by GPT emulation code, however on
-     * i.MX7 each GPT block can have their own clock root. This means
-     * that this functions needs somehow to know requester's identity
-     * and the way to pass it: be it via additional IMXClk constants
-     * or by adding another argument to this method needs to be
-     * figured out
+     * This function is "consumed" by GPT emulation code. Some clocks
+     * have fixed frequencies and we can provide requested frequency
+     * easily. However for CCM provided clocks (like IPG) each GPT
+     * timer can have its own clock root.
+     * This means we need additionnal information when calling this
+     * function to know the requester's identity.
      */
-    qemu_log_mask(LOG_GUEST_ERROR, "[%s]%s: Not implemented\n",
-                  TYPE_IMX7_CCM, __func__);
-    return 0;
+    uint32_t freq = 0;
+
+    switch (clock) {
+    case CLK_NONE:
+        break;
+    case CLK_32k:
+        freq = CKIL_FREQ;
+        break;
+    case CLK_HIGH:
+        freq = CKIH_FREQ;
+        break;
+    case CLK_IPG:
+    case CLK_IPG_HIGH:
+        /*
+         * For now we don't have a way to figure out the device this
+         * function is called for. Until then the IPG derived clocks
+         * are left unimplemented.
+         */
+        qemu_log_mask(LOG_GUEST_ERROR, "[%s]%s: Clock %d Not implemented\n",
+                      TYPE_IMX7_CCM, __func__, clock);
+        break;
+    default:
+        qemu_log_mask(LOG_GUEST_ERROR, "[%s]%s: unsupported clock %d\n",
+                      TYPE_IMX7_CCM, __func__, clock);
+        break;
+    }
+
+    trace_ccm_clock_freq(clock, freq);
+
+    return freq;
 }
 
 static void imx7_ccm_class_init(ObjectClass *klass, void *data)
-- 
2.25.1

From: Jean-Christophe Dubois <jcd@tribudubois.net>

The i.MX6UL doesn't support CLK_HIGH ou CLK_HIGH_DIV clock source.

Signed-off-by: Jean-Christophe Dubois <jcd@tribudubois.net>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 include/hw/timer/imx_gpt.h |  1 +
 hw/arm/fsl-imx6ul.c        |  2 +-
 hw/misc/imx6ul_ccm.c       |  6 ------
 hw/timer/imx_gpt.c         | 25 +++++++++++++++++++++++++
 4 files changed, 27 insertions(+), 7 deletions(-)

diff --git a/include/hw/timer/imx_gpt.h b/include/hw/timer/imx_gpt.h
index XXXXXXX..XXXXXXX 100644
--- a/include/hw/timer/imx_gpt.h
+++ b/include/hw/timer/imx_gpt.h
@@ -XXX,XX +XXX,XX @@
 #define TYPE_IMX25_GPT "imx25.gpt"
 #define TYPE_IMX31_GPT "imx31.gpt"
 #define TYPE_IMX6_GPT "imx6.gpt"
+#define TYPE_IMX6UL_GPT "imx6ul.gpt"
 #define TYPE_IMX7_GPT "imx7.gpt"
 
 #define TYPE_IMX_GPT TYPE_IMX25_GPT
diff --git a/hw/arm/fsl-imx6ul.c b/hw/arm/fsl-imx6ul.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/arm/fsl-imx6ul.c
+++ b/hw/arm/fsl-imx6ul.c
@@ -XXX,XX +XXX,XX @@ static void fsl_imx6ul_init(Object *obj)
      */
     for (i = 0; i < FSL_IMX6UL_NUM_GPTS; i++) {
         snprintf(name, NAME_SIZE, "gpt%d", i);
-        object_initialize_child(obj, name, &s->gpt[i], TYPE_IMX7_GPT);
+        object_initialize_child(obj, name, &s->gpt[i], TYPE_IMX6UL_GPT);
     }
 
     /*
diff --git a/hw/misc/imx6ul_ccm.c b/hw/misc/imx6ul_ccm.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/misc/imx6ul_ccm.c
+++ b/hw/misc/imx6ul_ccm.c
@@ -XXX,XX +XXX,XX @@ static uint32_t imx6ul_ccm_get_clock_frequency(IMXCCMState *dev, IMXClk clock)
     case CLK_32k:
         freq = CKIL_FREQ;
         break;
-    case CLK_HIGH:
-        freq = CKIH_FREQ;
-        break;
-    case CLK_HIGH_DIV:
-        freq = CKIH_FREQ / 8;
-        break;
     default:
         qemu_log_mask(LOG_GUEST_ERROR, "[%s]%s: unsupported clock %d\n",
                       TYPE_IMX6UL_CCM, __func__, clock);
diff --git a/hw/timer/imx_gpt.c b/hw/timer/imx_gpt.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/timer/imx_gpt.c
+++ b/hw/timer/imx_gpt.c
@@ -XXX,XX +XXX,XX @@ static const IMXClk imx6_gpt_clocks[] = {
     CLK_HIGH,      /* 111 reference clock */
 };
 
+static const IMXClk imx6ul_gpt_clocks[] = {
+    CLK_NONE,      /* 000 No clock source */
+    CLK_IPG,       /* 001 ipg_clk, 532MHz*/
+    CLK_IPG_HIGH,  /* 010 ipg_clk_highfreq */
+    CLK_EXT,       /* 011 External clock */
+    CLK_32k,       /* 100 ipg_clk_32k */
+    CLK_NONE,      /* 101 not defined */
+    CLK_NONE,      /* 110 not defined */
+    CLK_NONE,      /* 111 not defined */
+};
+
 static const IMXClk imx7_gpt_clocks[] = {
     CLK_NONE,      /* 000 No clock source */
     CLK_IPG,       /* 001 ipg_clk, 532MHz*/
@@ -XXX,XX +XXX,XX @@ static void imx6_gpt_init(Object *obj)
     s->clocks = imx6_gpt_clocks;
 }
 
+static void imx6ul_gpt_init(Object *obj)
+{
+    IMXGPTState *s = IMX_GPT(obj);
+
+    s->clocks = imx6ul_gpt_clocks;
+}
+
 static void imx7_gpt_init(Object *obj)
 {
     IMXGPTState *s = IMX_GPT(obj);
@@ -XXX,XX +XXX,XX @@ static const TypeInfo imx6_gpt_info = {
     .instance_init = imx6_gpt_init,
 };
 
+static const TypeInfo imx6ul_gpt_info = {
+    .name = TYPE_IMX6UL_GPT,
+    .parent = TYPE_IMX25_GPT,
+    .instance_init = imx6ul_gpt_init,
+};
+
 static const TypeInfo imx7_gpt_info = {
     .name = TYPE_IMX7_GPT,
     .parent = TYPE_IMX25_GPT,
@@ -XXX,XX +XXX,XX @@ static void imx_gpt_register_types(void)
     type_register_static(&imx25_gpt_info);
     type_register_static(&imx31_gpt_info);
     type_register_static(&imx6_gpt_info);
+    type_register_static(&imx6ul_gpt_info);
     type_register_static(&imx7_gpt_info);
 }
 
-- 
2.25.1

From: Jean-Christophe Dubois <jcd@tribudubois.net>

IRQs were not associated to the various GPIO devices inside i.MX7D.
This patch brings the i.MX7D on par with i.MX6.

Signed-off-by: Jean-Christophe Dubois <jcd@tribudubois.net>
Message-id: 20221226101418.415170-1-jcd@tribudubois.net
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 include/hw/arm/fsl-imx7.h | 15 +++++++++++++++
 hw/arm/fsl-imx7.c         | 31 ++++++++++++++++++++++++++++++-
 2 files changed, 45 insertions(+), 1 deletion(-)

diff --git a/include/hw/arm/fsl-imx7.h b/include/hw/arm/fsl-imx7.h
index XXXXXXX..XXXXXXX 100644
--- a/include/hw/arm/fsl-imx7.h
+++ b/include/hw/arm/fsl-imx7.h
@@ -XXX,XX +XXX,XX @@ enum FslIMX7IRQs {
     FSL_IMX7_GPT3_IRQ     = 53,
     FSL_IMX7_GPT4_IRQ     = 52,
 
+    FSL_IMX7_GPIO1_LOW_IRQ  = 64,
+    FSL_IMX7_GPIO1_HIGH_IRQ = 65,
+    FSL_IMX7_GPIO2_LOW_IRQ  = 66,
+    FSL_IMX7_GPIO2_HIGH_IRQ = 67,
+    FSL_IMX7_GPIO3_LOW_IRQ  = 68,
+    FSL_IMX7_GPIO3_HIGH_IRQ = 69,
+    FSL_IMX7_GPIO4_LOW_IRQ  = 70,
+    FSL_IMX7_GPIO4_HIGH_IRQ = 71,
+    FSL_IMX7_GPIO5_LOW_IRQ  = 72,
+    FSL_IMX7_GPIO5_HIGH_IRQ = 73,
+    FSL_IMX7_GPIO6_LOW_IRQ  = 74,
+    FSL_IMX7_GPIO6_HIGH_IRQ = 75,
+    FSL_IMX7_GPIO7_LOW_IRQ  = 76,
+    FSL_IMX7_GPIO7_HIGH_IRQ = 77,
+
     FSL_IMX7_WDOG1_IRQ    = 78,
     FSL_IMX7_WDOG2_IRQ    = 79,
     FSL_IMX7_WDOG3_IRQ    = 10,
diff --git a/hw/arm/fsl-imx7.c b/hw/arm/fsl-imx7.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/arm/fsl-imx7.c
+++ b/hw/arm/fsl-imx7.c
@@ -XXX,XX +XXX,XX @@ static void fsl_imx7_realize(DeviceState *dev, Error **errp)
             FSL_IMX7_GPIO7_ADDR,
         };
 
+        static const int FSL_IMX7_GPIOn_LOW_IRQ[FSL_IMX7_NUM_GPIOS] = {
+            FSL_IMX7_GPIO1_LOW_IRQ,
+            FSL_IMX7_GPIO2_LOW_IRQ,
+            FSL_IMX7_GPIO3_LOW_IRQ,
+            FSL_IMX7_GPIO4_LOW_IRQ,
+            FSL_IMX7_GPIO5_LOW_IRQ,
+            FSL_IMX7_GPIO6_LOW_IRQ,
+            FSL_IMX7_GPIO7_LOW_IRQ,
+        };
+
+        static const int FSL_IMX7_GPIOn_HIGH_IRQ[FSL_IMX7_NUM_GPIOS] = {
+            FSL_IMX7_GPIO1_HIGH_IRQ,
+            FSL_IMX7_GPIO2_HIGH_IRQ,
+            FSL_IMX7_GPIO3_HIGH_IRQ,
+            FSL_IMX7_GPIO4_HIGH_IRQ,
+            FSL_IMX7_GPIO5_HIGH_IRQ,
+            FSL_IMX7_GPIO6_HIGH_IRQ,
+            FSL_IMX7_GPIO7_HIGH_IRQ,
+        };
+
         sysbus_realize(SYS_BUS_DEVICE(&s->gpio[i]), &error_abort);
-        sysbus_mmio_map(SYS_BUS_DEVICE(&s->gpio[i]), 0, FSL_IMX7_GPIOn_ADDR[i]);
+        sysbus_mmio_map(SYS_BUS_DEVICE(&s->gpio[i]), 0,
+                        FSL_IMX7_GPIOn_ADDR[i]);
+
+        sysbus_connect_irq(SYS_BUS_DEVICE(&s->gpio[i]), 0,
+                           qdev_get_gpio_in(DEVICE(&s->a7mpcore),
+                                            FSL_IMX7_GPIOn_LOW_IRQ[i]));
+
+        sysbus_connect_irq(SYS_BUS_DEVICE(&s->gpio[i]), 1,
+                           qdev_get_gpio_in(DEVICE(&s->a7mpcore),
+                                            FSL_IMX7_GPIOn_HIGH_IRQ[i]));
     }
 
     /*
-- 
2.25.1

From: Stephen Longfield <slongfield@google.com>

Size is used at lines 1088/1188 for the loop, which reads the last 4
bytes from the crc_ptr so it does need to get increased, however it
shouldn't be increased before the buffer is passed to CRC computation,
or the crc32 function will access uninitialized memory.

This was pointed out to me by clg@kaod.org during the code review of
a similar patch to hw/net/ftgmac100.c

Change-Id: Ib0464303b191af1e28abeb2f5105eb25aadb5e9b
Signed-off-by: Stephen Longfield <slongfield@google.com>
Reviewed-by: Patrick Venture <venture@google.com>
Message-id: 20221221183202.3788132-1-slongfield@google.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/net/imx_fec.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c
index XXXXXXX..XXXXXXX 100644
--- a/hw/net/imx_fec.c
+++ b/hw/net/imx_fec.c
@@ -XXX,XX +XXX,XX @@ static ssize_t imx_fec_receive(NetClientState *nc, const uint8_t *buf,
         return 0;
     }
 
-    /* 4 bytes for the CRC.  */
-    size += 4;
     crc = cpu_to_be32(crc32(~0, buf, size));
+    /* Increase size by 4, loop below reads the last 4 bytes from crc_ptr. */
+    size += 4;
     crc_ptr = (uint8_t *) &crc;
 
     /* Huge frames are truncated.  */
@@ -XXX,XX +XXX,XX @@ static ssize_t imx_enet_receive(NetClientState *nc, const uint8_t *buf,
         return 0;
     }
 
-    /* 4 bytes for the CRC.  */
-    size += 4;
     crc = cpu_to_be32(crc32(~0, buf, size));
+    /* Increase size by 4, loop below reads the last 4 bytes from crc_ptr. */
+    size += 4;
     crc_ptr = (uint8_t *) &crc;
 
     if (shift16) {
-- 
2.25.1