hw/pvrdma: Check the correct return value

[Qemu-devel] [PATCH] hw/pvrdma: Check the correct return value

Yuval Shaia posted 1 patch 7 years ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181025061700.17050-1-yuval.shaia@oracle.com

Test docker-clang@ubuntu passed

Test checkpatch passed

Test asan passed

Test docker-quick@centos7 passed

hw/rdma/vmw/pvrdma_cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] hw/pvrdma: Check the correct return value

Posted by Yuval Shaia 7 years ago

Return value of 0 means ok, we want to free the memory only in case of
error.

Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
---
 hw/rdma/vmw/pvrdma_cmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
index 4faeb21631..57d6f41ae6 100644
--- a/hw/rdma/vmw/pvrdma_cmd.c
+++ b/hw/rdma/vmw/pvrdma_cmd.c
@@ -232,7 +232,7 @@ static int create_mr(PVRDMADev *dev, union pvrdma_cmd_req *req,
                                      cmd->start, cmd->length, host_virt,
                                      cmd->access_flags, &resp->mr_handle,
                                      &resp->lkey, &resp->rkey);
-    if (host_virt && !resp->hdr.err) {
+    if (resp->hdr.err && host_virt) {
         munmap(host_virt, cmd->length);
     }
 
-- 
2.17.2

Re: [Qemu-devel] [PATCH] hw/pvrdma: Check the correct return value

Posted by Marcel Apfelbaum 7 years ago


On 10/25/18 9:17 AM, Yuval Shaia wrote:
> Return value of 0 means ok, we want to free the memory only in case of
> error.
>
> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
> ---
>   hw/rdma/vmw/pvrdma_cmd.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
> index 4faeb21631..57d6f41ae6 100644
> --- a/hw/rdma/vmw/pvrdma_cmd.c
> +++ b/hw/rdma/vmw/pvrdma_cmd.c
> @@ -232,7 +232,7 @@ static int create_mr(PVRDMADev *dev, union pvrdma_cmd_req *req,
>                                        cmd->start, cmd->length, host_virt,
>                                        cmd->access_flags, &resp->mr_handle,
>                                        &resp->lkey, &resp->rkey);
> -    if (host_virt && !resp->hdr.err) {
> +    if (resp->hdr.err && host_virt) {
>           munmap(host_virt, cmd->length);
>       }
>   

Reviewed-by: Marcel Apfelbaum<marcel.apfelbaum@gmail.com>

Thanks,
Marcel