SDL: set a hint to not bypass the window compositor

[Qemu-devel] [PATCH] SDL: set a hint to not bypass the window compositor

Sebastian Krzyszkowiak posted 1 patch 7 years ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181024143748.4425-1-dos@dosowisko.net

Test docker-clang@ubuntu passed

Test checkpatch passed

Test asan passed

Test docker-mingw@fedora failed

Test docker-quick@centos7 passed

ui/sdl2.c | 3 +++
1 file changed, 3 insertions(+)

Expand all Fold all

[Qemu-devel] [PATCH] SDL: set a hint to not bypass the window compositor

Posted by Sebastian Krzyszkowiak 7 years ago

Without that, window effects in KWin get suspended as soon as any
qemu-sdl window becomes visible. While the SDL default makes sense
for games, it's not really suitable for QEMU.

Signed-off-by: Sebastian Krzyszkowiak <dos@dosowisko.net>
---
 ui/sdl2.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/ui/sdl2.c b/ui/sdl2.c
index 2696b95c79..a10b6e3a08 100644
--- a/ui/sdl2.c
+++ b/ui/sdl2.c
@@ -786,6 +786,9 @@ static void sdl2_display_init(DisplayState *ds, DisplayOptions *o)
                 SDL_GetError());
         exit(1);
     }
+#ifdef SDL_HINT_VIDEO_X11_NET_WM_BYPASS_COMPOSITOR /* only available since SDL 2.0.8 */
+    SDL_SetHint(SDL_HINT_VIDEO_X11_NET_WM_BYPASS_COMPOSITOR, "0");
+#endif
     SDL_SetHint(SDL_HINT_GRAB_KEYBOARD, "1");
     memset(&info, 0, sizeof(info));
     SDL_VERSION(&info.version);
-- 
2.19.1

Re: [Qemu-devel] [PATCH] SDL: set a hint to not bypass the window compositor

Posted by Gerd Hoffmann 7 years ago

On Wed, Oct 24, 2018 at 04:37:48PM +0200, Sebastian Krzyszkowiak wrote:
> Without that, window effects in KWin get suspended as soon as any
> qemu-sdl window becomes visible. While the SDL default makes sense
> for games, it's not really suitable for QEMU.
> 
> Signed-off-by: Sebastian Krzyszkowiak <dos@dosowisko.net>

Added to UI patch queue.

thanks,
  Gerd