disas/mips: Increase 'member of ISAs' flag holder size

[Qemu-devel] [PATCH] disas/mips: Increase 'member of ISAs' flag holder size

Philippe Mathieu-Daudé posted 1 patch 7 years ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181024105733.18605-1-f4bug@amsat.org

Test docker-clang@ubuntu passed

Test checkpatch passed

Test asan passed

Test docker-mingw@fedora failed

Test docker-quick@centos7 passed

disas/mips.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] disas/mips: Increase 'member of ISAs' flag holder size

Posted by Philippe Mathieu-Daudé 7 years ago

Increase the size of 'membership' holder size to 64 bits. This is
needed for future extensions since existing bits are almost all used.
(This change is related to f9c9cd63e3),

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 disas/mips.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/disas/mips.c b/disas/mips.c
index 97f661a37e..d73d4094d8 100644
--- a/disas/mips.c
+++ b/disas/mips.c
@@ -301,7 +301,7 @@ struct mips_opcode
   unsigned long pinfo2;
   /* A collection of bits describing the instruction sets of which this
      instruction or macro is a member. */
-  unsigned long membership;
+  uint64_t membership;
 };
 
 /* These are the characters which may appear in the args field of an
-- 
2.19.1

Re: [Qemu-devel] [PATCH] disas/mips: Increase 'member of ISAs' flag holder size

Posted by Richard Henderson 7 years ago

On 10/24/18 11:57 AM, Philippe Mathieu-Daudé wrote:
> Increase the size of 'membership' holder size to 64 bits. This is
> needed for future extensions since existing bits are almost all used.
> (This change is related to f9c9cd63e3),
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  disas/mips.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~

Re: [Qemu-devel] [PATCH] disas/mips: Increase 'member of ISAs' flag holder size

Posted by Fredrik Noring 7 years ago

Hi Philippe,

On Wed, Oct 24, 2018 at 12:57:32PM +0200, Philippe Mathieu-Daudé wrote:
> Increase the size of 'membership' holder size to 64 bits. This is
> needed for future extensions since existing bits are almost all used.
> (This change is related to f9c9cd63e3),

I'm queueing your patch to amend the support for the R5900, based on
Aleksandar's latest v2 tag:

https://github.com/AMarkovic/qemu tags/mips-queue-oct-2018-part-2-v2

> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  disas/mips.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/disas/mips.c b/disas/mips.c
> index 97f661a37e..d73d4094d8 100644
> --- a/disas/mips.c
> +++ b/disas/mips.c
> @@ -301,7 +301,7 @@ struct mips_opcode
>    unsigned long pinfo2;
>    /* A collection of bits describing the instruction sets of which this
>       instruction or macro is a member. */
> -  unsigned long membership;
> +  uint64_t membership;
>  };
>  
>  /* These are the characters which may appear in the args field of an
> -- 
> 2.19.1
>