[Qemu-devel] [PATCH] qapi: Fix COLOStatus and query-colo-status since version

Zhang Chen posted 1 patch 7 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181022164118.5502-1-zhangckid@gmail.com
Test docker-clang@ubuntu passed
Test checkpatch passed
Test asan passed
Test docker-mingw@fedora failed
Test docker-quick@centos7 passed
qapi/migration.json | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[Qemu-devel] [PATCH] qapi: Fix COLOStatus and query-colo-status since version
Posted by Zhang Chen 7 years ago
This structure and command have missed qemu version 3.0, so fix it to since version 3.1.

Signed-off-by: Zhang Chen <zhangckid@gmail.com>
---
 qapi/migration.json | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/qapi/migration.json b/qapi/migration.json
index 0928f4b727..38d4c41d88 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -1317,7 +1317,7 @@
 #
 # @reason: describes the reason for the COLO exit.
 #
-# Since: 3.0
+# Since: 3.1
 ##
 { 'struct': 'COLOStatus',
   'data': { 'mode': 'COLOMode', 'reason': 'COLOExitReason' } }
@@ -1334,7 +1334,7 @@
 # -> { "execute": "query-colo-status" }
 # <- { "return": { "mode": "primary", "active": true, "reason": "request" } }
 #
-# Since: 3.0
+# Since: 3.1
 ##
 { 'command': 'query-colo-status',
   'returns': 'COLOStatus' }
-- 
2.17.GIT


Re: [Qemu-devel] [PATCH] qapi: Fix COLOStatus and query-colo-status since version
Posted by Eric Blake 7 years ago
On 10/22/18 5:41 PM, Zhang Chen wrote:
> This structure and command have missed qemu version 3.0, so fix it to since version 3.1.
> 
> Signed-off-by: Zhang Chen <zhangckid@gmail.com>
> ---
>   qapi/migration.json | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 0928f4b727..38d4c41d88 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1317,7 +1317,7 @@
>   #
>   # @reason: describes the reason for the COLO exit.
>   #
> -# Since: 3.0
> +# Since: 3.1
>   ##
>   { 'struct': 'COLOStatus',
>     'data': { 'mode': 'COLOMode', 'reason': 'COLOExitReason' } }
> @@ -1334,7 +1334,7 @@
>   # -> { "execute": "query-colo-status" }
>   # <- { "return": { "mode": "primary", "active": true, "reason": "request" } }
>   #
> -# Since: 3.0
> +# Since: 3.1
>   ##
>   { 'command': 'query-colo-status',
>     'returns': 'COLOStatus' }
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH] qapi: Fix COLOStatus and query-colo-status since version
Posted by Dr. David Alan Gilbert 7 years ago
* Zhang Chen (zhangckid@gmail.com) wrote:
> This structure and command have missed qemu version 3.0, so fix it to since version 3.1.
> 
> Signed-off-by: Zhang Chen <zhangckid@gmail.com>

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> ---
>  qapi/migration.json | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 0928f4b727..38d4c41d88 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1317,7 +1317,7 @@
>  #
>  # @reason: describes the reason for the COLO exit.
>  #
> -# Since: 3.0
> +# Since: 3.1
>  ##
>  { 'struct': 'COLOStatus',
>    'data': { 'mode': 'COLOMode', 'reason': 'COLOExitReason' } }
> @@ -1334,7 +1334,7 @@
>  # -> { "execute": "query-colo-status" }
>  # <- { "return": { "mode": "primary", "active": true, "reason": "request" } }
>  #
> -# Since: 3.0
> +# Since: 3.1
>  ##
>  { 'command': 'query-colo-status',
>    'returns': 'COLOStatus' }
> -- 
> 2.17.GIT
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

Re: [Qemu-devel] [PATCH] qapi: Fix COLOStatus and query-colo-status since version
Posted by Dr. David Alan Gilbert 7 years ago
* Zhang Chen (zhangckid@gmail.com) wrote:
> This structure and command have missed qemu version 3.0, so fix it to since version 3.1.
> 
> Signed-off-by: Zhang Chen <zhangckid@gmail.com>

Queued

> ---
>  qapi/migration.json | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 0928f4b727..38d4c41d88 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -1317,7 +1317,7 @@
>  #
>  # @reason: describes the reason for the COLO exit.
>  #
> -# Since: 3.0
> +# Since: 3.1
>  ##
>  { 'struct': 'COLOStatus',
>    'data': { 'mode': 'COLOMode', 'reason': 'COLOExitReason' } }
> @@ -1334,7 +1334,7 @@
>  # -> { "execute": "query-colo-status" }
>  # <- { "return": { "mode": "primary", "active": true, "reason": "request" } }
>  #
> -# Since: 3.0
> +# Since: 3.1
>  ##
>  { 'command': 'query-colo-status',
>    'returns': 'COLOStatus' }
> -- 
> 2.17.GIT
> 
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK