vga_int: remove unused function protype

[Qemu-devel] [PATCH] vga_int: remove unused function protype

Posted by yuchenlin--- via Qemu-devel 7 years ago

From: yuchenlin <yuchenlin@synology.com>

Signed-off-by: yuchenlin <yuchenlin@synology.com>
---
 hw/display/vga_int.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/display/vga_int.h b/hw/display/vga_int.h
index 6e4fa48a79..55c418eab5 100644
--- a/hw/display/vga_int.h
+++ b/hw/display/vga_int.h
@@ -166,7 +166,6 @@ MemoryRegion *vga_init_io(VGACommonState *s, Object *obj,
                           const MemoryRegionPortio **vbe_ports);
 void vga_common_reset(VGACommonState *s);
 
-void vga_sync_dirty_bitmap(VGACommonState *s);
 void vga_dirty_log_start(VGACommonState *s);
 void vga_dirty_log_stop(VGACommonState *s);
 
-- 
2.18.0

Re: [Qemu-devel] [PATCH] vga_int: remove unused function protype

Posted by Philippe Mathieu-Daudé 7 years ago

On 22/10/18 10:00, yuchenlin--- via Qemu-devel wrote:
> From: yuchenlin <yuchenlin@synology.com>
> 
> Signed-off-by: yuchenlin <yuchenlin@synology.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>   hw/display/vga_int.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/hw/display/vga_int.h b/hw/display/vga_int.h
> index 6e4fa48a79..55c418eab5 100644
> --- a/hw/display/vga_int.h
> +++ b/hw/display/vga_int.h
> @@ -166,7 +166,6 @@ MemoryRegion *vga_init_io(VGACommonState *s, Object *obj,
>                             const MemoryRegionPortio **vbe_ports);
>   void vga_common_reset(VGACommonState *s);
>   
> -void vga_sync_dirty_bitmap(VGACommonState *s);
>   void vga_dirty_log_start(VGACommonState *s);
>   void vga_dirty_log_stop(VGACommonState *s);
>   
>

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vga_int: remove unused function protype

Posted by Laurent Vivier 7 years ago

On 23/10/2018 00:45, Philippe Mathieu-Daudé wrote:
> On 22/10/18 10:00, yuchenlin--- via Qemu-devel wrote:
>> From: yuchenlin <yuchenlin@synology.com>
>>
>> Signed-off-by: yuchenlin <yuchenlin@synology.com>
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> 

Applied,

Thanks,
Laurent

Re: [Qemu-devel] [PATCH] vga_int: remove unused function protype

Posted by Gerd Hoffmann 7 years ago

On Mon, Oct 22, 2018 at 04:00:53PM +0800, yuchenlin@synology.com wrote:
> From: yuchenlin <yuchenlin@synology.com>
> 
> Signed-off-by: yuchenlin <yuchenlin@synology.com>
> ---
>  hw/display/vga_int.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/display/vga_int.h b/hw/display/vga_int.h
> index 6e4fa48a79..55c418eab5 100644
> --- a/hw/display/vga_int.h
> +++ b/hw/display/vga_int.h
> @@ -166,7 +166,6 @@ MemoryRegion *vga_init_io(VGACommonState *s, Object *obj,
>                            const MemoryRegionPortio **vbe_ports);
>  void vga_common_reset(VGACommonState *s);
>  
> -void vga_sync_dirty_bitmap(VGACommonState *s);
>  void vga_dirty_log_start(VGACommonState *s);
>  void vga_dirty_log_stop(VGACommonState *s);

Added to vga queue.

thanks,
  Gerd

Re: [Qemu-devel] [PATCH] vga_int: remove unused function protype

Posted by yuchenlin via Qemu-devel 7 years ago

On 2018-10-29 17:44, Gerd Hoffmann wrote:
> On Mon, Oct 22, 2018 at 04:00:53PM +0800, yuchenlin@synology.com wrote:
>> From: yuchenlin <yuchenlin@synology.com>
>> 
>> Signed-off-by: yuchenlin <yuchenlin@synology.com>
>> ---
>>  hw/display/vga_int.h | 1 -
>>  1 file changed, 1 deletion(-)
>> 
>> diff --git a/hw/display/vga_int.h b/hw/display/vga_int.h
>> index 6e4fa48a79..55c418eab5 100644
>> --- a/hw/display/vga_int.h
>> +++ b/hw/display/vga_int.h
>> @@ -166,7 +166,6 @@ MemoryRegion *vga_init_io(VGACommonState *s, 
>> Object *obj,
>>                            const MemoryRegionPortio **vbe_ports);
>>  void vga_common_reset(VGACommonState *s);
>> 
>> -void vga_sync_dirty_bitmap(VGACommonState *s);
>>  void vga_dirty_log_start(VGACommonState *s);
>>  void vga_dirty_log_stop(VGACommonState *s);
> 
> Added to vga queue.
> 
> thanks,
>   Gerd

Hi, Gerd

Laurent has sent a pull request for this trivial commit.
See: 
http://lists.nongnu.org/archive/html/qemu-devel/2018-10/msg05896.html

Thanks,
yuchenlin