[Qemu-devel] [PATCH v2 2/5] chardev: Indent list of chardevs

Max Reitz posted 5 patches 7 years, 3 months ago
[Qemu-devel] [PATCH v2 2/5] chardev: Indent list of chardevs
Posted by Max Reitz 7 years, 3 months ago
Following the example of qemu_opts_print_help(), indent all entries in
the list of character devices.

Signed-off-by: Max Reitz <mreitz@redhat.com>
---
 chardev/char.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/chardev/char.c b/chardev/char.c
index e115166995..10d44aaefc 100644
--- a/chardev/char.c
+++ b/chardev/char.c
@@ -569,7 +569,7 @@ help_string_append(const char *name, void *opaque)
 {
     GString *str = opaque;
 
-    g_string_append_printf(str, "\n%s", name);
+    g_string_append_printf(str, "\n  %s", name);
 }
 
 static const char *chardev_alias_translate(const char *name)
-- 
2.17.1


Re: [Qemu-devel] [PATCH v2 2/5] chardev: Indent list of chardevs
Posted by Marc-André Lureau 7 years, 3 months ago
On Fri, Oct 19, 2018 at 8:49 PM Max Reitz <mreitz@redhat.com> wrote:
>
> Following the example of qemu_opts_print_help(), indent all entries in
> the list of character devices.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

> ---
>  chardev/char.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/chardev/char.c b/chardev/char.c
> index e115166995..10d44aaefc 100644
> --- a/chardev/char.c
> +++ b/chardev/char.c
> @@ -569,7 +569,7 @@ help_string_append(const char *name, void *opaque)
>  {
>      GString *str = opaque;
>
> -    g_string_append_printf(str, "\n%s", name);
> +    g_string_append_printf(str, "\n  %s", name);
>  }
>
>  static const char *chardev_alias_translate(const char *name)
> --
> 2.17.1
>