[v3] chardev: Add websocket support

[Qemu-devel] [PATCH v3 0/3] chardev: Add websocket support

Julia Suvorova via Qemu-devel posted 3 patches 5 years, 6 months ago

Diff against v1 v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181018223501.21683-1-jusual@mail.ru

Test docker-clang@ubuntu passed

Test checkpatch passed

Test asan passed

Test docker-mingw@fedora failed

Test docker-quick@centos7 passed

chardev/char-socket.c | 117 ++++++++++++++++++++++++++++-----------
chardev/char.c        |   8 ++-
qapi/char.json        |   3 +
qemu-options.hx       |  13 ++++-
tests/test-char.c     | 125 ++++++++++++++++++++++++++++++++++++++++++
5 files changed, 231 insertions(+), 35 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v3 0/3] chardev: Add websocket support

Posted by Julia Suvorova via Qemu-devel 5 years, 6 months ago

v3:
    * Refactoring moved to a separate patch [Daniel]
    * "websock" option renamed to "websocket" [Stefan]
    * Added documentation [Daniel]
v2:
    * Fixed initialization order [Daniel]
    * Function arguments refactoring [Paolo]
    * Added test [Stefan]
    * Added meaningful error message [Stefan]
    * Added "websock:" URI prefix support

Julia Suvorova (3):
  chardev/char-socket: Function headers refactoring
  chardev: Add websocket support
  tests/test-char: Check websocket chardev functionality

 chardev/char-socket.c | 117 ++++++++++++++++++++++++++++-----------
 chardev/char.c        |   8 ++-
 qapi/char.json        |   3 +
 qemu-options.hx       |  13 ++++-
 tests/test-char.c     | 125 ++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 231 insertions(+), 35 deletions(-)

-- 
2.17.1

Re: [Qemu-devel] [PATCH v3 0/3] chardev: Add websocket support

Posted by Stefan Hajnoczi 5 years, 6 months ago

On Fri, Oct 19, 2018 at 01:34:58AM +0300, Julia Suvorova wrote:
> v3:
>     * Refactoring moved to a separate patch [Daniel]
>     * "websock" option renamed to "websocket" [Stefan]
>     * Added documentation [Daniel]
> v2:
>     * Fixed initialization order [Daniel]
>     * Function arguments refactoring [Paolo]
>     * Added test [Stefan]
>     * Added meaningful error message [Stefan]
>     * Added "websock:" URI prefix support
> 
> Julia Suvorova (3):
>   chardev/char-socket: Function headers refactoring
>   chardev: Add websocket support
>   tests/test-char: Check websocket chardev functionality
> 
>  chardev/char-socket.c | 117 ++++++++++++++++++++++++++++-----------
>  chardev/char.c        |   8 ++-
>  qapi/char.json        |   3 +
>  qemu-options.hx       |  13 ++++-
>  tests/test-char.c     | 125 ++++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 231 insertions(+), 35 deletions(-)
> 
> -- 
> 2.17.1
> 

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>