nvdimm: Add docs hint for Linux driver name

[Qemu-devel] [PATCH] nvdimm: Add docs hint for Linux driver name

Kees Cook posted 1 patch 5 years, 6 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181018201351.GA25286@beast

Test docker-clang@ubuntu passed

Test checkpatch passed

Test asan passed

Test docker-mingw@fedora failed

Test docker-quick@centos7 passed

docs/nvdimm.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH] nvdimm: Add docs hint for Linux driver name

Posted by Kees Cook 5 years, 6 months ago

I spent way too much time trying to figure out why the emulated NVDIMM
was missing under Linux. In an effort to help others who might be looking
for these kinds of things in the future, include a hint.

Signed-off-by: Kees Cook <keescook@chromium.org>
---
 docs/nvdimm.txt | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/docs/nvdimm.txt b/docs/nvdimm.txt
index 5f158a61708e..7231c2d78f65 100644
--- a/docs/nvdimm.txt
+++ b/docs/nvdimm.txt
@@ -49,8 +49,9 @@ Multiple vNVDIMM devices can be created if multiple pairs of "-object"
 and "-device" are provided.
 
 For above command line options, if the guest OS has the proper NVDIMM
-driver, it should be able to detect a NVDIMM device which is in the
-persistent memory mode and whose size is $NVDIMM_SIZE.
+driver (e.g. "CONFIG_ACPI_NFIT=y" under Linux), it should be able to
+detect a NVDIMM device which is in the persistent memory mode and whose
+size is $NVDIMM_SIZE.
 
 Note:
 
-- 
2.17.1


-- 
Kees Cook
Pixel Security

Re: [Qemu-devel] [PATCH] nvdimm: Add docs hint for Linux driver name

Posted by Stefan Hajnoczi 5 years, 6 months ago

On Thu, Oct 18, 2018 at 01:13:51PM -0700, Kees Cook wrote:
> I spent way too much time trying to figure out why the emulated NVDIMM
> was missing under Linux. In an effort to help others who might be looking
> for these kinds of things in the future, include a hint.
> 
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
>  docs/nvdimm.txt | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block

Stefan