vpc: Don't leak opts in vpc_open()

[Qemu-devel] [PATCH] vpc: Don't leak opts in vpc_open()

Kevin Wolf posted 1 patch 7 years ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181017133350.14351-1-kwolf@redhat.com

Test docker-clang@ubuntu passed

Test checkpatch passed

Test asan passed

Test docker-mingw@fedora failed

Test docker-quick@centos7 passed

block/vpc.c | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[Qemu-devel] [PATCH] vpc: Don't leak opts in vpc_open()

Posted by Kevin Wolf 7 years ago

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/vpc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/block/vpc.c b/block/vpc.c
index bf294abfa7..eace2ba484 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -454,10 +454,12 @@ static int vpc_open(BlockDriverState *bs, QDict *options, int flags,
     }
 
     qemu_co_mutex_init(&s->lock);
+    qemu_opts_del(opts);
 
     return 0;
 
 fail:
+    qemu_opts_del(opts);
     qemu_vfree(s->pagetable);
 #ifdef CACHE
     g_free(s->pageentry_u8);
-- 
2.19.1

Re: [Qemu-devel] [Qemu-block] [PATCH] vpc: Don't leak opts in vpc_open()

Posted by Alberto Garcia 7 years ago

On Wed 17 Oct 2018 03:33:50 PM CEST, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>

Reviewed-by: Alberto Garcia <berto@igalia.com>

Berto