[Qemu-devel] [PATCH v3 0/3] use object link instead of qdev property

Mao Zhongyi posted 3 patches 7 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20181015032642.16411-1-maozhongyi@cmss.chinamobile.com
Test docker-clang@ubuntu failed
Test checkpatch passed
Test asan passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 failed
There is a newer version of this series
hw/arm/musicpal.c          |  5 +++--
hw/audio/marvell_88w8618.c | 14 ++++++--------
include/hw/audio/wm8750.h  |  1 +
3 files changed, 10 insertions(+), 10 deletions(-)
[Qemu-devel] [PATCH v3 0/3] use object link instead of qdev property
Posted by Mao Zhongyi 7 years ago
According to qdev-properties.h, properties of pointer type
should be avoid, so convert qdev property to link, Whilst we
are here, also update some hardcoded strings with already
defineded macros.

v3:
-removed incorrected "To: xxx" tags from commit message
-keep 'dc->user_creatable = false' in mv88w8618_audio_class_init()

v2:
-removed the patch1
-removed the TYPE_name in VMStateDescription.name

Cc: Jan Kiszka <jan.kiszka@web.de>
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>

Mao Zhongyi (3):
  audio: use TYPE_WM8750 instead of a hardcoded string
  audio: use object link instead of qdev property to pass wm8750
    reference
  audio: use TYPE_MV88W8618_AUDIO instead of hardcoded string

 hw/arm/musicpal.c          |  5 +++--
 hw/audio/marvell_88w8618.c | 14 ++++++--------
 include/hw/audio/wm8750.h  |  1 +
 3 files changed, 10 insertions(+), 10 deletions(-)

-- 
2.17.1




Re: [Qemu-devel] [PATCH v3 0/3] use object link instead of qdev property
Posted by Gerd Hoffmann 7 years ago
On Mon, Oct 15, 2018 at 11:26:39AM +0800, Mao Zhongyi wrote:
> According to qdev-properties.h, properties of pointer type
> should be avoid, so convert qdev property to link, Whilst we
> are here, also update some hardcoded strings with already
> defineded macros.

Patch series breaks "make check".

cheers,
  Gerd


Re: [Qemu-devel] [PATCH v3 0/3] use object link instead of qdev property
Posted by maozy 7 years ago
Hi, Gerd

On 10/19/18 4:04 PM, Gerd Hoffmann wrote:
> On Mon, Oct 15, 2018 at 11:26:39AM +0800, Mao Zhongyi wrote:
>> According to qdev-properties.h, properties of pointer type
>> should be avoid, so convert qdev property to link, Whilst we
>> are here, also update some hardcoded strings with already
>> defineded macros.
> 
> Patch series breaks "make check".

Already fixed it in v4, please review.

Thanks,
mao

> 
> cheers,
>    Gerd
> 
>