chardev: Convert IO handlers to use unsigned type

[Qemu-devel] [PATCH v2 01/11] hw/ipmi: Remove unnecessary declarations

Posted by Philippe Mathieu-Daudé 7 years ago

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/ipmi/ipmi_bmc_extern.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c
index bf0b7ee0f5..8c78b9804b 100644
--- a/hw/ipmi/ipmi_bmc_extern.c
+++ b/hw/ipmi/ipmi_bmc_extern.c
@@ -85,10 +85,6 @@ typedef struct IPMIBmcExtern {
     bool send_reset;
 } IPMIBmcExtern;
 
-static int can_receive(void *opaque);
-static void receive(void *opaque, const uint8_t *buf, int size);
-static void chr_event(void *opaque, int event);
-
 static unsigned char
 ipmb_checksum(const unsigned char *data, int size, unsigned char start)
 {
-- 
2.17.1

Re: [Qemu-devel] [PATCH v2 01/11] hw/ipmi: Remove unnecessary declarations

Posted by Corey Minyard 7 years ago

On 10/11/2018 07:22 PM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>   hw/ipmi/ipmi_bmc_extern.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/hw/ipmi/ipmi_bmc_extern.c b/hw/ipmi/ipmi_bmc_extern.c
> index bf0b7ee0f5..8c78b9804b 100644
> --- a/hw/ipmi/ipmi_bmc_extern.c
> +++ b/hw/ipmi/ipmi_bmc_extern.c
> @@ -85,10 +85,6 @@ typedef struct IPMIBmcExtern {
>       bool send_reset;
>   } IPMIBmcExtern;
>   
> -static int can_receive(void *opaque);
> -static void receive(void *opaque, const uint8_t *buf, int size);
> -static void chr_event(void *opaque, int event);
> -
>   static unsigned char
>   ipmb_checksum(const unsigned char *data, int size, unsigned char start)
>   {

Looks good to me.  Thanks.

Acked-by: Corey Minyard <cminyard@mvista.com>